svn commit: r938090 - /wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
Author: jcompagner
Date: Mon Apr 26 15:22:56 2010
New Revision: 938090
URL: http://svn.apache.org/viewvc?rev=938090view=rev
Log:
small patch to be able to save your own positions
Modified:
wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
Modified:
wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js?rev=938090r1=938089r2=938090view=diff
==
---
wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
(original)
+++
wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
Mon Apr 26 15:22:56 2010
@@ -528,7 +528,10 @@ Wicket.Window.prototype = {
* Saves the position (and size if resizable) as a cookie.
*/
savePosition: function() {
-
+ savePositionAs(this.window.style.left, this.window.style.top,
this.window.style.width, this.content.style.height);
+ },
+
+ savePositionAs: function(x, y, width, height) {
if (typeof(this.settings.cookieId) != undefined
this.settings.cookieId != null) {
this.findPositionString(true);
@@ -541,10 +544,10 @@ Wicket.Window.prototype = {
var cookie = this.settings.cookieId;
cookie += ::;
- cookie += this.window.style.left + ,;
- cookie += this.window.style.top + ,;
- cookie += this.window.style.width + ,;
- cookie += this.content.style.height;
+ cookie += x + ,;
+ cookie += y + ,;
+ cookie += width + ,;
+ cookie += height;
var rest = Wicket.Cookie.get(this.cookieKey);
if (rest != null) {
[jira] Resolved: (WICKET-2846) Store Application in InheritableThreadLocal instead of ThreadLocal
[ https://issues.apache.org/jira/browse/WICKET-2846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-2846. --- Assignee: Igor Vaynberg Fix Version/s: 1.4.9 Resolution: Fixed Store Application in InheritableThreadLocal instead of ThreadLocal -- Key: WICKET-2846 URL: https://issues.apache.org/jira/browse/WICKET-2846 Project: Wicket Issue Type: Improvement Components: wicket Reporter: Alexandru Objelean Assignee: Igor Vaynberg Priority: Minor Fix For: 1.4.9 Is there any particular reason why Application class wouldn't be stored in InheritableThreadLocal instead of ThreadLocal? The problem is that I need to be able to access Application class from a thread created when a button is pressed. Using InheritableThreadLocal instead of ThreadLocal would solve this problem. Thanks! Alex -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r938144 - /wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/Palette.java
Author: ivaynberg
Date: Mon Apr 26 17:39:24 2010
New Revision: 938144
URL: http://svn.apache.org/viewvc?rev=938144view=rev
Log:
Issue: WICKET-2843
Modified:
wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/Palette.java
Modified:
wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/Palette.java
URL:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/Palette.java?rev=938144r1=938143r2=938144view=diff
==
---
wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/Palette.java
(original)
+++
wicket/branches/wicket-1.4.x/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/Palette.java
Mon Apr 26 17:39:24 2010
@@ -515,6 +515,7 @@ public class PaletteT extends Panel im
protected final void updateModel()
{
// prepare model
+ modelChanging();
CollectionT model = getModelCollection();
model.clear();
@@ -526,8 +527,10 @@ public class PaletteT extends Panel im
final T selectedChoice = it.next();
model.add(selectedChoice);
}
+ modelChanged();
- setDefaultModelObject(model);
+ // call model.setObject()
+ ((IModelObject) getDefaultModel()).setObject(model);
}
/**
[jira] Resolved: (WICKET-2843) Palette is incompatible with ListMultipleChoice in its use of the model
[ https://issues.apache.org/jira/browse/WICKET-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-2843. --- Assignee: Igor Vaynberg Fix Version/s: 1.4.9 1.5-M1 Resolution: Fixed Palette is incompatible with ListMultipleChoice in its use of the model --- Key: WICKET-2843 URL: https://issues.apache.org/jira/browse/WICKET-2843 Project: Wicket Issue Type: Bug Components: wicket-extensions Affects Versions: 1.4.7 Reporter: Frank van Lankvelt Assignee: Igor Vaynberg Priority: Minor Fix For: 1.4.9, 1.5-M1 Attachments: WICKET-2843.patch Palette, like the listmultiplechoice component, modifies the object (a list) in-place. Both components have the same behavior in their updateModel documentation, but the implementation differs. Whereas ListMultipleChoice invokes getModel().setObject(), Palette uses setDefaultModelObject(). This has the consequence that it never invokes the setObject method as that is guarded by a model comparator. Suggested fix is to use the same logic in both updateModel implementations. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2840) Remove final on AbstractRequestTargetUrlCodingStrategy#getMountPath()
[ https://issues.apache.org/jira/browse/WICKET-2840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-2840. --- Assignee: Igor Vaynberg Fix Version/s: 1.4.9 Resolution: Fixed Remove final on AbstractRequestTargetUrlCodingStrategy#getMountPath() - Key: WICKET-2840 URL: https://issues.apache.org/jira/browse/WICKET-2840 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.4.7 Reporter: Nicolas Richeton Assignee: Igor Vaynberg Fix For: 1.4.9 Could final be removed of AbstractRequestTargetUrlCodingStrategy#getMountPath() ? I have a usecase where I need to mount a same page on several paths depending on the locale : - the login page is mounted on /login when the site is in english, and /connexion when the site is in french - The inverse should return 404 - /login in french or /connexion in english - All links should link directly to the right page according to the site language The best way I found to implement this is to override AbstractRequestTargetUrlCodingStrategy#getMountPath() but because of the final qualifier, a lot of code has to be duplicated. Why is this method final and could it be removed ? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r938151 - in /wicket/trunk/wicket/src: main/java/org/apache/wicket/request/resource/ main/java/org/apache/wicket/util/resource/ test/java/org/apache/wicket/request/resource/ test/java/org/
Author: ivaynberg
Date: Mon Apr 26 17:50:00 2010
New Revision: 938151
URL: http://svn.apache.org/viewvc?rev=938151view=rev
Log:
ajax not working due to bugs in resource handling
Issue: WICKET-2839
Added:
wicket/trunk/wicket/src/test/java/org/apache/wicket/request/resource/
wicket/trunk/wicket/src/test/java/org/apache/wicket/request/resource/WriteCallbackTest.java
(with props)
wicket/trunk/wicket/src/test/java/org/apache/wicket/util/resource/UrlResourceStreamTest.java
(with props)
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/request/resource/AbstractResource.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/resource/UrlResourceStream.java
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/request/resource/AbstractResource.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/request/resource/AbstractResource.java?rev=938151r1=938150r2=938151view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/request/resource/AbstractResource.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/request/resource/AbstractResource.java
Mon Apr 26 17:50:00 2010
@@ -463,7 +463,7 @@ public abstract class AbstractResource i
@Override
public void write(byte[] b, int off, int len)
throws IOException
{
- if (off == 0 || len == b.length)
+ if (off == 0 len == b.length)
{
write(b);
}
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/resource/UrlResourceStream.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/util/resource/UrlResourceStream.java?rev=938151r1=938150r2=938151view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/resource/UrlResourceStream.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/resource/UrlResourceStream.java
Mon Apr 26 17:50:00 2010
@@ -193,26 +193,26 @@ public class UrlResourceStream extends A
@Override
public Time lastModifiedTime()
{
- if (file != null)
+ try
{
- // in case the file has been removed by now
- if (file.exists() == false)
+ if (file != null)
{
- return null;
- }
+ // in case the file has been removed by now
+ if (file.exists() == false)
+ {
+ return null;
+ }
- long lastModified = file.lastModified();
+ long lastModified = file.lastModified();
- // if last modified changed update content length and
last modified date
- if (lastModified != this.lastModified)
- {
- this.lastModified = lastModified;
- contentLength = (int)file.length();
+ // if last modified changed update content
length and last modified date
+ if (lastModified != this.lastModified)
+ {
+ this.lastModified = lastModified;
+ setContentLength();
+ }
}
- }
- else
- {
- try
+ else
{
long lastModified =
Connections.getLastModified(url);
@@ -221,31 +221,35 @@ public class UrlResourceStream extends A
{
this.lastModified = lastModified;
- URLConnection connection =
url.openConnection();
- contentLength =
connection.getContentLength();
- Connections.close(connection);
+ setContentLength();
}
}
- catch (IOException e)
+ return Time.milliseconds(lastModified);
+ }
+ catch (IOException e)
+ {
+ if (url.toString().indexOf(.jar!) = 0)
[jira] Resolved: (WICKET-2839) ajax not working due to bugs in resource handling
[ https://issues.apache.org/jira/browse/WICKET-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-2839. --- Assignee: Igor Vaynberg Fix Version/s: 1.5-M1 Resolution: Fixed ajax not working due to bugs in resource handling - Key: WICKET-2839 URL: https://issues.apache.org/jira/browse/WICKET-2839 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.5-M1 Reporter: Kent Tong Assignee: Igor Vaynberg Fix For: 1.5-M1 Attachments: patch.txt A couple of bugs were found that were preventing .js resources to be returned to the client correctly. One bug was returning the jar file size as the content length of the resource if it is in a jar file. The other was copying past a source buffer into the response. After fixing these bugs, the ajax functions in the trunk seems to be working. A patch is provided. Test cases included. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2834) TreeTable not show Date in PropertyTreeColumn
[ https://issues.apache.org/jira/browse/WICKET-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-2834. --- Assignee: Igor Vaynberg Resolution: Incomplete please provide a quickstart that reproduces the problem and reopen the issue TreeTable not show Date in PropertyTreeColumn - Key: WICKET-2834 URL: https://issues.apache.org/jira/browse/WICKET-2834 Project: Wicket Issue Type: Bug Components: wicket-extensions Affects Versions: 1.4.7 Environment: Ubuntu 9.10 English, Netbeans 6.8, java6, on HP midtower core 2 duo. The server is the same but the locale is Latinamerica (Spanish). Reporter: Gabriel Jijon Assignee: Igor Vaynberg Priority: Minor Original Estimate: 24h Remaining Estimate: 24h When I work with TreeTable Component I define a PropertyTreeColumn (in IColumn) and a propertyExpression, well, this propertyExpresion is userObject.titulo. That expression represent a date. When server render the page didn't show treetable (neither the icons and text) but in the server machine or in other machine on the network with same configuration works fine. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2846) Store Application in InheritableThreadLocal instead of ThreadLocal
[ https://issues.apache.org/jira/browse/WICKET-2846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12861013#action_12861013 ] Alexandru Objelean commented on WICKET-2846: Hi Igor! Thanks for the fix. I have a question, why this fix is not a part of 1.4.8 release? Store Application in InheritableThreadLocal instead of ThreadLocal -- Key: WICKET-2846 URL: https://issues.apache.org/jira/browse/WICKET-2846 Project: Wicket Issue Type: Improvement Components: wicket Reporter: Alexandru Objelean Assignee: Igor Vaynberg Priority: Minor Fix For: 1.4.9 Is there any particular reason why Application class wouldn't be stored in InheritableThreadLocal instead of ThreadLocal? The problem is that I need to be able to access Application class from a thread created when a button is pressed. Using InheritableThreadLocal instead of ThreadLocal would solve this problem. Thanks! Alex -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2808) Wrong dates with StyleDateConverter with Format M-
[ https://issues.apache.org/jira/browse/WICKET-2808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-2808. --- Assignee: Igor Vaynberg Resolution: Won't Fix we are limited in terms of what YUI calendar understand, please do not use the shortcut formats. Wrong dates with StyleDateConverter with Format M- - Key: WICKET-2808 URL: https://issues.apache.org/jira/browse/WICKET-2808 Project: Wicket Issue Type: Bug Components: wicket-datetime Affects Versions: 1.4.7 Environment: Windows, Tomcat Reporter: Peter Diefenthäler Assignee: Igor Vaynberg Using a Date Text Field with StyleDateConverter and Formatstring M_ like DateTextField datehField = (new DateTextField(cdate, new PropertyModelDate(this, cDate), new StyleDateConverter(S-, true))); results in a wrong Date: Entering 12.12.12 results in 14.12.0012. The Day is wrong and the year should be 2012. Entering 12.12.2012 results in a correct date. If you use the Format option S-, both date conversions look fine. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2620) DataTable generates two thead wicket:id=topToolbars
[
https://issues.apache.org/jira/browse/WICKET-2620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12861020#action_12861020
]
James Carman commented on WICKET-2620:
--
I believe the fix for this issue has caused a regression in my code. I have a
custom subclass of DataTable with markup:
wicket:panel
span wicket:id=topToolbars
span wicket:id=toolbar/span
/span
tr wicket:id=rows
td wicket:id=cells
span wicket:id=cell[cell]/span
/td
/tr
span wicket:id=bottomToolbars
span wicket:id=toolbar/span
/span
/wicket:panel
In 1.4.6, my page fails to render. In 1.4.5, it works fine.
DataTable generates two thead wicket:id=topToolbars
---
Key: WICKET-2620
URL: https://issues.apache.org/jira/browse/WICKET-2620
Project: Wicket
Issue Type: Bug
Components: wicket-extensions
Affects Versions: 1.4.3
Reporter: Stefan Schueffler
Assignee: Juergen Donnerstag
Priority: Minor
Fix For: 1.4.6, 1.5-M1
The tables generated by DataTable component in the current version of Wicket
(1.4.3) do not contain thead in the output HTML.
It was working correctly in wicket 1.4.0 but there were some changes to fix
other issues - see WICKET-2436
To replicate - launch the wicket-examples-1.4.3.war and look at the DataTable
example:
http://localhost:8081/wicket-examples-1.4.3/repeater/?wicket:bookmarkablePage=:org.apache.wicket.examples.repeater.DataTablePage
If you check the HTML source you will see it does not contain thead tag:
{html}
table class=dataview cellspacing=0
tr class=navigation
{html}
When you look at
http://www.wicket-library.com/wicket-examples/repeater/?wicket:bookmarkablePage=:org.apache.wicket.examples.repeater.DataTablePage
it shows:
{html}
table class=dataview cellspacing=0
thead
tr class=navigation
{html}
Must be a previous version? :-)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2834) TreeTable not show Date in PropertyTreeColumn
[ https://issues.apache.org/jira/browse/WICKET-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12861094#action_12861094 ] Gabriel Jijon commented on WICKET-2834: --- My mistake, the error comes with too long text fields. When the text of userObject is longer than the width of the column, text disappears and the icon that contains that node. TreeTable not show Date in PropertyTreeColumn - Key: WICKET-2834 URL: https://issues.apache.org/jira/browse/WICKET-2834 Project: Wicket Issue Type: Bug Components: wicket-extensions Affects Versions: 1.4.7 Environment: Ubuntu 9.10 English, Netbeans 6.8, java6, on HP midtower core 2 duo. The server is the same but the locale is Latinamerica (Spanish). Reporter: Gabriel Jijon Assignee: Igor Vaynberg Priority: Minor Original Estimate: 24h Remaining Estimate: 24h When I work with TreeTable Component I define a PropertyTreeColumn (in IColumn) and a propertyExpression, well, this propertyExpresion is userObject.titulo. That expression represent a date. When server render the page didn't show treetable (neither the icons and text) but in the server machine or in other machine on the network with same configuration works fine. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2834) TreeTable not show Date in PropertyTreeColumn
[ https://issues.apache.org/jira/browse/WICKET-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabriel Jijon updated WICKET-2834: -- Attachment: capture.jpg This sequence is the result of manipulating the width of the browser window. TreeTable not show Date in PropertyTreeColumn - Key: WICKET-2834 URL: https://issues.apache.org/jira/browse/WICKET-2834 Project: Wicket Issue Type: Bug Components: wicket-extensions Affects Versions: 1.4.7 Environment: Ubuntu 9.10 English, Netbeans 6.8, java6, on HP midtower core 2 duo. The server is the same but the locale is Latinamerica (Spanish). Reporter: Gabriel Jijon Assignee: Igor Vaynberg Priority: Minor Attachments: capture.jpg Original Estimate: 24h Remaining Estimate: 24h When I work with TreeTable Component I define a PropertyTreeColumn (in IColumn) and a propertyExpression, well, this propertyExpresion is userObject.titulo. That expression represent a date. When server render the page didn't show treetable (neither the icons and text) but in the server machine or in other machine on the network with same configuration works fine. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2834) TreeTable not show Date in PropertyTreeColumn
[ https://issues.apache.org/jira/browse/WICKET-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabriel Jijon updated WICKET-2834: -- Attachment: (was: capture.jpg) TreeTable not show Date in PropertyTreeColumn - Key: WICKET-2834 URL: https://issues.apache.org/jira/browse/WICKET-2834 Project: Wicket Issue Type: Bug Components: wicket-extensions Affects Versions: 1.4.7 Environment: Ubuntu 9.10 English, Netbeans 6.8, java6, on HP midtower core 2 duo. The server is the same but the locale is Latinamerica (Spanish). Reporter: Gabriel Jijon Assignee: Igor Vaynberg Priority: Minor Attachments: capture.jpg Original Estimate: 24h Remaining Estimate: 24h When I work with TreeTable Component I define a PropertyTreeColumn (in IColumn) and a propertyExpression, well, this propertyExpresion is userObject.titulo. That expression represent a date. When server render the page didn't show treetable (neither the icons and text) but in the server machine or in other machine on the network with same configuration works fine. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2834) TreeTable not show Date in PropertyTreeColumn
[ https://issues.apache.org/jira/browse/WICKET-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabriel Jijon updated WICKET-2834: -- Attachment: capture.jpg TreeTable not show Date in PropertyTreeColumn - Key: WICKET-2834 URL: https://issues.apache.org/jira/browse/WICKET-2834 Project: Wicket Issue Type: Bug Components: wicket-extensions Affects Versions: 1.4.7 Environment: Ubuntu 9.10 English, Netbeans 6.8, java6, on HP midtower core 2 duo. The server is the same but the locale is Latinamerica (Spanish). Reporter: Gabriel Jijon Assignee: Igor Vaynberg Priority: Minor Attachments: capture.jpg Original Estimate: 24h Remaining Estimate: 24h When I work with TreeTable Component I define a PropertyTreeColumn (in IColumn) and a propertyExpression, well, this propertyExpresion is userObject.titulo. That expression represent a date. When server render the page didn't show treetable (neither the icons and text) but in the server machine or in other machine on the network with same configuration works fine. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2834) TreeTable not show Date in PropertyTreeColumn
[ https://issues.apache.org/jira/browse/WICKET-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-2834. --- Resolution: Won't Fix that is a css issue. you will have to use css to size your columns accordingly, not really sure what we can do otherwise. TreeTable not show Date in PropertyTreeColumn - Key: WICKET-2834 URL: https://issues.apache.org/jira/browse/WICKET-2834 Project: Wicket Issue Type: Bug Components: wicket-extensions Affects Versions: 1.4.7 Environment: Ubuntu 9.10 English, Netbeans 6.8, java6, on HP midtower core 2 duo. The server is the same but the locale is Latinamerica (Spanish). Reporter: Gabriel Jijon Assignee: Igor Vaynberg Priority: Minor Attachments: capture.jpg Original Estimate: 24h Remaining Estimate: 24h When I work with TreeTable Component I define a PropertyTreeColumn (in IColumn) and a propertyExpression, well, this propertyExpresion is userObject.titulo. That expression represent a date. When server render the page didn't show treetable (neither the icons and text) but in the server machine or in other machine on the network with same configuration works fine. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
