[jira] Commented: (WICKET-2881) Cannot substitute RelativePathPrefixHandler
[
https://issues.apache.org/jira/browse/WICKET-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889577#action_12889577
]
bernard commented on WICKET-2881:
-
Erik,
Thanks for the idea. The purpose of this is to get a functional local editing
environment which is not possible with absolute URLs.
> Cannot substitute RelativePathPrefixHandler
> ---
>
> Key: WICKET-2881
> URL: https://issues.apache.org/jira/browse/WICKET-2881
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.4.8
> Environment: All
>Reporter: bernard
> Attachments: DirectoryStructure.gif, HomePage.html
>
>
> In IPageSettings
> Get the (modifiable) list of IComponentResolvers.
> List getComponentResolvers();
> This looks very useful and easy indeed, and in Application.init() one can
> find and remove
> RelativePathPrefixHandler and replace it with a different
> AbstractMarkupFilter implementation e.g. XRelativePathPrefixHandler.
> But even while the List.remove(Object o) returns true, and the handler
> appears to be removed, it is still active.
> I don't know why and what holds on to it or what creates a new
> RelativePathPrefixHandler.
> If I add my XRelativePathPrefixHandler, it is not used.
> Consider
> public class MarkupParser
> public final void appendMarkupFilter(final IMarkupFilter filter)
> {
> appendMarkupFilter(filter, RelativePathPrefixHandler.class);
> }
> So RelativePathPrefixHandler seems to be something special and I am afraid of
> other potential complications in case replacement would work.
> Can Wicket be fixed to make a replacement as easy as it appears to be?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
svn commit: r965182 - /wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
Author: mgrigorov
Date: Sun Jul 18 09:15:32 2010
New Revision: 965182
URL: http://svn.apache.org/viewvc?rev=965182&view=rev
Log:
Port from wicket-1.4.x
r808930
Author: jcompagner
Date: Fri Aug 28 15:56:30 2009 UTC (10 months, 2 weeks ago)
Changed paths: 1
Log Message:
test if left/top cant be smaller then 0
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js?rev=965182&r1=965181&r2=965182&view=diff
==
---
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
(original)
+++
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
Sun Jul 18 09:15:32 2010
@@ -495,6 +495,8 @@ Wicket.Window.prototype = {
var left = (width / 2) - (modalWidth / 2) + scLeft;
var top = (height / 2) - (modalHeight / 2) + scTop;
+ if (left < 0) left = 0;
+ if (top < 0) top = 0;
this.window.style.left = left + "px";
this.window.style.top = top + "px";
svn commit: r965183 - in /wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete: AbstractAutoCompleteBehavior.java AutoCompleteSettings.java DefaultCs
Author: mgrigorov
Date: Sun Jul 18 09:29:02 2010
New Revision: 965183
URL: http://svn.apache.org/viewvc?rev=965183&view=rev
Log:
Port from wicket-1.4.x
r886735
Author: jcompagner
Date: Thu Dec 3 10:50:01 2009 UTC (7 months, 2 weeks ago)
Changed paths: 4
Log Message:
fixes and improvements (browser issues)
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AbstractAutoCompleteBehavior.java
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AutoCompleteSettings.java
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/DefaultCssAutoCompleteTextField.css
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AbstractAutoCompleteBehavior.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AbstractAutoCompleteBehavior.java?rev=965183&r1=965182&r2=965183&view=diff
==
---
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AbstractAutoCompleteBehavior.java
(original)
+++
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AbstractAutoCompleteBehavior.java
Sun Jul 18 09:29:02 2010
@@ -82,6 +82,8 @@ public abstract class AbstractAutoComple
sb.append("{preselect: ").append(settings.getPreselect());
sb.append(",maxHeight: ").append(settings.getMaxHeightInPx());
sb.append(",adjustInputWidth:
").append(settings.isAdjustInputWidth());
+ sb.append(",useSmartPositioning:
").append(settings.getUseSmartPositioning());
+ sb.append(",useHideShowCoveredIEFix:
").append(settings.getUseHideShowCoveredIEFix());
sb.append(",showListOnEmptyInput:
").append(settings.getShowListOnEmptyInput());
sb.append(",showListOnFocusGain:
").append(settings.getShowListOnFocusGain());
sb.append(",throttleDelay:
").append(settings.getThrottleDelay());
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AutoCompleteSettings.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AutoCompleteSettings.java?rev=965183&r1=965182&r2=965183&view=diff
==
---
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AutoCompleteSettings.java
(original)
+++
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AutoCompleteSettings.java
Sun Jul 18 09:29:02 2010
@@ -55,6 +55,10 @@ public final class AutoCompleteSettings
private boolean showListOnEmptyInput = false;
+ private boolean useSmartPositioning = false;
+
+ private boolean useHideShowCoveredIEFix = true;
+
private String cssClassName = null;
private boolean adjustInputWidth = true;
@@ -150,6 +154,29 @@ public final class AutoCompleteSettings
}
/**
+* Indicates whether the popup positioning will take into account
browser window visible area or
+* not. (so always show popup bottom-right or not)
+*
+* @return true if popup smart positioning is used, false otherwise.
+*/
+ public boolean getUseSmartPositioning()
+ {
+ return useSmartPositioning;
+ }
+
+ /**
+* Indicates whether in case of IE (and Opera), "select" "iframe" and
"applet" tags should be
+* hidden if covered by popup. (as they might appear on top)
+* By default this is true (before this flag was added).
+*
+* @return true if the fix/workaround should be used for IE and Opera,
false otherwise.
+*/
+ public boolean getUseHideShowCoveredIEFix()
+ {
+ return useHideShowCoveredIEFix;
+ }
+
+ /**
* Indicates whether the autocomplete list will be shown if the input
is empty.
*
* @return true if the autocomlete list will be shown if the input
string is empty, false
@@ -191,10 +218,12 @@ public final class AutoCompleteSettings
*
* @param cssClassName
*valid CSS class name
+* @return this {...@link AutoCompleteSettings}.
*/
- public void setCssClassName(final String cssClassName)
+ public AutoCompleteSettings setCssClassName(final
svn commit: r965185 - in /wicket/trunk: wicket-util/src/main/java/org/apache/wicket/util/io/Connections.java wicket/src/main/java/org/apache/wicket/util/resource/UrlResourceStream.java
Author: mgrigorov
Date: Sun Jul 18 09:34:40 2010
New Revision: 965185
URL: http://svn.apache.org/viewvc?rev=965185&view=rev
Log:
Port from wicket-1.4.x
r890446
Author: jcompagner
Date: Mon Dec 14 19:12:44 2009 UTC (7 months ago)
Changed paths: 2
Log Message:
partly reverted 2534 , fixed 2613
Issue: WICKET-2613
Modified:
wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/io/Connections.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/resource/UrlResourceStream.java
Modified:
wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/io/Connections.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/io/Connections.java?rev=965185&r1=965184&r2=965185&view=diff
==
---
wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/io/Connections.java
(original)
+++
wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/io/Connections.java
Sun Jul 18 09:34:40 2010
@@ -77,46 +77,6 @@ public class Connections
}
/**
-* Tries to find a file on the harddisk that the url points to
-*
-* @param url
-* @return file file pointing to the connection
-* @throws Exception
-* if file could not be located
-*/
- public static File findFile(final URL url) throws Exception
- {
- File file = null;
- URL fileUrl = url;
- URLConnection connection = null;
-
- try
- {
- connection = url.openConnection();
-
- // if this is a connection to a file inside a jar we
point the file to the jar
- // itself
- if (connection instanceof JarURLConnection)
- {
- fileUrl =
((JarURLConnection)connection).getJarFileURL();
- }
-
- file = new File(new URI(fileUrl.toExternalForm()));
-
- if (file != null && !file.exists())
- {
- file = null;
- }
-
- return file;
- }
- finally
- {
- close(connection);
- }
- }
-
- /**
* Closes a connection, ignoring any exceptions if they occur
*
* @param connection
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/resource/UrlResourceStream.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/util/resource/UrlResourceStream.java?rev=965185&r1=965184&r2=965185&view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/resource/UrlResourceStream.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/resource/UrlResourceStream.java
Sun Jul 18 09:34:40 2010
@@ -19,6 +19,7 @@ package org.apache.wicket.util.resource;
import java.io.File;
import java.io.IOException;
import java.io.InputStream;
+import java.net.URI;
import java.net.URL;
import java.net.URLConnection;
@@ -95,7 +96,12 @@ public class UrlResourceStream extends A
try
{
- file = Connections.findFile(url);
+ file = new File(new URI(url.toExternalForm()));
+
+ if (file != null && !file.exists())
+ {
+ file = null;
+ }
}
catch (Exception e)
{
svn commit: r965186 - in /wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal: ModalWindow.java res/modal.js
Author: mgrigorov
Date: Sun Jul 18 09:44:46 2010
New Revision: 965186
URL: http://svn.apache.org/viewvc?rev=965186&view=rev
Log:
Port from wicket-1.4.x
r931519
Author: jcompagner
Date: Wed Apr 7 12:21:42 2010 UTC (3 months, 1 week ago)
Changed paths: 2
Log Message:
open up the api a bit for custom showing and closing
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java?rev=965186&r1=965185&r2=965186&view=diff
==
---
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java
(original)
+++
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java
Sun Jul 18 09:44:46 2010
@@ -25,6 +25,7 @@ import org.apache.wicket.ajax.AjaxReques
import org.apache.wicket.ajax.IAjaxCallDecorator;
import org.apache.wicket.ajax.calldecorator.CancelEventIfNoAjaxDecorator;
import org.apache.wicket.behavior.HeaderContributor;
+import
org.apache.wicket.extensions.ajax.markup.html.modal.ModalWindow.PageCreator;
import org.apache.wicket.markup.ComponentTag;
import org.apache.wicket.markup.html.WebMarkupContainer;
import org.apache.wicket.markup.html.panel.Panel;
@@ -334,7 +335,7 @@ public class ModalWindow extends Panel
*/
public static final void closeCurrent(AjaxRequestTarget target)
{
- target.appendJavascript(getCloseJavacript());
+ target.appendJavascript(getCloseJavacriptInternal());
}
/**
@@ -351,9 +352,16 @@ public class ModalWindow extends Panel
}
/**
-* @return javascript that closes current modal window
+* Method that allows alternate script for showing the window.
+*
+* @return the script that actually shows the window.
*/
- private static String getCloseJavacript()
+ protected CharSequence getShowJavascript()
+ {
+ return "Wicket.Window.create(settings).show();\n";
+ }
+
+ private static String getCloseJavacriptInternal()
{
return "var win;\n" //
+ "try {\n"
@@ -374,6 +382,16 @@ public class ModalWindow extends Panel
}
/**
+* Method that allows alternate script for closing the window.
+*
+* @return the script that actually closes the window.
+*/
+ protected String getCloseJavacript()
+ {
+ return getCloseJavacriptInternal();
+ }
+
+ /**
* Returns the id of content component.
*
*
@@ -811,7 +829,7 @@ public class ModalWindow extends Panel
*
* @return True if user has added own component to the window, false
otherwise.
*/
- private boolean isCustomComponent()
+ protected boolean isCustomComponent()
{
return getContent() != empty;
}
@@ -1052,7 +1070,7 @@ public class ModalWindow extends Panel
postProcessSettings(buffer);
- buffer.append("Wicket.Window.create(settings).show();\n");
+ buffer.append(getShowJavascript());
return buffer.toString();
}
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js?rev=965186&r1=965185&r2=965186&view=diff
==
---
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
(original)
+++
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
Sun Jul 18 09:44:46 2010
@@ -631,34 +631,34 @@ Wicket.Window.prototype = {
show: function() {
// create the DOM elements
- this.createDOM();
+ this.createDOM();
// set the class of window (blue or silver by default)
- this.classElement.className = this.settings.className;
+ this.classElement.className = this.settings.className;
svn commit: r965188 - /wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
Author: mgrigorov
Date: Sun Jul 18 09:47:04 2010
New Revision: 965188
URL: http://svn.apache.org/viewvc?rev=965188&view=rev
Log:
Port from wicket-1.4.x
r933533
Author: jcompagner
Date: Tue Apr 13 09:54:51 2010 UTC (3 months ago)
Changed paths: 1
Log Message:
fix for IE7 when calling delete.
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js?rev=965188&r1=965187&r2=965188&view=diff
==
---
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
(original)
+++
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
Sun Jul 18 09:47:04 2010
@@ -1473,7 +1473,7 @@ Wicket.Window.Mask.prototype = {
var element = this.disabledTabsRevertList[i];
if (typeof(element.hiddenTabIndex) !=
'undefined') {
element.tabIndex =
element.hiddenTabIndex;
- delete element.hiddenTabIndex;
+ try { delete element.hiddenTabIndex; }
catch (e) { element.hiddenTabIndex = undefined; }
}
}
this.disabledTabsRevertList = null;
svn commit: r965190 - /wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
Author: mgrigorov
Date: Sun Jul 18 09:51:09 2010
New Revision: 965190
URL: http://svn.apache.org/viewvc?rev=965190&view=rev
Log:
Port from wicket-1.4.x
r938090
Author: jcompagner
Date: Mon Apr 26 15:22:56 2010 UTC (2 months, 3 weeks ago)
Changed paths: 1
Log Message:
small patch to be able to save your own positions
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js?rev=965190&r1=965189&r2=965190&view=diff
==
---
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
(original)
+++
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
Sun Jul 18 09:51:09 2010
@@ -528,7 +528,10 @@ Wicket.Window.prototype = {
* Saves the position (and size if resizable) as a cookie.
*/
savePosition: function() {
-
+ savePositionAs(this.window.style.left, this.window.style.top,
this.window.style.width, this.content.style.height);
+ },
+
+ savePositionAs: function(x, y, width, height) {
if (typeof(this.settings.cookieId) != "undefined" &&
this.settings.cookieId != null) {
this.findPositionString(true);
@@ -541,10 +544,10 @@ Wicket.Window.prototype = {
var cookie = this.settings.cookieId;
cookie += "::";
- cookie += this.window.style.left + ",";
- cookie += this.window.style.top + ",";
- cookie += this.window.style.width + ",";
- cookie += this.content.style.height;
+ cookie += x + ",";
+ cookie += y + ",";
+ cookie += width + ",";
+ cookie += height;
var rest = Wicket.Cookie.get(this.cookieKey);
if (rest != null) {
svn commit: r965191 - /wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
Author: mgrigorov
Date: Sun Jul 18 09:52:35 2010
New Revision: 965191
URL: http://svn.apache.org/viewvc?rev=965191&view=rev
Log:
Port from wicket-1.4.x
r938341
Author: jcompagner
Date: Tue Apr 27 07:43:07 2010 UTC (2 months, 3 weeks ago)
Changed paths: 1
Log Message:
needs to have this. in front of a call
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js?rev=965191&r1=965190&r2=965191&view=diff
==
---
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
(original)
+++
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
Sun Jul 18 09:52:35 2010
@@ -528,7 +528,7 @@ Wicket.Window.prototype = {
* Saves the position (and size if resizable) as a cookie.
*/
savePosition: function() {
- savePositionAs(this.window.style.left, this.window.style.top,
this.window.style.width, this.content.style.height);
+ this.savePositionAs(this.window.style.left, this.window.style.top,
this.window.style.width, this.content.style.height);
},
savePositionAs: function(x, y, width, height) {
svn commit: r965193 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/ajax/AbstractAjaxTimerBehavior.java
Author: mgrigorov
Date: Sun Jul 18 10:00:21 2010
New Revision: 965193
URL: http://svn.apache.org/viewvc?rev=965193&view=rev
Log:
Port from wicket-1.4.x
r949729
Author: jcompagner
Date: Mon May 31 12:35:50 2010 UTC (6 weeks, 5 days ago)
Changed paths: 1
Log Message:
timer behavior shouldnt add it self again when it is disabled.
Now testing for isEnabled() in the response that adds the onload script
(renderHead is also not called when it is disabled)
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/ajax/AbstractAjaxTimerBehavior.java
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/ajax/AbstractAjaxTimerBehavior.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/ajax/AbstractAjaxTimerBehavior.java?rev=965193&r1=965192&r2=965193&view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/ajax/AbstractAjaxTimerBehavior.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/ajax/AbstractAjaxTimerBehavior.java
Sun Jul 18 10:00:21 2010
@@ -157,7 +157,7 @@ public abstract class AbstractAjaxTimerB
{
onTimer(target);
- if (!stopped)
+ if (!stopped && isEnabled(getComponent()))
{
target.getHeaderResponse().renderOnLoadJavascript(getJsTimeoutCall(updateInterval));
}
[jira] Commented: (WICKET-2613) Content-Length Issue with 1.4.4
[ https://issues.apache.org/jira/browse/WICKET-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889597#action_12889597 ] Hudson commented on WICKET-2613: Integrated in Apache Wicket 1.5.x #143 (See [http://hudson.zones.apache.org/hudson/job/Apache%20Wicket%201.5.x/143/]) Port from wicket-1.4.x r890446 Author: jcompagner Date: Mon Dec 14 19:12:44 2009 UTC (7 months ago) Changed paths: 2 Log Message: partly reverted 2534 , fixed 2613 Issue: WICKET-2613 > Content-Length Issue with 1.4.4 > --- > > Key: WICKET-2613 > URL: https://issues.apache.org/jira/browse/WICKET-2613 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.4.4 > Environment: OSX/JDK6 >Reporter: Victor Igumnov >Assignee: Johan Compagner > Fix For: 1.4.5 > > Attachments: root-final-fix.java > > > I have upgraded to wicket-1.4.4 from wicket-1.4.3. I have made sure to > recompile all dependent libraries against 1.4.4. Since switching any > component referenced from a JAR comes back with an incorrect content-length. > I can resolve this issue by switching back to 1.4.3. > syris:~ victori$ curl -I > http://lfab:8480/resources/wicket.contrib.IconElements/vcard.gif > HTTP/1.1 200 OK > Date: Sun, 13 Dec 2009 23:02:11 GMT > Last-Modified: Sun, 13 Dec 2009 23:00:44 GMT > Expires: Mon, 14 Dec 2009 00:02:11 GMT > Cache-Control: max-age=3600 > Content-Type: image/gif > Content-Length: 99925 > Server: Jetty(6.1.12) > It should be 619 bytes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r965204 - in /wicket/trunk: ./ wicket-devutils/src/main/java/org/apache/wicket/devutils/ wicket-devutils/src/main/java/org/apache/wicket/devutils/debugbar/ wicket-devutils/src/main/java/or
Author: mgrigorov
Date: Sun Jul 18 10:31:20 2010
New Revision: 965204
URL: http://svn.apache.org/viewvc?rev=965204&view=rev
Log:
WICKET-2758 Patches for tests in trunk
* Re-enable wicket-devutils in 1.5.x
* PageMapView is completely removed because there is no more PageMap
* Remove a JMX method related to PageMap
Removed:
wicket/trunk/wicket-devutils/src/main/java/org/apache/wicket/devutils/inspector/PageMapView.html
wicket/trunk/wicket-devutils/src/main/java/org/apache/wicket/devutils/inspector/PageMapView.java
Modified:
wicket/trunk/pom.xml
wicket/trunk/wicket-devutils/src/main/java/org/apache/wicket/devutils/DevUtilsPage.java
wicket/trunk/wicket-devutils/src/main/java/org/apache/wicket/devutils/debugbar/DebugBar.java
wicket/trunk/wicket-devutils/src/main/java/org/apache/wicket/devutils/debugbar/InspectorDebugPanel.java
wicket/trunk/wicket-devutils/src/main/java/org/apache/wicket/devutils/debugbar/SessionSizeDebugPanel.java
wicket/trunk/wicket-devutils/src/main/java/org/apache/wicket/devutils/debugbar/StandardDebugPanel.java
wicket/trunk/wicket-devutils/src/main/java/org/apache/wicket/devutils/inspector/ApplicationView.java
wicket/trunk/wicket-devutils/src/main/java/org/apache/wicket/devutils/inspector/InspectorBug.java
wicket/trunk/wicket-devutils/src/main/java/org/apache/wicket/devutils/inspector/InspectorPage.java
wicket/trunk/wicket-devutils/src/main/java/org/apache/wicket/devutils/inspector/LiveSessionsPage.java
wicket/trunk/wicket-devutils/src/main/java/org/apache/wicket/devutils/inspector/RequestsPage.java
wicket/trunk/wicket-devutils/src/main/java/org/apache/wicket/devutils/inspector/SessionSizeModel.java
wicket/trunk/wicket-devutils/src/main/java/org/apache/wicket/devutils/inspector/SessionView.html
wicket/trunk/wicket-devutils/src/main/java/org/apache/wicket/devutils/inspector/SessionView.java
wicket/trunk/wicket-devutils/src/main/java/org/apache/wicket/devutils/stateless/StatelessChecker.java
wicket/trunk/wicket-jmx/src/main/java/org/apache/wicket/jmx/SessionSettings.java
wicket/trunk/wicket-jmx/src/main/java/org/apache/wicket/jmx/SessionSettingsMBean.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/settings/ISessionSettings.java
Modified: wicket/trunk/pom.xml
URL:
http://svn.apache.org/viewvc/wicket/trunk/pom.xml?rev=965204&r1=965203&r2=965204&view=diff
==
--- wicket/trunk/pom.xml (original)
+++ wicket/trunk/pom.xml Sun Jul 18 10:31:20 2010
@@ -46,9 +46,7 @@
wicket-util
wicket-datetime
wicket-request
-
wicket-extensions
wicket-ioc
wicket-spring
@@ -118,9 +116,7 @@
wicket-util
wicket-datetime
wicket-request
-
wicket-extensions
wicket-ioc
wicket-spring
@@ -195,9 +191,7 @@
wicket-util
wicket-datetime
wicket-request
-
wicket-extensions
wicket-ioc
wicket-spring
@@ -255,9 +249,7 @@
wicket-util
wicket-datetime
wicket-request
-
wicket-extensions
wicket-ioc
wicket-spring
@@ -346,14 +338,12 @@
${project.version}
jar
-
org.apache.wicket
wicket-request
Modified:
wicket/trunk/wicket-devutils/src/main/java/org/apache/wicket/devutils/DevUtilsPage.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-devutils/src/main/java/org/apache/wicket/devutils/DevUtilsPage.java?rev=965204&r1=965203&r2=965204&view=diff
==
---
wicket/trunk/wicket-devutils/src/main/java/org/apache/wicket/devutils/DevUtilsPage.java
(original)
+++
wicket/trunk/wicket-devutils/src/main/java/org/apache/wicket/devutils/DevUtilsPage.java
Sun Jul 18 10:31:20 2010
@@ -16,10 +16,10 @@
*/
package org.apache.wicket.devutils;
-import org.apache.wicket.PageParameters;
import org.apache.wicket.devutils.debugbar.DebugBar;
import org.apache.wicket.markup.html.WebPage;
import org.apache.wicket.model.IModel;
+import org.apache.wicket.request.mapper.parameter.PageParameters;
/**
* All pages in the wicket-devutils package should extend this page so that
they
svn commit: r965206 - /wicket/trunk/wicket/src/main/java/org/apache/wicket/pageStore/PersistentPageManager.java
Author: mgrigorov
Date: Sun Jul 18 10:34:24 2010
New Revision: 965206
URL: http://svn.apache.org/viewvc?rev=965206&view=rev
Log:
WICKET-2758 Patches for tests in trunk
Call IPageStore#destroy() on IPageManager#destroy().
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/pageStore/PersistentPageManager.java
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/pageStore/PersistentPageManager.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/pageStore/PersistentPageManager.java?rev=965206&r1=965205&r2=965206&view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/pageStore/PersistentPageManager.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/pageStore/PersistentPageManager.java
Sun Jul 18 10:34:24 2010
@@ -371,5 +371,6 @@ public class PersistentPageManager exten
public void destroy()
{
managers.remove(applicationName);
+ pageStore.destroy();
}
}
[jira] Commented: (WICKET-2758) Patches for tests in trunk
[ https://issues.apache.org/jira/browse/WICKET-2758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889600#action_12889600 ] Martin Grigorov commented on WICKET-2758: - 014-call-IPageStore-destroy.patch is integrated with r965206. > Patches for tests in trunk > -- > > Key: WICKET-2758 > URL: https://issues.apache.org/jira/browse/WICKET-2758 > Project: Wicket > Issue Type: Test > Components: wicket >Affects Versions: 1.5-M1 >Reporter: Martin Grigorov > Fix For: 1.5-M1 > > Attachments: 003-remove-velocity-init.patch, > 004-wicket-examples-tests.patch, 005-run-tests-offline.patch, > 006-upgrade-maven-jetty-plugin.patch, 007-fix-image2-name.patch, > 008-log-is-in-development-mode.patch, 009-use-iexception-settings.patch, > 010-enable-spring-example.patch, 011-comment-out-wicketng-example.patch, > 012-find-border-body-tag.patch, 013-re-enable-wicket-devutils.patch, > 014-call-IPageStore-destroy.patch, 015-fix-threadtest-urls-to-1.5.patch, > WICKET-2758.patch, wicket-2758.typos.patch > > > A ticket for patches for the tests in trunk. > applied patches: > wicket-2758.typos.patch > WICKET-2758.patch > 003-012 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r965209 - in /wicket/trunk/testing/wicket-threadtest/src/main/java/org/apache/wicket/threadtest: App1Test1.java App1Test2.java App1Test3.java App2Test1.java apps/app1/Home.java
Author: mgrigorov
Date: Sun Jul 18 10:38:17 2010
New Revision: 965209
URL: http://svn.apache.org/viewvc?rev=965209&view=rev
Log:
WICKET-2758 Patches for tests in trunk
Fix the URLs in threadtests to be 1.5 complaint
Modified:
wicket/trunk/testing/wicket-threadtest/src/main/java/org/apache/wicket/threadtest/App1Test1.java
wicket/trunk/testing/wicket-threadtest/src/main/java/org/apache/wicket/threadtest/App1Test2.java
wicket/trunk/testing/wicket-threadtest/src/main/java/org/apache/wicket/threadtest/App1Test3.java
wicket/trunk/testing/wicket-threadtest/src/main/java/org/apache/wicket/threadtest/App2Test1.java
wicket/trunk/testing/wicket-threadtest/src/main/java/org/apache/wicket/threadtest/apps/app1/Home.java
Modified:
wicket/trunk/testing/wicket-threadtest/src/main/java/org/apache/wicket/threadtest/App1Test1.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/testing/wicket-threadtest/src/main/java/org/apache/wicket/threadtest/App1Test1.java?rev=965209&r1=965208&r2=965209&view=diff
==
---
wicket/trunk/testing/wicket-threadtest/src/main/java/org/apache/wicket/threadtest/App1Test1.java
(original)
+++
wicket/trunk/testing/wicket-threadtest/src/main/java/org/apache/wicket/threadtest/App1Test1.java
Sun Jul 18 10:38:17 2010
@@ -42,13 +42,11 @@ public class App1Test1
{
List gets = Arrays.asList(new String[] {
-
"/app1/?wicket:bookmarkablePage=:org.apache.wicket.threadtest.apps.app1.Home",
-
"/app1/?wicket:interface=:${iteration}:link::ILinkListener::",
-
"/app1/?wicket:interface=:${iteration}:link:1:ILinkListener::",
-
"/app1/?wicket:interface=:${iteration}:link:2:ILinkListener::" });
+
"/app1/wicket/bookmarkable/org.apache.wicket.threadtest.apps.app1.Home",
+
"/app1/wicket/page?0-${iteration}.ILinkListener-link" });
// you can turn this on if you e.g. want to attach to a profiler
- // Thread.sleep(5000);
+// Thread.sleep(5000);
WicketObjects.setObjectStreamFactory(new
WicketObjectStreamFactory());
SimpleGetCommand getCmd = new SimpleGetCommand(gets, 10);
Modified:
wicket/trunk/testing/wicket-threadtest/src/main/java/org/apache/wicket/threadtest/App1Test2.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/testing/wicket-threadtest/src/main/java/org/apache/wicket/threadtest/App1Test2.java?rev=965209&r1=965208&r2=965209&view=diff
==
---
wicket/trunk/testing/wicket-threadtest/src/main/java/org/apache/wicket/threadtest/App1Test2.java
(original)
+++
wicket/trunk/testing/wicket-threadtest/src/main/java/org/apache/wicket/threadtest/App1Test2.java
Sun Jul 18 10:38:17 2010
@@ -39,7 +39,7 @@ public class App1Test2
public static void main(String[] args) throws Exception
{
- List gets = Arrays.asList(new String[] {
"/app1?wicket:bookmarkablePage=one:org.apache.wicket.threadtest.apps.app1.Home"
});
+ List gets = Arrays.asList(new String[] {
"/app1/wicket/bookmarkable/org.apache.wicket.threadtest.apps.app1.Home" });
SimpleGetCommand getCmd = new SimpleGetCommand(gets, 5);
Modified:
wicket/trunk/testing/wicket-threadtest/src/main/java/org/apache/wicket/threadtest/App1Test3.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/testing/wicket-threadtest/src/main/java/org/apache/wicket/threadtest/App1Test3.java?rev=965209&r1=965208&r2=965209&view=diff
==
---
wicket/trunk/testing/wicket-threadtest/src/main/java/org/apache/wicket/threadtest/App1Test3.java
(original)
+++
wicket/trunk/testing/wicket-threadtest/src/main/java/org/apache/wicket/threadtest/App1Test3.java
Sun Jul 18 10:38:17 2010
@@ -41,11 +41,10 @@ public class App1Test3
{
List gets = new ArrayList();
-
gets.add("/app1?wicket:bookmarkablePage=one:org.apache.wicket.threadtest.apps.app1.ResourceTestPage");
+
gets.add("/app1/wicket/bookmarkable/org.apache.wicket.threadtest.apps.app1.ResourceTestPage");
for (int i = 0; i < ResourceTestPage.IMAGES_PER_PAGE; i++)
{
-
gets.add("/app1?wicket:interface=one:${iteration}:listView:" + i +
- ":image::IResourceListener::");
+
gets.add("/app1/wicket/page?0-IResourceListener-listView-${iteration}-image");
}
SimpleGetCommand getCmd = new SimpleGetCommand(gets, 5);
Modified:
wicket/trunk/testing/wicket-threadtest/src/main/java/org/apache/wicket/threadtest/App2Test1.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/testing/wicket-
[jira] Commented: (WICKET-2758) Patches for tests in trunk
[ https://issues.apache.org/jira/browse/WICKET-2758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889601#action_12889601 ] Martin Grigorov commented on WICKET-2758: - 015-fix-threadtest-urls-to-1.5.patch is integrated with r965209. > Patches for tests in trunk > -- > > Key: WICKET-2758 > URL: https://issues.apache.org/jira/browse/WICKET-2758 > Project: Wicket > Issue Type: Test > Components: wicket >Affects Versions: 1.5-M1 >Reporter: Martin Grigorov > Fix For: 1.5-M1 > > Attachments: 003-remove-velocity-init.patch, > 004-wicket-examples-tests.patch, 005-run-tests-offline.patch, > 006-upgrade-maven-jetty-plugin.patch, 007-fix-image2-name.patch, > 008-log-is-in-development-mode.patch, 009-use-iexception-settings.patch, > 010-enable-spring-example.patch, 011-comment-out-wicketng-example.patch, > 012-find-border-body-tag.patch, 013-re-enable-wicket-devutils.patch, > 014-call-IPageStore-destroy.patch, 015-fix-threadtest-urls-to-1.5.patch, > WICKET-2758.patch, wicket-2758.typos.patch > > > A ticket for patches for the tests in trunk. > applied patches: > wicket-2758.typos.patch > WICKET-2758.patch > 003-012 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2758) Patches for tests in trunk
[ https://issues.apache.org/jira/browse/WICKET-2758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889599#action_12889599 ] Martin Grigorov commented on WICKET-2758: - 013-re-enable-wicket-devutils.patch is integrated with r965204. > Patches for tests in trunk > -- > > Key: WICKET-2758 > URL: https://issues.apache.org/jira/browse/WICKET-2758 > Project: Wicket > Issue Type: Test > Components: wicket >Affects Versions: 1.5-M1 >Reporter: Martin Grigorov > Fix For: 1.5-M1 > > Attachments: 003-remove-velocity-init.patch, > 004-wicket-examples-tests.patch, 005-run-tests-offline.patch, > 006-upgrade-maven-jetty-plugin.patch, 007-fix-image2-name.patch, > 008-log-is-in-development-mode.patch, 009-use-iexception-settings.patch, > 010-enable-spring-example.patch, 011-comment-out-wicketng-example.patch, > 012-find-border-body-tag.patch, 013-re-enable-wicket-devutils.patch, > 014-call-IPageStore-destroy.patch, 015-fix-threadtest-urls-to-1.5.patch, > WICKET-2758.patch, wicket-2758.typos.patch > > > A ticket for patches for the tests in trunk. > applied patches: > wicket-2758.typos.patch > WICKET-2758.patch > 003-012 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-2758) Patches for tests in trunk
[ https://issues.apache.org/jira/browse/WICKET-2758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Grigorov reassigned WICKET-2758: --- Assignee: Martin Grigorov > Patches for tests in trunk > -- > > Key: WICKET-2758 > URL: https://issues.apache.org/jira/browse/WICKET-2758 > Project: Wicket > Issue Type: Test > Components: wicket >Affects Versions: 1.5-M1 >Reporter: Martin Grigorov >Assignee: Martin Grigorov > Fix For: 1.5-M1 > > Attachments: 003-remove-velocity-init.patch, > 004-wicket-examples-tests.patch, 005-run-tests-offline.patch, > 006-upgrade-maven-jetty-plugin.patch, 007-fix-image2-name.patch, > 008-log-is-in-development-mode.patch, 009-use-iexception-settings.patch, > 010-enable-spring-example.patch, 011-comment-out-wicketng-example.patch, > 012-find-border-body-tag.patch, 013-re-enable-wicket-devutils.patch, > 014-call-IPageStore-destroy.patch, 015-fix-threadtest-urls-to-1.5.patch, > WICKET-2758.patch, wicket-2758.typos.patch > > > A ticket for patches for the tests in trunk. > applied patches: > wicket-2758.typos.patch > WICKET-2758.patch > 003-012 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2758) Patches for tests in trunk
[ https://issues.apache.org/jira/browse/WICKET-2758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889603#action_12889603 ] Hudson commented on WICKET-2758: Integrated in Apache Wicket 1.5.x #144 (See [http://hudson.zones.apache.org/hudson/job/Apache%20Wicket%201.5.x/144/]) WICKET-2758 Patches for tests in trunk Fix the URLs in threadtests to be 1.5 complaint WICKET-2758 Patches for tests in trunk Call IPageStore#destroy() on IPageManager#destroy(). WICKET-2758 Patches for tests in trunk * Re-enable wicket-devutils in 1.5.x * PageMapView is completely removed because there is no more PageMap * Remove a JMX method related to PageMap > Patches for tests in trunk > -- > > Key: WICKET-2758 > URL: https://issues.apache.org/jira/browse/WICKET-2758 > Project: Wicket > Issue Type: Test > Components: wicket >Affects Versions: 1.5-M1 >Reporter: Martin Grigorov >Assignee: Martin Grigorov > Fix For: 1.5-M1 > > Attachments: 003-remove-velocity-init.patch, > 004-wicket-examples-tests.patch, 005-run-tests-offline.patch, > 006-upgrade-maven-jetty-plugin.patch, 007-fix-image2-name.patch, > 008-log-is-in-development-mode.patch, 009-use-iexception-settings.patch, > 010-enable-spring-example.patch, 011-comment-out-wicketng-example.patch, > 012-find-border-body-tag.patch, 013-re-enable-wicket-devutils.patch, > 014-call-IPageStore-destroy.patch, 015-fix-threadtest-urls-to-1.5.patch, > WICKET-2758.patch, wicket-2758.typos.patch > > > A ticket for patches for the tests in trunk. > applied patches: > wicket-2758.typos.patch > WICKET-2758.patch > 003-012 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2758) Patches for tests in trunk
[ https://issues.apache.org/jira/browse/WICKET-2758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Grigorov resolved WICKET-2758. - Resolution: Fixed Close this ticket. All patches are applied. Any new fixes will go in separate tickets > Patches for tests in trunk > -- > > Key: WICKET-2758 > URL: https://issues.apache.org/jira/browse/WICKET-2758 > Project: Wicket > Issue Type: Test > Components: wicket >Affects Versions: 1.5-M1 >Reporter: Martin Grigorov >Assignee: Martin Grigorov > Fix For: 1.5-M1 > > Attachments: 003-remove-velocity-init.patch, > 004-wicket-examples-tests.patch, 005-run-tests-offline.patch, > 006-upgrade-maven-jetty-plugin.patch, 007-fix-image2-name.patch, > 008-log-is-in-development-mode.patch, 009-use-iexception-settings.patch, > 010-enable-spring-example.patch, 011-comment-out-wicketng-example.patch, > 012-find-border-body-tag.patch, 013-re-enable-wicket-devutils.patch, > 014-call-IPageStore-destroy.patch, 015-fix-threadtest-urls-to-1.5.patch, > WICKET-2758.patch, wicket-2758.typos.patch > > > A ticket for patches for the tests in trunk. > applied patches: > wicket-2758.typos.patch > WICKET-2758.patch > 003-012 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2881) Cannot substitute RelativePathPrefixHandler
[
https://issues.apache.org/jira/browse/WICKET-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889641#action_12889641
]
Juergen Donnerstag commented on WICKET-2881:
I'll try it again.If you want to change the behavior which eventually gets
attached to the component and which modifies the path, than
1) you need to copy RelativePathPrefixHandler (yes, sorry. That's how it
currently works).
2) remove "implements IComponentResolver" and the resolve() method. You will
not need it.
3) modify the behavior within MyRelativePathPrefixHandler as you like
4) Define a class MyMarkupParserFactory which extends MarkupParserFactory
5) subclass MarkupParserFactory.newMarkupParser() to add your own
implementation of RelativePathPrefixHandler (see MarkupParserFactory javadoc).
Your own MyRelativePathPrefixHandler will be added before the original
RelativePathPrefixHandler and thus "replace it".
6) register your MyMarkupParserFactory with IMarkupSettings via
setMarkupParserFactory(IMarkupParserFactory()
Juergen
> Cannot substitute RelativePathPrefixHandler
> ---
>
> Key: WICKET-2881
> URL: https://issues.apache.org/jira/browse/WICKET-2881
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.4.8
> Environment: All
>Reporter: bernard
> Attachments: DirectoryStructure.gif, HomePage.html
>
>
> In IPageSettings
> Get the (modifiable) list of IComponentResolvers.
> List getComponentResolvers();
> This looks very useful and easy indeed, and in Application.init() one can
> find and remove
> RelativePathPrefixHandler and replace it with a different
> AbstractMarkupFilter implementation e.g. XRelativePathPrefixHandler.
> But even while the List.remove(Object o) returns true, and the handler
> appears to be removed, it is still active.
> I don't know why and what holds on to it or what creates a new
> RelativePathPrefixHandler.
> If I add my XRelativePathPrefixHandler, it is not used.
> Consider
> public class MarkupParser
> public final void appendMarkupFilter(final IMarkupFilter filter)
> {
> appendMarkupFilter(filter, RelativePathPrefixHandler.class);
> }
> So RelativePathPrefixHandler seems to be something special and I am afraid of
> other potential complications in case replacement would work.
> Can Wicket be fixed to make a replacement as easy as it appears to be?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2881) Cannot substitute RelativePathPrefixHandler
[
https://issues.apache.org/jira/browse/WICKET-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889708#action_12889708
]
bernard commented on WICKET-2881:
-
Thanks Juergen.
Your suggestion works. The outcome is that we get complete separation of
concerns between HTML markup and Java source code which is a great step forward.
Previously this was not possible where one would have to either break resource
links at design time or break the association between markup and java files
which in both cases is terrible for tooling.
Now I can think of writing an IDE plugin that lets me switch between markup and
HTML with a keystroke.
There are plugins that do this, but they work on the assumption that markup is
in the same directory as the Java files. That is a special use case scenario -
most useful for components such as used in the framework itself, where markup
is managed by the Java developer who writes the framework.
> Cannot substitute RelativePathPrefixHandler
> ---
>
> Key: WICKET-2881
> URL: https://issues.apache.org/jira/browse/WICKET-2881
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.4.8
> Environment: All
>Reporter: bernard
> Attachments: DirectoryStructure.gif, HomePage.html
>
>
> In IPageSettings
> Get the (modifiable) list of IComponentResolvers.
> List getComponentResolvers();
> This looks very useful and easy indeed, and in Application.init() one can
> find and remove
> RelativePathPrefixHandler and replace it with a different
> AbstractMarkupFilter implementation e.g. XRelativePathPrefixHandler.
> But even while the List.remove(Object o) returns true, and the handler
> appears to be removed, it is still active.
> I don't know why and what holds on to it or what creates a new
> RelativePathPrefixHandler.
> If I add my XRelativePathPrefixHandler, it is not used.
> Consider
> public class MarkupParser
> public final void appendMarkupFilter(final IMarkupFilter filter)
> {
> appendMarkupFilter(filter, RelativePathPrefixHandler.class);
> }
> So RelativePathPrefixHandler seems to be something special and I am afraid of
> other potential complications in case replacement would work.
> Can Wicket be fixed to make a replacement as easy as it appears to be?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
