[CONF] Apache Wicket Spring Security and Wicket-auth-roles
Spring Security and Wicket-auth-roles Page comment added by Ruben Wagner To provide the security context in the wicket web application (using spring-security-3.0.X) you can not omit the "springSecurityFilterChain" in the web.xml. If you omit it, the "SecurityContextPersistenceFilter" will not be passed and you will not have the security context provided in a multithreaded environment - like tomcat. See Spring Docshttp://static.springsource.org/spring-security/site/docs/3.0.x/reference/security-filter-chain.html You don't need to specify a bean if you use "springSecurityFilterChain" as filter name - Because then the default filter-chain will be used. See Spring Docshttp://static.springsource.org/spring-security/site/docs/3.0.x/reference/ns-config.html (2.2.1) ... filter filter-namespringSecurityFilterChain/filter-name filter-classorg.springframework.web.filter.DelegatingFilterProxy/filter-class /filter filter-mapping filter-namespringSecurityFilterChain/filter-name url-pattern/*/url-pattern /filter-mapping ... Hope this helps someone. Change Notification Preferences View Online | Reply To This
[CONF] Apache Wicket Spring Security and Wicket-auth-roles
Spring Security and Wicket-auth-roles
Comment edited by Ruben Wagner
:
Changes (3)
To provide the security context in the wicket web application (using spring-security-3.0.X) you can not omit the springSecurityFilterChain in the web.xml. If you omit it, the SecurityContextPersistenceFilter will not be passed and you will not have the security context provided in a multithreaded environment - like tomcat.
See [Spring Docs][http://static.springsource.org/spring-security/site/docs/3.0.x/reference/security-filter-chain.html]
See [http://static.springsource.org/spring-security/site/docs/3.0.x/reference/security-filter-chain.html]
You dont need to specify a bean if you use springSecurityFilterChain as filter name - Because then the default filter-chain will be used.
See [Spring Docs][http://static.springsource.org/spring-security/site/docs/3.0.x/reference/ns-config.html] (2.2.1)
{code}
...
filter filter-namespringSecurityFilterChain/filter-name
filter-classorg.springframework.web.filter.DelegatingFilterProxy/filter-class
/filter filter-mapping
...
Full Content
To provide the security context in the wicket web application (using spring-security-3.0.X) you can not omit the "springSecurityFilterChain" in the web.xml.
If you omit it, the "SecurityContextPersistenceFilter" will not be passed and you will not have the security context provided in a multithreaded environment - like tomcat.
See http://static.springsource.org/spring-security/site/docs/3.0.x/reference/security-filter-chain.html
You don't need to specify a bean if you use "springSecurityFilterChain" as filter name - Because then the default filter-chain will be used.
See http://static.springsource.org/spring-security/site/docs/3.0.x/reference/ns-config.html (2.2.1)
...
filter
filter-namespringSecurityFilterChain/filter-name
filter-classorg.springframework.web.filter.DelegatingFilterProxy/filter-class
/filter
filter-mapping
filter-namespringSecurityFilterChain/filter-name
url-pattern/*/url-pattern
/filter-mapping
...
Hope this helps someone.
Change Notification Preferences
View Online
|
Reply To This
[CONF] Apache Wicket Spring Security and Wicket-auth-roles
Spring Security and Wicket-auth-roles
Comment edited by Ruben Wagner
:
Changes (1)
...
See [http://static.springsource.org/spring-security/site/docs/3.0.x/reference/ns-config.html] (2.2.1)
{code:web.xml}
... filter
...
Full Content
To provide the security context in the wicket web application (using spring-security-3.0.X) you can not omit the "springSecurityFilterChain" in the web.xml.
If you omit it, the "SecurityContextPersistenceFilter" will not be passed and you will not have the security context provided in a multithreaded environment - like tomcat.
See http://static.springsource.org/spring-security/site/docs/3.0.x/reference/security-filter-chain.html
You don't need to specify a bean if you use "springSecurityFilterChain" as filter name - Because then the default filter-chain will be used.
See http://static.springsource.org/spring-security/site/docs/3.0.x/reference/ns-config.html (2.2.1)
Unable to find source-code formatter for language: web.xml. Available languages are: actionscript, html, java, _javascript_, none, sql, xhtml, xml
...
filter
filter-namespringSecurityFilterChain/filter-name
filter-classorg.springframework.web.filter.DelegatingFilterProxy/filter-class
/filter
filter-mapping
filter-namespringSecurityFilterChain/filter-name
url-pattern/*/url-pattern
/filter-mapping
...
Hope this helps someone.
Change Notification Preferences
View Online
|
Reply To This
[CONF] Apache Wicket Spring Security and Wicket-auth-roles
Spring Security and Wicket-auth-roles
Comment edited by Ruben Wagner
:
Changes (2)
...
See [http://static.springsource.org/spring-security/site/docs/3.0.x/reference/ns-config.html] (2.2.1)
{code:web.xml}
{code:xml|title=web.xml}
... filter
...
Full Content
To provide the security context in the wicket web application (using spring-security-3.0.X) you can not omit the "springSecurityFilterChain" in the web.xml.
If you omit it, the "SecurityContextPersistenceFilter" will not be passed and you will not have the security context provided in a multithreaded environment - like tomcat.
See http://static.springsource.org/spring-security/site/docs/3.0.x/reference/security-filter-chain.html
You don't need to specify a bean if you use "springSecurityFilterChain" as filter name - Because then the default filter-chain will be used.
See http://static.springsource.org/spring-security/site/docs/3.0.x/reference/ns-config.html (2.2.1)
web.xml
...
filter
filter-namespringSecurityFilterChain/filter-name
filter-classorg.springframework.web.filter.DelegatingFilterProxy/filter-class
/filter
filter-mapping
filter-namespringSecurityFilterChain/filter-name
url-pattern/*/url-pattern
/filter-mapping
...
Hope this helps someone.
Change Notification Preferences
View Online
|
Reply To This
svn commit: r1041779 - /wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
Author: pedro
Date: Fri Dec 3 11:53:58 2010
New Revision: 1041779
URL: http://svn.apache.org/viewvc?rev=1041779view=rev
Log:
hack for a focus issue in IE working for WICKET-2279 and WICKET-3215
Issue: WICKET-3215
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js?rev=1041779r1=1041778r2=1041779view=diff
==
---
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
(original)
+++
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
Fri Dec 3 11:53:58 2010
@@ -590,14 +590,10 @@ Wicket.AutoComplete=function(elementId,
hideIndicator();
// hack for a focus issue in IE, WICKET-2279
-if(Wicket.Browser.isIE()) {
- Wicket.Focus.refocusLastFocusedComponentAfterResponse =
true;
- var focusedElement = Wicket.$(elementId);
- var temponblur = focusedElement.onblur;
- focusedElement.onblur = null;
- focusedElement.blur();
- setTimeout(function() { focusedElement.onblur =
temponblur;}, 0);
- Wicket.Focus.requestFocus();
+ if (Wicket.Browser.isIE()) {
+ var range = document.selection.createRange();
+ if (range != null)
+ range.select();
}
}
[jira] Closed: (WICKET-3215) AutoCompleteTextField does not work in an iframe under IE 6, 7 or 8
[ https://issues.apache.org/jira/browse/WICKET-3215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pedro Santos closed WICKET-3215. Resolution: Fixed Fix Version/s: 1.5-M4 |o|, thank u Martin, commited to 1.5 too AutoCompleteTextField does not work in an iframe under IE 6, 7 or 8 --- Key: WICKET-3215 URL: https://issues.apache.org/jira/browse/WICKET-3215 Project: Wicket Issue Type: Bug Components: wicket-extensions Affects Versions: 1.4.11, 1.4.12, 1.4.13, 1.4.14 Environment: Windows Server 2003 Reporter: Robert Csok Assignee: Pedro Santos Fix For: 1.4.15, 1.5-M4 Attachments: HomePage.html, HomePage.java, iframe.html The code that has been integrated in version 1.4.11 to fix issue WICKET-2279 forces the cursor of an AutoCompleteTextField to do a carriage return after each typed in char when the application runs in an iframe and IE 6, 7 or 8 is used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3218) Component#onInitialize is broken for Pages
[ https://issues.apache.org/jira/browse/WICKET-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12966514#action_12966514 ] Carl-Eric Menzel commented on WICKET-3218: -- Ok, you are right about that. I missed that. After your comment on the dev list that the whole initialization thing could be moved back to before configure(), I started on a different patch. The main concern for me is still that I need to be able to have an initialize step that is guaranteed to run after the constructors. Component#onInitialize is broken for Pages -- Key: WICKET-3218 URL: https://issues.apache.org/jira/browse/WICKET-3218 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.14 Reporter: Carl-Eric Menzel As first mentioned at http://mail-archives.apache.org/mod_mbox/wicket-dev/201012.mbox/%3c1291238699.1749.1408166...@webmail.messagingengine.com%3e , I think the current (Wicket 1.4.14) implementation of Component#onInitialize is broken for Pages. Pages get initialized as soon as the first component is added, which is correct. But this usually happens within the constructor of the page, which means that the page object isn't fully initialized yet. The entire point of having onInitialize, however, is to be able to do further work once all constructors have run. See https://github.com/duesenklipper/wicket-oninitialize for a quickstart that demonstrates the problem. Pedro Santos suggested in the above thread to just switch the entire object construction to onInitialize. I don't think this is a good idea, because 1) it is completely counter-intuitive 2) it is not always realistic to have an entire class hierarchy not using the constructor just because a subclass somewhere might want to use onInitialize 3) it is inconsistent with onInitialize behavior for all other (non-Page) components. Here I can easily mix work in the constructor with onInitialize. I propose the following patch: - override onInitialize in Page and make it final, so Pages can't use this any more. This should not cause any unnecessary breaking, since currently it's not working for pages anyway. - introduce Page#onPageInitialize to provide a safe alternative to onInitialize - make a special case for Page in Component's beforeRender to fire Page#onPageInitialize if necessary Yes, this is a bit of special casing for Page, but there's quite a lot of that needed for Page anyway. I think the impact of this should be minimal. My page includes documentation and a new testcase that verifies the new behavior. I modified the old ComponentInitializationTest to reflect the fact that Page doesn't get onInitialize any more. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3218) Component#onInitialize is broken for Pages
[ https://issues.apache.org/jira/browse/WICKET-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carl-Eric Menzel updated WICKET-3218: - Attachment: 0001-delay-oninitialize-until-just-before-onconfigure.patch A new attempt at resolving this. I moved the call to initialize() into internalBeforeRender(), since unlike configure() this can't be triggered by framework users. Components that are added before the Page itself has been initialized now are now simply initialized with the cascading fireInitialize() when the Page gets its initialize call. Components that are added after that will be initialized by Page#componentAdded. This way the initialization order is guaranteed to follow the component hierarchy. IMO, this restores a consistent and intuitive behavior for onInitialize for *all* components including Pages, without breaking any existing code. I adjusted ComponentInitializationTest to always use tester.startPage, since initialization is no longer triggered by add(). The tests that still made sense in this light still work. testPropagation was removed, since there is no immediate propagation anymore, and eventual propagation down the component tree is included in testInitializationOrder. One thing I'm not so happy about: I needed to distinguish between already initialized and currently initializing to delay initialization for components that are added in an onInitialize method. To do that I needed a new flag FLAG_INITIALIZING. Unfortunately the int space for flags was exhausted, so I had to turn Component#flags into a long. The cost of this is 4 extra bytes. I'm not sure whether that is acceptable. If not, it could probably be replaced with a single extra boolean in Component, which would reduce the cost but not eliminate it. Component#onInitialize is broken for Pages -- Key: WICKET-3218 URL: https://issues.apache.org/jira/browse/WICKET-3218 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.14 Reporter: Carl-Eric Menzel Attachments: 0001-delay-oninitialize-until-just-before-onconfigure.patch As first mentioned at http://mail-archives.apache.org/mod_mbox/wicket-dev/201012.mbox/%3c1291238699.1749.1408166...@webmail.messagingengine.com%3e , I think the current (Wicket 1.4.14) implementation of Component#onInitialize is broken for Pages. Pages get initialized as soon as the first component is added, which is correct. But this usually happens within the constructor of the page, which means that the page object isn't fully initialized yet. The entire point of having onInitialize, however, is to be able to do further work once all constructors have run. See https://github.com/duesenklipper/wicket-oninitialize for a quickstart that demonstrates the problem. Pedro Santos suggested in the above thread to just switch the entire object construction to onInitialize. I don't think this is a good idea, because 1) it is completely counter-intuitive 2) it is not always realistic to have an entire class hierarchy not using the constructor just because a subclass somewhere might want to use onInitialize 3) it is inconsistent with onInitialize behavior for all other (non-Page) components. Here I can easily mix work in the constructor with onInitialize. I propose the following patch: - override onInitialize in Page and make it final, so Pages can't use this any more. This should not cause any unnecessary breaking, since currently it's not working for pages anyway. - introduce Page#onPageInitialize to provide a safe alternative to onInitialize - make a special case for Page in Component's beforeRender to fire Page#onPageInitialize if necessary Yes, this is a bit of special casing for Page, but there's quite a lot of that needed for Page anyway. I think the impact of this should be minimal. My page includes documentation and a new testcase that verifies the new behavior. I modified the old ComponentInitializationTest to reflect the fact that Page doesn't get onInitialize any more. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3221) don't use @see upperClass when javadoc inheritance is sufficient
[
https://issues.apache.org/jira/browse/WICKET-3221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12966552#action_12966552
]
Pedro Santos commented on WICKET-3221:
--
+1
Refactor an name class on eclipse also rename the @see on javadoc. But think
the code would be cleaner without an javadoc just for the @see tag
don't use @see upperClass when javadoc inheritance is sufficient
Key: WICKET-3221
URL: https://issues.apache.org/jira/browse/WICKET-3221
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.5-M3
Reporter: Peter Ertl
I see this all the time:
/**
* @see org.apache.wicket.Application#getApplicationKey()
*/
@Override
public final String getApplicationKey()
{
return getName();
}
The javadoc links to the parent javadoc using @see.
This is not required since javadoc inheritance is enabled by default. Unless
you want to modify the javadoc from the parent class it's sufficient to just
don't declare javadoc at all. less work and better result!
@Override
public final String getApplicationKey()
{
return getName();
}
will automatically inherit the javadoc from the method it overrides.
Quite often the @see link is broken after refactoring.
So the @see generates a lot of unnessecary work (fix links after refactors)
and makes javadoc less usable.
Shouldn't we just abandon that style of documentation if the parent javadoc
is fine for the child?
??
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-3221) don't use @see upperClass when javadoc inheritance is sufficient
[
https://issues.apache.org/jira/browse/WICKET-3221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12966552#action_12966552
]
Pedro Santos edited comment on WICKET-3221 at 12/3/10 10:48 AM:
+1
Refactor an method or class name on eclipse also renames the @see link on
javadoc. But I think the code would be cleaner without an javadoc at the class
code just for the @see tag
was (Author: pedrosans):
+1
Refactor an name class on eclipse also rename the @see on javadoc. But think
the code would be cleaner without an javadoc just for the @see tag
don't use @see upperClass when javadoc inheritance is sufficient
Key: WICKET-3221
URL: https://issues.apache.org/jira/browse/WICKET-3221
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.5-M3
Reporter: Peter Ertl
I see this all the time:
/**
* @see org.apache.wicket.Application#getApplicationKey()
*/
@Override
public final String getApplicationKey()
{
return getName();
}
The javadoc links to the parent javadoc using @see.
This is not required since javadoc inheritance is enabled by default. Unless
you want to modify the javadoc from the parent class it's sufficient to just
don't declare javadoc at all. less work and better result!
@Override
public final String getApplicationKey()
{
return getName();
}
will automatically inherit the javadoc from the method it overrides.
Quite often the @see link is broken after refactoring.
So the @see generates a lot of unnessecary work (fix links after refactors)
and makes javadoc less usable.
Shouldn't we just abandon that style of documentation if the parent javadoc
is fine for the child?
??
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3222) AbstractMarkupParser doesn't remove Comments correctly
[ https://issues.apache.org/jira/browse/WICKET-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Juergen Donnerstag resolved WICKET-3222. Resolution: Fixed Fix Version/s: 1.5-M4 thanks AbstractMarkupParser doesn't remove Comments correctly -- Key: WICKET-3222 URL: https://issues.apache.org/jira/browse/WICKET-3222 Project: Wicket Issue Type: Bug Affects Versions: 1.5-M3 Reporter: Martin Funk Assignee: Juergen Donnerstag Fix For: 1.5-M4 AbstractMarkupParser removeComment(...) doesn't remove Comments correctly if two html comments stand to close together !-- foo -- !-- bar -- foo will be removed but not bar. see: https://github.com/mafulafunk/wicketComments g...@github.com:mafulafunk/wicketComments.git -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r1041947 - in /wicket/trunk/wicket/src: main/java/org/apache/wicket/markup/AbstractMarkupParser.java test/java/org/apache/wicket/markup/MarkupParserTest.java
Author: jdonnerstag
Date: Fri Dec 3 18:45:58 2010
New Revision: 1041947
URL: http://svn.apache.org/viewvc?rev=1041947view=rev
Log:
fixed WICKET-3222 AbstractMarkupParser doesn't remove Comments correctly
Issue: WICKET-3222
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/AbstractMarkupParser.java
wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/MarkupParserTest.java
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/AbstractMarkupParser.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/AbstractMarkupParser.java?rev=1041947r1=1041946r2=1041947view=diff
==
---
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/AbstractMarkupParser.java
(original)
+++
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/AbstractMarkupParser.java
Fri Dec 3 18:45:58 2010
@@ -30,7 +30,6 @@ import org.apache.wicket.markup.parser.f
import org.apache.wicket.settings.IMarkupSettings;
import org.apache.wicket.util.resource.ResourceStreamNotFoundException;
import org.apache.wicket.util.resource.StringResourceStream;
-import org.apache.wicket.util.string.AppendingStringBuffer;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -404,9 +403,9 @@ public abstract class AbstractMarkupPars
int pos1 = rawMarkup.indexOf(!--);
while (pos1 != -1)
{
- final int pos2 = rawMarkup.indexOf(--, pos1 + 4);
+ int pos2 = rawMarkup.indexOf(--, pos1 + 4);
- final AppendingStringBuffer buf = new
AppendingStringBuffer(rawMarkup.length());
+ final StringBuilder buf = new
StringBuilder(rawMarkup.length());
if (pos2 != -1)
{
final String comment = rawMarkup.substring(pos1
+ 4, pos2);
@@ -424,8 +423,12 @@ public abstract class AbstractMarkupPars
}
rawMarkup = buf.toString();
}
+ else
+ {
+ pos1 = pos2;
+ }
}
- pos1 = rawMarkup.length() = pos1 + 2 ? -1 :
rawMarkup.indexOf(!--, pos1 + 4);
+ pos1 = rawMarkup.indexOf(!--, pos1);
}
return rawMarkup;
}
Modified:
wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/MarkupParserTest.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/MarkupParserTest.java?rev=1041947r1=1041946r2=1041947view=diff
==
---
wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/MarkupParserTest.java
(original)
+++
wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/MarkupParserTest.java
Fri Dec 3 18:45:58 2010
@@ -182,7 +182,8 @@ public final class MarkupParserTest exte
final String extension)
{
final String path = cls.getName().replace('.', '/');
- final IResourceStream resource = locator.locate(cls, path,
style, variation, locale, extension, false);
+ final IResourceStream resource = locator.locate(cls, path,
style, variation, locale,
+ extension, false);
return new MarkupResourceStream(resource, null, null);
}
@@ -388,7 +389,8 @@ public final class MarkupParserTest exte
assertEquals(html, ((ComponentTag)markup.get(0)).getName());
assertEquals(html, ((ComponentTag)markup.get(2)).getName());
assertEquals(true, markup.get(1) instanceof RawMarkup);
- assertEquals(script language=\JavaScript\... x a
.../script, markup.get(1).toString());
+ assertEquals(script language=\JavaScript\... x a
.../script, markup.get(1)
+ .toString());
}
/**
@@ -413,4 +415,20 @@ public final class MarkupParserTest exte
t = (ComponentTag)markup.get(2);
assertEquals(t.getId(), span2);
}
+
+ /**
+*
+* @throws IOException
+* @throws ResourceStreamNotFoundException
+*/
+ public final void testComments() throws IOException,
ResourceStreamNotFoundException
+ {
+
tester.getApplication().getMarkupSettings().setStripComments(true);
+ final MarkupParser parser = new MarkupParser(
+ span!-- c1 -- !-- c2 --!-- c3 --/span);
+ IMarkupFragment markup = parser.parse();
+
+ RawMarkup raw = (RawMarkup)markup.get(0);
+ assertEquals(span /span,
svn commit: r1041955 - in /wicket/trunk/wicket/src/main/java/org/apache/wicket: ./ markup/ markup/html/panel/ markup/resolver/ request/handler/
Author: jdonnerstag
Date: Fri Dec 3 19:05:33 2010
New Revision: 1041955
URL: http://svn.apache.org/viewvc?rev=1041955view=rev
Log:
transient MarkupContainer.markupStream no longer needed (because of markup
fragments)
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/MarkupContainer.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/Page.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/DefaultMarkupCacheKeyProvider.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/IMarkupCache.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/MarkupCache.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/panel/Fragment.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/resolver/AutoLinkResolver.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/request/handler/PageProvider.java
Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java?rev=1041955r1=1041954r2=1041955view=diff
==
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java
(original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java Fri Dec
3 19:05:33 2010
@@ -2154,7 +2154,7 @@ public abstract class Component
*if this is false only the PREPARED_FOR_RENDER flag is
removed from component, the
*RENDERING flag is not set.
*
-* @see #prepareForRender(boolean)
+* @see #internalPrepareForRender(boolean)
*/
public final void markRendering(boolean setRenderingFlag)
{
@@ -2194,19 +2194,14 @@ public abstract class Component
* p
* Prepares the component and it's children for rendering. On whole
page render this method must
* be called on the page. On AJAX request, this method must be called
on updated component.
-* /p
-*
-* TODO this method is not part of public api, so rename to
internalPrepareForRender
*
* @param setRenderingFlag
*Whether to set the rendering flag. This must be true if
the page is about to be
*rendered. However, there are usecases to call this method
without an immediate
*render (e.g. on stateless listner request target to build
the component
*hierarchy), in that case setRenderingFlag should be false
-*
-*
*/
- public void prepareForRender(boolean setRenderingFlag)
+ public void internalPrepareForRender(boolean setRenderingFlag)
{
beforeRender();
@@ -2245,7 +2240,7 @@ public abstract class Component
*/
public final void prepareForRender()
{
- prepareForRender(true);
+ internalPrepareForRender(true);
}
/**
@@ -2291,11 +2286,11 @@ public abstract class Component
MarkupContainer parent = getParent();
if ((parent == null) || (parent.getFlag(FLAG_RENDERING)
== false) || isAuto())
{
- prepareForRender(true);
+ internalPrepareForRender(true);
}
// Do the render
- render_();
+ internalRender();
}
catch (final RuntimeException ex)
{
@@ -2329,20 +2324,19 @@ public abstract class Component
/**
* Performs a render of this component as part of a Page level render
process.
*/
- private final void render_()
+ private final void internalRender()
{
- // Step 1: Make sure there is a markup available for the
Component
+ // Make sure there is a markup available for the Component
IMarkupFragment markup = getMarkup();
if (markup == null)
{
throw new MarkupNotFoundException(Markup not found for
Component: + toString());
}
- // Step 2: A markup stream based on the markup should yield the
same result.
- // We want to use the new markup stream
+ // MarkupStream is an Iterator for the markup
MarkupStream markupStream = new MarkupStream(markup);
- setMarkupStream(markupStream);
+ // Flag: we stated the render process
markRendering(true);
MarkupElement elem = markup.get(0);
@@ -3956,21 +3950,6 @@ public abstract class Component
}
/**
-* The markup stream will be assigned to the
[jira] Commented: (WICKET-3221) don't use @see upperClass when javadoc inheritance is sufficient
[
https://issues.apache.org/jira/browse/WICKET-3221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12966634#action_12966634
]
Juergen Donnerstag commented on WICKET-3221:
The same seems to be true for Interface implementations.
Instead of removing the comment alltogether, an empty comment seem to work as
well, at least in eclipse
/**
*
*/
I personnelly like the visual separation provided by a comment on top of the
method.
don't use @see upperClass when javadoc inheritance is sufficient
Key: WICKET-3221
URL: https://issues.apache.org/jira/browse/WICKET-3221
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.5-M3
Reporter: Peter Ertl
I see this all the time:
/**
* @see org.apache.wicket.Application#getApplicationKey()
*/
@Override
public final String getApplicationKey()
{
return getName();
}
The javadoc links to the parent javadoc using @see.
This is not required since javadoc inheritance is enabled by default. Unless
you want to modify the javadoc from the parent class it's sufficient to just
don't declare javadoc at all. less work and better result!
@Override
public final String getApplicationKey()
{
return getName();
}
will automatically inherit the javadoc from the method it overrides.
Quite often the @see link is broken after refactoring.
So the @see generates a lot of unnessecary work (fix links after refactors)
and makes javadoc less usable.
Shouldn't we just abandon that style of documentation if the parent javadoc
is fine for the child?
??
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-3223) OpaqueRegion subtract for-loop does not process all rectangles
OpaqueRegion subtract for-loop does not process all rectangles
--
Key: WICKET-3223
URL: https://issues.apache.org/jira/browse/WICKET-3223
Project: Wicket
Issue Type: Bug
Components: wicket-extensions
Affects Versions: 1.5-M3
Environment: all
Reporter: Richard Emberson
Priority: Minor
Don't know it this is a bug or not.
In the extendsions class OpaqueRegion, the subtract method has a for-loop that
works its way over the members of the workList:
// Go through work list to remove the given rectangle
for (int i = 0; i workList.size(); i++)
In this loop is the following code:
if (rx1 = x1 rx2 = x2)
{
// Whole rectangle is obscured
workList.remove(i);
}
The remove on the ArrayList removes the element at position i and shifts all
higher elements
of the list down one index. The element that was at i+1 is now at i.
But the loop then increments i, so the element that was at i+1 prior to the
removal of the
element at i, is now at position i and is never examined in the loop.
So, I do not know if this is correct or not, thanks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
svn commit: r1041973 - in /wicket/trunk: wicket-util/src/main/java/org/apache/wicket/util/resource/ wicket/src/main/java/org/apache/wicket/markup/ wicket/src/main/java/org/apache/wicket/markup/loader/
Author: jdonnerstag
Date: Fri Dec 3 20:10:34 2010
New Revision: 1041973
URL: http://svn.apache.org/viewvc?rev=1041973view=rev
Log:
don't use @see upperClass when javadoc inheritance is sufficient
Issue: WICKET-3221
Modified:
wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/resource/AbstractResourceStream.java
wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/resource/FileResourceStream.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/Markup.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/MarkupCache.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/MarkupFragment.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/MarkupParser.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/MarkupResourceStream.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/MergedMarkup.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/loader/DefaultMarkupLoader.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/loader/InheritedMarkupMarkupLoader.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/loader/SimpleMarkupLoader.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/TagAttributes.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/XmlPullParser.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/XmlTag.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/filter/BaseMarkupFilter.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/filter/EnclosureHandler.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/filter/HeadForceTagIdHandler.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/filter/HtmlHandler.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/filter/HtmlHeaderSectionHandler.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/filter/HtmlProblemFinder.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/filter/OpenCloseTagExpander.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/filter/RelativePathPrefixHandler.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/filter/RootMarkupFilter.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/filter/WicketLinkTagHandler.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/filter/WicketMessageTagHandler.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/filter/WicketNamespaceHandler.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/parser/filter/WicketRemoveTagHandler.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/resource/AbstractResourceStreamWriter.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/resource/PackageResourceStream.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/resource/UrlResourceStream.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/resource/WebExternalResourceStream.java
Modified:
wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/resource/AbstractResourceStream.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/resource/AbstractResourceStream.java?rev=1041973r1=1041972r2=1041973view=diff
==
---
wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/resource/AbstractResourceStream.java
(original)
+++
wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/resource/AbstractResourceStream.java
Fri Dec 3 20:10:34 2010
@@ -35,73 +35,46 @@ public abstract class AbstractResourceSt
private String style;
private String variation;
- /**
-* @see org.apache.wicket.util.resource.IResourceStream#getLocale()
-*/
public Locale getLocale()
{
return locale;
}
- /**
-* @see
org.apache.wicket.util.resource.IResourceStream#setLocale(java.util.Locale)
-*/
public void setLocale(Locale locale)
{
this.locale = locale;
}
- /**
-* @see org.apache.wicket.util.resource.IResourceStream#getStyle()
-*/
public String getStyle()
{
return style;
}
- /**
-* @see org.apache.wicket.util.resource.IResourceStream#getVariation()
-*/
public String getVariation()
{
return variation;
}
- /**
-* @see
org.apache.wicket.util.resource.IResourceStream#setStyle(java.lang.String)
-*/
public void setStyle(String style)
{
this.style = style;
}
- /**
-* @see
[jira] Commented: (WICKET-3186) http://wicket.apache.org/learn/examples/stockquote.html is missing
[ https://issues.apache.org/jira/browse/WICKET-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12966651#action_12966651 ] Bernard Niset commented on WICKET-3186: --- Additionally, some pages in the live action examples give Internal Error: * http://wicketstuff.org/wicket14/repeater/?wicket:bookmarkablePage=:org.apache.wicket.examples.repeater.RepeatingPage * http://wicketstuff.org/wicket14/repeater/?wicket:bookmarkablePage=:org.apache.wicket.examples.repeater.RefreshingPage * http://wicketstuff.org/wicket14/repeater/?wicket:bookmarkablePage=:org.apache.wicket.examples.repeater.FormPage The company I work for is currently evaluating using Wicket for some part of a new Portal. Such broken links give a bad impression to management when they try to get some information on the product. Thanks for doing something about this problem. Bernard. http://wicket.apache.org/learn/examples/stockquote.html is missing -- Key: WICKET-3186 URL: https://issues.apache.org/jira/browse/WICKET-3186 Project: Wicket Issue Type: Task Components: site Reporter: Martin Grigorov Priority: Minor The link to Stock quote example at http://wicket.apache.org/learn/examples/stockquote.html is broken (returns 404). There is no such .md file for this example. We should either create the example or remove it from index.md. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r1041975 - in /wicket/trunk: wicket-util/src/main/java/org/apache/wicket/util/diff/ wicket-util/src/main/java/org/apache/wicket/util/lang/ wicket-util/src/main/java/org/apache/wicket/util/
Author: jdonnerstag Date: Fri Dec 3 20:17:31 2010 New Revision: 1041975 URL: http://svn.apache.org/viewvc?rev=1041975view=rev Log: don't use @see upperClass when javadoc inheritance is sufficient Issue: WICKET-3221 Modified: wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/diff/Revision.java wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/lang/EnumeratedType.java wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/time/TimeMap.java wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/renderStrategy/AbstractHeaderRenderStrategy.java wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/repeater/AbstractRepeater.java wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/repeater/data/EmptyDataProvider.java wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/resolver/AutoComponentResolver.java wicket/trunk/wicket/src/main/java/org/apache/wicket/pageStore/FileChannelPool.java wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/servlet/MultipartServletWebRequestImpl.java wicket/trunk/wicket/src/main/java/org/apache/wicket/resource/loader/ValidatorStringResourceLoader.java wicket/trunk/wicket/src/main/java/org/apache/wicket/util/lang/PropertyResolver.java wicket/trunk/wicket/src/main/java/org/apache/wicket/util/tester/TagTester.java wicket/trunk/wicket/src/test/java/org/apache/wicket/RemoveTestPage.java wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/panel/InlinePanelPage_5.java wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/parser/filter/HeaderSectionPage_9a.java wicket/trunk/wicket/src/test/java/org/apache/wicket/protocol/http/ModifyCookiePage.java wicket/trunk/wicket/src/test/java/org/apache/wicket/request/mapper/BasicResourceReferenceMapperTest.java Modified: wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/diff/Revision.java URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/diff/Revision.java?rev=1041975r1=1041974r2=1041975view=diff == --- wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/diff/Revision.java (original) +++ wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/diff/Revision.java Fri Dec 3 20:17:31 2010 @@ -59,7 +59,6 @@ package org.apache.wicket.util.diff; import java.util.ArrayList; import java.util.Arrays; -import java.util.Iterator; import java.util.LinkedList; import java.util.List; import java.util.ListIterator; Modified: wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/lang/EnumeratedType.java URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/lang/EnumeratedType.java?rev=1041975r1=1041974r2=1041975view=diff == --- wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/lang/EnumeratedType.java (original) +++ wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/lang/EnumeratedType.java Fri Dec 3 20:17:31 2010 @@ -17,7 +17,6 @@ package org.apache.wicket.util.lang; import java.util.ArrayList; -import java.util.Iterator; import java.util.List; import java.util.Map; Modified: wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/time/TimeMap.java URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/time/TimeMap.java?rev=1041975r1=1041974r2=1041975view=diff == --- wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/time/TimeMap.java (original) +++ wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/time/TimeMap.java Fri Dec 3 20:17:31 2010 @@ -17,7 +17,6 @@ package org.apache.wicket.util.time; import java.io.Serializable; -import java.util.Iterator; import java.util.Map; import java.util.concurrent.ConcurrentHashMap; Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java URL: http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java?rev=1041975r1=1041974r2=1041975view=diff == --- wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java (original) +++ wicket/trunk/wicket/src/main/java/org/apache/wicket/Component.java Fri Dec 3 20:17:31 2010 @@ -3510,7 +3510,6 @@ public abstract class Component * @param M *A class derived from IBehavior */ -
svn commit: r1041989 - in /wicket/trunk: wicket-request/src/main/java/org/apache/wicket/request/ wicket-request/src/main/java/org/apache/wicket/request/mapper/ wicket-request/src/main/java/org/apache/
Author: jdonnerstag
Date: Fri Dec 3 20:53:01 2010
New Revision: 1041989
URL: http://svn.apache.org/viewvc?rev=1041989view=rev
Log:
don't use @see upperClass when javadoc inheritance is sufficient
Issue: WICKET-3221
Removed:
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/IScopedComponent.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/resolver/ScopedComponentResolver.java
wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/ScopedComponentResolverTest.java
wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/ScopedLabel.java
wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/ScopedLink.java
wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/ScopedPage.html
wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/ScopedPage.java
wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/ScopedPageExpectedResult.html
Modified:
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/Url.java
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/mapper/AbstractMapper.java
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/mapper/mount/Mount.java
wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/collections/MultiMap.java
wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/listener/ChangeListenerSet.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/Behaviors.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/SharedResources.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/ThreadContext.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/application/ComponentInitializationListenerCollection.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/application/ComponentInstantiationListenerCollection.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/application/ComponentOnAfterRenderListenerCollection.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/application/ComponentOnBeforeRenderListenerCollection.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/pages/BrowserInfoPage.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/repeater/Item.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/resolver/AutoComponentResolver.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletResponse.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/request/cycle/AbstractRequestCycleListener.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/request/cycle/RequestCycleListenerCollection.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/request/handler/ComponentRenderingRequestHandler.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/request/mapper/BasicResourceReferenceMapper.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/resource/loader/ComponentStringResourceLoader.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/response/ByteArrayResponse.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/lang/PropertyResolver.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/string/ComponentStrings.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java
wicket/trunk/wicket/src/test/java/org/apache/wicket/markup/html/link/BookmarkablePageLinkTest.java
Modified:
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/Url.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/Url.java?rev=1041989r1=1041988r2=1041989view=diff
==
---
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/Url.java
(original)
+++
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/Url.java
Fri Dec 3 20:53:01 2010
@@ -623,6 +623,8 @@ public final class Url implements Serial
*/
public final static class QueryParameter implements Serializable
{
+ private static final long serialVersionUID = 1L;
+
private final String name;
private final String value;
Modified:
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/mapper/AbstractMapper.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/mapper/AbstractMapper.java?rev=1041989r1=1041988r2=1041989view=diff
==
---
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/mapper/AbstractMapper.java
(original)
+++
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/mapper/AbstractMapper.java
Fri Dec 3 20:53:01 2010
@@ -16,7 +16,6 @@
*/
package
[jira] Created: (WICKET-3224) FileCleaner issues
FileCleaner issues -- Key: WICKET-3224 URL: https://issues.apache.org/jira/browse/WICKET-3224 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.5-M3 Reporter: Juergen Donnerstag I failed to apply Generics to FileCleaner. While doing so, it became obvious that the current code can't work. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3215) AutoCompleteTextField does not work in an iframe under IE 6, 7 or 8
[ https://issues.apache.org/jira/browse/WICKET-3215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12966741#action_12966741 ] Pedro Santos commented on WICKET-3215: -- Just trying to explain the hack: after show the options list, the text field wasn't losing the focus, but the text cursor disappeared or goes to the wrong position. Rather than create an cursor position cache to be restored, I just realise that the selection bounds were already on the IE selection object, and just by invoking the select method from its API the cursor reappeared or got the right position. AutoCompleteTextField does not work in an iframe under IE 6, 7 or 8 --- Key: WICKET-3215 URL: https://issues.apache.org/jira/browse/WICKET-3215 Project: Wicket Issue Type: Bug Components: wicket-extensions Affects Versions: 1.4.11, 1.4.12, 1.4.13, 1.4.14 Environment: Windows Server 2003 Reporter: Robert Csok Assignee: Pedro Santos Fix For: 1.4.15, 1.5-M4 Attachments: HomePage.html, HomePage.java, iframe.html The code that has been integrated in version 1.4.11 to fix issue WICKET-2279 forces the cursor of an AutoCompleteTextField to do a carriage return after each typed in char when the application runs in an iframe and IE 6, 7 or 8 is used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3215) AutoCompleteTextField does not work in an iframe under IE 6, 7 or 8
[ https://issues.apache.org/jira/browse/WICKET-3215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12966749#action_12966749 ] Hudson commented on WICKET-3215: Integrated in Apache Wicket 1.4.x #308 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/308/]) AutoCompleteTextField does not work in an iframe under IE 6, 7 or 8 --- Key: WICKET-3215 URL: https://issues.apache.org/jira/browse/WICKET-3215 Project: Wicket Issue Type: Bug Components: wicket-extensions Affects Versions: 1.4.11, 1.4.12, 1.4.13, 1.4.14 Environment: Windows Server 2003 Reporter: Robert Csok Assignee: Pedro Santos Fix For: 1.4.15, 1.5-M4 Attachments: HomePage.html, HomePage.java, iframe.html The code that has been integrated in version 1.4.11 to fix issue WICKET-2279 forces the cursor of an AutoCompleteTextField to do a carriage return after each typed in char when the application runs in an iframe and IE 6, 7 or 8 is used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2279) Losing focus on Autocomplete field if DropDownChoice is updated using Ajax.
[ https://issues.apache.org/jira/browse/WICKET-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12966750#action_12966750 ] Hudson commented on WICKET-2279: Integrated in Apache Wicket 1.4.x #308 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/308/]) Losing focus on Autocomplete field if DropDownChoice is updated using Ajax. --- Key: WICKET-2279 URL: https://issues.apache.org/jira/browse/WICKET-2279 Project: Wicket Issue Type: Bug Components: wicket, wicket-extensions Affects Versions: 1.4-RC2, 1.4-RC4 Environment: Error exposed in IE 6, 7, 8. Works in Firefox, Chrome. Reporter: Aslak Knutsen Assignee: Igor Vaynberg Priority: Minor Fix For: 1.4.11 Attachments: AutoCompleteFocusIssuePage.html, AutoCompleteFocusIssuePage.java It seems that if a DropDownChoice is updated with ajax, the next AutoComplete field will lose focus when triggered if the updated DropDownChoice have had focus inbetween beeing updated and AutoComplete is triggered. But only if focus on the DropDownChoice is gained/lost using KEY_TAB. More description in the attached example.. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-3226) NavigationToolbar has table instance variable but so does base-class AbstractToolbar
NavigationToolbar has table instance variable but so does base-class AbstractToolbar Key: WICKET-3226 URL: https://issues.apache.org/jira/browse/WICKET-3226 Project: Wicket Issue Type: Bug Components: wicket-extensions Affects Versions: 1.5-M3 Environment: all Reporter: Richard Emberson Priority: Trivial The class NavigationToolbar has DataTable[_] table as instance variable but also passes the same table to the base-class AbstractToolbar which has a protected method getTable which returns the same table. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
