svn commit: r1085272 - in /wicket/trunk/wicket-core/src: main/java/org/apache/wicket/markup/ test/java/org/apache/wicket/markup/html/basic/ test/java/org/apache/wicket/markup/html/page/
Author: jdonnerstag
Date: Fri Mar 25 07:48:41 2011
New Revision: 1085272
URL: http://svn.apache.org/viewvc?rev=1085272view=rev
Log:
rename Markup.get(String) to .of(String)
Modified:
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/IMarkupResourceStreamProvider.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/Markup.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/SimplePage_3.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/page/SimplePanel.java
Modified:
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/IMarkupResourceStreamProvider.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/IMarkupResourceStreamProvider.java?rev=1085272r1=1085271r2=1085272view=diff
==
---
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/IMarkupResourceStreamProvider.java
(original)
+++
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/IMarkupResourceStreamProvider.java
Fri Mar 25 07:48:41 2011
@@ -23,6 +23,9 @@ import org.apache.wicket.util.resource.I
* To be implemented by MarkupContainer which wish to implement their own
algorithms for loading the
* markup resource stream.
* p
+ * Since 1.5 you may also use Component.setMarkup() or getMarkup() to attach
Markup to your
+ * component.
+ * p
* Note: IResourceStreamLocators should be used in case the strategy to find a
markup resource is
* meant to be applied to ALL components of your application.
* p
Modified:
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/Markup.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/Markup.java?rev=1085272r1=1085271r2=1085272view=diff
==
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/Markup.java
(original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/Markup.java
Fri Mar 25 07:48:41 2011
@@ -55,10 +55,15 @@ public class Markup implements IMarkupFr
/**
* Take the markup string, parse it and return the Markup (list of
MarkupElements).
+* p
+* Limitation: Please note that MarkupFactory is NOT used and thus no
caching is used (which
+* doesn't matter for Strings anyway), but what might matter is that
your own MarkupFilters are
+* not applied, which you might have registered with MarkupFactory.
+*
* @param markup
* @return Markup
*/
- public static Markup get(final String markup)
+ public static Markup of(final String markup)
{
try
{
Modified:
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/SimplePage_3.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/SimplePage_3.java?rev=1085272r1=1085271r2=1085272view=diff
==
---
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/SimplePage_3.java
(original)
+++
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/basic/SimplePage_3.java
Fri Mar 25 07:48:41 2011
@@ -47,7 +47,7 @@ public class SimplePage_3 extends Simple
@Override
public IMarkupFragment getMarkup()
{
- return Markup.get(html xmlns:wicketbody //
+ return Markup.of(html xmlns:wicketbody //
+ span wicket:id='myLabel'mein Label/span //
+ span wicket:id='test'body/span //
+ span wicket:id='myPanel'panel/span //
Modified:
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/page/SimplePanel.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/page/SimplePanel.java?rev=1085272r1=1085271r2=1085272view=diff
==
---
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/page/SimplePanel.java
(original)
+++
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/markup/html/page/SimplePanel.java
Fri Mar 25 07:48:41 2011
@@ -44,6 +44,6 @@ public class SimplePanel extends Panel
@Override
public IMarkupFragment getMarkup()
{
- return Markup.get(wicket:panelspan
wicket:id='label'/span/wicket:panel);
+ return Markup.of(wicket:panelspan
wicket:id='label'/span/wicket:panel);
}
}
[jira] [Created] (WICKET-3557) Can not add validator to AjaxEditableLabel unless it was added to page
Can not add validator to AjaxEditableLabel unless it was added to page -- Key: WICKET-3557 URL: https://issues.apache.org/jira/browse/WICKET-3557 Project: Wicket Issue Type: Bug Components: wicket-extensions Reporter: Erik van Oosten Priority: Minor Method AjaxEditableLabel#add(IValidator) tries to add the validator to the editor. As the editor initiaily does not exist, it is created. Creation of the editor fails when the component has not been added to the page yet. Workaround: add the AjaxEditableLabel to page before adding the validator(s). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (WICKET-3558) Expose active requests via JMX
Expose active requests via JMX -- Key: WICKET-3558 URL: https://issues.apache.org/jira/browse/WICKET-3558 Project: Wicket Issue Type: Improvement Components: wicket-jmx Affects Versions: 1.4.16 Reporter: Dominik Drzewiecki Priority: Minor It'd be nice if RequestLogger.active was exposed via JMX in the same manner the RequestLogger.liveSessions.size() is. Moreover it'd be great to track and expose the peak number of concurrent (active) requests. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3558) Expose active requests via JMX
[ https://issues.apache.org/jira/browse/WICKET-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011231#comment-13011231 ] Martin Grigorov commented on WICKET-3558: - Provide a patch please. Thanks! Expose active requests via JMX -- Key: WICKET-3558 URL: https://issues.apache.org/jira/browse/WICKET-3558 Project: Wicket Issue Type: Improvement Components: wicket-jmx Affects Versions: 1.4.16 Reporter: Dominik Drzewiecki Priority: Minor Attachments: exposeActiveViaJMX.patch It'd be nice if RequestLogger.active was exposed via JMX in the same manner the RequestLogger.liveSessions.size() is. Moreover it'd be great to track and expose the peak number of concurrent (active) requests. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-3558) Expose active requests via JMX
[ https://issues.apache.org/jira/browse/WICKET-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominik Drzewiecki updated WICKET-3558: --- Attachment: exposeActiveViaJMX.patch Expose active requests via JMX -- Key: WICKET-3558 URL: https://issues.apache.org/jira/browse/WICKET-3558 Project: Wicket Issue Type: Improvement Components: wicket-jmx Affects Versions: 1.4.16 Reporter: Dominik Drzewiecki Priority: Minor Attachments: exposeActiveViaJMX.patch It'd be nice if RequestLogger.active was exposed via JMX in the same manner the RequestLogger.liveSessions.size() is. Moreover it'd be great to track and expose the peak number of concurrent (active) requests. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
svn commit: r1085437 [3/3] - in /wicket/common/site/trunk: _site/ _site/2009/07/30/ _site/2009/08/21/ _site/2009/10/12/ _site/2009/10/24/ _site/2009/12/13/ _site/2009/12/21/ _site/2010/02/01/ _site/20
Modified: wicket/common/site/trunk/_site/learn/examples/navomatic.html
URL:
http://svn.apache.org/viewvc/wicket/common/site/trunk/_site/learn/examples/navomatic.html?rev=1085437r1=1085436r2=1085437view=diff
==
--- wicket/common/site/trunk/_site/learn/examples/navomatic.html (original)
+++ wicket/common/site/trunk/_site/learn/examples/navomatic.html Fri Mar 25
16:00:25 2011
@@ -171,148 +171,37 @@
pFor example, here is markup for a simple Border subclass, a usage of that
border, and the markup which would be output on rendering:/p
h3 id='border_markup'Border markup/h3
-div class='highlight'precode class='html'span
class='nt'lt;htmlgt;/span
-span class='nt'lt;bodygt;/span
-span class='nt'lt;wicket:bordergt;/span
-First span class='nt'lt;wicket:body/gt;/span Last
-span class='nt'lt;/wicket:bordergt;/span
-span class='nt'lt;/bodygt;/span
-span class='nt'lt;/htmlgt;/span
-/code/pre
-/div
+
h3 id='border_usage'Border usage/h3
-div class='highlight'precode class='html'span
class='nt'lt;htmlgt;/span
-span class='nt'lt;bodygt;/span
- span class='nt'lt;span/span span class='na'wicket:id =/spanspan
class='err' /spanspan class='s'quot;myBorderquot;/spanspan
class='nt'gt;/span
- Middle
- span class='nt'lt;/spangt;/span
-span class='nt'lt;/bodygt;/span
-span class='nt'lt;/htmlgt;/span
-/code/pre
-/div
+
h3 id='rendered_markup'Rendered markup/h3
-div class='highlight'precode class='html'span
class='nt'lt;htmlgt;/span
-span class='nt'lt;bodygt;/span
- First Middle Last
-span class='nt'lt;/bodygt;/span
-span class='nt'lt;/htmlgt;/span
-/code/pre
-/div
+
pIn other words, the markup around the codelt;wicket:body/gt;/code tag
in the border component is sort of #8220;wrapped around#8221; the body of the
codelt;spangt;/code tag where the border is used. This seems simple in
this example, but keep in mind that nested components and even nested borders
can appear anywhere in either markup file. This can be used to create quite
complex effects with relatively little code./p
h3 id='navomaticapplicationjava'NavomaticApplication.java/h3
pJust as in the Hello World! example, we need to define our application. In
this case, we set Page1 to be our home page./p
-div class='highlight'precode class='java'span class='kn'package/span
span class='n'org/spanspan class='o'./spanspan
class='na'apache/spanspan class='o'./spanspan
class='na'wicket/spanspan class='o'./spanspan
class='na'examples/spanspan class='o'./spanspan
class='na'navomatic/spanspan class='o';/span
-span class='kn'import/span span
class='nn'org.apache.wicket.protocol.http.WebApplication/spanspan
class='o';/span
-
-span class='kd'public/span span class='kd'class/span span
class='nc'NavomaticApplication/span span class='kd'extends/span span
class='n'WebApplication/span span class='o'{/span
-span class='kd'public/span span
class='nf'NavomaticApplication/spanspan class='o'()/span span
class='o'{/span
-span class='o'}/span
-
-span class='kd'public/span span class='n'Class/span span
class='nf'getHomePage/spanspan class='o'()/span span class='o'{/span
-span class='k'return/span span class='n'Page1/spanspan
class='o'./spanspan class='na'class/spanspan class='o';/span
-span class='o'}/span
-span class='o'}/span
-/code/pre
-/div
h3 id='page1java'Page1.java/h3
pThe Page1 Java and HTML files look like this:/p
-div class='highlight'precode class='java'span class='kn'package/span
span class='n'wicket/spanspan class='o'./spanspan
class='na'examples/spanspan class='o'./spanspan
class='na'navomatic/spanspan class='o';/span
-
-span class='kn'import/span span
class='nn'org.apache.wicket.markup.html.WebPage/spanspan class='o';/span
-span class='kd'public/span span class='kd'class/span span
class='nc'Page1/span span class='kd'extends/span span
class='n'WebPage/span span class='o'{/span
-span class='kd'public/span span class='nf'Page1/spanspan
class='o'()/span span class='o'{/span
-span class='n'add/spanspan class='o'(/spanspan
class='k'new/span span class='n'NavomaticBorder/spanspan
class='o'(/spanspan class='s'quot;navomaticBorderquot;/spanspan
class='o'));/span
-span class='o'}/span
-span class='o'}/span
-/code/pre
-/div
h3 id='page1html'Page1.html/h3
-div class='highlight'precode class='html'span
class='nt'lt;htmlgt;/span
-span class='nt'lt;bodygt;/span
-span class='nt'lt;span/span span class='na'wicket:id =/spanspan
class='err' /spanspan class='s'quot;navomaticBorderquot;/spanspan
class='nt'gt;/span
-You are viewing Page1
-span class='nt'lt;/spangt;/span
-span class='nt'lt;/bodygt;/span
-span class='nt'lt;/htmlgt;/span
-/code/pre
-/div
+
pNotice that the NavomaticBorder component is attached to the
codelt;spangt;/code tag because the name of the component in the Java
code is #8220;navomaticBorder#8221; and the codelt;spangt;/code
tag#8217;s wicket:id attribute is set to
svn commit: r1085441 - in /wicket/common/site/trunk/_site/learn/books: awc.html awc.jpg
Author: ivaynberg Date: Fri Mar 25 16:03:26 2011 New Revision: 1085441 URL: http://svn.apache.org/viewvc?rev=1085441view=rev Log: generated Apache Wicket Cookbook files Added: wicket/common/site/trunk/_site/learn/books/awc.html wicket/common/site/trunk/_site/learn/books/awc.jpg (with props) Added: wicket/common/site/trunk/_site/learn/books/awc.html URL: http://svn.apache.org/viewvc/wicket/common/site/trunk/_site/learn/books/awc.html?rev=1085441view=auto == --- wicket/common/site/trunk/_site/learn/books/awc.html (added) +++ wicket/common/site/trunk/_site/learn/books/awc.html Fri Mar 25 16:03:26 2011 @@ -0,0 +1,248 @@ +!DOCTYPE html +html +head +titleApache Wicket - Books â Apache Wicket Cookbook/title + + link rel=stylesheet href=/css/screen.css type=text/css media=screen / + +!--[if lt ie 7] + link rel=stylesheet href=/css/ie.css type=text/css media=screen / +![endif]-- +link rel=shortcut icon href=/favicon.ico type=image/vnd.microsoft.icon / + link rel=alternate type=application/atom+xml href=/atom.xml / + meta http-equiv=content-type content=text/html;charset=utf-8 / +/head +body +div id=container +div id=content +div id=headera href=/h1 id=logospanApache Wicket/span/h1/a/div + div id=navigation + h5a name=Navigation-Wicket/aMeet Wicket/h5 + ul + li + a href=/ title=IndexHome/a + /li + li + a href=/meet/introduction.html title=IntroductionIntroduction/a + /li + li + a href=/meet/features.html title=FeaturesFeatures/a + /li + li + a href=/meet/buzz.html title=BuzzBuzz/a + /li + li + a href=/meet/vision.html title=VisionVision/a + /li + li + a href=/meet/blogs.html title=BlogsBlogs/a + /li + /ul + h5 + a name=Navigation-GettingStarted id=Navigation-GettingStarted/aGet Started + /h5 + ul + li + a href=/start/download.html title=Download WicketDownload Wicket/a + /li + li + a href=/start/quickstart.html title=Getting started via a Maven ArchetypeQuickstart/a + /li + li + a href=http://www.jweekend.com/dev/LegUp; rel=nofollowMore archetypes/a + /li + li + a href=/help title=Get helpGet help/a + /li + /ul + h5 + a name=Navigation-Documentation id=Navigation-Documentation/aLearn + /h5 + ul + li + a href=/learn/examples title=ExamplesExamples/a + /li + li + a href=http://wicketstuff.org/wicket14/compref/;Components/a + /li + li + a href=/learn/projects/ title=Projects extending basic WicketProjects/a + /li + li + a href=http://cwiki.apache.org/WICKET;Wiki/a + /li + li + a href=http://cwiki.apache.org/WICKET/reference-library.html;Reference guide/a + /li + li + a href=/learn/books title=BooksBooks/a + /li + li + a href=/learn/ides.html title=IDEsIDE plugins/a + /li + /ul + h5 + a name=Navigation-Releases id=Navigation-Releases/aReleases + /h5 + ul + li + a href=http://www.apache.org/dyn/closer.cgi/wicket/1.4.16;Wicket 1.4/a + (a href=http://wicket.apache.org/apidocs/1.4; title=JavaDocs of the latest stable release - 1.4.xdocs/a) + /li + li + a href=http://www.apache.org/dyn/closer.cgi/wicket/1.3.7;Wicket 1.3/a + (a href=http://wicket.apache.org/apidocs/1.3; title=JavaDocs of Apache Wicket 1.3.xdocs/a) + /li + li + a href=http://wicket.sf.net/wicket-1.2; class=external-link rel=nofollowWicket 1.2/a + /li + li + a href=http://wicket.sf.net/wicket-1.1; class=external-link rel=nofollowWicket 1.1/a + /li + li + a href=http://wicket.sf.net/wicket-1.0; class=external-link rel=nofollowWicket 1.0/a + /li + /ul + h5 + a name=Navigation-Developers id=Navigation-Developers/aContribute + /h5 + ul + li + a
svn commit: r1085456 - in /wicket/common/site/trunk: _config.yml _site/atom.xml _site/learn/books/awc.html learn/books/awc.md
Author: ivaynberg Date: Fri Mar 25 16:37:16 2011 New Revision: 1085456 URL: http://svn.apache.org/viewvc?rev=1085456view=rev Log: corrected some marketing speak from PACKT's side Modified: wicket/common/site/trunk/_config.yml wicket/common/site/trunk/_site/atom.xml wicket/common/site/trunk/_site/learn/books/awc.html wicket/common/site/trunk/learn/books/awc.md Modified: wicket/common/site/trunk/_config.yml URL: http://svn.apache.org/viewvc/wicket/common/site/trunk/_config.yml?rev=1085456r1=1085455r2=1085456view=diff == --- wicket/common/site/trunk/_config.yml (original) +++ wicket/common/site/trunk/_config.yml Fri Mar 25 16:37:16 2011 @@ -11,7 +11,7 @@ maruku: png_dir:images/latex png_url:/images/latex toc:true -exclude:readme.md +exclude:readme.md,tmp,regenerate.sh wicket: version:1.4.16 released: 2011-02-25 Modified: wicket/common/site/trunk/_site/atom.xml URL: http://svn.apache.org/viewvc/wicket/common/site/trunk/_site/atom.xml?rev=1085456r1=1085455r2=1085456view=diff == --- wicket/common/site/trunk/_site/atom.xml (original) +++ wicket/common/site/trunk/_site/atom.xml Fri Mar 25 16:37:16 2011 @@ -4,7 +4,7 @@ titleApache Wicket/title link href=http://wicket.apache.org/atom.xml; rel=self/ link href=http://wicket.apache.org// - updated2011-03-25T08:57:59-07:00/updated + updated2011-03-25T09:32:57-07:00/updated idhttp://wicket.apache.org//id author nameApache Wicket/name Modified: wicket/common/site/trunk/_site/learn/books/awc.html URL: http://svn.apache.org/viewvc/wicket/common/site/trunk/_site/learn/books/awc.html?rev=1085456r1=1085455r2=1085456view=diff == --- wicket/common/site/trunk/_site/learn/books/awc.html (original) +++ wicket/common/site/trunk/_site/learn/books/awc.html Fri Mar 25 16:37:16 2011 @@ -152,7 +152,7 @@ pYou will learn how to integrate with client-side technologies such as JavaScript libraries or Flash components, which will help you to build your application faster. You will discover how to use Wicket paradigms to factor out commonly used code into custom Components, which will reduce the maintenance cost of your application, and how to leverage the existing Wicket Components to make your own code simpler./p -pA straightforward Cookbook with over 75 highly focused practical recipes to make your web application development easier with the Wicket web framework/p +pA straightforward Cookbook with highly focused practical recipes to make your web application development easier with the Wicket web framework/p h2 id='what_you_will_learn_from_this_book'What you will learn from this book/h2 Modified: wicket/common/site/trunk/learn/books/awc.md URL: http://svn.apache.org/viewvc/wicket/common/site/trunk/learn/books/awc.md?rev=1085456r1=1085455r2=1085456view=diff == --- wicket/common/site/trunk/learn/books/awc.md (original) +++ wicket/common/site/trunk/learn/books/awc.md Fri Mar 25 16:37:16 2011 @@ -11,7 +11,7 @@ Apache Wicket Cookbook provides you with You will learn how to integrate with client-side technologies such as JavaScript libraries or Flash components, which will help you to build your application faster. You will discover how to use Wicket paradigms to factor out commonly used code into custom Components, which will reduce the maintenance cost of your application, and how to leverage the existing Wicket Components to make your own code simpler. -A straightforward Cookbook with over 75 highly focused practical recipes to make your web application development easier with the Wicket web framework +A straightforward Cookbook with highly focused practical recipes to make your web application development easier with the Wicket web framework ## What you will learn from this book ##
svn commit: r1085472 - in /wicket/common/site/trunk: _site/index.html _site/learn/books/awc.png _site/learn/books/index.html index.md learn/books/awc.png learn/books/index.md
Author: dashorst Date: Fri Mar 25 17:00:35 2011 New Revision: 1085472 URL: http://svn.apache.org/viewvc?rev=1085472view=rev Log: Added better image for Igor's book Added: wicket/common/site/trunk/_site/learn/books/awc.png (with props) wicket/common/site/trunk/learn/books/awc.png (with props) Modified: wicket/common/site/trunk/_site/index.html wicket/common/site/trunk/_site/learn/books/index.html wicket/common/site/trunk/index.md wicket/common/site/trunk/learn/books/index.md Modified: wicket/common/site/trunk/_site/index.html URL: http://svn.apache.org/viewvc/wicket/common/site/trunk/_site/index.html?rev=1085472r1=1085471r2=1085472view=diff == --- wicket/common/site/trunk/_site/index.html (original) +++ wicket/common/site/trunk/_site/index.html Fri Mar 25 17:00:35 2011 @@ -166,39 +166,35 @@ h1 id='wicket_15rc2_released'a href='/2011/02/25/wicket-1.5-rc2-released.html'Wicket 1.5-rc2 released/a/h1 pThe Wicket Team is proud to introduce the second Release Candidate in Wicket 1.5 series. See the changelog for the list of bug fixes and improvements done between 1.5-RC1 and 1.5-rc2/ppMore detailed migration notes are available on our a href='https://cwiki.apache.org/WICKET/migration-to-wicket-15.html'Migrate to 1.5 Wiki Page/a/ppRelease Artifacts:/pul -li -pa href='http://svn.apache.org/repos/asf/wicket/releases/wicket-1.5-rc2'Subversion tag/a/p -/li +lia href='http://svn.apache.org/repos/asf/wicket/releases/wicket-1.5-rc2'Subversion tag/a/li -li -pa href='https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561amp;version=12316059'Changelog/a/p -/li +lia href='https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561amp;version=12316059'Changelog/a/li -li -pTo use in Maven:/p -/li - -li -pDownload the a href='http://www.apache.org/dyn/closer.cgi/wicket/1.5-rc2'full distribution/a (including source)/p -/li +liTo use in Maven:/li +/uldiv class='highlight'precode class='xml'span class='nt'lt;dependencygt;/span +span class='nt'lt;groupIdgt;/spanorg.apache.wicketspan class='nt'lt;/groupIdgt;/span +span class='nt'lt;artifactIdgt;/spanwicket-corespan class='nt'lt;/artifactIdgt;/span +span class='nt'lt;versiongt;/span1.5-rc2span class='nt'lt;/versiongt;/span +span class='nt'lt;/dependencygt;/span +/code/pre +/divul +liDownload the a href='http://www.apache.org/dyn/closer.cgi/wicket/1.5-rc2'full distribution/a (including source)/li /ul h1 id='wicket_1416_released'a href='/2011/02/25/wicket-1.4.16-released.html'Wicket 1.4.16 released/a/h1 pThis is sixteenth release of the Wicket 1.4.x series. This is primarily a minor bugfix release on the 1.4.x (stable) branch./pul -li -pa href='http://svn.apache.org/repos/asf/wicket/releases/wicket-1.4.16'Subversion tag/a/p -/li +lia href='http://svn.apache.org/repos/asf/wicket/releases/wicket-1.4.16'Subversion tag/a/li -li -pa href='https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561amp;version=12316020'Changelog/a/p -/li +lia href='https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561amp;version=12316020'Changelog/a/li -li -pTo use in Maven:/p -/li - -li -pDownload the a href='http://www.apache.org/dyn/closer.cgi/wicket/1.4.16'full distribution/a (including source)/p -/li +liTo use in Maven:/li +/uldiv class='highlight'precode class='xml'span class='nt'lt;dependencygt;/span +span class='nt'lt;groupIdgt;/spanorg.apache.wicketspan class='nt'lt;/groupIdgt;/span +span class='nt'lt;artifactIdgt;/spanwicketspan class='nt'lt;/artifactIdgt;/span +span class='nt'lt;versiongt;/span1.4.16span class='nt'lt;/versiongt;/span +span class='nt'lt;/dependencygt;/span +/code/pre +/divul +liDownload the a href='http://www.apache.org/dyn/closer.cgi/wicket/1.4.16'full distribution/a (including source)/li /ulh1Older news items/h1ul @@ -265,7 +261,7 @@ h1 id='books_about_wicket'Books about Wicket/h1 pThe following books are published regarding Apache Wicket (click a cover to learn more about the book):/p -a href='/learn/books/wia.html'img src='/learn/books/wia.png' height='200px' //aa href='/learn/books/ewdww.html'img src='/learn/books/ewdww.png' height='200px' //aa href='/learn/books/prowicket.html'img src='/learn/books/prowicket.png' height='200px' //aa href='/learn/books/kwij.html'img src='/learn/books/kwij.png' height='200px' //aa href='/learn/books/praxisbuchwicket.html'img src='/learn/books/praxisbuchwicket.png' height='200px' //aa href='/learn/books/wicket-jp.html'img src='/learn/books/wicket-jp.png' height='200px' //a +a href='/learn/books/awc.html'img src='/learn/books/awc.png' height='200px' //aa href='/learn/books/wia.html'img src='/learn/books/wia.png' height='200px' //aa href='/learn/books/ewdww.html'img src='/learn/books/ewdww.png' height='200px' //aa href='/learn/books/prowicket.html'img
svn commit: r1085486 - in /wicket/common/site/trunk: _posts/2011-03-25-wicket-cookbook-published.md _site/2011/03/ _site/2011/03/25/ _site/2011/03/25/wicket-cookbook-published.html _site/atom.xml _sit
Author: ivaynberg Date: Fri Mar 25 17:40:40 2011 New Revision: 1085486 URL: http://svn.apache.org/viewvc?rev=1085486view=rev Log: added book announcement Added: wicket/common/site/trunk/_posts/2011-03-25-wicket-cookbook-published.md wicket/common/site/trunk/_site/2011/03/ wicket/common/site/trunk/_site/2011/03/25/ wicket/common/site/trunk/_site/2011/03/25/wicket-cookbook-published.html Modified: wicket/common/site/trunk/_site/atom.xml wicket/common/site/trunk/_site/index.html Added: wicket/common/site/trunk/_posts/2011-03-25-wicket-cookbook-published.md URL: http://svn.apache.org/viewvc/wicket/common/site/trunk/_posts/2011-03-25-wicket-cookbook-published.md?rev=1085486view=auto == --- wicket/common/site/trunk/_posts/2011-03-25-wicket-cookbook-published.md (added) +++ wicket/common/site/trunk/_posts/2011-03-25-wicket-cookbook-published.md Fri Mar 25 17:40:40 2011 @@ -0,0 +1,14 @@ +--- +layout: post +title: Apache Wicket Cookbook Published! +--- + +img style=float: left; margin-left: 10px; margin-right: 10px; title=Apache Wicket Cookbook src=http://wicket.apache.org/learn/books/awc.jpg; alt= width=180 height=222 / +For the past nine months I have been quietly working on a book about Wicket. Unlike other books on the market this one does not attempt to teach you Wicket from the ground up. Instead, it is for developers who already know the basics and want to learn how to implement some of the more advanced use cases. Essentially, it contains recipes that show the reader how to implement solutions to some of, what I think are, the most commonly asked questions and stumbling blocks. + +This morning I was informed that the book has been published! You can read more about it and pick up a copy on a href=https://www.packtpub.com/apache-wicket-cookbook/book;PACKT's Site/a. + +I hope you enjoy it, more details are available on a href=http://wicketinaction.com/2011/03/apache-wicket-cookbook-is-published/;Wicket In Action Blog Post/a +br/br/br/br/br/ + + Added: wicket/common/site/trunk/_site/2011/03/25/wicket-cookbook-published.html URL: http://svn.apache.org/viewvc/wicket/common/site/trunk/_site/2011/03/25/wicket-cookbook-published.html?rev=1085486view=auto == --- wicket/common/site/trunk/_site/2011/03/25/wicket-cookbook-published.html (added) +++ wicket/common/site/trunk/_site/2011/03/25/wicket-cookbook-published.html Fri Mar 25 17:40:40 2011 @@ -0,0 +1,165 @@ +!DOCTYPE html +html +head +titleApache Wicket - Apache Wicket Cookbook Published!/title + + link rel=stylesheet href=/css/screen.css type=text/css media=screen / + +!--[if lt ie 7] + link rel=stylesheet href=/css/ie.css type=text/css media=screen / +![endif]-- +link rel=shortcut icon href=/favicon.ico type=image/vnd.microsoft.icon / + link rel=alternate type=application/atom+xml href=/atom.xml / + meta http-equiv=content-type content=text/html;charset=utf-8 / +/head +body +div id=container +div id=content +div id=headera href=/h1 id=logospanApache Wicket/span/h1/a/div + div id=navigation + h5a name=Navigation-Wicket/aMeet Wicket/h5 + ul + li + a href=/ title=IndexHome/a + /li + li + a href=/meet/introduction.html title=IntroductionIntroduction/a + /li + li + a href=/meet/features.html title=FeaturesFeatures/a + /li + li + a href=/meet/buzz.html title=BuzzBuzz/a + /li + li + a href=/meet/vision.html title=VisionVision/a + /li + li + a href=/meet/blogs.html title=BlogsBlogs/a + /li + /ul + h5 + a name=Navigation-GettingStarted id=Navigation-GettingStarted/aGet Started + /h5 + ul + li + a href=/start/download.html title=Download WicketDownload Wicket/a + /li + li + a href=/start/quickstart.html title=Getting started via a Maven ArchetypeQuickstart/a + /li + li + a href=http://www.jweekend.com/dev/LegUp; rel=nofollowMore archetypes/a + /li + li + a href=/help title=Get helpGet help/a + /li + /ul + h5 + a name=Navigation-Documentation id=Navigation-Documentation/aLearn + /h5 + ul + li + a href=/learn/examples title=ExamplesExamples/a + /li + li + a href=http://wicketstuff.org/wicket14/compref/;Components/a + /li +
svn commit: r1085489 - in /wicket/common/site/trunk: _site/atom.xml _site/learn/books/awc.html learn/books/awc.md
Author: ivaynberg Date: Fri Mar 25 17:49:22 2011 New Revision: 1085489 URL: http://svn.apache.org/viewvc?rev=1085489view=rev Log: corrected a typo Modified: wicket/common/site/trunk/_site/atom.xml wicket/common/site/trunk/_site/learn/books/awc.html wicket/common/site/trunk/learn/books/awc.md Modified: wicket/common/site/trunk/_site/atom.xml URL: http://svn.apache.org/viewvc/wicket/common/site/trunk/_site/atom.xml?rev=1085489r1=1085488r2=1085489view=diff == --- wicket/common/site/trunk/_site/atom.xml (original) +++ wicket/common/site/trunk/_site/atom.xml Fri Mar 25 17:49:22 2011 @@ -4,7 +4,7 @@ titleApache Wicket/title link href=http://wicket.apache.org/atom.xml; rel=self/ link href=http://wicket.apache.org// - updated2011-03-25T10:39:34-07:00/updated + updated2011-03-25T10:48:03-07:00/updated idhttp://wicket.apache.org//id author nameApache Wicket/name Modified: wicket/common/site/trunk/_site/learn/books/awc.html URL: http://svn.apache.org/viewvc/wicket/common/site/trunk/_site/learn/books/awc.html?rev=1085489r1=1085488r2=1085489view=diff == --- wicket/common/site/trunk/_site/learn/books/awc.html (original) +++ wicket/common/site/trunk/_site/learn/books/awc.html Fri Mar 25 17:49:22 2011 @@ -188,7 +188,7 @@ h2 id='about_the_author'About the author/h2 -pIgor Vaynberg is a software architect with more than ten years of experience in the software field. His liking for computers was sparked when his parents got him a Sinclair Z80 when he was but ten years old. Since then he has worked with companies both large and small building modular and scalable web applications. Igor#8217;s main interest is finding ways to simply the development of complex user interfaces required by modern web applications. Igor is a committer for the Apache Wicket framework, the aim of which is to simply the programming model as well as reintroduce OOP to the web UI tier. In his AFK time he enjoys snowboarding with his beautiful wife and playing with his amazing children./p +pIgor Vaynberg is a software architect with more than ten years of experience in the software field. His liking for computers was sparked when his parents got him a Sinclair Z80 when he was but ten years old. Since then he has worked with companies both large and small building modular and scalable web applications. Igor#8217;s main interest is finding ways to simplify the development of complex user interfaces required by modern web applications. Igor is a committer for the Apache Wicket framework, the aim of which is to simplify the programming model as well as reintroduce OOP to the web UI tier. In his AFK time he enjoys snowboarding with his beautiful wife and playing with his amazing children./p h2 id='book_details'Book details/h2 table Modified: wicket/common/site/trunk/learn/books/awc.md URL: http://svn.apache.org/viewvc/wicket/common/site/trunk/learn/books/awc.md?rev=1085489r1=1085488r2=1085489view=diff == --- wicket/common/site/trunk/learn/books/awc.md (original) +++ wicket/common/site/trunk/learn/books/awc.md Fri Mar 25 17:49:22 2011 @@ -36,7 +36,7 @@ This book is for current users of the Ap ## About the author ## -Igor Vaynberg is a software architect with more than ten years of experience in the software field. His liking for computers was sparked when his parents got him a Sinclair Z80 when he was but ten years old. Since then he has worked with companies both large and small building modular and scalable web applications. Igor's main interest is finding ways to simply the development of complex user interfaces required by modern web applications. Igor is a committer for the Apache Wicket framework, the aim of which is to simply the programming model as well as reintroduce OOP to the web UI tier. In his AFK time he enjoys snowboarding with his beautiful wife and playing with his amazing children. +Igor Vaynberg is a software architect with more than ten years of experience in the software field. His liking for computers was sparked when his parents got him a Sinclair Z80 when he was but ten years old. Since then he has worked with companies both large and small building modular and scalable web applications. Igor's main interest is finding ways to simplify the development of complex user interfaces required by modern web applications. Igor is a committer for the Apache Wicket framework, the aim of which is to simplify the programming model as well as reintroduce OOP to the web UI tier. In his AFK time he enjoys snowboarding with his beautiful wife and playing with his amazing children. ## Book details ##
svn commit: r1085497 - in /wicket/common/site/trunk: _posts/2011-03-25-wicket-cookbook-published.md _site/2011/03/25/wicket-cookbook-published.html _site/atom.xml _site/index.html
Author: ivaynberg Date: Fri Mar 25 18:09:10 2011 New Revision: 1085497 URL: http://svn.apache.org/viewvc?rev=1085497view=rev Log: changed book image to one with the shadow Modified: wicket/common/site/trunk/_posts/2011-03-25-wicket-cookbook-published.md wicket/common/site/trunk/_site/2011/03/25/wicket-cookbook-published.html wicket/common/site/trunk/_site/atom.xml wicket/common/site/trunk/_site/index.html Modified: wicket/common/site/trunk/_posts/2011-03-25-wicket-cookbook-published.md URL: http://svn.apache.org/viewvc/wicket/common/site/trunk/_posts/2011-03-25-wicket-cookbook-published.md?rev=1085497r1=1085496r2=1085497view=diff == --- wicket/common/site/trunk/_posts/2011-03-25-wicket-cookbook-published.md (original) +++ wicket/common/site/trunk/_posts/2011-03-25-wicket-cookbook-published.md Fri Mar 25 18:09:10 2011 @@ -3,7 +3,7 @@ layout: post title: Apache Wicket Cookbook Published! --- -img style=float: left; margin-left: 10px; margin-right: 10px; title=Apache Wicket Cookbook src=http://wicket.apache.org/learn/books/awc.jpg; alt= width=180 height=222 / +img style=float: left; margin-left: 10px; margin-right: 10px; title=Apache Wicket Cookbook src=http://wicket.apache.org/learn/books/awc.png; alt= width=180 height=222 / For the past nine months I have been quietly working on a book about Wicket. Unlike other books on the market this one does not attempt to teach you Wicket from the ground up. Instead, it is for developers who already know the basics and want to learn how to implement some of the more advanced use cases. Essentially, it contains recipes that show the reader how to implement solutions to some of, what I think are, the most commonly asked questions and stumbling blocks. This morning I was informed that the book has been published! You can read more about it and pick up a copy on a href=https://www.packtpub.com/apache-wicket-cookbook/book;PACKT's Site/a. Modified: wicket/common/site/trunk/_site/2011/03/25/wicket-cookbook-published.html URL: http://svn.apache.org/viewvc/wicket/common/site/trunk/_site/2011/03/25/wicket-cookbook-published.html?rev=1085497r1=1085496r2=1085497view=diff == --- wicket/common/site/trunk/_site/2011/03/25/wicket-cookbook-published.html (original) +++ wicket/common/site/trunk/_site/2011/03/25/wicket-cookbook-published.html Fri Mar 25 18:09:10 2011 @@ -144,7 +144,7 @@ div id=contentbody h1Apache Wicket Cookbook Published!/h1 - img title='Apache Wicket Cookbook' src='http://wicket.apache.org/learn/books/awc.jpg' height='222' alt='' style='float: left; margin-left: 10px; margin-right: 10px;' width='180' / + img title='Apache Wicket Cookbook' src='http://wicket.apache.org/learn/books/awc.png' height='222' alt='' style='float: left; margin-left: 10px; margin-right: 10px;' width='180' / pFor the past nine months I have been quietly working on a book about Wicket. Unlike other books on the market this one does not attempt to teach you Wicket from the ground up. Instead, it is for developers who already know the basics and want to learn how to implement some of the more advanced use cases. Essentially, it contains recipes that show the reader how to implement solutions to some of, what I think are, the most commonly asked questions and stumbling blocks./p pThis morning I was informed that the book has been published! You can read more about it and pick up a copy on a href='https://www.packtpub.com/apache-wicket-cookbook/book'PACKT's Site/a./p Modified: wicket/common/site/trunk/_site/atom.xml URL: http://svn.apache.org/viewvc/wicket/common/site/trunk/_site/atom.xml?rev=1085497r1=1085496r2=1085497view=diff == --- wicket/common/site/trunk/_site/atom.xml (original) +++ wicket/common/site/trunk/_site/atom.xml Fri Mar 25 18:09:10 2011 @@ -4,7 +4,7 @@ titleApache Wicket/title link href=http://wicket.apache.org/atom.xml; rel=self/ link href=http://wicket.apache.org// - updated2011-03-25T10:48:03-07:00/updated + updated2011-03-25T11:08:16-07:00/updated idhttp://wicket.apache.org//id author nameApache Wicket/name @@ -17,7 +17,7 @@ link href=http://wicket.apache.org/2011/03/25/wicket-cookbook-published.html/ updated2011-03-25T00:00:00-07:00/updated idhttp://wicket.apache.org/2011/03/25/wicket-cookbook-published/id - content type=htmllt;img title='Apache Wicket Cookbook' src='http://wicket.apache.org/learn/books/awc.jpg' height='222' alt='' style='float: left; margin-left: 10px; margin-right: 10px;' width='180' /gt; + content type=htmllt;img title='Apache Wicket Cookbook' src='http://wicket.apache.org/learn/books/awc.png' height='222' alt='' style='float: left; margin-left:
[jira] [Commented] (WICKET-3360) Datepicker formatting
[
https://issues.apache.org/jira/browse/WICKET-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011344#comment-13011344
]
Pedro Santos commented on WICKET-3360:
--
Hi Peter, in your page you have 2 div tags (div class=baseContainer)
marking 2 different containers in the same z-index.
The calendar tag z-index is 9, but IE don't care about it being higher then
the rest of page because the its parent container is not on a higher z-index
than its brother. Change the first base container z-index to 1 and the calendar
will stop to show behind the container 2.
About the sizing, the Yahoo devs already did their work specifying in the css
that the table header cell has 2em of width:
.yui-skin-sam .yui-calendar .calweekdaycell {
color: #000;
font-weight: bold;
text-align: center;
width: 2em;
}
not sure what we can do more.
Datepicker formatting
-
Key: WICKET-3360
URL: https://issues.apache.org/jira/browse/WICKET-3360
Project: Wicket
Issue Type: Bug
Components: wicket-datetime
Affects Versions: 1.4.15
Environment: Windows 7, IE 8, Tomcat 6
Reporter: Peter Diefenthäler
Attachments: QickStartDatePicker.jpg, QuickStartDatePicker.war
The datepicker component often hides behind other html components. Also the
sizing is influenced by surronding html tags like tabel and div's.
I think this issue can be solved by using div tags instead of span tags
inside the datepicker.
I.e. span class=yui-calcontainer single withtitle ... style=... should be
switched to div class=yui-calcontainer ...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3360) Datepicker formatting
[ https://issues.apache.org/jira/browse/WICKET-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011349#comment-13011349 ] Pedro Santos commented on WICKET-3360: -- Change the component to use div tags instead of span don't fix any reported problem in this ticket. Datepicker formatting - Key: WICKET-3360 URL: https://issues.apache.org/jira/browse/WICKET-3360 Project: Wicket Issue Type: Bug Components: wicket-datetime Affects Versions: 1.4.15 Environment: Windows 7, IE 8, Tomcat 6 Reporter: Peter Diefenthäler Attachments: QickStartDatePicker.jpg, QuickStartDatePicker.war The datepicker component often hides behind other html components. Also the sizing is influenced by surronding html tags like tabel and div's. I think this issue can be solved by using div tags instead of span tags inside the datepicker. I.e. span class=yui-calcontainer single withtitle ... style=... should be switched to div class=yui-calcontainer ... -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (WICKET-3519) DefaultJavascriptCompressor broken jquery v1.5.1 minified file
[
https://issues.apache.org/jira/browse/WICKET-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011462#comment-13011462
]
Max Raba edited comment on WICKET-3519 at 3/25/11 10:45 PM:
Could someone please look at this thing here, because i think it's a major
thing which should be fixed soon and easily. Thanks.
was (Author: rabam):
Could someone please look at this thing here, because i think it's a major
thing which should be fixed soon and easily.
DefaultJavascriptCompressor broken jquery v1.5.1 minified file
--
Key: WICKET-3519
URL: https://issues.apache.org/jira/browse/WICKET-3519
Project: Wicket
Issue Type: Bug
Components: wicket-core
Affects Versions: 1.4.16
Environment: windows 7 x64
Reporter: Olivier Dutrieux
Labels: javascript, jquery, wicket
Attachments: JQueryCompressionTest.java, jquery-1.5.1.min.js
Hello,
The DefaultJavascriptCompressor broken jquery v1.5.1 Minified file:
text/javascript,*:*/*},contents:{xml:/xml/,html:/html/,json:/json/},responseFields:{xml:responseXML,text:responseText},converters:{*
text:a.String,text html:!0,text json:d.parseJSON,text
xml:d.parseXML}},ajaxPrefilter:bM(bH),ajaxTransport:bM(bI),ajax:function(a,c){function
v(a,c,l,n){if(r!==2){r=2,pclearTimeout(p),o=b,m=n||,u.readyState=a?4:0;var
q,t,v,w=l?bP(e,u,l):b,x,y;if(a=200a300||a===304){if(e.ifModified){if(x=u.getResponseHeader(Last-Modified))d.lastModified[k]=x;if(y=u.getResponseHeader(Etag))d.etag[k]=y}if(a===304)c=notmodified,q=!0;else
try{t=bQ(e,w),c=success,q=!0}catch(z){c=parsererror,v=z}}else{v=c;if(!c||a)c=error,a0(a=0)}u.status=a,u.statusText=c,q?h.resolveWith(f,[t,c,u]):h.rejectWith(f,[u,c,v]),u.statusCode(j),j=b,sg.trigger(ajax+(q?Success:Error),[u,e,q?t:v]),i.resolveWith(f,[u,c]),s(g.trigger(ajaxComplete,[u,e]),--d.active||d.event.trigger(ajaxStop))}}typeof
a===object(c=a,a=b),c=c||{};var
e=d.ajaxSetup({},c),f=e.context||e,g=f!==e(f.nodeType||f instanceof
d)?d(f):d.event,h=d.Deferred(),i=d._Deferred(),j=e.statusCode||{},k,l={},m,n,o,p,q,r=0,s,t,u={readyState:0,setRequestHeader:function(a,b){r||(l[a.toLowerCase().replace(bD,bE)]=b);return
this},getAllResponseHeaders:function(){return
r===2?m:null},getResponseHeader:function(a){var
c;if(r===2){if(!n){n={};while(c=bt.exec(m))n[c[1].toLowerCase()]=c[2]}c=n[a.toLowerCase()]}return
c===b?null:c},overrideMimeType:function(a){r||(e.mimeType=a);return
this},abort:function(a){a=a||abort,oo.abort(a),v(0,a);return
this}};h.promise(u),u.success=u.done,u.error=u.fail,u.complete=i.done,u.statusCode=function(a){if(a){var
b;if(r2)for(b in a)j[b]=[j[b],a[b]];else b=a[u.status],u.then(b,b)}return
this},e.url=((a||e.url)+).replace(bs,).replace(bx,bK[1]+//),e.dataTypes=d.trim(e.dataType||*).toLowerCase().split(bB),e.crossDomain||(q=bF.exec(e.url.toLowerCase()),e.crossDomain=q(q[1]!=bK[1]||q[2]!=bK[2]||(q[3]||(q[1]===http:?80:443))!=(bK[3]||(bK[1]===http:?80:443,e.datae.processDatatypeof
e.data!==string(e.data=d.param(e.data,e.traditional)),bN(bH,e,c,u);if(r===2)return!1;s=e.global,e.type=e.type.toUpperCase(),e.hasContent=!bw.test(e.type),sd.active++===0d.event.trigger(ajaxStart);if(!e.hasContent){e.data(e.url+=(by.test(e.url)?:?)+e.data),k=e.url;if(e.cache===!1){var
w=d.now(),x=e.url.replace(bC,$1_=+w);e.url=x+(x===e.url?(by.test(e.url)?:?)+_=+w:)}}if(e.datae.hasContente.contentType!==!1||c.contentType)l[Content-Type]=e.contentType;e.ifModified(k=k||e.url,d.lastModified[k](l[If-Modified-Since]=d.lastModified[k]),d.etag[k](l[If-None-Match]=d.etag[k])),l.Accept=e.dataTypes[0]e.accepts[e.dataTypes[0]]?e.accepts[e.dataTypes[0]]+(e.dataTypes[0]!==*?,
*/*; q=0.01:)
become :
text/javascript,*:**; q=0.01:)
I think is due to the /* ... */ on the javascript file and is interpreted by
stripCommentsAndWhitespace as a comment.
Best regards
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3519) DefaultJavascriptCompressor broken jquery v1.5.1 minified file
[
https://issues.apache.org/jira/browse/WICKET-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011462#comment-13011462
]
Max Raba commented on WICKET-3519:
--
Could someone please look at this thing here, because i think it's a major
thing which should be fixed soon and easily.
DefaultJavascriptCompressor broken jquery v1.5.1 minified file
--
Key: WICKET-3519
URL: https://issues.apache.org/jira/browse/WICKET-3519
Project: Wicket
Issue Type: Bug
Components: wicket-core
Affects Versions: 1.4.16
Environment: windows 7 x64
Reporter: Olivier Dutrieux
Labels: javascript, jquery, wicket
Attachments: JQueryCompressionTest.java, jquery-1.5.1.min.js
Hello,
The DefaultJavascriptCompressor broken jquery v1.5.1 Minified file:
text/javascript,*:*/*},contents:{xml:/xml/,html:/html/,json:/json/},responseFields:{xml:responseXML,text:responseText},converters:{*
text:a.String,text html:!0,text json:d.parseJSON,text
xml:d.parseXML}},ajaxPrefilter:bM(bH),ajaxTransport:bM(bI),ajax:function(a,c){function
v(a,c,l,n){if(r!==2){r=2,pclearTimeout(p),o=b,m=n||,u.readyState=a?4:0;var
q,t,v,w=l?bP(e,u,l):b,x,y;if(a=200a300||a===304){if(e.ifModified){if(x=u.getResponseHeader(Last-Modified))d.lastModified[k]=x;if(y=u.getResponseHeader(Etag))d.etag[k]=y}if(a===304)c=notmodified,q=!0;else
try{t=bQ(e,w),c=success,q=!0}catch(z){c=parsererror,v=z}}else{v=c;if(!c||a)c=error,a0(a=0)}u.status=a,u.statusText=c,q?h.resolveWith(f,[t,c,u]):h.rejectWith(f,[u,c,v]),u.statusCode(j),j=b,sg.trigger(ajax+(q?Success:Error),[u,e,q?t:v]),i.resolveWith(f,[u,c]),s(g.trigger(ajaxComplete,[u,e]),--d.active||d.event.trigger(ajaxStop))}}typeof
a===object(c=a,a=b),c=c||{};var
e=d.ajaxSetup({},c),f=e.context||e,g=f!==e(f.nodeType||f instanceof
d)?d(f):d.event,h=d.Deferred(),i=d._Deferred(),j=e.statusCode||{},k,l={},m,n,o,p,q,r=0,s,t,u={readyState:0,setRequestHeader:function(a,b){r||(l[a.toLowerCase().replace(bD,bE)]=b);return
this},getAllResponseHeaders:function(){return
r===2?m:null},getResponseHeader:function(a){var
c;if(r===2){if(!n){n={};while(c=bt.exec(m))n[c[1].toLowerCase()]=c[2]}c=n[a.toLowerCase()]}return
c===b?null:c},overrideMimeType:function(a){r||(e.mimeType=a);return
this},abort:function(a){a=a||abort,oo.abort(a),v(0,a);return
this}};h.promise(u),u.success=u.done,u.error=u.fail,u.complete=i.done,u.statusCode=function(a){if(a){var
b;if(r2)for(b in a)j[b]=[j[b],a[b]];else b=a[u.status],u.then(b,b)}return
this},e.url=((a||e.url)+).replace(bs,).replace(bx,bK[1]+//),e.dataTypes=d.trim(e.dataType||*).toLowerCase().split(bB),e.crossDomain||(q=bF.exec(e.url.toLowerCase()),e.crossDomain=q(q[1]!=bK[1]||q[2]!=bK[2]||(q[3]||(q[1]===http:?80:443))!=(bK[3]||(bK[1]===http:?80:443,e.datae.processDatatypeof
e.data!==string(e.data=d.param(e.data,e.traditional)),bN(bH,e,c,u);if(r===2)return!1;s=e.global,e.type=e.type.toUpperCase(),e.hasContent=!bw.test(e.type),sd.active++===0d.event.trigger(ajaxStart);if(!e.hasContent){e.data(e.url+=(by.test(e.url)?:?)+e.data),k=e.url;if(e.cache===!1){var
w=d.now(),x=e.url.replace(bC,$1_=+w);e.url=x+(x===e.url?(by.test(e.url)?:?)+_=+w:)}}if(e.datae.hasContente.contentType!==!1||c.contentType)l[Content-Type]=e.contentType;e.ifModified(k=k||e.url,d.lastModified[k](l[If-Modified-Since]=d.lastModified[k]),d.etag[k](l[If-None-Match]=d.etag[k])),l.Accept=e.dataTypes[0]e.accepts[e.dataTypes[0]]?e.accepts[e.dataTypes[0]]+(e.dataTypes[0]!==*?,
*/*; q=0.01:)
become :
text/javascript,*:**; q=0.01:)
I think is due to the /* ... */ on the javascript file and is interpreted by
stripCommentsAndWhitespace as a comment.
Best regards
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-3558) Expose active requests via JMX
[ https://issues.apache.org/jira/browse/WICKET-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominik Drzewiecki updated WICKET-3558: --- Attachment: (was: exposeActiveViaJMX-1.4.patch) Expose active requests via JMX -- Key: WICKET-3558 URL: https://issues.apache.org/jira/browse/WICKET-3558 Project: Wicket Issue Type: Improvement Components: wicket-jmx Affects Versions: 1.4.16 Reporter: Dominik Drzewiecki Priority: Minor Attachments: exposeActiveViaJMX-1.4.patch, exposeActiveViaJMX-1.5.patch, exposeActiveViaJMX.patch It'd be nice if RequestLogger.active was exposed via JMX in the same manner the RequestLogger.liveSessions.size() is. Moreover it'd be great to track and expose the peak number of concurrent (active) requests. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-3558) Expose active requests via JMX
[ https://issues.apache.org/jira/browse/WICKET-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominik Drzewiecki updated WICKET-3558: --- Attachment: exposeActiveViaJMX-1.4.patch Expose active requests via JMX -- Key: WICKET-3558 URL: https://issues.apache.org/jira/browse/WICKET-3558 Project: Wicket Issue Type: Improvement Components: wicket-jmx Affects Versions: 1.4.16 Reporter: Dominik Drzewiecki Priority: Minor Attachments: exposeActiveViaJMX-1.4.patch, exposeActiveViaJMX-1.5.patch, exposeActiveViaJMX.patch It'd be nice if RequestLogger.active was exposed via JMX in the same manner the RequestLogger.liveSessions.size() is. Moreover it'd be great to track and expose the peak number of concurrent (active) requests. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-3558) Expose active requests via JMX
[ https://issues.apache.org/jira/browse/WICKET-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominik Drzewiecki updated WICKET-3558: --- Attachment: exposeActiveViaJMX-1.4.patch This one supersedes exposeActiveViaJMX.patch which appears to miss one class modifcations. Expose active requests via JMX -- Key: WICKET-3558 URL: https://issues.apache.org/jira/browse/WICKET-3558 Project: Wicket Issue Type: Improvement Components: wicket-jmx Affects Versions: 1.4.16 Reporter: Dominik Drzewiecki Priority: Minor Attachments: exposeActiveViaJMX-1.4.patch, exposeActiveViaJMX-1.5.patch, exposeActiveViaJMX.patch It'd be nice if RequestLogger.active was exposed via JMX in the same manner the RequestLogger.liveSessions.size() is. Moreover it'd be great to track and expose the peak number of concurrent (active) requests. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-3558) Expose active requests via JMX
[ https://issues.apache.org/jira/browse/WICKET-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominik Drzewiecki updated WICKET-3558: --- Attachment: exposeActiveViaJMX-1.5.patch Expose active requests via JMX -- Key: WICKET-3558 URL: https://issues.apache.org/jira/browse/WICKET-3558 Project: Wicket Issue Type: Improvement Components: wicket-jmx Affects Versions: 1.4.16 Reporter: Dominik Drzewiecki Priority: Minor Attachments: exposeActiveViaJMX-1.4.patch, exposeActiveViaJMX-1.5.patch, exposeActiveViaJMX.patch It'd be nice if RequestLogger.active was exposed via JMX in the same manner the RequestLogger.liveSessions.size() is. Moreover it'd be great to track and expose the peak number of concurrent (active) requests. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-3558) Expose active requests via JMX
[ https://issues.apache.org/jira/browse/WICKET-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominik Drzewiecki updated WICKET-3558: --- Attachment: (was: exposeActiveViaJMX.patch) Expose active requests via JMX -- Key: WICKET-3558 URL: https://issues.apache.org/jira/browse/WICKET-3558 Project: Wicket Issue Type: Improvement Components: wicket-jmx Affects Versions: 1.4.16, 1.5-RC2 Reporter: Dominik Drzewiecki Priority: Minor Attachments: exposeActiveViaJMX-1.4.patch, exposeActiveViaJMX-1.5.patch It'd be nice if RequestLogger.active was exposed via JMX in the same manner the RequestLogger.liveSessions.size() is. Moreover it'd be great to track and expose the peak number of concurrent (active) requests. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-3558) Expose active requests via JMX
[ https://issues.apache.org/jira/browse/WICKET-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominik Drzewiecki updated WICKET-3558: --- Affects Version/s: 1.5-RC2 Expose active requests via JMX -- Key: WICKET-3558 URL: https://issues.apache.org/jira/browse/WICKET-3558 Project: Wicket Issue Type: Improvement Components: wicket-jmx Affects Versions: 1.4.16, 1.5-RC2 Reporter: Dominik Drzewiecki Priority: Minor Attachments: exposeActiveViaJMX-1.4.patch, exposeActiveViaJMX-1.5.patch It'd be nice if RequestLogger.active was exposed via JMX in the same manner the RequestLogger.liveSessions.size() is. Moreover it'd be great to track and expose the peak number of concurrent (active) requests. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-3558) Expose active requests via JMX
[ https://issues.apache.org/jira/browse/WICKET-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominik Drzewiecki updated WICKET-3558: --- Attachment: (was: exposeActiveViaJMX-1.5.patch) Expose active requests via JMX -- Key: WICKET-3558 URL: https://issues.apache.org/jira/browse/WICKET-3558 Project: Wicket Issue Type: Improvement Components: wicket-jmx Affects Versions: 1.4.16, 1.5-RC2 Reporter: Dominik Drzewiecki Priority: Minor Attachments: exposeActiveViaJMX-1.4.patch, exposeActiveViaJMX-1.5.patch It'd be nice if RequestLogger.active was exposed via JMX in the same manner the RequestLogger.liveSessions.size() is. Moreover it'd be great to track and expose the peak number of concurrent (active) requests. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-3558) Expose active requests via JMX
[ https://issues.apache.org/jira/browse/WICKET-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominik Drzewiecki updated WICKET-3558: --- Attachment: exposeActiveViaJMX-1.5.patch Expose active requests via JMX -- Key: WICKET-3558 URL: https://issues.apache.org/jira/browse/WICKET-3558 Project: Wicket Issue Type: Improvement Components: wicket-jmx Affects Versions: 1.4.16, 1.5-RC2 Reporter: Dominik Drzewiecki Priority: Minor Attachments: exposeActiveViaJMX-1.4.patch, exposeActiveViaJMX-1.5.patch It'd be nice if RequestLogger.active was exposed via JMX in the same manner the RequestLogger.liveSessions.size() is. Moreover it'd be great to track and expose the peak number of concurrent (active) requests. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (WICKET-3218) Component#onInitialize is broken for Pages
[ https://issues.apache.org/jira/browse/WICKET-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg reopened WICKET-3218: --- Component#onInitialize is broken for Pages -- Key: WICKET-3218 URL: https://issues.apache.org/jira/browse/WICKET-3218 Project: Wicket Issue Type: Bug Components: wicket-core Affects Versions: 1.4.14 Reporter: Carl-Eric Menzel Assignee: Igor Vaynberg Fix For: 1.5-RC3 Attachments: 0001-delay-oninitialize-until-just-before-onconfigure.patch As first mentioned at http://mail-archives.apache.org/mod_mbox/wicket-dev/201012.mbox/%3c1291238699.1749.1408166...@webmail.messagingengine.com%3E , I think the current (Wicket 1.4.14) implementation of Component#onInitialize is broken for Pages. Pages get initialized as soon as the first component is added, which is correct. But this usually happens within the constructor of the page, which means that the page object isn't fully initialized yet. The entire point of having onInitialize, however, is to be able to do further work once all constructors have run. See https://github.com/duesenklipper/wicket-oninitialize for a quickstart that demonstrates the problem. Pedro Santos suggested in the above thread to just switch the entire object construction to onInitialize. I don't think this is a good idea, because 1) it is completely counter-intuitive 2) it is not always realistic to have an entire class hierarchy not using the constructor just because a subclass somewhere might want to use onInitialize 3) it is inconsistent with onInitialize behavior for all other (non-Page) components. Here I can easily mix work in the constructor with onInitialize. I propose the following patch: - override onInitialize in Page and make it final, so Pages can't use this any more. This should not cause any unnecessary breaking, since currently it's not working for pages anyway. - introduce Page#onPageInitialize to provide a safe alternative to onInitialize - make a special case for Page in Component's beforeRender to fire Page#onPageInitialize if necessary Yes, this is a bit of special casing for Page, but there's quite a lot of that needed for Page anyway. I think the impact of this should be minimal. My page includes documentation and a new testcase that verifies the new behavior. I modified the old ComponentInitializationTest to reflect the fact that Page doesn't get onInitialize any more. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-3218) Component#onInitialize is broken for Pages
[ https://issues.apache.org/jira/browse/WICKET-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-3218. --- Resolution: Fixed Fix Version/s: (was: 1.5-RC1) 1.5-RC3 Component#onInitialize is broken for Pages -- Key: WICKET-3218 URL: https://issues.apache.org/jira/browse/WICKET-3218 Project: Wicket Issue Type: Bug Components: wicket-core Affects Versions: 1.4.14 Reporter: Carl-Eric Menzel Assignee: Igor Vaynberg Fix For: 1.5-RC3 Attachments: 0001-delay-oninitialize-until-just-before-onconfigure.patch As first mentioned at http://mail-archives.apache.org/mod_mbox/wicket-dev/201012.mbox/%3c1291238699.1749.1408166...@webmail.messagingengine.com%3E , I think the current (Wicket 1.4.14) implementation of Component#onInitialize is broken for Pages. Pages get initialized as soon as the first component is added, which is correct. But this usually happens within the constructor of the page, which means that the page object isn't fully initialized yet. The entire point of having onInitialize, however, is to be able to do further work once all constructors have run. See https://github.com/duesenklipper/wicket-oninitialize for a quickstart that demonstrates the problem. Pedro Santos suggested in the above thread to just switch the entire object construction to onInitialize. I don't think this is a good idea, because 1) it is completely counter-intuitive 2) it is not always realistic to have an entire class hierarchy not using the constructor just because a subclass somewhere might want to use onInitialize 3) it is inconsistent with onInitialize behavior for all other (non-Page) components. Here I can easily mix work in the constructor with onInitialize. I propose the following patch: - override onInitialize in Page and make it final, so Pages can't use this any more. This should not cause any unnecessary breaking, since currently it's not working for pages anyway. - introduce Page#onPageInitialize to provide a safe alternative to onInitialize - make a special case for Page in Component's beforeRender to fire Page#onPageInitialize if necessary Yes, this is a bit of special casing for Page, but there's quite a lot of that needed for Page anyway. I think the impact of this should be minimal. My page includes documentation and a new testcase that verifies the new behavior. I modified the old ComponentInitializationTest to reflect the fact that Page doesn't get onInitialize any more. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3218) Component#onInitialize is broken for Pages
[ https://issues.apache.org/jira/browse/WICKET-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011574#comment-13011574 ] Igor Vaynberg commented on WICKET-3218: --- initial cascade is now delayed just prior to first render of the page. however, once the page has been initialized further component initialization will happen on immediate availability of the page just like it does now. Component#onInitialize is broken for Pages -- Key: WICKET-3218 URL: https://issues.apache.org/jira/browse/WICKET-3218 Project: Wicket Issue Type: Bug Components: wicket-core Affects Versions: 1.4.14 Reporter: Carl-Eric Menzel Assignee: Igor Vaynberg Fix For: 1.5-RC3 Attachments: 0001-delay-oninitialize-until-just-before-onconfigure.patch As first mentioned at http://mail-archives.apache.org/mod_mbox/wicket-dev/201012.mbox/%3c1291238699.1749.1408166...@webmail.messagingengine.com%3E , I think the current (Wicket 1.4.14) implementation of Component#onInitialize is broken for Pages. Pages get initialized as soon as the first component is added, which is correct. But this usually happens within the constructor of the page, which means that the page object isn't fully initialized yet. The entire point of having onInitialize, however, is to be able to do further work once all constructors have run. See https://github.com/duesenklipper/wicket-oninitialize for a quickstart that demonstrates the problem. Pedro Santos suggested in the above thread to just switch the entire object construction to onInitialize. I don't think this is a good idea, because 1) it is completely counter-intuitive 2) it is not always realistic to have an entire class hierarchy not using the constructor just because a subclass somewhere might want to use onInitialize 3) it is inconsistent with onInitialize behavior for all other (non-Page) components. Here I can easily mix work in the constructor with onInitialize. I propose the following patch: - override onInitialize in Page and make it final, so Pages can't use this any more. This should not cause any unnecessary breaking, since currently it's not working for pages anyway. - introduce Page#onPageInitialize to provide a safe alternative to onInitialize - make a special case for Page in Component's beforeRender to fire Page#onPageInitialize if necessary Yes, this is a bit of special casing for Page, but there's quite a lot of that needed for Page anyway. I think the impact of this should be minimal. My page includes documentation and a new testcase that verifies the new behavior. I modified the old ComponentInitializationTest to reflect the fact that Page doesn't get onInitialize any more. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
svn commit: r1085649 - in /wicket/trunk/wicket-core/src: main/java/org/apache/wicket/ test/java/org/apache/wicket/
Author: ivaynberg
Date: Sat Mar 26 05:49:20 2011
New Revision: 1085649
URL: http://svn.apache.org/viewvc?rev=1085649view=rev
Log:
delay first onInitialize cascade just before render so pages can use
onInitialize() as well
Issue: WICKET-3218
Added:
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ComponentInitializationIntegrationTest.java
(with props)
Modified:
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/Page.java
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ComponentInitializationTest.java
Modified:
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java?rev=1085649r1=1085648r2=1085649view=diff
==
---
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java
(original)
+++
wicket/trunk/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java
Sat Mar 26 05:49:20 2011
@@ -924,7 +924,10 @@ public abstract class MarkupContainer ex
page.componentAdded(child);
// initialie the component
- child.internalInitialize();
+ if (page.getFlag(FLAG_INITIALIZED))
+ {
+ child.internalInitialize();
+ }
}
// if the PREPARED_FOR_RENDER flag is set, we have already
called
Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/Page.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/Page.java?rev=1085649r1=1085648r2=1085649view=diff
==
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/Page.java
(original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/Page.java Sat Mar
26 05:49:20 2011
@@ -572,17 +572,6 @@ public abstract class Page extends Marku
return stateless;
}
- @Override
- protected final void onInitialize()
- {
- /*
-* final in the page because: *** doesnt make sense for pages
*** can be called from page's
-* constructor - which is bad *** if delayed can lead to page
not being initialized after
-* its constructor call - which is bad
-*/
- super.onInitialize();
- }
-
/**
* Redirect to this page.
*
@@ -1017,12 +1006,6 @@ public abstract class Page extends Marku
*/
final void componentAdded(final Component component)
{
- if (!getFlag(FLAG_INITIALIZED))
- {
- // initialize the page if not yet initialized
- internalInitialize();
- }
-
if (!component.isAuto())
{
dirty();
Added:
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ComponentInitializationIntegrationTest.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ComponentInitializationIntegrationTest.java?rev=1085649view=auto
==
---
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ComponentInitializationIntegrationTest.java
(added)
+++
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/ComponentInitializationIntegrationTest.java
Sat Mar 26 05:49:20 2011
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the License); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.wicket;
+
+import static org.junit.Assert.assertEquals;
+
+import org.apache.wicket.markup.IMarkupResourceStreamProvider;
+import org.apache.wicket.markup.html.WebMarkupContainer;
+import org.apache.wicket.markup.html.WebPage;
+import org.apache.wicket.util.resource.IResourceStream;
+import org.apache.wicket.util.resource.StringResourceStream;
+import
svn commit: r1085651 - in /wicket/trunk/wicket-datetime/src: main/java/org/apache/wicket/extensions/yui/calendar/ test/java/org/apache/wicket/extensions/yui/calendar/
Author: ivaynberg
Date: Sat Mar 26 05:50:56 2011
New Revision: 1085651
URL: http://svn.apache.org/viewvc?rev=1085651view=rev
Log:
3510
Modified:
wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.html
wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.java
wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/TimeField.java
wicket/trunk/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatePickerTest.java
wicket/trunk/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatesPage2.html
wicket/trunk/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatesPage2.java
Modified:
wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.html
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.html?rev=1085651r1=1085650r2=1085651view=diff
==
---
wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.html
(original)
+++
wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.html
Sat Mar 26 05:50:56 2011
@@ -18,7 +18,8 @@
wicket:panel
span style=white-space: nowrap;
input type=text wicket:id=date size=12 /
-input type=text wicket:id=hours size=2 /nbsp;:
+ input type=text wicket:id=hours size=2 /
+ span wicket:id=hoursSeparatornbsp;:/span
input type=text wicket:id=minutes size=2 /
select wicket:id=amOrPmChoice/select
/span
Modified:
wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.java?rev=1085651r1=1085650r2=1085651view=diff
==
---
wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.java
(original)
+++
wicket/trunk/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.java
Sat Mar 26 05:50:56 2011
@@ -26,6 +26,7 @@ import java.util.TimeZone;
import org.apache.wicket.Session;
import org.apache.wicket.datetime.markup.html.form.DateTextField;
import org.apache.wicket.markup.html.IHeaderResponse;
+import org.apache.wicket.markup.html.WebMarkupContainer;
import org.apache.wicket.markup.html.form.DropDownChoice;
import org.apache.wicket.markup.html.form.FormComponentPanel;
import org.apache.wicket.markup.html.form.TextField;
@@ -173,6 +174,16 @@ public class DateTimeField extends FormC
// Create and add the AM/PM Listbox
add(amOrPmChoice = new DropDownChoiceAM_PM(AM_OR_PM_CHOICE,
new PropertyModelAM_PM(
this, AM_OR_PM), Arrays.asList(AM_PM.values(;
+
+ add(new WebMarkupContainer(hoursSeparator){
+ private static final long serialVersionUID = 1L;
+
+ @Override
+ public boolean isVisible()
+ {
+ return minutesField.determineVisibility();
+ }
+ });
}
/**
@@ -402,15 +413,15 @@ public class DateTimeField extends FormC
}
else
{
- MutableDateTime mDate = new
MutableDateTime(modelObject);
-
// convert date to the client's time zone if we have
that info
TimeZone zone = getClientTimeZone();
if (zone != null)
{
- mDate.setZone(DateTimeZone.forTimeZone(zone));
+ modelObject = changeTimeZone(modelObject, zone);
}
+ MutableDateTime mDate = new
MutableDateTime(modelObject);
+
date = mDate.toDate();
if (use12HourFormat)
@@ -431,6 +442,32 @@ public class DateTimeField extends FormC
}
/**
+* Change a date in another timezone
+*
+* @param date
+*The input date.
+* @param zone
+*The target timezone.
+* @return A new converted date.
+*/
+ public static Date changeTimeZone(Date date, TimeZone zone)
+ {
+ Calendar first = Calendar.getInstance(zone);
+ first.setTimeInMillis(date.getTime());
+
+ Calendar output = Calendar.getInstance();
+ output.set(Calendar.YEAR, first.get(Calendar.YEAR));
+
[jira] [Resolved] (WICKET-3510) DateTimeField improperly converts time causing wrong dates when the server's current date is different from the client's date.
[ https://issues.apache.org/jira/browse/WICKET-3510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-3510. --- Resolution: Fixed Assignee: Igor Vaynberg latest patch applied DateTimeField improperly converts time causing wrong dates when the server's current date is different from the client's date. -- Key: WICKET-3510 URL: https://issues.apache.org/jira/browse/WICKET-3510 Project: Wicket Issue Type: Bug Components: wicket-datetime Affects Versions: 1.5-RC2 Reporter: Bertrand Guay-Paquet Assignee: Igor Vaynberg Labels: datepicker, datetime Fix For: 1.5-RC3 Attachments: DateConverterFix.patch, FailingTest.patch, TestDateConverter.java, dateModelConversionFix.patch, dateModelConversionFix_TimeField.patch, dateModelConversionFix_TimeField_NoEnclosure.patch, doubleConversionFix.patch, testsWithDateModels.patch The bug is in DateTimeField#convertInput(). code // Get year, month and day ignoring any timezone of the Date object Calendar cal = Calendar.getInstance(); cal.setTime(dateFieldInput); int year = cal.get(Calendar.YEAR); int month = cal.get(Calendar.MONTH) + 1; int day = cal.get(Calendar.DAY_OF_MONTH); int hours = (hoursInput == null ? 0 : hoursInput % 24); int minutes = (minutesInput == null ? 0 : minutesInput); // Use the input to create a date object with proper timezone MutableDateTime date = new MutableDateTime(year, month, day, hours, minutes, 0, 0, DateTimeZone.forTimeZone(getClientTimeZone())); /code If the server's current date is different from the client's, this produces wrong output. I attached a patch with a test case that simulates this condition. I don't know why this casting of day, month, year is done. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
