[jira] [Created] (WICKET-5128) Allow for Testing Component relative Feedback-Messages in Wicket-Tester
Martin Dilger created WICKET-5128: - Summary: Allow for Testing Component relative Feedback-Messages in Wicket-Tester Key: WICKET-5128 URL: https://issues.apache.org/jira/browse/WICKET-5128 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 6.7.0 Reporter: Martin Dilger Priority: Minor Attachments: WICKET-5128-Allow-for-Component-relative-Feedbackmessages-in-Wicket-Tester.patch If I as a developer want to test for certain Feedback Messages to be rendered, currently I can only test for a complete String. This forces me to duplicate the Feedback-Message String. If the Message changes, the Test will break. This is not desirable. The patch attached extends the Wicket-Tester and allows for Testing against Property-Keys and not only the complete rendered Message. This gives me the possibililty to change the feedback message without changing the corresponding test. Please consider applying the Patch. Thanks. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-5128) Allow for Testing Component relative Feedback-Messages in Wicket-Tester
[ https://issues.apache.org/jira/browse/WICKET-5128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Dilger updated WICKET-5128: -- Attachment: WICKET-5128-Allow-for-Component-relative-Feedbackmessages-in-Wicket-Tester.patch > Allow for Testing Component relative Feedback-Messages in Wicket-Tester > --- > > Key: WICKET-5128 > URL: https://issues.apache.org/jira/browse/WICKET-5128 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 6.7.0 >Reporter: Martin Dilger >Priority: Minor > Attachments: > WICKET-5128-Allow-for-Component-relative-Feedbackmessages-in-Wicket-Tester.patch > > > If I as a developer want to test for certain Feedback Messages to be > rendered, currently I can only test for a complete String. > This forces me to duplicate the Feedback-Message String. > If the Message changes, the Test will break. > This is not desirable. > The patch attached extends the Wicket-Tester and allows for Testing against > Property-Keys and not only the complete rendered Message. > This gives me the possibililty to change the feedback message without > changing the corresponding test. > Please consider applying the Patch. > Thanks. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
buildbot success in ASF Buildbot on wicket-master
The Buildbot has detected a restored build on builder wicket-master while building wicket. Full details are available at: http://ci.apache.org/builders/wicket-master/builds/1142 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: hemera_ubuntu Build Reason: scheduler Build Source Stamp: [branch master] 0aabf6694d113e6645f699f291555d850a1a986e Blamelist: Igor Vaynberg Build succeeded! sincerely, -The Buildbot
git commit: ignore license header in beans.xml
Updated Branches:
refs/heads/master d461b729e -> 0aabf6694
ignore license header in beans.xml
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/0aabf669
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/0aabf669
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/0aabf669
Branch: refs/heads/master
Commit: 0aabf6694d113e6645f699f291555d850a1a986e
Parents: d461b72
Author: Igor Vaynberg
Authored: Mon Apr 1 13:41:57 2013 -0700
Committer: Igor Vaynberg
Committed: Mon Apr 1 13:41:57 2013 -0700
--
.../apache/wicket/cdi/ApacheLicenceHeaderTest.java |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/0aabf669/wicket-cdi/src/test/java/org/apache/wicket/cdi/ApacheLicenceHeaderTest.java
--
diff --git
a/wicket-cdi/src/test/java/org/apache/wicket/cdi/ApacheLicenceHeaderTest.java
b/wicket-cdi/src/test/java/org/apache/wicket/cdi/ApacheLicenceHeaderTest.java
index eeb2c21..92efb73 100644
---
a/wicket-cdi/src/test/java/org/apache/wicket/cdi/ApacheLicenceHeaderTest.java
+++
b/wicket-cdi/src/test/java/org/apache/wicket/cdi/ApacheLicenceHeaderTest.java
@@ -34,7 +34,7 @@ public class ApacheLicenceHeaderTest extends
ApacheLicenseHeaderTestCase
public ApacheLicenceHeaderTest()
{
xmlIgnore.add(".settings");
-
+ xmlIgnore.add("src/main/resources/META-INF/beans.xml");
xmlPrologIgnore = Arrays.asList("src");
}
}
git commit: fix file names
Updated Branches:
refs/heads/master ecb474f65 -> f3d6e19a9
fix file names
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/f3d6e19a
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/f3d6e19a
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/f3d6e19a
Branch: refs/heads/master
Commit: f3d6e19a9469cd07b674988610429e65dbaafd7d
Parents: ecb474f
Author: Igor Vaynberg
Authored: Mon Apr 1 13:01:31 2013 -0700
Committer: Igor Vaynberg
Committed: Mon Apr 1 13:01:31 2013 -0700
--
.../wicket/ajax/json/JSONSequenceStringer.java | 57 ---
.../org/apache/wicket/ajax/json/JSONStringer.java | 79 +++
.../wicket/ajax/json/JsonSequenceStringer.java | 57 +++
.../org/apache/wicket/ajax/json/JsonStringer.java | 79 ---
4 files changed, 136 insertions(+), 136 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/f3d6e19a/wicket-core/src/main/java/org/apache/wicket/ajax/json/JSONSequenceStringer.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/ajax/json/JSONSequenceStringer.java
b/wicket-core/src/main/java/org/apache/wicket/ajax/json/JSONSequenceStringer.java
deleted file mode 100644
index 1e0b8df..000
---
a/wicket-core/src/main/java/org/apache/wicket/ajax/json/JSONSequenceStringer.java
+++ /dev/null
@@ -1,57 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.wicket.ajax.json;
-
-import java.io.IOException;
-
-import org.apache.wicket.util.io.StringBufferWriter;
-
-/**
- * An efficient implementation of a JSON stringer. The efficiency comes from
the fact that istead of
- * a {@link String} this class can return a {@link CharSequence}. This is
better for downstream
- * method that can accept a {@link CharSequence} becuase it requires one less
memory copy of the
- * internal {@link AppendingStringBufferWriter} to a {@link String} to get the
JSON.
- *
- * @author igor
- */
-public class JSONSequenceStringer extends JSONWriter
-{
- public JSONSequenceStringer()
- {
- super(new StringBufferWriter());
- }
-
- /**
-* @return JSON text as a {@link CharSequence}
-*/
- public CharSequence toCharSequence()
- {
-
- if (mode != 'd')
- return null;
-
- try
- {
- writer.flush();
- }
- catch (IOException e)
- {
- throw new RuntimeException(e);
- }
- return ((StringBufferWriter)writer).getStringBuffer();
- }
-}
http://git-wip-us.apache.org/repos/asf/wicket/blob/f3d6e19a/wicket-core/src/main/java/org/apache/wicket/ajax/json/JSONStringer.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/ajax/json/JSONStringer.java
b/wicket-core/src/main/java/org/apache/wicket/ajax/json/JSONStringer.java
new file mode 100755
index 000..76b2b4e
--- /dev/null
+++ b/wicket-core/src/main/java/org/apache/wicket/ajax/json/JSONStringer.java
@@ -0,0 +1,79 @@
+package org.apache.wicket.ajax.json;
+
+/*
+Copyright (c) 2006 JSON.org
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+The Software shall be used for Good, not Evil.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRAN
[jira] [Commented] (WICKET-4795) Wicket unit tests rely on hashmap iteration order
[ https://issues.apache.org/jira/browse/WICKET-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619081#comment-13619081 ] Mikko Tiihonen commented on WICKET-4795: My patch to upstream JSON was rejected. The valid reason being that applications should not be written to rely on specific order of json fields. Maybe we need to figure some other way than exact string comparison of rendered markup to make the unit tests pass on Java 8. > Wicket unit tests rely on hashmap iteration order > - > > Key: WICKET-4795 > URL: https://issues.apache.org/jira/browse/WICKET-4795 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.4.21, 1.5.8, 6.0.0 >Reporter: Mikko Tiihonen >Priority: Minor > Attachments: fix-WICKET-4795.patch > > > Starting from version 7u5 java has supported randomizing the hashmap String > key order (enabling this will fix CVE-2012-2739). It is also a good way to > test the code if it is relying on hashmap order. > More details: > http://docs.oracle.com/javase/7/docs/technotes/guides/collections/changes7.html > In the latest Java 8 (b58) the randomized hashmap is enabled by default > causing some wicket unit tests to fail randomly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-5127) Dont use sun-internal packages to allow easy jdk7 compilation
[ https://issues.apache.org/jira/browse/WICKET-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Vaynberg resolved WICKET-5127. --- Resolution: Fixed Fix Version/s: 6.7.0 Assignee: Igor Vaynberg > Dont use sun-internal packages to allow easy jdk7 compilation > - > > Key: WICKET-5127 > URL: https://issues.apache.org/jira/browse/WICKET-5127 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 6.7.0 >Reporter: Martin Dilger >Assignee: Igor Vaynberg >Priority: Minor > Fix For: 6.7.0 > > Attachments: > 0001-Dont-use-sun-internal-packages-as-this-breaks-compil.patch > > > Hi Devs, > I´m not able to compile the wicket-sources on my notebook, no matter what I > try. > I try to compile with JDK7, that always worked but now some Problems seem to > arise. > In the new JsonSequenceStringer-Class we make use of the sun internal: > com.sun.istack.internal.Nullable; > I dont think its a very good idea to use sun internal classes here, even if > jdk6 is the target of the current source base, we should allow jdk7 to > compile it. Thats not possible at the moment. > The attached patch just removes this usage. We wont lose much here. > Or am I missing something important? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (WICKET-5127) Dont use sun-internal packages to allow easy jdk7 compilation
Martin Dilger created WICKET-5127: - Summary: Dont use sun-internal packages to allow easy jdk7 compilation Key: WICKET-5127 URL: https://issues.apache.org/jira/browse/WICKET-5127 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 6.7.0 Reporter: Martin Dilger Priority: Minor Attachments: 0001-Dont-use-sun-internal-packages-as-this-breaks-compil.patch Hi Devs, I´m not able to compile the wicket-sources on my notebook, no matter what I try. I try to compile with JDK7, that always worked but now some Problems seem to arise. In the new JsonSequenceStringer-Class we make use of the sun internal: com.sun.istack.internal.Nullable; I dont think its a very good idea to use sun internal classes here, even if jdk6 is the target of the current source base, we should allow jdk7 to compile it. Thats not possible at the moment. The attached patch just removes this usage. We wont lose much here. Or am I missing something important? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-5127) Dont use sun-internal packages to allow easy jdk7 compilation
[ https://issues.apache.org/jira/browse/WICKET-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Dilger updated WICKET-5127: -- Attachment: 0001-Dont-use-sun-internal-packages-as-this-breaks-compil.patch > Dont use sun-internal packages to allow easy jdk7 compilation > - > > Key: WICKET-5127 > URL: https://issues.apache.org/jira/browse/WICKET-5127 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 6.7.0 >Reporter: Martin Dilger >Priority: Minor > Attachments: > 0001-Dont-use-sun-internal-packages-as-this-breaks-compil.patch > > > Hi Devs, > I´m not able to compile the wicket-sources on my notebook, no matter what I > try. > I try to compile with JDK7, that always worked but now some Problems seem to > arise. > In the new JsonSequenceStringer-Class we make use of the sun internal: > com.sun.istack.internal.Nullable; > I dont think its a very good idea to use sun internal classes here, even if > jdk6 is the target of the current source base, we should allow jdk7 to > compile it. Thats not possible at the moment. > The attached patch just removes this usage. We wont lose much here. > Or am I missing something important? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
