date:20130408


 [ 
https://issues.apache.org/jira/browse/WICKET-5132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov reassigned WICKET-5132:
---

Assignee: Martin Grigorov

> Evaluation of returned data (which includes alot of javascript) very slow 
> after ajax call in IE10.
> --
>
> Key: WICKET-5132
> URL: https://issues.apache.org/jira/browse/WICKET-5132
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 6.0.0
> Environment: IE10
>Reporter: Bas Veenema
>Assignee: Martin Grigorov
>  Labels: javascript, performance
> Attachments: response_script.txt
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> We're using ajax to update a treetable. In IE10, when the ajax call returns 
> the data, which contains alot of javascript code, processEvaluation in 
> wicket-ajax-jquery.js stalls on var text = jQuery(node).text();
> In jQuery procedure Sizzle.getText is called, which eventually returns 
> property elem.textContent. In IE10 this last statement takes about 26 seconds 
> for our case while the same statement in chrome takes about 6 ms.
> It seems strange that IE10 takes this long to return the textContent of a 
> node, but why is this necessary in the first place?
> The purpose of var text = jQuery(node).text() would be to get the text of the 
> node. I think it would suffice to state var text = 
> node.childNodes[0].nodeValue instead of var text = Query(node).text(), 
> because the text is in the node itself, and it's not necessary to get the 
> text from its descendants, because it has no descendants.
> In our case this modification improves the duration from 25915 ms to 8 ms in 
> IE10.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[CONF] Apache Wicket > Index

2013-04-08 Thread confluence

Index
Page edited by Ralf Eichinger

Comment:
removed orphaned "Output"-widget list and added cool and sexy Wicket-Bootstrap to GUI-Components section

Changes (2)

...
Here is the reference for the standard Wicket GUI components: [Component Reference|http://www.wicket-library.com/wicket-examples-6.0.x/compref/]
h4. Output * [Label|http://wicketstuff.org/wicket13/compref/?wicket:bookmarkablePage=:org.apache.wicket.examples.compref.LabelPage] * [MultiLineLabel|http://wicketstuff.org/wicket13/compref/?wicket:bookmarkablePage=:org.apache.wicket.examples.compref.MultiLineLabelPage]
You are looking for some additional additional cool Widgets, mainly _javascript_/AJAX style? Then have a look here: * [Wicketstuff|http://wicketstuff.org/] - Wicket Stuff provides components that complement the Wicket framework.
* [Wicket-Bootstrap|http://wb.agilecoders.de/] - Simple and flexible Wicket Components, HTML, CSS, and _javascript_ for popular user interface components and interactions.
* [wiQuery|http://www.wiquery.org/] - wiQuery integrates jQuery and jQuery UI into the Apache Wicket framework. * [visural-wicket|http://code.google.com/p/visural-wicket/] - a set of open-source Wicket components, Apache 2.0 licensed.
...

Full Content

Bookmarkable URL
Linking to the wikiTo help with the server loading, please only link to pages under the http://cwiki.apache.org/WICKET/ static root.

This wiki is dedicated to documenting the Wicket Java application framework. Wicket takes simplicity, separation of concerns and ease of development to a whole new level. The wiki is currently open to new users and contributors; see the contribution page for more information. To download Wicket, please visit the Wicket site.
Table of contents

About Wicket

What is Wicket?

Introduction to Java web applications

Why Wicket

Framework Comparisons

Who is using Wicket
Where to (get) help

IRC
Community initiatives
Communities on social networking sites
Contribute to Wicket
Commercial Services

What's next

Wish List for Next Version
Migrations

More about Wicket...

Videos, Talks, Screencasts
Wicket Press & User Stories
Companies Hiring Wicket Developers
External Links

Using Wicket

Development Environment

Java
Build tools
IDE
Application server
Portal server
Database

Development

Framework Documentation
GUI-Components and Widgets
Wicket Component Packaging
Portlet Development
Development Aids

Testing

About Wicket

What is Wicket?

Wicket is one of the most recent in a long line of Java web development frameworks and stands on the shoulders of many that have come before it. Wicket is a component-based framework, which puts it in stark contrast to some of the earlier solutions to the sometimes monotonous task of web programming. Like other frameworks, Wicket builds on top of Sun's servlet API; however, unlike frameworks like Struts or Spring MVC, the developer using Wicket is mostly removed from the request/response nature that is inherent with the web and Servlets. Instead of building controllers that must service many users and threads simultaneously, taking in requests, returning responses, and never storing any state, the Wicket developer thinks in terms of stateful components. Instead of creating a controller or action class, he or she creates a page, places components on it, and defines how each component reacts to user input.

This may all sound familiar to those with desktop GUI experience; Microsoft's Visual Studio line, Sun's Swing API, and Borland's Delphi are all popular desktop GUI development tools that use component models. Using components allows the developer to spend less time on the visual tier of his or her app and more time implementing the core functionality. Even more important is how extensible this makes component-based GUIs. Adding additional functionality is simply a matter of adding one more component, which can act independently or in cooperation with other components in the view. These advantages have not been lost on web developers. In fact, many web framework projects have attempted to leverage the productivity and scalability of desktop applications. Apache Jakarta's Tapestry and Microsoft's own ASP.NET as well as Sun's Java Server Faces specification all present solutions to component-based development over the web and bring new ideas to the table. All of these technologies separate the page layout into a template file. JSF uses Sun's JSPs, ASP.NET uses ASP, and Tapestry use's it's own templating system based on standard HTML markup. These pag

[jira] [Resolved] (WICKET-5110) File upload and Ajax buttons bug


 [ 
https://issues.apache.org/jira/browse/WICKET-5110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov resolved WICKET-5110.
-

Resolution: Cannot Reproduce

I also cannot reproduce the problem.
Just installed Opera 12.15 on Windows 7 and pointed it to 
http://www.wicket-library.com/wicket-examples-6.0.x/ajax/upload.

> File upload and Ajax buttons bug
> 
>
> Key: WICKET-5110
> URL: https://issues.apache.org/jira/browse/WICKET-5110
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 6.6.0
>Reporter: Jakub Rinkes
>Priority: Minor
> Attachments: ajaxupload_6_6_0.rar, today.jpg
>
>
> I found problem with file upload and ajax buttons in Opera 12.14 for wicket 
> 6.6.0. Its same problem like here: 
> https://issues.apache.org/jira/browse/WICKET-4711
> I download quickstart from old issue reworked to my version of form where is 
> fileuploadfield and ajaxbutton. Same error message in wicket debug like in 
> the old issue.
> In quickstart is used Ajax button. I tested AjaxSubmitLink and it has same 
> problem. IE and Firefox working normal.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (WICKET-5113) Set a different TimeZone for the RequestLogger


 [ 
https://issues.apache.org/jira/browse/WICKET-5113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov resolved WICKET-5113.
-

   Resolution: Fixed
Fix Version/s: 6.7.0
 Assignee: Martin Grigorov

The 'final' modifier is removed in Wicket 6.x.
In 1.5.x the signature is: 
  protected static String formatDate(final Date date)
and we cannot remove 'static' because it will be an API break in minor release.

> Set a different TimeZone for the RequestLogger
> --
>
> Key: WICKET-5113
> URL: https://issues.apache.org/jira/browse/WICKET-5113
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.5.10
>Reporter: Teresa Neto
>Assignee: Martin Grigorov
> Fix For: 6.7.0
>
>
> I'm using wicket 1.5.9. In my log4j.xml I have:
> 
> 
> 
> but when I'm testing my log file output is showing the request logger 
> information using GMT timezone and I need to be GMT+1. 
> Following Martin Grigorov is it possible to remove the final from 
> org.apache.wicket.protocol.http.AbstractRequestLogger#formatDate method?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

git commit: WICKET-5113 Set a different TimeZone for the RequestLogger

Updated Branches:
  refs/heads/master ab9cf9445 -> e03d2d88c


WICKET-5113 Set a different TimeZone for the RequestLogger


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/e03d2d88
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/e03d2d88
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/e03d2d88

Branch: refs/heads/master
Commit: e03d2d88c20a69ae532b5bddb38e1c280a3b634d
Parents: ab9cf94
Author: Martin Tzvetanov Grigorov 
Authored: Tue Apr 9 00:50:26 2013 +0300
Committer: Martin Tzvetanov Grigorov 
Committed: Tue Apr 9 00:50:26 2013 +0300

--
 .../protocol/http/AbstractRequestLogger.java   |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/e03d2d88/wicket-core/src/main/java/org/apache/wicket/protocol/http/AbstractRequestLogger.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/protocol/http/AbstractRequestLogger.java
 
b/wicket-core/src/main/java/org/apache/wicket/protocol/http/AbstractRequestLogger.java
index b3b0ffe..add5220 100644
--- 
a/wicket-core/src/main/java/org/apache/wicket/protocol/http/AbstractRequestLogger.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/protocol/http/AbstractRequestLogger.java
@@ -492,7 +492,7 @@ public abstract class AbstractRequestLogger implements 
IRequestLogger
 *the date to format
 * @return the formatted date
 */
-   protected final String formatDate(final Date date)
+   protected String formatDate(final Date date)
{
Args.notNull(date, "date");

[jira] [Commented] (WICKET-5119) PopupSettings IE8 - dosen't work secound time a link is clicked.


[ 
https://issues.apache.org/jira/browse/WICKET-5119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625871#comment-13625871
 ] 

Martin Grigorov commented on WICKET-5119:
-

I cannot reproduce the problem.
I don't have real IE 7/8 around so I use IE9 in IE 7/8 mode.
At http://www.wicket-library.com/wicket-examples-6.0.x/linkomatic/home I click 
on the link with text "Click this link for a popup" and then I click second 
time on the same link without closing the popup.
Are the steps correct ?

Could it be something related to your installation of IE 8 ? Can you try from a 
different machine too ? Also please try with different DOCTYPE, preferably 
HTML5.

> PopupSettings IE8 - dosen't work secound time a link is clicked.
> 
>
> Key: WICKET-5119
> URL: https://issues.apache.org/jira/browse/WICKET-5119
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 6.4.0
>Reporter: Uffe Heerfordt
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> Hi,
> The popup functionality causes a script error in IE8, if the popup window is 
> already open. As a result the link's default behaviour is executed instead - 
> as ' return false; ' never is reached.
> Class: org.apache.wicket.markup.html.link.PopupSettings
> The problem exists in line: 188 //  if(w.blur) w.focus();
> In IE8 blur and focus isen't defined - secound time a popup link is called 
> and therefore the logic breaks.
> //An alternative: (test if w.blur is defined)
> script.append("'); if( jQuery.isFunction( w.blur ) && w.blur ) { w.focus(); } 
> ").append(" return false;");
> Br,
> Uffe.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WICKET-5120) DummyPanelPage sets span element as root


[ 
https://issues.apache.org/jira/browse/WICKET-5120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625853#comment-13625853
 ] 

Martin Grigorov commented on WICKET-5120:
-

I am not sure there is an universal solution here.
You want to assert that a Component (a Panel in your case) has to be used with 
a . Someone else may want to use a ,  or .
The solution is to override 
org.apache.wicket.util.tester.BaseWicketTester#createPageMarkup() method and 
return whatever markup is needed for the specific case.

> DummyPanelPage sets span element as root
> 
>
> Key: WICKET-5120
> URL: https://issues.apache.org/jira/browse/WICKET-5120
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 6.6.0
>Reporter: Arne Baganz
> Attachments: test.tar.gz
>
>
> I have found a problem with WicketTester when I use startComponentInPage with 
> a panel that checks its onComponentTag to be a div.
> Please look at the failing test TestHomePage#renderComponentInPage in the 
> attached quickstart.
> Quoted from DummyPanelPage.html
> {code}
> 
>   ... replace by testing panel...
> 
> {code}
> There is no tag replacement going on, MyPanel starts with:
> {code}
> 
> {code}
> when run in the test and thus fails when its onComponentTag method is 
> executed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (WICKET-5120) DummyPanelPage sets span element as root


 [ 
https://issues.apache.org/jira/browse/WICKET-5120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov resolved WICKET-5120.
-

Resolution: Not A Problem

> DummyPanelPage sets span element as root
> 
>
> Key: WICKET-5120
> URL: https://issues.apache.org/jira/browse/WICKET-5120
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 6.6.0
>Reporter: Arne Baganz
> Attachments: test.tar.gz
>
>
> I have found a problem with WicketTester when I use startComponentInPage with 
> a panel that checks its onComponentTag to be a div.
> Please look at the failing test TestHomePage#renderComponentInPage in the 
> attached quickstart.
> Quoted from DummyPanelPage.html
> {code}
> 
>   ... replace by testing panel...
> 
> {code}
> There is no tag replacement going on, MyPanel starts with:
> {code}
> 
> {code}
> when run in the test and thus fails when its onComponentTag method is 
> executed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (WICKET-5121) Log warning message if a component that is not on the page associated with the AjaxRequestTarget is added


 [ 
https://issues.apache.org/jira/browse/WICKET-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov resolved WICKET-5121.
-

   Resolution: Fixed
Fix Version/s: 6.7.0
 Assignee: Martin Grigorov

There was already a debug log message for this. Now it is a warning.

> Log warning message if a component that is not on the page associated with 
> the AjaxRequestTarget is added
> -
>
> Key: WICKET-5121
> URL: https://issues.apache.org/jira/browse/WICKET-5121
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.5.0
> Environment: NA
>Reporter: Andrew Geery
>Assignee: Martin Grigorov
>Priority: Minor
> Fix For: 6.7.0
>
>
> If a component that is not associated with the page in the AjaxRequestTarget 
> is added (e.g., target.add(component) to the AjaxRequestTarget, it would be 
> nice to log a warning message that the added component will not, in fact, be 
> re-rendered.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

git commit: WICKET-5121 Log warning message if a component that is not on the page associated with the AjaxRequestTarget is added

Updated Branches:
  refs/heads/master 640cd630c -> ab9cf9445


WICKET-5121 Log warning message if a component that is not on the page 
associated with the AjaxRequestTarget is added


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/ab9cf944
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/ab9cf944
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/ab9cf944

Branch: refs/heads/master
Commit: ab9cf94455ef21f3ed1d3580086cca35bfad64bd
Parents: 640cd63
Author: Martin Tzvetanov Grigorov 
Authored: Tue Apr 9 00:22:15 2013 +0300
Committer: Martin Tzvetanov Grigorov 
Committed: Tue Apr 9 00:22:15 2013 +0300

--
 .../apache/wicket/ajax/AbstractAjaxResponse.java   |1 -
 .../org/apache/wicket/ajax/XmlAjaxResponse.java|4 ++--
 2 files changed, 2 insertions(+), 3 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/ab9cf944/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractAjaxResponse.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractAjaxResponse.java 
b/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractAjaxResponse.java
index 1e3cd1a..a183ef4 100644
--- a/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractAjaxResponse.java
+++ b/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractAjaxResponse.java
@@ -206,7 +206,6 @@ public abstract class AbstractAjaxResponse
for (Map.Entry stringComponentEntry : 
markupIdToComponent.entrySet())
{
final Component component = 
stringComponentEntry.getValue();
-   // final String markupId = 
stringComponentEntry.getKey();
 
if (!containsAncestorFor(component))
{

http://git-wip-us.apache.org/repos/asf/wicket/blob/ab9cf944/wicket-core/src/main/java/org/apache/wicket/ajax/XmlAjaxResponse.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/ajax/XmlAjaxResponse.java 
b/wicket-core/src/main/java/org/apache/wicket/ajax/XmlAjaxResponse.java
index 29a008f..9442cb3 100644
--- a/wicket-core/src/main/java/org/apache/wicket/ajax/XmlAjaxResponse.java
+++ b/wicket-core/src/main/java/org/apache/wicket/ajax/XmlAjaxResponse.java
@@ -92,8 +92,8 @@ public abstract class XmlAjaxResponse extends 
AbstractAjaxResponse
{
// dont throw an exception but just ignore this 
component, somehow
// it got removed from the page.
-   LOG.debug("component: " + component + " with markupid: 
" + markupId +
-   " not rendered because it was already 
removed from page");
+   LOG.warn("Component '{}' with markupid: '{}' not 
rendered because it was already removed from page",
+   component, markupId);
return;
}

[jira] [Resolved] (WICKET-5125) IE8 error in wicket-date.js when used in a modalwindow


 [ 
https://issues.apache.org/jira/browse/WICKET-5125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov resolved WICKET-5125.
-

   Resolution: Fixed
Fix Version/s: 6.7.0
 Assignee: Martin Grigorov

> IE8 error in wicket-date.js when used in a modalwindow
> --
>
> Key: WICKET-5125
> URL: https://issues.apache.org/jira/browse/WICKET-5125
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-datetime
>Affects Versions: 6.5.0
> Environment: NA
>Reporter: Andrew Geery
>Assignee: Martin Grigorov
>Priority: Minor
> Fix For: 6.7.0
>
>
> Using the DatePicker in a ModalWindow, I get the error below after using the 
> calendar widget and closing the modal.  The widget works fine for me; it's 
> simply throwing a JS error in IE8 (displayed in the
> lower lefthand corner of the browser).  I don't see the error in other 
> browsers.
> The problematic line in wicket-date.js is this one:
> YAHOO.wicket[cfg.dpJs].hide();
> I can avoid the error simply by adding a condition to the if-statement that 
> is wrapped around the hide method to check that YAHOO.wicket[cfg.dpJs] is not 
> null:
> if (... && YAHOO.wicket[cfg.dpJs]) ...
> I'm guessing that this is related to the bug fix for 
> https://issues.apache.org/jira/browse/WICKET-4975 -- perhaps the widget is 
> getting destroyed in IE before it can be hidden?
> 
> Webpage error details
> User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.2;
> Trident/4.0; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR
> 3.0.4506.2152; .NET CLR 3.5.30729)
> Timestamp: Fri, 29 Mar 2013 17:54:46 UTC
> Message: 'YAHOO.wicket[...]' is null or not an object
> Line: 308
> Char: 6
> Code: 0
> URI: 
> http://127.0.0.1:8080/test/wicket/resource/org.apache.wicket.extensions.yui.calendar.DatePicker/wicket-date-ver-1359131272000.js

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[3/3] git commit: WICKET-5104 AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax Response Error

WICKET-5104 AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow 
causes Ajax Response Error


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/1ccb57d7
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/1ccb57d7
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/1ccb57d7

Branch: refs/heads/master
Commit: 1ccb57d741e1467b2ba296e4c6d135a558c1565b
Parents: e8dab4a
Author: Martin Tzvetanov Grigorov 
Authored: Tue Apr 9 00:07:28 2013 +0300
Committer: Martin Tzvetanov Grigorov 
Committed: Tue Apr 9 00:14:51 2013 +0300

--
 .../wicket/ajax/AbstractAjaxTimerBehavior.java |9 ++---
 1 files changed, 6 insertions(+), 3 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/1ccb57d7/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractAjaxTimerBehavior.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractAjaxTimerBehavior.java
 
b/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractAjaxTimerBehavior.java
index 7b5065e..f4acfc8 100644
--- 
a/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractAjaxTimerBehavior.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/ajax/AbstractAjaxTimerBehavior.java
@@ -190,9 +190,12 @@ public abstract class AbstractAjaxTimerBehavior extends 
AbstractDefaultAjaxBehav
 */
public final void stop(final AjaxRequestTarget target)
{
-   stopped = true;
-   String timeoutHandle = getTimeoutHandle();
-   target.prependJavaScript("clearTimeout("+timeoutHandle+"); 
delete "+timeoutHandle+";");
+   if (headRendered && stopped == false)
+   {
+   stopped = true;
+   String timeoutHandle = getTimeoutHandle();
+   
target.prependJavaScript("clearTimeout("+timeoutHandle+"); delete 
"+timeoutHandle+";");
+   }
}
 
@Override

[1/3] git commit: WICKET-5125 IE8 error in wicket-date.js when used in a modalwindow

Updated Branches:
  refs/heads/master e8dab4a01 -> 640cd630c


WICKET-5125 IE8 error in wicket-date.js when used in a modalwindow

Add a check for existance of YAHOO.wicket[cfg.dpJs]


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/640cd630
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/640cd630
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/640cd630

Branch: refs/heads/master
Commit: 640cd630c52e0d5780518779078ecdf92781ee70
Parents: ac44eba
Author: Martin Tzvetanov Grigorov 
Authored: Tue Apr 9 00:13:56 2013 +0300
Committer: Martin Tzvetanov Grigorov 
Committed: Tue Apr 9 00:14:51 2013 +0300

--
 .../wicket/extensions/yui/calendar/wicket-date.js  |   10 --
 1 files changed, 8 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/640cd630/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/wicket-date.js
--
diff --git 
a/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/wicket-date.js
 
b/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/wicket-date.js
index 4963898..e82c723 100644
--- 
a/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/wicket-date.js
+++ 
b/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/wicket-date.js
@@ -304,7 +304,13 @@
var showBtn = document.getElementById(cfg.icon);
var fieldEl = 
document.getElementById(cfg.componentId);
 
-   if (el !== dialogEl && el !== fieldEl && 
!YAHOO.util.Dom.isAncestor(dialogEl, el) && el !== showBtn && 
!YAHOO.util.Dom.isAncestor(showBtn, el)) {
+   if (YAHOO.wicket[cfg.dpJs] &&
+   el !== dialogEl &&
+   el !== fieldEl &&
+   !YAHOO.util.Dom.isAncestor(dialogEl, 
el) &&
+   el !== showBtn &&
+   !YAHOO.util.Dom.isAncestor(showBtn, el))
+   {
YAHOO.wicket[cfg.dpJs].hide();
}
});
@@ -414,7 +420,7 @@
});
};
 
-   YAHOO.register("wicket-date", Wicket.DateTime, {version: "6.5.0", 
build: "1"});
+   YAHOO.register("wicket-date", Wicket.DateTime, {version: "6.7.0", 
build: "1"});
 
// register a listener to clean up YAHOO.wicket cache.
Wicket.Event.subscribe('/ajax/call/complete', function(jqEvent, 
attributes, jqXHR, errorThrown, textStatus) {

[2/3] git commit: Fix a minor typo in comment

Fix a minor typo in comment


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/ac44eba9
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/ac44eba9
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/ac44eba9

Branch: refs/heads/master
Commit: ac44eba9da094f3455ecf522eb975614b701fa89
Parents: 1ccb57d
Author: Martin Tzvetanov Grigorov 
Authored: Tue Apr 9 00:08:00 2013 +0300
Committer: Martin Tzvetanov Grigorov 
Committed: Tue Apr 9 00:14:51 2013 +0300

--
 .../src/main/java/org/apache/wicket/Component.java |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/ac44eba9/wicket-core/src/main/java/org/apache/wicket/Component.java
--
diff --git a/wicket-core/src/main/java/org/apache/wicket/Component.java 
b/wicket-core/src/main/java/org/apache/wicket/Component.java
index 07cebf8..99b8ff9 100644
--- a/wicket-core/src/main/java/org/apache/wicket/Component.java
+++ b/wicket-core/src/main/java/org/apache/wicket/Component.java
@@ -2695,7 +2695,7 @@ public abstract class Component
response.markRendered(this);
}
 
-   // Than ask all behaviors
+   // Then ask all behaviors
for (Behavior behavior : getBehaviors())
{
if (isBehaviorAccepted(behavior))

[jira] [Commented] (WICKET-5104) AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax Response Error


[ 
https://issues.apache.org/jira/browse/WICKET-5104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625818#comment-13625818
 ] 

Cedric Gatay commented on WICKET-5104:
--

I'm glad it is finally fixed. Looking forward to help fixing more ;-) 

> AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax 
> Response Error
> ---
>
> Key: WICKET-5104
> URL: https://issues.apache.org/jira/browse/WICKET-5104
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 6.3.0, 6.6.0
>Reporter: Marios Skounakis
>Assignee: Martin Grigorov
> Fix For: 6.7.0
>
> Attachments: 5104.zip, fix-WICKET-5104.patch
>
>
> I have a ModalWindow which shows a panel with a hidden label with an 
> AjaxSelfUpdatingTimerBehavior. When the modal window is shown, the following 
> error occurs in the Wicket Ajax Debug console:
> ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating javascript: 
> TypeError: Cannot read property 'label5' of undefined, text: 
> (function(){clearTimeout(Wicket.TimerHandles['label5']); delete 
> Wicket.TimerHandles['label5'];})();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (WICKET-5104) AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax Response Error


 [ 
https://issues.apache.org/jira/browse/WICKET-5104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov resolved WICKET-5104.
-

   Resolution: Fixed
Fix Version/s: 6.7.0

Thanks, Cedric!

> AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax 
> Response Error
> ---
>
> Key: WICKET-5104
> URL: https://issues.apache.org/jira/browse/WICKET-5104
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 6.3.0, 6.6.0
>Reporter: Marios Skounakis
>Assignee: Martin Grigorov
> Fix For: 6.7.0
>
> Attachments: 5104.zip, fix-WICKET-5104.patch
>
>
> I have a ModalWindow which shows a panel with a hidden label with an 
> AjaxSelfUpdatingTimerBehavior. When the modal window is shown, the following 
> error occurs in the Wicket Ajax Debug console:
> ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating javascript: 
> TypeError: Cannot read property 'label5' of undefined, text: 
> (function(){clearTimeout(Wicket.TimerHandles['label5']); delete 
> Wicket.TimerHandles['label5'];})();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WICKET-5104) AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax Response Error


[ 
https://issues.apache.org/jira/browse/WICKET-5104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625805#comment-13625805
 ] 

Martin Grigorov commented on WICKET-5104:
-

Thanks!

> AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax 
> Response Error
> ---
>
> Key: WICKET-5104
> URL: https://issues.apache.org/jira/browse/WICKET-5104
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 6.3.0, 6.6.0
>Reporter: Marios Skounakis
>Assignee: Martin Grigorov
> Attachments: 5104.zip, fix-WICKET-5104.patch
>
>
> I have a ModalWindow which shows a panel with a hidden label with an 
> AjaxSelfUpdatingTimerBehavior. When the modal window is shown, the following 
> error occurs in the Wicket Ajax Debug console:
> ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating javascript: 
> TypeError: Cannot read property 'label5' of undefined, text: 
> (function(){clearTimeout(Wicket.TimerHandles['label5']); delete 
> Wicket.TimerHandles['label5'];})();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WICKET-5104) AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax Response Error

2013-04-08 Thread Sven Meier (JIRA)


[ 
https://issues.apache.org/jira/browse/WICKET-5104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625799#comment-13625799
 ] 

Sven Meier commented on WICKET-5104:


Martin: The issue can easily be reproduced with Cedric instructions:

Thread [qtp1028384965-18] (Suspended (breakpoint at line 201 in 
AbstractAjaxTimerBehavior)) 

AjaxSelfUpdatingTimerBehavior(AbstractAjaxTimerBehavior).onRemove(Component) 
line: 201  
Behaviors.onRemove(Component) line: 235 
MessageBoxPanel$1(Component).internalOnRemove() line: 1110  
MessageBoxPanel(MarkupContainer).removeChildren() line: 1590
MessageBoxPanel(Component).internalOnRemove() line: 
ModalWindow(MarkupContainer).removedComponent(Component) line: 1343 
ModalWindow(MarkupContainer).replace(Component) line: 740   
ModalWindow.setContent(Component) line: 944 
HomePage$1.onClick(AjaxRequestTarget) line: 26  
...

As you can see this has nothing to do with #renderHead().

> AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax 
> Response Error
> ---
>
> Key: WICKET-5104
> URL: https://issues.apache.org/jira/browse/WICKET-5104
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 6.3.0, 6.6.0
>Reporter: Marios Skounakis
>Assignee: Martin Grigorov
> Attachments: 5104.zip, fix-WICKET-5104.patch
>
>
> I have a ModalWindow which shows a panel with a hidden label with an 
> AjaxSelfUpdatingTimerBehavior. When the modal window is shown, the following 
> error occurs in the Wicket Ajax Debug console:
> ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating javascript: 
> TypeError: Cannot read property 'label5' of undefined, text: 
> (function(){clearTimeout(Wicket.TimerHandles['label5']); delete 
> Wicket.TimerHandles['label5'];})();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WICKET-5104) AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax Response Error


[ 
https://issues.apache.org/jira/browse/WICKET-5104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625780#comment-13625780
 ] 

Martin Grigorov commented on WICKET-5104:
-

Sven: can you reproduce the issue ?
org.apache.wicket.Component#renderHead(HtmlHeaderContainer) checks whether the 
component is visible(InHierarchy) and only then calls behavior#renderHead().
As I said earlier neither 
org.apache.wicket.ajax.AbstractAjaxTimerBehavior#renderHead() nor 
org.apache.wicket.ajax.AbstractAjaxTimerBehavior#stop() is called here.
Please put breakpoints in these methods and attach/paste the stacktraces.

> AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax 
> Response Error
> ---
>
> Key: WICKET-5104
> URL: https://issues.apache.org/jira/browse/WICKET-5104
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 6.3.0, 6.6.0
>Reporter: Marios Skounakis
>Assignee: Martin Grigorov
> Attachments: 5104.zip, fix-WICKET-5104.patch
>
>
> I have a ModalWindow which shows a panel with a hidden label with an 
> AjaxSelfUpdatingTimerBehavior. When the modal window is shown, the following 
> error occurs in the Wicket Ajax Debug console:
> ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating javascript: 
> TypeError: Cannot read property 'label5' of undefined, text: 
> (function(){clearTimeout(Wicket.TimerHandles['label5']); delete 
> Wicket.TimerHandles['label5'];})();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WICKET-5104) AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax Response Error

2013-04-08 Thread Sven Meier (JIRA)


[ 
https://issues.apache.org/jira/browse/WICKET-5104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625766#comment-13625766
 ] 

Sven Meier commented on WICKET-5104:


I would think a test on isVisibleInHierarchy() should suffice.

> AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax 
> Response Error
> ---
>
> Key: WICKET-5104
> URL: https://issues.apache.org/jira/browse/WICKET-5104
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 6.3.0, 6.6.0
>Reporter: Marios Skounakis
>Assignee: Martin Grigorov
> Attachments: 5104.zip, fix-WICKET-5104.patch
>
>
> I have a ModalWindow which shows a panel with a hidden label with an 
> AjaxSelfUpdatingTimerBehavior. When the modal window is shown, the following 
> error occurs in the Wicket Ajax Debug console:
> ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating javascript: 
> TypeError: Cannot read property 'label5' of undefined, text: 
> (function(){clearTimeout(Wicket.TimerHandles['label5']); delete 
> Wicket.TimerHandles['label5'];})();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WICKET-5104) AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax Response Error


[ 
https://issues.apache.org/jira/browse/WICKET-5104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625585#comment-13625585
 ] 

Cedric Gatay commented on WICKET-5104:
--

The attached patch fixes this issue, as far as I can tell, a review could be 
necessary to do it the right way though.

> AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax 
> Response Error
> ---
>
> Key: WICKET-5104
> URL: https://issues.apache.org/jira/browse/WICKET-5104
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 6.3.0, 6.6.0
>Reporter: Marios Skounakis
>Assignee: Martin Grigorov
> Attachments: 5104.zip, fix-WICKET-5104.patch
>
>
> I have a ModalWindow which shows a panel with a hidden label with an 
> AjaxSelfUpdatingTimerBehavior. When the modal window is shown, the following 
> error occurs in the Wicket Ajax Debug console:
> ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating javascript: 
> TypeError: Cannot read property 'label5' of undefined, text: 
> (function(){clearTimeout(Wicket.TimerHandles['label5']); delete 
> Wicket.TimerHandles['label5'];})();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (WICKET-5138) Wicket does not correctly handle http OPTIONS requests

2013-04-08 Thread Igor Vaynberg (JIRA)


 [ 
https://issues.apache.org/jira/browse/WICKET-5138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg resolved WICKET-5138.
---

Resolution: Fixed

> Wicket does not correctly handle http OPTIONS requests
> --
>
> Key: WICKET-5138
> URL: https://issues.apache.org/jira/browse/WICKET-5138
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 6.6.0
>Reporter: Igor Vaynberg
>Assignee: Igor Vaynberg
> Fix For: 6.7.0
>
>
> currently these requests cause regular processing (page rendering), when in 
> fact they should have a special response.
> rendering the page in OPTIONS causes renderCount to be incremented and this 
> messes with the subsequent request to the same url via a GET or POST

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

git commit: WICKET-5138

2013-04-08 Thread ivaynberg

Updated Branches:
  refs/heads/master f98cc63e1 -> e8dab4a01


WICKET-5138


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/e8dab4a0
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/e8dab4a0
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/e8dab4a0

Branch: refs/heads/master
Commit: e8dab4a0112d2cf84b381fe37cbb48b6c0bcf310
Parents: f98cc63
Author: Igor Vaynberg 
Authored: Mon Apr 8 10:35:07 2013 -0700
Committer: Igor Vaynberg 
Committed: Mon Apr 8 10:35:07 2013 -0700

--
 .../apache/wicket/protocol/http/WicketFilter.java  |   28 +++--
 .../wicket/protocol/http/WicketFilterTest.java |   82 ++-
 2 files changed, 94 insertions(+), 16 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/e8dab4a0/wicket-core/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java 
b/wicket-core/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java
index eb73ee7..be577f3 100644
--- 
a/wicket-core/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java
@@ -96,8 +96,8 @@ public class WicketFilter implements Filter
private boolean isServlet = false;
 
/**
-* default constructor, usually invoked through the servlet 
-* container by the web.xml configuration
+* default constructor, usually invoked through the servlet container 
by the web.xml
+* configuration
 */
public WicketFilter()
{
@@ -106,11 +106,11 @@ public class WicketFilter implements Filter
/**
 * constructor supporting programmatic setup of the filter
 * 
-*  this can be useful for programmatically creating and appending the 
-*  wicket filter to the servlet context using servlet 3 features.
+* this can be useful for programmatically creating and appending the 
wicket filter to the
+* servlet context using servlet 3 features.
 * 
 * @param application
-*   web application
+*web application
 */
public WicketFilter(WebApplication application)
{
@@ -174,7 +174,7 @@ public class WicketFilter implements Filter
return false;
}
 
-   if ("OPTIONS".equals(httpServletRequest.getMethod()))
+   if 
("OPTIONS".equalsIgnoreCase(httpServletRequest.getMethod()))
{
// handle the OPTIONS request outside of normal 
request processing.
// wicket pages normally only support GET and 
POST methods, but resources and
@@ -198,7 +198,8 @@ public class WicketFilter implements Filter
httpServletResponse);
 
RequestCycle requestCycle = 
application.createRequestCycle(webRequest, webResponse);
-   res = processRequestCycle(requestCycle, 
webResponse, httpServletRequest, httpServletResponse, chain);
+   res = processRequestCycle(requestCycle, 
webResponse, httpServletRequest,
+   httpServletResponse, chain);
}
else
{
@@ -238,7 +239,7 @@ public class WicketFilter implements Filter
 
/**
 * Process the request cycle
-*
+* 
 * @param requestCycle
 * @param webResponse
 * @param httpServletRequest
@@ -249,8 +250,9 @@ public class WicketFilter implements Filter
 * @throws ServletException
 */
protected boolean processRequestCycle(RequestCycle requestCycle, 
WebResponse webResponse,
-   HttpServletRequest httpServletRequest, HttpServletResponse 
httpServletResponse,
-   final FilterChain chain) throws IOException, ServletException {
+   HttpServletRequest httpServletRequest, HttpServletResponse 
httpServletResponse,
+   final FilterChain chain) throws IOException, ServletException
+   {
// Assume we are able to handle the request
boolean res = true;
 
@@ -518,6 +520,7 @@ public class WicketFilter implements Filter
 
/**
 * Provide a standard getter for filterPath.
+* 
 * @return The configured filterPath.
 */
protected String getFilterPath()
@@ -651,7 +654,8 @@ public class WicketFilter implements Filter
if (this.filterPath != null)
{

git commit: WICKET-5138

2013-04-08 Thread ivaynberg

Updated Branches:
  refs/heads/master 4b7367ef2 -> f98cc63e1


WICKET-5138


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/f98cc63e
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/f98cc63e
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/f98cc63e

Branch: refs/heads/master
Commit: f98cc63e108e23bf281e1350846b0f8da7d7f8bb
Parents: 4b7367e
Author: Igor Vaynberg 
Authored: Mon Apr 8 10:23:16 2013 -0700
Committer: Igor Vaynberg 
Committed: Mon Apr 8 10:23:23 2013 -0700

--
 .../apache/wicket/protocol/http/WicketFilter.java  |   13 +
 1 files changed, 13 insertions(+), 0 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/f98cc63e/wicket-core/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java 
b/wicket-core/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java
index 291bb30..eb73ee7 100644
--- 
a/wicket-core/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java
@@ -174,6 +174,19 @@ public class WicketFilter implements Filter
return false;
}
 
+   if ("OPTIONS".equals(httpServletRequest.getMethod()))
+   {
+   // handle the OPTIONS request outside of normal 
request processing.
+   // wicket pages normally only support GET and 
POST methods, but resources and
+   // special pages acting like REST clients can 
also support other methods, so
+   // we include them all.
+   
httpServletResponse.setStatus(HttpServletResponse.SC_OK);
+   httpServletResponse.setHeader("Allow",
+   
"GET,POST,OPTIONS,PUT,HEAD,PATCH,DELETE,TRACE");
+   httpServletResponse.setHeader("Content-Length", 
"0");
+   return true;
+   }
+
String redirectURL = 
checkIfRedirectRequired(httpServletRequest);
if (redirectURL == null)
{

[jira] [Updated] (WICKET-5138) Wicket does not correctly handle http OPTIONS requests

2013-04-08 Thread Igor Vaynberg (JIRA)


 [ 
https://issues.apache.org/jira/browse/WICKET-5138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Vaynberg updated WICKET-5138:
--

Description: 
currently these requests cause regular processing (page rendering), when in 
fact they should have a special response.

rendering the page in OPTIONS causes renderCount to be incremented and this 
messes with the subsequent request to the same url via a GET or POST

  was:currently these requests cause regular processing (page rendering), when 
in fact they should have a special response.


> Wicket does not correctly handle http OPTIONS requests
> --
>
> Key: WICKET-5138
> URL: https://issues.apache.org/jira/browse/WICKET-5138
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 6.6.0
>Reporter: Igor Vaynberg
>Assignee: Igor Vaynberg
> Fix For: 6.7.0
>
>
> currently these requests cause regular processing (page rendering), when in 
> fact they should have a special response.
> rendering the page in OPTIONS causes renderCount to be incremented and this 
> messes with the subsequent request to the same url via a GET or POST

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (WICKET-5138) Wicket does not correctly handle http OPTIONS requests

2013-04-08 Thread Igor Vaynberg (JIRA)

Igor Vaynberg created WICKET-5138:
-

 Summary: Wicket does not correctly handle http OPTIONS requests
 Key: WICKET-5138
 URL: https://issues.apache.org/jira/browse/WICKET-5138
 Project: Wicket
  Issue Type: Bug
Affects Versions: 6.6.0
Reporter: Igor Vaynberg
Assignee: Igor Vaynberg
 Fix For: 6.7.0


currently these requests cause regular processing (page rendering), when in 
fact they should have a special response.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WICKET-5132) Evaluation of returned data (which includes alot of javascript) very slow after ajax call in IE10.

2013-04-08 Thread Andrea Del Bene (JIRA)


[ 
https://issues.apache.org/jira/browse/WICKET-5132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625484#comment-13625484
 ] 

Andrea Del Bene commented on WICKET-5132:
-

Unfortunately it is not possible running Bas's test with  IE 7/8 because they 
don't define method  createDocument (see http://help.dottoro.com/ljqlhagh.php). 
However, node.firstChild.nodeValue works fine with both 7 and 8.

> Evaluation of returned data (which includes alot of javascript) very slow 
> after ajax call in IE10.
> --
>
> Key: WICKET-5132
> URL: https://issues.apache.org/jira/browse/WICKET-5132
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 6.0.0
> Environment: IE10
>Reporter: Bas Veenema
>  Labels: javascript, performance
> Attachments: response_script.txt
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> We're using ajax to update a treetable. In IE10, when the ajax call returns 
> the data, which contains alot of javascript code, processEvaluation in 
> wicket-ajax-jquery.js stalls on var text = jQuery(node).text();
> In jQuery procedure Sizzle.getText is called, which eventually returns 
> property elem.textContent. In IE10 this last statement takes about 26 seconds 
> for our case while the same statement in chrome takes about 6 ms.
> It seems strange that IE10 takes this long to return the textContent of a 
> node, but why is this necessary in the first place?
> The purpose of var text = jQuery(node).text() would be to get the text of the 
> node. I think it would suffice to state var text = 
> node.childNodes[0].nodeValue instead of var text = Query(node).text(), 
> because the text is in the node itself, and it's not necessary to get the 
> text from its descendants, because it has no descendants.
> In our case this modification improves the duration from 25915 ms to 8 ms in 
> IE10.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WICKET-5018) redirectToInterceptPage results in 404 when url-rewriting is active


[ 
https://issues.apache.org/jira/browse/WICKET-5018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625471#comment-13625471
 ] 

Martin Grigorov commented on WICKET-5018:
-

I can reproduce it now.
The problem is in 
org.apache.wicket.protocol.http.servlet.ServletWebResponse#encodeRedirectURL() 
- it cannot properly relativize the produced encodedFullUrl because of the 
context path in the full url, the context path is missing in the base url. As a 
result the context path is considered a segment and it participates in the 
calculations with the segments.

I'll try to find a solution.

> redirectToInterceptPage results in 404 when url-rewriting is active 
> 
>
> Key: WICKET-5018
> URL: https://issues.apache.org/jira/browse/WICKET-5018
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 6.5.0
> Environment: tomcat 7, wicket 6.5, Firefox/Internetexplorer
>Reporter: Jürgen Brardt
> Attachments: QuickStart.20130228.zip, QuickStart.zip
>
>
> I have the following setup:
> Tomcat 7 with urlrewriting activated for sessionhandling
> Page a is the homepage of my WicketApplication and requires the User to be 
> Authenticated.
> If the caller is not Authorized, page b redirects to LoginPage l, which 
> contains an ajax-based loginform. After successfull login, the form calls 
> continueToOriginalDestination() which leads to an HTTP 404 error.
> The URL-Causing the 404 result is sth. like:
> /context//context/;jsessionId=./?...
> it should be sth. like:
> /context/;jsessionId=.../?
> the coding is:
> class A extends WebPage{
>   public A(){
>  ..
>  if(Session.isLoggedIn() == false){
> redirectToInterceptPage(new L());
>  }
> }
> class L extends WebPage{
>public L(){
>  addForm(){ onSubmit(){ continueToOriginalDestination();
>   } }
>   }
> }
> I tracked it Down to the ServletWebResponse.encodeUrl Method which does the 
> following:
> fullUrl = http://localhost:8080/nubodent
> encodedFullUrl = 
> http://localhost:8080/context;jsessionid=9C3C51AA3D018E44EA85044012CA504D
> _encodedUrl= /contextt;jsessionid=9C3C51AA3D018E44EA85044012CA504D
> after renderRelativeUrl
> endcodeRelativeUrl = ..//context;jsessionid=9C3C51AA3D018E44EA85044012CA504D
> and then back in the "browser" it is
> /context//context;jsessionid=...
> as stated above.
> I wonder if there really is something wrong, or if Iam the Error, programming 
> it like this.
> Thanks for any helpful hints.
> Jürgen

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (WICKET-4967) Title (caption) not correctly displayed when using a css framework which change the default style of h3.


 [ 
https://issues.apache.org/jira/browse/WICKET-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov resolved WICKET-4967.
-

Resolution: Won't Fix

> Title (caption) not correctly displayed when using a css framework which 
> change the default style of h3.
> 
>
> Key: WICKET-4967
> URL: https://issues.apache.org/jira/browse/WICKET-4967
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.4.0
>Reporter: pascal jacob
>Priority: Trivial
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> Because the title (a.k.a. the caption) of ModalWindow is displayed within a 
>  tag it can miss behave when the application is using a css framework 
> which change the default style of h3. 
> In fact, bootstrap redefine h3 to have a line-height: 40px; and a font-size: 
> 24.5px;  in this case, the ModalWindow caption is a lot bigger than usual and 
> is not correctly displayed. 
> The bug is trivial to fix: have the ModalWindow caption rendered in a span or 
> a div tag instead of a h3 tag.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WICKET-5104) AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax Response Error


[ 
https://issues.apache.org/jira/browse/WICKET-5104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625363#comment-13625363
 ] 

Cedric Gatay commented on WICKET-5104:
--

Hum, I just built the master branch (mvn clean install -Dmaven.test.skip=true) 
locally, then ran mvn clean jetty:run and could reproduce it. I am using Chrome 
28.0.1464.0 dev (the built war is available at the following URL 
http://cl.ly/1c0C30212e3j). The steps to reproduce are the one I detailed 
previously.

> AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax 
> Response Error
> ---
>
> Key: WICKET-5104
> URL: https://issues.apache.org/jira/browse/WICKET-5104
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 6.3.0, 6.6.0
>Reporter: Marios Skounakis
>Assignee: Martin Grigorov
> Attachments: 5104.zip, fix-WICKET-5104.patch
>
>
> I have a ModalWindow which shows a panel with a hidden label with an 
> AjaxSelfUpdatingTimerBehavior. When the modal window is shown, the following 
> error occurs in the Wicket Ajax Debug console:
> ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating javascript: 
> TypeError: Cannot read property 'label5' of undefined, text: 
> (function(){clearTimeout(Wicket.TimerHandles['label5']); delete 
> Wicket.TimerHandles['label5'];})();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WICKET-5122) Add the free Wicket guide in the books page on the official site.

2013-04-08 Thread Andrea Del Bene (JIRA)


[ 
https://issues.apache.org/jira/browse/WICKET-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625358#comment-13625358
 ] 

Andrea Del Bene commented on WICKET-5122:
-

Thank you VERY much!

> Add the free Wicket guide in the books page on the official site.
> -
>
> Key: WICKET-5122
> URL: https://issues.apache.org/jira/browse/WICKET-5122
> Project: Wicket
>  Issue Type: Improvement
>Reporter: Andrea Del Bene
>Assignee: Martin Grigorov
> Fix For: 6.7.0
>
> Attachments: freeguide.diff, freeguide.png
>
>
> This issue contains the picture file and the markdown file to add the free 
> Wicket guide to the list of books available at 
> http://wicket.apache.org/learn/books/.
> Unfortunately my drawing skills are very limited, so any suggestion to 
> improve the book cover is welcome :).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WICKET-5104) AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax Response Error


[ 
https://issues.apache.org/jira/browse/WICKET-5104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625355#comment-13625355
 ] 

Martin Grigorov commented on WICKET-5104:
-

No error here :-/
I've put breakpoints both at 
org.apache.wicket.ajax.AbstractAjaxTimerBehavior#stop() and 
org.apache.wicket.ajax.AbstractAjaxTimerBehavior#renderHead() and they are 
never called no matter how many times I open and the close the modal.

> AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax 
> Response Error
> ---
>
> Key: WICKET-5104
> URL: https://issues.apache.org/jira/browse/WICKET-5104
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 6.3.0, 6.6.0
>Reporter: Marios Skounakis
>Assignee: Martin Grigorov
> Attachments: 5104.zip, fix-WICKET-5104.patch
>
>
> I have a ModalWindow which shows a panel with a hidden label with an 
> AjaxSelfUpdatingTimerBehavior. When the modal window is shown, the following 
> error occurs in the Wicket Ajax Debug console:
> ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating javascript: 
> TypeError: Cannot read property 'label5' of undefined, text: 
> (function(){clearTimeout(Wicket.TimerHandles['label5']); delete 
> Wicket.TimerHandles['label5'];})();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WICKET-5104) AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax Response Error


[ 
https://issues.apache.org/jira/browse/WICKET-5104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625356#comment-13625356
 ] 

Martin Grigorov commented on WICKET-5104:
-

And yes, I also use master branch.

> AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax 
> Response Error
> ---
>
> Key: WICKET-5104
> URL: https://issues.apache.org/jira/browse/WICKET-5104
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 6.3.0, 6.6.0
>Reporter: Marios Skounakis
>Assignee: Martin Grigorov
> Attachments: 5104.zip, fix-WICKET-5104.patch
>
>
> I have a ModalWindow which shows a panel with a hidden label with an 
> AjaxSelfUpdatingTimerBehavior. When the modal window is shown, the following 
> error occurs in the Wicket Ajax Debug console:
> ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating javascript: 
> TypeError: Cannot read property 'label5' of undefined, text: 
> (function(){clearTimeout(Wicket.TimerHandles['label5']); delete 
> Wicket.TimerHandles['label5'];})();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WICKET-5104) AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax Response Error


[ 
https://issues.apache.org/jira/browse/WICKET-5104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625354#comment-13625354
 ] 

Cedric Gatay commented on WICKET-5104:
--

My brain hurts me this monday ;) It is not the second page load but the second 
click on the link to open the modal. I just checked it with the latest 
6.7.0-SNAPSHOT.

Launched quickstart, clicked open, closed the modal, clicked open another time 
> bam Wicket Ajax Debug fever is on.

> AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax 
> Response Error
> ---
>
> Key: WICKET-5104
> URL: https://issues.apache.org/jira/browse/WICKET-5104
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 6.3.0, 6.6.0
>Reporter: Marios Skounakis
>Assignee: Martin Grigorov
> Attachments: 5104.zip, fix-WICKET-5104.patch
>
>
> I have a ModalWindow which shows a panel with a hidden label with an 
> AjaxSelfUpdatingTimerBehavior. When the modal window is shown, the following 
> error occurs in the Wicket Ajax Debug console:
> ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating javascript: 
> TypeError: Cannot read property 'label5' of undefined, text: 
> (function(){clearTimeout(Wicket.TimerHandles['label5']); delete 
> Wicket.TimerHandles['label5'];})();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WICKET-5104) AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax Response Error


[ 
https://issues.apache.org/jira/browse/WICKET-5104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625348#comment-13625348
 ] 

Martin Grigorov commented on WICKET-5104:
-

I just tried again.
I've opened the modal several times without problem.
I removed ?pageId from the url to create a new page instance and tried again 
and there is no error.

> AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax 
> Response Error
> ---
>
> Key: WICKET-5104
> URL: https://issues.apache.org/jira/browse/WICKET-5104
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 6.3.0, 6.6.0
>Reporter: Marios Skounakis
>Assignee: Martin Grigorov
> Attachments: 5104.zip, fix-WICKET-5104.patch
>
>
> I have a ModalWindow which shows a panel with a hidden label with an 
> AjaxSelfUpdatingTimerBehavior. When the modal window is shown, the following 
> error occurs in the Wicket Ajax Debug console:
> ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating javascript: 
> TypeError: Cannot read property 'label5' of undefined, text: 
> (function(){clearTimeout(Wicket.TimerHandles['label5']); delete 
> Wicket.TimerHandles['label5'];})();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WICKET-5104) AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax Response Error


[ 
https://issues.apache.org/jira/browse/WICKET-5104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625342#comment-13625342
 ] 

Cedric Gatay commented on WICKET-5104:
--

For me it happened only the second time the page was rendered. The first 
display everything was fine, after a second display it was all messed up with 
the JavaScript error in the Wicket Ajax Debug window

> AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax 
> Response Error
> ---
>
> Key: WICKET-5104
> URL: https://issues.apache.org/jira/browse/WICKET-5104
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 6.3.0, 6.6.0
>Reporter: Marios Skounakis
>Assignee: Martin Grigorov
> Attachments: 5104.zip, fix-WICKET-5104.patch
>
>
> I have a ModalWindow which shows a panel with a hidden label with an 
> AjaxSelfUpdatingTimerBehavior. When the modal window is shown, the following 
> error occurs in the Wicket Ajax Debug console:
> ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating javascript: 
> TypeError: Cannot read property 'label5' of undefined, text: 
> (function(){clearTimeout(Wicket.TimerHandles['label5']); delete 
> Wicket.TimerHandles['label5'];})();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WICKET-5104) AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax Response Error


[ 
https://issues.apache.org/jira/browse/WICKET-5104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625340#comment-13625340
 ] 

Martin Grigorov commented on WICKET-5104:
-

I cannot reproduce the problem with the attached quickstart.
The Label is set invisible in the panel constructor thus the Ajax timer 
behavior is disabled and its #renderHead() is not called at all, so it doesn't 
contribute the JS which should lead to this error.

What do I miss ?

> AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax 
> Response Error
> ---
>
> Key: WICKET-5104
> URL: https://issues.apache.org/jira/browse/WICKET-5104
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 6.3.0, 6.6.0
>Reporter: Marios Skounakis
>Assignee: Martin Grigorov
> Attachments: 5104.zip, fix-WICKET-5104.patch
>
>
> I have a ModalWindow which shows a panel with a hidden label with an 
> AjaxSelfUpdatingTimerBehavior. When the modal window is shown, the following 
> error occurs in the Wicket Ajax Debug console:
> ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating javascript: 
> TypeError: Cannot read property 'label5' of undefined, text: 
> (function(){clearTimeout(Wicket.TimerHandles['label5']); delete 
> Wicket.TimerHandles['label5'];})();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (WICKET-5104) AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax Response Error


 [ 
https://issues.apache.org/jira/browse/WICKET-5104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov reassigned WICKET-5104:
---

Assignee: Martin Grigorov

> AjaxSelfUpdatingTimerBehavior in hidden component in ModalWindow causes Ajax 
> Response Error
> ---
>
> Key: WICKET-5104
> URL: https://issues.apache.org/jira/browse/WICKET-5104
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 6.3.0, 6.6.0
>Reporter: Marios Skounakis
>Assignee: Martin Grigorov
> Attachments: 5104.zip, fix-WICKET-5104.patch
>
>
> I have a ModalWindow which shows a panel with a hidden label with an 
> AjaxSelfUpdatingTimerBehavior. When the modal window is shown, the following 
> error occurs in the Wicket Ajax Debug console:
> ERROR: Wicket.Ajax.Call.processEvaluation: Exception evaluating javascript: 
> TypeError: Cannot read property 'label5' of undefined, text: 
> (function(){clearTimeout(Wicket.TimerHandles['label5']); delete 
> Wicket.TimerHandles['label5'];})();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WICKET-4795) Wicket unit tests rely on hashmap iteration order


[ 
https://issues.apache.org/jira/browse/WICKET-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625329#comment-13625329
 ] 

Martin Grigorov commented on WICKET-4795:
-

I'm going to add AjaxAttributesTester with WICKET-5092. This should help when 
you do something like:

attributesTester = new AjaxAttributesTester(wicketTester, 
component.getMarkupId());
attributesTester.assertUrl("someUrl");
attributesTester.assertMethod(AjaxRequestAttributes.METHOD.POST);


but it still wont help when using WicketTestCase to compare the generated 
markup as plain string.

> Wicket unit tests rely on hashmap iteration order
> -
>
> Key: WICKET-4795
> URL: https://issues.apache.org/jira/browse/WICKET-4795
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 1.4.21, 1.5.8, 6.0.0
>Reporter: Mikko Tiihonen
>Priority: Minor
> Attachments: fix-WICKET-4795.patch
>
>
> Starting from version 7u5 java has supported randomizing the hashmap String 
> key order (enabling this will fix CVE-2012-2739). It is also a good way to 
> test the code if it is relying on hashmap order.
> More details: 
> http://docs.oracle.com/javase/7/docs/technotes/guides/collections/changes7.html
> In the latest Java 8 (b58) the randomized hashmap is enabled by default 
> causing some wicket unit tests to fail randomly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (WICKET-5122) Add the free Wicket guide in the books page on the official site.


 [ 
https://issues.apache.org/jira/browse/WICKET-5122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov resolved WICKET-5122.
-

   Resolution: Fixed
Fix Version/s: 6.7.0
 Assignee: Martin Grigorov

Added!
Check http://wicket.apache.org/learn/books/

> Add the free Wicket guide in the books page on the official site.
> -
>
> Key: WICKET-5122
> URL: https://issues.apache.org/jira/browse/WICKET-5122
> Project: Wicket
>  Issue Type: Improvement
>Reporter: Andrea Del Bene
>Assignee: Martin Grigorov
> Fix For: 6.7.0
>
> Attachments: freeguide.diff, freeguide.png
>
>
> This issue contains the picture file and the markdown file to add the free 
> Wicket guide to the list of books available at 
> http://wicket.apache.org/learn/books/.
> Unfortunately my drawing skills are very limited, so any suggestion to 
> improve the book cover is welcome :).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

svn commit: r1465612 - in /wicket/common/site/trunk/_site/learn/books: freeguide.html freeguide.png

Author: mgrigorov
Date: Mon Apr  8 12:35:23 2013
New Revision: 1465612

URL: http://svn.apache.org/r1465612
Log:
Add an entry for Free Reference Guide by Andrea Del Bene.

Add the generated files too


Added:
wicket/common/site/trunk/_site/learn/books/freeguide.html
wicket/common/site/trunk/_site/learn/books/freeguide.png   (with props)

Added: wicket/common/site/trunk/_site/learn/books/freeguide.html
URL: 
http://svn.apache.org/viewvc/wicket/common/site/trunk/_site/learn/books/freeguide.html?rev=1465612&view=auto
==
--- wicket/common/site/trunk/_site/learn/books/freeguide.html (added)
+++ wicket/common/site/trunk/_site/learn/books/freeguide.html Mon Apr  8 
12:35:23 2013
@@ -0,0 +1,202 @@
+
+
+
+Apache Wicket - Wicket free guide
+
+   
+
+
+
+   
+   
+
+
+
+
+Apache 
Wicket
+   
+   Meet Wicket
+   
+   
+   Home
+   
+   
+   Introduction
+   
+   
+   Features
+   
+   
+   Buzz
+   
+   
+   Vision
+   
+   
+   Blogs
+   
+   
+   
+   Get Started
+   
+   
+   
+   Download Wicket
+   
+   
+   Quickstart
+   
+   
+   http://www.jweekend.com/dev/LegUp"; 
rel="nofollow">More archetypes
+   
+   
+   Get help
+   
+   
+   Mailing Lists
+   
+   
+   
+   Learn
+   
+   
+   
+   Examples
+   
+   
+   http://www.wicket-library.com/wicket-examples/compref/";>Components
+   
+   
+   Projects
+   
+   
+   http://cwiki.apache.org/WICKET";>Wiki
+   
+   
+   http://cwiki.apache.org/WICKET/reference-library.html";>Reference guide
+   
+   
+   Books
+   
+   
+   IDE plugins
+   
+   
+   
+   Releases
+   
+   
+   
+   http://www.apache.org/dyn/closer.cgi/wicket/6.6.0";>Wicket 6.6
+   
+   
+   http://www.apache.org/dyn/closer.cgi/wicket/1.5.10";>Wicket 1.5
+   
+   
+   http://www.apache.org/dyn/closer.cgi/wicket/1.4.22";>Wicket 1.4
+   
+   
+   http://www.apache.org/dyn/closer.cgi/wicket/1.3.7";>Wicket 1.3
+   
+   
+   http://wicket.sf.net/wicket-1.2"; 
class="external-link" rel="nofollow">Wicket 1.2
+   
+   
+   http://wicket.sf.net/wicket-1.1"; 
class="external-link" rel="nofollow">Wicket 1.1
+   
+   
+   http://wicket.sf.net/wicket-1.0"; 
class="external-link" rel="nofollow">Wicket 1.0
+   
+   
+   
+   API Docs
+   
+   
+   
+   http://ci.apache.org/projects/wicket/apidocs/6.0.x/"; title="JavaDocs of 
Apache Wicket 6.x">Wicket 6
+   
+   
+   http://ci.apache.org/projects/wicket/apidocs/1.5.x/"; title="JavaDocs of 
Apache Wicket 1.5.x">Wicket 1.5
+   
+   
+   http://ci.apache.org/projects/wicket/apidocs/1.4.x"; title="JavaDocs of 
Apache Wicket 1.4.x">Wicket 1.4
+   
+   
+   http://ci.apache.org/projects/wicket/apidocs/1.3.x"; title="JavaDocs of 
Apache Wicket 1.3.x">Wicket 1.3
+   
+   
+   
+   Contribute
+   
+   
+   
+   Writing docs
+   
+   
+   Build Wicket
+   
+   
+   Provide a patch
+   
+   
+   Release Wicket
+   
+   
+   http://fisheye6.atlassian.com/browse/wicket"; 
title="SVN Overview" class="external-link" rel="nofollow">Fisheye
+   
+   
+   
+   Apache
+   
+   
+   
+   http://www.apache.org/"; class="external-link" 
rel="nofollow">Apache
+   
+   
+   http://www.apache.org/licenses/"; 
class="external-link" rel="nofollow"

[jira] [Resolved] (WICKET-5131) Problems with cookies disabled when using 301/302 and also 303 (even with cookies)


 [ 
https://issues.apache.org/jira/browse/WICKET-5131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov resolved WICKET-5131.
-

   Resolution: Fixed
Fix Version/s: 1.5.11
   6.7.0
 Assignee: Martin Grigorov

Added support for SC_SEE_OTHER.
Please test it with 6.7.0-SNAPSHOT before next Friday if you can.

> Problems with cookies disabled when using 301/302 and also 303 (even with 
> cookies)
> --
>
> Key: WICKET-5131
> URL: https://issues.apache.org/jira/browse/WICKET-5131
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 6.6.0
>Reporter: oliver  z
>Assignee: Martin Grigorov
> Fix For: 6.7.0, 1.5.11
>
>
> As mentioned in the mailing list by Martin, i open this as a bug...
> Its not possible to use 303 as redirect (SC_SEE_OTHER) because thats not 
> supported, only 302 and 301 are supported but this is defined in RFC HTTP 1.1 
> from 1997. 
> 301 will add the Location header - which works as expected when disabling 
> cookies. But a 302 (which is what i prefer) will redirect to the same page 
> because the Location header is missing. When i enable cookies, its working.
> Example can be found here: https://github.com/olze/WicketRedirect

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

git commit: WICKET-5131 Problems with cookies disabled when using 301/302 and also 303 (even with cookies)

Updated Branches:
  refs/heads/wicket-1.5.x 2f20d06d4 -> bdfc0f959


WICKET-5131 Problems with cookies disabled when using 301/302 and also 303 
(even with cookies)


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/bdfc0f95
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/bdfc0f95
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/bdfc0f95

Branch: refs/heads/wicket-1.5.x
Commit: bdfc0f95944f9a97ea23ca9532b088710cfdc804
Parents: 2f20d06
Author: Martin Tzvetanov Grigorov 
Authored: Mon Apr 8 14:05:13 2013 +0300
Committer: Martin Tzvetanov Grigorov 
Committed: Mon Apr 8 14:05:55 2013 +0300

--
 .../http/handler/RedirectRequestHandler.java   |   15 ++
 .../http/handler/RedirectRequestHandlerTest.java   |   20 +++
 2 files changed, 29 insertions(+), 6 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/bdfc0f95/wicket-request/src/main/java/org/apache/wicket/request/http/handler/RedirectRequestHandler.java
--
diff --git 
a/wicket-request/src/main/java/org/apache/wicket/request/http/handler/RedirectRequestHandler.java
 
b/wicket-request/src/main/java/org/apache/wicket/request/http/handler/RedirectRequestHandler.java
index e21856f..13c99fa 100644
--- 
a/wicket-request/src/main/java/org/apache/wicket/request/http/handler/RedirectRequestHandler.java
+++ 
b/wicket-request/src/main/java/org/apache/wicket/request/http/handler/RedirectRequestHandler.java
@@ -59,9 +59,10 @@ public class RedirectRequestHandler implements 
IRequestHandler
public RedirectRequestHandler(final String redirectUrl, final int 
status)
{
if ((status != HttpServletResponse.SC_MOVED_PERMANENTLY) &&
-   (status != HttpServletResponse.SC_MOVED_TEMPORARILY))
+   (status != HttpServletResponse.SC_MOVED_TEMPORARILY) &&
+   (status != HttpServletResponse.SC_SEE_OTHER))
{
-   throw new IllegalStateException("Status must be either 
301 or 302, but was: " + status);
+   throw new IllegalStateException("Status must be either 
301, 302 or 303, but was: " + status);
}
this.redirectUrl = redirectUrl;
this.status = status;
@@ -93,17 +94,19 @@ public class RedirectRequestHandler implements 
IRequestHandler
{
final String location;
 
-   if (redirectUrl.startsWith("/"))
+   final String url = getRedirectUrl();
+
+   if (url.charAt(0) == '/')
{
// context-absolute url
-   location = 
requestCycle.getUrlRenderer().renderContextRelativeUrl(redirectUrl);
+   location = 
requestCycle.getUrlRenderer().renderContextRelativeUrl(url);
}
else
{
// if relative url, servlet container will translate to 
absolute as
// per the servlet spec
// if absolute url still do the same
-   location = redirectUrl;
+   location = url;
}
 
WebResponse response = (WebResponse)requestCycle.getResponse();
@@ -114,7 +117,7 @@ public class RedirectRequestHandler implements 
IRequestHandler
}
else
{
-   
response.setStatus(HttpServletResponse.SC_MOVED_PERMANENTLY);
+   response.setStatus(status);
response.setHeader("Location", location);
}
}

http://git-wip-us.apache.org/repos/asf/wicket/blob/bdfc0f95/wicket-request/src/test/java/org/apache/wicket/request/http/handler/RedirectRequestHandlerTest.java
--
diff --git 
a/wicket-request/src/test/java/org/apache/wicket/request/http/handler/RedirectRequestHandlerTest.java
 
b/wicket-request/src/test/java/org/apache/wicket/request/http/handler/RedirectRequestHandlerTest.java
index 3e76a1f..d6239dc 100644
--- 
a/wicket-request/src/test/java/org/apache/wicket/request/http/handler/RedirectRequestHandlerTest.java
+++ 
b/wicket-request/src/test/java/org/apache/wicket/request/http/handler/RedirectRequestHandlerTest.java
@@ -69,4 +69,24 @@ public class RedirectRequestHandlerTest
 
Mockito.verify(webResponse).sendRedirect(REDIRECT_URL);
}
+
+   /**
+* https://issues.apache.org/jira/browse/WICKET-5131
+*/
+   @Test
+   public void seeOtherShouldSetLocationHeader()
+   {
+   RedirectRequestHandler handler = new 
RedirectRequestHandler(REDIRECT_URL,
+

git commit: WICKET-5131 Problems with cookies disabled when using 301/302 and also 303 (even with cookies)

Updated Branches:
  refs/heads/master 6dd0fe21b -> 4b7367ef2


WICKET-5131 Problems with cookies disabled when using 301/302 and also 303 
(even with cookies)


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/4b7367ef
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/4b7367ef
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/4b7367ef

Branch: refs/heads/master
Commit: 4b7367ef2dd030d988cb0e8c9cdac8b7b699c565
Parents: 6dd0fe2
Author: Martin Tzvetanov Grigorov 
Authored: Mon Apr 8 14:05:13 2013 +0300
Committer: Martin Tzvetanov Grigorov 
Committed: Mon Apr 8 14:05:13 2013 +0300

--
 .../http/handler/RedirectRequestHandler.java   |   15 ++
 .../http/handler/RedirectRequestHandlerTest.java   |   20 +++
 2 files changed, 29 insertions(+), 6 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/4b7367ef/wicket-request/src/main/java/org/apache/wicket/request/http/handler/RedirectRequestHandler.java
--
diff --git 
a/wicket-request/src/main/java/org/apache/wicket/request/http/handler/RedirectRequestHandler.java
 
b/wicket-request/src/main/java/org/apache/wicket/request/http/handler/RedirectRequestHandler.java
index e21856f..13c99fa 100644
--- 
a/wicket-request/src/main/java/org/apache/wicket/request/http/handler/RedirectRequestHandler.java
+++ 
b/wicket-request/src/main/java/org/apache/wicket/request/http/handler/RedirectRequestHandler.java
@@ -59,9 +59,10 @@ public class RedirectRequestHandler implements 
IRequestHandler
public RedirectRequestHandler(final String redirectUrl, final int 
status)
{
if ((status != HttpServletResponse.SC_MOVED_PERMANENTLY) &&
-   (status != HttpServletResponse.SC_MOVED_TEMPORARILY))
+   (status != HttpServletResponse.SC_MOVED_TEMPORARILY) &&
+   (status != HttpServletResponse.SC_SEE_OTHER))
{
-   throw new IllegalStateException("Status must be either 
301 or 302, but was: " + status);
+   throw new IllegalStateException("Status must be either 
301, 302 or 303, but was: " + status);
}
this.redirectUrl = redirectUrl;
this.status = status;
@@ -93,17 +94,19 @@ public class RedirectRequestHandler implements 
IRequestHandler
{
final String location;
 
-   if (redirectUrl.startsWith("/"))
+   final String url = getRedirectUrl();
+
+   if (url.charAt(0) == '/')
{
// context-absolute url
-   location = 
requestCycle.getUrlRenderer().renderContextRelativeUrl(redirectUrl);
+   location = 
requestCycle.getUrlRenderer().renderContextRelativeUrl(url);
}
else
{
// if relative url, servlet container will translate to 
absolute as
// per the servlet spec
// if absolute url still do the same
-   location = redirectUrl;
+   location = url;
}
 
WebResponse response = (WebResponse)requestCycle.getResponse();
@@ -114,7 +117,7 @@ public class RedirectRequestHandler implements 
IRequestHandler
}
else
{
-   
response.setStatus(HttpServletResponse.SC_MOVED_PERMANENTLY);
+   response.setStatus(status);
response.setHeader("Location", location);
}
}

http://git-wip-us.apache.org/repos/asf/wicket/blob/4b7367ef/wicket-request/src/test/java/org/apache/wicket/request/http/handler/RedirectRequestHandlerTest.java
--
diff --git 
a/wicket-request/src/test/java/org/apache/wicket/request/http/handler/RedirectRequestHandlerTest.java
 
b/wicket-request/src/test/java/org/apache/wicket/request/http/handler/RedirectRequestHandlerTest.java
index 3e76a1f..d6239dc 100644
--- 
a/wicket-request/src/test/java/org/apache/wicket/request/http/handler/RedirectRequestHandlerTest.java
+++ 
b/wicket-request/src/test/java/org/apache/wicket/request/http/handler/RedirectRequestHandlerTest.java
@@ -69,4 +69,24 @@ public class RedirectRequestHandlerTest
 
Mockito.verify(webResponse).sendRedirect(REDIRECT_URL);
}
+
+   /**
+* https://issues.apache.org/jira/browse/WICKET-5131
+*/
+   @Test
+   public void seeOtherShouldSetLocationHeader()
+   {
+   RedirectRequestHandler handler = new 
RedirectRequestHandler(REDIRECT_URL,
+

[jira] [Commented] (WICKET-5132) Evaluation of returned data (which includes alot of javascript) very slow after ajax call in IE10.


[ 
https://issues.apache.org/jira/browse/WICKET-5132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625267#comment-13625267
 ] 

Martin Grigorov commented on WICKET-5132:
-

Thanks, Andrea!

In the JSPerf link Bas provided there is no usage of childNodes[0].nodeValue.
Can you check with s = node.textContent and s = node.firstChild.nodeValue ?
It would be nice if you run the test on IE 7 and 8 so we can see the results. 
Scroll to the bottom in the JSPerf page and you will see the current results 
for different browsers.

> Evaluation of returned data (which includes alot of javascript) very slow 
> after ajax call in IE10.
> --
>
> Key: WICKET-5132
> URL: https://issues.apache.org/jira/browse/WICKET-5132
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 6.0.0
> Environment: IE10
>Reporter: Bas Veenema
>  Labels: javascript, performance
> Attachments: response_script.txt
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> We're using ajax to update a treetable. In IE10, when the ajax call returns 
> the data, which contains alot of javascript code, processEvaluation in 
> wicket-ajax-jquery.js stalls on var text = jQuery(node).text();
> In jQuery procedure Sizzle.getText is called, which eventually returns 
> property elem.textContent. In IE10 this last statement takes about 26 seconds 
> for our case while the same statement in chrome takes about 6 ms.
> It seems strange that IE10 takes this long to return the textContent of a 
> node, but why is this necessary in the first place?
> The purpose of var text = jQuery(node).text() would be to get the text of the 
> node. I think it would suffice to state var text = 
> node.childNodes[0].nodeValue instead of var text = Query(node).text(), 
> because the text is in the node itself, and it's not necessary to get the 
> text from its descendants, because it has no descendants.
> In our case this modification improves the duration from 25915 ms to 8 ms in 
> IE10.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (WICKET-5136) CheckingObjectOutputStream#check(Object) swallows Exception without logging the cause


 [ 
https://issues.apache.org/jira/browse/WICKET-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov resolved WICKET-5136.
-

   Resolution: Fixed
Fix Version/s: 6.7.0
 Assignee: Martin Grigorov

> CheckingObjectOutputStream#check(Object) swallows Exception without logging 
> the cause
> -
>
> Key: WICKET-5136
> URL: https://issues.apache.org/jira/browse/WICKET-5136
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 6.5.0
>Reporter: Peter Parson
>Assignee: Martin Grigorov
>Priority: Minor
> Fix For: 6.7.0
>
> Attachments: 
> CheckingObjectOutputStream_check_pass_exception_to_log_warn.patch
>
>
> A warning message is sent to log when an exception occurs during checking, 
> but it does not include information about the exception itself.
> Patch: pass Exception object to log.warn

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

git commit: WICKET-5136 CheckingObjectOutputStream#check(Object) swallows Exception without logging the cause

Updated Branches:
  refs/heads/master 518c933bb -> 6dd0fe21b


WICKET-5136 CheckingObjectOutputStream#check(Object) swallows Exception without 
logging the cause


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/6dd0fe21
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/6dd0fe21
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/6dd0fe21

Branch: refs/heads/master
Commit: 6dd0fe21b04b1af7a1fc26ffe40f820bc2edb31b
Parents: 518c933
Author: Martin Tzvetanov Grigorov 
Authored: Mon Apr 8 13:06:07 2013 +0300
Committer: Martin Tzvetanov Grigorov 
Committed: Mon Apr 8 13:06:07 2013 +0300

--
 .../checker/CheckingObjectOutputStream.java|4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/6dd0fe21/wicket-core/src/main/java/org/apache/wicket/core/util/objects/checker/CheckingObjectOutputStream.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/core/util/objects/checker/CheckingObjectOutputStream.java
 
b/wicket-core/src/main/java/org/apache/wicket/core/util/objects/checker/CheckingObjectOutputStream.java
index d6e5715..bf56d41 100644
--- 
a/wicket-core/src/main/java/org/apache/wicket/core/util/objects/checker/CheckingObjectOutputStream.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/core/util/objects/checker/CheckingObjectOutputStream.java
@@ -345,8 +345,8 @@ public class CheckingObjectOutputStream extends 
ObjectOutputStream
}
catch (RuntimeException e)
{
-   log.warn("Wasn't possible to check the object '{}' 
possible due an problematic " +
-   "implementation of equals method", 
obj.getClass());
+   log.warn(String.format("Wasn't possible to check the 
object '%s' possible due an problematic " +
+   "implementation of equals method", 
obj.getClass()), e);
/*
 * Can't check if this obj were in stack, giving up 
because we don't want to throw an
 * invaluable exception to user. The main goal of this 
checker is to find non

buildbot success in ASF Buildbot on wicket-branch-1.5.x

2013-04-08 Thread buildbot

The Buildbot has detected a restored build on builder wicket-branch-1.5.x while 
building wicket.
Full details are available at:
 http://ci.apache.org/builders/wicket-branch-1.5.x/builds/418

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: hemera_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch wicket-1.5.x] 
2f20d06d42b9daddbf4243ee6e592d4a9b428059
Blamelist: Martin Tzvetanov Grigorov 

Build succeeded!

sincerely,
 -The Buildbot

[jira] [Resolved] (WICKET-5114) Url#toString(StringMode.FULL) throws exception if a segment contains two dots


 [ 
https://issues.apache.org/jira/browse/WICKET-5114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov resolved WICKET-5114.
-

   Resolution: Fixed
Fix Version/s: 1.5.11
   6.7.0
 Assignee: Martin Grigorov

Thanks, Cedric!

> Url#toString(StringMode.FULL) throws exception if a segment contains two dots
> -
>
> Key: WICKET-5114
> URL: https://issues.apache.org/jira/browse/WICKET-5114
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 6.5.0
>Reporter: Peter Parson
>Assignee: Martin Grigorov
> Fix For: 6.7.0, 1.5.11
>
> Attachments: fix-WICKET-5114.patch
>
>
> When invoking toString(StringMode.FULL) for a URL like
> /mountPoint/whatever.../
> an IllegalStateException is thrown with message: Cannot render this url in 
> FULL mode because it has a `..` segment: /mountPoint/whatever.../
> The method does not actually check for `..` segments but rather checks 
> whether path.contains("..")

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

git commit: WICKET-5114 Url#toString(StringMode.FULL) throws exception if a segment contains two dots

Updated Branches:
  refs/heads/wicket-1.5.x 5a8bfada5 -> 2f20d06d4


WICKET-5114 Url#toString(StringMode.FULL) throws exception if a segment 
contains two dots


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/2f20d06d
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/2f20d06d
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/2f20d06d

Branch: refs/heads/wicket-1.5.x
Commit: 2f20d06d42b9daddbf4243ee6e592d4a9b428059
Parents: 5a8bfad
Author: Martin Tzvetanov Grigorov 
Authored: Mon Apr 8 12:53:02 2013 +0300
Committer: Martin Tzvetanov Grigorov 
Committed: Mon Apr 8 13:01:00 2013 +0300

--
 .../main/java/org/apache/wicket/request/Url.java   |2 +-
 .../java/org/apache/wicket/request/UrlTest.java|   17 +++
 2 files changed, 18 insertions(+), 1 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/2f20d06d/wicket-request/src/main/java/org/apache/wicket/request/Url.java
--
diff --git a/wicket-request/src/main/java/org/apache/wicket/request/Url.java 
b/wicket-request/src/main/java/org/apache/wicket/request/Url.java
index 077f167..f2d4394 100755
--- a/wicket-request/src/main/java/org/apache/wicket/request/Url.java
+++ b/wicket-request/src/main/java/org/apache/wicket/request/Url.java
@@ -704,7 +704,7 @@ public class Url implements Serializable
result.append(port);
}
 
-   if (path.contains(".."))
+   if (segments.contains(".."))
{
throw new IllegalStateException("Cannot render 
this url in " +
StringMode.FULL.name() + " mode because 
it has a `..` segment: " + toString());

http://git-wip-us.apache.org/repos/asf/wicket/blob/2f20d06d/wicket-request/src/test/java/org/apache/wicket/request/UrlTest.java
--
diff --git 
a/wicket-request/src/test/java/org/apache/wicket/request/UrlTest.java 
b/wicket-request/src/test/java/org/apache/wicket/request/UrlTest.java
index 54200d6..09e6b93 100644
--- a/wicket-request/src/test/java/org/apache/wicket/request/UrlTest.java
+++ b/wicket-request/src/test/java/org/apache/wicket/request/UrlTest.java
@@ -799,4 +799,21 @@ public class UrlTest extends Assert
assertEquals(Integer.valueOf(9090), url.getPort());
 
}
+
+   @Test
+   public void wicket_5114_allowtoStringFullWhenContainingTwoDots()
+   {
+   Url url = Url.parse("/mountPoint/whatever.../");
+   url.setHost("wicketHost");
+   assertEquals("http://wicketHost/mountPoint/whatever.../";, 
url.toString(StringMode.FULL));
+   }
+
+   @Test(expected = IllegalStateException.class)
+   public void 
wicket_5114_throwExceptionWhenToStringFullContainsRelativePathSegment()
+   {
+   Url url = Url.parse("/mountPoint/../whatever/");
+   url.setHost("wicketHost");
+   url.toString(StringMode.FULL);
+   }
+
 }

git commit: WICKET-5114 Url#toString(StringMode.FULL) throws exception if a segment contains two dots

Updated Branches:
  refs/heads/master e0d2b7c38 -> 518c933bb


WICKET-5114 Url#toString(StringMode.FULL) throws exception if a segment 
contains two dots


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/518c933b
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/518c933b
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/518c933b

Branch: refs/heads/master
Commit: 518c933bb31c35b736253936ba080ac21e6cb19f
Parents: e0d2b7c
Author: Martin Tzvetanov Grigorov 
Authored: Mon Apr 8 12:53:02 2013 +0300
Committer: Martin Tzvetanov Grigorov 
Committed: Mon Apr 8 12:53:02 2013 +0300

--
 .../main/java/org/apache/wicket/request/Url.java   |2 +-
 .../java/org/apache/wicket/request/UrlTest.java|   16 +++
 2 files changed, 17 insertions(+), 1 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/518c933b/wicket-request/src/main/java/org/apache/wicket/request/Url.java
--
diff --git a/wicket-request/src/main/java/org/apache/wicket/request/Url.java 
b/wicket-request/src/main/java/org/apache/wicket/request/Url.java
index 12ca5f0..9ca2c0d 100755
--- a/wicket-request/src/main/java/org/apache/wicket/request/Url.java
+++ b/wicket-request/src/main/java/org/apache/wicket/request/Url.java
@@ -674,7 +674,7 @@ public class Url implements Serializable
result.append(port);
}
 
-   if (path.contains(".."))
+   if (segments.contains(".."))
{
throw new IllegalStateException("Cannot render 
this url in " +
StringMode.FULL.name() + " mode because 
it has a `..` segment: " + toString());

http://git-wip-us.apache.org/repos/asf/wicket/blob/518c933b/wicket-request/src/test/java/org/apache/wicket/request/UrlTest.java
--
diff --git 
a/wicket-request/src/test/java/org/apache/wicket/request/UrlTest.java 
b/wicket-request/src/test/java/org/apache/wicket/request/UrlTest.java
index 91a4914..eaebe14 100644
--- a/wicket-request/src/test/java/org/apache/wicket/request/UrlTest.java
+++ b/wicket-request/src/test/java/org/apache/wicket/request/UrlTest.java
@@ -911,4 +911,20 @@ public class UrlTest extends Assert
 
url.removeLeadingSegments(3);
}
+
+@Test
+public void wicket_5114_allowtoStringFullWhenContainingTwoDots()
+{
+Url url = Url.parse("/mountPoint/whatever.../");
+url.setHost("wicketHost");
+assertEquals("//wicketHost/mountPoint/whatever.../", 
url.toString(StringMode.FULL));
+}
+
+@Test(expected = IllegalStateException.class)
+public void 
wicket_5114_throwExceptionWhenToStringFullContainsRelativePathSegment()
+{
+Url url = Url.parse("/mountPoint/../whatever/");
+url.setHost("wicketHost");
+url.toString(StringMode.FULL);
+}
 }

[jira] [Resolved] (WICKET-5137) Improve TagTester support for Ajax responses


 [ 
https://issues.apache.org/jira/browse/WICKET-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov resolved WICKET-5137.
-

   Resolution: Fixed
Fix Version/s: 6.7.0

Improved by removing the CDATA for the 's.
The  attributes (the id) are also removed because the id is often 
the same as the HTML element inside the  and we need getTagById() to 
return the HTML element, not the 

> Improve TagTester support for Ajax responses
> 
>
> Key: WICKET-5137
> URL: https://issues.apache.org/jira/browse/WICKET-5137
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.6.0
>Reporter: Martin Grigorov
>Assignee: Martin Grigorov
>Priority: Minor
> Fix For: 6.7.0
>
>
> org.apache.wicket.util.tester.TagTester#createTagByAttribute does not work 
> for Ajax responses because the HTML elements are inside CDATA and thus 
> ignored by XmlPullParser.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

git commit: WICKET-5137 Improve TagTester support for Ajax responses

Updated Branches:
  refs/heads/master af34de7f6 -> e0d2b7c38


WICKET-5137 Improve TagTester support for Ajax responses


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/e0d2b7c3
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/e0d2b7c3
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/e0d2b7c3

Branch: refs/heads/master
Commit: e0d2b7c38188f34d669a47c6f22d8965fa0c295a
Parents: af34de7
Author: Martin Tzvetanov Grigorov 
Authored: Mon Apr 8 12:06:44 2013 +0300
Committer: Martin Tzvetanov Grigorov 
Committed: Mon Apr 8 12:06:44 2013 +0300

--
 .../org/apache/wicket/util/tester/TagTester.java   |   16 +-
 .../markup/html/image/AjaxUpdatedImageTest.java|4 +-
 .../apache/wicket/util/tester/TagTesterTest.java   |   17 ++-
 3 files changed, 33 insertions(+), 4 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/e0d2b7c3/wicket-core/src/main/java/org/apache/wicket/util/tester/TagTester.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/util/tester/TagTester.java 
b/wicket-core/src/main/java/org/apache/wicket/util/tester/TagTester.java
index 7aba99b..9915981 100644
--- a/wicket-core/src/main/java/org/apache/wicket/util/tester/TagTester.java
+++ b/wicket-core/src/main/java/org/apache/wicket/util/tester/TagTester.java
@@ -19,6 +19,7 @@ package org.apache.wicket.util.tester;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
+import java.util.regex.Pattern;
 
 import org.apache.wicket.WicketRuntimeException;
 import org.apache.wicket.markup.parser.XmlPullParser;
@@ -50,6 +51,9 @@ import org.apache.wicket.util.value.IValueMap;
  */
 public class TagTester
 {
+   private static final Pattern AJAX_COMPONENT_CDATA_OPEN = 
Pattern.compile("");
+
private final XmlTag openTag;
 
private final XmlTag closeTag;
@@ -362,10 +366,15 @@ public class TagTester
{
try
{
+   // remove the CDATA and
+   // the id attribute of the component because it 
is often the same as the element's id
+   markup = 
AJAX_COMPONENT_CDATA_OPEN.matcher(markup).replaceAll("");
+   markup = 
AJAX_COMPONENT_CDATA_CLOSE.matcher(markup).replaceAll("");
+
XmlPullParser parser = new XmlPullParser();
parser.parse(markup);
 
-   XmlTag elm = null;
+   XmlTag elm;
XmlTag openTag = null;
XmlTag closeTag = null;
int level = 0;
@@ -486,6 +495,11 @@ public class TagTester
{
try
{
+   // remove the CDATA and
+   // the id attribute of the component because it 
is often the same as the element's id
+   markup = 
AJAX_COMPONENT_CDATA_OPEN.matcher(markup).replaceAll("");
+   markup = 
AJAX_COMPONENT_CDATA_CLOSE.matcher(markup).replaceAll("");
+
XmlPullParser parser = new XmlPullParser();
parser.parse(markup);
 

http://git-wip-us.apache.org/repos/asf/wicket/blob/e0d2b7c3/wicket-core/src/test/java/org/apache/wicket/markup/html/image/AjaxUpdatedImageTest.java
--
diff --git 
a/wicket-core/src/test/java/org/apache/wicket/markup/html/image/AjaxUpdatedImageTest.java
 
b/wicket-core/src/test/java/org/apache/wicket/markup/html/image/AjaxUpdatedImageTest.java
index c095778..f235ff6 100644
--- 
a/wicket-core/src/test/java/org/apache/wicket/markup/html/image/AjaxUpdatedImageTest.java
+++ 
b/wicket-core/src/test/java/org/apache/wicket/markup/html/image/AjaxUpdatedImageTest.java
@@ -44,9 +44,9 @@ public class AjaxUpdatedImageTest extends WicketTestCase
tester.clickLink("link", true);
page = (AjaxyImagesPage)tester.getLastRenderedPage();
tagTester = tester.getTagById(page.image.getMarkupId());
-   final String imageAjaxComponent = tagTester.getValue();
+   final String srcAttr1 = tagTester.getAttribute("src");
assertTrue(
"Image has not be rendered in Ajax request so it has no 
wicket:antiCache' parameter",
-   imageAjaxComponent.contains("antiCache"));
+   srcAttr1.contains("antiCache"));
}
 }

http://git-wip-us.apache.org/repos/asf/wicke

[jira] [Created] (WICKET-5137) Improve TagTester support for Ajax responses