buildbot success in ASF Buildbot on wicket-master
The Buildbot has detected a restored build on builder wicket-master while building wicket. Full details are available at: http://ci.apache.org/builders/wicket-master/builds/1673 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: hemera_ubuntu Build Reason: scheduler Build Source Stamp: [branch master] da98a830ce75b94bd7885a759659d1bd7abcf193 Blamelist: Igor Vaynberg Build succeeded! sincerely, -The Buildbot
git commit: WICKET-3335 fix remaining test
Repository: wicket Updated Branches: refs/heads/master c2e12216f -> da98a830c WICKET-3335 fix remaining test Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/da98a830 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/da98a830 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/da98a830 Branch: refs/heads/master Commit: da98a830ce75b94bd7885a759659d1bd7abcf193 Parents: c2e1221 Author: Igor Vaynberg Authored: Tue Feb 25 14:54:50 2014 -0800 Committer: Igor Vaynberg Committed: Tue Feb 25 14:54:52 2014 -0800 -- .../src/main/java/org/apache/wicket/MarkupContainer.java| 9 - 1 file changed, 8 insertions(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/wicket/blob/da98a830/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java -- diff --git a/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java b/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java index 914112a..d588112 100644 --- a/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java +++ b/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java @@ -939,11 +939,18 @@ public abstract class MarkupContainer extends Component implements Iterable
[jira] [Updated] (WICKET-5518) FormComponent.updateCollectionModel does not handle unmodifiableList
[
https://issues.apache.org/jira/browse/WICKET-5518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sven Meier updated WICKET-5518:
---
Fix Version/s: 7.0.0
> FormComponent.updateCollectionModel does not handle unmodifiableList
> -
>
> Key: WICKET-5518
> URL: https://issues.apache.org/jira/browse/WICKET-5518
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 6.12.0
>Reporter: Petr Lancaric
>Assignee: Sven Meier
>Priority: Minor
> Fix For: 7.0.0
>
>
> FormComponent.updateCollectionModel should handle situation, when getter
> returns unmodifiable list.
> Proposed solution:
> formComponent.modelChanging();
> booelan isChanged;
> try {
> collection.clear();
> if (convertedInput != null)
> {
> collection.addAll(convertedInput);
> }
> isChanged = true;
> catch (Exception e)
> {
> // ignore this exception as Unmodifiable list
> does not allow change
> logger.info("An error occurred while trying to
> modify list attached to " + formComponent, e);
> }
> try
> {
> if(isChanged)
>
> formComponent.getModel().setObject(collection);
> else
> // TODO: create here collection as
> non-abstract successor of setObject declared argument
> formComponent.getModel().setObject(new
> ArrayList(convertedInput));
> isChanged = true;
> }
> catch (Exception e)
> {
> // ignore this exception because it could be
> that there
> // is not setter for this collection.
> logger.info("An error occurred while trying to
> set the new value for the property attached to " + formComponent, e);
> }
> // at least one update method should pass successfully
>
> if(isChanged)
> formComponent.modelChanged();
> else
> throw new RuntimeException("An error occurred
> while trying to modify value for the property attached to " + formComponent);
>
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (WICKET-5518) FormComponent.updateCollectionModel does not handle unmodifiableList
[
https://issues.apache.org/jira/browse/WICKET-5518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13912162#comment-13912162
]
Sven Meier commented on WICKET-5518:
I've pushed an improvement in Wicket master. I'm not sure it's safe to apply
the change to 6.x too, since it changes the invocation order of #modelChanged()
and this might break user's code.
> FormComponent.updateCollectionModel does not handle unmodifiableList
> -
>
> Key: WICKET-5518
> URL: https://issues.apache.org/jira/browse/WICKET-5518
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 6.12.0
>Reporter: Petr Lancaric
>Assignee: Sven Meier
>Priority: Minor
> Fix For: 7.0.0
>
>
> FormComponent.updateCollectionModel should handle situation, when getter
> returns unmodifiable list.
> Proposed solution:
> formComponent.modelChanging();
> booelan isChanged;
> try {
> collection.clear();
> if (convertedInput != null)
> {
> collection.addAll(convertedInput);
> }
> isChanged = true;
> catch (Exception e)
> {
> // ignore this exception as Unmodifiable list
> does not allow change
> logger.info("An error occurred while trying to
> modify list attached to " + formComponent, e);
> }
> try
> {
> if(isChanged)
>
> formComponent.getModel().setObject(collection);
> else
> // TODO: create here collection as
> non-abstract successor of setObject declared argument
> formComponent.getModel().setObject(new
> ArrayList(convertedInput));
> isChanged = true;
> }
> catch (Exception e)
> {
> // ignore this exception because it could be
> that there
> // is not setter for this collection.
> logger.info("An error occurred while trying to
> set the new value for the property attached to " + formComponent, e);
> }
> // at least one update method should pass successfully
>
> if(isChanged)
> formComponent.modelChanged();
> else
> throw new RuntimeException("An error occurred
> while trying to modify value for the property attached to " + formComponent);
>
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
git commit: WICKET-5518 support unmodifiable collections as well as models without setter
Repository: wicket
Updated Branches:
refs/heads/master a8c6daec3 -> c2e12216f
WICKET-5518 support unmodifiable collections as well as models without
setter
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/c2e12216
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/c2e12216
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/c2e12216
Branch: refs/heads/master
Commit: c2e12216f38b4bd0517aff239f67e9925ac5a106
Parents: a8c6dae
Author: svenmeier
Authored: Tue Feb 25 23:20:02 2014 +0100
Committer: svenmeier
Committed: Tue Feb 25 23:20:02 2014 +0100
--
.../wicket/markup/html/form/FormComponent.java | 43 ++--
.../html/form/CollectionFormComponentTest.java | 195 +++
2 files changed, 226 insertions(+), 12 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/c2e12216/wicket-core/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java
b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java
index fdeb8c6..cb4ad05 100644
---
a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java
+++
b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/FormComponent.java
@@ -1610,8 +1610,8 @@ public abstract class FormComponent extends
LabeledWebMarkupContainer impleme
* @param formComponent
*the form component to update
* @see FormComponent#updateModel()
-* @throws UnsupportedOperationException
-* if the existing model object Collection cannot be
modified
+* @throws WicketRuntimeException
+* if the existing model object collection is unmodifiable
and no setter exists
*/
public static void
updateCollectionModel(FormComponent> formComponent)
{
@@ -1625,23 +1625,42 @@ public abstract class FormComponent extends
LabeledWebMarkupContainer impleme
}
else
{
+ Exception failure;
+
formComponent.modelChanging();
- collection.clear();
- if (convertedInput != null)
- {
- collection.addAll(convertedInput);
- }
- formComponent.modelChanged();
+
+ try {
+ collection.clear();
+ if (convertedInput != null)
+ {
+ collection.addAll(convertedInput);
+ }
+ failure = null;
+ } catch (UnsupportedOperationException unmodifiable) {
+ logger.debug("An error occurred while trying to
change the collection attached to " + formComponent, unmodifiable);
+ failure = unmodifiable;
+ collection = new ArrayList<>(convertedInput);
+ }
+
try
{
formComponent.getModel().setObject(collection);
+ failure = null;
}
- catch (Exception e)
+ catch (Exception noSetter)
{
- // ignore this exception because it could be
that there
- // is not setter for this collection.
- logger.info("An error occurred while trying to
set the new value for the property attached to " + formComponent, e);
+ logger.debug("An error occurred while trying to
set the collection attached to " + formComponent, noSetter);
+
+ if (failure != null) {
+ failure = noSetter;
+ }
+ }
+
+ if (failure == null) {
+ formComponent.modelChanged();
+ } else {
+ throw new WicketRuntimeException("Unable to
update the collection attached to " + formComponent);
}
}
}
http://git-wip-us.apache.org/repos/asf/wicket/blob/c2e12216/wicket-core/src/test/java/org/apache/wicket/markup/html/form/CollectionFormComponentTest.java
[jira] [Commented] (WICKET-5501) Support of client timezones for java.util.Date, java.util.Timestamp and etc.
[ https://issues.apache.org/jira/browse/WICKET-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911959#comment-13911959 ] Ilia Naryzhny commented on WICKET-5501: --- I think that all Date related convertors should have common parent class with ability to override getTimezone and getDateFormat methods. Currently, it's not true and it's very hard to do with existing classes. And more over: as I can see, there is no reason to use joda.time for this kind of convertions. Joda.Time can just add some realizations for "extra" date formats. Opinions of wicket's devs are very interesting... > Support of client timezones for java.util.Date, java.util.Timestamp and etc. > > > Key: WICKET-5501 > URL: https://issues.apache.org/jira/browse/WICKET-5501 > Project: Wicket > Issue Type: Improvement > Components: wicket, wicket-datetime >Affects Versions: 6.13.0 >Reporter: Ilia Naryzhny > Labels: converter, time_zone, wicket > Attachments: AbstractDateConverter.java > > > That was surprise for me that wicket doesn't support convertion of > java.util.Date, java.sql.Date, java.sql.Time, java.sql.Timestamp taking into > account client timezone. > I know about existing DateConverter/StyleDateConverter and etc. But it's not > so easy to extend and reuse that for java.sql.* types. > Please find in the attachment our implementation of date convertor which is > taking into account client timezone and (!) don't use org.joda.time. Hope > that it can be included (maybe after some refactoring) into main branch. > Please let me know your vision of this approach and if you are OK: let me go > ahead and prepare patch. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Closed] (WICKET-5515) AjaxFallbackLink does not work on pages with the version number removed
[
https://issues.apache.org/jira/browse/WICKET-5515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip McCullick closed WICKET-5515.
Thanks Martin! That fixes the issue.
> AjaxFallbackLink does not work on pages with the version number removed
> ---
>
> Key: WICKET-5515
> URL: https://issues.apache.org/jira/browse/WICKET-5515
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 6.13.0, 6.14.0
>Reporter: Philip McCullick
> Attachments: AjaxFallbackLinkTest.zip
>
>
> In Wicket 6.13/6.14, if you add an AjaxFallbackLink to a page that uses a
> custom MountedMapper to remove the version number then the ajax "click" event
> will never be triggered. This was working in all versions of Wicket up till
> 6.12.
> I'll attach a sample project that has two pages mounted:
> 1. PageMountedNormally - clicking the link will fire an alert("clicked").
> 2. PageMountedWithoutVersion - clicking the link should fire the alert but
> instead just refreshes the page.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
git commit: WICKET-3335 small cleanup of dequeuing code
Repository: wicket
Updated Branches:
refs/heads/master 8088d460a -> a8c6daec3
WICKET-3335 small cleanup of dequeuing code
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/a8c6daec
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/a8c6daec
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/a8c6daec
Branch: refs/heads/master
Commit: a8c6daec3cf6241bee5741e1083dfc0db1a3d6a8
Parents: 8088d46
Author: Igor Vaynberg
Authored: Tue Feb 25 08:20:53 2014 -0800
Committer: Igor Vaynberg
Committed: Tue Feb 25 09:25:35 2014 -0800
--
.../html/panel/DequeueMarkupFragment.java | 23
.../wicket/markup/html/panel/Fragment.java | 2 +-
2 files changed, 1 insertion(+), 24 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/a8c6daec/wicket-core/src/main/java/org/apache/wicket/markup/html/panel/DequeueMarkupFragment.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/markup/html/panel/DequeueMarkupFragment.java
b/wicket-core/src/main/java/org/apache/wicket/markup/html/panel/DequeueMarkupFragment.java
deleted file mode 100644
index 2239989..000
---
a/wicket-core/src/main/java/org/apache/wicket/markup/html/panel/DequeueMarkupFragment.java
+++ /dev/null
@@ -1,23 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.wicket.markup.html.panel;
-
-//TODO queueing Do we need this class ? It is not used at he moment
-public class DequeueMarkupFragment
-{
-
-}
http://git-wip-us.apache.org/repos/asf/wicket/blob/a8c6daec/wicket-core/src/main/java/org/apache/wicket/markup/html/panel/Fragment.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/markup/html/panel/Fragment.java
b/wicket-core/src/main/java/org/apache/wicket/markup/html/panel/Fragment.java
index e915714..25e9b10 100644
---
a/wicket-core/src/main/java/org/apache/wicket/markup/html/panel/Fragment.java
+++
b/wicket-core/src/main/java/org/apache/wicket/markup/html/panel/Fragment.java
@@ -136,7 +136,7 @@ public class Fragment extends WebMarkupContainer implements
IQueueRegion
@Override
public DequeueContext newDequeueContext()
{
- IMarkupFragment markup =
newMarkupSourcingStrategy().getMarkup(this, null);
+ IMarkupFragment markup =
getMarkupSourcingStrategy().getMarkup(this, null);
if (markup == null)
{
return null;
[jira] [Commented] (WICKET-5517) IE11 returns false for Wicket.Browser.isIE()
[ https://issues.apache.org/jira/browse/WICKET-5517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911661#comment-13911661 ] ASF GitHub Bot commented on WICKET-5517: Github user niesink closed the pull request at: https://github.com/apache/wicket/pull/69 > IE11 returns false for Wicket.Browser.isIE() > > > Key: WICKET-5517 > URL: https://issues.apache.org/jira/browse/WICKET-5517 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 6.14.0 > Environment: Internet Explorer 11, tested on Windows 7 and 8. >Reporter: Luke Niesink >Assignee: Emond Papegaaij >Priority: Minor > > As of Internet Explorer 11 this statement returns false instead of true (like > it did prior to version 11): > typeof(document.all) !== "undefined" > This statement is used on line 56 of wicket-event-jquery.js which means > Wicket.Browser.isIE() will return false in IE11. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (WICKET-5517) IE11 returns false for Wicket.Browser.isIE()
[ https://issues.apache.org/jira/browse/WICKET-5517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911660#comment-13911660 ] ASF GitHub Bot commented on WICKET-5517: Github user niesink commented on the pull request: https://github.com/apache/wicket/pull/69#issuecomment-36018963 Tried to merge into master instead of the wicket-6.x branch, apologies > IE11 returns false for Wicket.Browser.isIE() > > > Key: WICKET-5517 > URL: https://issues.apache.org/jira/browse/WICKET-5517 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 6.14.0 > Environment: Internet Explorer 11, tested on Windows 7 and 8. >Reporter: Luke Niesink >Assignee: Emond Papegaaij >Priority: Minor > > As of Internet Explorer 11 this statement returns false instead of true (like > it did prior to version 11): > typeof(document.all) !== "undefined" > This statement is used on line 56 of wicket-event-jquery.js which means > Wicket.Browser.isIE() will return false in IE11. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (WICKET-5517) IE11 returns false for Wicket.Browser.isIE()
[ https://issues.apache.org/jira/browse/WICKET-5517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911657#comment-13911657 ] ASF GitHub Bot commented on WICKET-5517: GitHub user niesink opened a pull request: https://github.com/apache/wicket/pull/70 WICKET-5517 Added support for detection of IE11 in Wicket.Browser.isIE() and update references to Wicket.Browser.isIE() You can merge this pull request into a Git repository by running: $ git pull https://github.com/niesink/wicket wicket-6.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/wicket/pull/70.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #70 commit a8fcba33b2ae33ccadfd6885ac05812143cbd5c9 Author: Luke Niesink Date: 2014-02-25T15:15:06Z WICKET-5517 Added support for detection of IE11 in Wicket.Browser.isIE() commit a6565b625581ea583006ac98e5d4dba9c7b730fc Author: Luke Niesink Date: 2014-02-25T15:16:35Z WICKET-5517 Use Wicket.Browser.isIELessThan11() as the behaviour of Wicket.Browser.isIE() has changed > IE11 returns false for Wicket.Browser.isIE() > > > Key: WICKET-5517 > URL: https://issues.apache.org/jira/browse/WICKET-5517 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 6.14.0 > Environment: Internet Explorer 11, tested on Windows 7 and 8. >Reporter: Luke Niesink >Assignee: Emond Papegaaij >Priority: Minor > > As of Internet Explorer 11 this statement returns false instead of true (like > it did prior to version 11): > typeof(document.all) !== "undefined" > This statement is used on line 56 of wicket-event-jquery.js which means > Wicket.Browser.isIE() will return false in IE11. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (WICKET-5517) IE11 returns false for Wicket.Browser.isIE()
[ https://issues.apache.org/jira/browse/WICKET-5517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911656#comment-13911656 ] ASF GitHub Bot commented on WICKET-5517: GitHub user niesink opened a pull request: https://github.com/apache/wicket/pull/69 WICKET-5517 Added support for detection of IE11 in Wicket.Browser.isIE() and update references to Wicket.Browser.isIE() You can merge this pull request into a Git repository by running: $ git pull https://github.com/niesink/wicket wicket-6.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/wicket/pull/69.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #69 commit bcce5f29cf42afc83ab99d50f26558194b59192c Author: Martin Tzvetanov Grigorov Date: 2013-09-16T08:25:11Z Append character instead of String where possible commit 3c4db496af86e972b2cfc2ed20a6fef25539afb6 Author: Martin Tzvetanov Grigorov Date: 2013-09-16T08:25:30Z WICKET-5345 Url.canonical() breaks when there are two consecutive "parent" segments followed by a normal segment commit 6eb5df74a771f8ad15a1302aa5700e463ddc70a6 Author: Martin Tzvetanov Grigorov Date: 2013-09-16T11:52:52Z WICKET-5348 JavaDoc for IColumn#getSortProperty() in misleading commit 89c660fbb1be911b540ff0cf270c35e7ff6a8fb0 Author: Martin Tzvetanov Grigorov Date: 2013-09-17T08:11:05Z Minor improvement: use Args.notNull commit 1758ba6b5061f00550d9d65c9b077710d0834e9e Author: Martin Tzvetanov Grigorov Date: 2013-09-17T08:22:00Z WICKET-5354 Make ResourceBundles and related classes easier for extension commit 46c03d259c62a9b6b4e13b9c0a86b252c9ecde19 Author: Martijn Dashorst Date: 2013-09-20T09:59:22Z Added release notes commit abd0bc5dbb95772af53649510f36a9607d5a9018 Author: Martijn Dashorst Date: 2013-09-20T10:01:43Z Added revert script to quickly revert a release when e.g. the changelog was not updated... commit 556587dfe5ebaf9499812fe08f273e7f75c56da4 Author: svenmeier Date: 2013-09-20T19:11:09Z WICKET-5359 fixed equals for different locales commit 53b335ee6140f9a0eade5bd30e1d131a67483f20 Author: bitstorm Date: 2013-09-21T13:40:55Z WICKET-5356 AutoCompleteSettings.setShowListOnEmptyInput(true) is not working anymore commit d1570dbe76926459e7b036ab3e457a54fbeebbe8 Author: Martin Tzvetanov Grigorov Date: 2013-09-23T12:01:40Z WICKET-5362 Add support for parsing IE 11 user agent commit c0c83d54f6b7466962b0d66bdfac0a0be231d312 Author: Martin Tzvetanov Grigorov Date: 2013-09-24T08:27:41Z WICKET-5366 ResourceAggregator looses information about priority/filtering/... when using a bundle Add a test case showing the problem commit a6a37d445182fdc0ba385602170b474cca674ff5 Author: Emond Papegaaij Date: 2013-09-24T13:20:35Z WICKET-5366: rewrap bundle-HeaderItems after resolving commit 27cfdf284521cde403f2bfaca4a03f40fc9f2372 Author: Martin Tzvetanov Grigorov Date: 2013-09-24T17:44:40Z Remove usage of prototype.js in Ajax/GuestBook example. It is not really needed commit 865a34fdd5b114fe35c3c7fb2c9a013ca689375a Author: Martijn Dashorst Date: 2013-09-25T10:18:10Z Start next development version commit dd336fe22c9b0cfea6bad54261cce0c4fb112a77 Author: Martijn Dashorst Date: 2013-09-25T10:18:45Z Merge remote-tracking branch 'origin/wicket-6.x' into wicket-6.x commit a13dec062fffbe1b9fe933b0f546e6f50e1d7fed Author: Leonid Bogdanov Date: 2013-09-26T09:12:31Z Upgrade Atmosphere to 2.0.0 commit 28cac7193fe84790dc890937404f739c19927eda Author: svenmeier Date: 2013-09-26T09:54:16Z WICKET-5374 don't let XhtmlRenderer use a StringBufferInputStream, as it fails on non-ASCII characters commit 4a92041ebfd770f1b2450707d71d39363e3ceb4d Author: svenmeier Date: 2013-09-26T11:06:13Z retain existing CSS classes commit eaed6ee5ebc479fa87b67cc0489e2c3350541a55 Author: Emond Papegaaij Date: 2013-09-26T13:02:05Z Merge branch 'wicket-6.x' of https://github.com/vonZeppelin/wicket into wicket-6.x commit 7db55f5a828560d8733c4db34eeaa06f11982741 Author: Martin Tzvetanov Grigorov Date: 2013-09-26T14:49:06Z WICKET-5375 Improve ConcatBundleResource error handling when a resource is missing commit 2ae366b2eb90d53f1a6e06c3c09ba0d509bfe9d7 Author: Martin Tzvetanov Grigorov Date: 2013-09-26T15:12:46Z WICKET-5369 Can't set a cookie using CookieUtils during an ajax request due to java.lang.ClassCastException: org.apache.wicket.ajax.AbstractAjaxResponse$AjaxResponse cannot be cast to org.apache.wicket.request.http.WebResponse commit 4b55c3fdbb5e7c5391c9864e2857649c61b74ead Author: Martin Tzvetanov Grigorov Date: 2013-09-27T07:11:45Z Mark an unused method as deprecated commit 9ed34b990b2f2d7c2bf09251dd
[jira] [Assigned] (WICKET-5518) FormComponent.updateCollectionModel does not handle unmodifiableList
[
https://issues.apache.org/jira/browse/WICKET-5518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sven Meier reassigned WICKET-5518:
--
Assignee: Sven Meier
> FormComponent.updateCollectionModel does not handle unmodifiableList
> -
>
> Key: WICKET-5518
> URL: https://issues.apache.org/jira/browse/WICKET-5518
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 6.12.0
>Reporter: Petr Lancaric
>Assignee: Sven Meier
>Priority: Minor
>
> FormComponent.updateCollectionModel should handle situation, when getter
> returns unmodifiable list.
> Proposed solution:
> formComponent.modelChanging();
> booelan isChanged;
> try {
> collection.clear();
> if (convertedInput != null)
> {
> collection.addAll(convertedInput);
> }
> isChanged = true;
> catch (Exception e)
> {
> // ignore this exception as Unmodifiable list
> does not allow change
> logger.info("An error occurred while trying to
> modify list attached to " + formComponent, e);
> }
> try
> {
> if(isChanged)
>
> formComponent.getModel().setObject(collection);
> else
> // TODO: create here collection as
> non-abstract successor of setObject declared argument
> formComponent.getModel().setObject(new
> ArrayList(convertedInput));
> isChanged = true;
> }
> catch (Exception e)
> {
> // ignore this exception because it could be
> that there
> // is not setter for this collection.
> logger.info("An error occurred while trying to
> set the new value for the property attached to " + formComponent, e);
> }
> // at least one update method should pass successfully
>
> if(isChanged)
> formComponent.modelChanged();
> else
> throw new RuntimeException("An error occurred
> while trying to modify value for the property attached to " + formComponent);
>
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Comment Edited] (WICKET-5518) FormComponent.updateCollectionModel does not handle unmodifiableList
[
https://issues.apache.org/jira/browse/WICKET-5518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911555#comment-13911555
]
Petr Lancaric edited comment on WICKET-5518 at 2/25/14 1:34 PM:
With guava the result is the same:
Caused by: java.lang.UnsupportedOperationException
at
com.google.common.collect.ImmutableCollection.clear(ImmutableCollection.java:142)
at
org.apache.wicket.markup.html.form.FormComponent.updateCollectionModel(FormComponent.java:1593)
at
org.apache.wicket.markup.html.form.ListMultipleChoice.updateModel(ListMultipleChoice.java:371)
Colelction.clear and Collection.addAll are declared as optional methods and it
is correct if they throw UnsupportedOperationException. Such situation should
be handled.
http://docs.oracle.com/javase/7/docs/api/java/util/Collection.html#clear%28%29
was (Author: petr.lanca...@lmc.eu):
With guava the result is the same:
Caused by: java.lang.UnsupportedOperationException
at
com.google.common.collect.ImmutableCollection.clear(ImmutableCollection.java:142)
at
org.apache.wicket.markup.html.form.FormComponent.updateCollectionModel(FormComponent.java:1593)
at
org.apache.wicket.markup.html.form.ListMultipleChoice.updateModel(ListMultipleChoice.java:371)
> FormComponent.updateCollectionModel does not handle unmodifiableList
> -
>
> Key: WICKET-5518
> URL: https://issues.apache.org/jira/browse/WICKET-5518
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 6.12.0
>Reporter: Petr Lancaric
>Priority: Minor
>
> FormComponent.updateCollectionModel should handle situation, when getter
> returns unmodifiable list.
> Proposed solution:
> formComponent.modelChanging();
> booelan isChanged;
> try {
> collection.clear();
> if (convertedInput != null)
> {
> collection.addAll(convertedInput);
> }
> isChanged = true;
> catch (Exception e)
> {
> // ignore this exception as Unmodifiable list
> does not allow change
> logger.info("An error occurred while trying to
> modify list attached to " + formComponent, e);
> }
> try
> {
> if(isChanged)
>
> formComponent.getModel().setObject(collection);
> else
> // TODO: create here collection as
> non-abstract successor of setObject declared argument
> formComponent.getModel().setObject(new
> ArrayList(convertedInput));
> isChanged = true;
> }
> catch (Exception e)
> {
> // ignore this exception because it could be
> that there
> // is not setter for this collection.
> logger.info("An error occurred while trying to
> set the new value for the property attached to " + formComponent, e);
> }
> // at least one update method should pass successfully
>
> if(isChanged)
> formComponent.modelChanged();
> else
> throw new RuntimeException("An error occurred
> while trying to modify value for the property attached to " + formComponent);
>
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (WICKET-5518) FormComponent.updateCollectionModel does not handle unmodifiableList
[
https://issues.apache.org/jira/browse/WICKET-5518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911555#comment-13911555
]
Petr Lancaric commented on WICKET-5518:
---
With guava the result is the same:
Caused by: java.lang.UnsupportedOperationException
at
com.google.common.collect.ImmutableCollection.clear(ImmutableCollection.java:142)
at
org.apache.wicket.markup.html.form.FormComponent.updateCollectionModel(FormComponent.java:1593)
at
org.apache.wicket.markup.html.form.ListMultipleChoice.updateModel(ListMultipleChoice.java:371)
> FormComponent.updateCollectionModel does not handle unmodifiableList
> -
>
> Key: WICKET-5518
> URL: https://issues.apache.org/jira/browse/WICKET-5518
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 6.12.0
>Reporter: Petr Lancaric
>Priority: Minor
>
> FormComponent.updateCollectionModel should handle situation, when getter
> returns unmodifiable list.
> Proposed solution:
> formComponent.modelChanging();
> booelan isChanged;
> try {
> collection.clear();
> if (convertedInput != null)
> {
> collection.addAll(convertedInput);
> }
> isChanged = true;
> catch (Exception e)
> {
> // ignore this exception as Unmodifiable list
> does not allow change
> logger.info("An error occurred while trying to
> modify list attached to " + formComponent, e);
> }
> try
> {
> if(isChanged)
>
> formComponent.getModel().setObject(collection);
> else
> // TODO: create here collection as
> non-abstract successor of setObject declared argument
> formComponent.getModel().setObject(new
> ArrayList(convertedInput));
> isChanged = true;
> }
> catch (Exception e)
> {
> // ignore this exception because it could be
> that there
> // is not setter for this collection.
> logger.info("An error occurred while trying to
> set the new value for the property attached to " + formComponent, e);
> }
> // at least one update method should pass successfully
>
> if(isChanged)
> formComponent.modelChanged();
> else
> throw new RuntimeException("An error occurred
> while trying to modify value for the property attached to " + formComponent);
>
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (WICKET-5518) FormComponent.updateCollectionModel does not handle unmodifiableList
[
https://issues.apache.org/jira/browse/WICKET-5518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911543#comment-13911543
]
Martin Grigorov commented on WICKET-5518:
-
Immutable collections makes sense to be used when:
1) the collection is designed to be immutable
2) in multithreaded context
1) is very important because immutable collections have additional logic to
reuse the same memory when an item is added/removed to/from it.
I.e. the old collection will share most of its items with the new collection.
With your code your are adding more pressure to the Garbage Collector, nothing
more, because Java collections are not designed to be used as immutable. Wicket
protects you from multithreaded issues if the collection is not with session
scope.
But in the case when you use real immutable collections (like Guava's ones)
then the suggested change makes more sense.
The logger level should be DEBUG IMO.
> FormComponent.updateCollectionModel does not handle unmodifiableList
> -
>
> Key: WICKET-5518
> URL: https://issues.apache.org/jira/browse/WICKET-5518
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 6.12.0
>Reporter: Petr Lancaric
>Priority: Minor
>
> FormComponent.updateCollectionModel should handle situation, when getter
> returns unmodifiable list.
> Proposed solution:
> formComponent.modelChanging();
> booelan isChanged;
> try {
> collection.clear();
> if (convertedInput != null)
> {
> collection.addAll(convertedInput);
> }
> isChanged = true;
> catch (Exception e)
> {
> // ignore this exception as Unmodifiable list
> does not allow change
> logger.info("An error occurred while trying to
> modify list attached to " + formComponent, e);
> }
> try
> {
> if(isChanged)
>
> formComponent.getModel().setObject(collection);
> else
> // TODO: create here collection as
> non-abstract successor of setObject declared argument
> formComponent.getModel().setObject(new
> ArrayList(convertedInput));
> isChanged = true;
> }
> catch (Exception e)
> {
> // ignore this exception because it could be
> that there
> // is not setter for this collection.
> logger.info("An error occurred while trying to
> set the new value for the property attached to " + formComponent, e);
> }
> // at least one update method should pass successfully
>
> if(isChanged)
> formComponent.modelChanged();
> else
> throw new RuntimeException("An error occurred
> while trying to modify value for the property attached to " + formComponent);
>
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (WICKET-5518) FormComponent.updateCollectionModel does not handle unmodifiableList
[
https://issues.apache.org/jira/browse/WICKET-5518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911534#comment-13911534
]
Petr Lancaric commented on WICKET-5518:
---
There is a discussion on pros and cons of immutable objects, so I considered as
good practice to use immutable object:
http://programmers.stackexchange.com/questions/151733/if-immutable-objects-are-good-why-do-people-keep-creating-mutable-objects
My initial motivation was that I want to track changes on my value object,
therefore getter returns copy of list and changes could be detected in setter.
I am able to achieve this goal using mutable copy as shown bellow.
I understand task is not so easy as we have to find suitable collection type
and create instance via reflection, which is accepted by setObject call as an
argument.
My code of vaue object used in property model:
public List getBusinessFieldList() {
// fails:
return Collections.unmodifiableList(this.businessFieldList);
// works:
//return Lists.newArrayList(this.businessFieldList);
}
public void setBusinessFieldList(List value) {
trackChange("businessField", this.businessFieldList, value);
this.businessFieldList = value;
}
> FormComponent.updateCollectionModel does not handle unmodifiableList
> -
>
> Key: WICKET-5518
> URL: https://issues.apache.org/jira/browse/WICKET-5518
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 6.12.0
>Reporter: Petr Lancaric
>Priority: Minor
>
> FormComponent.updateCollectionModel should handle situation, when getter
> returns unmodifiable list.
> Proposed solution:
> formComponent.modelChanging();
> booelan isChanged;
> try {
> collection.clear();
> if (convertedInput != null)
> {
> collection.addAll(convertedInput);
> }
> isChanged = true;
> catch (Exception e)
> {
> // ignore this exception as Unmodifiable list
> does not allow change
> logger.info("An error occurred while trying to
> modify list attached to " + formComponent, e);
> }
> try
> {
> if(isChanged)
>
> formComponent.getModel().setObject(collection);
> else
> // TODO: create here collection as
> non-abstract successor of setObject declared argument
> formComponent.getModel().setObject(new
> ArrayList(convertedInput));
> isChanged = true;
> }
> catch (Exception e)
> {
> // ignore this exception because it could be
> that there
> // is not setter for this collection.
> logger.info("An error occurred while trying to
> set the new value for the property attached to " + formComponent, e);
> }
> // at least one update method should pass successfully
>
> if(isChanged)
> formComponent.modelChanged();
> else
> throw new RuntimeException("An error occurred
> while trying to modify value for the property attached to " + formComponent);
>
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (WICKET-5518) FormComponent.updateCollectionModel does not handle unmodifiableList
[
https://issues.apache.org/jira/browse/WICKET-5518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911533#comment-13911533
]
Sven Meier commented on WICKET-5518:
A getter might return an unmodifiable collection, expecting the setter to be
called with a new collection. Makes sense to me.
> FormComponent.updateCollectionModel does not handle unmodifiableList
> -
>
> Key: WICKET-5518
> URL: https://issues.apache.org/jira/browse/WICKET-5518
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 6.12.0
>Reporter: Petr Lancaric
>Priority: Minor
>
> FormComponent.updateCollectionModel should handle situation, when getter
> returns unmodifiable list.
> Proposed solution:
> formComponent.modelChanging();
> booelan isChanged;
> try {
> collection.clear();
> if (convertedInput != null)
> {
> collection.addAll(convertedInput);
> }
> isChanged = true;
> catch (Exception e)
> {
> // ignore this exception as Unmodifiable list
> does not allow change
> logger.info("An error occurred while trying to
> modify list attached to " + formComponent, e);
> }
> try
> {
> if(isChanged)
>
> formComponent.getModel().setObject(collection);
> else
> // TODO: create here collection as
> non-abstract successor of setObject declared argument
> formComponent.getModel().setObject(new
> ArrayList(convertedInput));
> isChanged = true;
> }
> catch (Exception e)
> {
> // ignore this exception because it could be
> that there
> // is not setter for this collection.
> logger.info("An error occurred while trying to
> set the new value for the property attached to " + formComponent, e);
> }
> // at least one update method should pass successfully
>
> if(isChanged)
> formComponent.modelChanged();
> else
> throw new RuntimeException("An error occurred
> while trying to modify value for the property attached to " + formComponent);
>
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
git commit: WICKET-3335 Fix the javadoc of MarkupContainer#dequeue()
Repository: wicket Updated Branches: refs/heads/master 2e327ccee -> 8088d460a WICKET-3335 Fix the javadoc of MarkupContainer#dequeue() Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/8088d460 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/8088d460 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/8088d460 Branch: refs/heads/master Commit: 8088d460a2c1422e3342bdf317be90dbdc606a26 Parents: 2e327cc Author: Martin Tzvetanov Grigorov Authored: Tue Feb 25 14:45:52 2014 +0200 Committer: Martin Tzvetanov Grigorov Committed: Tue Feb 25 14:45:52 2014 +0200 -- wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/wicket/blob/8088d460/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java -- diff --git a/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java b/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java index 616654f..914112a 100644 --- a/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java +++ b/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java @@ -2052,7 +2052,7 @@ public abstract class MarkupContainer extends Component implements Iterable
git commit: Return IGNORE when no tag.
Repository: wicket
Updated Branches:
refs/heads/master 56fe3592e -> 2e327ccee
Return IGNORE when no tag.
Fixes most of the broken tests
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/2e327cce
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/2e327cce
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/2e327cce
Branch: refs/heads/master
Commit: 2e327ccee16eb721372930f86fbd4f92bc57b8c3
Parents: 56fe359
Author: Martin Tzvetanov Grigorov
Authored: Tue Feb 25 14:37:30 2014 +0200
Committer: Martin Tzvetanov Grigorov
Committed: Tue Feb 25 14:37:30 2014 +0200
--
wicket-core/src/main/java/org/apache/wicket/DequeueContext.java | 2 --
1 file changed, 2 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/2e327cce/wicket-core/src/main/java/org/apache/wicket/DequeueContext.java
--
diff --git a/wicket-core/src/main/java/org/apache/wicket/DequeueContext.java
b/wicket-core/src/main/java/org/apache/wicket/DequeueContext.java
index eec4e24..11327bf 100644
--- a/wicket-core/src/main/java/org/apache/wicket/DequeueContext.java
+++ b/wicket-core/src/main/java/org/apache/wicket/DequeueContext.java
@@ -220,8 +220,6 @@ public final class DequeueContext
private DequeueTagAction canDequeueTag(ComponentTag open)
{
- Args.notNull(open, "open");
-
if (containers.size() < 1)
{
// TODO queueing message: called too early
[jira] [Updated] (WICKET-5518) FormComponent.updateCollectionModel does not handle unmodifiableList
[
https://issues.apache.org/jira/browse/WICKET-5518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Petr Lancaric updated WICKET-5518:
--
Description:
FormComponent.updateCollectionModel should handle situation, when getter
returns unmodifiable list.
Proposed solution:
formComponent.modelChanging();
booelan isChanged;
try {
collection.clear();
if (convertedInput != null)
{
collection.addAll(convertedInput);
}
isChanged = true;
catch (Exception e)
{
// ignore this exception as Unmodifiable list
does not allow change
logger.info("An error occurred while trying to
modify list attached to " + formComponent, e);
}
try
{
if(isChanged)
formComponent.getModel().setObject(collection);
else
// TODO: create here collection as
non-abstract successor of setObject declared argument
formComponent.getModel().setObject(new
ArrayList(convertedInput));
isChanged = true;
}
catch (Exception e)
{
// ignore this exception because it could be
that there
// is not setter for this collection.
logger.info("An error occurred while trying to
set the new value for the property attached to " + formComponent, e);
}
// at least one update method should pass successfully
if(isChanged)
formComponent.modelChanged();
else
throw new RuntimeException("An error occurred
while trying to modify value for the property attached to " + formComponent);
was:
FormComponent.updateCollectionModel should handle situation, when getter
returns unmodifiable list.
Proposed solution:
formComponent.modelChanging();
booelan isChanged;
try {
collection.clear();
if (convertedInput != null)
{
collection.addAll(convertedInput);
}
isChanged = true;
catch (Exception e)
{
// ignore this exception as Unmodifiable list
does not allow change
logger.info("An error occurred while trying to
modify list attached to " + formComponent, e);
}
try
{
formComponent.getModel().setObject(collection);
isChanged = true;
}
catch (Exception e)
{
// ignore this exception because it could be
that there
// is not setter for this collection.
logger.info("An error occurred while trying to
set the new value for the property attached to " + formComponent, e);
}
// at least one update method should pass successfully
if(isChanged)
formComponent.modelChanged();
else
throw new RuntimeException("An error occurred
while trying to modify value for the property attached to " + formComponent)
> FormComponent.updateCollectionModel does not handle unmodifiableList
> -
>
> Key: WICKET-5518
> URL: https://issues.apache.org/jira/browse/WICKET-5518
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 6.12.0
>Reporter: Petr Lancaric
>Priority: Minor
>
> FormComponent.updateCollectionModel should handle situation, when getter
> returns unmodifiable list.
> Proposed solution:
> formComponent.modelChanging();
>
[jira] [Commented] (WICKET-5518) FormComponent.updateCollectionModel does not handle unmodifiableList
[
https://issues.apache.org/jira/browse/WICKET-5518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911513#comment-13911513
]
Martin Grigorov commented on WICKET-5518:
-
What is the use case ?
Why you want to use unmodifiable model (list) ?
> FormComponent.updateCollectionModel does not handle unmodifiableList
> -
>
> Key: WICKET-5518
> URL: https://issues.apache.org/jira/browse/WICKET-5518
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 6.12.0
>Reporter: Petr Lancaric
>Priority: Minor
>
> FormComponent.updateCollectionModel should handle situation, when getter
> returns unmodifiable list.
> Proposed solution:
> formComponent.modelChanging();
> booelan isChanged;
> try {
> collection.clear();
> if (convertedInput != null)
> {
> collection.addAll(convertedInput);
> }
> isChanged = true;
> catch (Exception e)
> {
> // ignore this exception as Unmodifiable list
> does not allow change
> logger.info("An error occurred while trying to
> modify list attached to " + formComponent, e);
> }
> try
> {
> formComponent.getModel().setObject(collection);
> isChanged = true;
> }
> catch (Exception e)
> {
> // ignore this exception because it could be
> that there
> // is not setter for this collection.
> logger.info("An error occurred while trying to
> set the new value for the property attached to " + formComponent, e);
> }
> // at least one update method should pass successfully
>
> if(isChanged)
> formComponent.modelChanged();
> else
> throw new RuntimeException("An error occurred
> while trying to modify value for the property attached to " + formComponent)
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (WICKET-5517) IE11 returns false for Wicket.Browser.isIE()
[ https://issues.apache.org/jira/browse/WICKET-5517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911512#comment-13911512 ] Martin Grigorov commented on WICKET-5517: - [~papegaaij] I hope you will find time to fix any problems caused by this change in the later versions of Wicket ! I see no reason why to fix something when there is no real problem with it. I'd rather deprecate these methods. > IE11 returns false for Wicket.Browser.isIE() > > > Key: WICKET-5517 > URL: https://issues.apache.org/jira/browse/WICKET-5517 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 6.14.0 > Environment: Internet Explorer 11, tested on Windows 7 and 8. >Reporter: Luke Niesink >Assignee: Emond Papegaaij >Priority: Minor > > As of Internet Explorer 11 this statement returns false instead of true (like > it did prior to version 11): > typeof(document.all) !== "undefined" > This statement is used on line 56 of wicket-event-jquery.js which means > Wicket.Browser.isIE() will return false in IE11. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (WICKET-5517) IE11 returns false for Wicket.Browser.isIE()
[ https://issues.apache.org/jira/browse/WICKET-5517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Grigorov updated WICKET-5517: Assignee: Emond Papegaaij > IE11 returns false for Wicket.Browser.isIE() > > > Key: WICKET-5517 > URL: https://issues.apache.org/jira/browse/WICKET-5517 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 6.14.0 > Environment: Internet Explorer 11, tested on Windows 7 and 8. >Reporter: Luke Niesink >Assignee: Emond Papegaaij >Priority: Minor > > As of Internet Explorer 11 this statement returns false instead of true (like > it did prior to version 11): > typeof(document.all) !== "undefined" > This statement is used on line 56 of wicket-event-jquery.js which means > Wicket.Browser.isIE() will return false in IE11. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Reopened] (WICKET-5517) IE11 returns false for Wicket.Browser.isIE()
[ https://issues.apache.org/jira/browse/WICKET-5517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emond Papegaaij reopened WICKET-5517: - I do not agree with you here. A function called 'isIE()' should return true if the browser is IE, no matter what version. In this case, the distinction needed because of different handling of events on selects, which is still the case in IE11. If isIE() is used in Wicket code for work arounds which are no longer required on IE11, those places should be fixed. A quick grep on isIE() shows only a handful of places outside modal.js. > IE11 returns false for Wicket.Browser.isIE() > > > Key: WICKET-5517 > URL: https://issues.apache.org/jira/browse/WICKET-5517 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 6.14.0 > Environment: Internet Explorer 11, tested on Windows 7 and 8. >Reporter: Luke Niesink >Priority: Minor > > As of Internet Explorer 11 this statement returns false instead of true (like > it did prior to version 11): > typeof(document.all) !== "undefined" > This statement is used on line 56 of wicket-event-jquery.js which means > Wicket.Browser.isIE() will return false in IE11. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (WICKET-5518) FormComponent.updateCollectionModel does not handle unmodifiableList
[
https://issues.apache.org/jira/browse/WICKET-5518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sven Meier updated WICKET-5518:
---
Description:
FormComponent.updateCollectionModel should handle situation, when getter
returns unmodifiable list.
Proposed solution:
formComponent.modelChanging();
booelan isChanged;
try {
collection.clear();
if (convertedInput != null)
{
collection.addAll(convertedInput);
}
isChanged = true;
catch (Exception e)
{
// ignore this exception as Unmodifiable list
does not allow change
logger.info("An error occurred while trying to
modify list attached to " + formComponent, e);
}
try
{
formComponent.getModel().setObject(collection);
isChanged = true;
}
catch (Exception e)
{
// ignore this exception because it could be
that there
// is not setter for this collection.
logger.info("An error occurred while trying to
set the new value for the property attached to " + formComponent, e);
}
// at least one update method should pass successfully
if(isChanged)
formComponent.modelChanged();
else
throw new RuntimeException("An error occurred
while trying to modify value for the property attached to " + formComponent)
was:
FormComponent.updateCollectionModel should handle situation, when getter
returns unmodifiable list.
Proposed solution:
formComponent.modelChanging();
booelan isChanged;
try {
collection.clear();
if (convertedInput != null)
{
collection.addAll(convertedInput);
}
isChanged = true;
catch (Exception e)
{
// ignore this exception as Unmodifiable list
does not allow change
logger.info("An error occurred while trying to
modify list attached to " + formComponent, e);
}
try
{
formComponent.getModel().setObject(collection);
isChanged = true;
}
catch (Exception e)
{
// ignore this exception because it could be
that there
// is not setter for this collection.
logger.info("An error occurred while trying to
set the new value for the property attached to " + formComponent, e);
}
// at least one update method should pass successfully
if(isChanged)
formComponent.modelChanged();
else
throw new RuntimeException("An error occurred
while trying to modify value for the property attached to " + formComponent)
> FormComponent.updateCollectionModel does not handle unmodifiableList
> -
>
> Key: WICKET-5518
> URL: https://issues.apache.org/jira/browse/WICKET-5518
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 6.12.0
>Reporter: Petr Lancaric
>Priority: Minor
>
> FormComponent.updateCollectionModel should handle situation, when getter
> returns unmodifiable list.
> Proposed solution:
> formComponent.modelChanging();
> booelan isChanged;
> try {
> collection.clear();
> if (convertedInput != null)
> {
> collection.addAll(convertedInput);
> }
> isChanged = true;
> catch (Exception e)
>
[2/2] git commit: Add Apache Licence header
Add Apache Licence header
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/56fe3592
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/56fe3592
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/56fe3592
Branch: refs/heads/master
Commit: 56fe3592ede1e06a2636bcaa4f97ca138400eeb2
Parents: 8640ad2
Author: Martin Tzvetanov Grigorov
Authored: Tue Feb 25 14:08:15 2014 +0200
Committer: Martin Tzvetanov Grigorov
Committed: Tue Feb 25 14:08:15 2014 +0200
--
.../java/org/apache/wicket/DequeueTagAction.java | 16
.../markup/html/panel/DequeueMarkupFragment.java | 17 +
2 files changed, 33 insertions(+)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/56fe3592/wicket-core/src/main/java/org/apache/wicket/DequeueTagAction.java
--
diff --git a/wicket-core/src/main/java/org/apache/wicket/DequeueTagAction.java
b/wicket-core/src/main/java/org/apache/wicket/DequeueTagAction.java
index 5981cb1..461cac4 100644
--- a/wicket-core/src/main/java/org/apache/wicket/DequeueTagAction.java
+++ b/wicket-core/src/main/java/org/apache/wicket/DequeueTagAction.java
@@ -1,3 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
package org.apache.wicket;
public enum DequeueTagAction
http://git-wip-us.apache.org/repos/asf/wicket/blob/56fe3592/wicket-core/src/main/java/org/apache/wicket/markup/html/panel/DequeueMarkupFragment.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/markup/html/panel/DequeueMarkupFragment.java
b/wicket-core/src/main/java/org/apache/wicket/markup/html/panel/DequeueMarkupFragment.java
index 5e0a874..2239989 100644
---
a/wicket-core/src/main/java/org/apache/wicket/markup/html/panel/DequeueMarkupFragment.java
+++
b/wicket-core/src/main/java/org/apache/wicket/markup/html/panel/DequeueMarkupFragment.java
@@ -1,5 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
package org.apache.wicket.markup.html.panel;
+//TODO queueing Do we need this class ? It is not used at he moment
public class DequeueMarkupFragment
{
[1/2] git commit: Print the processes markup when an error with opening/closing tag is detected for easier debugging.
Repository: wicket
Updated Branches:
refs/heads/master 67134a089 -> 56fe3592e
Print the processes markup when an error with opening/closing tag is detected
for easier debugging.
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/8640ad2b
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/8640ad2b
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/8640ad2b
Branch: refs/heads/master
Commit: 8640ad2b8580dd51266a8f9f8e16d88ac3d72b73
Parents: 67134a0
Author: Martin Tzvetanov Grigorov
Authored: Tue Feb 25 14:07:28 2014 +0200
Committer: Martin Tzvetanov Grigorov
Committed: Tue Feb 25 14:07:28 2014 +0200
--
.../src/main/java/org/apache/wicket/DequeueContext.java | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/8640ad2b/wicket-core/src/main/java/org/apache/wicket/DequeueContext.java
--
diff --git a/wicket-core/src/main/java/org/apache/wicket/DequeueContext.java
b/wicket-core/src/main/java/org/apache/wicket/DequeueContext.java
index 2717e8c..eec4e24 100644
--- a/wicket-core/src/main/java/org/apache/wicket/DequeueContext.java
+++ b/wicket-core/src/main/java/org/apache/wicket/DequeueContext.java
@@ -175,7 +175,7 @@ public final class DequeueContext
for (; index <
markup.size(); index++)
{
if
((markup.get(index) instanceof ComponentTag)
- &&
((ComponentTag)markup.get(index)).closes(tag))
+ &&
markup.get(index).closes(tag))
{
found =
true;
break;
@@ -184,7 +184,8 @@ public final class DequeueContext
if (!found)
{
throw new
IllegalStateException(
- "Could
not find close tag for tag: " + tag);
+
String.format("Could not find close tag for tag '%s' in markup: %s ",
+
tag, markup));
}
}
@@ -208,7 +209,8 @@ public final class DequeueContext
continue;
case SKIP :
throw new
IllegalStateException(
- "Should not see
closed tag of skipped open tag: " + tag);
+
String.format("Should not see closed tag of skipped open tag '%s' in markup:%s",
+
tag, markup));
}
}
}
@@ -220,13 +222,13 @@ public final class DequeueContext
{
Args.notNull(open, "open");
- DequeueTagAction action = null;
-
if (containers.size() < 1)
{
// TODO queueing message: called too early
throw new IllegalStateException();
}
+
+ DequeueTagAction action;
for (int i = containers.size() - 1; i >= 0; i--)
{
action = containers.get(i).canDequeueTag((open));
[jira] [Created] (WICKET-5518) FormComponent.updateCollectionModel does not handle unmodifiableList
Petr Lancaric created WICKET-5518:
-
Summary: FormComponent.updateCollectionModel does not handle
unmodifiableList
Key: WICKET-5518
URL: https://issues.apache.org/jira/browse/WICKET-5518
Project: Wicket
Issue Type: Bug
Affects Versions: 6.12.0
Reporter: Petr Lancaric
Priority: Minor
FormComponent.updateCollectionModel should handle situation, when getter
returns unmodifiable list.
Proposed solution:
formComponent.modelChanging();
booelan isChanged;
try {
collection.clear();
if (convertedInput != null)
{
collection.addAll(convertedInput);
}
isChanged = true;
catch (Exception e)
{
// ignore this exception as Unmodifiable list
does not allow change
logger.info("An error occurred while trying to
modify list attached to " + formComponent, e);
}
try
{
formComponent.getModel().setObject(collection);
isChanged = true;
}
catch (Exception e)
{
// ignore this exception because it could be
that there
// is not setter for this collection.
logger.info("An error occurred while trying to
set the new value for the property attached to " + formComponent, e);
}
// at least one update method should pass successfully
if(isChanged)
formComponent.modelChanged();
else
throw new RuntimeException("An error occurred
while trying to modify value for the property attached to " + formComponent)
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Resolved] (WICKET-5517) IE11 returns false for Wicket.Browser.isIE()
[ https://issues.apache.org/jira/browse/WICKET-5517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Grigorov resolved WICKET-5517. - Resolution: Won't Fix Closing as "Won't fix" until there is a real issue with this helper method. I've added #isIE11() helper method in case it is needed by the application. > IE11 returns false for Wicket.Browser.isIE() > > > Key: WICKET-5517 > URL: https://issues.apache.org/jira/browse/WICKET-5517 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 6.14.0 > Environment: Internet Explorer 11, tested on Windows 7 and 8. >Reporter: Luke Niesink >Priority: Minor > > As of Internet Explorer 11 this statement returns false instead of true (like > it did prior to version 11): > typeof(document.all) !== "undefined" > This statement is used on line 56 of wicket-event-jquery.js which means > Wicket.Browser.isIE() will return false in IE11. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
git commit: WICKET-5517 IE11 returns false for Wicket.Browser.isIE()
Repository: wicket
Updated Branches:
refs/heads/wicket-6.x 225369c9d -> dfd12188a
WICKET-5517 IE11 returns false for Wicket.Browser.isIE()
Add a simple check whether the current user agent is IE 11.
It is not used by Wicket for now
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/dfd12188
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/dfd12188
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/dfd12188
Branch: refs/heads/wicket-6.x
Commit: dfd12188a0da8cdc37aecbd29fc83fddfcb51c4d
Parents: 225369c
Author: Martin Tzvetanov Grigorov
Authored: Tue Feb 25 13:46:58 2014 +0200
Committer: Martin Tzvetanov Grigorov
Committed: Tue Feb 25 13:46:58 2014 +0200
--
.../java/org/apache/wicket/ajax/res/js/wicket-event-jquery.js | 7 +++
1 file changed, 7 insertions(+)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/dfd12188/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-event-jquery.js
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-event-jquery.js
b/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-event-jquery.js
index 116fa03..76c8091 100644
---
a/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-event-jquery.js
+++
b/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-event-jquery.js
@@ -79,6 +79,13 @@
return Wicket.Browser.isIE() && version < 9;
},
+ isIE11: function () {
+ var userAgent = window.navigator.userAgent;
+ var isTrident = userAgent.indexOf("Trident");
+ var is11 = userAgent.indexOf("rv:11");
+ return isTrident && is11;
+ },
+
isGecko: function () {
return
(/Gecko/).test(window.navigator.userAgent) && !Wicket.Browser.isSafari();
}
git commit: WICKET-5517 IE11 returns false for Wicket.Browser.isIE()
Repository: wicket
Updated Branches:
refs/heads/master 023f94d11 -> 67134a089
WICKET-5517 IE11 returns false for Wicket.Browser.isIE()
Add a simple check whether the current user agent is IE 11.
It is not used by Wicket for now
(cherry picked from commit dfd12188a0da8cdc37aecbd29fc83fddfcb51c4d)
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/67134a08
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/67134a08
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/67134a08
Branch: refs/heads/master
Commit: 67134a089685e755968f12934b656dc3b3ea7e0f
Parents: 023f94d
Author: Martin Tzvetanov Grigorov
Authored: Tue Feb 25 13:46:58 2014 +0200
Committer: Martin Tzvetanov Grigorov
Committed: Tue Feb 25 13:49:22 2014 +0200
--
.../java/org/apache/wicket/ajax/res/js/wicket-event-jquery.js | 7 +++
1 file changed, 7 insertions(+)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/67134a08/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-event-jquery.js
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-event-jquery.js
b/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-event-jquery.js
index 8ac06f2..b914fdb 100644
---
a/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-event-jquery.js
+++
b/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-event-jquery.js
@@ -79,6 +79,13 @@
return Wicket.Browser.isIE() && version < 9;
},
+ isIE11: function () {
+ var userAgent = window.navigator.userAgent;
+ var isTrident = userAgent.indexOf("Trident");
+ var is11 = userAgent.indexOf("rv:11");
+ return isTrident && is11;
+ },
+
isGecko: function () {
return
(/Gecko/).test(window.navigator.userAgent) && !Wicket.Browser.isSafari();
}
[jira] [Commented] (WICKET-5517) IE11 returns false for Wicket.Browser.isIE()
[ https://issues.apache.org/jira/browse/WICKET-5517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911494#comment-13911494 ] Martin Grigorov commented on WICKET-5517: - Thank you! We are aware of this but we prefer to not fix it until there is a real issue with this check somewhere. IE11 is more close to W3C standards and most of the checks in Wicket code for ".isIE()" don't apply for 11. > IE11 returns false for Wicket.Browser.isIE() > > > Key: WICKET-5517 > URL: https://issues.apache.org/jira/browse/WICKET-5517 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 6.14.0 > Environment: Internet Explorer 11, tested on Windows 7 and 8. >Reporter: Luke Niesink >Priority: Minor > > As of Internet Explorer 11 this statement returns false instead of true (like > it did prior to version 11): > typeof(document.all) !== "undefined" > This statement is used on line 56 of wicket-event-jquery.js which means > Wicket.Browser.isIE() will return false in IE11. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (WICKET-5517) IE11 returns false for Wicket.Browser.isIE()
Luke Niesink created WICKET-5517: Summary: IE11 returns false for Wicket.Browser.isIE() Key: WICKET-5517 URL: https://issues.apache.org/jira/browse/WICKET-5517 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.14.0 Environment: Internet Explorer 11, tested on Windows 7 and 8. Reporter: Luke Niesink Priority: Minor As of Internet Explorer 11 this statement returns false instead of true (like it did prior to version 11): typeof(document.all) !== "undefined" This statement is used on line 56 of wicket-event-jquery.js which means Wicket.Browser.isIE() will return false in IE11. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Resolved] (WICKET-5516) RadioChoice / add a getAdditionalAttributes() also for -tag
[ https://issues.apache.org/jira/browse/WICKET-5516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Grigorov resolved WICKET-5516. - Resolution: Fixed Fix Version/s: 6.15.0 7.0.0 > RadioChoice / add a getAdditionalAttributes() also for -tag > -- > > Key: WICKET-5516 > URL: https://issues.apache.org/jira/browse/WICKET-5516 > Project: Wicket > Issue Type: Wish > Components: wicket >Reporter: Patrick Davids >Assignee: Martin Grigorov > Fix For: 7.0.0, 6.15.0 > > > Hi Dev-Team, > for styling issues it would be very usefull to have method > getAdditionalAttributesForLabel() in a RadioChoice > to add additional attributes e.g. "style", "class" or "title" to the label > element, not only to the input element. > kind regards > Patrick -- This message was sent by Atlassian JIRA (v6.1.5#6160)
git commit: WICKET-5516 RadioChoice / add a getAdditionalAttributes() also for -tag
Repository: wicket
Updated Branches:
refs/heads/master 2008dfb70 -> 023f94d11
WICKET-5516 RadioChoice / add a getAdditionalAttributes() also for -tag
(cherry picked from commit 225369c9d2bdfc9d48b07dad2766288159d0707e)
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/023f94d1
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/023f94d1
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/023f94d1
Branch: refs/heads/master
Commit: 023f94d11cd7147aa43cedcc480d27cf3d9398e9
Parents: 2008dfb
Author: Martin Tzvetanov Grigorov
Authored: Tue Feb 25 12:58:24 2014 +0200
Committer: Martin Tzvetanov Grigorov
Committed: Tue Feb 25 12:58:45 2014 +0200
--
.../wicket/markup/html/form/RadioChoice.java| 37 +++-
1 file changed, 36 insertions(+), 1 deletion(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/023f94d1/wicket-core/src/main/java/org/apache/wicket/markup/html/form/RadioChoice.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/RadioChoice.java
b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/RadioChoice.java
index be74378..d953338 100644
---
a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/RadioChoice.java
+++
b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/RadioChoice.java
@@ -521,7 +521,26 @@ public class RadioChoice extends
AbstractSingleSelectChoice implements IOn
buffer.append("")
+ .append('"');
+
+ // Allows user to add attributes to the tag
+ {
+ IValueMap labelAttrs =
getAdditionalAttributesForLabel(index, choice);
+ if (labelAttrs != null)
+ {
+ for (Map.Entry attr :
labelAttrs.entrySet())
+ {
+ buffer.append(' ')
+
.append(attr.getKey())
+ .append("=\"")
+
.append(attr.getValue())
+ .append('"');
+ }
+ }
+ }
+
+ buffer
+ .append('>')
.append(escaped)
.append("");
@@ -531,10 +550,26 @@ public class RadioChoice extends
AbstractSingleSelectChoice implements IOn
}
/**
+* You may subclass this method to provide additional attributes to the
git commit: WICKET-5516 RadioChoice / add a getAdditionalAttributes() also for -tag
Repository: wicket
Updated Branches:
refs/heads/wicket-6.x 08fa98293 -> 225369c9d
WICKET-5516 RadioChoice / add a getAdditionalAttributes() also for -tag
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/225369c9
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/225369c9
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/225369c9
Branch: refs/heads/wicket-6.x
Commit: 225369c9d2bdfc9d48b07dad2766288159d0707e
Parents: 08fa982
Author: Martin Tzvetanov Grigorov
Authored: Tue Feb 25 12:58:24 2014 +0200
Committer: Martin Tzvetanov Grigorov
Committed: Tue Feb 25 12:58:24 2014 +0200
--
.../wicket/markup/html/form/RadioChoice.java| 37 +++-
1 file changed, 36 insertions(+), 1 deletion(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/225369c9/wicket-core/src/main/java/org/apache/wicket/markup/html/form/RadioChoice.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/RadioChoice.java
b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/RadioChoice.java
index e684186..73720a2 100644
---
a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/RadioChoice.java
+++
b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/RadioChoice.java
@@ -521,7 +521,26 @@ public class RadioChoice extends
AbstractSingleSelectChoice implements IOn
buffer.append("")
+ .append('"');
+
+ // Allows user to add attributes to the tag
+ {
+ IValueMap labelAttrs =
getAdditionalAttributesForLabel(index, choice);
+ if (labelAttrs != null)
+ {
+ for (Map.Entry attr :
labelAttrs.entrySet())
+ {
+ buffer.append(' ')
+
.append(attr.getKey())
+ .append("=\"")
+
.append(attr.getValue())
+ .append('"');
+ }
+ }
+ }
+
+ buffer
+ .append('>')
.append(escaped)
.append("");
@@ -531,10 +550,26 @@ public class RadioChoice extends
AbstractSingleSelectChoice implements IOn
}
/**
+* You may subclass this method to provide additional attributes to the
[jira] [Assigned] (WICKET-5516) RadioChoice / add a getAdditionalAttributes() also for -tag
[ https://issues.apache.org/jira/browse/WICKET-5516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Grigorov reassigned WICKET-5516: --- Assignee: Martin Grigorov > RadioChoice / add a getAdditionalAttributes() also for -tag > -- > > Key: WICKET-5516 > URL: https://issues.apache.org/jira/browse/WICKET-5516 > Project: Wicket > Issue Type: Wish > Components: wicket >Reporter: Patrick Davids >Assignee: Martin Grigorov > > Hi Dev-Team, > for styling issues it would be very usefull to have method > getAdditionalAttributesForLabel() in a RadioChoice > to add additional attributes e.g. "style", "class" or "title" to the label > element, not only to the input element. > kind regards > Patrick -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (WICKET-5516) RadioChoice / add a getAdditionalAttributes() also for -tag
Patrick Davids created WICKET-5516: -- Summary: RadioChoice / add a getAdditionalAttributes() also for -tag Key: WICKET-5516 URL: https://issues.apache.org/jira/browse/WICKET-5516 Project: Wicket Issue Type: Wish Components: wicket Reporter: Patrick Davids Hi Dev-Team, for styling issues it would be very usefull to have method getAdditionalAttributesForLabel() in a RadioChoice to add additional attributes e.g. "style", "class" or "title" to the label element, not only to the input element. kind regards Patrick -- This message was sent by Atlassian JIRA (v6.1.5#6160)
