[jira] [Closed] (WICKET-5573) FilterToolbar generics broken

2014-05-16 Thread Andrea Del Bene (JIRA) 

 [ 
https://issues.apache.org/jira/browse/WICKET-5573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Del Bene closed WICKET-5573.
---

   Resolution: Fixed
Fix Version/s: 7.0.0-M2
   6.16.0

Fix ported to 6.x

 FilterToolbar generics broken
 -

 Key: WICKET-5573
 URL: https://issues.apache.org/jira/browse/WICKET-5573
 Project: Wicket
  Issue Type: Bug
  Components: wicket-extensions
Affects Versions: 6.15.0
Reporter: Leszek Gawron
Assignee: Andrea Del Bene
 Fix For: 6.16.0, 7.0.0-M2


 Once you were able to create DataTableUser wrapped inside of
 FilterFormUserFilterDto
 currently FilterToolbar requires you for those two types to be identical:
 {code}
 public T, S FilterToolbar(final DataTableT, S table, final
 FilterFormT form,
 final IFilterStateLocatorT stateLocator)
 {code}
 It looks like commit 9b3f9ca1df064fe9c6fde64ccc37fecc504b09a6
 introduced a bug long time ago and it carried on:
 {code}
 -   public T FilterToolbar(final DataTable? table, final
 FilterFormT form,
 +   public T FilterToolbar(final DataTableT table, final
 FilterFormT form,
 {code}
 FilterToolbar constructor should state:
 {code}
 public T, F, S FilterToolbar(final DataTableT, S table, final
 FilterFormF form,
 final IFilterStateLocatorF stateLocator)
 {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (WICKET-5593) AjaxFormValidatingBehavior attempts to update non-visible feedback panels

2014-05-16 Thread Alexander Keul (JIRA) 

 [ 
https://issues.apache.org/jira/browse/WICKET-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Keul updated WICKET-5593:
---

Attachment: foo.rar

Attaching a simple page demonstrating how it would fail. Feedback panel is a 
child of a WebMarkupContainer with setVisible(false);

 AjaxFormValidatingBehavior attempts to update non-visible feedback panels
 -

 Key: WICKET-5593
 URL: https://issues.apache.org/jira/browse/WICKET-5593
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 6.14.0
Reporter: Alexander Keul
Priority: Minor
 Attachments: foo.rar


 AjaxFormValidatingBehavior#addFeedbackPanels adds all feedback panels on the 
 page to the AjaxRequestTarget, without any check for visibility in the 
 hierarchy or lack of output MarkupId.
 As the behaviour is so broad it should probably have an added check:
 if ( component.isVisibleInHierarchy()) {
   target.add(component);
 } else {
   visit.dontGoDeeper();
 }



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Created] (WICKET-5594) AjaxButton prevent override of #onSumit() #onError()

2014-05-16 Thread Sven Meier (JIRA) 
Sven Meier created WICKET-5594:
--

 Summary: AjaxButton prevent override of #onSumit() #onError()
 Key: WICKET-5594
 URL: https://issues.apache.org/jira/browse/WICKET-5594
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Affects Versions: 7.0.0-M1
Reporter: Sven Meier
Assignee: Sven Meier
Priority: Trivial


When a developer overrides AjaxButton's #onSubmit() and #onError() (note no ART 
argument), these hooks will never be called.

Modifying these as final will prevent this possible programming error.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Created] (WICKET-5592) Add a method to clear the cache of CachingResourceStreamLocator

2014-05-16 Thread Fridolin Jackstadt (JIRA) 
Fridolin Jackstadt created WICKET-5592:
--

 Summary: Add a method to clear the cache of 
CachingResourceStreamLocator
 Key: WICKET-5592
 URL: https://issues.apache.org/jira/browse/WICKET-5592
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 6.15.0
Reporter: Fridolin Jackstadt
Priority: Minor


See WICKET-5590



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[9/9] git commit: WICKET-5587 Upgrade JQuery to latest releases - 1.11.1 2.1.1

2014-05-16 Thread mgrigorov 
WICKET-5587 Upgrade JQuery to latest releases - 1.11.1  2.1.1


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/f5daf77f
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/f5daf77f
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/f5daf77f

Branch: refs/heads/wicket-6.x
Commit: f5daf77f57ae801f673c6bf444bdfc71d999e048
Parents: 1d057ac
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Fri May 9 09:46:30 2014 +0300
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Fri May 9 09:46:30 2014 +0300

--
 .../DynamicJQueryResourceReference.java | 2 +-
 .../resource/JQueryResourceReference.java   | 2 +-
 .../wicket/resource/jquery/jquery-1.11.0.js | 10337 -
 .../wicket/resource/jquery/jquery-1.11.0.min.js | 4 -
 .../wicket/resource/jquery/jquery-1.11.1.js | 10308 
 .../wicket/resource/jquery/jquery-1.11.1.min.js | 4 +
 .../wicket/resource/jquery/jquery-2.1.0.js  |  9111 ---
 .../wicket/resource/jquery/jquery-2.1.0.min.js  | 4 -
 .../wicket/resource/jquery/jquery-2.1.1.js  |  9190 +++
 .../wicket/resource/jquery/jquery-2.1.1.min.js  | 4 +
 wicket-core/src/test/js/all.html| 2 +-
 wicket-core/src/test/js/amd.html| 2 +-
 12 files changed, 19510 insertions(+), 19460 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/f5daf77f/wicket-core/src/main/java/org/apache/wicket/resource/DynamicJQueryResourceReference.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/resource/DynamicJQueryResourceReference.java
 
b/wicket-core/src/main/java/org/apache/wicket/resource/DynamicJQueryResourceReference.java
index cd26399..ccc953f 100644
--- 
a/wicket-core/src/main/java/org/apache/wicket/resource/DynamicJQueryResourceReference.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/resource/DynamicJQueryResourceReference.java
@@ -50,7 +50,7 @@ public class DynamicJQueryResourceReference extends 
JQueryResourceReference
/**
 * jQuery ver. 2.x - works only on modern browsers
 */
-   public static final String VERSION_2 = jquery/jquery-2.1.0.js;
+   public static final String VERSION_2 = jquery/jquery-2.1.1.js;
 
public DynamicJQueryResourceReference()
{

http://git-wip-us.apache.org/repos/asf/wicket/blob/f5daf77f/wicket-core/src/main/java/org/apache/wicket/resource/JQueryResourceReference.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/resource/JQueryResourceReference.java
 
b/wicket-core/src/main/java/org/apache/wicket/resource/JQueryResourceReference.java
index 3c8af58..46f369c 100644
--- 
a/wicket-core/src/main/java/org/apache/wicket/resource/JQueryResourceReference.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/resource/JQueryResourceReference.java
@@ -34,7 +34,7 @@ public class JQueryResourceReference extends 
JavaScriptResourceReference
/**
 * jQuery ver. 1.x - works on modern browsers and IE 6/7/8
 */
-   public static final String VERSION_1 = jquery/jquery-1.11.0.js;
+   public static final String VERSION_1 = jquery/jquery-1.11.1.js;
 
private static final JQueryResourceReference INSTANCE = new 
JQueryResourceReference();

[jira] [Created] (WICKET-5590) Add a method to clear the cache of CachingResourceVersion

2014-05-16 Thread Fridolin Jackstadt (JIRA) 
Fridolin Jackstadt created WICKET-5590:
--

 Summary: Add a method to clear the cache of CachingResourceVersion
 Key: WICKET-5590
 URL: https://issues.apache.org/jira/browse/WICKET-5590
 Project: Wicket
  Issue Type: New Feature
  Components: wicket
Affects Versions: 6.15.0
Reporter: Fridolin Jackstadt
Priority: Minor


Since our Application supports to change resouces content at runtime of wicket 
application, we need a mechanism to invalidate the resource version cache. The 
implementation is easy and very useful for us, and we will make a pull request 
for that.

We would be very happy to find it in one of the next releases.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (WICKET-5590) Add a method to clear the cache of CachingResourceVersion

2014-05-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/WICKET-5590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998576#comment-13998576
 ] 

ASF GitHub Bot commented on WICKET-5590:


GitHub user frido37 opened a pull request:

https://github.com/apache/wicket/pull/73

WICKET-5590 Add a method to clear the cache of CachingResourceVersion



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/frido37/wicket master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/wicket/pull/73.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #73


commit 1274ea5673fe5aa02ac54f40e3635050a8d67e31
Author: Fridolin Jackstadt fridolin.jackst...@lindenbaum.eu
Date:   2014-05-15T08:22:54Z

WICKET-5590 Add a method to clear the cache of CachingResourceVersion




 Add a method to clear the cache of CachingResourceVersion
 -

 Key: WICKET-5590
 URL: https://issues.apache.org/jira/browse/WICKET-5590
 Project: Wicket
  Issue Type: New Feature
  Components: wicket
Affects Versions: 6.15.0
Reporter: Fridolin Jackstadt
Priority: Minor

 Since our Application supports to change resouces content at runtime of 
 wicket application, we need a mechanism to invalidate the resource version 
 cache. The implementation is easy and very useful for us, and we will make a 
 pull request for that.
 We would be very happy to find it in one of the next releases.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Created] (WICKET-5591) Missing translation for HoursValidator.range (in DateTimeField)

2014-05-16 Thread JIRA 
Frédéric Donckels created WICKET-5591:
-

 Summary: Missing translation for HoursValidator.range (in 
DateTimeField)
 Key: WICKET-5591
 URL: https://issues.apache.org/jira/browse/WICKET-5591
 Project: Wicket
  Issue Type: Bug
  Components: wicket-datetime
Affects Versions: 6.15.0
Reporter: Frédéric Donckels
Priority: Minor


The HoursValidator in DateTimeField extends RangeValidator. Therefore when 
validation fails, the key used is HoursValidator.range. There is no default 
translation for it (and the translation mechanism doesn't look at the 
inheritance chain for validators).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

git commit: [WICKET-5573] Changed FilterToolbar to accept three different generic types, and added an example for such component.

2014-05-16 Thread adelbene 
Repository: wicket
Updated Branches:
  refs/heads/wicket-6.x cab182a45 - 466ce9020


[WICKET-5573] Changed FilterToolbar to accept three different generic
types, and added an example for such component.


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/466ce902
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/466ce902
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/466ce902

Branch: refs/heads/wicket-6.x
Commit: 466ce902039d9097a5b08c5831dd04a780f7047b
Parents: cab182a
Author: bitstorm an.delb...@gmail.com
Authored: Tue May 13 19:51:22 2014 +0200
Committer: bitstorm an.delb...@gmail.com
Committed: Wed May 14 16:50:41 2014 +0200

--
 .../wicket/examples/repeater/Contact.java   | 24 -
 .../wicket/examples/repeater/ContactFilter.java | 43 +
 .../examples/repeater/ContactGenerator.java | 20 +
 .../examples/repeater/ContactsDatabase.java |  2 +-
 .../repeater/DataTableFilterToolbarPage.html| 29 ++
 .../repeater/DataTableFilterToolbarPage.java| 95 
 .../wicket/examples/repeater/DataTablePage.html |  2 +-
 .../wicket/examples/repeater/DataTablePage.java |  4 +
 .../apache/wicket/examples/repeater/Index.html  |  1 +
 .../repeater/SortableContactDataProvider.java   | 55 +++-
 .../data/table/filter/FilterToolbar.java| 13 +--
 11 files changed, 272 insertions(+), 16 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/466ce902/wicket-examples/src/main/java/org/apache/wicket/examples/repeater/Contact.java
--
diff --git 
a/wicket-examples/src/main/java/org/apache/wicket/examples/repeater/Contact.java
 
b/wicket-examples/src/main/java/org/apache/wicket/examples/repeater/Contact.java
index 7751654..0a53924 100644
--- 
a/wicket-examples/src/main/java/org/apache/wicket/examples/repeater/Contact.java
+++ 
b/wicket-examples/src/main/java/org/apache/wicket/examples/repeater/Contact.java
@@ -16,6 +16,8 @@
  */
 package org.apache.wicket.examples.repeater;
 
+import java.util.Date;
+
 import org.apache.wicket.util.io.IClusterable;
 
 /**
@@ -35,7 +37,9 @@ public class Contact implements IClusterable
private String homePhone;
 
private String cellPhone;
-
+   
+   private Date bornDate;
+   
/**
 * Constructor
 */
@@ -176,4 +180,22 @@ public class Contact implements IClusterable
this.lastName = lastName;
}
 
+   /**
+* 
+* @return bornDate
+*/
+   public Date getBornDate()
+   {
+   return bornDate;
+   }
+
+   /**
+* 
+* @param bornDate
+*/
+   public void setBornDate(Date bornDate)
+   {
+   this.bornDate = bornDate;
+   }
+
 }

http://git-wip-us.apache.org/repos/asf/wicket/blob/466ce902/wicket-examples/src/main/java/org/apache/wicket/examples/repeater/ContactFilter.java
--
diff --git 
a/wicket-examples/src/main/java/org/apache/wicket/examples/repeater/ContactFilter.java
 
b/wicket-examples/src/main/java/org/apache/wicket/examples/repeater/ContactFilter.java
new file mode 100644
index 000..532321f
--- /dev/null
+++ 
b/wicket-examples/src/main/java/org/apache/wicket/examples/repeater/ContactFilter.java
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the License); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.wicket.examples.repeater;
+
+import java.io.Serializable;
+import java.util.Date;
+
+public class ContactFilter implements Serializable
+{
+private Date dateFrom;
+private Date dateTo;
+
+public Date getDateFrom()
+{
+return dateFrom;
+}
+public void setDateFrom(Date dateFrom)
+{
+this.dateFrom = dateFrom;
+}
+public Date getDateTo()
+{
+return dateTo;
+}
+public void setDateTo(Date dateTo)
+{
+this.dateTo = dateTo;
+}
+}

[jira] [Created] (WICKET-5593) AjaxFormValidatingBehavior attempts to update non-visible feedback panels

2014-05-16 Thread Alexander Keul (JIRA) 
Alexander Keul created WICKET-5593:
--

 Summary: AjaxFormValidatingBehavior attempts to update non-visible 
feedback panels
 Key: WICKET-5593
 URL: https://issues.apache.org/jira/browse/WICKET-5593
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 6.14.0
Reporter: Alexander Keul
Priority: Minor
 Attachments: foo.rar

AjaxFormValidatingBehavior#addFeedbackPanels adds all feedback panels on the 
page to the AjaxRequestTarget, without any check for visibility in the 
hierarchy or lack of output MarkupId.

As the behaviour is so broad it should probably have an added check:
if ( component.isVisibleInHierarchy()) {
  target.add(component);
} else {
  visit.dontGoDeeper();
}



--
This message was sent by Atlassian JIRA
(v6.2#6252)