[jira] [Created] (WICKET-5595) update infinity transport long polling
Duto created WICKET-5595:
Summary: update infinity transport long polling
Key: WICKET-5595
URL: https://issues.apache.org/jira/browse/WICKET-5595
Project: Wicket
Issue Type: Bug
Components: wicket-atmosphere
Affects Versions: 6.16.0
Reporter: Duto
Assignee: Emond Papegaaij
I found a problem when I use long polling for the transport :
When the EventBus loop to the list of AtmosphereResource (on post method) and
if the update is too long of each AtmosphereResource, the list of
AtmosphereResource is update and reorder (because atmosphere remove and
registry the AtmosphereResource due to long polling) and then the loop on
EventBus never stop and update is infinitie.
To solve the probleme I do that on line 366 of EventBus.java :
{code}for (AtmosphereResource resource :
ImmutableList.copyOf(broadcaster.getAtmosphereResources())){code}
rather than
{code}for (AtmosphereResource resource :
broadcaster.getAtmosphereResources()){code}
Best regards
--
This message was sent by Atlassian JIRA
(v6.2#6252)
git commit: WICKET-5595: copy list of resources, because it is modified inside the loop
Repository: wicket
Updated Branches:
refs/heads/wicket-6.x c6f92f173 - d3fb459a0
WICKET-5595: copy list of resources, because it is modified inside the loop
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/d3fb459a
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/d3fb459a
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/d3fb459a
Branch: refs/heads/wicket-6.x
Commit: d3fb459a0409efd526f93f9d43db8958c57ef163
Parents: c6f92f1
Author: Emond Papegaaij emond.papega...@topicus.nl
Authored: Mon May 19 09:43:21 2014 +0200
Committer: Emond Papegaaij emond.papega...@topicus.nl
Committed: Mon May 19 09:44:01 2014 +0200
--
.../src/main/java/org/apache/wicket/atmosphere/EventBus.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/d3fb459a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java
--
diff --git
a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java
b/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java
index d13965e..7790f83 100644
---
a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java
+++
b/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java
@@ -50,6 +50,7 @@ import org.slf4j.LoggerFactory;
import com.google.common.collect.Collections2;
import com.google.common.collect.HashMultimap;
+import com.google.common.collect.ImmutableList;
import com.google.common.collect.Maps;
import com.google.common.collect.Multimap;
@@ -363,7 +364,7 @@ public class EventBus implements UnboundListener
ThreadContext oldContext = ThreadContext.get(false);
try
{
- for (AtmosphereResource resource :
broadcaster.getAtmosphereResources())
+ for (AtmosphereResource resource :
ImmutableList.copyOf(broadcaster.getAtmosphereResources()))
{
postToSingleResource(event, resource);
}
git commit: WICKET-5595: copy list of resources, because it is modified inside the loop
Repository: wicket
Updated Branches:
refs/heads/master 8951bd5c6 - 8e6b4fc72
WICKET-5595: copy list of resources, because it is modified inside the loop
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/8e6b4fc7
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/8e6b4fc7
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/8e6b4fc7
Branch: refs/heads/master
Commit: 8e6b4fc725290ecd50b06565c1c6227b45f33ba6
Parents: 8951bd5
Author: Emond Papegaaij emond.papega...@topicus.nl
Authored: Mon May 19 09:43:21 2014 +0200
Committer: Emond Papegaaij emond.papega...@topicus.nl
Committed: Mon May 19 09:45:10 2014 +0200
--
.../src/main/java/org/apache/wicket/atmosphere/EventBus.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/8e6b4fc7/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java
--
diff --git
a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java
b/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java
index 0ea88cf..ed88336 100644
---
a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java
+++
b/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java
@@ -50,6 +50,7 @@ import org.slf4j.LoggerFactory;
import com.google.common.collect.Collections2;
import com.google.common.collect.HashMultimap;
+import com.google.common.collect.ImmutableList;
import com.google.common.collect.Maps;
import com.google.common.collect.Multimap;
@@ -363,7 +364,7 @@ public class EventBus implements UnboundListener
ThreadContext oldContext = ThreadContext.get(false);
try
{
- for (AtmosphereResource resource :
broadcaster.getAtmosphereResources())
+ for (AtmosphereResource resource :
ImmutableList.copyOf(broadcaster.getAtmosphereResources()))
{
postToSingleResource(event, resource);
}
[jira] [Resolved] (WICKET-5595) update infinity transport long polling
[
https://issues.apache.org/jira/browse/WICKET-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emond Papegaaij resolved WICKET-5595.
-
Resolution: Fixed
Fix Version/s: 7.0.0-M2
6.16.0
I've applied your changes. Thanks!
update infinity transport long polling
--
Key: WICKET-5595
URL: https://issues.apache.org/jira/browse/WICKET-5595
Project: Wicket
Issue Type: Bug
Components: wicket-atmosphere
Affects Versions: 6.16.0
Reporter: Duto
Assignee: Emond Papegaaij
Labels: atmosphere, long_polling, loop
Fix For: 6.16.0, 7.0.0-M2
I found a problem when I use long polling for the transport :
When the EventBus loop to the list of AtmosphereResource (on post method) and
if the update is too long of each AtmosphereResource, the list of
AtmosphereResource is update and reorder (because atmosphere remove and
registry the AtmosphereResource due to long polling) and then the loop on
EventBus never stop and update is infinitie.
To solve the probleme I do that on line 366 of EventBus.java :
{code}for (AtmosphereResource resource :
ImmutableList.copyOf(broadcaster.getAtmosphereResources())){code}
rather than
{code}for (AtmosphereResource resource :
broadcaster.getAtmosphereResources()){code}
Best regards
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (WICKET-5594) AjaxButton prevent override of #onSubmit() #onError()
[ https://issues.apache.org/jira/browse/WICKET-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Grigorov updated WICKET-5594: Summary: AjaxButton prevent override of #onSubmit() #onError() (was: AjaxButton prevent override of #onSumit() #onError()) AjaxButton prevent override of #onSubmit() #onError() - Key: WICKET-5594 URL: https://issues.apache.org/jira/browse/WICKET-5594 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 7.0.0-M1 Reporter: Sven Meier Assignee: Sven Meier Priority: Trivial When a developer overrides AjaxButton's #onSubmit() and #onError() (note no ART argument), these hooks will never be called. Modifying these as final will prevent this possible programming error. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (WICKET-5594) AjaxButton prevent override of #onSubmit() #onError()
[ https://issues.apache.org/jira/browse/WICKET-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14001732#comment-14001732 ] Martin Grigorov commented on WICKET-5594: - +1 AjaxButton prevent override of #onSubmit() #onError() - Key: WICKET-5594 URL: https://issues.apache.org/jira/browse/WICKET-5594 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 7.0.0-M1 Reporter: Sven Meier Assignee: Sven Meier Priority: Trivial When a developer overrides AjaxButton's #onSubmit() and #onError() (note no ART argument), these hooks will never be called. Modifying these as final will prevent this possible programming error. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (WICKET-5590) Add a method to clear the cache of CachingResourceVersion
[ https://issues.apache.org/jira/browse/WICKET-5590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14001739#comment-14001739 ] ASF GitHub Bot commented on WICKET-5590: Github user martin-g commented on a diff in the pull request: https://github.com/apache/wicket/pull/73#discussion_r12797692 --- Diff: wicket-core/src/main/java/org/apache/wicket/request/resource/caching/IResourceCachingStrategy.java --- @@ -71,4 +71,10 @@ * @param response */ void decorateResponse(AbstractResource.ResourceResponse response, IStaticCacheableResource resource); + + /** +* Clears any stateful information +*/ + void clearCache(); --- End diff -- This addition of a new method to a public interface makes this change applicable only to Wicket 7.x. I see the PR is actually against `master`. Add a method to clear the cache of CachingResourceVersion - Key: WICKET-5590 URL: https://issues.apache.org/jira/browse/WICKET-5590 Project: Wicket Issue Type: New Feature Components: wicket Affects Versions: 6.15.0 Reporter: Fridolin Jackstadt Priority: Minor Since our Application supports to change resouces content at runtime of wicket application, we need a mechanism to invalidate the resource version cache. The implementation is easy and very useful for us, and we will make a pull request for that. We would be very happy to find it in one of the next releases. -- This message was sent by Atlassian JIRA (v6.2#6252)
[1/4] git commit: WICKET-5590 Add a method to clear the cache of CachingResourceVersion
Repository: wicket
Updated Branches:
refs/heads/master 8e6b4fc72 - 9a79f67ea
WICKET-5590 Add a method to clear the cache of CachingResourceVersion
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/1274ea56
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/1274ea56
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/1274ea56
Branch: refs/heads/master
Commit: 1274ea5673fe5aa02ac54f40e3635050a8d67e31
Parents: f29fe6f
Author: Fridolin Jackstadt fridolin.jackst...@lindenbaum.eu
Authored: Thu May 15 10:22:54 2014 +0200
Committer: Fridolin Jackstadt fridolin.jackst...@lindenbaum.eu
Committed: Thu May 15 10:22:54 2014 +0200
--
.../FilenameWithVersionResourceCachingStrategy.java | 10 ++
.../resource/caching/IResourceCachingStrategy.java| 6 ++
.../resource/caching/NoOpResourceCachingStrategy.java | 6 ++
.../QueryStringWithVersionResourceCachingStrategy.java| 10 ++
.../resource/caching/version/CachingResourceVersion.java | 4
5 files changed, 36 insertions(+)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/1274ea56/wicket-core/src/main/java/org/apache/wicket/request/resource/caching/FilenameWithVersionResourceCachingStrategy.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/request/resource/caching/FilenameWithVersionResourceCachingStrategy.java
b/wicket-core/src/main/java/org/apache/wicket/request/resource/caching/FilenameWithVersionResourceCachingStrategy.java
index 0afd86c..e1b2594 100644
---
a/wicket-core/src/main/java/org/apache/wicket/request/resource/caching/FilenameWithVersionResourceCachingStrategy.java
+++
b/wicket-core/src/main/java/org/apache/wicket/request/resource/caching/FilenameWithVersionResourceCachingStrategy.java
@@ -21,6 +21,7 @@ import java.util.regex.Pattern;
import org.apache.wicket.request.cycle.RequestCycle;
import org.apache.wicket.request.http.WebResponse;
import org.apache.wicket.request.resource.AbstractResource;
+import
org.apache.wicket.request.resource.caching.version.CachingResourceVersion;
import org.apache.wicket.request.resource.caching.version.IResourceVersion;
import org.apache.wicket.util.lang.Args;
import org.slf4j.Logger;
@@ -214,4 +215,13 @@ public class FilenameWithVersionResourceCachingStrategy
implements IResourceCach
response.setCacheScope(WebResponse.CacheScope.PUBLIC);
}
}
+
+ @Override
+ public void clearCache()
+ {
+ if (resourceVersion instanceof CachingResourceVersion)
+ {
+ ((CachingResourceVersion)
resourceVersion).invalidateAll();
+ }
+ }
}
http://git-wip-us.apache.org/repos/asf/wicket/blob/1274ea56/wicket-core/src/main/java/org/apache/wicket/request/resource/caching/IResourceCachingStrategy.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/request/resource/caching/IResourceCachingStrategy.java
b/wicket-core/src/main/java/org/apache/wicket/request/resource/caching/IResourceCachingStrategy.java
index c62a61a..c8d5821 100644
---
a/wicket-core/src/main/java/org/apache/wicket/request/resource/caching/IResourceCachingStrategy.java
+++
b/wicket-core/src/main/java/org/apache/wicket/request/resource/caching/IResourceCachingStrategy.java
@@ -71,4 +71,10 @@ public interface IResourceCachingStrategy
* @param response
*/
void decorateResponse(AbstractResource.ResourceResponse response,
IStaticCacheableResource resource);
+
+ /**
+* Clears any stateful information
+*/
+ void clearCache();
+
}
http://git-wip-us.apache.org/repos/asf/wicket/blob/1274ea56/wicket-core/src/main/java/org/apache/wicket/request/resource/caching/NoOpResourceCachingStrategy.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/request/resource/caching/NoOpResourceCachingStrategy.java
b/wicket-core/src/main/java/org/apache/wicket/request/resource/caching/NoOpResourceCachingStrategy.java
index ce39947..c65f209 100644
---
a/wicket-core/src/main/java/org/apache/wicket/request/resource/caching/NoOpResourceCachingStrategy.java
+++
b/wicket-core/src/main/java/org/apache/wicket/request/resource/caching/NoOpResourceCachingStrategy.java
@@ -48,4 +48,10 @@ public class NoOpResourceCachingStrategy implements
IResourceCachingStrategy
public void decorateResponse(AbstractResource.ResourceResponse
response, IStaticCacheableResource resource)
{
}
+
+ @Override
+ public void clearCache()
+ {
+ }
+
}
[3/4] git commit: WICKET-5573 FilterToolbar generics broken
WICKET-5573 FilterToolbar generics broken
Improve the javadoc and error messages
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/dceb444c
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/dceb444c
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/dceb444c
Branch: refs/heads/master
Commit: dceb444c463e2d7b1d82f2de0174138d3044c3a6
Parents: 8e6b4fc
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Mon May 19 10:46:42 2014 +0300
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Mon May 19 10:52:50 2014 +0300
--
.../html/repeater/data/table/filter/FilterToolbar.java | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/dceb444c/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterToolbar.java
--
diff --git
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterToolbar.java
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterToolbar.java
index 62fe752..f7222c3 100644
---
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterToolbar.java
+++
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterToolbar.java
@@ -53,7 +53,11 @@ public class FilterToolbar extends AbstractToolbar
* @param form
*the filter form
* @param T
-*type of filter state object
+*the type of the DataTable's model object
+* @param S
+*the type of the DataTable's sorting parameter
+* @param F
+*the type of filter state object
*
*/
public T, S, F FilterToolbar(final DataTableT, S table, final
FilterFormF form)
@@ -149,7 +153,7 @@ public class FilterToolbar extends AbstractToolbar
{
if (findParent(FilterForm.class) == null)
{
- throw new IllegalStateException(FilterToolbar must be
contained within a Form);
+ throw new IllegalStateException(FilterToolbar must be
contained within a FilterForm);
}
super.onBeforeRender();
}
[4/4] git commit: Merge branch 'master' of https://github.com/frido37/wicket into pr-73-master
Merge branch 'master' of https://github.com/frido37/wicket into pr-73-master Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/9a79f67e Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/9a79f67e Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/9a79f67e Branch: refs/heads/master Commit: 9a79f67ea941585eef5b3f514e0ff4ddd12a9670 Parents: dceb444 234dc01 Author: Martin Tzvetanov Grigorov mgrigo...@apache.org Authored: Mon May 19 17:54:24 2014 +0300 Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org Committed: Mon May 19 17:54:24 2014 +0300 -- .../locator/caching/CachingResourceStreamLocator.java | 6 ++ .../FilenameWithVersionResourceCachingStrategy.java | 10 ++ .../resource/caching/IResourceCachingStrategy.java| 6 ++ .../resource/caching/NoOpResourceCachingStrategy.java | 6 ++ .../QueryStringWithVersionResourceCachingStrategy.java| 10 ++ .../resource/caching/version/CachingResourceVersion.java | 4 6 files changed, 42 insertions(+) --
[2/4] git commit: WICKET-5592 Add a method to clear the cache of CachingResourceStreamLocator
WICKET-5592 Add a method to clear the cache of CachingResourceStreamLocator
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/234dc01d
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/234dc01d
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/234dc01d
Branch: refs/heads/master
Commit: 234dc01def692a28365dd08bd6ffb16d0b646a3b
Parents: 1274ea5
Author: Fridolin Jackstadt fridolin.jackst...@lindenbaum.eu
Authored: Thu May 15 13:57:42 2014 +0200
Committer: Fridolin Jackstadt fridolin.jackst...@lindenbaum.eu
Committed: Thu May 15 13:57:42 2014 +0200
--
.../resource/locator/caching/CachingResourceStreamLocator.java | 6 ++
1 file changed, 6 insertions(+)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/234dc01d/wicket-core/src/main/java/org/apache/wicket/core/util/resource/locator/caching/CachingResourceStreamLocator.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/core/util/resource/locator/caching/CachingResourceStreamLocator.java
b/wicket-core/src/main/java/org/apache/wicket/core/util/resource/locator/caching/CachingResourceStreamLocator.java
index 49301e2..a3f7c4f 100644
---
a/wicket-core/src/main/java/org/apache/wicket/core/util/resource/locator/caching/CachingResourceStreamLocator.java
+++
b/wicket-core/src/main/java/org/apache/wicket/core/util/resource/locator/caching/CachingResourceStreamLocator.java
@@ -137,4 +137,10 @@ public class CachingResourceStreamLocator implements
IResourceStreamLocator
{
return delegate.newResourceNameIterator(path, locale, style,
variation, extension, strict);
}
+
+ public void clearCache()
+ {
+ cache.clear();
+ }
+
}
[2/2] git commit: WICKET-5592 Add a method to clear the cache of CachingResourceStreamLocator
WICKET-5592 Add a method to clear the cache of CachingResourceStreamLocator
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/cdc28993
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/cdc28993
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/cdc28993
Branch: refs/heads/wicket-6.x
Commit: cdc28993dce98812d3679a7fd8ffd0c941f6a0f6
Parents: ed612ac
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Mon May 19 18:00:51 2014 +0300
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Mon May 19 18:00:51 2014 +0300
--
.../resource/locator/caching/CachingResourceStreamLocator.java | 5 +
1 file changed, 5 insertions(+)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/cdc28993/wicket-core/src/main/java/org/apache/wicket/core/util/resource/locator/caching/CachingResourceStreamLocator.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/core/util/resource/locator/caching/CachingResourceStreamLocator.java
b/wicket-core/src/main/java/org/apache/wicket/core/util/resource/locator/caching/CachingResourceStreamLocator.java
index 48506d8..74fa3c0 100644
---
a/wicket-core/src/main/java/org/apache/wicket/core/util/resource/locator/caching/CachingResourceStreamLocator.java
+++
b/wicket-core/src/main/java/org/apache/wicket/core/util/resource/locator/caching/CachingResourceStreamLocator.java
@@ -137,4 +137,9 @@ public class CachingResourceStreamLocator implements
IResourceStreamLocator
{
return delegate.newResourceNameIterator(path, locale, style,
variation, extension, strict);
}
+
+ public void clearCache()
+ {
+ cache.clear();
+ }
}
[1/2] git commit: WICKET-5573 FilterToolbar generics broken
Repository: wicket
Updated Branches:
refs/heads/wicket-6.x d3fb459a0 - cdc28993d
WICKET-5573 FilterToolbar generics broken
Improve the javadoc and error messages
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/ed612acb
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/ed612acb
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/ed612acb
Branch: refs/heads/wicket-6.x
Commit: ed612acb03a5484e70389a6c8a04b3684023634e
Parents: d3fb459
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Mon May 19 10:51:57 2014 +0300
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Mon May 19 10:52:44 2014 +0300
--
.../examples/repeater/DataTableFilterToolbarPage.java | 2 +-
.../html/repeater/data/table/filter/FilterToolbar.java| 10 +++---
2 files changed, 8 insertions(+), 4 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/ed612acb/wicket-examples/src/main/java/org/apache/wicket/examples/repeater/DataTableFilterToolbarPage.java
--
diff --git
a/wicket-examples/src/main/java/org/apache/wicket/examples/repeater/DataTableFilterToolbarPage.java
b/wicket-examples/src/main/java/org/apache/wicket/examples/repeater/DataTableFilterToolbarPage.java
index 6edd6ba..edb9a68 100644
---
a/wicket-examples/src/main/java/org/apache/wicket/examples/repeater/DataTableFilterToolbarPage.java
+++
b/wicket-examples/src/main/java/org/apache/wicket/examples/repeater/DataTableFilterToolbarPage.java
@@ -85,7 +85,7 @@ public class DataTableFilterToolbarPage extends ExamplePage
add(filterForm);
- FilterToolbar filterToolbar = new
FilterToolbar(tableWithFilterForm, filterForm, dataProvider);
+ FilterToolbar filterToolbar = new
FilterToolbar(tableWithFilterForm, filterForm, null);
tableWithFilterForm.addTopToolbar(filterToolbar);
tableWithFilterForm.addTopToolbar(new
NavigationToolbar(tableWithFilterForm));
http://git-wip-us.apache.org/repos/asf/wicket/blob/ed612acb/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterToolbar.java
--
diff --git
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterToolbar.java
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterToolbar.java
index 713477f..1589d4d 100644
---
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterToolbar.java
+++
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/filter/FilterToolbar.java
@@ -53,9 +53,13 @@ public class FilterToolbar extends AbstractToolbar
* @param form
*the filter form
* @param stateLocator
-*locator responsible for finding object used to store
filter's state
+*locator responsible for finding object used to store
filter's state. Deprecated! Not used.
* @param T
-*type of filter state object
+*the type of the DataTable's model object
+* @param S
+*the type of the DataTable's sorting parameter
+* @param F
+*the type of the type of filter state object
*
*/
public T, S, F FilterToolbar(final DataTableT, S table, final
FilterFormF form, final IFilterStateLocatorF stateLocator)
@@ -151,7 +155,7 @@ public class FilterToolbar extends AbstractToolbar
{
if (findParent(FilterForm.class) == null)
{
- throw new IllegalStateException(FilterToolbar must be
contained within a Form);
+ throw new IllegalStateException(FilterToolbar must be
contained within a FilterForm);
}
super.onBeforeRender();
}
[jira] [Resolved] (WICKET-5592) Add a method to clear the cache of CachingResourceStreamLocator
[ https://issues.apache.org/jira/browse/WICKET-5592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Grigorov resolved WICKET-5592. - Resolution: Fixed Fix Version/s: 7.0.0-M2 6.16.0 Assignee: Martin Grigorov Add a method to clear the cache of CachingResourceStreamLocator --- Key: WICKET-5592 URL: https://issues.apache.org/jira/browse/WICKET-5592 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.15.0 Reporter: Fridolin Jackstadt Assignee: Martin Grigorov Priority: Minor Fix For: 6.16.0, 7.0.0-M2 See WICKET-5590 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (WICKET-5590) Add a method to clear the cache of CachingResourceVersion
[ https://issues.apache.org/jira/browse/WICKET-5590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14001746#comment-14001746 ] ASF GitHub Bot commented on WICKET-5590: Github user asfgit closed the pull request at: https://github.com/apache/wicket/pull/73 Add a method to clear the cache of CachingResourceVersion - Key: WICKET-5590 URL: https://issues.apache.org/jira/browse/WICKET-5590 Project: Wicket Issue Type: New Feature Components: wicket Affects Versions: 6.15.0 Reporter: Fridolin Jackstadt Assignee: Martin Grigorov Priority: Minor Fix For: 7.0.0-M2 Since our Application supports to change resouces content at runtime of wicket application, we need a mechanism to invalidate the resource version cache. The implementation is easy and very useful for us, and we will make a pull request for that. We would be very happy to find it in one of the next releases. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (WICKET-5590) Add a method to clear the cache of CachingResourceVersion
[ https://issues.apache.org/jira/browse/WICKET-5590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Grigorov resolved WICKET-5590. - Resolution: Fixed Fix Version/s: 7.0.0-M2 Assignee: Martin Grigorov The patch is applied to master branch only, i.e. Wicket 7, because it introduces a new method in an interface and this is an API break. Thanks! Add a method to clear the cache of CachingResourceVersion - Key: WICKET-5590 URL: https://issues.apache.org/jira/browse/WICKET-5590 Project: Wicket Issue Type: New Feature Components: wicket Affects Versions: 6.15.0 Reporter: Fridolin Jackstadt Assignee: Martin Grigorov Priority: Minor Fix For: 7.0.0-M2 Since our Application supports to change resouces content at runtime of wicket application, we need a mechanism to invalidate the resource version cache. The implementation is easy and very useful for us, and we will make a pull request for that. We would be very happy to find it in one of the next releases. -- This message was sent by Atlassian JIRA (v6.2#6252)
git commit: [WICKET-4904] Refactoring for behavior DisabledAttributeLinkBehavior
Repository: wicket
Updated Branches:
refs/heads/master 9a79f67ea - 5a3fd0d2a
[WICKET-4904] Refactoring for behavior DisabledAttributeLinkBehavior
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/5a3fd0d2
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/5a3fd0d2
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/5a3fd0d2
Branch: refs/heads/master
Commit: 5a3fd0d2a3e501e3f7363293eb938ce04d7c25fc
Parents: 9a79f67
Author: bitstorm an.delb...@gmail.com
Authored: Mon May 19 17:01:14 2014 +0200
Committer: bitstorm an.delb...@gmail.com
Committed: Mon May 19 17:02:20 2014 +0200
--
.../link/DisabledAttributeLinkBehavior.java | 49
.../markup/html/link/DisabledLinkBehavior.java | 2 +-
.../paging/DisabledLinkPagingBehavior.java | 45 --
.../paging/PagingNavigationIncrementLink.java | 3 +-
.../navigation/paging/PagingNavigationLink.java | 3 +-
5 files changed, 54 insertions(+), 48 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/5a3fd0d2/wicket-core/src/main/java/org/apache/wicket/markup/html/link/DisabledAttributeLinkBehavior.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/markup/html/link/DisabledAttributeLinkBehavior.java
b/wicket-core/src/main/java/org/apache/wicket/markup/html/link/DisabledAttributeLinkBehavior.java
new file mode 100644
index 000..c8ed992
--- /dev/null
+++
b/wicket-core/src/main/java/org/apache/wicket/markup/html/link/DisabledAttributeLinkBehavior.java
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the License); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.wicket.markup.html.link;
+
+import org.apache.wicket.Component;
+import org.apache.wicket.behavior.Behavior;
+import org.apache.wicket.markup.ComponentTag;
+
+/**
+ *
+ * A behavior to add attribute disabled to a Link component when it is
disabled.
+ *
+ */
+public class DisabledAttributeLinkBehavior extends Behavior
+{
+
+private static final long serialVersionUID = 1L;
+
+ @Override
+ public void onComponentTag(Component component, ComponentTag tag)
+ {
+ if (!component.isEnabledInHierarchy())
+ {
+ // if the tag is an anchor proper
+ String tagName = tag.getName();
+
+ if (tagName.equalsIgnoreCase(a) ||
tagName.equalsIgnoreCase(link) ||
+ tagName.equalsIgnoreCase(area))
+ {
+ tag.put(disabled, disabled);
+ }
+ }
+ }
+}
http://git-wip-us.apache.org/repos/asf/wicket/blob/5a3fd0d2/wicket-core/src/main/java/org/apache/wicket/markup/html/link/DisabledLinkBehavior.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/markup/html/link/DisabledLinkBehavior.java
b/wicket-core/src/main/java/org/apache/wicket/markup/html/link/DisabledLinkBehavior.java
index 66dffd9..a198b87 100644
---
a/wicket-core/src/main/java/org/apache/wicket/markup/html/link/DisabledLinkBehavior.java
+++
b/wicket-core/src/main/java/org/apache/wicket/markup/html/link/DisabledLinkBehavior.java
@@ -22,7 +22,7 @@ import org.apache.wicket.behavior.Behavior;
import org.apache.wicket.markup.ComponentTag;
/**
- * A behavior to change the representation fo disabled links.
+ * A behavior to change the representation for disabled links.
* p
* Markup tags {@code a}, {@code link} and {@code area} are replaced
with a {@code span}.
*/
http://git-wip-us.apache.org/repos/asf/wicket/blob/5a3fd0d2/wicket-core/src/main/java/org/apache/wicket/markup/html/navigation/paging/DisabledLinkPagingBehavior.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/markup/html/navigation/paging/DisabledLinkPagingBehavior.java
[jira] [Assigned] (WICKET-5577) Generation of wicket ids with prefix / suffix
[ https://issues.apache.org/jira/browse/WICKET-5577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Grigorov reassigned WICKET-5577: --- Assignee: Martin Grigorov Generation of wicket ids with prefix / suffix - Key: WICKET-5577 URL: https://issues.apache.org/jira/browse/WICKET-5577 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 6.13.0 Environment: - Reporter: Tobias Soloschenko Assignee: Martin Grigorov Priority: Minor As mentioned in the following post of the users mailing list: http://wicket-users.markmail.org/message/54lo4i4qwoqtmuqv?q=tobias+soloschenko It would be great to be able to change the way wicket ids are generated so that it is possible to define a custom prefix / suffix. Example: Without prefix div id=menuItem32.../div With prefix div id= ns_Z7_0G8AH001I8CJD0AKTUU2F21004__menuItem32.../div ns_Z7_0G8AH001I8CJD0AKTUU2F21004__ would be the prefix. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (WICKET-5594) AjaxButton #onSubmit() #onError() intricacies
[ https://issues.apache.org/jira/browse/WICKET-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sven Meier updated WICKET-5594: --- Description: Overriding AjaxButton's hook #onSubmit() is prone to possible programming errors: - with JavaScript enabled, #onSubmit() will not be called, leaving the developer without clue that the wrong method was overwritten - with JavaScript disabled, #onSubmit(ART, Form) will not be called - furthermore if the markup includes type=submit or no type attribute, #onSubmit() will be called instead. #onError() and #onError(ART, Form) have identical intricacies. To make things consistent I propose the following change for Wicket 7.x: - declare #onSubmit() and #onError() final on AjaxButton - in #onComponentTag() make sure the button-Tag has type=button, so the browser does not submit the form when JavaScript is disabled. For fallack support we have AjaxFallbackButton already. Any objections or better ideas? was: When a developer overrides AjaxButton's #onSubmit() and #onError() (note no ART argument), these hooks will never be called. Modifying these as final will prevent this possible programming error. Summary: AjaxButton #onSubmit() #onError() intricacies (was: AjaxButton prevent override of #onSubmit() #onError()) AjaxButton #onSubmit() #onError() intricacies - Key: WICKET-5594 URL: https://issues.apache.org/jira/browse/WICKET-5594 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 7.0.0-M1 Reporter: Sven Meier Assignee: Sven Meier Priority: Trivial Overriding AjaxButton's hook #onSubmit() is prone to possible programming errors: - with JavaScript enabled, #onSubmit() will not be called, leaving the developer without clue that the wrong method was overwritten - with JavaScript disabled, #onSubmit(ART, Form) will not be called - furthermore if the markup includes type=submit or no type attribute, #onSubmit() will be called instead. #onError() and #onError(ART, Form) have identical intricacies. To make things consistent I propose the following change for Wicket 7.x: - declare #onSubmit() and #onError() final on AjaxButton - in #onComponentTag() make sure the button-Tag has type=button, so the browser does not submit the form when JavaScript is disabled. For fallack support we have AjaxFallbackButton already. Any objections or better ideas? -- This message was sent by Atlassian JIRA (v6.2#6252)
git commit: WICKET-5577 Generation of wicket ids with prefix / suffix
Repository: wicket
Updated Branches:
refs/heads/master 5a3fd0d2a - ccff0802a
WICKET-5577 Generation of wicket ids with prefix / suffix
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/ccff0802
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/ccff0802
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/ccff0802
Branch: refs/heads/master
Commit: ccff0802a729bc10d84ed876ec08d408efc377af
Parents: 5a3fd0d
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Mon May 19 18:38:01 2014 +0300
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Mon May 19 18:38:37 2014 +0300
--
.../main/java/org/apache/wicket/Component.java | 53 +-
.../java/org/apache/wicket/ComponentQueue2.java | 104 ---
.../apache/wicket/DefaultMarkupIdGenerator.java | 80 ++
.../org/apache/wicket/IMarkupIdGenerator.java | 32 ++
.../apache/wicket/settings/MarkupSettings.java | 29 ++
.../apache/wicket/MarkupIdGeneratorTest.java| 73 +
6 files changed, 216 insertions(+), 155 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/ccff0802/wicket-core/src/main/java/org/apache/wicket/Component.java
--
diff --git a/wicket-core/src/main/java/org/apache/wicket/Component.java
b/wicket-core/src/main/java/org/apache/wicket/Component.java
index 0e91438..eed90a7 100644
--- a/wicket-core/src/main/java/org/apache/wicket/Component.java
+++ b/wicket-core/src/main/java/org/apache/wicket/Component.java
@@ -1498,57 +1498,8 @@ public abstract class Component
*/
public String getMarkupId(boolean createIfDoesNotExist)
{
- Object storedMarkupId = getMarkupIdImpl();
- if (storedMarkupId instanceof String)
- {
- return (String)storedMarkupId;
- }
-
- if (storedMarkupId == null createIfDoesNotExist == false)
- {
- return null;
- }
-
- int generatedMarkupId = storedMarkupId instanceof Integer ?
(Integer)storedMarkupId
- : getSession().nextSequenceValue();
-
- if (generatedMarkupId == 0xAD)
- {
- // WICKET-4559 skip suffix 'ad' because some
ad-blocking solutions may hide the
-// component
- generatedMarkupId = getSession().nextSequenceValue();
- }
-
- if (storedMarkupId == null)
- {
- setMarkupIdImpl(generatedMarkupId);
- }
-
- String markupIdPrefix = id;
- if (getApplication().usesDevelopmentConfig())
- {
- // in non-deployment mode we make the markup id include
component id
- // so it is easier to debug
- markupIdPrefix = getId();
- }
-
- String markupIdPostfix =
Integer.toHexString(generatedMarkupId).toLowerCase();
-
- String markupId = markupIdPrefix + markupIdPostfix;
-
- // make sure id is compliant with w3c requirements (starts with
a letter)
- char c = markupId.charAt(0);
- if (!Character.isLetter(c))
- {
- markupId = id + markupId;
- }
-
- // escape some noncompliant characters
- markupId = Strings.replaceAll(markupId, _, __).toString();
- markupId = markupId.replace('.', '_');
- markupId = markupId.replace('-', '_');
- markupId = markupId.replace(' ', '_');
-
+ IMarkupIdGenerator markupIdGenerator =
getApplication().getMarkupSettings().getMarkupIdGenerator();
+ String markupId = markupIdGenerator.generateMarkupId(this);
return markupId;
}
http://git-wip-us.apache.org/repos/asf/wicket/blob/ccff0802/wicket-core/src/main/java/org/apache/wicket/ComponentQueue2.java
--
diff --git a/wicket-core/src/main/java/org/apache/wicket/ComponentQueue2.java
b/wicket-core/src/main/java/org/apache/wicket/ComponentQueue2.java
deleted file mode 100644
index 2ce3e8f..000
--- a/wicket-core/src/main/java/org/apache/wicket/ComponentQueue2.java
+++ /dev/null
@@ -1,104 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the License); you may not
[jira] [Commented] (WICKET-5577) Generation of wicket ids with prefix / suffix
[ https://issues.apache.org/jira/browse/WICKET-5577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14001903#comment-14001903 ] Martin Grigorov commented on WICKET-5577: - I've extracted IMarkupIdGenerator in Wicket 7.x: https://git-wip-us.apache.org/repos/asf/wicket/repo?p=wicket.git;a=commitdiff;h=ccff0802a729bc10d84ed876ec08d408efc377af But this change is not OK for Wicket 6.x because it adds a new method to IMarkupSettings. Wicket devs: ideas how to do this in 6.x without making Clirr angry ? Generation of wicket ids with prefix / suffix - Key: WICKET-5577 URL: https://issues.apache.org/jira/browse/WICKET-5577 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 6.13.0 Environment: - Reporter: Tobias Soloschenko Assignee: Martin Grigorov Priority: Minor As mentioned in the following post of the users mailing list: http://wicket-users.markmail.org/message/54lo4i4qwoqtmuqv?q=tobias+soloschenko It would be great to be able to change the way wicket ids are generated so that it is possible to define a custom prefix / suffix. Example: Without prefix div id=menuItem32.../div With prefix div id= ns_Z7_0G8AH001I8CJD0AKTUU2F21004__menuItem32.../div ns_Z7_0G8AH001I8CJD0AKTUU2F21004__ would be the prefix. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (WICKET-5596) DropDownChoice#wantsOnSelectionChangedNotifications(T) not being called on unmounted page
Simon Botting created WICKET-5596: - Summary: DropDownChoice#wantsOnSelectionChangedNotifications(T) not being called on unmounted page Key: WICKET-5596 URL: https://issues.apache.org/jira/browse/WICKET-5596 Project: Wicket Issue Type: Bug Affects Versions: 6.15.0, 6.14.0 Environment: Windows 7, Jetty, Wicket 6.14.0 Wicket 6.15.0 Java 1.6 Reporter: Simon Botting I posted on nabble about this here: http://apache-wicket.1842946.n4.nabble.com/wantsOnSelectionChangedNotifications-RadioGroup-Radio-vs-DropDownChoice-td4665927.html Essentially on an unmounted bookmarkable page (one that you access directly through: wicket/bookmarkable/package.name.ClassName) the DropDownChoice#wantsOnSelectionChangedNotifications(T) does not seem to be called. Having looked at the internals a bit, it seems that the onchange handler is not setting a variable that resolves properly to any ListenerInterfaceRequestHandler e.g.: the onchange is: document.getElementById(#039;form6_hf_0#039;).value=#039;../../page?2-1.IOnChangeListener-form-vegetable#039;;document.getElementById(#039;form6#039;).submit(); but should be something like: document.getElementById(#039;form6_hf_0#039;).value=#039;./wicket_issue_4.FormPage?2-1.IOnChangeListener-form-vegetable#039;;document.getElementById(#039;form6#039;).submit(); That's just my initial thought, I'm no expert. Please look at the posting on nabble // Wicket Users Forum for more contextual information -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (WICKET-5596) DropDownChoice#wantsOnSelectionChangedNotifications(T) not being called on unmounted page
[ https://issues.apache.org/jira/browse/WICKET-5596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Botting updated WICKET-5596: -- Attachment: wicket_issue_4.tar.gz this is the quickstart that shows the problem described in WICKET-5596 DropDownChoice#wantsOnSelectionChangedNotifications(T) not being called on unmounted page - Key: WICKET-5596 URL: https://issues.apache.org/jira/browse/WICKET-5596 Project: Wicket Issue Type: Bug Affects Versions: 6.14.0, 6.15.0 Environment: Windows 7, Jetty, Wicket 6.14.0 Wicket 6.15.0 Java 1.6 Reporter: Simon Botting Attachments: wicket_issue_4.tar.gz I posted on nabble about this here: http://apache-wicket.1842946.n4.nabble.com/wantsOnSelectionChangedNotifications-RadioGroup-Radio-vs-DropDownChoice-td4665927.html Essentially on an unmounted bookmarkable page (one that you access directly through: wicket/bookmarkable/package.name.ClassName) the DropDownChoice#wantsOnSelectionChangedNotifications(T) does not seem to be called. Having looked at the internals a bit, it seems that the onchange handler is not setting a variable that resolves properly to any ListenerInterfaceRequestHandler e.g.: the onchange is: document.getElementById(#039;form6_hf_0#039;).value=#039;../../page?2-1.IOnChangeListener-form-vegetable#039;;document.getElementById(#039;form6#039;).submit(); but should be something like: document.getElementById(#039;form6_hf_0#039;).value=#039;./wicket_issue_4.FormPage?2-1.IOnChangeListener-form-vegetable#039;;document.getElementById(#039;form6#039;).submit(); That's just my initial thought, I'm no expert. Please look at the posting on nabble // Wicket Users Forum for more contextual information -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (WICKET-5596) DropDownChoice#wantsOnSelectionChangedNotifications(T) not being called on unmounted page
[ https://issues.apache.org/jira/browse/WICKET-5596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene reassigned WICKET-5596: --- Assignee: Andrea Del Bene DropDownChoice#wantsOnSelectionChangedNotifications(T) not being called on unmounted page - Key: WICKET-5596 URL: https://issues.apache.org/jira/browse/WICKET-5596 Project: Wicket Issue Type: Bug Affects Versions: 6.14.0, 6.15.0 Environment: Windows 7, Jetty, Wicket 6.14.0 Wicket 6.15.0 Java 1.6 Reporter: Simon Botting Assignee: Andrea Del Bene Attachments: wicket_issue_4.tar.gz I posted on nabble about this here: http://apache-wicket.1842946.n4.nabble.com/wantsOnSelectionChangedNotifications-RadioGroup-Radio-vs-DropDownChoice-td4665927.html Essentially on an unmounted bookmarkable page (one that you access directly through: wicket/bookmarkable/package.name.ClassName) the DropDownChoice#wantsOnSelectionChangedNotifications(T) does not seem to be called. Having looked at the internals a bit, it seems that the onchange handler is not setting a variable that resolves properly to any ListenerInterfaceRequestHandler e.g.: the onchange is: document.getElementById(#039;form6_hf_0#039;).value=#039;../../page?2-1.IOnChangeListener-form-vegetable#039;;document.getElementById(#039;form6#039;).submit(); but should be something like: document.getElementById(#039;form6_hf_0#039;).value=#039;./wicket_issue_4.FormPage?2-1.IOnChangeListener-form-vegetable#039;;document.getElementById(#039;form6#039;).submit(); That's just my initial thought, I'm no expert. Please look at the posting on nabble // Wicket Users Forum for more contextual information -- This message was sent by Atlassian JIRA (v6.2#6252)
git commit: Code improved for AbstractLink
Repository: wicket
Updated Branches:
refs/heads/wicket-6.x cdc28993d - 3c6c41f19
Code improved for AbstractLink
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/3c6c41f1
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/3c6c41f1
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/3c6c41f1
Branch: refs/heads/wicket-6.x
Commit: 3c6c41f19f6d4d9a236a7d902ed62816af41c00b
Parents: cdc2899
Author: adelbene an.delb...@gmail.com
Authored: Mon May 19 19:30:58 2014 +0200
Committer: adelbene an.delb...@gmail.com
Committed: Mon May 19 19:30:58 2014 +0200
--
.../wicket/markup/html/link/AbstractLink.java | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/3c6c41f1/wicket-core/src/main/java/org/apache/wicket/markup/html/link/AbstractLink.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/markup/html/link/AbstractLink.java
b/wicket-core/src/main/java/org/apache/wicket/markup/html/link/AbstractLink.java
index 86c2c89..d267a1c 100644
---
a/wicket-core/src/main/java/org/apache/wicket/markup/html/link/AbstractLink.java
+++
b/wicket-core/src/main/java/org/apache/wicket/markup/html/link/AbstractLink.java
@@ -165,7 +165,9 @@ public abstract class AbstractLink extends
WebMarkupContainer
public void onComponentTagBody(final MarkupStream markupStream, final
ComponentTag openTag)
{
// Draw anything before the body?
- if (!isLinkEnabled() getBeforeDisabledLink() != null)
+ boolean linkEnabled = isLinkEnabled();
+
+ if (!linkEnabled getBeforeDisabledLink() != null)
{
getResponse().write(getBeforeDisabledLink());
}
@@ -184,7 +186,7 @@ public abstract class AbstractLink extends
WebMarkupContainer
super.onComponentTagBody(markupStream, openTag);
}
// Draw anything after the body?
- if (!isLinkEnabled() getAfterDisabledLink() != null)
+ if (!linkEnabled getAfterDisabledLink() != null)
{
getResponse().write(getAfterDisabledLink());
}
@@ -201,8 +203,10 @@ public abstract class AbstractLink extends
WebMarkupContainer
protected void disableLink(final ComponentTag tag)
{
// if the tag is an anchor proper
- if (tag.getName().equalsIgnoreCase(a) ||
tag.getName().equalsIgnoreCase(link) ||
- tag.getName().equalsIgnoreCase(area))
+ String tagName = tag.getName();
+
+ if (tagName.equalsIgnoreCase(a) ||
tagName.equalsIgnoreCase(link) ||
+ tagName.equalsIgnoreCase(area))
{
// Change anchor link to span tag
tag.setName(span);
@@ -213,8 +217,8 @@ public abstract class AbstractLink extends
WebMarkupContainer
tag.remove(onclick);
}
// if the tag is a button or input
- else if (button.equalsIgnoreCase(tag.getName()) ||
- input.equalsIgnoreCase(tag.getName()))
+ else if (button.equalsIgnoreCase(tagName) ||
+ input.equalsIgnoreCase(tagName))
{
tag.put(disabled, disabled);
}
git commit: [WICKET-5596] DropDownChoice#wantsOnSelectionChangedNotifications(T) not being called on unmounted page
Repository: wicket
Updated Branches:
refs/heads/wicket-6.x 3c6c41f19 - 6dfd3d9d2
[WICKET-5596] DropDownChoice#wantsOnSelectionChangedNotifications(T) not
being called on unmounted page
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/6dfd3d9d
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/6dfd3d9d
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/6dfd3d9d
Branch: refs/heads/wicket-6.x
Commit: 6dfd3d9d2cb7e378275db0458c9d241de8e7e7d8
Parents: 3c6c41f
Author: adelbene an.delb...@gmail.com
Authored: Mon May 19 22:24:55 2014 +0200
Committer: adelbene an.delb...@gmail.com
Committed: Mon May 19 22:24:55 2014 +0200
--
.../org/apache/wicket/markup/html/form/DropDownChoice.java | 6 +-
.../extensions/yui/calendar/DatesPage1_ExpectedResult.html | 2 +-
2 files changed, 2 insertions(+), 6 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/6dfd3d9d/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
index 0db8dc6..1da483a 100644
---
a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
+++
b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
@@ -21,8 +21,6 @@ import java.util.List;
import org.apache.wicket.ajax.form.AjaxFormComponentUpdatingBehavior;
import org.apache.wicket.markup.ComponentTag;
import org.apache.wicket.model.IModel;
-import org.apache.wicket.core.request.handler.ListenerInterfaceRequestHandler;
-import org.apache.wicket.core.request.handler.PageAndComponentProvider;
import org.apache.wicket.request.mapper.parameter.PageParameters;
@@ -233,9 +231,7 @@ public class DropDownChoiceT extends
AbstractSingleSelectChoiceT implements
{
// we do not want relative URL here, because it will be
used by
// Form#dispatchEvent
- CharSequence url = urlFor(new
ListenerInterfaceRequestHandler(
- new PageAndComponentProvider(getPage(), this,
new PageParameters()),
- IOnChangeListener.INTERFACE));
+ CharSequence url = urlFor(IOnChangeListener.INTERFACE,
new PageParameters());
Form? form = findParent(Form.class);
if (form != null)
http://git-wip-us.apache.org/repos/asf/wicket/blob/6dfd3d9d/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatesPage1_ExpectedResult.html
--
diff --git
a/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatesPage1_ExpectedResult.html
b/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatesPage1_ExpectedResult.html
index 45bc50e..e32bce0 100644
---
a/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatesPage1_ExpectedResult.html
+++
b/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatesPage1_ExpectedResult.html
@@ -105,7 +105,7 @@ Wicket.DateTimeInit.CalendarAdd(function() {
/head
body
form wicket:id=localeForm id=localeForm2 method=post
action=./org.apache.wicket.extensions.yui.calendar.DatesPage1?0-1.IFormSubmitListener-localeFormdiv
style=width:0px;height:0px;position:absolute;left:-100px;top:-100px;overflow:hiddeninput
type=hidden name=localeForm2_hf_0 id=localeForm2_hf_0 //div
-pselect wicket:id=localeSelect
onchange=document.getElementById(#039;localeForm2_hf_0#039;).value=#039;../../page?0-1.IOnChangeListener-localeForm-localeSelect#039;;document.getElementById(#039;localeForm2#039;).submit();
name=localeSelect
+pselect wicket:id=localeSelect
onchange=document.getElementById(#039;localeForm2_hf_0#039;).value=#039;./org.apache.wicket.extensions.yui.calendar.DatesPage1?0-1.IOnChangeListener-localeForm-localeSelect#039;;document.getElementById(#039;localeForm2#039;).submit();
name=localeSelect
option value=0cinese (Cina) (Chinese (China))/option
option value=1cinese (Cina) (Chinese (China))/option
option value=2cinese (Cina) (Chinese (China))/option
git commit: [WICKET-5596] DropDownChoice#wantsOnSelectionChangedNotifications(T) not being called on unmounted page
Repository: wicket
Updated Branches:
refs/heads/master ccff0802a - 0102b9db3
[WICKET-5596] DropDownChoice#wantsOnSelectionChangedNotifications(T) not
being called on unmounted page
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/0102b9db
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/0102b9db
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/0102b9db
Branch: refs/heads/master
Commit: 0102b9db3f093b415d1a646c5d7590bd3b10d00e
Parents: ccff080
Author: adelbene an.delb...@gmail.com
Authored: Mon May 19 22:24:55 2014 +0200
Committer: adelbene an.delb...@gmail.com
Committed: Mon May 19 23:03:40 2014 +0200
--
.../apache/wicket/markup/html/form/DropDownChoice.java | 11 ---
.../yui/calendar/DatesPage1_ExpectedResult.html | 2 +-
2 files changed, 5 insertions(+), 8 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/0102b9db/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
index e6ec9ca..3f97479 100644
---
a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
+++
b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
@@ -19,10 +19,10 @@ package org.apache.wicket.markup.html.form;
import java.util.List;
import org.apache.wicket.ajax.form.AjaxFormComponentUpdatingBehavior;
-import org.apache.wicket.core.request.handler.ListenerInterfaceRequestHandler;
-import org.apache.wicket.core.request.handler.PageAndComponentProvider;
import org.apache.wicket.markup.ComponentTag;
import org.apache.wicket.model.IModel;
+import org.apache.wicket.core.request.handler.ListenerInterfaceRequestHandler;
+import org.apache.wicket.core.request.handler.PageAndComponentProvider;
import org.apache.wicket.request.mapper.parameter.PageParameters;
@@ -233,9 +233,7 @@ public class DropDownChoiceT extends
AbstractSingleSelectChoiceT implements
{
// we do not want relative URL here, because it will be
used by
// Form#dispatchEvent
- CharSequence url = urlFor(new
ListenerInterfaceRequestHandler(
- new PageAndComponentProvider(getPage(), this,
new PageParameters()),
- IOnChangeListener.INTERFACE));
+ CharSequence url = urlFor(IOnChangeListener.INTERFACE,
new PageParameters());
Form? form = findParent(Form.class);
if (form != null)
@@ -263,7 +261,6 @@ public class DropDownChoiceT extends
AbstractSingleSelectChoiceT implements
* @param newSelection
*The newly selected object of the backing model NOTE this
is the same as you would
*get by calling getModelObject() if the new selection were
current
-* @see #wantOnSelectionChangedNotifications()
*/
protected void onSelectionChanged(final T newSelection)
{
@@ -297,4 +294,4 @@ public class DropDownChoiceT extends
AbstractSingleSelectChoiceT implements
}
return super.getStatelessHint();
}
-}
+}
\ No newline at end of file
http://git-wip-us.apache.org/repos/asf/wicket/blob/0102b9db/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatesPage1_ExpectedResult.html
--
diff --git
a/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatesPage1_ExpectedResult.html
b/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatesPage1_ExpectedResult.html
index 45bc50e..e32bce0 100644
---
a/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatesPage1_ExpectedResult.html
+++
b/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatesPage1_ExpectedResult.html
@@ -105,7 +105,7 @@ Wicket.DateTimeInit.CalendarAdd(function() {
/head
body
form wicket:id=localeForm id=localeForm2 method=post
action=./org.apache.wicket.extensions.yui.calendar.DatesPage1?0-1.IFormSubmitListener-localeFormdiv
style=width:0px;height:0px;position:absolute;left:-100px;top:-100px;overflow:hiddeninput
type=hidden name=localeForm2_hf_0 id=localeForm2_hf_0 //div
-pselect wicket:id=localeSelect
onchange=document.getElementById(#039;localeForm2_hf_0#039;).value=#039;../../page?0-1.IOnChangeListener-localeForm-localeSelect#039;;document.getElementById(#039;localeForm2#039;).submit();
name=localeSelect
+pselect
[jira] [Closed] (WICKET-5596) DropDownChoice#wantsOnSelectionChangedNotifications(T) not being called on unmounted page
[ https://issues.apache.org/jira/browse/WICKET-5596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene closed WICKET-5596. --- Resolution: Fixed DropDownChoice#wantsOnSelectionChangedNotifications(T) not being called on unmounted page - Key: WICKET-5596 URL: https://issues.apache.org/jira/browse/WICKET-5596 Project: Wicket Issue Type: Bug Affects Versions: 6.14.0, 6.15.0, 7.0.0-M2 Environment: Windows 7, Jetty, Wicket 6.14.0 Wicket 6.15.0 Java 1.6 Reporter: Simon Botting Assignee: Andrea Del Bene Attachments: wicket_issue_4.tar.gz I posted on nabble about this here: http://apache-wicket.1842946.n4.nabble.com/wantsOnSelectionChangedNotifications-RadioGroup-Radio-vs-DropDownChoice-td4665927.html Essentially on an unmounted bookmarkable page (one that you access directly through: wicket/bookmarkable/package.name.ClassName) the DropDownChoice#wantsOnSelectionChangedNotifications(T) does not seem to be called. Having looked at the internals a bit, it seems that the onchange handler is not setting a variable that resolves properly to any ListenerInterfaceRequestHandler e.g.: the onchange is: document.getElementById(#039;form6_hf_0#039;).value=#039;../../page?2-1.IOnChangeListener-form-vegetable#039;;document.getElementById(#039;form6#039;).submit(); but should be something like: document.getElementById(#039;form6_hf_0#039;).value=#039;./wicket_issue_4.FormPage?2-1.IOnChangeListener-form-vegetable#039;;document.getElementById(#039;form6#039;).submit(); That's just my initial thought, I'm no expert. Please look at the posting on nabble // Wicket Users Forum for more contextual information -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (WICKET-5596) DropDownChoice#wantsOnSelectionChangedNotifications(T) not being called on unmounted page
[ https://issues.apache.org/jira/browse/WICKET-5596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-5596: Affects Version/s: 7.0.0-M2 DropDownChoice#wantsOnSelectionChangedNotifications(T) not being called on unmounted page - Key: WICKET-5596 URL: https://issues.apache.org/jira/browse/WICKET-5596 Project: Wicket Issue Type: Bug Affects Versions: 6.14.0, 6.15.0, 7.0.0-M2 Environment: Windows 7, Jetty, Wicket 6.14.0 Wicket 6.15.0 Java 1.6 Reporter: Simon Botting Assignee: Andrea Del Bene Attachments: wicket_issue_4.tar.gz I posted on nabble about this here: http://apache-wicket.1842946.n4.nabble.com/wantsOnSelectionChangedNotifications-RadioGroup-Radio-vs-DropDownChoice-td4665927.html Essentially on an unmounted bookmarkable page (one that you access directly through: wicket/bookmarkable/package.name.ClassName) the DropDownChoice#wantsOnSelectionChangedNotifications(T) does not seem to be called. Having looked at the internals a bit, it seems that the onchange handler is not setting a variable that resolves properly to any ListenerInterfaceRequestHandler e.g.: the onchange is: document.getElementById(#039;form6_hf_0#039;).value=#039;../../page?2-1.IOnChangeListener-form-vegetable#039;;document.getElementById(#039;form6#039;).submit(); but should be something like: document.getElementById(#039;form6_hf_0#039;).value=#039;./wicket_issue_4.FormPage?2-1.IOnChangeListener-form-vegetable#039;;document.getElementById(#039;form6#039;).submit(); That's just my initial thought, I'm no expert. Please look at the posting on nabble // Wicket Users Forum for more contextual information -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Reopened] (WICKET-5596) DropDownChoice#wantsOnSelectionChangedNotifications(T) not being called on unmounted page
[ https://issues.apache.org/jira/browse/WICKET-5596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene reopened WICKET-5596: - DropDownChoice#wantsOnSelectionChangedNotifications(T) not being called on unmounted page - Key: WICKET-5596 URL: https://issues.apache.org/jira/browse/WICKET-5596 Project: Wicket Issue Type: Bug Affects Versions: 6.14.0, 7.0.0-M1, 6.15.0 Environment: Windows 7, Jetty, Wicket 6.14.0 Wicket 6.15.0 Java 1.6 Reporter: Simon Botting Assignee: Andrea Del Bene Fix For: 6.16.0, 7.0.0-M2 Attachments: wicket_issue_4.tar.gz I posted on nabble about this here: http://apache-wicket.1842946.n4.nabble.com/wantsOnSelectionChangedNotifications-RadioGroup-Radio-vs-DropDownChoice-td4665927.html Essentially on an unmounted bookmarkable page (one that you access directly through: wicket/bookmarkable/package.name.ClassName) the DropDownChoice#wantsOnSelectionChangedNotifications(T) does not seem to be called. Having looked at the internals a bit, it seems that the onchange handler is not setting a variable that resolves properly to any ListenerInterfaceRequestHandler e.g.: the onchange is: document.getElementById(#039;form6_hf_0#039;).value=#039;../../page?2-1.IOnChangeListener-form-vegetable#039;;document.getElementById(#039;form6#039;).submit(); but should be something like: document.getElementById(#039;form6_hf_0#039;).value=#039;./wicket_issue_4.FormPage?2-1.IOnChangeListener-form-vegetable#039;;document.getElementById(#039;form6#039;).submit(); That's just my initial thought, I'm no expert. Please look at the posting on nabble // Wicket Users Forum for more contextual information -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (WICKET-5596) DropDownChoice#wantsOnSelectionChangedNotifications(T) not being called on unmounted page
[ https://issues.apache.org/jira/browse/WICKET-5596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-5596: Affects Version/s: (was: 7.0.0-M2) 7.0.0-M1 DropDownChoice#wantsOnSelectionChangedNotifications(T) not being called on unmounted page - Key: WICKET-5596 URL: https://issues.apache.org/jira/browse/WICKET-5596 Project: Wicket Issue Type: Bug Affects Versions: 6.14.0, 7.0.0-M1, 6.15.0 Environment: Windows 7, Jetty, Wicket 6.14.0 Wicket 6.15.0 Java 1.6 Reporter: Simon Botting Assignee: Andrea Del Bene Fix For: 6.16.0, 7.0.0-M2 Attachments: wicket_issue_4.tar.gz I posted on nabble about this here: http://apache-wicket.1842946.n4.nabble.com/wantsOnSelectionChangedNotifications-RadioGroup-Radio-vs-DropDownChoice-td4665927.html Essentially on an unmounted bookmarkable page (one that you access directly through: wicket/bookmarkable/package.name.ClassName) the DropDownChoice#wantsOnSelectionChangedNotifications(T) does not seem to be called. Having looked at the internals a bit, it seems that the onchange handler is not setting a variable that resolves properly to any ListenerInterfaceRequestHandler e.g.: the onchange is: document.getElementById(#039;form6_hf_0#039;).value=#039;../../page?2-1.IOnChangeListener-form-vegetable#039;;document.getElementById(#039;form6#039;).submit(); but should be something like: document.getElementById(#039;form6_hf_0#039;).value=#039;./wicket_issue_4.FormPage?2-1.IOnChangeListener-form-vegetable#039;;document.getElementById(#039;form6#039;).submit(); That's just my initial thought, I'm no expert. Please look at the posting on nabble // Wicket Users Forum for more contextual information -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (WICKET-5596) DropDownChoice#wantsOnSelectionChangedNotifications(T) not being called on unmounted page
[ https://issues.apache.org/jira/browse/WICKET-5596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-5596: Fix Version/s: 7.0.0-M2 6.16.0 DropDownChoice#wantsOnSelectionChangedNotifications(T) not being called on unmounted page - Key: WICKET-5596 URL: https://issues.apache.org/jira/browse/WICKET-5596 Project: Wicket Issue Type: Bug Affects Versions: 6.14.0, 7.0.0-M1, 6.15.0 Environment: Windows 7, Jetty, Wicket 6.14.0 Wicket 6.15.0 Java 1.6 Reporter: Simon Botting Assignee: Andrea Del Bene Fix For: 6.16.0, 7.0.0-M2 Attachments: wicket_issue_4.tar.gz I posted on nabble about this here: http://apache-wicket.1842946.n4.nabble.com/wantsOnSelectionChangedNotifications-RadioGroup-Radio-vs-DropDownChoice-td4665927.html Essentially on an unmounted bookmarkable page (one that you access directly through: wicket/bookmarkable/package.name.ClassName) the DropDownChoice#wantsOnSelectionChangedNotifications(T) does not seem to be called. Having looked at the internals a bit, it seems that the onchange handler is not setting a variable that resolves properly to any ListenerInterfaceRequestHandler e.g.: the onchange is: document.getElementById(#039;form6_hf_0#039;).value=#039;../../page?2-1.IOnChangeListener-form-vegetable#039;;document.getElementById(#039;form6#039;).submit(); but should be something like: document.getElementById(#039;form6_hf_0#039;).value=#039;./wicket_issue_4.FormPage?2-1.IOnChangeListener-form-vegetable#039;;document.getElementById(#039;form6#039;).submit(); That's just my initial thought, I'm no expert. Please look at the posting on nabble // Wicket Users Forum for more contextual information -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Closed] (WICKET-5596) DropDownChoice#wantsOnSelectionChangedNotifications(T) not being called on unmounted page
[ https://issues.apache.org/jira/browse/WICKET-5596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene closed WICKET-5596. --- Resolution: Fixed DropDownChoice#wantsOnSelectionChangedNotifications(T) not being called on unmounted page - Key: WICKET-5596 URL: https://issues.apache.org/jira/browse/WICKET-5596 Project: Wicket Issue Type: Bug Affects Versions: 6.14.0, 7.0.0-M1, 6.15.0 Environment: Windows 7, Jetty, Wicket 6.14.0 Wicket 6.15.0 Java 1.6 Reporter: Simon Botting Assignee: Andrea Del Bene Fix For: 6.16.0, 7.0.0-M2 Attachments: wicket_issue_4.tar.gz I posted on nabble about this here: http://apache-wicket.1842946.n4.nabble.com/wantsOnSelectionChangedNotifications-RadioGroup-Radio-vs-DropDownChoice-td4665927.html Essentially on an unmounted bookmarkable page (one that you access directly through: wicket/bookmarkable/package.name.ClassName) the DropDownChoice#wantsOnSelectionChangedNotifications(T) does not seem to be called. Having looked at the internals a bit, it seems that the onchange handler is not setting a variable that resolves properly to any ListenerInterfaceRequestHandler e.g.: the onchange is: document.getElementById(#039;form6_hf_0#039;).value=#039;../../page?2-1.IOnChangeListener-form-vegetable#039;;document.getElementById(#039;form6#039;).submit(); but should be something like: document.getElementById(#039;form6_hf_0#039;).value=#039;./wicket_issue_4.FormPage?2-1.IOnChangeListener-form-vegetable#039;;document.getElementById(#039;form6#039;).submit(); That's just my initial thought, I'm no expert. Please look at the posting on nabble // Wicket Users Forum for more contextual information -- This message was sent by Atlassian JIRA (v6.2#6252)
