date:20141002


[ 
https://issues.apache.org/jira/browse/WICKET-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156251#comment-14156251
 ] 

Martin Grigorov commented on WICKET-5704:
-

Thanks for verifying!

 IllegalArgument exception with wicket:child in ajaxrequest
 --

 Key: WICKET-5704
 URL: https://issues.apache.org/jira/browse/WICKET-5704
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 6.16.0, 6.17.0
Reporter: Ted Roeloffzen
Assignee: Jesse Long
 Fix For: 6.18.0, 7.0.0-M4


 We have a page in our application with a DataView.
 In this DataView we have an anonymous inner class of a component which has a 
 wicket:child-tag.
 When there is ajaxrequest, in our case because we want to go to the next page 
 in our dataview, an exception is thrown.
 java.lang.IllegalArgumentException: Argument 'streamOffset' must have a value 
 within [0,0], but was 1
 at org.apache.wicket.util.lang.Args.withinRange(Args.java:120)
 at 
 org.apache.wicket.markup.AbstractMarkupFragment.find(AbstractMarkupFragment.java:43)
 at 
 org.apache.wicket.markup.MarkupFragment.find(MarkupFragment.java:150)
 at 
 org.apache.wicket.markup.html.panel.DefaultMarkupSourcingStrategy.getMarkup(DefaultMarkupSourcingStrategy.java:94)
 at 
 org.apache.wicket.MarkupContainer.getMarkup(MarkupContainer.java:451)
 at 
 org.apache.wicket.markup.html.panel.AbstractMarkupSourcingStrategy$1.component(AbstractMarkupSourcingStrategy.java:72)
 at 
 org.apache.wicket.markup.html.panel.AbstractMarkupSourcingStrategy$1.component(AbstractMarkupSourcingStrategy.java:66)
 I have the feeling that is caused by the fix in the following jira-issue
 https://issues.apache.org/jira/browse/WICKET-5580
 When we remove the wicket:child-tag completely, there is no problem.
 When we change the anonymous inner class, to a nested class and give it an 
 html-file with wicket:extend-tags without anything between them, it also 
 works.
 I believe that the fix for WICKET-5580, failed to take in account subclasses 
 of components that don't need to add markup and therefor don't have their own 
 HTML-file.
 I hope I can get around to making a quickstart testcase for this in the next 
 couple of days



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

2014-10-02 Thread ASF subversion and git services (JIRA)

Martin Grigorov created WICKET-5713:
---

 Summary: Move /wicket.properties to /META-INF/wicket/xyz.properties
 Key: WICKET-5713
 URL: https://issues.apache.org/jira/browse/WICKET-5713
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Affects Versions: 6.17.0
Reporter: Martin Grigorov
Assignee: Martin Grigorov
Priority: Minor


As found at http://markmail.org/message/gzychpjelr4eshly the current location 
of wicket.properties (at the root of the classpath entry) is problematic when 
an uberjar is used because usually the developer doesn't know how 
org.apache.wicket.IInitializer works and doesn't add code to merge the contents 
of all wicket.propeties files in the classpath into one.

But even if the developer tried to merge them then it will fail again because 
org.apache.wicket.Application#load(Properties) doesn't expect more than one 
value per key, e.g. separated by comma.

Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
and use more qualified names, e.g. org.apache.wicket.core.properties.

The first problem is that there are no JRE and Servlet APIs to find such files 
easily. We need to scan the classpath to be able to find them and load them.
Is this costly ?
https://github.com/ronmamo/reflections is wildly used library that provides 
this functionality (and much more) and it is using the same logic and seems to 
be quite fast!

So let's give it a try!

We should still support /wicket.properties for backward compatibility. We can 
log a WARN message when such is found and suggest to be moved in 
/META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties


[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156306#comment-14156306
 ] 

ASF subversion and git services commented on WICKET-5713:
-

Commit e4262674d6dd347fb51a1454c63e5f03ed5f135e in wicket's branch 
refs/heads/WICKET-5713-meta-inf-wicket from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=e426267 ]

WICKET-5713 Move /wicket.properties to /META-INF/wicket/xyz.properties


 Move /wicket.properties to /META-INF/wicket/xyz.properties
 --

 Key: WICKET-5713
 URL: https://issues.apache.org/jira/browse/WICKET-5713
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Affects Versions: 6.17.0
Reporter: Martin Grigorov
Assignee: Martin Grigorov
Priority: Minor

 As found at http://markmail.org/message/gzychpjelr4eshly the current location 
 of wicket.properties (at the root of the classpath entry) is problematic when 
 an uberjar is used because usually the developer doesn't know how 
 org.apache.wicket.IInitializer works and doesn't add code to merge the 
 contents of all wicket.propeties files in the classpath into one.
 But even if the developer tried to merge them then it will fail again because 
 org.apache.wicket.Application#load(Properties) doesn't expect more than one 
 value per key, e.g. separated by comma.
 Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
 and use more qualified names, e.g. org.apache.wicket.core.properties.
 The first problem is that there are no JRE and Servlet APIs to find such 
 files easily. We need to scan the classpath to be able to find them and load 
 them.
 Is this costly ?
 https://github.com/ronmamo/reflections is wildly used library that provides 
 this functionality (and much more) and it is using the same logic and seems 
 to be quite fast!
 So let's give it a try!
 We should still support /wicket.properties for backward compatibility. We can 
 log a WARN message when such is found and suggest to be moved in 
 /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

git commit: WICKET-5713 Move /wicket.properties to /META-INF/wicket/xyz.properties

Repository: wicket
Updated Branches:
  refs/heads/WICKET-5713-meta-inf-wicket [created] e4262674d


WICKET-5713 Move /wicket.properties to /META-INF/wicket/xyz.properties


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/e4262674
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/e4262674
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/e4262674

Branch: refs/heads/WICKET-5713-meta-inf-wicket
Commit: e4262674d6dd347fb51a1454c63e5f03ed5f135e
Parents: 5837817
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Thu Oct 2 12:32:21 2014 +0200
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Thu Oct 2 12:32:21 2014 +0200

--
 .../wicket/osgi/OsgiClashingPackagesTest.java   |  2 +-
 .../java/org/apache/wicket/Application.java | 97 +---
 .../java/org/apache/wicket/IInitializer.java|  7 +-
 .../wicket/settings/FrameworkSettings.java  |  2 +-
 wicket-core/src/main/java/wicket.properties | 15 ---
 .../wicket/org.apache.wicket.core.properties| 15 +++
 wicket-devutils/src/main/java/wicket.properties | 15 ---
 .../org.apache.wicket.devutils.properties   | 15 +++
 .../org.apache.wicket.atmosphere.properties | 15 +++
 .../src/main/resources/wicket.properties| 15 ---
 .../src/main/java/wicket.properties | 15 ---
 .../org.apache.wicket.extensions.properties | 15 +++
 wicket-jmx/src/main/java/wicket.properties  | 15 ---
 .../wicket/org.apache.wicket.jmx.properties | 15 +++
 .../org/apache/wicket/velocity/Initializer.java | 11 +--
 wicket-velocity/src/main/java/wicket.properties | 15 ---
 .../org.apache.wicket.velocity.properties   | 15 +++
 17 files changed, 184 insertions(+), 115 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/e4262674/testing/wicket-common-tests/src/test/java/org/apache/wicket/osgi/OsgiClashingPackagesTest.java
--
diff --git 
a/testing/wicket-common-tests/src/test/java/org/apache/wicket/osgi/OsgiClashingPackagesTest.java
 
b/testing/wicket-common-tests/src/test/java/org/apache/wicket/osgi/OsgiClashingPackagesTest.java
index 993c8d4..6672cc6 100644
--- 
a/testing/wicket-common-tests/src/test/java/org/apache/wicket/osgi/OsgiClashingPackagesTest.java
+++ 
b/testing/wicket-common-tests/src/test/java/org/apache/wicket/osgi/OsgiClashingPackagesTest.java
@@ -153,7 +153,7 @@ public class OsgiClashingPackagesTest extends Assert
entryName.startsWith(META-INF/) ||
 
// ignore Wicket's IInitializer conf files
-   (entryName.startsWith(wicket)  
entryName.endsWith(.properties))
+   (entryName.startsWith(META-INF/wicket)  
entryName.endsWith(.properties))
)
{
return false;

http://git-wip-us.apache.org/repos/asf/wicket/blob/e4262674/wicket-core/src/main/java/org/apache/wicket/Application.java
--
diff --git a/wicket-core/src/main/java/org/apache/wicket/Application.java 
b/wicket-core/src/main/java/org/apache/wicket/Application.java
index 999316d..f2fd258 100644
--- a/wicket-core/src/main/java/org/apache/wicket/Application.java
+++ b/wicket-core/src/main/java/org/apache/wicket/Application.java
@@ -18,20 +18,25 @@ package org.apache.wicket;
 
 import java.io.IOException;
 import java.io.InputStream;
+import java.net.JarURLConnection;
+import java.net.URISyntaxException;
 import java.net.URL;
 import java.net.URLConnection;
 import java.util.Collections;
+import java.util.Enumeration;
 import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
 import java.util.Properties;
 import java.util.Set;
+import java.util.jar.JarEntry;
+import java.util.jar.JarFile;
 
-import org.apache.wicket.application.ComponentOnConfigureListenerCollection;
 import org.apache.wicket.application.ComponentInitializationListenerCollection;
 import org.apache.wicket.application.ComponentInstantiationListenerCollection;
 import org.apache.wicket.application.ComponentOnAfterRenderListenerCollection;
 import org.apache.wicket.application.ComponentOnBeforeRenderListenerCollection;
+import org.apache.wicket.application.ComponentOnConfigureListenerCollection;
 import org.apache.wicket.application.HeaderContributorListenerCollection;
 import org.apache.wicket.application.IComponentInitializationListener;
 import org.apache.wicket.application.IComponentInstantiationListener;
@@ -98,6 +103,8 @@ import org.apache.wicket.settings.ResourceSettings;
 import org.apache.wicket.settings.SecuritySettings;
 import org.apache.wicket.settings.StoreSettings;
 import

git commit: WICKET-5713 Move /wicket.properties to /META-INF/wicket/xyz.properties

2014-10-02 Thread ASF subversion and git services (JIRA)

Repository: wicket
Updated Branches:
  refs/heads/WICKET-5713-meta-inf-wicket e4262674d - d106598d4


WICKET-5713 Move /wicket.properties to /META-INF/wicket/xyz.properties


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/d106598d
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/d106598d
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/d106598d

Branch: refs/heads/WICKET-5713-meta-inf-wicket
Commit: d106598d4e244122eb330ae84de9cdc6f0ac1413
Parents: e426267
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Thu Oct 2 13:00:16 2014 +0200
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Thu Oct 2 13:00:16 2014 +0200

--
 wicket-core/src/main/java/org/apache/wicket/Application.java | 1 +
 1 file changed, 1 insertion(+)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/d106598d/wicket-core/src/main/java/org/apache/wicket/Application.java
--
diff --git a/wicket-core/src/main/java/org/apache/wicket/Application.java 
b/wicket-core/src/main/java/org/apache/wicket/Application.java
index f2fd258..5376284 100644
--- a/wicket-core/src/main/java/org/apache/wicket/Application.java
+++ b/wicket-core/src/main/java/org/apache/wicket/Application.java
@@ -508,6 +508,7 @@ public abstract class Application implements 
UnboundListener, IEventSink
{

properties.load(jarEntryStream);
load(properties);
+   break; // atm there is 
no need to have more than one .properties file
}
}
}

[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties


[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156367#comment-14156367
 ] 

ASF subversion and git services commented on WICKET-5713:
-

Commit d106598d4e244122eb330ae84de9cdc6f0ac1413 in wicket's branch 
refs/heads/WICKET-5713-meta-inf-wicket from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=d106598 ]

WICKET-5713 Move /wicket.properties to /META-INF/wicket/xyz.properties


 Move /wicket.properties to /META-INF/wicket/xyz.properties
 --

 Key: WICKET-5713
 URL: https://issues.apache.org/jira/browse/WICKET-5713
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Affects Versions: 6.17.0
Reporter: Martin Grigorov
Assignee: Martin Grigorov
Priority: Minor

 As found at http://markmail.org/message/gzychpjelr4eshly the current location 
 of wicket.properties (at the root of the classpath entry) is problematic when 
 an uberjar is used because usually the developer doesn't know how 
 org.apache.wicket.IInitializer works and doesn't add code to merge the 
 contents of all wicket.propeties files in the classpath into one.
 But even if the developer tried to merge them then it will fail again because 
 org.apache.wicket.Application#load(Properties) doesn't expect more than one 
 value per key, e.g. separated by comma.
 Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
 and use more qualified names, e.g. org.apache.wicket.core.properties.
 The first problem is that there are no JRE and Servlet APIs to find such 
 files easily. We need to scan the classpath to be able to find them and load 
 them.
 Is this costly ?
 https://github.com/ronmamo/reflections is wildly used library that provides 
 this functionality (and much more) and it is using the same logic and seems 
 to be quite fast!
 So let's give it a try!
 We should still support /wicket.properties for backward compatibility. We can 
 log a WARN message when such is found and suggest to be moved in 
 /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties


[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156368#comment-14156368
 ] 

Martin Grigorov commented on WICKET-5713:
-

Please review !

 Move /wicket.properties to /META-INF/wicket/xyz.properties
 --

 Key: WICKET-5713
 URL: https://issues.apache.org/jira/browse/WICKET-5713
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Affects Versions: 6.17.0
Reporter: Martin Grigorov
Assignee: Martin Grigorov
Priority: Minor

 As found at http://markmail.org/message/gzychpjelr4eshly the current location 
 of wicket.properties (at the root of the classpath entry) is problematic when 
 an uberjar is used because usually the developer doesn't know how 
 org.apache.wicket.IInitializer works and doesn't add code to merge the 
 contents of all wicket.propeties files in the classpath into one.
 But even if the developer tried to merge them then it will fail again because 
 org.apache.wicket.Application#load(Properties) doesn't expect more than one 
 value per key, e.g. separated by comma.
 Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
 and use more qualified names, e.g. org.apache.wicket.core.properties.
 The first problem is that there are no JRE and Servlet APIs to find such 
 files easily. We need to scan the classpath to be able to find them and load 
 them.
 Is this costly ?
 https://github.com/ronmamo/reflections is wildly used library that provides 
 this functionality (and much more) and it is using the same logic and seems 
 to be quite fast!
 So let's give it a try!
 We should still support /wicket.properties for backward compatibility. We can 
 log a WARN message when such is found and suggest to be moved in 
 /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

[
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156458#comment-14156458
]

Sven Meier commented on WICKET-5713:

Moving the files to META-INF/wicket is a good idea.

Apart from that I don't think this change is too useful:
I'd expect usage of uberjar to lead to many other name collisions anyway.
Java's service registry is broken with uberjar too (e.g.
META-INF/services/java.sql.Driver).

Furthermore up til now I was able to search for wicket.properties in my IDE
and quickly find all registered Initializers. Now I can't find them so easily
:(.
Can we at least rename *.properties to *.initializer(s)?

Move /wicket.properties to /META-INF/wicket/xyz.properties
--

Key: WICKET-5713
URL: https://issues.apache.org/jira/browse/WICKET-5713
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 6.17.0
Reporter: Martin Grigorov
Assignee: Martin Grigorov
Priority: Minor

As found at http://markmail.org/message/gzychpjelr4eshly the current location
of wicket.properties (at the root of the classpath entry) is problematic when
an uberjar is used because usually the developer doesn't know how
org.apache.wicket.IInitializer works and doesn't add code to merge the
contents of all wicket.propeties files in the classpath into one.
But even if the developer tried to merge them then it will fail again because
org.apache.wicket.Application#load(Properties) doesn't expect more than one
value per key, e.g. separated by comma.
Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/
and use more qualified names, e.g. org.apache.wicket.core.properties.
The first problem is that there are no JRE and Servlet APIs to find such
files easily. We need to scan the classpath to be able to find them and load
them.
Is this costly ?
https://github.com/ronmamo/reflections is wildly used library that provides
this functionality (and much more) and it is using the same logic and seems
to be quite fast!
So let's give it a try!
We should still support /wicket.properties for backward compatibility. We can
log a WARN message when such is found and suggest to be moved in
/META-INF/wicket/

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties


[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156465#comment-14156465
 ] 

Martin Grigorov commented on WICKET-5713:
-

Changing the extension is totally OK!

I use the IDE main power to find Java artefacts - Open IInitializer class 
(Ctrl+N) and then Show Implementations (Ctrl+Alt+B in IDEA) :-)

 Move /wicket.properties to /META-INF/wicket/xyz.properties
 --

 Key: WICKET-5713
 URL: https://issues.apache.org/jira/browse/WICKET-5713
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Affects Versions: 6.17.0
Reporter: Martin Grigorov
Assignee: Martin Grigorov
Priority: Minor

 As found at http://markmail.org/message/gzychpjelr4eshly the current location 
 of wicket.properties (at the root of the classpath entry) is problematic when 
 an uberjar is used because usually the developer doesn't know how 
 org.apache.wicket.IInitializer works and doesn't add code to merge the 
 contents of all wicket.propeties files in the classpath into one.
 But even if the developer tried to merge them then it will fail again because 
 org.apache.wicket.Application#load(Properties) doesn't expect more than one 
 value per key, e.g. separated by comma.
 Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
 and use more qualified names, e.g. org.apache.wicket.core.properties.
 The first problem is that there are no JRE and Servlet APIs to find such 
 files easily. We need to scan the classpath to be able to find them and load 
 them.
 Is this costly ?
 https://github.com/ronmamo/reflections is wildly used library that provides 
 this functionality (and much more) and it is using the same logic and seems 
 to be quite fast!
 So let's give it a try!
 We should still support /wicket.properties for backward compatibility. We can 
 log a WARN message when such is found and suggest to be moved in 
 /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

git commit: WICKET-5713 Move /wicket.properties to /META-INF/wicket/xyz.properties

2014-10-02 Thread ASF subversion and git services (JIRA)

Repository: wicket
Updated Branches:
  refs/heads/WICKET-5713-meta-inf-wicket d106598d4 - fa10aef39


WICKET-5713 Move /wicket.properties to /META-INF/wicket/xyz.properties

Minor improvements


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/fa10aef3
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/fa10aef3
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/fa10aef3

Branch: refs/heads/WICKET-5713-meta-inf-wicket
Commit: fa10aef39e23c0258738079e1d1ff90885175dc1
Parents: d106598
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Thu Oct 2 14:25:20 2014 +0200
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Thu Oct 2 14:25:20 2014 +0200

--
 .../main/java/org/apache/wicket/Application.java| 16 
 1 file changed, 8 insertions(+), 8 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/fa10aef3/wicket-core/src/main/java/org/apache/wicket/Application.java
--
diff --git a/wicket-core/src/main/java/org/apache/wicket/Application.java 
b/wicket-core/src/main/java/org/apache/wicket/Application.java
index 5376284..2bd8462 100644
--- a/wicket-core/src/main/java/org/apache/wicket/Application.java
+++ b/wicket-core/src/main/java/org/apache/wicket/Application.java
@@ -105,7 +105,6 @@ import org.apache.wicket.settings.StoreSettings;
 import org.apache.wicket.util.IProvider;
 import org.apache.wicket.util.file.File;
 import org.apache.wicket.util.file.Folder;
-import org.apache.wicket.util.io.IOUtils;
 import org.apache.wicket.util.io.Streams;
 import org.apache.wicket.util.lang.Args;
 import org.apache.wicket.util.lang.Generics;
@@ -167,6 +166,8 @@ public abstract class Application implements 
UnboundListener, IEventSink
/** Log. */
private static final Logger log = 
LoggerFactory.getLogger(Application.class);
 
+   private static final String PROPERTIES_FILE_EXTENSION = .properties;
+
/** root mapper */
private IRequestMapper rootRequestMapper;
 
@@ -485,7 +486,7 @@ public abstract class Application implements 
UnboundListener, IEventSink
 */
private void collectWicketProperties() throws IOException, 
URISyntaxException
{
-   IteratorURL wicketResources = 
getApplicationSettings().getClassResolver().getResources(META-INF/wicket);
+   IteratorURL wicketResources = 
getApplicationSettings().getClassResolver().getResources(META-INF/wicket/);
while (wicketResources.hasNext())
{
URL metaInfWicket = wicketResources.next();
@@ -493,8 +494,7 @@ public abstract class Application implements 
UnboundListener, IEventSink
 
if (jar.equals(protocol))
{
-   URLConnection urlConnection = 
metaInfWicket.openConnection();
-   JarURLConnection jarURLConnection = 
(JarURLConnection) urlConnection;
+   JarURLConnection jarURLConnection = 
(JarURLConnection) metaInfWicket.openConnection();;
JarFile jarFile = jarURLConnection.getJarFile();
EnumerationJarEntry jarEntries = 
jarFile.entries();
while (jarEntries.hasMoreElements())
@@ -503,9 +503,9 @@ public abstract class Application implements 
UnboundListener, IEventSink
String entryName = jarEntry.getName();
if 
(entryName.startsWith(META-INF/wicket/)  entryName.endsWith(.properties))
{
-   Properties properties = new 
Properties();
try (InputStream jarEntryStream 
= jarFile.getInputStream(jarEntry))
{
+   Properties properties = 
new Properties();

properties.load(jarEntryStream);
load(properties);
break; // atm there is 
no need to have more than one .properties file
@@ -522,14 +522,14 @@ public abstract class Application implements 
UnboundListener, IEventSink
public boolean accept(File file)
{
String fileName = 
file.getAbsolutePath();
-   return 
fileName.contains(/META-INF/wicket/)  fileName.endsWith(.properties);
+

[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties


[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156479#comment-14156479
 ] 

ASF subversion and git services commented on WICKET-5713:
-

Commit fa10aef39e23c0258738079e1d1ff90885175dc1 in wicket's branch 
refs/heads/WICKET-5713-meta-inf-wicket from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=fa10aef ]

WICKET-5713 Move /wicket.properties to /META-INF/wicket/xyz.properties

Minor improvements


 Move /wicket.properties to /META-INF/wicket/xyz.properties
 --

 Key: WICKET-5713
 URL: https://issues.apache.org/jira/browse/WICKET-5713
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Affects Versions: 6.17.0
Reporter: Martin Grigorov
Assignee: Martin Grigorov
Priority: Minor

 As found at http://markmail.org/message/gzychpjelr4eshly the current location 
 of wicket.properties (at the root of the classpath entry) is problematic when 
 an uberjar is used because usually the developer doesn't know how 
 org.apache.wicket.IInitializer works and doesn't add code to merge the 
 contents of all wicket.propeties files in the classpath into one.
 But even if the developer tried to merge them then it will fail again because 
 org.apache.wicket.Application#load(Properties) doesn't expect more than one 
 value per key, e.g. separated by comma.
 Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
 and use more qualified names, e.g. org.apache.wicket.core.properties.
 The first problem is that there are no JRE and Servlet APIs to find such 
 files easily. We need to scan the classpath to be able to find them and load 
 them.
 Is this costly ?
 https://github.com/ronmamo/reflections is wildly used library that provides 
 this functionality (and much more) and it is using the same logic and seems 
 to be quite fast!
 So let's give it a try!
 We should still support /wicket.properties for backward compatibility. We can 
 log a WARN message when such is found and suggest to be moved in 
 /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (WICKET-5714) MockHttpServletRequest.buildRequest() should work for parameters with multiple values with multipart content type

2014-10-02 Thread Dennis Waldherr (JIRA)

Dennis Waldherr created WICKET-5714:
---

 Summary: MockHttpServletRequest.buildRequest() should work for 
parameters with multiple values with multipart content type
 Key: WICKET-5714
 URL: https://issues.apache.org/jira/browse/WICKET-5714
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.5.11
Reporter: Dennis Waldherr


The following code in the method MockHttpServletRequest.buildRequest() iterates 
over all values of a parameter. When writing the value to the outputstream it 
doesn't use the iteration variable, but instead retrieves the value with 
post.getParameterValue(parameterName) which always returns the first element 
of the list.
{code}
ListStringValue values = 
post.getParameterValues(parameterName);
for (StringValue value : values)
{
newAttachment(out);
out.write(; name=\.getBytes());
out.write(parameterName.getBytes());
out.write(\.getBytes());
out.write(crlf.getBytes());
out.write(crlf.getBytes());

out.write(post.getParameterValue(parameterName).toString().getBytes());
out.write(crlf.getBytes());
}
{code}
So for a given list of values 3, 2 and 1, it actually writes 3, 3 and 
3.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (WICKET-5715) Allow setting 'async' attribute on reference script elements

Martin Grigorov created WICKET-5715:
---

 Summary: Allow setting 'async' attribute on reference script 
elements
 Key: WICKET-5715
 URL: https://issues.apache.org/jira/browse/WICKET-5715
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Affects Versions: 6.17.0
Reporter: Martin Grigorov
Assignee: Martin Grigorov
Priority: Minor


Add support for the new 'async' attribute on script elements - 
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script#Attributes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[7/7] git commit: WICKET-5715 Allow setting 'async' attribute on reference script elements

2014-10-02 Thread ASF subversion and git services (JIRA)

WICKET-5715 Allow setting 'async' attribute on reference script elements


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/f6ee84e5
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/f6ee84e5
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/f6ee84e5

Branch: refs/heads/master
Commit: f6ee84e5f855252a38aab6a84ae40f70017c257d
Parents: 51864c6
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Thu Oct 2 14:46:34 2014 +0200
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Thu Oct 2 14:47:08 2014 +0200

--
 .../core/util/string/JavaScriptUtils.java   | 34 +++-
 .../AbstractJavaScriptReferenceHeaderItem.java  | 89 
 .../markup/head/JavaScriptHeaderItem.java   |  4 +-
 .../head/JavaScriptReferenceHeaderItem.java | 27 +-
 .../head/JavaScriptUrlReferenceHeaderItem.java  | 28 +-
 .../core/util/string/JavaScriptUtilsTest.java   | 19 +
 6 files changed, 147 insertions(+), 54 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/f6ee84e5/wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java
 
b/wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java
index 098efed..b95c531 100644
--- 
a/wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java
@@ -109,7 +109,28 @@ public class JavaScriptUtils
public static void writeJavaScriptUrl(final Response response, final 
CharSequence url,
final String id)
{
-   writeJavaScriptUrl(response, url, id, false, null);
+   writeJavaScriptUrl(response, url, id, false, null, false);
+   }
+
+   /**
+* Write a reference to a javascript file to the response object
+*
+* @param response
+*The HTTP response
+* @param url
+*The javascript file URL
+* @param id
+*Unique identifier of element
+* @param defer
+*specifies that the execution of a script should be 
deferred (delayed) until after
+*the page has been loaded.
+* @param charset
+*a non null value specifies the charset attribute of the 
script tag
+*/
+   public static void writeJavaScriptUrl(final Response response, final 
CharSequence url,
+ final String id, boolean defer, 
String charset)
+   {
+   writeJavaScriptUrl(response, url, id, defer, charset, false);
}
 
/**
@@ -126,9 +147,11 @@ public class JavaScriptUtils
 *the page has been loaded.
 * @param charset
 *a non null value specifies the charset attribute of the 
script tag
+* @param async
+*specifies that the script can be loaded asynchronously by 
the browser
 */
public static void writeJavaScriptUrl(final Response response, final 
CharSequence url,
-   final String id, boolean defer, String charset)
+   final String id, boolean defer, String charset, boolean async)
{
response.write(script type=\text/javascript\ );
if (id != null)
@@ -139,6 +162,12 @@ public class JavaScriptUtils
{
response.write(defer=\defer\ );
}
+
+   if (async)
+   {
+   response.write(async=\async\ );
+   }
+
if (charset != null)
{
response.write(charset=\ + 
Strings.escapeMarkup(charset) + \ );
@@ -225,7 +254,6 @@ public class JavaScriptUtils
{
response.write(SCRIPT_CONTENT_SUFFIX);
response.write(/script\n);
-
}
 
/**

http://git-wip-us.apache.org/repos/asf/wicket/blob/f6ee84e5/wicket-core/src/main/java/org/apache/wicket/markup/head/AbstractJavaScriptReferenceHeaderItem.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/markup/head/AbstractJavaScriptReferenceHeaderItem.java
 
b/wicket-core/src/main/java/org/apache/wicket/markup/head/AbstractJavaScriptReferenceHeaderItem.java
new file mode 100644
index 000..06f898d
--- /dev/null
+++ 
b/wicket-core/src/main/java/org/apache/wicket/markup/head/AbstractJavaScriptReferenceHeaderItem.java
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache

[jira] [Commented] (WICKET-5715) Allow setting 'async' attribute on reference script elements


[ 
https://issues.apache.org/jira/browse/WICKET-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156494#comment-14156494
 ] 

ASF subversion and git services commented on WICKET-5715:
-

Commit f6ee84e5f855252a38aab6a84ae40f70017c257d in wicket's branch 
refs/heads/master from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=f6ee84e ]

WICKET-5715 Allow setting 'async' attribute on reference script elements


 Allow setting 'async' attribute on reference script elements
 --

 Key: WICKET-5715
 URL: https://issues.apache.org/jira/browse/WICKET-5715
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Affects Versions: 6.17.0
Reporter: Martin Grigorov
Assignee: Martin Grigorov
Priority: Minor

 Add support for the new 'async' attribute on script elements - 
 https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script#Attributes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[4/7] git commit: Fix javadoc warning

Fix javadoc warning


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/203fb421
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/203fb421
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/203fb421

Branch: refs/heads/master
Commit: 203fb42111de9161eb6b860aaf2ba070a4820094
Parents: f4df2c2
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Thu Oct 2 12:24:27 2014 +0200
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Thu Oct 2 14:47:07 2014 +0200

--
 .../java/org/apache/wicket/request/resource/PackageResource.java   | 2 --
 1 file changed, 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/203fb421/wicket-core/src/main/java/org/apache/wicket/request/resource/PackageResource.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/request/resource/PackageResource.java
 
b/wicket-core/src/main/java/org/apache/wicket/request/resource/PackageResource.java
index 162f75c..503e8cf 100644
--- 
a/wicket-core/src/main/java/org/apache/wicket/request/resource/PackageResource.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/request/resource/PackageResource.java
@@ -515,8 +515,6 @@ public class PackageResource extends AbstractResource 
implements IStaticCacheabl
 * By default IPackageResourceGuard is used to check the permissions but
 * the resource itself can also make the check.
 *
-* @param scope
-*resource scope
 * @param path
 *resource path
 * @return codetruecode if resource access is granted

[6/7] git commit: Java 7 diamonds

Java 7 diamonds


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/51864c6e
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/51864c6e
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/51864c6e

Branch: refs/heads/master
Commit: 51864c6e2273bbec2e35988ab5bbf29c6569b77e
Parents: 03464f6
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Thu Oct 2 12:28:41 2014 +0200
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Thu Oct 2 14:47:08 2014 +0200

--
 .../org/apache/wicket/core/util/resource/UrlResourceStream.java   | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/51864c6e/wicket-core/src/main/java/org/apache/wicket/core/util/resource/UrlResourceStream.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/core/util/resource/UrlResourceStream.java
 
b/wicket-core/src/main/java/org/apache/wicket/core/util/resource/UrlResourceStream.java
index 199ef6d..e9d751c 100644
--- 
a/wicket-core/src/main/java/org/apache/wicket/core/util/resource/UrlResourceStream.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/core/util/resource/UrlResourceStream.java
@@ -98,7 +98,6 @@ public class UrlResourceStream extends AbstractResourceStream
 */
public UrlResourceStream(final URL url)
{
-   // save the url
this.url = Args.notNull(url, url);
}
 
@@ -179,7 +178,7 @@ public class UrlResourceStream extends 
AbstractResourceStream
StreamData data = getData(true);
InputStream is = data.connection.getInputStream();
if (data.inputStreams == null) {
-   data.inputStreams = new 
ArrayListInputStream();
+   data.inputStreams = new ArrayList();
}
data.inputStreams.add(is);
return is;

[3/7] git commit: Remove unused logger

Remove unused logger


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/53f47976
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/53f47976
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/53f47976

Branch: refs/heads/master
Commit: 53f479766ebfba449774d8f179673f8f33104698
Parents: 145da02
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Thu Oct 2 12:22:54 2014 +0200
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Thu Oct 2 14:47:07 2014 +0200

--
 .../wicket/resource/loader/InitializerStringResourceLoader.java | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/53f47976/wicket-core/src/main/java/org/apache/wicket/resource/loader/InitializerStringResourceLoader.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/resource/loader/InitializerStringResourceLoader.java
 
b/wicket-core/src/main/java/org/apache/wicket/resource/loader/InitializerStringResourceLoader.java
index 4ae33d4..4e4c84c 100644
--- 
a/wicket-core/src/main/java/org/apache/wicket/resource/loader/InitializerStringResourceLoader.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/resource/loader/InitializerStringResourceLoader.java
@@ -41,9 +41,6 @@ import org.slf4j.LoggerFactory;
  */
 public class InitializerStringResourceLoader extends 
ComponentStringResourceLoader
 {
-   /** Log. */
-   private static final Logger log = 
LoggerFactory.getLogger(InitializerStringResourceLoader.class);
-
private ListIInitializer initializers;
 
/**
@@ -91,4 +88,4 @@ public class InitializerStringResourceLoader extends 
ComponentStringResourceLoad
{
return loadStringResource((Class?)null, key, locale, style, 
variation);
}
-}
\ No newline at end of file
+}

[1/7] git commit: Fix javadoc error

Repository: wicket
Updated Branches:
  refs/heads/master 145da0212 - f6ee84e5f


Fix javadoc error


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/8daa3767
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/8daa3767
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/8daa3767

Branch: refs/heads/master
Commit: 8daa376732cc1dea7a85b2dd9cf1da7571ee04dd
Parents: 203fb42
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Thu Oct 2 12:25:25 2014 +0200
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Thu Oct 2 14:47:07 2014 +0200

--
 .../examples/authentication3/MyAuthenticatedWebSession.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/8daa3767/wicket-examples/src/main/java/org/apache/wicket/examples/authentication3/MyAuthenticatedWebSession.java
--
diff --git 
a/wicket-examples/src/main/java/org/apache/wicket/examples/authentication3/MyAuthenticatedWebSession.java
 
b/wicket-examples/src/main/java/org/apache/wicket/examples/authentication3/MyAuthenticatedWebSession.java
index 2ce3a56..4309eef 100644
--- 
a/wicket-examples/src/main/java/org/apache/wicket/examples/authentication3/MyAuthenticatedWebSession.java
+++ 
b/wicket-examples/src/main/java/org/apache/wicket/examples/authentication3/MyAuthenticatedWebSession.java
@@ -41,7 +41,7 @@ public class MyAuthenticatedWebSession extends 
AuthenticatedWebSession
}
 
/**
-* @see 
org.apache.wicket.authentication.AuthenticatedWebSession#authenticate(java.lang.String,
+* @see 
org.apache.wicket.authroles.authentication.AuthenticatedWebSession#authenticate(java.lang.String,
 *  java.lang.String)
 */
@Override
@@ -54,7 +54,7 @@ public class MyAuthenticatedWebSession extends 
AuthenticatedWebSession
}
 
/**
-* @see 
org.apache.wicket.authentication.AuthenticatedWebSession#getRoles()
+* @see 
org.apache.wicket.authroles.authentication.AuthenticatedWebSession#getRoles()
 */
@Override
public Roles getRoles()

[2/7] git commit: Make resourceStream final

Make resourceStream final


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/f4df2c27
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/f4df2c27
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/f4df2c27

Branch: refs/heads/master
Commit: f4df2c2704265d643d3373a91b89cff043aaffcd
Parents: 53f4797
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Thu Oct 2 12:23:59 2014 +0200
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Thu Oct 2 14:47:07 2014 +0200

--
 .../apache/wicket/core/util/resource/PackageResourceStream.java| 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/f4df2c27/wicket-core/src/main/java/org/apache/wicket/core/util/resource/PackageResourceStream.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/core/util/resource/PackageResourceStream.java
 
b/wicket-core/src/main/java/org/apache/wicket/core/util/resource/PackageResourceStream.java
index 770d29b..e76926d 100644
--- 
a/wicket-core/src/main/java/org/apache/wicket/core/util/resource/PackageResourceStream.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/core/util/resource/PackageResourceStream.java
@@ -42,7 +42,7 @@ public class PackageResourceStream extends 
AbstractResourceStream
/** */
private static final long serialVersionUID = 1L;
 
-   private IResourceStream resourceStream;
+   private final IResourceStream resourceStream;
 
/**
 * Obtains an {@link IResourceStream} from the application's

[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties


[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156557#comment-14156557
 ] 

Sven Meier commented on WICKET-5713:


That IDE power will show you all IInitializers, but not the registered ones.

 Move /wicket.properties to /META-INF/wicket/xyz.properties
 --

 Key: WICKET-5713
 URL: https://issues.apache.org/jira/browse/WICKET-5713
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Affects Versions: 6.17.0
Reporter: Martin Grigorov
Assignee: Martin Grigorov
Priority: Minor

 As found at http://markmail.org/message/gzychpjelr4eshly the current location 
 of wicket.properties (at the root of the classpath entry) is problematic when 
 an uberjar is used because usually the developer doesn't know how 
 org.apache.wicket.IInitializer works and doesn't add code to merge the 
 contents of all wicket.propeties files in the classpath into one.
 But even if the developer tried to merge them then it will fail again because 
 org.apache.wicket.Application#load(Properties) doesn't expect more than one 
 value per key, e.g. separated by comma.
 Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
 and use more qualified names, e.g. org.apache.wicket.core.properties.
 The first problem is that there are no JRE and Servlet APIs to find such 
 files easily. We need to scan the classpath to be able to find them and load 
 them.
 Is this costly ?
 https://github.com/ronmamo/reflections is wildly used library that provides 
 this functionality (and much more) and it is using the same logic and seems 
 to be quite fast!
 So let's give it a try!
 We should still support /wicket.properties for backward compatibility. We can 
 log a WARN message when such is found and suggest to be moved in 
 /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

git commit: WICKET-5715 Allow setting 'async' attribute on reference script elements

2014-10-02 Thread ASF subversion and git services (JIRA)

Repository: wicket
Updated Branches:
  refs/heads/wicket-6.x a05aa4cae - ff1ad079c


WICKET-5715 Allow setting 'async' attribute on reference script elements

(cherry picked from commit eeae249a95926027184b551239b46586a05848fc)


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/ff1ad079
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/ff1ad079
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/ff1ad079

Branch: refs/heads/wicket-6.x
Commit: ff1ad079c450d024daa637faa4e3438f3b3e88c0
Parents: a05aa4c
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Thu Oct 2 14:46:34 2014 +0200
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Thu Oct 2 15:07:13 2014 +0200

--
 .../core/util/string/JavaScriptUtils.java   | 34 +++-
 .../AbstractJavaScriptReferenceHeaderItem.java  | 89 
 .../markup/head/JavaScriptHeaderItem.java   | 18 +++-
 .../head/JavaScriptReferenceHeaderItem.java | 27 +-
 .../head/JavaScriptUrlReferenceHeaderItem.java  | 28 +-
 .../core/util/string/JavaScriptUtilsTest.java   | 19 +
 6 files changed, 161 insertions(+), 54 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/ff1ad079/wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java
 
b/wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java
index 098efed..b95c531 100644
--- 
a/wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java
@@ -109,7 +109,28 @@ public class JavaScriptUtils
public static void writeJavaScriptUrl(final Response response, final 
CharSequence url,
final String id)
{
-   writeJavaScriptUrl(response, url, id, false, null);
+   writeJavaScriptUrl(response, url, id, false, null, false);
+   }
+
+   /**
+* Write a reference to a javascript file to the response object
+*
+* @param response
+*The HTTP response
+* @param url
+*The javascript file URL
+* @param id
+*Unique identifier of element
+* @param defer
+*specifies that the execution of a script should be 
deferred (delayed) until after
+*the page has been loaded.
+* @param charset
+*a non null value specifies the charset attribute of the 
script tag
+*/
+   public static void writeJavaScriptUrl(final Response response, final 
CharSequence url,
+ final String id, boolean defer, 
String charset)
+   {
+   writeJavaScriptUrl(response, url, id, defer, charset, false);
}
 
/**
@@ -126,9 +147,11 @@ public class JavaScriptUtils
 *the page has been loaded.
 * @param charset
 *a non null value specifies the charset attribute of the 
script tag
+* @param async
+*specifies that the script can be loaded asynchronously by 
the browser
 */
public static void writeJavaScriptUrl(final Response response, final 
CharSequence url,
-   final String id, boolean defer, String charset)
+   final String id, boolean defer, String charset, boolean async)
{
response.write(script type=\text/javascript\ );
if (id != null)
@@ -139,6 +162,12 @@ public class JavaScriptUtils
{
response.write(defer=\defer\ );
}
+
+   if (async)
+   {
+   response.write(async=\async\ );
+   }
+
if (charset != null)
{
response.write(charset=\ + 
Strings.escapeMarkup(charset) + \ );
@@ -225,7 +254,6 @@ public class JavaScriptUtils
{
response.write(SCRIPT_CONTENT_SUFFIX);
response.write(/script\n);
-
}
 
/**

http://git-wip-us.apache.org/repos/asf/wicket/blob/ff1ad079/wicket-core/src/main/java/org/apache/wicket/markup/head/AbstractJavaScriptReferenceHeaderItem.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/markup/head/AbstractJavaScriptReferenceHeaderItem.java
 
b/wicket-core/src/main/java/org/apache/wicket/markup/head/AbstractJavaScriptReferenceHeaderItem.java
new file mode 100644
index 000..06f898d
---

[jira] [Commented] (WICKET-5715) Allow setting 'async' attribute on reference script elements


[ 
https://issues.apache.org/jira/browse/WICKET-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156558#comment-14156558
 ] 

ASF subversion and git services commented on WICKET-5715:
-

Commit ff1ad079c450d024daa637faa4e3438f3b3e88c0 in wicket's branch 
refs/heads/wicket-6.x from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=ff1ad07 ]

WICKET-5715 Allow setting 'async' attribute on reference script elements

(cherry picked from commit eeae249a95926027184b551239b46586a05848fc)


 Allow setting 'async' attribute on reference script elements
 --

 Key: WICKET-5715
 URL: https://issues.apache.org/jira/browse/WICKET-5715
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Affects Versions: 6.17.0
Reporter: Martin Grigorov
Assignee: Martin Grigorov
Priority: Minor

 Add support for the new 'async' attribute on script elements - 
 https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script#Attributes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (WICKET-5715) Allow setting 'async' attribute on reference script elements


 [ 
https://issues.apache.org/jira/browse/WICKET-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov resolved WICKET-5715.
-
   Resolution: Fixed
Fix Version/s: 7.0.0-M4
   6.18.0

 Allow setting 'async' attribute on reference script elements
 --

 Key: WICKET-5715
 URL: https://issues.apache.org/jira/browse/WICKET-5715
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Affects Versions: 6.17.0
Reporter: Martin Grigorov
Assignee: Martin Grigorov
Priority: Minor
 Fix For: 6.18.0, 7.0.0-M4


 Add support for the new 'async' attribute on script elements - 
 https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script#Attributes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (WICKET-5714) MockHttpServletRequest.buildRequest() should work for parameters with multiple values with multipart content type


 [ 
https://issues.apache.org/jira/browse/WICKET-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov reassigned WICKET-5714:
---

Assignee: Martin Grigorov

 MockHttpServletRequest.buildRequest() should work for parameters with 
 multiple values with multipart content type
 -

 Key: WICKET-5714
 URL: https://issues.apache.org/jira/browse/WICKET-5714
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.5.11
Reporter: Dennis Waldherr
Assignee: Martin Grigorov

 The following code in the method MockHttpServletRequest.buildRequest() 
 iterates over all values of a parameter. When writing the value to the 
 outputstream it doesn't use the iteration variable, but instead retrieves the 
 value with post.getParameterValue(parameterName) which always returns the 
 first element of the list.
 {code}
   ListStringValue values = 
 post.getParameterValues(parameterName);
   for (StringValue value : values)
   {
   newAttachment(out);
   out.write(; name=\.getBytes());
   out.write(parameterName.getBytes());
   out.write(\.getBytes());
   out.write(crlf.getBytes());
   out.write(crlf.getBytes());
   
 out.write(post.getParameterValue(parameterName).toString().getBytes());
   out.write(crlf.getBytes());
   }
 {code}
 So for a given list of values 3, 2 and 1, it actually writes 3, 3 
 and 3.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

git commit: WICKET-5714 MockHttpServletRequest.buildRequest() should work for parameters with multiple values with multipart content type

Repository: wicket
Updated Branches:
  refs/heads/wicket-1.5.x 18787f8ba - fb1f57f4d


WICKET-5714 MockHttpServletRequest.buildRequest() should work for parameters 
with multiple values with multipart content type


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/fb1f57f4
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/fb1f57f4
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/fb1f57f4

Branch: refs/heads/wicket-1.5.x
Commit: fb1f57f4d2be9534580b3a8e54ce98eb07adf77f
Parents: 18787f8
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Thu Oct 2 15:14:55 2014 +0200
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Thu Oct 2 15:14:55 2014 +0200

--
 .../apache/wicket/protocol/http/mock/MockHttpServletRequest.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/fb1f57f4/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
 
b/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
index 79ee45d..62c038d 100755
--- 
a/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
@@ -1581,7 +1581,7 @@ public class MockHttpServletRequest implements 
HttpServletRequest
out.write(\.getBytes());
out.write(crlf.getBytes());
out.write(crlf.getBytes());
-   
out.write(post.getParameterValue(parameterName).toString().getBytes());
+   out.write(value.toString().getBytes());
out.write(crlf.getBytes());
}
}

git commit: WICKET-5714 MockHttpServletRequest.buildRequest() should work for parameters with multiple values with multipart content type

2014-10-02 Thread ASF subversion and git services (JIRA)

Repository: wicket
Updated Branches:
  refs/heads/wicket-6.x ff1ad079c - 7ee559486


WICKET-5714 MockHttpServletRequest.buildRequest() should work for parameters 
with multiple values with multipart content type

(cherry picked from commit fb1f57f4d2be9534580b3a8e54ce98eb07adf77f)


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/7ee55948
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/7ee55948
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/7ee55948

Branch: refs/heads/wicket-6.x
Commit: 7ee559486f53c62947171a150508893c9a5d16d1
Parents: ff1ad07
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Thu Oct 2 15:14:55 2014 +0200
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Thu Oct 2 15:15:12 2014 +0200

--
 .../apache/wicket/protocol/http/mock/MockHttpServletRequest.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/7ee55948/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
 
b/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
index 7088d31..66287ff 100755
--- 
a/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
@@ -1634,7 +1634,7 @@ public class MockHttpServletRequest implements 
HttpServletRequest
out.write(\.getBytes());
out.write(crlf.getBytes());
out.write(crlf.getBytes());
-   
out.write(post.getParameterValue(parameterName).toString().getBytes());
+   out.write(value.toString().getBytes());
out.write(crlf.getBytes());
}
}

[jira] [Commented] (WICKET-5714) MockHttpServletRequest.buildRequest() should work for parameters with multiple values with multipart content type


[ 
https://issues.apache.org/jira/browse/WICKET-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156563#comment-14156563
 ] 

ASF subversion and git services commented on WICKET-5714:
-

Commit 41e71f9de5d84f24b80da12d2c5bd76216a5cf00 in wicket's branch 
refs/heads/master from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=41e71f9 ]

WICKET-5714 MockHttpServletRequest.buildRequest() should work for parameters 
with multiple values with multipart content type

(cherry picked from commit fb1f57f4d2be9534580b3a8e54ce98eb07adf77f)


 MockHttpServletRequest.buildRequest() should work for parameters with 
 multiple values with multipart content type
 -

 Key: WICKET-5714
 URL: https://issues.apache.org/jira/browse/WICKET-5714
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.5.11
Reporter: Dennis Waldherr
Assignee: Martin Grigorov

 The following code in the method MockHttpServletRequest.buildRequest() 
 iterates over all values of a parameter. When writing the value to the 
 outputstream it doesn't use the iteration variable, but instead retrieves the 
 value with post.getParameterValue(parameterName) which always returns the 
 first element of the list.
 {code}
   ListStringValue values = 
 post.getParameterValues(parameterName);
   for (StringValue value : values)
   {
   newAttachment(out);
   out.write(; name=\.getBytes());
   out.write(parameterName.getBytes());
   out.write(\.getBytes());
   out.write(crlf.getBytes());
   out.write(crlf.getBytes());
   
 out.write(post.getParameterValue(parameterName).toString().getBytes());
   out.write(crlf.getBytes());
   }
 {code}
 So for a given list of values 3, 2 and 1, it actually writes 3, 3 
 and 3.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WICKET-5714) MockHttpServletRequest.buildRequest() should work for parameters with multiple values with multipart content type

2014-10-02 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/WICKET-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156562#comment-14156562
 ] 

ASF subversion and git services commented on WICKET-5714:
-

Commit 7ee559486f53c62947171a150508893c9a5d16d1 in wicket's branch 
refs/heads/wicket-6.x from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=7ee5594 ]

WICKET-5714 MockHttpServletRequest.buildRequest() should work for parameters 
with multiple values with multipart content type

(cherry picked from commit fb1f57f4d2be9534580b3a8e54ce98eb07adf77f)


 MockHttpServletRequest.buildRequest() should work for parameters with 
 multiple values with multipart content type
 -

 Key: WICKET-5714
 URL: https://issues.apache.org/jira/browse/WICKET-5714
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.5.11
Reporter: Dennis Waldherr
Assignee: Martin Grigorov

 The following code in the method MockHttpServletRequest.buildRequest() 
 iterates over all values of a parameter. When writing the value to the 
 outputstream it doesn't use the iteration variable, but instead retrieves the 
 value with post.getParameterValue(parameterName) which always returns the 
 first element of the list.
 {code}
   ListStringValue values = 
 post.getParameterValues(parameterName);
   for (StringValue value : values)
   {
   newAttachment(out);
   out.write(; name=\.getBytes());
   out.write(parameterName.getBytes());
   out.write(\.getBytes());
   out.write(crlf.getBytes());
   out.write(crlf.getBytes());
   
 out.write(post.getParameterValue(parameterName).toString().getBytes());
   out.write(crlf.getBytes());
   }
 {code}
 So for a given list of values 3, 2 and 1, it actually writes 3, 3 
 and 3.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

git commit: WICKET-5714 MockHttpServletRequest.buildRequest() should work for parameters with multiple values with multipart content type

2014-10-02 Thread ASF subversion and git services (JIRA)

Repository: wicket
Updated Branches:
  refs/heads/master f6ee84e5f - 41e71f9de


WICKET-5714 MockHttpServletRequest.buildRequest() should work for parameters 
with multiple values with multipart content type

(cherry picked from commit fb1f57f4d2be9534580b3a8e54ce98eb07adf77f)


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/41e71f9d
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/41e71f9d
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/41e71f9d

Branch: refs/heads/master
Commit: 41e71f9de5d84f24b80da12d2c5bd76216a5cf00
Parents: f6ee84e
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Thu Oct 2 15:14:55 2014 +0200
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Thu Oct 2 15:15:20 2014 +0200

--
 .../apache/wicket/protocol/http/mock/MockHttpServletRequest.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/41e71f9d/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
 
b/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
index 5baddfa..5acc2a5 100755
--- 
a/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
@@ -1672,7 +1672,7 @@ public class MockHttpServletRequest implements 
HttpServletRequest
out.write(\.getBytes());
out.write(crlf.getBytes());
out.write(crlf.getBytes());
-   
out.write(post.getParameterValue(parameterName).toString().getBytes());
+   out.write(value.toString().getBytes());
out.write(crlf.getBytes());
}
}

[jira] [Commented] (WICKET-5714) MockHttpServletRequest.buildRequest() should work for parameters with multiple values with multipart content type


[ 
https://issues.apache.org/jira/browse/WICKET-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156561#comment-14156561
 ] 

ASF subversion and git services commented on WICKET-5714:
-

Commit fb1f57f4d2be9534580b3a8e54ce98eb07adf77f in wicket's branch 
refs/heads/wicket-1.5.x from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=fb1f57f ]

WICKET-5714 MockHttpServletRequest.buildRequest() should work for parameters 
with multiple values with multipart content type


 MockHttpServletRequest.buildRequest() should work for parameters with 
 multiple values with multipart content type
 -

 Key: WICKET-5714
 URL: https://issues.apache.org/jira/browse/WICKET-5714
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.5.11
Reporter: Dennis Waldherr
Assignee: Martin Grigorov

 The following code in the method MockHttpServletRequest.buildRequest() 
 iterates over all values of a parameter. When writing the value to the 
 outputstream it doesn't use the iteration variable, but instead retrieves the 
 value with post.getParameterValue(parameterName) which always returns the 
 first element of the list.
 {code}
   ListStringValue values = 
 post.getParameterValues(parameterName);
   for (StringValue value : values)
   {
   newAttachment(out);
   out.write(; name=\.getBytes());
   out.write(parameterName.getBytes());
   out.write(\.getBytes());
   out.write(crlf.getBytes());
   out.write(crlf.getBytes());
   
 out.write(post.getParameterValue(parameterName).toString().getBytes());
   out.write(crlf.getBytes());
   }
 {code}
 So for a given list of values 3, 2 and 1, it actually writes 3, 3 
 and 3.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (WICKET-5714) MockHttpServletRequest.buildRequest() should work for parameters with multiple values with multipart content type


 [ 
https://issues.apache.org/jira/browse/WICKET-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov resolved WICKET-5714.
-
   Resolution: Fixed
Fix Version/s: 7.0.0-M4
   1.5.13
   6.18.0

Fixed!
Thank you!

 MockHttpServletRequest.buildRequest() should work for parameters with 
 multiple values with multipart content type
 -

 Key: WICKET-5714
 URL: https://issues.apache.org/jira/browse/WICKET-5714
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.5.11
Reporter: Dennis Waldherr
Assignee: Martin Grigorov
 Fix For: 6.18.0, 1.5.13, 7.0.0-M4


 The following code in the method MockHttpServletRequest.buildRequest() 
 iterates over all values of a parameter. When writing the value to the 
 outputstream it doesn't use the iteration variable, but instead retrieves the 
 value with post.getParameterValue(parameterName) which always returns the 
 first element of the list.
 {code}
   ListStringValue values = 
 post.getParameterValues(parameterName);
   for (StringValue value : values)
   {
   newAttachment(out);
   out.write(; name=\.getBytes());
   out.write(parameterName.getBytes());
   out.write(\.getBytes());
   out.write(crlf.getBytes());
   out.write(crlf.getBytes());
   
 out.write(post.getParameterValue(parameterName).toString().getBytes());
   out.write(crlf.getBytes());
   }
 {code}
 So for a given list of values 3, 2 and 1, it actually writes 3, 3 
 and 3.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

[
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156572#comment-14156572
]

Martin Grigorov commented on WICKET-5713:
-

Are there not registered ones ?
org.apache.wicket.extensions.ajax.markup.html.form.upload.UploadProgressBar.ComponentInitializer
is registered transitively, for example. Your way won't show it as registered
one unless you open and read the content of
org.apache.wicket.extensions.Initializer.
Anyway, you have your ways, and I have mine ...

By changing the file extension to '.initializer' we will make this Properties
file's purpose solely for IInitializers (by looking at the file name).
At the moment there is no need to use it for something else but in the future
there may appear one ...

Move /wicket.properties to /META-INF/wicket/xyz.properties
--

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

git commit: Upgrade Spring to 4.1.1 and m-javadoc-p to 2.10.1

Repository: wicket
Updated Branches:
  refs/heads/master 41e71f9de - d998c7fe6


Upgrade Spring to 4.1.1 and m-javadoc-p to 2.10.1


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/d998c7fe
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/d998c7fe
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/d998c7fe

Branch: refs/heads/master
Commit: d998c7fe6c4f88ac215b6adc1b30fac27576845c
Parents: 41e71f9
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Thu Oct 2 15:36:12 2014 +0200
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Thu Oct 2 15:36:12 2014 +0200

--
 pom.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/d998c7fe/pom.xml
--
diff --git a/pom.xml b/pom.xml
index e3f40f2..9c76321 100644
--- a/pom.xml
+++ b/pom.xml
@@ -118,9 +118,9 @@
jacoco.version0.7.1.201405082137/jacoco.version
jetty.version8.1.16.v20140903/jetty.version
jetty9.version9.0.7.v20131107/jetty9.version
-   spring.version4.1.0.RELEASE/spring.version
+   spring.version4.1.1.RELEASE/spring.version
servlet-api.version3.0.1/servlet-api.version
-   maven.javadoc.version2.9.1/maven.javadoc.version
+   maven.javadoc.version2.10.1/maven.javadoc.version
maven.surefire.version2.17/maven.surefire.version
mockito.version1.9.5/mockito.version
slf4j.version1.7.7/slf4j.version

git commit: Remove unused m-clover-p. Move yuicompressor-m-p's configuration in the plugin (out of pluginManagement)

Repository: wicket
Updated Branches:
  refs/heads/master d998c7fe6 - 16152d8f0


Remove unused m-clover-p. Move yuicompressor-m-p's configuration in the plugin 
(out of pluginManagement)


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/16152d8f
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/16152d8f
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/16152d8f

Branch: refs/heads/master
Commit: 16152d8f0fa543f66779683f8355dcd30335beb4
Parents: d998c7f
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Thu Oct 2 15:40:53 2014 +0200
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Thu Oct 2 15:40:53 2014 +0200

--
 wicket-core/pom.xml | 22 +-
 1 file changed, 5 insertions(+), 17 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/16152d8f/wicket-core/pom.xml
--
diff --git a/wicket-core/pom.xml b/wicket-core/pom.xml
index 7d3d98c..bf6006d 100644
--- a/wicket-core/pom.xml
+++ b/wicket-core/pom.xml
@@ -72,24 +72,12 @@
plugin
groupIdnet.alchim31.maven/groupId

artifactIdyuicompressor-maven-plugin/artifactId
-   /plugin
-   plugin
-   groupIdorg.apache.maven.plugins/groupId
-   artifactIdmaven-clover-plugin/artifactId
+   configuration
+   excludes
+   exclude**/jquery*.js/exclude
+   /excludes
+   /configuration
/plugin
/plugins
-   pluginManagement
-   plugins
-   plugin
-   groupIdnet.alchim31.maven/groupId
-   
artifactIdyuicompressor-maven-plugin/artifactId
-   configuration
-   excludes
-   exclude**/jquery*.js/exclude
-   /excludes
-   /configuration
-   /plugin
-   /plugins
-   /pluginManagement
/build
 /project

[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

2014-10-02 Thread Andrea Del Bene (JIRA)


[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156587#comment-14156587
 ] 

Andrea Del Bene commented on WICKET-5713:
-

so no additional dependency on reflections, right?

 Move /wicket.properties to /META-INF/wicket/xyz.properties
 --

 Key: WICKET-5713
 URL: https://issues.apache.org/jira/browse/WICKET-5713
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
Affects Versions: 6.17.0
Reporter: Martin Grigorov
Assignee: Martin Grigorov
Priority: Minor

 As found at http://markmail.org/message/gzychpjelr4eshly the current location 
 of wicket.properties (at the root of the classpath entry) is problematic when 
 an uberjar is used because usually the developer doesn't know how 
 org.apache.wicket.IInitializer works and doesn't add code to merge the 
 contents of all wicket.propeties files in the classpath into one.
 But even if the developer tried to merge them then it will fail again because 
 org.apache.wicket.Application#load(Properties) doesn't expect more than one 
 value per key, e.g. separated by comma.
 Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
 and use more qualified names, e.g. org.apache.wicket.core.properties.
 The first problem is that there are no JRE and Servlet APIs to find such 
 files easily. We need to scan the classpath to be able to find them and load 
 them.
 Is this costly ?
 https://github.com/ronmamo/reflections is wildly used library that provides 
 this functionality (and much more) and it is using the same logic and seems 
 to be quite fast!
 So let's give it a try!
 We should still support /wicket.properties for backward compatibility. We can 
 log a WARN message when such is found and suggest to be moved in 
 /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

[
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156590#comment-14156590
]

Martin Grigorov commented on WICKET-5713:
-

No. No new dependencies.
It is manual traversal of the content of .jar that has /META-INF/wicket/ folder
entry inside.
There is no way to traverse only the files inside /META-INF/wicket/ so all
entries in the jar are visited. Once the properties file is found we break the
traversal.
I don't see noticeable delay in Maven build. And it is done only at application
start time so it should not hurt.

Move /wicket.properties to /META-INF/wicket/xyz.properties
--

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (WICKET-5716) wicket-autocomplete prevents change-listener when leaving input via mouse click

Sven Meier created WICKET-5716:
--

 Summary: wicket-autocomplete prevents change-listener when 
leaving input via mouse click
 Key: WICKET-5716
 URL: https://issues.apache.org/jira/browse/WICKET-5716
 Project: Wicket
  Issue Type: Bug
  Components: wicket-extensions
Affects Versions: 6.17.0, 7.0.0-M3
Reporter: Sven Meier


wicket-autocomplete's ignoreChange is true initially, this prevents change 
events being fired when the user enters something and then clicks somewhere else



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

git commit: Update the ciManagement data

Repository: wicket
Updated Branches:
  refs/heads/master 16152d8f0 - e87e47add


Update the ciManagement data


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/e87e47ad
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/e87e47ad
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/e87e47ad

Branch: refs/heads/master
Commit: e87e47addf933fb17557ae198abe3c4d2ebbd132
Parents: 16152d8
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Thu Oct 2 16:09:10 2014 +0200
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Thu Oct 2 16:09:10 2014 +0200

--
 pom.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/e87e47ad/pom.xml
--
diff --git a/pom.xml b/pom.xml
index 9c76321..a5f4a0d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -45,8 +45,8 @@
/organization
inceptionYear2006/inceptionYear
ciManagement
-   systemhudson/system
-   
urlhttps://hudson.apache.org/hudson/job/Apache%20Wicket%201.5.x//url
+   systemBuildBot/system
+   urlhttp://ci.apache.org/builders/wicket-master/url
/ciManagement
mailingLists
mailingList

[jira] [Commented] (WICKET-5714) MockHttpServletRequest.buildRequest() should work for parameters with multiple values with multipart content type

2014-10-02 Thread Dennis Waldherr (JIRA)


[ 
https://issues.apache.org/jira/browse/WICKET-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156609#comment-14156609
 ] 

Dennis Waldherr commented on WICKET-5714:
-

Thanks, that was quick :)

 MockHttpServletRequest.buildRequest() should work for parameters with 
 multiple values with multipart content type
 -

 Key: WICKET-5714
 URL: https://issues.apache.org/jira/browse/WICKET-5714
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.5.11
Reporter: Dennis Waldherr
Assignee: Martin Grigorov
 Fix For: 6.18.0, 1.5.13, 7.0.0-M4


 The following code in the method MockHttpServletRequest.buildRequest() 
 iterates over all values of a parameter. When writing the value to the 
 outputstream it doesn't use the iteration variable, but instead retrieves the 
 value with post.getParameterValue(parameterName) which always returns the 
 first element of the list.
 {code}
   ListStringValue values = 
 post.getParameterValues(parameterName);
   for (StringValue value : values)
   {
   newAttachment(out);
   out.write(; name=\.getBytes());
   out.write(parameterName.getBytes());
   out.write(\.getBytes());
   out.write(crlf.getBytes());
   out.write(crlf.getBytes());
   
 out.write(post.getParameterValue(parameterName).toString().getBytes());
   out.write(crlf.getBytes());
   }
 {code}
 So for a given list of values 3, 2 and 1, it actually writes 3, 3 
 and 3.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

buildbot failure in ASF Buildbot on wicket-master

2014-10-02 Thread buildbot

The Buildbot has detected a new failure on builder wicket-master while building 
wicket.
Full details are available at:
 http://ci.apache.org/builders/wicket-master/builds/234

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: hemera_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch master] e87e47addf933fb17557ae198abe3c4d2ebbd132
Blamelist: Martin Tzvetanov Grigorov mgrigo...@apache.org

BUILD FAILED: failed compile

sincerely,
 -The Buildbot

git commit: Update the XML schema location

Repository: wicket
Updated Branches:
  refs/heads/master e87e47add - e004c08e5


Update the XML schema location


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/e004c08e
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/e004c08e
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/e004c08e

Branch: refs/heads/master
Commit: e004c08e528ed478710613f8d3094a23d431815e
Parents: e87e47a
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Thu Oct 2 17:25:18 2014 +0200
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Thu Oct 2 17:25:18 2014 +0200

--
 .../test/java/org/apache/wicket/spring/applicationContext.xml  | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/e004c08e/wicket-spring/src/test/java/org/apache/wicket/spring/applicationContext.xml
--
diff --git 
a/wicket-spring/src/test/java/org/apache/wicket/spring/applicationContext.xml 
b/wicket-spring/src/test/java/org/apache/wicket/spring/applicationContext.xml
index d1a961d..7d05c62 100644
--- 
a/wicket-spring/src/test/java/org/apache/wicket/spring/applicationContext.xml
+++ 
b/wicket-spring/src/test/java/org/apache/wicket/spring/applicationContext.xml
@@ -15,9 +15,11 @@
See the License for the specific language governing permissions and
limitations under the License.
 --
-!DOCTYPE beans PUBLIC -//SPRING//DTD BEAN//EN 
http://www.springframework.org/dtd/spring-beans.dtd;
+beans xmlns=http://www.springframework.org/schema/beans;
+   xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
+   xsi:schemaLocation=
+http://www.springframework.org/schema/beans 
http://www.springframework.org/schema/beans/spring-beans.xsd;
 
-beans
bean 
class=org.apache.wicket.spring.SpringWebApplicationFactoryTest$Application /

bean id=watcher 
class=org.apache.wicket.spring.SpringWebApplicationFactoryTest$Destroyable 
destroy-method=destroy /

buildbot success in ASF Buildbot on wicket-master

2014-10-02 Thread buildbot

The Buildbot has detected a restored build on builder wicket-master while 
building wicket.
Full details are available at:
 http://ci.apache.org/builders/wicket-master/builds/235

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: hemera_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch master] e004c08e528ed478710613f8d3094a23d431815e
Blamelist: Martin Tzvetanov Grigorov mgrigo...@apache.org

Build succeeded!

sincerely,
 -The Buildbot

[jira] [Created] (WICKET-5717) Url.parse/toString should support fragment

2014-10-02 Thread Guillaume Smet (JIRA)

Guillaume Smet created WICKET-5717:
--

 Summary: Url.parse/toString should support fragment
 Key: WICKET-5717
 URL: https://issues.apache.org/jira/browse/WICKET-5717
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 6.17.0
Reporter: Guillaume Smet


Hi,

Starting with Wicket 6.16, we have issues redirecting to an absolute
URL containing a fragment: the # is escaped by Wicket.

Changes in the commit
https://fisheye6.atlassian.com/changelog/wicket-git?cs=e1f29e90ff3a35e117bb3ddc5ee2aefd900c13c8
are causing the regression but as far as we can see, the commit is not
the problem: the issue is that Url.parse then toString encodes the
anchor.

Before this commit, as we were using an absolute Url, we were in the
case where the Url wasn't escaped.

We think the right fix would be to make org.apache.wicket.request.Url
anchor aware.

Pull request to come.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (WICKET-5717) Url.parse/toString should support fragment

2014-10-02 Thread Guillaume Smet (JIRA)


 [ 
https://issues.apache.org/jira/browse/WICKET-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Smet updated WICKET-5717:
---
Attachment: redirect-url-anchor.tar.gz

Added a quick start showing the issue.

 Url.parse/toString should support fragment
 --

 Key: WICKET-5717
 URL: https://issues.apache.org/jira/browse/WICKET-5717
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 6.17.0
Reporter: Guillaume Smet
 Attachments: redirect-url-anchor.tar.gz


 Hi,
 Starting with Wicket 6.16, we have issues redirecting to an absolute
 URL containing a fragment: the # is escaped by Wicket.
 Changes in the commit
 https://fisheye6.atlassian.com/changelog/wicket-git?cs=e1f29e90ff3a35e117bb3ddc5ee2aefd900c13c8
 are causing the regression but as far as we can see, the commit is not
 the problem: the issue is that Url.parse then toString encodes the
 anchor.
 Before this commit, as we were using an absolute Url, we were in the
 case where the Url wasn't escaped.
 We think the right fix would be to make org.apache.wicket.request.Url
 anchor aware.
 Pull request to come.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WICKET-5717) Url.parse/toString should support fragment

2014-10-02 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/WICKET-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14157270#comment-14157270
 ] 

ASF GitHub Bot commented on WICKET-5717:


GitHub user gsmet opened a pull request:

https://github.com/apache/wicket/pull/78

WICKET-5717 Support fragment in Url parse and toString

Note: this PR is for the wicket-6.x branch.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/openwide-java/wicket support-fragment-in-url

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/wicket/pull/78.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #78


commit f35ae430ee741ca7dd517ed09647d1a28a1f
Author: Guillaume Smet guillaume.s...@gmail.com
Date:   2014-09-30T23:42:27Z

WICKET-5717 Support fragment in Url parse and toString




 Url.parse/toString should support fragment
 --

 Key: WICKET-5717
 URL: https://issues.apache.org/jira/browse/WICKET-5717
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 6.17.0
Reporter: Guillaume Smet
 Attachments: redirect-url-anchor.tar.gz


 Hi,
 Starting with Wicket 6.16, we have issues redirecting to an absolute
 URL containing a fragment: the # is escaped by Wicket.
 Changes in the commit
 https://fisheye6.atlassian.com/changelog/wicket-git?cs=e1f29e90ff3a35e117bb3ddc5ee2aefd900c13c8
 are causing the regression but as far as we can see, the commit is not
 the problem: the issue is that Url.parse then toString encodes the
 anchor.
 Before this commit, as we were using an absolute Url, we were in the
 case where the Url wasn't escaped.
 We think the right fix would be to make org.apache.wicket.request.Url
 anchor aware.
 Pull request to come.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (WICKET-5716) wicket-autocomplete prevents change-listener when leaving input via mouse click