[jira] [Comment Edited] (WICKET-5835) InlineEnclosure doesn't call child.configure() before updating its visilbity
[
https://issues.apache.org/jira/browse/WICKET-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322968#comment-14322968
]
Andrea Del Bene edited comment on WICKET-5835 at 2/16/15 4:39 PM:
--
Thank you for the quickstart. To me this is not a problem with Wicket but with
the way you use to decide the visibility for the inline internal component.
Variable 'visible1' is used to determinate component's visibility but it is set
only when onConfigure is called, hence the component is always invisible to the
inline container.
Just replace the onconfigure method with this version of isVisible:
```
public boolean isVisible() {
return visible1;
};
//@Override
//protected void onConfigure() {
//super.onConfigure();
//
//setVisible(visible1);
//}
```
in this way the internal component's visibility reflects the visible1 flag.
was (Author: bitstorm):
Thank you for the quickstart. To me this is not a problem with Wicket but with
the way you use to decide the visibility for the inline internal component.
Variable 'visible1' is used to determinate component's visibility but it is set
only when onConfigure is called, hence the component is always invisible to the
inline container.
Just replace the onconfigure method with this version of isVisible:
```java
public boolean isVisible() {
return visible1;
};
//@Override
//protected void onConfigure() {
//super.onConfigure();
//
//setVisible(visible1);
//}
```
in this way the internal component's visibility reflects the visible1 flag.
InlineEnclosure doesn't call child.configure() before updating its visilbity
Key: WICKET-5835
URL: https://issues.apache.org/jira/browse/WICKET-5835
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.19.0
Environment: Any
Reporter: Raoul Zander
Assignee: Andrea Del Bene
Priority: Minor
Labels: enclosure
Attachments: enclosure-quickstart.zip
org.apache.wicket.markup.html.internal.InlineEnclosure.updateVisibility()
should propably call child.configure() before the visibility of the
InlineEnclosure is set to the visibility of the child.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (WICKET-5835) InlineEnclosure doesn't call child.configure() before updating its visilbity
[
https://issues.apache.org/jira/browse/WICKET-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322968#comment-14322968
]
Andrea Del Bene edited comment on WICKET-5835 at 2/16/15 4:41 PM:
--
Thank you for the quickstart. To me this is not a problem with Wicket but with
the way you use to decide the visibility for the inline internal component.
Variable 'visible1' is used to determinate component's visibility but it is set
only when onConfigure is called, hence the component is always invisible to the
inline container.
Just replace the onconfigure method with this version of isVisible:
{code}
public boolean isVisible() {
return visible1;
};
//@Override
//protected void onConfigure() {
//super.onConfigure();
//
//setVisible(visible1);
//}
{code}
in this way the internal component's visibility reflects the visible1 flag.
was (Author: bitstorm):
Thank you for the quickstart. To me this is not a problem with Wicket but with
the way you use to decide the visibility for the inline internal component.
Variable 'visible1' is used to determinate component's visibility but it is set
only when onConfigure is called, hence the component is always invisible to the
inline container.
Just replace the onconfigure method with this version of isVisible:
```
public boolean isVisible() {
return visible1;
};
//@Override
//protected void onConfigure() {
//super.onConfigure();
//
//setVisible(visible1);
//}
```
in this way the internal component's visibility reflects the visible1 flag.
InlineEnclosure doesn't call child.configure() before updating its visilbity
Key: WICKET-5835
URL: https://issues.apache.org/jira/browse/WICKET-5835
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.19.0
Environment: Any
Reporter: Raoul Zander
Assignee: Andrea Del Bene
Priority: Minor
Labels: enclosure
Attachments: enclosure-quickstart.zip
org.apache.wicket.markup.html.internal.InlineEnclosure.updateVisibility()
should propably call child.configure() before the visibility of the
InlineEnclosure is set to the visibility of the child.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-5835) InlineEnclosure doesn't call child.configure() before updating its visilbity
[
https://issues.apache.org/jira/browse/WICKET-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322968#comment-14322968
]
Andrea Del Bene commented on WICKET-5835:
-
Thank you for the quickstart. To me this is not a problem with Wicket but with
the way you use to decide the visibility for the inline internal component.
Variable 'visible1' is used to determinate component's visibility but it is set
only when onConfigure is called, hence the component is always invisible to the
inline container.
Just replace the onconfigure method with this version of isVisible:
```java
public boolean isVisible() {
return visible1;
};
//@Override
//protected void onConfigure() {
//super.onConfigure();
//
//setVisible(visible1);
//}
```
in this way the internal component's visibility reflects the visible1 flag.
InlineEnclosure doesn't call child.configure() before updating its visilbity
Key: WICKET-5835
URL: https://issues.apache.org/jira/browse/WICKET-5835
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.19.0
Environment: Any
Reporter: Raoul Zander
Assignee: Andrea Del Bene
Priority: Minor
Labels: enclosure
Attachments: enclosure-quickstart.zip
org.apache.wicket.markup.html.internal.InlineEnclosure.updateVisibility()
should propably call child.configure() before the visibility of the
InlineEnclosure is set to the visibility of the child.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (WICKET-5835) InlineEnclosure doesn't call child.configure() before updating its visilbity
[
https://issues.apache.org/jira/browse/WICKET-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322968#comment-14322968
]
Andrea Del Bene edited comment on WICKET-5835 at 2/16/15 4:40 PM:
--
Thank you for the quickstart. To me this is not a problem with Wicket but with
the way you use to decide the visibility for the inline internal component.
Variable 'visible1' is used to determinate component's visibility but it is set
only when onConfigure is called, hence the component is always invisible to the
inline container.
Just replace the onconfigure method with this version of isVisible:
```
public boolean isVisible() {
return visible1;
};
//@Override
//protected void onConfigure() {
//super.onConfigure();
//
//setVisible(visible1);
//}
```
in this way the internal component's visibility reflects the visible1 flag.
was (Author: bitstorm):
Thank you for the quickstart. To me this is not a problem with Wicket but with
the way you use to decide the visibility for the inline internal component.
Variable 'visible1' is used to determinate component's visibility but it is set
only when onConfigure is called, hence the component is always invisible to the
inline container.
Just replace the onconfigure method with this version of isVisible:
```
public boolean isVisible() {
return visible1;
};
//@Override
//protected void onConfigure() {
//super.onConfigure();
//
//setVisible(visible1);
//}
```
in this way the internal component's visibility reflects the visible1 flag.
InlineEnclosure doesn't call child.configure() before updating its visilbity
Key: WICKET-5835
URL: https://issues.apache.org/jira/browse/WICKET-5835
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.19.0
Environment: Any
Reporter: Raoul Zander
Assignee: Andrea Del Bene
Priority: Minor
Labels: enclosure
Attachments: enclosure-quickstart.zip
org.apache.wicket.markup.html.internal.InlineEnclosure.updateVisibility()
should propably call child.configure() before the visibility of the
InlineEnclosure is set to the visibility of the child.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-5835) InlineEnclosure doesn't call child.configure() before updating its visilbity
[ https://issues.apache.org/jira/browse/WICKET-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14323139#comment-14323139 ] Andrea Del Bene commented on WICKET-5835: - Thank you for your clarification, I think now I get the picture... InlineEnclosure doesn't call child.configure() before updating its visilbity Key: WICKET-5835 URL: https://issues.apache.org/jira/browse/WICKET-5835 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.19.0 Environment: Any Reporter: Raoul Zander Assignee: Andrea Del Bene Priority: Minor Labels: enclosure Attachments: enclosure-quickstart.zip org.apache.wicket.markup.html.internal.InlineEnclosure.updateVisibility() should propably call child.configure() before the visibility of the InlineEnclosure is set to the visibility of the child. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5835) InlineEnclosure doesn't call child.configure() before updating its visilbity
[ https://issues.apache.org/jira/browse/WICKET-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14323268#comment-14323268 ] Andrea Del Bene commented on WICKET-5835: - An the answer is in the next javadoc line :-) NOTE: If component's visibility or another property depends on another component you may call other.configure() followed by other.isVisible() as mentioned in configure() javadoc. InlineEnclosure doesn't call child.configure() before updating its visilbity Key: WICKET-5835 URL: https://issues.apache.org/jira/browse/WICKET-5835 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.19.0 Environment: Any Reporter: Raoul Zander Assignee: Andrea Del Bene Priority: Minor Labels: enclosure Attachments: enclosure-quickstart.zip org.apache.wicket.markup.html.internal.InlineEnclosure.updateVisibility() should propably call child.configure() before the visibility of the InlineEnclosure is set to the visibility of the child. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5835) InlineEnclosure doesn't call child.configure() before updating its visilbity
[ https://issues.apache.org/jira/browse/WICKET-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14323276#comment-14323276 ] ASF subversion and git services commented on WICKET-5835: - Commit c97e3f4b0e7c7300c41d4608547d8bd16f37498f in wicket's branch refs/heads/master from [~bitstorm] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=c97e3f4 ] WICKET-5835 InlineEnclosure doesn't call child.configure() before updating its visilbity InlineEnclosure doesn't call child.configure() before updating its visilbity Key: WICKET-5835 URL: https://issues.apache.org/jira/browse/WICKET-5835 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 7.0.0-M5, 6.19.0 Environment: Any Reporter: Raoul Zander Assignee: Andrea Del Bene Priority: Minor Labels: enclosure Fix For: 6.20.0, 7.0.0-M6 Attachments: enclosure-quickstart.zip org.apache.wicket.markup.html.internal.InlineEnclosure.updateVisibility() should propably call child.configure() before the visibility of the InlineEnclosure is set to the visibility of the child. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-5835) InlineEnclosure doesn't call child.configure() before updating its visilbity
[ https://issues.apache.org/jira/browse/WICKET-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-5835: Affects Version/s: 7.0.0-M5 InlineEnclosure doesn't call child.configure() before updating its visilbity Key: WICKET-5835 URL: https://issues.apache.org/jira/browse/WICKET-5835 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 7.0.0-M5, 6.19.0 Environment: Any Reporter: Raoul Zander Assignee: Andrea Del Bene Priority: Minor Labels: enclosure Fix For: 6.20.0, 7.0.0-M6 Attachments: enclosure-quickstart.zip org.apache.wicket.markup.html.internal.InlineEnclosure.updateVisibility() should propably call child.configure() before the visibility of the InlineEnclosure is set to the visibility of the child. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5835) InlineEnclosure doesn't call child.configure() before updating its visilbity
[ https://issues.apache.org/jira/browse/WICKET-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14323287#comment-14323287 ] ASF subversion and git services commented on WICKET-5835: - Commit 3d5b261577d79afd74a274d7cffb20c031b4dac1 in wicket's branch refs/heads/wicket-6.x from [~bitstorm] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=3d5b261 ] WICKET-5835 InlineEnclosure doesn't call child.configure() before updating its visilbity InlineEnclosure doesn't call child.configure() before updating its visilbity Key: WICKET-5835 URL: https://issues.apache.org/jira/browse/WICKET-5835 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 7.0.0-M5, 6.19.0 Environment: Any Reporter: Raoul Zander Assignee: Andrea Del Bene Priority: Minor Labels: enclosure Fix For: 6.20.0, 7.0.0-M6 Attachments: enclosure-quickstart.zip org.apache.wicket.markup.html.internal.InlineEnclosure.updateVisibility() should propably call child.configure() before the visibility of the InlineEnclosure is set to the visibility of the child. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
wicket git commit: WICKET-5835 InlineEnclosure doesn't call child.configure() before updating its visilbity
Repository: wicket
Updated Branches:
refs/heads/wicket-6.x 1a4844f5c - 3d5b26157
WICKET-5835 InlineEnclosure doesn't call child.configure() before updating its
visilbity
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/3d5b2615
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/3d5b2615
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/3d5b2615
Branch: refs/heads/wicket-6.x
Commit: 3d5b261577d79afd74a274d7cffb20c031b4dac1
Parents: 1a4844f
Author: Andrea Del Bene adelb...@apache.org
Authored: Mon Feb 16 21:52:38 2015 +0100
Committer: Andrea Del Bene adelb...@apache.org
Committed: Mon Feb 16 22:00:18 2015 +0100
--
.../apache/wicket/markup/html/internal/Enclosure.java | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/3d5b2615/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java
b/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java
index 8a3c8e5..61cb29d 100644
---
a/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java
+++
b/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java
@@ -142,7 +142,18 @@ public class Enclosure extends WebMarkupContainer
implements IComponentResolver
{
return childComponent.determineVisibility()
super.isVisible();
}
-
+
+ @Override
+ protected void onConfigure()
+ {
+ super.onConfigure();
+ final Component child = getChild();
+
+ child.configure();
+ boolean childVisible = child.determineVisibility();
+
+ setVisible(childVisible);
+ }
/**
* Get the real parent container
*
[jira] [Commented] (WICKET-5837) JUnit tests may fail because of AbstractDefaultAjaxBehavior
[ https://issues.apache.org/jira/browse/WICKET-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14323424#comment-14323424 ] ASF GitHub Bot commented on WICKET-5837: Github user bitstorm commented on the pull request: https://github.com/apache/wicket/pull/90#issuecomment-74585821 actually I have already applied your commit to 6.x (hash 1a6f1bde1a6b576f39bf6fd6d5129d577319c2a7 ). So now its ok. I forgot to notify you about it. JUnit tests may fail because of AbstractDefaultAjaxBehavior --- Key: WICKET-5837 URL: https://issues.apache.org/jira/browse/WICKET-5837 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 7.0.0-M5, 6.19.0 Reporter: Tobias Soloschenko Assignee: Andrea Del Bene Labels: test Fix For: 6.20.0, 7.0.0-M6 Because JSONObject is used in the method org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.renderAjaxAttributes(Component, AjaxRequestAttributes) which internally uses a HashMap to store the key value pairs - see org.apache.wicket.ajax.json.JSONObject.JSONObject() - it is not ensured the attributes rendered in a specific order. This can cause the unit tests to pass in one run and fail in the next run. One suggestion would be to switch the HashMap and replace it with at LinkedHashMap to preserve the insertion order. See stack trace in comment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5837) JUnit tests may fail because of AbstractDefaultAjaxBehavior
[ https://issues.apache.org/jira/browse/WICKET-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14323728#comment-14323728 ] ASF GitHub Bot commented on WICKET-5837: Github user klopfdreh commented on the pull request: https://github.com/apache/wicket/pull/90#issuecomment-74624272 Ah ok! :-) - thanks a lot - so I'm closing this PR, now! JUnit tests may fail because of AbstractDefaultAjaxBehavior --- Key: WICKET-5837 URL: https://issues.apache.org/jira/browse/WICKET-5837 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 7.0.0-M5, 6.19.0 Reporter: Tobias Soloschenko Assignee: Andrea Del Bene Labels: test Fix For: 6.20.0, 7.0.0-M6 Because JSONObject is used in the method org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.renderAjaxAttributes(Component, AjaxRequestAttributes) which internally uses a HashMap to store the key value pairs - see org.apache.wicket.ajax.json.JSONObject.JSONObject() - it is not ensured the attributes rendered in a specific order. This can cause the unit tests to pass in one run and fail in the next run. One suggestion would be to switch the HashMap and replace it with at LinkedHashMap to preserve the insertion order. See stack trace in comment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5837) JUnit tests may fail because of AbstractDefaultAjaxBehavior
[ https://issues.apache.org/jira/browse/WICKET-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14323729#comment-14323729 ] ASF GitHub Bot commented on WICKET-5837: Github user klopfdreh closed the pull request at: https://github.com/apache/wicket/pull/90 JUnit tests may fail because of AbstractDefaultAjaxBehavior --- Key: WICKET-5837 URL: https://issues.apache.org/jira/browse/WICKET-5837 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 7.0.0-M5, 6.19.0 Reporter: Tobias Soloschenko Assignee: Andrea Del Bene Labels: test Fix For: 6.20.0, 7.0.0-M6 Because JSONObject is used in the method org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.renderAjaxAttributes(Component, AjaxRequestAttributes) which internally uses a HashMap to store the key value pairs - see org.apache.wicket.ajax.json.JSONObject.JSONObject() - it is not ensured the attributes rendered in a specific order. This can cause the unit tests to pass in one run and fail in the next run. One suggestion would be to switch the HashMap and replace it with at LinkedHashMap to preserve the insertion order. See stack trace in comment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
wicket git commit: WICKET-5835 InlineEnclosure doesn't call child.configure() before updating its visilbity
Repository: wicket
Updated Branches:
refs/heads/master dd8dca3e5 - c97e3f4b0
WICKET-5835 InlineEnclosure doesn't call child.configure() before updating its
visilbity
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/c97e3f4b
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/c97e3f4b
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/c97e3f4b
Branch: refs/heads/master
Commit: c97e3f4b0e7c7300c41d4608547d8bd16f37498f
Parents: dd8dca3
Author: Andrea Del Bene adelb...@apache.org
Authored: Mon Feb 16 21:52:38 2015 +0100
Committer: Andrea Del Bene adelb...@apache.org
Committed: Mon Feb 16 21:53:10 2015 +0100
--
.../wicket/markup/html/internal/Enclosure.java | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/c97e3f4b/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java
b/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java
index f2fcb49..49d55c3 100644
---
a/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java
+++
b/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/Enclosure.java
@@ -140,7 +140,18 @@ public class Enclosure extends WebMarkupContainer
implements IComponentResolver
{
return getChild().determineVisibility();
}
-
+
+ @Override
+ protected void onConfigure()
+ {
+ super.onConfigure();
+ final Component child = getChild();
+
+ child.configure();
+ boolean childVisible = child.determineVisibility();
+
+ setVisible(childVisible);
+ }
@Override
protected void onDetach()
@@ -239,12 +250,6 @@ public class Enclosure extends WebMarkupContainer
implements IComponentResolver
@Override
public Component resolve(MarkupContainer container, MarkupStream
markupStream, ComponentTag tag)
{
- // only resolved when auto, not when queued
- // if (!isAuto())
- // {
- // return null;
- // }
-
if (childId.equals(tag.getId()))
{
return childComponent;
[jira] [Resolved] (WICKET-5837) JUnit tests may fail because of AbstractDefaultAjaxBehavior
[ https://issues.apache.org/jira/browse/WICKET-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene resolved WICKET-5837. - Resolution: Fixed JUnit tests may fail because of AbstractDefaultAjaxBehavior --- Key: WICKET-5837 URL: https://issues.apache.org/jira/browse/WICKET-5837 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 7.0.0-M5, 6.19.0 Reporter: Tobias Soloschenko Assignee: Andrea Del Bene Labels: test Fix For: 6.20.0, 7.0.0-M6 Because JSONObject is used in the method org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.renderAjaxAttributes(Component, AjaxRequestAttributes) which internally uses a HashMap to store the key value pairs - see org.apache.wicket.ajax.json.JSONObject.JSONObject() - it is not ensured the attributes rendered in a specific order. This can cause the unit tests to pass in one run and fail in the next run. One suggestion would be to switch the HashMap and replace it with at LinkedHashMap to preserve the insertion order. See stack trace in comment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[1/2] wicket git commit: WICKET-5827 bugfixes
Repository: wicket
Updated Branches:
refs/heads/wicket-6.x 1a6f1bde1 - 1a4844f5c
WICKET-5827 bugfixes
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/c92ad134
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/c92ad134
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/c92ad134
Branch: refs/heads/wicket-6.x
Commit: c92ad1348eec047453e0980f01d5a1713927b69f
Parents: 1a6f1bd
Author: klopfdreh klopfdreh@192.168.2.110
Authored: Mon Feb 16 12:19:21 2015 +0100
Committer: klopfdreh klopfdreh@192.168.2.110
Committed: Mon Feb 16 12:19:21 2015 +0100
--
.../java/org/apache/wicket/resource/CompositeCssCompressor.java | 4 ++--
.../src/main/java/org/apache/wicket/resource/CssUrlReplacer.java | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/c92ad134/wicket-core/src/main/java/org/apache/wicket/resource/CompositeCssCompressor.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/resource/CompositeCssCompressor.java
b/wicket-core/src/main/java/org/apache/wicket/resource/CompositeCssCompressor.java
index d8fdcc0..6e7b1c3 100644
---
a/wicket-core/src/main/java/org/apache/wicket/resource/CompositeCssCompressor.java
+++
b/wicket-core/src/main/java/org/apache/wicket/resource/CompositeCssCompressor.java
@@ -42,7 +42,7 @@ import org.apache.wicket.css.ICssCompressor;
* @author Tobias Soloschenko
*
*/
-public class CompositeCssCompressor implements IScopeAwareTextResourceProcessor
+public class CompositeCssCompressor implements
IScopeAwareTextResourceProcessor, ICssCompressor
{
/* Compressors to compress the CSS content */
private final ListICssCompressor compressors = new
ArrayListICssCompressor();
@@ -71,7 +71,7 @@ public class CompositeCssCompressor implements
IScopeAwareTextResourceProcessor
if (compressor instanceof
IScopeAwareTextResourceProcessor)
{
IScopeAwareTextResourceProcessor processor =
(IScopeAwareTextResourceProcessor)compressor;
- processor.process(compressed, scope, name);
+ compressed = processor.process(compressed,
scope, name);
}
else
{
http://git-wip-us.apache.org/repos/asf/wicket/blob/c92ad134/wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacer.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacer.java
b/wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacer.java
index 6ad891c..7734e91 100644
--- a/wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacer.java
+++ b/wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacer.java
@@ -19,6 +19,7 @@ package org.apache.wicket.resource;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
+import org.apache.wicket.css.ICssCompressor;
import org.apache.wicket.request.Url;
import org.apache.wicket.request.cycle.RequestCycle;
import org.apache.wicket.request.resource.PackageResourceReference;
@@ -37,7 +38,7 @@ import
org.apache.wicket.request.resource.PackageResourceReference;
* @since 6.20.0
* @author Tobias Soloschenko
*/
-public class CssUrlReplacer implements IScopeAwareTextResourceProcessor
+public class CssUrlReplacer implements IScopeAwareTextResourceProcessor,
ICssCompressor
{
// The pattern to find URLs in CSS resources
private static final Pattern URL_PATTERN =
Pattern.compile(url\\(['|\]*(.*?)['|\]*\\));
[jira] [Commented] (WICKET-5827) Allow to apply multiple Javascript / CSS compressors
[ https://issues.apache.org/jira/browse/WICKET-5827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322781#comment-14322781 ] ASF GitHub Bot commented on WICKET-5827: Github user asfgit closed the pull request at: https://github.com/apache/wicket/pull/95 Allow to apply multiple Javascript / CSS compressors Key: WICKET-5827 URL: https://issues.apache.org/jira/browse/WICKET-5827 Project: Wicket Issue Type: New Feature Components: wicket Affects Versions: 6.20.0, 7.0.0-M6 Reporter: Tobias Soloschenko Assignee: Martin Grigorov Priority: Minor Labels: features Fix For: 6.20.0, 7.0.0-M6 It would be nice to be able to add several css and javascript compressions in a chain. Example for CSS: CssRemoveCommentsCompressor CssUrlReplacementCompressor CssMinifyCompressor The same would be nice for JavaScript files. https://github.com/apache/wicket/pull/88 https://github.com/apache/wicket/pull/87 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5827) Allow to apply multiple Javascript / CSS compressors
[ https://issues.apache.org/jira/browse/WICKET-5827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322780#comment-14322780 ] ASF subversion and git services commented on WICKET-5827: - Commit 1a4844f5c8da09d0055909c436fa20a9fb292158 in wicket's branch refs/heads/wicket-6.x from [~mgrigorov] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=1a4844f ] WICKET-5827 Allow to apply multiple Javascript / CSS compressors Allow IJavaScriptCompressors to be IScopeAwareTextResourceProcessor too Allow to apply multiple Javascript / CSS compressors Key: WICKET-5827 URL: https://issues.apache.org/jira/browse/WICKET-5827 Project: Wicket Issue Type: New Feature Components: wicket Affects Versions: 6.20.0, 7.0.0-M6 Reporter: Tobias Soloschenko Assignee: Martin Grigorov Priority: Minor Labels: features Fix For: 6.20.0, 7.0.0-M6 It would be nice to be able to add several css and javascript compressions in a chain. Example for CSS: CssRemoveCommentsCompressor CssUrlReplacementCompressor CssMinifyCompressor The same would be nice for JavaScript files. https://github.com/apache/wicket/pull/88 https://github.com/apache/wicket/pull/87 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5827) Allow to apply multiple Javascript / CSS compressors
[ https://issues.apache.org/jira/browse/WICKET-5827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322779#comment-14322779 ] ASF subversion and git services commented on WICKET-5827: - Commit c92ad1348eec047453e0980f01d5a1713927b69f in wicket's branch refs/heads/wicket-6.x from klopfdreh [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=c92ad13 ] WICKET-5827 bugfixes Allow to apply multiple Javascript / CSS compressors Key: WICKET-5827 URL: https://issues.apache.org/jira/browse/WICKET-5827 Project: Wicket Issue Type: New Feature Components: wicket Affects Versions: 6.20.0, 7.0.0-M6 Reporter: Tobias Soloschenko Assignee: Martin Grigorov Priority: Minor Labels: features Fix For: 6.20.0, 7.0.0-M6 It would be nice to be able to add several css and javascript compressions in a chain. Example for CSS: CssRemoveCommentsCompressor CssUrlReplacementCompressor CssMinifyCompressor The same would be nice for JavaScript files. https://github.com/apache/wicket/pull/88 https://github.com/apache/wicket/pull/87 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[2/2] wicket git commit: WICKET-5827 Allow to apply multiple Javascript / CSS compressors
WICKET-5827 Allow to apply multiple Javascript / CSS compressors
Allow IJavaScriptCompressors to be IScopeAwareTextResourceProcessor too
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/1a4844f5
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/1a4844f5
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/1a4844f5
Branch: refs/heads/wicket-6.x
Commit: 1a4844f5c8da09d0055909c436fa20a9fb292158
Parents: c92ad13
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Mon Feb 16 15:56:14 2015 +0200
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Mon Feb 16 15:56:14 2015 +0200
--
.../resource/JavaScriptPackageResource.java | 25 +--
.../wicket/resource/CompositeCssCompressor.java | 3 +--
.../resource/CompositeJavaScriptCompressor.java | 26 +++-
3 files changed, 38 insertions(+), 16 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/1a4844f5/wicket-core/src/main/java/org/apache/wicket/request/resource/JavaScriptPackageResource.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/request/resource/JavaScriptPackageResource.java
b/wicket-core/src/main/java/org/apache/wicket/request/resource/JavaScriptPackageResource.java
index 210fee1..49f393a 100644
---
a/wicket-core/src/main/java/org/apache/wicket/request/resource/JavaScriptPackageResource.java
+++
b/wicket-core/src/main/java/org/apache/wicket/request/resource/JavaScriptPackageResource.java
@@ -20,11 +20,12 @@ import java.util.Locale;
import org.apache.wicket.Application;
import org.apache.wicket.javascript.IJavaScriptCompressor;
+import org.apache.wicket.resource.IScopeAwareTextResourceProcessor;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/**
- * Package resource for javascript files. It strips comments and whitespace
from javascript.
+ * Package resource for javascript files.
*/
public class JavaScriptPackageResource extends PackageResource
{
@@ -32,20 +33,18 @@ public class JavaScriptPackageResource extends
PackageResource
private static final Logger log =
LoggerFactory.getLogger(JavaScriptPackageResource.class);
+ private final String name;
+
/**
* Construct.
-*
-* @param scope
-* @param name
-* @param locale
-* @param style
-* @param variation
*/
public JavaScriptPackageResource(Class? scope, String name, Locale
locale, String style,
String variation)
{
super(scope, name, locale, style, variation);
+ this.name = name;
+
// JS resources can be compressed if there is configured
IJavaScriptCompressor
setCompress(true);
}
@@ -62,7 +61,17 @@ public class JavaScriptPackageResource extends
PackageResource
try
{
String nonCompressed = new
String(processedResponse, UTF-8);
- return
compressor.compress(nonCompressed).getBytes(UTF-8);
+ String output;
+ if (compressor instanceof
IScopeAwareTextResourceProcessor)
+ {
+ IScopeAwareTextResourceProcessor
scopeAwareProcessor = (IScopeAwareTextResourceProcessor)compressor;
+ output =
scopeAwareProcessor.process(nonCompressed, getScope(), name);
+ }
+ else
+ {
+ output =
compressor.compress(nonCompressed);
+ }
+ return output.getBytes();
}
catch (Exception e)
{
http://git-wip-us.apache.org/repos/asf/wicket/blob/1a4844f5/wicket-core/src/main/java/org/apache/wicket/resource/CompositeCssCompressor.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/resource/CompositeCssCompressor.java
b/wicket-core/src/main/java/org/apache/wicket/resource/CompositeCssCompressor.java
index 6e7b1c3..7d0dc8b 100644
---
a/wicket-core/src/main/java/org/apache/wicket/resource/CompositeCssCompressor.java
+++
b/wicket-core/src/main/java/org/apache/wicket/resource/CompositeCssCompressor.java
@@ -40,7 +40,6 @@ import org.apache.wicket.css.ICssCompressor;
*
* @since 6.20.0
* @author Tobias Soloschenko
- *
*/
public class CompositeCssCompressor implements
IScopeAwareTextResourceProcessor, ICssCompressor
{
@@
[jira] [Commented] (WICKET-5827) Allow to apply multiple Javascript / CSS compressors
[ https://issues.apache.org/jira/browse/WICKET-5827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322790#comment-14322790 ] Martin Grigorov commented on WICKET-5827: - Thanks, Tobias! Allow to apply multiple Javascript / CSS compressors Key: WICKET-5827 URL: https://issues.apache.org/jira/browse/WICKET-5827 Project: Wicket Issue Type: New Feature Components: wicket Affects Versions: 6.20.0, 7.0.0-M6 Reporter: Tobias Soloschenko Assignee: Martin Grigorov Priority: Minor Labels: features Fix For: 6.20.0, 7.0.0-M6 It would be nice to be able to add several css and javascript compressions in a chain. Example for CSS: CssRemoveCommentsCompressor CssUrlReplacementCompressor CssMinifyCompressor The same would be nice for JavaScript files. https://github.com/apache/wicket/pull/88 https://github.com/apache/wicket/pull/87 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[2/2] wicket git commit: WICKET-5827 Allow to apply multiple Javascript / CSS compressors
WICKET-5827 Allow to apply multiple Javascript / CSS compressors
Allow IJavaScriptCompressors to be IScopeAwareTextResourceProcessor too
(cherry picked from commit 1a4844f5c8da09d0055909c436fa20a9fb292158)
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/dd8dca3e
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/dd8dca3e
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/dd8dca3e
Branch: refs/heads/master
Commit: dd8dca3e5489ae5e114df6ffc7a1726039535020
Parents: 5d1b3b1
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Mon Feb 16 15:56:14 2015 +0200
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Mon Feb 16 15:59:02 2015 +0200
--
.../resource/JavaScriptPackageResource.java | 25 +---
.../wicket/resource/CompositeCssCompressor.java | 1 -
.../resource/CompositeJavaScriptCompressor.java | 24 +++
3 files changed, 36 insertions(+), 14 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/dd8dca3e/wicket-core/src/main/java/org/apache/wicket/request/resource/JavaScriptPackageResource.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/request/resource/JavaScriptPackageResource.java
b/wicket-core/src/main/java/org/apache/wicket/request/resource/JavaScriptPackageResource.java
index 210fee1..49f393a 100644
---
a/wicket-core/src/main/java/org/apache/wicket/request/resource/JavaScriptPackageResource.java
+++
b/wicket-core/src/main/java/org/apache/wicket/request/resource/JavaScriptPackageResource.java
@@ -20,11 +20,12 @@ import java.util.Locale;
import org.apache.wicket.Application;
import org.apache.wicket.javascript.IJavaScriptCompressor;
+import org.apache.wicket.resource.IScopeAwareTextResourceProcessor;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/**
- * Package resource for javascript files. It strips comments and whitespace
from javascript.
+ * Package resource for javascript files.
*/
public class JavaScriptPackageResource extends PackageResource
{
@@ -32,20 +33,18 @@ public class JavaScriptPackageResource extends
PackageResource
private static final Logger log =
LoggerFactory.getLogger(JavaScriptPackageResource.class);
+ private final String name;
+
/**
* Construct.
-*
-* @param scope
-* @param name
-* @param locale
-* @param style
-* @param variation
*/
public JavaScriptPackageResource(Class? scope, String name, Locale
locale, String style,
String variation)
{
super(scope, name, locale, style, variation);
+ this.name = name;
+
// JS resources can be compressed if there is configured
IJavaScriptCompressor
setCompress(true);
}
@@ -62,7 +61,17 @@ public class JavaScriptPackageResource extends
PackageResource
try
{
String nonCompressed = new
String(processedResponse, UTF-8);
- return
compressor.compress(nonCompressed).getBytes(UTF-8);
+ String output;
+ if (compressor instanceof
IScopeAwareTextResourceProcessor)
+ {
+ IScopeAwareTextResourceProcessor
scopeAwareProcessor = (IScopeAwareTextResourceProcessor)compressor;
+ output =
scopeAwareProcessor.process(nonCompressed, getScope(), name);
+ }
+ else
+ {
+ output =
compressor.compress(nonCompressed);
+ }
+ return output.getBytes();
}
catch (Exception e)
{
http://git-wip-us.apache.org/repos/asf/wicket/blob/dd8dca3e/wicket-core/src/main/java/org/apache/wicket/resource/CompositeCssCompressor.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/resource/CompositeCssCompressor.java
b/wicket-core/src/main/java/org/apache/wicket/resource/CompositeCssCompressor.java
index 5419516..81f8096 100644
---
a/wicket-core/src/main/java/org/apache/wicket/resource/CompositeCssCompressor.java
+++
b/wicket-core/src/main/java/org/apache/wicket/resource/CompositeCssCompressor.java
@@ -39,7 +39,6 @@ import org.apache.wicket.css.ICssCompressor;
*
* @since 6.20.0
* @author Tobias Soloschenko
- *
*/
public class CompositeCssCompressor
[jira] [Commented] (WICKET-5827) Allow to apply multiple Javascript / CSS compressors
[ https://issues.apache.org/jira/browse/WICKET-5827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322794#comment-14322794 ] ASF subversion and git services commented on WICKET-5827: - Commit dd8dca3e5489ae5e114df6ffc7a1726039535020 in wicket's branch refs/heads/master from [~mgrigorov] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=dd8dca3 ] WICKET-5827 Allow to apply multiple Javascript / CSS compressors Allow IJavaScriptCompressors to be IScopeAwareTextResourceProcessor too (cherry picked from commit 1a4844f5c8da09d0055909c436fa20a9fb292158) Allow to apply multiple Javascript / CSS compressors Key: WICKET-5827 URL: https://issues.apache.org/jira/browse/WICKET-5827 Project: Wicket Issue Type: New Feature Components: wicket Affects Versions: 6.20.0, 7.0.0-M6 Reporter: Tobias Soloschenko Assignee: Martin Grigorov Priority: Minor Labels: features Fix For: 6.20.0, 7.0.0-M6 It would be nice to be able to add several css and javascript compressions in a chain. Example for CSS: CssRemoveCommentsCompressor CssUrlReplacementCompressor CssMinifyCompressor The same would be nice for JavaScript files. https://github.com/apache/wicket/pull/88 https://github.com/apache/wicket/pull/87 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[1/2] wicket git commit: WICKET-5827 bugfixes
Repository: wicket
Updated Branches:
refs/heads/master 9240b8ab9 - dd8dca3e5
WICKET-5827 bugfixes
(cherry picked from commit c92ad1348eec047453e0980f01d5a1713927b69f)
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/5d1b3b1b
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/5d1b3b1b
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/5d1b3b1b
Branch: refs/heads/master
Commit: 5d1b3b1bd7414ca9bfeadbc1c3057f364932d983
Parents: 9240b8a
Author: klopfdreh klopfdreh@192.168.2.110
Authored: Mon Feb 16 12:19:21 2015 +0100
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Mon Feb 16 15:58:38 2015 +0200
--
.../org/apache/wicket/resource/CompositeCssCompressor.java | 6 +++---
.../main/java/org/apache/wicket/resource/CssUrlReplacer.java | 3 ++-
2 files changed, 5 insertions(+), 4 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/5d1b3b1b/wicket-core/src/main/java/org/apache/wicket/resource/CompositeCssCompressor.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/resource/CompositeCssCompressor.java
b/wicket-core/src/main/java/org/apache/wicket/resource/CompositeCssCompressor.java
index f23c937..5419516 100644
---
a/wicket-core/src/main/java/org/apache/wicket/resource/CompositeCssCompressor.java
+++
b/wicket-core/src/main/java/org/apache/wicket/resource/CompositeCssCompressor.java
@@ -41,7 +41,7 @@ import org.apache.wicket.css.ICssCompressor;
* @author Tobias Soloschenko
*
*/
-public class CompositeCssCompressor implements IScopeAwareTextResourceProcessor
+public class CompositeCssCompressor implements
IScopeAwareTextResourceProcessor, ICssCompressor
{
/* Compressors to compress the CSS content */
private final ListICssCompressor compressors = new ArrayList();
@@ -69,8 +69,8 @@ public class CompositeCssCompressor implements
IScopeAwareTextResourceProcessor
{
if (compressor instanceof
IScopeAwareTextResourceProcessor)
{
- IScopeAwareTextResourceProcessor processor =
(IScopeAwareTextResourceProcessor) compressor;
- processor.process(compressed, scope, name);
+ IScopeAwareTextResourceProcessor processor =
(IScopeAwareTextResourceProcessor)compressor;
+ compressed = processor.process(compressed,
scope, name);
}
else
{
http://git-wip-us.apache.org/repos/asf/wicket/blob/5d1b3b1b/wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacer.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacer.java
b/wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacer.java
index a636609..b7e55f0 100644
--- a/wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacer.java
+++ b/wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacer.java
@@ -19,6 +19,7 @@ package org.apache.wicket.resource;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
+import org.apache.wicket.css.ICssCompressor;
import org.apache.wicket.request.Url;
import org.apache.wicket.request.cycle.RequestCycle;
import org.apache.wicket.request.resource.PackageResourceReference;
@@ -37,7 +38,7 @@ import
org.apache.wicket.request.resource.PackageResourceReference;
* @since 6.20.0
* @author Tobias Soloschenko
*/
-public class CssUrlReplacer implements IScopeAwareTextResourceProcessor
+public class CssUrlReplacer implements IScopeAwareTextResourceProcessor,
ICssCompressor
{
// The pattern to find URLs in CSS resources
private static final Pattern URL_PATTERN =
Pattern.compile(url\\(['|\]*(.*?)['|\]*\\));
[jira] [Commented] (WICKET-5827) Allow to apply multiple Javascript / CSS compressors
[ https://issues.apache.org/jira/browse/WICKET-5827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322793#comment-14322793 ] ASF subversion and git services commented on WICKET-5827: - Commit 5d1b3b1bd7414ca9bfeadbc1c3057f364932d983 in wicket's branch refs/heads/master from klopfdreh [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=5d1b3b1 ] WICKET-5827 bugfixes (cherry picked from commit c92ad1348eec047453e0980f01d5a1713927b69f) Allow to apply multiple Javascript / CSS compressors Key: WICKET-5827 URL: https://issues.apache.org/jira/browse/WICKET-5827 Project: Wicket Issue Type: New Feature Components: wicket Affects Versions: 6.20.0, 7.0.0-M6 Reporter: Tobias Soloschenko Assignee: Martin Grigorov Priority: Minor Labels: features Fix For: 6.20.0, 7.0.0-M6 It would be nice to be able to add several css and javascript compressions in a chain. Example for CSS: CssRemoveCommentsCompressor CssUrlReplacementCompressor CssMinifyCompressor The same would be nice for JavaScript files. https://github.com/apache/wicket/pull/88 https://github.com/apache/wicket/pull/87 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5827) Allow to apply multiple Javascript / CSS compressors
[ https://issues.apache.org/jira/browse/WICKET-5827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322796#comment-14322796 ] ASF GitHub Bot commented on WICKET-5827: Github user martin-g commented on the pull request: https://github.com/apache/wicket/pull/94#issuecomment-74512507 Thanks, Tobias! I've cherry-picked the commit for 6.x and applied it to 7.x. GitHub didn't recognize the commit and didn't close the PR. Please close it manually. Allow to apply multiple Javascript / CSS compressors Key: WICKET-5827 URL: https://issues.apache.org/jira/browse/WICKET-5827 Project: Wicket Issue Type: New Feature Components: wicket Affects Versions: 6.20.0, 7.0.0-M6 Reporter: Tobias Soloschenko Assignee: Martin Grigorov Priority: Minor Labels: features Fix For: 6.20.0, 7.0.0-M6 It would be nice to be able to add several css and javascript compressions in a chain. Example for CSS: CssRemoveCommentsCompressor CssUrlReplacementCompressor CssMinifyCompressor The same would be nice for JavaScript files. https://github.com/apache/wicket/pull/88 https://github.com/apache/wicket/pull/87 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5819) Support for HTML 5 media tags (audio / video)
[ https://issues.apache.org/jira/browse/WICKET-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322523#comment-14322523 ] Tobias Soloschenko commented on WICKET-5819: https://github.com/apache/wicket/blob/pr-86-media_tags/wicket-core/src/main/java/org/apache/wicket/markup/html/media/MediaStreamingResourceReference.java#L75 The line is returning 'null' for a valide video located in the package with the correct scope - any idea what it could be? Support for HTML 5 media tags (audio / video) - Key: WICKET-5819 URL: https://issues.apache.org/jira/browse/WICKET-5819 Project: Wicket Issue Type: New Feature Components: wicket Affects Versions: 7.0.0-M5 Reporter: Tobias Soloschenko Assignee: Martin Grigorov Labels: features It would be great to embed video and audio files with the html5 tags: http://www.w3schools.com/html/html5_video.asp http://www.w3schools.com/html/html5_audio.asp http://dev.w3.org/html5/spec-author-view/video.html A documentation / implementation is provided here: https://github.com/klopfdreh/wicket-components-playground -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (WICKET-5819) Support for HTML 5 media tags (audio / video)
[ https://issues.apache.org/jira/browse/WICKET-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322523#comment-14322523 ] Tobias Soloschenko edited comment on WICKET-5819 at 2/16/15 8:37 AM: - https://github.com/apache/wicket/blob/pr-86-media_tags/wicket-core/src/main/java/org/apache/wicket/markup/html/media/MediaStreamingResourceReference.java#L75 The line is returning 'null' for a valid video located in the package with the correct scope - any idea what it could be? was (Author: klopfdreh): https://github.com/apache/wicket/blob/pr-86-media_tags/wicket-core/src/main/java/org/apache/wicket/markup/html/media/MediaStreamingResourceReference.java#L75 The line is returning 'null' for a valide video located in the package with the correct scope - any idea what it could be? Support for HTML 5 media tags (audio / video) - Key: WICKET-5819 URL: https://issues.apache.org/jira/browse/WICKET-5819 Project: Wicket Issue Type: New Feature Components: wicket Affects Versions: 7.0.0-M5 Reporter: Tobias Soloschenko Assignee: Martin Grigorov Labels: features It would be great to embed video and audio files with the html5 tags: http://www.w3schools.com/html/html5_video.asp http://www.w3schools.com/html/html5_audio.asp http://dev.w3.org/html5/spec-author-view/video.html A documentation / implementation is provided here: https://github.com/klopfdreh/wicket-components-playground -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5819) Support for HTML 5 media tags (audio / video)
[ https://issues.apache.org/jira/browse/WICKET-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322498#comment-14322498 ] Tobias Soloschenko commented on WICKET-5819: Well then - ok - put it together. maybe we can reuse the PartWriterCallback then. Support for HTML 5 media tags (audio / video) - Key: WICKET-5819 URL: https://issues.apache.org/jira/browse/WICKET-5819 Project: Wicket Issue Type: New Feature Components: wicket Affects Versions: 7.0.0-M5 Reporter: Tobias Soloschenko Assignee: Martin Grigorov Labels: features It would be great to embed video and audio files with the html5 tags: http://www.w3schools.com/html/html5_video.asp http://www.w3schools.com/html/html5_audio.asp http://dev.w3.org/html5/spec-author-view/video.html A documentation / implementation is provided here: https://github.com/klopfdreh/wicket-components-playground -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5819) Support for HTML 5 media tags (audio / video)
[ https://issues.apache.org/jira/browse/WICKET-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322585#comment-14322585 ] ASF GitHub Bot commented on WICKET-5819: Github user klopfdreh commented on the pull request: https://github.com/apache/wicket/pull/86#issuecomment-74482175 Closed due to: https://github.com/apache/wicket/pull/93 Support for HTML 5 media tags (audio / video) - Key: WICKET-5819 URL: https://issues.apache.org/jira/browse/WICKET-5819 Project: Wicket Issue Type: New Feature Components: wicket Affects Versions: 7.0.0-M5 Reporter: Tobias Soloschenko Assignee: Martin Grigorov Labels: features It would be great to embed video and audio files with the html5 tags: http://www.w3schools.com/html/html5_video.asp http://www.w3schools.com/html/html5_audio.asp http://dev.w3.org/html5/spec-author-view/video.html A documentation / implementation is provided here: https://github.com/klopfdreh/wicket-components-playground -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5819) Support for HTML 5 media tags (audio / video)
[ https://issues.apache.org/jira/browse/WICKET-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322584#comment-14322584 ] ASF GitHub Bot commented on WICKET-5819: GitHub user klopfdreh opened a pull request: https://github.com/apache/wicket/pull/93 WICKET-5819 Media tags - audio / video implementation (branched) Media tags implementation based on its own branch You can merge this pull request into a Git repository by running: $ git pull https://github.com/klopfdreh/wicket pr-86-media_tags Alternatively you can review and apply these changes as the patch at: https://github.com/apache/wicket/pull/93.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #93 commit 42e89211079e35894f4a804b279d5a5a8e3acee9 Author: klopfdreh klopfdreh@192.168.2.110 Date: 2015-02-16T09:33:39Z WICKET-5819 Media tags - examples / minor changes Support for HTML 5 media tags (audio / video) - Key: WICKET-5819 URL: https://issues.apache.org/jira/browse/WICKET-5819 Project: Wicket Issue Type: New Feature Components: wicket Affects Versions: 7.0.0-M5 Reporter: Tobias Soloschenko Assignee: Martin Grigorov Labels: features It would be great to embed video and audio files with the html5 tags: http://www.w3schools.com/html/html5_video.asp http://www.w3schools.com/html/html5_audio.asp http://dev.w3.org/html5/spec-author-view/video.html A documentation / implementation is provided here: https://github.com/klopfdreh/wicket-components-playground -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5819) Support for HTML 5 media tags (audio / video)
[ https://issues.apache.org/jira/browse/WICKET-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322586#comment-14322586 ] ASF GitHub Bot commented on WICKET-5819: Github user klopfdreh closed the pull request at: https://github.com/apache/wicket/pull/86 Support for HTML 5 media tags (audio / video) - Key: WICKET-5819 URL: https://issues.apache.org/jira/browse/WICKET-5819 Project: Wicket Issue Type: New Feature Components: wicket Affects Versions: 7.0.0-M5 Reporter: Tobias Soloschenko Assignee: Martin Grigorov Labels: features It would be great to embed video and audio files with the html5 tags: http://www.w3schools.com/html/html5_video.asp http://www.w3schools.com/html/html5_audio.asp http://dev.w3.org/html5/spec-author-view/video.html A documentation / implementation is provided here: https://github.com/klopfdreh/wicket-components-playground -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5819) Support for HTML 5 media tags (audio / video)
[ https://issues.apache.org/jira/browse/WICKET-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322590#comment-14322590 ] Tobias Soloschenko commented on WICKET-5819: Ok - there are some examples, now. I added additional checks if the resource can not be found and reimplemented the PageParameters constructors. I used the following code to convert the PageParameters into a query string - hope this is ok: Url encoded = new PageParametersEncoder().encodePageParameters(pageParameters); String queryString = encoded.getQueryString(); The line is returning 'null' for a valid video located in the package with the correct scope - any idea what it could be? - This issue was only a fault of my IDE which does not copied the video.mp4 into the target/classes folder. One little hint I also mentioned in the Examples Page: Videos are from: http://media.w3.org/2010/05/video/ Images are from: http://search.creativecommons.org/ with check on commercial use and modify... Support for HTML 5 media tags (audio / video) - Key: WICKET-5819 URL: https://issues.apache.org/jira/browse/WICKET-5819 Project: Wicket Issue Type: New Feature Components: wicket Affects Versions: 7.0.0-M5 Reporter: Tobias Soloschenko Assignee: Martin Grigorov Labels: features It would be great to embed video and audio files with the html5 tags: http://www.w3schools.com/html/html5_video.asp http://www.w3schools.com/html/html5_audio.asp http://dev.w3.org/html5/spec-author-view/video.html A documentation / implementation is provided here: https://github.com/klopfdreh/wicket-components-playground -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5827) Allow to apply multiple Javascript / CSS compressors
[ https://issues.apache.org/jira/browse/WICKET-5827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322652#comment-14322652 ] ASF GitHub Bot commented on WICKET-5827: GitHub user klopfdreh opened a pull request: https://github.com/apache/wicket/pull/94 WICKET-5827 bugfixes + CssUrlReplacer / CompositeCssCompressor must implement ICssCompressor, otherwise they can't be added to getResourceSettings().setCssCompressor(..) + replaced content of IScopeAwareTextResourceProcessor should be stored compressed = processor.process(compressed, scope, name); You can merge this pull request into a Git repository by running: $ git pull https://github.com/klopfdreh/wicket WICKET-5827_bugfixes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/wicket/pull/94.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #94 commit 9303b8b0a1779f94000f86aea6c3152c522b6a1a Author: klopfdreh klopfdreh@192.168.2.110 Date: 2015-02-16T11:11:21Z WICKET-5827 bugfixes Allow to apply multiple Javascript / CSS compressors Key: WICKET-5827 URL: https://issues.apache.org/jira/browse/WICKET-5827 Project: Wicket Issue Type: New Feature Components: wicket Affects Versions: 6.20.0, 7.0.0-M6 Reporter: Tobias Soloschenko Assignee: Martin Grigorov Priority: Minor Labels: features Fix For: 6.20.0, 7.0.0-M6 It would be nice to be able to add several css and javascript compressions in a chain. Example for CSS: CssRemoveCommentsCompressor CssUrlReplacementCompressor CssMinifyCompressor The same would be nice for JavaScript files. https://github.com/apache/wicket/pull/88 https://github.com/apache/wicket/pull/87 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5827) Allow to apply multiple Javascript / CSS compressors
[ https://issues.apache.org/jira/browse/WICKET-5827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322657#comment-14322657 ] ASF GitHub Bot commented on WICKET-5827: GitHub user klopfdreh opened a pull request: https://github.com/apache/wicket/pull/95 WICKET-5827 bugfixes 6.x + CssUrlReplacer / CompositeCssCompressor must implement ICssCompressor, otherwise they can't be added to getResourceSettings().setCssCompressor(..) + replaced content of IScopeAwareTextResourceProcessor should be stored compressed = processor.process(compressed, scope, name); You can merge this pull request into a Git repository by running: $ git pull https://github.com/klopfdreh/wicket WICKET-5827_bugfixes_6.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/wicket/pull/95.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #95 commit c92ad1348eec047453e0980f01d5a1713927b69f Author: klopfdreh klopfdreh@192.168.2.110 Date: 2015-02-16T11:19:21Z WICKET-5827 bugfixes Allow to apply multiple Javascript / CSS compressors Key: WICKET-5827 URL: https://issues.apache.org/jira/browse/WICKET-5827 Project: Wicket Issue Type: New Feature Components: wicket Affects Versions: 6.20.0, 7.0.0-M6 Reporter: Tobias Soloschenko Assignee: Martin Grigorov Priority: Minor Labels: features Fix For: 6.20.0, 7.0.0-M6 It would be nice to be able to add several css and javascript compressions in a chain. Example for CSS: CssRemoveCommentsCompressor CssUrlReplacementCompressor CssMinifyCompressor The same would be nice for JavaScript files. https://github.com/apache/wicket/pull/88 https://github.com/apache/wicket/pull/87 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
