[jira] [Commented] (WICKET-6287) Switch from json.org to open-json
[ https://issues.apache.org/jira/browse/WICKET-6287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15733220#comment-15733220 ] ASF GitHub Bot commented on WICKET-6287: Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/193 Sorry I wasn't clear. I asked if this PR is complete and if we should proceed merging it and wicketstuff/core#566. > Switch from json.org to open-json > - > > Key: WICKET-6287 > URL: https://issues.apache.org/jira/browse/WICKET-6287 > Project: Wicket > Issue Type: Task > Components: wicket, wicket-atmosphere, wicket-extensions >Affects Versions: 8.0.0-M2, 6.25.0, 7.5.0 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko >Priority: Minor > Labels: license > Fix For: 6.26, 7.6.0, 8.0.0-M3 > > > Because of license issues it is required to switch from json.org: > https://github.com/stleary/JSON-java > to open-json: > https://github.com/tdunning/open-json > For more information see: > http://apache-wicket.1842946.n4.nabble.com/Fwd-JSON-License-and-Apache-Projects-td4676261.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6296) Not possible to add WebSocketBehavior in ajax request
[ https://issues.apache.org/jira/browse/WICKET-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vit Springl updated WICKET-6296: Description: Due to a change in WICKET-6152 the renderHead method in BaseWebSocketBehavior is never called if the WebSocketBehavior is added in an Ajax request. This makes using web sockets more complicated in a single ajax page scenario. -(Wouldn't it be possible to use page metadata instead of requestcycle metadata, for instance?)- (was: Due to a change in WICKET-6152 the renderHead method in BaseWebSocketBehavior is never called if the WebSocketBehavior is added in an Ajax request. This makes using web sockets more complicated in a single ajax page scenario. (Wouldn't it be possible to use page metadata instead of requestcycle metadata, for instance?)) > Not possible to add WebSocketBehavior in ajax request > - > > Key: WICKET-6296 > URL: https://issues.apache.org/jira/browse/WICKET-6296 > Project: Wicket > Issue Type: Bug > Components: wicket-native-websocket >Affects Versions: 7.3.0, 8.0.0-M1, 6.23.0 >Reporter: Vit Springl >Assignee: Martin Grigorov > > Due to a change in WICKET-6152 the renderHead method in BaseWebSocketBehavior > is never called if the WebSocketBehavior is added in an Ajax request. This > makes using web sockets more complicated in a single ajax page scenario. > -(Wouldn't it be possible to use page metadata instead of requestcycle > metadata, for instance?)- -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6296) Not possible to add WebSocketBehavior in ajax request
[ https://issues.apache.org/jira/browse/WICKET-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15732668#comment-15732668 ] Vit Springl commented on WICKET-6296: - Hello, thank you for a quick reply. The thing is I am unable to replicate the problem described in WICKET-6152 and, therefore, I cannot verify that the fix doesn't break anything. I tried adding two websocket behaviors to different parts of the component tree of a page in a non-ajax and ajax requests and in both cases even if I delete the the whole renderHead method in WebSocketBehavior (i.e. the whole check whether the java script has already been contributed in the current request cycle) everything seems to work - the javascript reference is added only once to the DOM and the broadcast works properly too - the onConnect and onMessage methods have been called for both behaviors. Adding the id to the JavaScriptHeaderItem doesn't seem to be necessary, it works with or without the id. > Not possible to add WebSocketBehavior in ajax request > - > > Key: WICKET-6296 > URL: https://issues.apache.org/jira/browse/WICKET-6296 > Project: Wicket > Issue Type: Bug > Components: wicket-native-websocket >Affects Versions: 7.3.0, 8.0.0-M1, 6.23.0 >Reporter: Vit Springl >Assignee: Martin Grigorov > > Due to a change in WICKET-6152 the renderHead method in BaseWebSocketBehavior > is never called if the WebSocketBehavior is added in an Ajax request. This > makes using web sockets more complicated in a single ajax page scenario. > (Wouldn't it be possible to use page metadata instead of requestcycle > metadata, for instance?) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6287) Switch from json.org to open-json
[ https://issues.apache.org/jira/browse/WICKET-6287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15732643#comment-15732643 ] ASF GitHub Bot commented on WICKET-6287: Github user klopfdreh commented on the issue: https://github.com/apache/wicket/pull/193 @bitstorm - there are two different PRs for 6.x and 7.x to preserve the API integrity. > Switch from json.org to open-json > - > > Key: WICKET-6287 > URL: https://issues.apache.org/jira/browse/WICKET-6287 > Project: Wicket > Issue Type: Task > Components: wicket, wicket-atmosphere, wicket-extensions >Affects Versions: 8.0.0-M2, 6.25.0, 7.5.0 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko >Priority: Minor > Labels: license > Fix For: 6.26, 7.6.0, 8.0.0-M3 > > > Because of license issues it is required to switch from json.org: > https://github.com/stleary/JSON-java > to open-json: > https://github.com/tdunning/open-json > For more information see: > http://apache-wicket.1842946.n4.nabble.com/Fwd-JSON-License-and-Apache-Projects-td4676261.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6287) Switch from json.org to open-json
[ https://issues.apache.org/jira/browse/WICKET-6287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15732630#comment-15732630 ] ASF GitHub Bot commented on WICKET-6287: Github user klopfdreh commented on the issue: https://github.com/apache/wicket/pull/195 Great! 😄 - so if everything is working - we should integrate all PR for open-json. But I suggest to test all dependencies (also for wicketstuff) > Switch from json.org to open-json > - > > Key: WICKET-6287 > URL: https://issues.apache.org/jira/browse/WICKET-6287 > Project: Wicket > Issue Type: Task > Components: wicket, wicket-atmosphere, wicket-extensions >Affects Versions: 8.0.0-M2, 6.25.0, 7.5.0 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko >Priority: Minor > Labels: license > Fix For: 6.26, 7.6.0, 8.0.0-M3 > > > Because of license issues it is required to switch from json.org: > https://github.com/stleary/JSON-java > to open-json: > https://github.com/tdunning/open-json > For more information see: > http://apache-wicket.1842946.n4.nabble.com/Fwd-JSON-License-and-Apache-Projects-td4676261.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6287) Switch from json.org to open-json
[ https://issues.apache.org/jira/browse/WICKET-6287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15732621#comment-15732621 ] ASF GitHub Bot commented on WICKET-6287: Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/193 @klopfdreh @martin-g Shall we go ahead merging or do you prefer to port the pr to the other two branches first? > Switch from json.org to open-json > - > > Key: WICKET-6287 > URL: https://issues.apache.org/jira/browse/WICKET-6287 > Project: Wicket > Issue Type: Task > Components: wicket, wicket-atmosphere, wicket-extensions >Affects Versions: 8.0.0-M2, 6.25.0, 7.5.0 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko >Priority: Minor > Labels: license > Fix For: 6.26, 7.6.0, 8.0.0-M3 > > > Because of license issues it is required to switch from json.org: > https://github.com/stleary/JSON-java > to open-json: > https://github.com/tdunning/open-json > For more information see: > http://apache-wicket.1842946.n4.nabble.com/Fwd-JSON-License-and-Apache-Projects-td4676261.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6287) Switch from json.org to open-json
[ https://issues.apache.org/jira/browse/WICKET-6287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15732544#comment-15732544 ] ASF GitHub Bot commented on WICKET-6287: Github user martin-g commented on the issue: https://github.com/apache/wicket/pull/195 The build passes with JDK1.7! > Switch from json.org to open-json > - > > Key: WICKET-6287 > URL: https://issues.apache.org/jira/browse/WICKET-6287 > Project: Wicket > Issue Type: Task > Components: wicket, wicket-atmosphere, wicket-extensions >Affects Versions: 8.0.0-M2, 6.25.0, 7.5.0 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko >Priority: Minor > Labels: license > Fix For: 6.26, 7.6.0, 8.0.0-M3 > > > Because of license issues it is required to switch from json.org: > https://github.com/stleary/JSON-java > to open-json: > https://github.com/tdunning/open-json > For more information see: > http://apache-wicket.1842946.n4.nabble.com/Fwd-JSON-License-and-Apache-Projects-td4676261.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (WICKET-6295) Clicking Link in BrowserInfoPage results in infinite request loop
[
https://issues.apache.org/jira/browse/WICKET-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sven Meier resolved WICKET-6295.
Resolution: Fixed
Assignee: Sven Meier
Fix Version/s: 6.26
The meta refresh consumes the original destination, the following click on the
link will lead into a infinite loop of browserInfo pages.
Fixed. Could you give it a test drive? Thanks.
> Clicking Link in BrowserInfoPage results in infinite request loop
> -
>
> Key: WICKET-6295
> URL: https://issues.apache.org/jira/browse/WICKET-6295
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 6.25.0
>Reporter: Daniel Radünz
>Assignee: Sven Meier
> Fix For: 6.26
>
>
> Clicking on the link in the BrowserInfoPage used to gather extended browser
> information results in an infinite loop in which the browser is alternating
> between sending several GET and POST request per second for the
> BrowserInfoPage.
> Based on QuickStart with Wicket 6.25:
> {code:Java|title=WicketApplication.java}
> ...
> @Override
> public void init()
> {
> super.init();
> getRequestCycleSettings().setGatherExtendedBrowserInfo(true);
> }
> ...
> {code}
> {code:Java|title=Homapage.java}
> public class HomePage extends WebPage {
> private static final long serialVersionUID = 1L;
> public HomePage(final PageParameters parameters) {
> super(parameters);
> // Get ClientInfo for example to conditionally add components
> // further down in the code
> ClientInfo clientInfo = Session.get().getClientInfo();
> // Run code that takes a few seconds, just long enough to allow
> // an impatient user to click the link in the BrowserInfoPage
> try {
> Thread.sleep(3000);
> } catch (InterruptedException e) {
> }
> add(new Label("version",
> getApplication().getFrameworkSettings().getVersion()));
> }
> }
> {code}
> Wicket 7 does not exhibit this behavior.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-6295) Clicking Link in BrowserInfoPage results in infinite request loop
[
https://issues.apache.org/jira/browse/WICKET-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15732530#comment-15732530
]
ASF subversion and git services commented on WICKET-6295:
-
Commit 7b239ca45a876a9b90da6e90001bcbb36578574b in wicket's branch
refs/heads/wicket-6.x from [~svenmeier]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=7b239ca ]
WICKET-6295 fallback to home page
a previous request might have consumed the original destination - this could
happen if the meta refresh fires but the user is still able to link on the link
> Clicking Link in BrowserInfoPage results in infinite request loop
> -
>
> Key: WICKET-6295
> URL: https://issues.apache.org/jira/browse/WICKET-6295
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 6.25.0
>Reporter: Daniel Radünz
>
> Clicking on the link in the BrowserInfoPage used to gather extended browser
> information results in an infinite loop in which the browser is alternating
> between sending several GET and POST request per second for the
> BrowserInfoPage.
> Based on QuickStart with Wicket 6.25:
> {code:Java|title=WicketApplication.java}
> ...
> @Override
> public void init()
> {
> super.init();
> getRequestCycleSettings().setGatherExtendedBrowserInfo(true);
> }
> ...
> {code}
> {code:Java|title=Homapage.java}
> public class HomePage extends WebPage {
> private static final long serialVersionUID = 1L;
> public HomePage(final PageParameters parameters) {
> super(parameters);
> // Get ClientInfo for example to conditionally add components
> // further down in the code
> ClientInfo clientInfo = Session.get().getClientInfo();
> // Run code that takes a few seconds, just long enough to allow
> // an impatient user to click the link in the BrowserInfoPage
> try {
> Thread.sleep(3000);
> } catch (InterruptedException e) {
> }
> add(new Label("version",
> getApplication().getFrameworkSettings().getVersion()));
> }
> }
> {code}
> Wicket 7 does not exhibit this behavior.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
wicket git commit: WICKET-6295 fallback to home page a previous request might have consumed the original destination - this could happen if the meta refresh fires but the user is still able to link on
Repository: wicket
Updated Branches:
refs/heads/wicket-6.x e493b0435 -> 7b239ca45
WICKET-6295 fallback to home page
a previous request might have consumed the original destination - this could
happen if the meta refresh fires but the user is still able to link on the link
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/7b239ca4
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/7b239ca4
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/7b239ca4
Branch: refs/heads/wicket-6.x
Commit: 7b239ca45a876a9b90da6e90001bcbb36578574b
Parents: e493b04
Author: Sven Meier
Authored: Thu Dec 8 16:29:29 2016 +0100
Committer: Sven Meier
Committed: Thu Dec 8 16:29:29 2016 +0100
--
.../markup/html/pages/BrowserInfoPage.java | 24
1 file changed, 9 insertions(+), 15 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/7b239ca4/wicket-core/src/main/java/org/apache/wicket/markup/html/pages/BrowserInfoPage.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/markup/html/pages/BrowserInfoPage.java
b/wicket-core/src/main/java/org/apache/wicket/markup/html/pages/BrowserInfoPage.java
index 373cbb5..507cd9e 100644
---
a/wicket-core/src/main/java/org/apache/wicket/markup/html/pages/BrowserInfoPage.java
+++
b/wicket-core/src/main/java/org/apache/wicket/markup/html/pages/BrowserInfoPage.java
@@ -25,14 +25,12 @@ import org.apache.wicket.markup.html.WebPage;
import org.apache.wicket.model.AbstractReadOnlyModel;
import org.apache.wicket.model.IModel;
import org.apache.wicket.model.LoadableDetachableModel;
-import org.apache.wicket.protocol.http.ClientProperties;
import org.apache.wicket.protocol.http.WebSession;
import org.apache.wicket.protocol.http.request.WebClientInfo;
import org.apache.wicket.request.cycle.RequestCycle;
import org.apache.wicket.settings.IRequestCycleSettings;
/**
- *
* This page uses a form post right after the page has loaded in the browser,
using JavaScript or
* alternative means to detect and pass on settings to the embedded form. The
form submit method
* updates this session's {@link org.apache.wicket.core.request.ClientInfo}
object and then redirects to
@@ -53,28 +51,24 @@ public class BrowserInfoPage extends WebPage
private BrowserInfoForm browserInfoForm;
/**
-* Bookmarkable constructor. This is not for normal framework client
use. It will be called
-* whenever JavaScript is not supported, and the browser info page's
meta refresh fires to this
-* page. Prior to this, the other constructor should already have been
called.
+* This constructor will be called twice, once to display the initial
page and additionally when JavaScript
+* is not enabled and the meta refresh fires or the user clicks the
link instead.
*/
public BrowserInfoPage()
{
initComps();
RequestCycle requestCycle = getRequestCycle();
WebSession session = (WebSession)getSession();
+
WebClientInfo clientInfo = session.getClientInfo();
- if (clientInfo == null)
+ if (clientInfo != null)
{
- clientInfo = new WebClientInfo(requestCycle);
- getSession().setClientInfo(clientInfo);
+ // clientInfo is already present so continue
+ continueToOriginalDestination();
+
+ // switch to home page if no original destination was
intercepted
+ setResponsePage(getApplication().getHomePage());
}
- else
- {
- ClientProperties properties =
clientInfo.getProperties();
- properties.setJavaEnabled(false);
- }
-
- continueToOriginalDestination();
}
@Override
[jira] [Commented] (WICKET-6287) Switch from json.org to open-json
[ https://issues.apache.org/jira/browse/WICKET-6287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15732315#comment-15732315 ] ASF GitHub Bot commented on WICKET-6287: Github user klopfdreh commented on the issue: https://github.com/apache/wicket/pull/195 @martin-g I rebased it and pushed it again. Should be up to date now. > Switch from json.org to open-json > - > > Key: WICKET-6287 > URL: https://issues.apache.org/jira/browse/WICKET-6287 > Project: Wicket > Issue Type: Task > Components: wicket, wicket-atmosphere, wicket-extensions >Affects Versions: 8.0.0-M2, 6.25.0, 7.5.0 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko >Priority: Minor > Labels: license > Fix For: 6.26, 7.6.0, 8.0.0-M3 > > > Because of license issues it is required to switch from json.org: > https://github.com/stleary/JSON-java > to open-json: > https://github.com/tdunning/open-json > For more information see: > http://apache-wicket.1842946.n4.nabble.com/Fwd-JSON-License-and-Apache-Projects-td4676261.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6296) Not possible to add WebSocketBehavior in ajax request
[ https://issues.apache.org/jira/browse/WICKET-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15732243#comment-15732243 ] Martin Grigorov commented on WICKET-6296: - A (stateful) page could be rendered many times. In this case the header contributions should be done for each of them. Another solution would be to remove the check for "isAjax" and contribute a JS HeaderItem with id. This way Wicket will not insert it twice in the page's DOM. Do you want to give this a try and send us a Pull Request / attach a patch ? > Not possible to add WebSocketBehavior in ajax request > - > > Key: WICKET-6296 > URL: https://issues.apache.org/jira/browse/WICKET-6296 > Project: Wicket > Issue Type: Bug > Components: wicket-native-websocket >Affects Versions: 7.3.0, 8.0.0-M1, 6.23.0 >Reporter: Vit Springl >Assignee: Martin Grigorov > > Due to a change in WICKET-6152 the renderHead method in BaseWebSocketBehavior > is never called if the WebSocketBehavior is added in an Ajax request. This > makes using web sockets more complicated in a single ajax page scenario. > (Wouldn't it be possible to use page metadata instead of requestcycle > metadata, for instance?) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6287) Switch from json.org to open-json
[ https://issues.apache.org/jira/browse/WICKET-6287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15732223#comment-15732223 ] ASF GitHub Bot commented on WICKET-6287: Github user duesenklipper commented on the issue: https://github.com/apache/wicket/pull/195 @martin-g I hate German translations of computer terms, which is the main reason my systems are all in English. But as mentioned elsewhere, I use a split locale instead, with formatting set to German. Thus I break things in other ways ;-) > Switch from json.org to open-json > - > > Key: WICKET-6287 > URL: https://issues.apache.org/jira/browse/WICKET-6287 > Project: Wicket > Issue Type: Task > Components: wicket, wicket-atmosphere, wicket-extensions >Affects Versions: 8.0.0-M2, 6.25.0, 7.5.0 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko >Priority: Minor > Labels: license > Fix For: 6.26, 7.6.0, 8.0.0-M3 > > > Because of license issues it is required to switch from json.org: > https://github.com/stleary/JSON-java > to open-json: > https://github.com/tdunning/open-json > For more information see: > http://apache-wicket.1842946.n4.nabble.com/Fwd-JSON-License-and-Apache-Projects-td4676261.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
wicket git commit: fix CssUrlReplacerTest to work again with other locales
Repository: wicket
Updated Branches:
refs/heads/wicket-6.x 7e42573b1 -> e493b0435
fix CssUrlReplacerTest to work again with other locales
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/e493b043
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/e493b043
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/e493b043
Branch: refs/heads/wicket-6.x
Commit: e493b0435ee66d2256ca02a972b01b6e9b4e01ae
Parents: 7e42573
Author: Carl-Eric Menzel
Authored: Thu Dec 8 14:27:59 2016 +0100
Committer: Carl-Eric Menzel
Committed: Thu Dec 8 14:27:59 2016 +0100
--
.../org/apache/wicket/resource/CssUrlReplacerTest.java | 11 +++
1 file changed, 11 insertions(+)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/e493b043/wicket-core/src/test/java/org/apache/wicket/resource/CssUrlReplacerTest.java
--
diff --git
a/wicket-core/src/test/java/org/apache/wicket/resource/CssUrlReplacerTest.java
b/wicket-core/src/test/java/org/apache/wicket/resource/CssUrlReplacerTest.java
index 58ee5fc..f3888ce 100644
---
a/wicket-core/src/test/java/org/apache/wicket/resource/CssUrlReplacerTest.java
+++
b/wicket-core/src/test/java/org/apache/wicket/resource/CssUrlReplacerTest.java
@@ -19,6 +19,8 @@ package org.apache.wicket.resource;
import static org.hamcrest.Matchers.containsString;
import static org.hamcrest.Matchers.is;
+import java.util.Locale;
+
import org.apache.wicket.WicketTestCase;
import org.apache.wicket.markup.html.image.ImageTest;
import org.apache.wicket.mock.MockApplication;
@@ -27,6 +29,7 @@ import
org.apache.wicket.request.resource.caching.FilenameWithVersionResourceCac
import org.apache.wicket.request.resource.caching.IStaticCacheableResource;
import org.apache.wicket.request.resource.caching.ResourceUrl;
import
org.apache.wicket.request.resource.caching.version.MessageDigestResourceVersion;
+import org.junit.Before;
import org.junit.Test;
public class CssUrlReplacerTest extends WicketTestCase
@@ -58,6 +61,14 @@ public class CssUrlReplacerTest extends WicketTestCase
};
}
+ @Before
+ public void before()
+ {
+ // if not ENGLISH then the #base64EncodedImage test will pick
up a different GIF than the one we're expecting
+ // here.
+ tester.getSession().setLocale(Locale.ENGLISH);
+ }
+
@Test
public void doNotProcessFullUrls()
{
[jira] [Created] (WICKET-6296) Not possible to add WebSocketBehavior in ajax request
Vit Springl created WICKET-6296: --- Summary: Not possible to add WebSocketBehavior in ajax request Key: WICKET-6296 URL: https://issues.apache.org/jira/browse/WICKET-6296 Project: Wicket Issue Type: Bug Components: wicket-native-websocket Affects Versions: 6.23.0, 8.0.0-M1, 7.3.0 Reporter: Vit Springl Assignee: Martin Grigorov Due to a change in WICKET-6152 the renderHead method in BaseWebSocketBehavior is never called if the WebSocketBehavior is added in an Ajax request. This makes using web sockets more complicated in a single ajax page scenario. (Wouldn't it be possible to use page metadata instead of requestcycle metadata, for instance?) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6286) Would be good to have AjaxDownload available out of the box
[ https://issues.apache.org/jira/browse/WICKET-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15732082#comment-15732082 ] Martin Grigorov commented on WICKET-6286: - Is it a good idea to use IResourceStreamWriter instead ? This way the developer will be guided to stream the data instead of loading it into the memory ? > Would be good to have AjaxDownload available out of the box > > > Key: WICKET-6286 > URL: https://issues.apache.org/jira/browse/WICKET-6286 > Project: Wicket > Issue Type: New Feature > Components: wicket-extensions >Affects Versions: 8.0.0-M2, 7.5.0 >Reporter: Maxim Solodovnik >Assignee: Sven Meier > Labels: patch > > Currently every project need to create own AjaxDownload component based on > the Wiki example. > Unfortunately this component has some issues with WebSockets > Discussion: http://markmail.org/message/gizsnqh2qgypcgri > PRs: > https://github.com/apache/wicket/pull/190 > https://github.com/apache/wicket/pull/191 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6286) Would be good to have AjaxDownload available out of the box
[ https://issues.apache.org/jira/browse/WICKET-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15732079#comment-15732079 ] Maxim Solodovnik commented on WICKET-6286: -- Sure :) Sorry :( I ws afraid it will not be included in 7.6.0 :( > Would be good to have AjaxDownload available out of the box > > > Key: WICKET-6286 > URL: https://issues.apache.org/jira/browse/WICKET-6286 > Project: Wicket > Issue Type: New Feature > Components: wicket-extensions >Affects Versions: 8.0.0-M2, 7.5.0 >Reporter: Maxim Solodovnik >Assignee: Sven Meier > Labels: patch > > Currently every project need to create own AjaxDownload component based on > the Wiki example. > Unfortunately this component has some issues with WebSockets > Discussion: http://markmail.org/message/gizsnqh2qgypcgri > PRs: > https://github.com/apache/wicket/pull/190 > https://github.com/apache/wicket/pull/191 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6287) Switch from json.org to open-json
[ https://issues.apache.org/jira/browse/WICKET-6287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15732068#comment-15732068 ] ASF GitHub Bot commented on WICKET-6287: Github user martin-g commented on the issue: https://github.com/apache/wicket/pull/195 @duesenklipper I am the non-German guy here but it seems it is just me who uses de_DE locale to catch such kind of problems :-) Your fix is good! @klopfdreh Please update this branch to latest wicket-7.x and I'll retest it again with JDK1.7 > Switch from json.org to open-json > - > > Key: WICKET-6287 > URL: https://issues.apache.org/jira/browse/WICKET-6287 > Project: Wicket > Issue Type: Task > Components: wicket, wicket-atmosphere, wicket-extensions >Affects Versions: 8.0.0-M2, 6.25.0, 7.5.0 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko >Priority: Minor > Labels: license > Fix For: 6.26, 7.6.0, 8.0.0-M3 > > > Because of license issues it is required to switch from json.org: > https://github.com/stleary/JSON-java > to open-json: > https://github.com/tdunning/open-json > For more information see: > http://apache-wicket.1842946.n4.nabble.com/Fwd-JSON-License-and-Apache-Projects-td4676261.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (WICKET-6295) Clicking Link in BrowserInfoPage results in infinite request loop
Daniel Radünz created WICKET-6295:
-
Summary: Clicking Link in BrowserInfoPage results in infinite
request loop
Key: WICKET-6295
URL: https://issues.apache.org/jira/browse/WICKET-6295
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.25.0
Reporter: Daniel Radünz
Clicking on the link in the BrowserInfoPage used to gather extended browser
information results in an infinite loop in which the browser is alternating
between sending several GET and POST request per second for the BrowserInfoPage.
Based on QuickStart with Wicket 6.25:
{code:Java|title=WicketApplication.java}
...
@Override
public void init()
{
super.init();
getRequestCycleSettings().setGatherExtendedBrowserInfo(true);
}
...
{code}
{code:Java|title=Homapage.java}
public class HomePage extends WebPage {
private static final long serialVersionUID = 1L;
public HomePage(final PageParameters parameters) {
super(parameters);
// Get ClientInfo for example to conditionally add components
// further down in the code
ClientInfo clientInfo = Session.get().getClientInfo();
// Run code that takes a few seconds, just long enough to allow
// an impatient user to click the link in the BrowserInfoPage
try {
Thread.sleep(3000);
} catch (InterruptedException e) {
}
add(new Label("version",
getApplication().getFrameworkSettings().getVersion()));
}
}
{code}
Wicket 7 does not exhibit this behavior.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
wicket git commit: fix CssUrlReplacerTest to work again with other locales
Repository: wicket
Updated Branches:
refs/heads/wicket-7.x 5bfa280b2 -> 091dbbe4a
fix CssUrlReplacerTest to work again with other locales
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/091dbbe4
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/091dbbe4
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/091dbbe4
Branch: refs/heads/wicket-7.x
Commit: 091dbbe4a714018517127665923b9030ae9376cb
Parents: 5bfa280
Author: Carl-Eric Menzel
Authored: Thu Dec 8 11:56:44 2016 +0100
Committer: Carl-Eric Menzel
Committed: Thu Dec 8 12:12:22 2016 +0100
--
.../org/apache/wicket/resource/CssUrlReplacerTest.java | 11 +++
1 file changed, 11 insertions(+)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/091dbbe4/wicket-core/src/test/java/org/apache/wicket/resource/CssUrlReplacerTest.java
--
diff --git
a/wicket-core/src/test/java/org/apache/wicket/resource/CssUrlReplacerTest.java
b/wicket-core/src/test/java/org/apache/wicket/resource/CssUrlReplacerTest.java
index 675c665..ed8a811 100644
---
a/wicket-core/src/test/java/org/apache/wicket/resource/CssUrlReplacerTest.java
+++
b/wicket-core/src/test/java/org/apache/wicket/resource/CssUrlReplacerTest.java
@@ -19,6 +19,8 @@ package org.apache.wicket.resource;
import static org.hamcrest.Matchers.containsString;
import static org.hamcrest.Matchers.is;
+import java.util.Locale;
+
import org.apache.wicket.markup.html.image.ImageTest;
import org.apache.wicket.mock.MockApplication;
import org.apache.wicket.protocol.http.WebApplication;
@@ -27,6 +29,7 @@ import
org.apache.wicket.request.resource.caching.IStaticCacheableResource;
import org.apache.wicket.request.resource.caching.ResourceUrl;
import
org.apache.wicket.request.resource.caching.version.MessageDigestResourceVersion;
import org.apache.wicket.util.tester.WicketTestCase;
+import org.junit.Before;
import org.junit.Test;
public class CssUrlReplacerTest extends WicketTestCase
@@ -58,6 +61,14 @@ public class CssUrlReplacerTest extends WicketTestCase
};
}
+ @Before
+ public void before()
+ {
+ // if not ENGLISH then the #base64EncodedImage test will pick
up a different GIF than the one we're expecting
+ // here.
+ tester.getSession().setLocale(Locale.ENGLISH);
+ }
+
@Test
public void doNotProcessFullUrls()
{
[jira] [Commented] (WICKET-6287) Switch from json.org to open-json
[ https://issues.apache.org/jira/browse/WICKET-6287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15731839#comment-15731839 ] ASF GitHub Bot commented on WICKET-6287: Github user duesenklipper commented on the issue: https://github.com/apache/wicket/pull/195 @klopfdreh I know you did ;-) @martin-g I found it. @klopfdreh is right, it has something to do with Locale. My fault - for some reason I lost the `@Before` method in `CssUrlReplacerTest` that set the Locale to English, when I updated that test for data urls. I'll push the fix to the main branches. Sorry about that! > Switch from json.org to open-json > - > > Key: WICKET-6287 > URL: https://issues.apache.org/jira/browse/WICKET-6287 > Project: Wicket > Issue Type: Task > Components: wicket, wicket-atmosphere, wicket-extensions >Affects Versions: 8.0.0-M2, 6.25.0, 7.5.0 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko >Priority: Minor > Labels: license > Fix For: 6.26, 7.6.0, 8.0.0-M3 > > > Because of license issues it is required to switch from json.org: > https://github.com/stleary/JSON-java > to open-json: > https://github.com/tdunning/open-json > For more information see: > http://apache-wicket.1842946.n4.nabble.com/Fwd-JSON-License-and-Apache-Projects-td4676261.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6286) Would be good to have AjaxDownload available out of the box
[ https://issues.apache.org/jira/browse/WICKET-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15731756#comment-15731756 ] Sven Meier commented on WICKET-6286: I hear you ;) There are a few issues I'd like to have addressed before we put this into extensions: - I don't think it's a good idea to introduce a field for the resource stream, this will invite people to keep large data inside the component tree (e.g. a StringResourceStream with the generated content) - it would be nice to support resource references too, so that the page is not locked while the download is generated - example and tests are missing Furthermore I'm playing with https://github.com/johnculviner/jquery.fileDownload currently. I have a prototype running that allows to display a popup/information while the download is generated. I'll push a branch this weekend, perhaps you have time to look at it? > Would be good to have AjaxDownload available out of the box > > > Key: WICKET-6286 > URL: https://issues.apache.org/jira/browse/WICKET-6286 > Project: Wicket > Issue Type: New Feature > Components: wicket-extensions >Affects Versions: 8.0.0-M2, 7.5.0 >Reporter: Maxim Solodovnik >Assignee: Sven Meier > Labels: patch > > Currently every project need to create own AjaxDownload component based on > the Wiki example. > Unfortunately this component has some issues with WebSockets > Discussion: http://markmail.org/message/gizsnqh2qgypcgri > PRs: > https://github.com/apache/wicket/pull/190 > https://github.com/apache/wicket/pull/191 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
