[jira] [Commented] (WICKET-6449) Form should raise validation error when required checkbox is not set
[ https://issues.apache.org/jira/browse/WICKET-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126764#comment-16126764 ] Maxim Solodovnik commented on WICKET-6449: -- I would agree with comments to WICKET-1221 Both true and false are valid values for checkbox, it is not tri-state component In your dropdown example error will be raised only in case value is null, in case dropdown is not nullable onError will not be called even if user will not make any choice And I believe you are right setRequired does not make much sense for checkbox > Form should raise validation error when required checkbox is not set > > > Key: WICKET-6449 > URL: https://issues.apache.org/jira/browse/WICKET-6449 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.0.0-M6 >Reporter: Kamil >Assignee: Sven Meier > Attachments: showcase-requiredCheckbox.zip > > > Every user before he registers must agree to terms, thus proper > checkbox is required to check and validation error should be raised when > required checkbox is not checked. > This test case shows incorrect behavior -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6448) IndicatingAjaxButton should prevent double submit
[ https://issues.apache.org/jira/browse/WICKET-6448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126621#comment-16126621 ] Andrea Del Bene commented on WICKET-6448: - I'm also reluctant to provide such a behavior out of the box. I don't think it's possible to create a generic behavior that makes everybody happy. On the other hand it's quite easy to build a custom behavior tailored to your specific needs See this [example|http://examples-wickettutorial.rhcloud.com/wicket/bookmarkable/org.wicketTutorial.ajaxlistener.HomePage] > IndicatingAjaxButton should prevent double submit > - > > Key: WICKET-6448 > URL: https://issues.apache.org/jira/browse/WICKET-6448 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 8.0.0-M6 >Reporter: Kamil > Attachments: showcase-preventClick.zip > > > 1)Run the app > 2)Click "submit" quickly several times > 3)Watch the console -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6449) Form should raise validation error when required checkbox is not set
[ https://issues.apache.org/jira/browse/WICKET-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126552#comment-16126552 ] Kamil commented on WICKET-6449: --- But it was 4 years ago. Did you have this "onError" rule on other components back then? It's not about what I prefer. It's about if you want to have inconsistent API and confused users. Wicket is evolving - maybe it's time to at least reconsider this case. > Form should raise validation error when required checkbox is not set > > > Key: WICKET-6449 > URL: https://issues.apache.org/jira/browse/WICKET-6449 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.0.0-M6 >Reporter: Kamil >Assignee: Sven Meier > Attachments: showcase-requiredCheckbox.zip > > > Every user before he registers must agree to terms, thus proper > checkbox is required to check and validation error should be raised when > required checkbox is not checked. > This test case shows incorrect behavior -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6449) Form should raise validation error when required checkbox is not set
[ https://issues.apache.org/jira/browse/WICKET-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126245#comment-16126245 ] Sven Meier commented on WICKET-6449: I don't necessarily agree with the conclusion of 1221. But it was decided that way - you can argue both ways so we won't change it because you prefer one over the other. > Form should raise validation error when required checkbox is not set > > > Key: WICKET-6449 > URL: https://issues.apache.org/jira/browse/WICKET-6449 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.0.0-M6 >Reporter: Kamil >Assignee: Sven Meier > Attachments: showcase-requiredCheckbox.zip > > > Every user before he registers must agree to terms, thus proper > checkbox is required to check and validation error should be raised when > required checkbox is not checked. > This test case shows incorrect behavior -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6449) Form should raise validation error when required checkbox is not set
[ https://issues.apache.org/jira/browse/WICKET-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126171#comment-16126171 ] Kamil commented on WICKET-6449: --- Or putting it in different words: All the people from https://issues.apache.org/jira/browse/WICKET-1221 who don't want to handle onError behavior - why would they want to setRequired(true) in the first place? Especially if it doesn't do anything now. Why not to leave current behavior as it is (default "not required" checkbox) and add the required one? > Form should raise validation error when required checkbox is not set > > > Key: WICKET-6449 > URL: https://issues.apache.org/jira/browse/WICKET-6449 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.0.0-M6 >Reporter: Kamil >Assignee: Sven Meier > Attachments: showcase-requiredCheckbox.zip > > > Every user before he registers must agree to terms, thus proper > checkbox is required to check and validation error should be raised when > required checkbox is not checked. > This test case shows incorrect behavior -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (WICKET-6449) Form should raise validation error when required checkbox is not set
[ https://issues.apache.org/jira/browse/WICKET-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126072#comment-16126072 ] Kamil edited comment on WICKET-6449 at 8/14/17 6:01 PM: [~svenmeier], [~mgrigorov] When you have dropdown with setRequired(true) and you select empty value - you say that calling onError [is fine|https://issues.apache.org/jira/browse/WICKET-6403?focusedCommentId=16055931=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16055931] I understood this, I'm fine with this and I found this reasonable. But now with exactly same situation: Having checkbox with setRequired(true) and you uncheck it -> you say that onError [is wrong|https://issues.apache.org/jira/browse/WICKET-1221] how is this consistent?! Why would someone call setRequired(true) on checkbox if it has no effect? Currently: * I want chceckbox to be not required -> It is now whether you setRequired(true) or setRequired(false) * I want chceckbox to be required -> It can't be But if we make it consistent with "onError" behavior we can have win-win: * I want chceckbox to be not required -> I setRequired(false) and I have behavior I desire - exactly like today * I want chceckbox to be required -> I setRequired(true) and listen to "onError" was (Author: eximius): [~svenmeier], [~mgrigorov] When you have dropdown with setRequired(true) and you select empty value - you say that calling onError [is fine|https://issues.apache.org/jira/browse/WICKET-6403?focusedCommentId=16056113=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16056113] I understood this, I'm fine with this and I found this reasonable. But now with exactly same situation: Having checkbox with setRequired(true) and you uncheck it -> you say that onError [is wrong|https://issues.apache.org/jira/browse/WICKET-1221] how is this consistent?! Why would someone call setRequired(true) on checkbox if it has no effect? Currently: * I want chceckbox to be not required -> It is now * I want chceckbox to be required -> It can't be But if we make it consistent with "onError" behavior we can have win-win: * I want chceckbox to be not required -> I setRequired(false) and I have behavior I desire - exactly like today * I want chceckbox to be required -> I setRequired(true) and listen to "onError" > Form should raise validation error when required checkbox is not set > > > Key: WICKET-6449 > URL: https://issues.apache.org/jira/browse/WICKET-6449 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.0.0-M6 >Reporter: Kamil >Assignee: Sven Meier > Attachments: showcase-requiredCheckbox.zip > > > Every user before he registers must agree to terms, thus proper > checkbox is required to check and validation error should be raised when > required checkbox is not checked. > This test case shows incorrect behavior -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (WICKET-6449) Form should raise validation error when required checkbox is not set
[ https://issues.apache.org/jira/browse/WICKET-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126072#comment-16126072 ] Kamil edited comment on WICKET-6449 at 8/14/17 5:55 PM: [~svenmeier], [~mgrigorov] When you have dropdown with setRequired(true) and you select empty value - you say that calling onError [is fine|https://issues.apache.org/jira/browse/WICKET-6403?focusedCommentId=16056113=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16056113] I understood this, I'm fine with this and I found this reasonable. But now with exactly same situation: Having checkbox with setRequired(true) and you uncheck it -> you say that onError [is wrong|https://issues.apache.org/jira/browse/WICKET-1221] how is this consistent?! Why would someone call setRequired(true) on checkbox if it has no effect? Currently: * I want chceckbox to be not required -> It is now * I want chceckbox to be required -> It can't be But if we make it consistent with "onError" behavior we can have win-win: * I want chceckbox to be not required -> I setRequired(false) and I have behavior I desire - exactly like today * I want chceckbox to be required -> I setRequired(true) and listen to "onError" was (Author: eximius): [~svenmeier], [~mgrigorov] When you have dropdown with setRequired(true) and you select empty value - you say that calling onError [is fine|https://issues.apache.org/jira/browse/WICKET-6403?focusedCommentId=16056113=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16056113] I understood this, I'm fine with this and I found this reasonable. But now with exactly same situation: Having checkbox with setRequired(true) and you uncheck it -> you say that onError [is wrong|https://issues.apache.org/jira/browse/WICKET-1221] how is this consistent?! > Form should raise validation error when required checkbox is not set > > > Key: WICKET-6449 > URL: https://issues.apache.org/jira/browse/WICKET-6449 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.0.0-M6 >Reporter: Kamil >Assignee: Sven Meier > Attachments: showcase-requiredCheckbox.zip > > > Every user before he registers must agree to terms, thus proper > checkbox is required to check and validation error should be raised when > required checkbox is not checked. > This test case shows incorrect behavior -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6449) Form should raise validation error when required checkbox is not set
[ https://issues.apache.org/jira/browse/WICKET-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126072#comment-16126072 ] Kamil commented on WICKET-6449: --- [~svenmeier], [~mgrigorov] When you have dropdown with setRequired(true) and you select empty value - you say that calling onError [is fine|https://issues.apache.org/jira/browse/WICKET-6403?focusedCommentId=16056113=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16056113] I understood this, I'm fine with this and I found this reasonable. But now with exactly same situation: Having checkbox with setRequired(true) and you uncheck it -> you say that onError [is wrong|https://issues.apache.org/jira/browse/WICKET-1221] how is this consistent?! > Form should raise validation error when required checkbox is not set > > > Key: WICKET-6449 > URL: https://issues.apache.org/jira/browse/WICKET-6449 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.0.0-M6 >Reporter: Kamil >Assignee: Sven Meier > Attachments: showcase-requiredCheckbox.zip > > > Every user before he registers must agree to terms, thus proper > checkbox is required to check and validation error should be raised when > required checkbox is not checked. > This test case shows incorrect behavior -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6449) Form should raise validation error when required checkbox is not set
[ https://issues.apache.org/jira/browse/WICKET-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126062#comment-16126062 ] Sven Meier commented on WICKET-6449: 1) As discussed in WICKET-1221 it has no effect. 2) use a validator > Form should raise validation error when required checkbox is not set > > > Key: WICKET-6449 > URL: https://issues.apache.org/jira/browse/WICKET-6449 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.0.0-M6 >Reporter: Kamil >Assignee: Sven Meier > Attachments: showcase-requiredCheckbox.zip > > > Every user before he registers must agree to terms, thus proper > checkbox is required to check and validation error should be raised when > required checkbox is not checked. > This test case shows incorrect behavior -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (WICKET-6449) Form should raise validation error when required checkbox is not set
[ https://issues.apache.org/jira/browse/WICKET-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125978#comment-16125978 ] Kamil edited comment on WICKET-6449 at 8/14/17 5:11 PM: Sven (before we discuss 1221) please tell me: 1) What impact has "setRequired(true)" on a checkbox? What does it currently do? 2) How can I achieve desired behavior (which is required by EuropeanUnion for example) was (Author: eximius): Sven, so please tell me: 1) What impact has "setRequired(true)" on a checkbox? What does it currently do? 2) How can I achieve desired behavior (which is required by EuropeanUnion for example) > Form should raise validation error when required checkbox is not set > > > Key: WICKET-6449 > URL: https://issues.apache.org/jira/browse/WICKET-6449 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.0.0-M6 >Reporter: Kamil >Assignee: Sven Meier > Attachments: showcase-requiredCheckbox.zip > > > Every user before he registers must agree to terms, thus proper > checkbox is required to check and validation error should be raised when > required checkbox is not checked. > This test case shows incorrect behavior -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6449) Form should raise validation error when required checkbox is not set
[ https://issues.apache.org/jira/browse/WICKET-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125978#comment-16125978 ] Kamil commented on WICKET-6449: --- Sven, so please tell me: 1) What impact has "setRequired(true)" on a checkbox? What does it currently do? 2) How can I achieve desired behavior (which is required by EuropeanUnion for example) > Form should raise validation error when required checkbox is not set > > > Key: WICKET-6449 > URL: https://issues.apache.org/jira/browse/WICKET-6449 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.0.0-M6 >Reporter: Kamil >Assignee: Sven Meier > Attachments: showcase-requiredCheckbox.zip > > > Every user before he registers must agree to terms, thus proper > checkbox is required to check and validation error should be raised when > required checkbox is not checked. > This test case shows incorrect behavior -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (WICKET-6448) IndicatingAjaxButton should prevent double submit
[ https://issues.apache.org/jira/browse/WICKET-6448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125874#comment-16125874 ] Sebastien Briquet edited comment on WICKET-6448 at 8/14/17 4:03 PM: I would say that if the button is not part of the submit (which I guess it will be the case), then I do not agree : the user should be aware of this, and he voluntary accept it by overriding #isDisabledOnClick (or equivalent). Moreover, thinking back on the implementation... I'm figuring out that we need to use both #click and #ajaxStart. #click for displaying the indicator #ajaxStart for disabling the button Otherwise the indicator will be always be shown on every ajax request in the current page... was (Author: sebfz1): I would say that if the button is not part of the submit (which I guess it will be the case), then I do not agree : the user should be aware of this, and he voluntary accept it by overriding #isDisabledOnClick (or equivalent). Moreover, thinking back on the implementation... I'm figuring out that we need to user both #click and #ajaxStart. #click for displaying the indicator #ajaxStart for disabling the button Otherwise the indicator will be always be shown on every ajax request in the current page... > IndicatingAjaxButton should prevent double submit > - > > Key: WICKET-6448 > URL: https://issues.apache.org/jira/browse/WICKET-6448 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 8.0.0-M6 >Reporter: Kamil > Attachments: showcase-preventClick.zip > > > 1)Run the app > 2)Click "submit" quickly several times > 3)Watch the console -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6448) IndicatingAjaxButton should prevent double submit
[ https://issues.apache.org/jira/browse/WICKET-6448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125874#comment-16125874 ] Sebastien Briquet commented on WICKET-6448: --- I would say that if the button is not part of the submit (which I guess it will be the case), then I do not agree : the user should be aware of this, and he voluntary accept it by overriding #isDisabledOnClick (or equivalent). Moreover, thinking back on the implementation... I'm figuring out that we need to user both #click and #ajaxStart. #click for displaying the indicator #ajaxStart for disabling the button Otherwise the indicator will be always be shown on every ajax request in the current page... > IndicatingAjaxButton should prevent double submit > - > > Key: WICKET-6448 > URL: https://issues.apache.org/jira/browse/WICKET-6448 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 8.0.0-M6 >Reporter: Kamil > Attachments: showcase-preventClick.zip > > > 1)Run the app > 2)Click "submit" quickly several times > 3)Watch the console -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (WICKET-6451) Real Exception while setting model object is hidden
Kamil created WICKET-6451:
-
Summary: Real Exception while setting model object is hidden
Key: WICKET-6451
URL: https://issues.apache.org/jira/browse/WICKET-6451
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 8.0.0-M6
Reporter: Kamil
Attachments: showcase-hiddenException.zip
When object returns Collections.unmodifiableSet() it is obvious that model
object can not be updated.
But the exception that was thrown causes me to spend hours until I found out
that:
{code}
Last cause: Could not convert value: [] to type: java.util.Set. Could not find
compatible converter.
WicketMessage: An error occurred while trying to set the collection attached to
[BootstrapMultiSelect [Component id = children]]
{code}
Is not about converter but about unmodifialble set, because the real exception
was hidden!
1)Run the app
2)Click submit
3)Caused by User#L30
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (WICKET-6449) Form should raise validation error when required checkbox is not set
[ https://issues.apache.org/jira/browse/WICKET-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sven Meier resolved WICKET-6449. Resolution: Won't Fix This is intended, see WICKET-1221 > Form should raise validation error when required checkbox is not set > > > Key: WICKET-6449 > URL: https://issues.apache.org/jira/browse/WICKET-6449 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.0.0-M6 >Reporter: Kamil >Assignee: Sven Meier > Attachments: showcase-requiredCheckbox.zip > > > Every user before he registers must agree to terms, thus proper > checkbox is required to check and validation error should be raised when > required checkbox is not checked. > This test case shows incorrect behavior -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (WICKET-6449) Form should raise validation error when required checkbox is not set
[ https://issues.apache.org/jira/browse/WICKET-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sven Meier reassigned WICKET-6449: -- Assignee: Sven Meier > Form should raise validation error when required checkbox is not set > > > Key: WICKET-6449 > URL: https://issues.apache.org/jira/browse/WICKET-6449 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.0.0-M6 >Reporter: Kamil >Assignee: Sven Meier > Attachments: showcase-requiredCheckbox.zip > > > Every user before he registers must agree to terms, thus proper > checkbox is required to check and validation error should be raised when > required checkbox is not checked. > This test case shows incorrect behavior -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6448) IndicatingAjaxButton should prevent double submit
[ https://issues.apache.org/jira/browse/WICKET-6448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125861#comment-16125861 ] Kamil commented on WICKET-6448: --- Moreover - I'd say that this feature should be enabled by default > IndicatingAjaxButton should prevent double submit > - > > Key: WICKET-6448 > URL: https://issues.apache.org/jira/browse/WICKET-6448 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 8.0.0-M6 >Reporter: Kamil > Attachments: showcase-preventClick.zip > > > 1)Run the app > 2)Click "submit" quickly several times > 3)Watch the console -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6448) IndicatingAjaxButton should prevent double submit
[ https://issues.apache.org/jira/browse/WICKET-6448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125849#comment-16125849 ] Sebastien Briquet commented on WICKET-6448: --- I've rechecked my code, actually I've changed from ajaxStart to button.click to prevent the button being disabled on every ajax call (ajaxStart should always be bound to 'document') But ajaxStart seems actually to be the best compromise for now as I guess it occurs after the submit (I will double check...) > IndicatingAjaxButton should prevent double submit > - > > Key: WICKET-6448 > URL: https://issues.apache.org/jira/browse/WICKET-6448 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 8.0.0-M6 >Reporter: Kamil > Attachments: showcase-preventClick.zip > > > 1)Run the app > 2)Click "submit" quickly several times > 3)Watch the console -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (WICKET-6450) FormComponent should not always create ArrayList when field is null
Kamil created WICKET-6450: - Summary: FormComponent should not always create ArrayList when field is null Key: WICKET-6450 URL: https://issues.apache.org/jira/browse/WICKET-6450 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 8.0.0-M6 Reporter: Kamil Attachments: showcase-notCreateArrayList.zip Sometimes we want to use Set as a backing object but FormComponent#L1600 always creates new ArrayList. 1)Run the app 2)Click submit 3)See what happens. 4)Everything works when User#L13 is uncommented -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6448) IndicatingAjaxButton should prevent double submit
[ https://issues.apache.org/jira/browse/WICKET-6448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125821#comment-16125821 ] Kamil commented on WICKET-6448: --- ok, I can slightly agree that this could be not a bug but very important enhancement. Why? Because you use IndicatingAjaxButton when you know that user input would take long to process, so you want to inform the user that "something is going on in background" so he should wait. But impatient user can click the button several times thus process important operation twice. Please take charging user's credit card for example. We mus contact Visa, so it takes some time. During card number verification user clicks "pay" twice, so next payment is processed right after first one finished (which is just wrong) > IndicatingAjaxButton should prevent double submit > - > > Key: WICKET-6448 > URL: https://issues.apache.org/jira/browse/WICKET-6448 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 8.0.0-M6 >Reporter: Kamil > Attachments: showcase-preventClick.zip > > > 1)Run the app > 2)Click "submit" quickly several times > 3)Watch the console -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6448) IndicatingAjaxButton should prevent double submit
[ https://issues.apache.org/jira/browse/WICKET-6448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125809#comment-16125809 ] Sebastien Briquet commented on WICKET-6448: --- Agree that it is not a bug, should rather be an enhancement... > IndicatingAjaxButton should prevent double submit > - > > Key: WICKET-6448 > URL: https://issues.apache.org/jira/browse/WICKET-6448 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 8.0.0-M6 >Reporter: Kamil > Attachments: showcase-preventClick.zip > > > 1)Run the app > 2)Click "submit" quickly several times > 3)Watch the console -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6448) IndicatingAjaxButton should prevent double submit
[ https://issues.apache.org/jira/browse/WICKET-6448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125807#comment-16125807 ] Sebastien Briquet commented on WICKET-6448: --- [~mgrigorov]: It can be an option. I should say that it is convenient. I've added isDisabledOnClick property (default false) on wicket-jquery-ui's IndicatingAjaxButton, but I recently realized the issue I described earlier... :( > IndicatingAjaxButton should prevent double submit > - > > Key: WICKET-6448 > URL: https://issues.apache.org/jira/browse/WICKET-6448 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 8.0.0-M6 >Reporter: Kamil > Attachments: showcase-preventClick.zip > > > 1)Run the app > 2)Click "submit" quickly several times > 3)Watch the console -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6448) IndicatingAjaxButton should prevent double submit
[ https://issues.apache.org/jira/browse/WICKET-6448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125806#comment-16125806 ] Martin Grigorov commented on WICKET-6448: - I wonder why this is a "Bug". Why IndicatingAjaxButton should do this by default at all ? > IndicatingAjaxButton should prevent double submit > - > > Key: WICKET-6448 > URL: https://issues.apache.org/jira/browse/WICKET-6448 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 8.0.0-M6 >Reporter: Kamil > Attachments: showcase-preventClick.zip > > > 1)Run the app > 2)Click "submit" quickly several times > 3)Watch the console -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6448) IndicatingAjaxButton should prevent double submit
[ https://issues.apache.org/jira/browse/WICKET-6448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125803#comment-16125803 ] Sebastien Briquet commented on WICKET-6448: --- To prevent double submit, the button should likely be disabled on ajax-start and re-enabled on ajax-stop. The problems are: 1/ if the button is disabled just before the submit, it will not be part of the form data, therefore button#onSubmit will never be reached (but form#onSubmit will) 2/ on Chrome and IE, disabling the button will just prevent the form to be submitted. It work on FF however So, a smart alternative should be found... > IndicatingAjaxButton should prevent double submit > - > > Key: WICKET-6448 > URL: https://issues.apache.org/jira/browse/WICKET-6448 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 8.0.0-M6 >Reporter: Kamil > Attachments: showcase-preventClick.zip > > > 1)Run the app > 2)Click "submit" quickly several times > 3)Watch the console -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (WICKET-6449) Form should raise validation error when required checkbox is not set
Kamil created WICKET-6449: - Summary: Form should raise validation error when required checkbox is not set Key: WICKET-6449 URL: https://issues.apache.org/jira/browse/WICKET-6449 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 8.0.0-M6 Reporter: Kamil Attachments: showcase-requiredCheckbox.zip Every user before he registers must agree to terms, thus proper checkbox is required to check and validation error should be raised when required checkbox is not checked. This test case shows incorrect behavior -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6448) IndicatingAjaxButton should prevent double submit
[ https://issues.apache.org/jira/browse/WICKET-6448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125796#comment-16125796 ] Martin Grigorov commented on WICKET-6448: - Why ? Does anything say that it is expected to prevent double submit ? > IndicatingAjaxButton should prevent double submit > - > > Key: WICKET-6448 > URL: https://issues.apache.org/jira/browse/WICKET-6448 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 8.0.0-M6 >Reporter: Kamil > Attachments: showcase-preventClick.zip > > > 1)Run the app > 2)Click "submit" quickly several times > 3)Watch the console -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (WICKET-6448) IndicatingAjaxButton should prevent double submit
Kamil created WICKET-6448: - Summary: IndicatingAjaxButton should prevent double submit Key: WICKET-6448 URL: https://issues.apache.org/jira/browse/WICKET-6448 Project: Wicket Issue Type: Bug Components: wicket-extensions Affects Versions: 8.0.0-M6 Reporter: Kamil Attachments: showcase-preventClick.zip 1)Run the app 2)Click "submit" quickly several times 3)Watch the console -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (WICKET-6447) Dynamic setRequired() is not taken into account by WicketTester
[ https://issues.apache.org/jira/browse/WICKET-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil updated WICKET-6447: -- Attachment: showcase-requiredByVisibility.zip I'm also adding different use case where "required" is acheved by changing visibility. If you think that this is different bug, then just please separate them > Dynamic setRequired() is not taken into account by WicketTester > --- > > Key: WICKET-6447 > URL: https://issues.apache.org/jira/browse/WICKET-6447 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.0.0-M6 >Reporter: Kamil > Attachments: showcase-changeRequired.zip, > showcase-requiredByVisibility.zip > > > 1)Run the app > 2)Click submit (with empty field) -> you should see "SUCCESS" in console > 3)Click the checkbox and submit (with empty field) -> you should see "ERROR" > in console > now run the tests -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (WICKET-6447) Dynamic setRequired() is not taken into account by WicketTester
Kamil created WICKET-6447: - Summary: Dynamic setRequired() is not taken into account by WicketTester Key: WICKET-6447 URL: https://issues.apache.org/jira/browse/WICKET-6447 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 8.0.0-M6 Reporter: Kamil Attachments: showcase-changeRequired.zip 1)Run the app 2)Click submit (with empty field) -> you should see "SUCCESS" in console 3)Click the checkbox and submit (with empty field) -> you should see "ERROR" in console now run the tests -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (WICKET-6446) FormTester submit() doesn't work
Kamil created WICKET-6446: - Summary: FormTester submit() doesn't work Key: WICKET-6446 URL: https://issues.apache.org/jira/browse/WICKET-6446 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 8.0.0-M6 Reporter: Kamil Attachments: showcase-submit.zip 1)Run the app. 2)Click submit -> it works Run the "formShouldBeSubmittedSuccessfully" test - it fails -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (WICKET-6445) TagTester throws MalformedTag exception when wicket message is <
Kamil created WICKET-6445: - Summary: TagTester throws MalformedTag exception when wicket message is << Key: WICKET-6445 URL: https://issues.apache.org/jira/browse/WICKET-6445 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 8.0.0-M6 Reporter: Kamil Attachments: showcase-tagTester.zip just run "wicketTesterShouldNotFail" and "wicketTesterShouldNotFail2" -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Reopened] (WICKET-6441) MockHttpSession doesn't call onInvalidate() on invalidate()
[
https://issues.apache.org/jira/browse/WICKET-6441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Grigorov reopened WICKET-6441:
-
> MockHttpSession doesn't call onInvalidate() on invalidate()
> ---
>
> Key: WICKET-6441
> URL: https://issues.apache.org/jira/browse/WICKET-6441
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 8.0.0-M6
>Reporter: Kamil
> Attachments: showcase-onInvalidate.zip
>
>
> org.apache.wicket.protocol.http.mock.MockHttpSession on invalidate calls just:
> {code}
> @Override
> public void invalidate()
> {
> attributes.clear();
> id = generateSessionId();
> }
> {code}
> while org.apache.wicket.session.HttpSessionStore valueUnbound calls
> {code}
> public void valueUnbound(final HttpSessionBindingEvent evt)
> {
> String sessionId = evt.getSession().getId();
> log.debug("Session unbound: {}", sessionId);
> if (wicketSession != null)
> {
> wicketSession.onInvalidate();
> }
> ...
> }
> {code}
> (valueUnbound is called on
> org.apache.catalina.session.StandardSession.invalidate)
> this causes to be impossible to properly test what happens on invalidation of
> the session.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (WICKET-6441) MockHttpSession doesn't call onInvalidate() on invalidate()
[
https://issues.apache.org/jira/browse/WICKET-6441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamil updated WICKET-6441:
--
Attachment: showcase-onInvalidate.zip
[~mgrigorov] here you have the quickstart testcase.
1)Run application
2)Click "Invalidate"
3)onInvalidate is being called
now run the "sessionInvalidatesSuccessfully" test - it fails
> MockHttpSession doesn't call onInvalidate() on invalidate()
> ---
>
> Key: WICKET-6441
> URL: https://issues.apache.org/jira/browse/WICKET-6441
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 8.0.0-M6
>Reporter: Kamil
> Attachments: showcase-onInvalidate.zip
>
>
> org.apache.wicket.protocol.http.mock.MockHttpSession on invalidate calls just:
> {code}
> @Override
> public void invalidate()
> {
> attributes.clear();
> id = generateSessionId();
> }
> {code}
> while org.apache.wicket.session.HttpSessionStore valueUnbound calls
> {code}
> public void valueUnbound(final HttpSessionBindingEvent evt)
> {
> String sessionId = evt.getSession().getId();
> log.debug("Session unbound: {}", sessionId);
> if (wicketSession != null)
> {
> wicketSession.onInvalidate();
> }
> ...
> }
> {code}
> (valueUnbound is called on
> org.apache.catalina.session.StandardSession.invalidate)
> this causes to be impossible to properly test what happens on invalidation of
> the session.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
