[jira] [Created] (WICKET-6471) FileSystemResource file descriptor leak

2017-09-20 Thread Boris Goldowsky (JIRA) 
Boris Goldowsky created WICKET-6471:
---

 Summary: FileSystemResource file descriptor leak
 Key: WICKET-6471
 URL: https://issues.apache.org/jira/browse/WICKET-6471
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 7.9.0
Reporter: Boris Goldowsky
 Attachments: frquickstart.zip

FileSystemResource does not appear to close the InputStream that it creates.  

I believe it should call setClose(true) on the PartWriterCallback.

To verify the problem, see the attached quick start. Change the filename in 
HomePage.java to point to some valid image file on your system. After viewing 
the home page in a browser, check for files that the jetty process has open, eg:

{noformat}
lsof -p PID | grep logo
{noformat}

If you load the home page a few more times, using Shift-reload to avoid simply 
loading from cache, you can see many file descriptors pointing to the image 
file are kept open:

{noformat}
java87278 borisgoldowsky  txt  REG1,4 12244 
103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
java87278 borisgoldowsky  175r REG1,4 12244 
103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
java87278 borisgoldowsky  180r REG1,4 12244 
103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
java87278 borisgoldowsky  181r REG1,4 12244 
103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
{noformat}






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (WICKET-6448) Provide behavior that disables a button after click

2017-09-20 Thread Kamil (JIRA) 

[ 
https://issues.apache.org/jira/browse/WICKET-6448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173338#comment-16173338
 ] 

Kamil commented on WICKET-6448:
---

[~mgrigorov] sounds good to me

> Provide behavior that disables a button after click
> ---
>
> Key: WICKET-6448
> URL: https://issues.apache.org/jira/browse/WICKET-6448
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-extensions
>Affects Versions: 8.0.0-M6
>Reporter: Kamil
> Attachments: block-comment-doublesubmit.png, showcase-preventClick.zip
>
>
> Wicket should provide a Behavior that can be assigned to (Ajax)Buttons and 
> when clicked those buttons should be disabled via the HTML "disabled" 
> attribute.
> For AjaxButtons the behavior should re-enable the button after processing the 
> Ajax response.
> 1)Run the app
> 2)Click "submit" quickly several times
> 3)Watch the console



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (WICKET-6467) wicket:child nested inside container can not be found by Wicket

2017-09-20 Thread Kamil (JIRA) 

[ 
https://issues.apache.org/jira/browse/WICKET-6467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173331#comment-16173331
 ] 

Kamil commented on WICKET-6467:
---

Thank you very much Andrew, but these are still just workarounds...
Although they could be handy until this bug is fixed ;)

> wicket:child nested inside container can not be found by Wicket
> ---
>
> Key: WICKET-6467
> URL: https://issues.apache.org/jira/browse/WICKET-6467
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 8.0.0-M7
>Reporter: Kamil
> Attachments: showcase-childExtend.zip
>
>
> Sample app in attachment.
> When wicket:child is not "top level" component but is nested inside another 
> Wicket container, it can not be found by Wicket and exception is being thrown:
> {code}
> 17:06:34.719 [qtp767010715-12] ERROR org.apache.wicket.MarkupContainer - 
> Unable to find component with id 'child' in [Form [Component id = form]]
>   Expected: 'test:form:child'.
>   Found with similar names: 'test:child'
> 17:06:34.721 [qtp767010715-12] WARN  RequestCycleExtra - 
> 
> 17:06:34.722 [qtp767010715-12] WARN  RequestCycleExtra - Handling the 
> following exception
> org.apache.wicket.markup.MarkupException: Unable to find component with id 
> 'child' in [Form [Component id = form]]
>   Expected: 'test:form:child'.
>   Found with similar names: 'test:child'
> {code}
> I know, that it will work if I make "form" accessible for the child and add 
> component there, but It is clearly not what:
> {code}
> We should not require the subclass to start worrying about the exact 
> implementation of the super class.
> {code}
> stands for (https://issues.apache.org/jira/browse/WICKET-5580)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (WICKET-6470) If AjaxPagingNavigator is added before table, count is called twice

2017-09-20 Thread Kamil (JIRA) 
Kamil created WICKET-6470:
-

 Summary: If AjaxPagingNavigator is added before table, count is 
called twice
 Key: WICKET-6470
 URL: https://issues.apache.org/jira/browse/WICKET-6470
 Project: Wicket
  Issue Type: Bug
Reporter: Kamil
 Attachments: showcase-ajaxPagingNavigator.zip

1) Run "shouldCallCountOnce" test
2) Switch "EntityTable" lines 29 and 30
3) Run the test again.

Count is rather expensive operation, so it should not be called twice. Despite 
this behavior doesn't look consistent nor deterministic...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (WICKET-6469) "No files selected" displayed although files ARE selected in MultiFileUploadField

2017-09-20 Thread Kamil (JIRA) 
Kamil created WICKET-6469:
-

 Summary: "No files selected" displayed although files ARE selected 
in MultiFileUploadField
 Key: WICKET-6469
 URL: https://issues.apache.org/jira/browse/WICKET-6469
 Project: Wicket
  Issue Type: Bug
Reporter: Kamil
 Attachments: showcase-fileUpload.zip

When you run the wicket-quickstart app and select some files, you'll see that 
although files are listed below Upload field, the "No files selected" is still 
displayed next to a button.
I consider this as a bug



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (WICKET-6468) Caption Label should be hidden in MultiFileUploadField when model is empty

2017-09-20 Thread Kamil (JIRA) 
Kamil created WICKET-6468:
-

 Summary: Caption Label should be hidden in MultiFileUploadField 
when model is empty
 Key: WICKET-6468
 URL: https://issues.apache.org/jira/browse/WICKET-6468
 Project: Wicket
  Issue Type: Improvement
Reporter: Kamil
 Attachments: showcase-fileUpload.zip

When you run the wicket-quickstart app, you'll see a page with 
MultiFileUploadField.
Although no files are selected, "Files:" caption is being visible.
I think that if "IModel> model" is empty, then 
"caption" label (Line 193) should not be visible.
I'd add something like:
{code}
Label caption = new Label("caption", new CaptionModel()) {
@Override
protected void onConfigure() {
super.onConfigure();
setVisible(model.map(Collection::isEmpty).getObject());
}
};
{code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

wicket-site git commit: Added informations for M7

2017-09-20 Thread adelbene 
Repository: wicket-site
Updated Branches:
  refs/heads/asf-site 8185769de -> 167388ddd


Added informations for M7


Project: http://git-wip-us.apache.org/repos/asf/wicket-site/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket-site/commit/167388dd
Tree: http://git-wip-us.apache.org/repos/asf/wicket-site/tree/167388dd
Diff: http://git-wip-us.apache.org/repos/asf/wicket-site/diff/167388dd

Branch: refs/heads/asf-site
Commit: 167388ddd3bb4046598ec3b4c25c1c04882f48a0
Parents: 8185769
Author: Andrea Del Bene 
Authored: Wed Sep 20 10:52:10 2017 +0200
Committer: Andrea Del Bene 
Committed: Wed Sep 20 10:52:10 2017 +0200

--
 _config.yml   | 4 ++--
 content/archetype-catalog.xml | 4 ++--
 content/atom.xml  | 2 +-
 content/start/download.html   | 2 +-
 content/start/quickstart.html | 2 +-
 content/start/wicket-8.x.html | 4 ++--
 6 files changed, 9 insertions(+), 9 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket-site/blob/167388dd/_config.yml
--
diff --git a/_config.yml b/_config.yml
index 0563bd9..fa82389 100644
--- a/_config.yml
+++ b/_config.yml
@@ -16,14 +16,14 @@ sass:
 sass_dir: _sass
 wicket:
   version:7.9.0
-  version_80: 8.0.0-M6
+  version_80: 8.0.0-M7
   version_70: 7.9.0
   version_60: 6.27.1
   version_15: 1.5.17
   version_14: 1.4.23
   version_13: 1.3.7
   released:   2017-07-12
-  versions:   [6.27.1, 1.5.17, 1.4.23, 7.9.0, 1.5-SNAPSHOT, 6.28.0-SNAPSHOT, 
7.10.0-SNAPSHOT, 8.0.0-M6, 8.0.0-SNAPSHOT]
+  versions:   [6.27.1, 1.5.17, 1.4.23, 7.9.0, 1.5-SNAPSHOT, 6.28.0-SNAPSHOT, 
7.10.0-SNAPSHOT, 8.0.0-M7, 8.0.0-SNAPSHOT]
 
 navigation:
 - id: start

http://git-wip-us.apache.org/repos/asf/wicket-site/blob/167388dd/content/archetype-catalog.xml
--
diff --git a/content/archetype-catalog.xml b/content/archetype-catalog.xml
index 2467887..ba7474b 100644
--- a/content/archetype-catalog.xml
+++ b/content/archetype-catalog.xml
@@ -12,8 +12,8 @@

org.apache.wicket
wicket-archetype-quickstart
-   8.0.0-M6
-   Wicket 8.0.0-M6 Quickstart
+   8.0.0-M7
+   Wicket 8.0.0-M7 Quickstart

 


http://git-wip-us.apache.org/repos/asf/wicket-site/blob/167388dd/content/atom.xml
--
diff --git a/content/atom.xml b/content/atom.xml
index bb2198b..5a0f75e 100644
--- a/content/atom.xml
+++ b/content/atom.xml
@@ -3,7 +3,7 @@
 Apache Wicket
 http://wicket.apache.org/atom.xml; rel="self"/>
 http://wicket.apache.org/"/>
-2017-09-20T10:35:12+02:00
+2017-09-20T10:51:40+02:00
 http://wicket.apache.org/
 
 Apache Wicket

http://git-wip-us.apache.org/repos/asf/wicket-site/blob/167388dd/content/start/download.html
--
diff --git a/content/start/download.html b/content/start/download.html
index 8fa041a..975928d 100644
--- a/content/start/download.html
+++ b/content/start/download.html
@@ -81,7 +81,7 @@


Wicket 8.x
-   8.0.0-M6
+   8.0.0-M7
in development



http://git-wip-us.apache.org/repos/asf/wicket-site/blob/167388dd/content/start/quickstart.html
--
diff --git a/content/start/quickstart.html b/content/start/quickstart.html
index 50db3e0..3b5cd8b 100644
--- a/content/start/quickstart.html
+++ b/content/start/quickstart.html
@@ -120,7 +120,7 @@ command line to your clipboard.
 Wicket Version
 
8.0.0-SNAPSHOT
-   8.0.0-M6
+   8.0.0-M7
7.10.0-SNAPSHOT
6.28.0-SNAPSHOT
1.5-SNAPSHOT

http://git-wip-us.apache.org/repos/asf/wicket-site/blob/167388dd/content/start/wicket-8.x.html
--
diff --git a/content/start/wicket-8.x.html b/content/start/wicket-8.x.html
index c6f3d5c..2ac8208 100644
--- a/content/start/wicket-8.x.html
+++ b/content/start/wicket-8.x.html
@@ -65,14 +65,14 @@ releases will not break compatibility.
 Change log
 The change log is not available at the current state of the development 
process.
 Download
-The most recent test version in this branch is: 8.0.0-M6. 
+The most recent test version in this branch is: 8.0.0-M7. 
 You can test the current state of development using Maven.
 Using Apache Maven
 Use the following Maven dependency to use Wicket in your project:
 dependency
 groupIdorg.apache.wicket/groupId

[2/2] wicket-site git commit: Generated new site for 7.9.0 release

2017-09-20 Thread adelbene 
Generated new site for 7.9.0 release


Project: http://git-wip-us.apache.org/repos/asf/wicket-site/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket-site/commit/8185769d
Tree: http://git-wip-us.apache.org/repos/asf/wicket-site/tree/8185769d
Diff: http://git-wip-us.apache.org/repos/asf/wicket-site/diff/8185769d

Branch: refs/heads/asf-site
Commit: 8185769deec4f416acc863eb39ea9bef27188964
Parents: da8ee1c
Author: Andrea Del Bene 
Authored: Wed Sep 20 10:36:07 2017 +0200
Committer: Andrea Del Bene 
Committed: Wed Sep 20 10:36:07 2017 +0200

--
 2017/_posts/2017-09-19-wicket-7.9.0-released.md |   7 +-
 content/archetype-catalog.xml   |  12 +-
 content/atom.xml| 280 +--
 content/doap.rdf|   2 +-
 content/help/index.html |  12 +-
 content/index.html  |  52 ++--
 content/learn/index.html|   6 +-
 content/news/2009/07/index.html |   1 +
 content/news/2009/08/index.html |   1 +
 content/news/2009/10/index.html |   1 +
 content/news/2009/12/index.html |   1 +
 content/news/2009/index.html|   1 +
 content/news/2010/02/index.html |   1 +
 content/news/2010/03/index.html |   1 +
 content/news/2010/05/index.html |   1 +
 content/news/2010/08/index.html |   1 +
 content/news/2010/09/index.html |   1 +
 content/news/2010/11/index.html |   1 +
 content/news/2010/12/index.html |   1 +
 content/news/2010/index.html|   1 +
 content/news/2011/01/index.html |   1 +
 content/news/2011/02/index.html |   1 +
 content/news/2011/03/index.html |   1 +
 content/news/2011/04/index.html |   1 +
 content/news/2011/05/index.html |   1 +
 content/news/2011/06/index.html |   1 +
 content/news/2011/08/index.html |   1 +
 content/news/2011/09/index.html |   1 +
 content/news/2011/10/index.html |   1 +
 content/news/2011/11/index.html |   1 +
 content/news/2011/index.html|   1 +
 content/news/2012/01/index.html |   1 +
 content/news/2012/03/index.html |   1 +
 content/news/2012/05/index.html |   1 +
 content/news/2012/06/index.html |   1 +
 content/news/2012/07/index.html |   1 +
 content/news/2012/08/index.html |   1 +
 content/news/2012/09/index.html |   1 +
 content/news/2012/10/index.html |   1 +
 content/news/2012/11/index.html |   1 +
 content/news/2012/12/index.html |   1 +
 content/news/2012/index.html|   1 +
 content/news/2013/01/index.html |   1 +
 content/news/2013/02/index.html |   1 +
 content/news/2013/03/index.html |   1 +
 content/news/2013/04/index.html |   1 +
 content/news/2013/05/index.html |   1 +
 content/news/2013/06/index.html |   1 +
 content/news/2013/07/index.html |   1 +
 content/news/2013/08/index.html |   1 +
 content/news/2013/09/index.html |   1 +
 content/news/2013/11/index.html |   1 +
 content/news/2013/index.html|   1 +
 content/news/2014/01/index.html |   1 +
 content/news/2014/02/index.html |   1 +
 content/news/2014/04/index.html |   1 +
 content/news/2014/06/index.html |   1 +
 content/news/2014/08/index.html |   1 +
 content/news/2014/09/index.html |   1 +
 content/news/2014/11/index.html |   1 +
 content/news/2014/index.html|   1 +
 content/news/2015/02/index.html |   1 +
 content/news/2015/06/index.html |   1 +
 content/news/2015/07/index.html |   1 +
 content/news/2015/10/index.html |   1 +
 content/news/2015/11/index.html |   1 +
 content/news/2015/index.html|   1 +
 content/news/2016/01/index.html |   1 +
 content/news/2016/02/index.html |   1 +
 content/news/2016/03/index.html |   1 +
 content/news/2016/05/index.html |   1 +
 content/news/2016/07/index.html |   1 +
 content/news/2016/08/index.html |   1 +
 content/news/2016/10/index.html |   1 +
 content/news/2016/11/index.html |   1 +

[1/2] wicket-site git commit: Generated new site for 7.9.0 release

2017-09-20 Thread adelbene 
Repository: wicket-site
Updated Branches:
  refs/heads/asf-site da8ee1c28 -> 8185769de


http://git-wip-us.apache.org/repos/asf/wicket-site/blob/8185769d/content/news/2017/09/19/wicket-7.9.0-released.html
--
diff --git a/content/news/2017/09/19/wicket-7.9.0-released.html 
b/content/news/2017/09/19/wicket-7.9.0-released.html
new file mode 100644
index 000..03b51c4
--- /dev/null
+++ b/content/news/2017/09/19/wicket-7.9.0-released.html
@@ -0,0 +1,160 @@
+
+
+
+
+
+Apache Wicket 7.9.0 released | Apache Wicket
+
+
+
+
+
+
+   
+
+
+
+
+
+
+
+
+   
+   Quick Start
+   
+   Download
+   
+   Documentation
+   
+   Support
+   
+   Contribute
+   
+   Community
+   
+   Apache
+
+
+
+
+
+
+
+
+
+
+Apache Wicket 7.9.0 released
+
+
+Table of 
Contents1 New and noteworthy2 
Using this release3 Upgrading from earlier versions3.1 This 
Release
+
+
+
+19 Sep 2017
+The Apache Wicket PMC is proud to announce Apache Wicket 7.9.0!
+Apache Wicket is an open source Java component oriented web application
+framework that powers thousands of web applications and web sites for
+governments, stores, universities, cities, banks, email providers, and
+more. You can find more about Apache Wicket at https://wicket.apache.org
+This release marks another minor release of Wicket 7. We
+use semantic versioning for the development of Wicket, and as such no
+API breaks are present breaks are present in this release compared to
+7.0.0.
+New and noteworthy
+This release fixes WICKET-6457 and WICKET-6465 which caused the page store 
not to be cleared when session ends.
+Using this release
+With Apache Maven update your dependency to (and don’t forget to
+update any other dependencies on Wicket projects to the same version):
+dependency
+groupIdorg.apache.wicket/groupId
+artifactIdwicket-core/artifactId
+version7.9.0/version
+/dependency
+Or download and build the distribution yourself, or use our
+convenience binary package
+
+  Source: http://www.apache.org/dyn/closer.cgi/wicket/7.9.0;>7.9.0 source 
download
+  Binary: http://www.apache.org/dyn/closer.cgi/wicket/7.9.0/binaries;>7.9.0 binary 
download
+
+
+Upgrading from earlier versions
+If you upgrade from 7.y.z this release is a drop in replacement. If
+you come from a version prior to 7.0.0, please read our Wicket 7
+migration guide found at
+
+  http://s.apache.org/wicket7migrate
+
+Have fun!
+— The Wicket team
+
+The signatures for 
the source release artefacts:
+
+
+Signature for apache-wicket-7.9.0.zip:
+
+-BEGIN PGP SIGNATURE-
+Version: GnuPG v1
+iQIcBAABAgAGBQJZvBu5AAoJEAzCjx+CMhBVaPMP/0pZ+1p6uIfnzV7EHDNqv35F
+WJ82gFCqWZov29EUFcb+2YOCjFOU6BG61pgP98IzB+qhXomHf34hhrzomuEZCtlR
+hxYjMxnvaPHR5C/2SEkbtGtHs8YFE5SylmKB2V9Qchpx0ClicApSu1JvAb8q3rnL
+CDLIOEDEtKsioLcsVZpXT67ctgKc/Pp5Gdd0lRClnEOUONQ1WJ7yQ1uy5JfxS+Xv
+48zdiIumzgdTWgm1HJXzM41Lp4NdpwZx6/GVvD/9RjNMMOxxsPw5ZZUG/P9jtPTg
+anSXIjA2q40Y2NDRwdMMgKFNBsPoef4QHqgniiNTTZVsitGHo/jl0LqSjyXZ7MSE
+VwzSv/FOQcEfiVCMklJG+8JFIpq2/CLDCIWvlNpBC1QTqzw97xLW0gw/R88rcAoe
+ESrl7k4OSKS/YWilDRgCgaw5nBhGwqpN/Luv5Yzvxe91BFi1RXcBVq4xs/ceQd8c
+r7Sa8ZC2uvCFGdRBbMK1OjYU7Y8DjTJb3Fp2EzQRjIqAqaj6PMINEYdYvKJG8d3Y
+Z90qMv2QqF3q5BNbBU9Lf9z0Kau/W3jGXFC0wxj9tYj5gz3F5EEWDLbHj3pRiH0/
+vAHPPMZekI7GQbsYel+nGtkHBj3osPGUQ/ESQDLutJiqJ9t1e1Eijd/CdX+r5pUL
+JG97c19NWfJaKfKdCT60
+=ReUR
+-END PGP SIGNATURE-
+
+Signature for apache-wicket-7.9.0.tar.gz:
+
+-BEGIN PGP SIGNATURE-
+Version: GnuPG v1
+iQIcBAABAgAGBQJZvBu5AAoJEAzCjx+CMhBVtzkQAKjDi4eBTH9A/gl0e4r5VQxP
+E+RPPVzo1Jf2+1Szz4gR4cLgFGGFqLQoqBM7YGWRSSaxdI1/ys7sn91MTg+pLCSB
+I5Xh145t/Ok58czr1N5VsIPLo3pU0pHMZwmPv+xDjv42EbogpsoFaEQsN3XorKyo
+DlrtN9WAh3pXj2y05nHqFNsUUuWACPmo+CCAuAPsTIqYbxDyB0OjlFA54ovSY41Q
+sP5UP7EuhM7W9Px38RzArUUT2WNIJlDdHogISZrurkj3aS5K5qTe1KGx2u15B6Gi
+gjU9P2aw3pzpHiBXsBInAthwGXWecIkvvRst85mQo3ivLydmyIla00+DZCe3vgkE
+cJHDCFig8QwF9kC1rtma3Rep3aXDiq+mLdDWXPqMC66s1BzzuH4xeX78/OadyVOB
+7PIjs3vUfJUIwITVG4RlLNQebDeIeFaWubT19zjcelet325WlAJpwAOGtWxj31bG
+7pWmUUAkJo0yUuK1wLBb+TN+GHQBsjwSMTxs/PTAAsq6m53fPkOFerzL5ygCshvt
+dlFAd48VZVIzWZTc0yYq0X5oHtQETIDgIKcFuJp88uBfTc0Io9r+QMdAWTgUIuzH
+OqMV4TXjaM/YBWurQ4B/Xz1KPgR7gtSjifnw3hytEIT7RHq/Av+3bJTjvby4t7r9
+CeQiIicC2Ghx4BrN1Lxk
+=b9ky
+-END PGP SIGNATURE-
+
+
+This Release
+CHANGELOG for 7.9.0:
+Bug
+
+  [WICKET-6429] - AbstractRequestLogger should not create new Sessions
+  [WICKET-6455] - AjaxFormSubmitBehavior doesn’t submit inner forms
+  [WICKET-6457] - PageStore not cleared at session end
+  [WICKET-6459] -