[jira] [Commented] (WICKET-6321) Support Integrity and Crossorigin attributes for JavaScriptUrlReferenceHeaderItem
[ https://issues.apache.org/jira/browse/WICKET-6321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408134#comment-16408134 ] Maxim Solodovnik commented on WICKET-6321: -- Could you please create PR? > Support Integrity and Crossorigin attributes for > JavaScriptUrlReferenceHeaderItem > -- > > Key: WICKET-6321 > URL: https://issues.apache.org/jira/browse/WICKET-6321 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 8.0.0-M3 >Reporter: Mikhail Fursov >Priority: Major > Fix For: 8.0.0 > > Attachments: wicket-6321-20180306.diff, wicket-6321.diff > > > Example of secure script reference: > src="https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/4.0.0-alpha.6/js/bootstrap.min.js" > integrity="sha256-+kIbbrvS+0dNOjhmQJzmwe/RILR/8lb/+4+PUNVW09k=" > crossorigin="anonymous"> -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6544) Chrome and Firefox on iOS detected as Safari version -1
[ https://issues.apache.org/jira/browse/WICKET-6544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408121#comment-16408121 ] ASF GitHub Bot commented on WICKET-6544: Github user solomax commented on a diff in the pull request: https://github.com/apache/wicket/pull/269#discussion_r176132347 --- Diff: wicket-core/src/test/java/org/apache/wicket/protocol/http/request/WebClientInfoTest.java --- @@ -680,6 +708,35 @@ public void konqueror() } } + @Test + public void ffMobile() + { + final String userAgent = "Mozilla/5.0 (iPhone; CPU iPhone OS 11_2_6 like Mac OS X) AppleWebKit/604.5.6 (KHTML, like Gecko) FxiOS/10.6b8836 Mobile/15D100 Safari/604.5.6"; + WebClientInfo webClientInfo = new WebClientInfo(requestCycleMock, userAgent); + + assertThat(userAgent, webClientInfo.getProperties().getBrowserVersionMajor(), + is(equalTo(10))); + assertThat(userAgent, webClientInfo.getProperties().getBrowserVersionMinor(), + is(equalTo(6))); + assertThat(userAgent, webClientInfo.getProperties().isBrowserMozillaFirefox(), + is(equalTo(true))); + assertThat(userAgent, webClientInfo.getProperties().isBrowserMozilla(), --- End diff -- This part is something I don;t really like in this PR :( > Chrome and Firefox on iOS detected as Safari version -1 > --- > > Key: WICKET-6544 > URL: https://issues.apache.org/jira/browse/WICKET-6544 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.9.0 >Reporter: Sven Ackermann >Assignee: Maxim Solodovnik >Priority: Major > > The UserAgent detection on iOS for browsers other than Safari does not work > correctly. > E.g. Chrome 64 has UserAgent > ??Mozilla/5.0 (iPhone; CPU iPhone OS 11_2_6 like Mac OS X) > AppleWebKit/604.1.34 (KHTML, like Gecko) CriOS/64.0.3282.112 Mobile/15D100 > Safari/604.1?? > which is recognized by classes {{UserAgent}} and {{WebClientInfo}} as Safari > with no version (-1). The problem is that the UserAgent does not contain > "Chrome" as required by {{UserAgent.CHROME}}, but instead "CriOS". So it is > recognized as Safari, but since it does not contain "version/", no version is > set. > A similar problem exists for Firefox on iOS where the UserAgent contains > "FxiOS" instead of "Firefox": > ??Mozilla/5.0 (iPhone; CPU iPhone OS 11_2_6 like Mac OS X) > AppleWebKit/604.5.6 (KHTML, like Gecko) FxiOS/10.6b8836 Mobile/15D100 > Safari/604.5.6?? > In our application this causes some unwanted redirects to legacy pages > because we think it is an old Safari browser with no support for some > features our pages need. But of course the Chrome und Firefox versions above > support all that. > see also > [https://developer.chrome.com/multidevice/user-agent#chrome_for_ios_user_agent|https://developer.chrome.com/multidevice/user-agent#chrome_for_ios_user_agent,] > and > [https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent/Firefox#Firefox_for_iOS] > > Thanks for looking into it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6544) Chrome and Firefox on iOS detected as Safari version -1
[ https://issues.apache.org/jira/browse/WICKET-6544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408116#comment-16408116 ] ASF GitHub Bot commented on WICKET-6544: GitHub user solomax opened a pull request: https://github.com/apache/wicket/pull/269 [WICKET-6544] mobile browser detection is improved You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/wicket WICKET-6544-mobile-browsers Alternatively you can review and apply these changes as the patch at: https://github.com/apache/wicket/pull/269.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #269 commit 0cc14749903f51057cc75d011cbc8a02a4e42f4c Author: Maxim SolodovnikDate: 2018-03-21T15:44:17Z [WICKET-6544] mobile browser detection is improved > Chrome and Firefox on iOS detected as Safari version -1 > --- > > Key: WICKET-6544 > URL: https://issues.apache.org/jira/browse/WICKET-6544 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.9.0 >Reporter: Sven Ackermann >Assignee: Maxim Solodovnik >Priority: Major > > The UserAgent detection on iOS for browsers other than Safari does not work > correctly. > E.g. Chrome 64 has UserAgent > ??Mozilla/5.0 (iPhone; CPU iPhone OS 11_2_6 like Mac OS X) > AppleWebKit/604.1.34 (KHTML, like Gecko) CriOS/64.0.3282.112 Mobile/15D100 > Safari/604.1?? > which is recognized by classes {{UserAgent}} and {{WebClientInfo}} as Safari > with no version (-1). The problem is that the UserAgent does not contain > "Chrome" as required by {{UserAgent.CHROME}}, but instead "CriOS". So it is > recognized as Safari, but since it does not contain "version/", no version is > set. > A similar problem exists for Firefox on iOS where the UserAgent contains > "FxiOS" instead of "Firefox": > ??Mozilla/5.0 (iPhone; CPU iPhone OS 11_2_6 like Mac OS X) > AppleWebKit/604.5.6 (KHTML, like Gecko) FxiOS/10.6b8836 Mobile/15D100 > Safari/604.5.6?? > In our application this causes some unwanted redirects to legacy pages > because we think it is an old Safari browser with no support for some > features our pages need. But of course the Chrome und Firefox versions above > support all that. > see also > [https://developer.chrome.com/multidevice/user-agent#chrome_for_ios_user_agent|https://developer.chrome.com/multidevice/user-agent#chrome_for_ios_user_agent,] > and > [https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent/Firefox#Firefox_for_iOS] > > Thanks for looking into it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6544) Chrome and Firefox on iOS detected as Safari version -1
[ https://issues.apache.org/jira/browse/WICKET-6544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408114#comment-16408114 ] ASF subversion and git services commented on WICKET-6544: - Commit 0cc14749903f51057cc75d011cbc8a02a4e42f4c in wicket's branch refs/heads/WICKET-6544-mobile-browsers from [~solomax] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=0cc1474 ] [WICKET-6544] mobile browser detection is improved > Chrome and Firefox on iOS detected as Safari version -1 > --- > > Key: WICKET-6544 > URL: https://issues.apache.org/jira/browse/WICKET-6544 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.9.0 >Reporter: Sven Ackermann >Assignee: Maxim Solodovnik >Priority: Major > > The UserAgent detection on iOS for browsers other than Safari does not work > correctly. > E.g. Chrome 64 has UserAgent > ??Mozilla/5.0 (iPhone; CPU iPhone OS 11_2_6 like Mac OS X) > AppleWebKit/604.1.34 (KHTML, like Gecko) CriOS/64.0.3282.112 Mobile/15D100 > Safari/604.1?? > which is recognized by classes {{UserAgent}} and {{WebClientInfo}} as Safari > with no version (-1). The problem is that the UserAgent does not contain > "Chrome" as required by {{UserAgent.CHROME}}, but instead "CriOS". So it is > recognized as Safari, but since it does not contain "version/", no version is > set. > A similar problem exists for Firefox on iOS where the UserAgent contains > "FxiOS" instead of "Firefox": > ??Mozilla/5.0 (iPhone; CPU iPhone OS 11_2_6 like Mac OS X) > AppleWebKit/604.5.6 (KHTML, like Gecko) FxiOS/10.6b8836 Mobile/15D100 > Safari/604.5.6?? > In our application this causes some unwanted redirects to legacy pages > because we think it is an old Safari browser with no support for some > features our pages need. But of course the Chrome und Firefox versions above > support all that. > see also > [https://developer.chrome.com/multidevice/user-agent#chrome_for_ios_user_agent|https://developer.chrome.com/multidevice/user-agent#chrome_for_ios_user_agent,] > and > [https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent/Firefox#Firefox_for_iOS] > > Thanks for looking into it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
wicket git commit: [WICKET-6544] mobile browser detection is improved
Repository: wicket Updated Branches: refs/heads/WICKET-6544-mobile-browsers [created] 0cc147499 [WICKET-6544] mobile browser detection is improved Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/0cc14749 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/0cc14749 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/0cc14749 Branch: refs/heads/WICKET-6544-mobile-browsers Commit: 0cc14749903f51057cc75d011cbc8a02a4e42f4c Parents: c544488 Author: Maxim SolodovnikAuthored: Wed Mar 21 22:44:17 2018 +0700 Committer: Maxim Solodovnik Committed: Wed Mar 21 22:44:17 2018 +0700 -- .../wicket/protocol/http/request/UserAgent.java | 14 +++-- .../protocol/http/request/WebClientInfo.java| 34 +++- .../protocol/http/request/UserAgentTest.java| 14 + .../http/request/WebClientInfoTest.java | 57 4 files changed, 101 insertions(+), 18 deletions(-) -- http://git-wip-us.apache.org/repos/asf/wicket/blob/0cc14749/wicket-core/src/main/java/org/apache/wicket/protocol/http/request/UserAgent.java -- diff --git a/wicket-core/src/main/java/org/apache/wicket/protocol/http/request/UserAgent.java b/wicket-core/src/main/java/org/apache/wicket/protocol/http/request/UserAgent.java index e198166..c9c4e7b 100644 --- a/wicket-core/src/main/java/org/apache/wicket/protocol/http/request/UserAgent.java +++ b/wicket-core/src/main/java/org/apache/wicket/protocol/http/request/UserAgent.java @@ -28,7 +28,9 @@ enum UserAgent { MOZILLA("Opera,AppleWebKit,Konqueror,Trident", Arrays.asList("Mozilla", "Gecko")), - FIREFOX("Opera,AppleWebKit,Konqueror,Trident,Edge", Arrays.asList("Mozilla", "Gecko", "Firefox")), + FIREFOX("Opera,Konqueror,Trident,Edge", + Arrays.asList("Mozilla", "Gecko", "Firefox"), + Arrays.asList("Mozilla", "Gecko", "FxiOS")), INTERNET_EXPLORER("Opera,Edge", Arrays.asList("Mozilla", "MSIE", "Windows"), @@ -38,9 +40,11 @@ enum UserAgent { OPERA(Arrays.asList("Opera")), - CHROME("Edge", Arrays.asList("Mozilla", "Chrome", "AppleWebKit", "Safari")), + CHROME("Edge", + Arrays.asList("Mozilla", "Chrome", "AppleWebKit", "Safari"), + Arrays.asList("Mozilla", "CriOS", "AppleWebKit", "Safari")), - SAFARI("Chrome,Edge", Arrays.asList("Mozilla", "AppleWebKit", "Safari")), + SAFARI("Chrome,Edge,FxiOS,CriOS", Arrays.asList("Mozilla", "AppleWebKit", "Safari")), KONQUEROR(Arrays.asList("Konqueror")), @@ -58,7 +62,7 @@ enum UserAgent { /** * Construct. -* +* * @param notAllowed *comma separated list with values which are not allowed in the user agent * @param detectionStrings @@ -72,7 +76,7 @@ enum UserAgent { /** * Construct. -* +* * @param detectionStrings *list with string which has to be in the user agent string */ http://git-wip-us.apache.org/repos/asf/wicket/blob/0cc14749/wicket-core/src/main/java/org/apache/wicket/protocol/http/request/WebClientInfo.java -- diff --git a/wicket-core/src/main/java/org/apache/wicket/protocol/http/request/WebClientInfo.java b/wicket-core/src/main/java/org/apache/wicket/protocol/http/request/WebClientInfo.java index c0fb2a6..e0495f5 100644 --- a/wicket-core/src/main/java/org/apache/wicket/protocol/http/request/WebClientInfo.java +++ b/wicket-core/src/main/java/org/apache/wicket/protocol/http/request/WebClientInfo.java @@ -35,7 +35,7 @@ import org.slf4j.LoggerFactory; /** * Default client info object for web applications. - * + * * @author Eelco Hillenius */ public class WebClientInfo extends ClientInfo @@ -56,7 +56,7 @@ public class WebClientInfo extends ClientInfo /** * Construct. -* +* * @param requestCycle *the request cycle */ @@ -67,7 +67,7 @@ public class WebClientInfo extends ClientInfo /** * Construct. -* +* * @param requestCycle *the request cycle */ @@ -79,7 +79,7 @@ public class WebClientInfo extends ClientInfo /** * Construct. -* +* * @param requestCycle *the request cycle * @param userAgent @@ -92,13 +92,13 @@ public class WebClientInfo extends ClientInfo /** * Construct. -* +* * @param requestCycle *the request cycle * @param
[jira] [Assigned] (WICKET-6544) Chrome and Firefox on iOS detected as Safari version -1
[ https://issues.apache.org/jira/browse/WICKET-6544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik reassigned WICKET-6544: Assignee: Maxim Solodovnik > Chrome and Firefox on iOS detected as Safari version -1 > --- > > Key: WICKET-6544 > URL: https://issues.apache.org/jira/browse/WICKET-6544 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.9.0 >Reporter: Sven Ackermann >Assignee: Maxim Solodovnik >Priority: Major > > The UserAgent detection on iOS for browsers other than Safari does not work > correctly. > E.g. Chrome 64 has UserAgent > ??Mozilla/5.0 (iPhone; CPU iPhone OS 11_2_6 like Mac OS X) > AppleWebKit/604.1.34 (KHTML, like Gecko) CriOS/64.0.3282.112 Mobile/15D100 > Safari/604.1?? > which is recognized by classes {{UserAgent}} and {{WebClientInfo}} as Safari > with no version (-1). The problem is that the UserAgent does not contain > "Chrome" as required by {{UserAgent.CHROME}}, but instead "CriOS". So it is > recognized as Safari, but since it does not contain "version/", no version is > set. > A similar problem exists for Firefox on iOS where the UserAgent contains > "FxiOS" instead of "Firefox": > ??Mozilla/5.0 (iPhone; CPU iPhone OS 11_2_6 like Mac OS X) > AppleWebKit/604.5.6 (KHTML, like Gecko) FxiOS/10.6b8836 Mobile/15D100 > Safari/604.5.6?? > In our application this causes some unwanted redirects to legacy pages > because we think it is an old Safari browser with no support for some > features our pages need. But of course the Chrome und Firefox versions above > support all that. > see also > [https://developer.chrome.com/multidevice/user-agent#chrome_for_ios_user_agent|https://developer.chrome.com/multidevice/user-agent#chrome_for_ios_user_agent,] > and > [https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent/Firefox#Firefox_for_iOS] > > Thanks for looking into it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (WICKET-6478) Nesting 3+ enclosures leads to error You most likely forgot to register the EnclosureHandler with the MarkupParserFactory
[ https://issues.apache.org/jira/browse/WICKET-6478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Del Bene updated WICKET-6478: Attachment: quickstart.zip > Nesting 3+ enclosures leads to error You most likely forgot to register the > EnclosureHandler with the MarkupParserFactory > - > > Key: WICKET-6478 > URL: https://issues.apache.org/jira/browse/WICKET-6478 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.8.0 > Environment: Websphere 9, IBM JDK 8, Wicket 7.8.0 >Reporter: David Rain >Assignee: Andrea Del Bene >Priority: Major > Labels: WICKET-6026 > Attachments: quickstart.zip > > > The issue reported here WICKET-6026 hasn't been resolved completely. The > error is still present in 7.8.0 when nesting 3 or more enclosures. > It is OK with 2 nested enclosures. > Markup fragment causing error > works fine in 6.24.0 > {code:html} > > > > > > > > wicket:id="otherBankLoanType" >[Spotřebitelský úvěr] > - > wicket:id="otherBankLoanDebit" class="value">[100 000,00] > >- > wicket:id="otherBankLoanMonthlyInstallment" class="value">[2 500,00 > CZK] > > > - wicket:id="otherBankLoanCreditAmount" class="value">[60 000,00] > > > > > > > wicket:id="kbLoanType" >[Spotřebitelský úvěr] > - > wicket:id="kbLoanDebit" class="value">[100 000,00] > - > wicket:id="kbLoanCreditAmount" class="value">[60 000,00] > > - wicket:id="kbLoanCreditAccountNumber" class="value">[123] > > > > > key="bu0008.loanAmount"/> wicket:id="loanAmount"/> > key="bu0437.typeOfLoan"/> > > > wicket:id="linkProductConditions" class="pl-20 highslide-iframe > highslide-layout-6"> > [Úvěrové > podmínky] > > > > > key="bu2154.lengthOfLoanInYears"/> wicket:id="lengthOfLoan"/> > key="bu5462.myAccountForPayment"/> wicket:id="accountToTransfer"/> > > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6478) Nesting 3+ enclosures leads to error You most likely forgot to register the EnclosureHandler with the MarkupParserFactory
[ https://issues.apache.org/jira/browse/WICKET-6478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408079#comment-16408079 ] Andrea Del Bene commented on WICKET-6478: - I've created a minimal quickstart based on your html code. Everything seems to work fine for me. If you have more details please write them down here. > Nesting 3+ enclosures leads to error You most likely forgot to register the > EnclosureHandler with the MarkupParserFactory > - > > Key: WICKET-6478 > URL: https://issues.apache.org/jira/browse/WICKET-6478 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.8.0 > Environment: Websphere 9, IBM JDK 8, Wicket 7.8.0 >Reporter: David Rain >Assignee: Andrea Del Bene >Priority: Major > Labels: WICKET-6026 > Attachments: quickstart.zip > > > The issue reported here WICKET-6026 hasn't been resolved completely. The > error is still present in 7.8.0 when nesting 3 or more enclosures. > It is OK with 2 nested enclosures. > Markup fragment causing error > works fine in 6.24.0 > {code:html} > > > > > > > > wicket:id="otherBankLoanType" >[Spotřebitelský úvěr] > - > wicket:id="otherBankLoanDebit" class="value">[100 000,00] > >- > wicket:id="otherBankLoanMonthlyInstallment" class="value">[2 500,00 > CZK] > > > - wicket:id="otherBankLoanCreditAmount" class="value">[60 000,00] > > > > > > > wicket:id="kbLoanType" >[Spotřebitelský úvěr] > - > wicket:id="kbLoanDebit" class="value">[100 000,00] > - > wicket:id="kbLoanCreditAmount" class="value">[60 000,00] > > - wicket:id="kbLoanCreditAccountNumber" class="value">[123] > > > > > key="bu0008.loanAmount"/> wicket:id="loanAmount"/> > key="bu0437.typeOfLoan"/> > > > wicket:id="linkProductConditions" class="pl-20 highslide-iframe > highslide-layout-6"> > [Úvěrové > podmínky] > > > > > key="bu2154.lengthOfLoanInYears"/> wicket:id="lengthOfLoan"/> > key="bu5462.myAccountForPayment"/> wicket:id="accountToTransfer"/> > > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)