[jira] [Commented] (WICKET-6546) CssContentHeaderItem comments CSS code with HTML comments

2018-03-28 Thread Maxim Solodovnik (JIRA) 

[ 
https://issues.apache.org/jira/browse/WICKET-6546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418361#comment-16418361
 ] 

Maxim Solodovnik commented on WICKET-6546:
--

Your quick-start is same as mine :) (10 times bigger ...)

I can see no errors in browser console

no errors in CSS interpreting, what is the issue ?

> CssContentHeaderItem comments CSS code with HTML comments
> -
>
> Key: WICKET-6546
> URL: https://issues.apache.org/jira/browse/WICKET-6546
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 6.24.0, 6.29.0
>Reporter: Robert Niestroj
>Priority: Minor
> Attachments: wicket6546.zip
>
>
> CssContentHeaderItem wraps the passed CSS in HTML comments thus rendering 
> invalid markup.
> Example code:
>  
> {code:java}
> @Override
> public void renderHead(Component component, IHeaderResponse response) {
>    super.renderHead(component, response);
>    response.render(CssContentHeaderItem.forCSS(".select2-container--open 
> {z-index: 10;}", "select2-mod", ""));
> }
> {code}
> Renders:
>  
> {code:java}
> 
> 
> {code}
> The HTML comments in the CSS make the response invalid and in the browser you 
> get a XML Parsing Error - Not Well Formed.
>  
> It should not render this invalid html comments in CSS.
> Looking at the source code i think the error is in the CssUtils class: 
> https://github.com/apache/wicket/blob/wicket-6.x/wicket-core/src/main/java/org/apache/wicket/core/util/string/CssUtils.java
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (WICKET-6546) CssContentHeaderItem comments CSS code with HTML comments

2018-03-28 Thread Robert Niestroj (JIRA) 

[ 
https://issues.apache.org/jira/browse/WICKET-6546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417991#comment-16417991
 ] 

Robert Niestroj commented on WICKET-6546:
-

Quickstart attached. The page works here, but the comments in the CSS is also 
there.

> CssContentHeaderItem comments CSS code with HTML comments
> -
>
> Key: WICKET-6546
> URL: https://issues.apache.org/jira/browse/WICKET-6546
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 6.24.0, 6.29.0
>Reporter: Robert Niestroj
>Priority: Minor
> Attachments: wicket6546.zip
>
>
> CssContentHeaderItem wraps the passed CSS in HTML comments thus rendering 
> invalid markup.
> Example code:
>  
> {code:java}
> @Override
> public void renderHead(Component component, IHeaderResponse response) {
>    super.renderHead(component, response);
>    response.render(CssContentHeaderItem.forCSS(".select2-container--open 
> {z-index: 10;}", "select2-mod", ""));
> }
> {code}
> Renders:
>  
> {code:java}
> 
> 
> {code}
> The HTML comments in the CSS make the response invalid and in the browser you 
> get a XML Parsing Error - Not Well Formed.
>  
> It should not render this invalid html comments in CSS.
> Looking at the source code i think the error is in the CssUtils class: 
> https://github.com/apache/wicket/blob/wicket-6.x/wicket-core/src/main/java/org/apache/wicket/core/util/string/CssUtils.java
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (WICKET-6546) CssContentHeaderItem comments CSS code with HTML comments

2018-03-28 Thread Robert Niestroj (JIRA) 

 [ 
https://issues.apache.org/jira/browse/WICKET-6546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Niestroj updated WICKET-6546:

Attachment: wicket6546.zip

> CssContentHeaderItem comments CSS code with HTML comments
> -
>
> Key: WICKET-6546
> URL: https://issues.apache.org/jira/browse/WICKET-6546
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 6.24.0, 6.29.0
>Reporter: Robert Niestroj
>Priority: Minor
> Attachments: wicket6546.zip
>
>
> CssContentHeaderItem wraps the passed CSS in HTML comments thus rendering 
> invalid markup.
> Example code:
>  
> {code:java}
> @Override
> public void renderHead(Component component, IHeaderResponse response) {
>    super.renderHead(component, response);
>    response.render(CssContentHeaderItem.forCSS(".select2-container--open 
> {z-index: 10;}", "select2-mod", ""));
> }
> {code}
> Renders:
>  
> {code:java}
> 
> 
> {code}
> The HTML comments in the CSS make the response invalid and in the browser you 
> get a XML Parsing Error - Not Well Formed.
>  
> It should not render this invalid html comments in CSS.
> Looking at the source code i think the error is in the CssUtils class: 
> https://github.com/apache/wicket/blob/wicket-6.x/wicket-core/src/main/java/org/apache/wicket/core/util/string/CssUtils.java
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (WICKET-6533) Error while parsing xml using AjaxButton

2018-03-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/WICKET-6533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417825#comment-16417825
 ] 

ASF GitHub Bot commented on WICKET-6533:


GitHub user solomax opened a pull request:

https://github.com/apache/wicket/pull/270

[WICKET-6533] Unicode non-characters are skipped



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/wicket WICKET-6533-non-characters

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/wicket/pull/270.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #270


commit b85f5c0202439b404028470883f8353a44a2e034
Author: Maxim Solodovnik 
Date:   2018-03-28T17:47:08Z

[WICKET-6533] Unicode non-characters are skipped




> Error while parsing xml using AjaxButton
> 
>
> Key: WICKET-6533
> URL: https://issues.apache.org/jira/browse/WICKET-6533
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 8.0.0-M8
>Reporter: Łukasz Ludwa
>Priority: Major
> Attachments: showcase.zip, showcase_simplified.zip
>
>
> Problem is caused when refreshing markup using Ajax and in data is special 
> character (�).
> Error occurs in my project everywhere when refreshing markup using Ajax where 
> this special character occurs.
> I create and attach quickstart project which reproduces this problem in 
> simple way: changing markup through hiding/showing TextField by ajax button.
>  
> Steps to reproduce problem:
> 1. Download and run attached quickstart project
> 2. Enter to TextField symbol presented under "Insert this string for 
> error..." label:
> 3) Click „Regular submit” twice (this causes component to refresh, but 
> doesn’t cause error)
> 4) Now click „Ajax submit” twice – this causes button to not refresh markup 
> and show error:
>  
> {code:java}
> ERROR: Wicket.Ajax.Call.failure: Error while parsing response: Error: Invalid 
> XML:  id="field3" >{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (WICKET-6533) Error while parsing xml using AjaxButton

2018-03-28 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/WICKET-6533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417820#comment-16417820
 ] 

ASF subversion and git services commented on WICKET-6533:
-

Commit b85f5c0202439b404028470883f8353a44a2e034 in wicket's branch 
refs/heads/WICKET-6533-non-characters from [~solomax]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=b85f5c0 ]

[WICKET-6533] Unicode non-characters are skipped


> Error while parsing xml using AjaxButton
> 
>
> Key: WICKET-6533
> URL: https://issues.apache.org/jira/browse/WICKET-6533
> Project: Wicket
>  Issue Type: Bug
>Affects Versions: 8.0.0-M8
>Reporter: Łukasz Ludwa
>Priority: Major
> Attachments: showcase.zip, showcase_simplified.zip
>
>
> Problem is caused when refreshing markup using Ajax and in data is special 
> character (�).
> Error occurs in my project everywhere when refreshing markup using Ajax where 
> this special character occurs.
> I create and attach quickstart project which reproduces this problem in 
> simple way: changing markup through hiding/showing TextField by ajax button.
>  
> Steps to reproduce problem:
> 1. Download and run attached quickstart project
> 2. Enter to TextField symbol presented under "Insert this string for 
> error..." label:
> 3) Click „Regular submit” twice (this causes component to refresh, but 
> doesn’t cause error)
> 4) Now click „Ajax submit” twice – this causes button to not refresh markup 
> and show error:
>  
> {code:java}
> ERROR: Wicket.Ajax.Call.failure: Error while parsing response: Error: Invalid 
> XML:  id="field3" >{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

wicket git commit: [WICKET-6533] Unicode non-characters are skipped

2018-03-28 Thread solomax 
Repository: wicket
Updated Branches:
  refs/heads/WICKET-6533-non-characters [created] b85f5c020


[WICKET-6533] Unicode non-characters are skipped


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/b85f5c02
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/b85f5c02
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/b85f5c02

Branch: refs/heads/WICKET-6533-non-characters
Commit: b85f5c0202439b404028470883f8353a44a2e034
Parents: c544488
Author: Maxim Solodovnik 
Authored: Thu Mar 29 00:47:08 2018 +0700
Committer: Maxim Solodovnik 
Committed: Thu Mar 29 00:47:08 2018 +0700

--
 .../org/apache/wicket/util/string/Strings.java  | 24 
 .../apache/wicket/util/string/StringsTest.java  |  7 ++
 2 files changed, 31 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/b85f5c02/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java
--
diff --git 
a/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java 
b/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java
index 58475d4..9d6537b 100755
--- a/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java
+++ b/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java
@@ -21,8 +21,11 @@ import java.nio.charset.Charset;
 import java.security.AccessController;
 import java.security.PrivilegedAction;
 import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashSet;
 import java.util.List;
 import java.util.Locale;
+import java.util.Set;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
@@ -59,6 +62,19 @@ public final class Strings
/** A table of hex digits */
private static final char[] HEX_DIGIT = { '0', '1', '2', '3', '4', '5', 
'6', '7', '8', '9',
'A', 'B', 'C', 'D', 'E', 'F' };
+   private static final Set NONCHARACTERS = 
Collections.unmodifiableSet(new HashSet()
+   {
+   private static final long serialVersionUID = 1L;
+
+   {
+   for (int i = 0xFDD0; i <= 0xFDEF; ++i)
+   {
+   add((char)i);
+   }
+   add((char)0xFFFE);
+   // all other non-characters are out of range of (char)
+   }
+   });
 
private static final Pattern HTML_NUMBER_REGEX = 
Pattern.compile("

[jira] [Commented] (WICKET-6544) Chrome and Firefox on iOS detected as Safari version -1

2018-03-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/WICKET-6544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417692#comment-16417692
 ] 

ASF GitHub Bot commented on WICKET-6544:


Github user kbachl commented on the issue:

https://github.com/apache/wicket/pull/269
  
drop this "feature" completely - it just wont work reliable anyway


> Chrome and Firefox on iOS detected as Safari version -1
> ---
>
> Key: WICKET-6544
> URL: https://issues.apache.org/jira/browse/WICKET-6544
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 7.9.0
>Reporter: Sven Ackermann
>Assignee: Maxim Solodovnik
>Priority: Major
>
> The UserAgent detection on iOS for browsers other than Safari does not work 
> correctly.
> E.g. Chrome 64 has UserAgent
> ??Mozilla/5.0 (iPhone; CPU iPhone OS 11_2_6 like Mac OS X) 
> AppleWebKit/604.1.34 (KHTML, like Gecko) CriOS/64.0.3282.112 Mobile/15D100 
> Safari/604.1??
> which is recognized by classes {{UserAgent}} and {{WebClientInfo}} as Safari 
> with no version (-1). The problem is that the UserAgent does not contain 
> "Chrome" as required by {{UserAgent.CHROME}}, but instead "CriOS". So it is 
> recognized as Safari, but since it does not contain "version/", no version is 
> set.
> A similar problem exists for Firefox on iOS where the UserAgent contains 
> "FxiOS" instead of "Firefox":
>  ??Mozilla/5.0 (iPhone; CPU iPhone OS 11_2_6 like Mac OS X) 
> AppleWebKit/604.5.6 (KHTML, like Gecko) FxiOS/10.6b8836 Mobile/15D100 
> Safari/604.5.6??
> In our application this causes some unwanted redirects to legacy pages 
> because we think it is an old Safari browser with no support for some 
> features our pages need. But of course the Chrome und Firefox versions above 
> support all that.
> see also 
> [https://developer.chrome.com/multidevice/user-agent#chrome_for_ios_user_agent|https://developer.chrome.com/multidevice/user-agent#chrome_for_ios_user_agent,]
>  and 
> [https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent/Firefox#Firefox_for_iOS]
>  
> Thanks for looking into it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (WICKET-6546) CssContentHeaderItem comments CSS code with HTML comments

2018-03-28 Thread Maxim Solodovnik (JIRA) 

[ 
https://issues.apache.org/jira/browse/WICKET-6546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417613#comment-16417613
 ] 

Maxim Solodovnik commented on WICKET-6546:
--

Works for me as expected [https://github.com/solomax/ajax-download]

Could you please provide quickstart demonstrating this issue?

> CssContentHeaderItem comments CSS code with HTML comments
> -
>
> Key: WICKET-6546
> URL: https://issues.apache.org/jira/browse/WICKET-6546
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 6.24.0, 6.29.0
>Reporter: Robert Niestroj
>Priority: Minor
>
> CssContentHeaderItem wraps the passed CSS in HTML comments thus rendering 
> invalid markup.
> Example code:
>  
> {code:java}
> @Override
> public void renderHead(Component component, IHeaderResponse response) {
>    super.renderHead(component, response);
>    response.render(CssContentHeaderItem.forCSS(".select2-container--open 
> {z-index: 10;}", "select2-mod", ""));
> }
> {code}
> Renders:
>  
> {code:java}
> 
> 
> {code}
> The HTML comments in the CSS make the response invalid and in the browser you 
> get a XML Parsing Error - Not Well Formed.
>  
> It should not render this invalid html comments in CSS.
> Looking at the source code i think the error is in the CssUtils class: 
> https://github.com/apache/wicket/blob/wicket-6.x/wicket-core/src/main/java/org/apache/wicket/core/util/string/CssUtils.java
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (WICKET-6546) CssContentHeaderItem comments CSS code with HTML comments

2018-03-28 Thread Maxim Solodovnik (JIRA) 

[ 
https://issues.apache.org/jira/browse/WICKET-6546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417568#comment-16417568
 ] 

Maxim Solodovnik commented on WICKET-6546:
--

Works as expected on {{static}} html page

Will try to check with quick-start

> CssContentHeaderItem comments CSS code with HTML comments
> -
>
> Key: WICKET-6546
> URL: https://issues.apache.org/jira/browse/WICKET-6546
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 6.24.0, 6.29.0
>Reporter: Robert Niestroj
>Priority: Minor
>
> CssContentHeaderItem wraps the passed CSS in HTML comments thus rendering 
> invalid markup.
> Example code:
>  
> {code:java}
> @Override
> public void renderHead(Component component, IHeaderResponse response) {
>    super.renderHead(component, response);
>    response.render(CssContentHeaderItem.forCSS(".select2-container--open 
> {z-index: 10;}", "select2-mod", ""));
> }
> {code}
> Renders:
>  
> {code:java}
> 
> 
> {code}
> The HTML comments in the CSS make the response invalid and in the browser you 
> get a XML Parsing Error - Not Well Formed.
>  
> It should not render this invalid html comments in CSS.
> Looking at the source code i think the error is in the CssUtils class: 
> https://github.com/apache/wicket/blob/wicket-6.x/wicket-core/src/main/java/org/apache/wicket/core/util/string/CssUtils.java
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (WICKET-6545) Argument 'markup' may not be null.

2018-03-28 Thread Sven Meier (JIRA) 

 [ 
https://issues.apache.org/jira/browse/WICKET-6545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sven Meier resolved WICKET-6545.

   Resolution: Fixed
Fix Version/s: 8.0.0

isRendering() returns true now during preparation phase (beforeRender) too

> Argument 'markup' may not be null.
> --
>
> Key: WICKET-6545
> URL: https://issues.apache.org/jira/browse/WICKET-6545
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 8.0.0-M9
>Reporter: KAHA
>Assignee: Sven Meier
>Priority: Critical
> Fix For: 8.0.0
>
>
> After switch in maven POM from version M8 to M9 wicket has satred reporting 
> problem
> "Argument 'markup' may not be null." during render component which is 
> descendant of MarkupContainer.
>  
> In version 8.0.0-M8 was everythig allright, but in version 8.0.0-M9, there is 
> error
> Message: Argument 'markup' may not be null.
> Root cause:
> java.lang.IllegalArgumentException: Argument 'markup' may not be null.
> at org.apache.wicket.util.lang.Args.notNull(Args.java:41)
> at org.apache.wicket.markup.MarkupStream.(MarkupStream.java:65)
> at 
> org.apache.wicket.markup.html.TransparentWebMarkupContainer.renderHeadForInnerSiblings(TransparentWebMarkupContainer.java:134)
> at 
> org.apache.wicket.markup.html.TransparentWebMarkupContainer.internalRenderHead(TransparentWebMarkupContainer.java:89)
> at 
> org.apache.wicket.markup.renderStrategy.ChildFirstHeaderRenderStrategy$1.component(ChildFirstHeaderRenderStrategy.java:85)
> at 
> org.apache.wicket.markup.renderStrategy.DeepChildFirstVisitor.visit(DeepChildFirstVisitor.java:96)
> at 
> org.apache.wicket.markup.renderStrategy.DeepChildFirstVisitor.visit(DeepChildFirstVisitor.java:87)
> at 
> org.apache.wicket.markup.renderStrategy.DeepChildFirstVisitor.visit(DeepChildFirstVisitor.java:87)
> at 
> org.apache.wicket.markup.renderStrategy.DeepChildFirstVisitor.visit(DeepChildFirstVisitor.java:51)
> at 
> org.apache.wicket.markup.renderStrategy.ChildFirstHeaderRenderStrategy.renderChildHeaders(ChildFirstHeaderRenderStrategy.java:94)
> at 
> org.apache.wicket.markup.renderStrategy.ChildFirstHeaderRenderStrategy.renderHeader(ChildFirstHeaderRenderStrategy.java:57)
> at 
> org.apache.wicket.page.PartialPageUpdate.writeHeaderContribution(PartialPageUpdate.java:551)
> at 
> org.apache.wicket.page.XmlPartialPageUpdate.writeComponent(XmlPartialPageUpdate.java:75)
> at 
> org.apache.wicket.page.PartialPageUpdate.writeComponents(PartialPageUpdate.java:262)
> at 
> org.apache.wicket.page.PartialPageUpdate.writeTo(PartialPageUpdate.java:162)
> at eu.abra.web.base.AjaxRequestHandler.respond(AjaxRequestHandler.java:343)
> at 
> org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor.respond(RequestCycle.java:912)
> at 
> org.apache.wicket.request.RequestHandlerExecutor.execute(RequestHandlerExecutor.java:65)
> at org.apache.wicket.request.cycle.RequestCycle.execute(RequestCycle.java:283)
> at 
> org.apache.wicket.request.cycle.RequestCycle.processRequest(RequestCycle.java:253)
> at 
> org.apache.wicket.request.cycle.RequestCycle.processRequestAndDetach(RequestCycle.java:221)
> at 
> org.apache.wicket.protocol.http.WicketFilter.processRequestCycle(WicketFilter.java:262)
> at 
> org.apache.wicket.protocol.http.WicketFilter.processRequest(WicketFilter.java:204)
> at 
> org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:286)
> at 
> org.atmosphere.util.AtmosphereFilterChain.doFilter(AtmosphereFilterChain.java:119)
> at 
> org.atmosphere.util.AtmosphereFilterChain.invokeFilterChain(AtmosphereFilterChain.java:96)
> at 
> org.atmosphere.handler.ReflectorServletProcessor$FilterChainServletWrapper.service(ReflectorServletProcessor.java:317)
> at 
> org.atmosphere.handler.ReflectorServletProcessor.onRequest(ReflectorServletProcessor.java:160)
> at 
> org.atmosphere.cpr.AsynchronousProcessor.action(AsynchronousProcessor.java:199)
> at 
> org.atmosphere.cpr.AsynchronousProcessor.suspended(AsynchronousProcessor.java:107)
> at 
> org.atmosphere.container.BlockingIOCometSupport.service(BlockingIOCometSupport.java:63)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (WICKET-6545) Argument 'markup' may not be null.

2018-03-28 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/WICKET-6545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417508#comment-16417508
 ] 

ASF subversion and git services commented on WICKET-6545:
-

Commit cea08bfbd72b3b1fb4d9668b7c2a8012d3f06dac in wicket's branch 
refs/heads/master from [~svenmeier]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=cea08bf ]

WICKET-6545 isRendering() includes preparation

phase now; extended tests for TransparentWebMarkupContainer


> Argument 'markup' may not be null.
> --
>
> Key: WICKET-6545
> URL: https://issues.apache.org/jira/browse/WICKET-6545
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 8.0.0-M9
>Reporter: KAHA
>Assignee: Sven Meier
>Priority: Critical
>
> After switch in maven POM from version M8 to M9 wicket has satred reporting 
> problem
> "Argument 'markup' may not be null." during render component which is 
> descendant of MarkupContainer.
>  
> In version 8.0.0-M8 was everythig allright, but in version 8.0.0-M9, there is 
> error
> Message: Argument 'markup' may not be null.
> Root cause:
> java.lang.IllegalArgumentException: Argument 'markup' may not be null.
> at org.apache.wicket.util.lang.Args.notNull(Args.java:41)
> at org.apache.wicket.markup.MarkupStream.(MarkupStream.java:65)
> at 
> org.apache.wicket.markup.html.TransparentWebMarkupContainer.renderHeadForInnerSiblings(TransparentWebMarkupContainer.java:134)
> at 
> org.apache.wicket.markup.html.TransparentWebMarkupContainer.internalRenderHead(TransparentWebMarkupContainer.java:89)
> at 
> org.apache.wicket.markup.renderStrategy.ChildFirstHeaderRenderStrategy$1.component(ChildFirstHeaderRenderStrategy.java:85)
> at 
> org.apache.wicket.markup.renderStrategy.DeepChildFirstVisitor.visit(DeepChildFirstVisitor.java:96)
> at 
> org.apache.wicket.markup.renderStrategy.DeepChildFirstVisitor.visit(DeepChildFirstVisitor.java:87)
> at 
> org.apache.wicket.markup.renderStrategy.DeepChildFirstVisitor.visit(DeepChildFirstVisitor.java:87)
> at 
> org.apache.wicket.markup.renderStrategy.DeepChildFirstVisitor.visit(DeepChildFirstVisitor.java:51)
> at 
> org.apache.wicket.markup.renderStrategy.ChildFirstHeaderRenderStrategy.renderChildHeaders(ChildFirstHeaderRenderStrategy.java:94)
> at 
> org.apache.wicket.markup.renderStrategy.ChildFirstHeaderRenderStrategy.renderHeader(ChildFirstHeaderRenderStrategy.java:57)
> at 
> org.apache.wicket.page.PartialPageUpdate.writeHeaderContribution(PartialPageUpdate.java:551)
> at 
> org.apache.wicket.page.XmlPartialPageUpdate.writeComponent(XmlPartialPageUpdate.java:75)
> at 
> org.apache.wicket.page.PartialPageUpdate.writeComponents(PartialPageUpdate.java:262)
> at 
> org.apache.wicket.page.PartialPageUpdate.writeTo(PartialPageUpdate.java:162)
> at eu.abra.web.base.AjaxRequestHandler.respond(AjaxRequestHandler.java:343)
> at 
> org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor.respond(RequestCycle.java:912)
> at 
> org.apache.wicket.request.RequestHandlerExecutor.execute(RequestHandlerExecutor.java:65)
> at org.apache.wicket.request.cycle.RequestCycle.execute(RequestCycle.java:283)
> at 
> org.apache.wicket.request.cycle.RequestCycle.processRequest(RequestCycle.java:253)
> at 
> org.apache.wicket.request.cycle.RequestCycle.processRequestAndDetach(RequestCycle.java:221)
> at 
> org.apache.wicket.protocol.http.WicketFilter.processRequestCycle(WicketFilter.java:262)
> at 
> org.apache.wicket.protocol.http.WicketFilter.processRequest(WicketFilter.java:204)
> at 
> org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:286)
> at 
> org.atmosphere.util.AtmosphereFilterChain.doFilter(AtmosphereFilterChain.java:119)
> at 
> org.atmosphere.util.AtmosphereFilterChain.invokeFilterChain(AtmosphereFilterChain.java:96)
> at 
> org.atmosphere.handler.ReflectorServletProcessor$FilterChainServletWrapper.service(ReflectorServletProcessor.java:317)
> at 
> org.atmosphere.handler.ReflectorServletProcessor.onRequest(ReflectorServletProcessor.java:160)
> at 
> org.atmosphere.cpr.AsynchronousProcessor.action(AsynchronousProcessor.java:199)
> at 
> org.atmosphere.cpr.AsynchronousProcessor.suspended(AsynchronousProcessor.java:107)
> at 
> org.atmosphere.container.BlockingIOCometSupport.service(BlockingIOCometSupport.java:63)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

wicket git commit: WICKET-6545 isRendering() includes preparation

2018-03-28 Thread svenmeier 
Repository: wicket
Updated Branches:
  refs/heads/master c54448859 -> cea08bfbd


WICKET-6545 isRendering() includes preparation

phase now; extended tests for TransparentWebMarkupContainer


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/cea08bfb
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/cea08bfb
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/cea08bfb

Branch: refs/heads/master
Commit: cea08bfbd72b3b1fb4d9668b7c2a8012d3f06dac
Parents: c544488
Author: Sven Meier 
Authored: Wed Mar 28 15:52:40 2018 +0200
Committer: Sven Meier 
Committed: Wed Mar 28 15:52:40 2018 +0200

--
 .../main/java/org/apache/wicket/Component.java  |  4 +-
 .../html/TransparentWebMarkupContainerTest.java | 70 
 2 files changed, 59 insertions(+), 15 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/cea08bfb/wicket-core/src/main/java/org/apache/wicket/Component.java
--
diff --git a/wicket-core/src/main/java/org/apache/wicket/Component.java 
b/wicket-core/src/main/java/org/apache/wicket/Component.java
index c1ae823..c033194 100644
--- a/wicket-core/src/main/java/org/apache/wicket/Component.java
+++ b/wicket-core/src/main/java/org/apache/wicket/Component.java
@@ -4368,13 +4368,13 @@ public abstract class Component
}

/**
-* Says if the component is rendering or not checking the corresponding 
flag.
+* Says if the component is rendering currently.
 * 
 * @return true if this component is rendering, false otherwise.
 */
public final boolean isRendering()
{
-   return getRequestFlag(RFLAG_RENDERING);
+   return getRequestFlag(RFLAG_PREPARED_FOR_RENDER) || 
getRequestFlag(RFLAG_RENDERING);
}
 
/**

http://git-wip-us.apache.org/repos/asf/wicket/blob/cea08bfb/wicket-core/src/test/java/org/apache/wicket/markup/html/TransparentWebMarkupContainerTest.java
--
diff --git 
a/wicket-core/src/test/java/org/apache/wicket/markup/html/TransparentWebMarkupContainerTest.java
 
b/wicket-core/src/test/java/org/apache/wicket/markup/html/TransparentWebMarkupContainerTest.java
index 9233dcb..39586e0 100644
--- 
a/wicket-core/src/test/java/org/apache/wicket/markup/html/TransparentWebMarkupContainerTest.java
+++ 
b/wicket-core/src/test/java/org/apache/wicket/markup/html/TransparentWebMarkupContainerTest.java
@@ -29,6 +29,7 @@ import org.apache.wicket.markup.IMarkupResourceStreamProvider;
 import org.apache.wicket.markup.MarkupException;
 import org.apache.wicket.markup.html.basic.Label;
 import org.apache.wicket.markup.html.border.Border;
+import org.apache.wicket.markup.html.internal.HtmlHeaderContainer;
 import org.apache.wicket.markup.html.panel.Fragment;
 import org.apache.wicket.mock.MockPageManager;
 import org.apache.wicket.page.IManageablePage;
@@ -37,7 +38,6 @@ import org.apache.wicket.page.IPageManagerContext;
 import org.apache.wicket.request.mapper.parameter.PageParameters;
 import org.apache.wicket.util.resource.IResourceStream;
 import org.apache.wicket.util.resource.StringResourceStream;
-import org.apache.wicket.util.tester.TagTester;
 import org.apache.wicket.util.tester.WicketTestCase;
 import org.apache.wicket.util.tester.WicketTester;
 import org.junit.Test;
@@ -242,16 +242,25 @@ public class TransparentWebMarkupContainerTest extends 
WicketTestCase
 * Headers not rendered for components inside 
TransparentWebMarkupContainer on ajax update
 */
@Test
-   public void updateEmbeddedAjaxComponent() throws Exception
+   public void updateAjaxUpdateOfTransparentContainer() throws Exception
{
-   tester.startPage(TestEmbeddedAjaxComponet.class);
-   tester.clickLink("ajaxLink", true);
+   TestEmbeddedAjaxComponet page = new TestEmbeddedAjaxComponet();
+   tester.startPage(page);
+   assertEquals(2, page.renderHeadCount);

-   TagTester scriptTag = TagTester.createTagByAttribute(
-   tester.getLastResponseAsString(), 
"header-contribution");
+   tester.clickLink("container:updateTransparentContainer", true);
+   assertEquals(4, page.renderHeadCount);
+   }
+   
+   @Test
+   public void updateAjaxUpdateOfContainerWithTransparentContainer() 
throws Exception
+   {
+   TestEmbeddedAjaxComponet page = new TestEmbeddedAjaxComponet();
+   tester.startPage(page);
+   assertEquals(2, page.renderHeadCount);

-   //check if our response contains

[jira] [Updated] (WICKET-6546) CssContentHeaderItem comments CSS code with HTML comments

2018-03-28 Thread Robert Niestroj (JIRA) 

 [ 
https://issues.apache.org/jira/browse/WICKET-6546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Niestroj updated WICKET-6546:

Affects Version/s: 6.29.0

> CssContentHeaderItem comments CSS code with HTML comments
> -
>
> Key: WICKET-6546
> URL: https://issues.apache.org/jira/browse/WICKET-6546
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 6.24.0, 6.29.0
>Reporter: Robert Niestroj
>Priority: Minor
>
> CssContentHeaderItem wraps the passed CSS in HTML comments thus rendering 
> invalid markup.
> Example code:
>  
> {code:java}
> @Override
> public void renderHead(Component component, IHeaderResponse response) {
>    super.renderHead(component, response);
>    response.render(CssContentHeaderItem.forCSS(".select2-container--open 
> {z-index: 10;}", "select2-mod", ""));
> }
> {code}
> Renders:
>  
> {code:java}
> 
> 
> {code}
> The HTML comments in the CSS make the response invalid and in the browser you 
> get a XML Parsing Error - Not Well Formed.
>  
> It should not render this invalid html comments in CSS.
> Looking at the source code i think the error is in the CssUtils class: 
> https://github.com/apache/wicket/blob/wicket-6.x/wicket-core/src/main/java/org/apache/wicket/core/util/string/CssUtils.java
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (WICKET-6546) CssContentHeaderItem comments CSS code with HTML comments

2018-03-28 Thread Robert Niestroj (JIRA) 

 [ 
https://issues.apache.org/jira/browse/WICKET-6546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Niestroj updated WICKET-6546:

Description: 
CssContentHeaderItem wraps the passed CSS in HTML comments thus rendering 
invalid markup.

Example code:

 
{code:java}
@Override
public void renderHead(Component component, IHeaderResponse response) {
   super.renderHead(component, response);
   response.render(CssContentHeaderItem.forCSS(".select2-container--open 
{z-index: 10;}", "select2-mod", ""));
}
{code}
Renders:

 
{code:java}


{code}
The HTML comments in the CSS make the response invalid and in the browser you 
get a XML Parsing Error - Not Well Formed.

 

It should not render this invalid html comments in CSS.

Looking at the source code i think the error is in the CssUtils class: 
https://github.com/apache/wicket/blob/wicket-6.x/wicket-core/src/main/java/org/apache/wicket/core/util/string/CssUtils.java

 

  was:
CssContentHeaderItem wraps the passed CSS in HTML comments thus rendering 
invalid markup. 

Example code:

 
{code:java}
@Override
public void renderHead(Component component, IHeaderResponse response) {
   super.renderHead(component, response);
   response.render(CssContentHeaderItem.forCSS(".select2-container--open 
{z-index: 10;}", "select2-mod", ""));
}
{code}
Renders:

 
{code:java}


{code}
The HTML comments in the CSS make the response invalid and in the browser you 
get a XML Parsing Error - Not Well Formed.

 

It should not render this invalid html comments in CSS.


> CssContentHeaderItem comments CSS code with HTML comments
> -
>
> Key: WICKET-6546
> URL: https://issues.apache.org/jira/browse/WICKET-6546
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 6.24.0
>Reporter: Robert Niestroj
>Priority: Minor
>
> CssContentHeaderItem wraps the passed CSS in HTML comments thus rendering 
> invalid markup.
> Example code:
>  
> {code:java}
> @Override
> public void renderHead(Component component, IHeaderResponse response) {
>    super.renderHead(component, response);
>    response.render(CssContentHeaderItem.forCSS(".select2-container--open 
> {z-index: 10;}", "select2-mod", ""));
> }
> {code}
> Renders:
>  
> {code:java}
> 
> 
> {code}
> The HTML comments in the CSS make the response invalid and in the browser you 
> get a XML Parsing Error - Not Well Formed.
>  
> It should not render this invalid html comments in CSS.
> Looking at the source code i think the error is in the CssUtils class: 
> https://github.com/apache/wicket/blob/wicket-6.x/wicket-core/src/main/java/org/apache/wicket/core/util/string/CssUtils.java
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (WICKET-6546) CssContentHeaderItem comments CSS code with HTML comments

2018-03-28 Thread Robert Niestroj (JIRA) 
Robert Niestroj created WICKET-6546:
---

 Summary: CssContentHeaderItem comments CSS code with HTML comments
 Key: WICKET-6546
 URL: https://issues.apache.org/jira/browse/WICKET-6546
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 6.24.0
Reporter: Robert Niestroj


CssContentHeaderItem wraps the passed CSS in HTML comments thus rendering 
invalid markup. 

Example code:

 
{code:java}
@Override
public void renderHead(Component component, IHeaderResponse response) {
   super.renderHead(component, response);
   response.render(CssContentHeaderItem.forCSS(".select2-container--open 
{z-index: 10;}", "select2-mod", ""));
}
{code}
Renders:

 
{code:java}


{code}
The HTML comments in the CSS make the response invalid and in the browser you 
get a XML Parsing Error - Not Well Formed.

 

It should not render this invalid html comments in CSS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)