[jira] [Issue Comment Deleted] (WICKET-6321) Support Integrity and Crossorigin attributes for JavaScriptUrlReferenceHeaderItem
[ https://issues.apache.org/jira/browse/WICKET-6321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dieter Tremel updated WICKET-6321: -- Comment: was deleted (was: PR: https://github.com/apache/wicket/pull/273) > Support Integrity and Crossorigin attributes for > JavaScriptUrlReferenceHeaderItem > -- > > Key: WICKET-6321 > URL: https://issues.apache.org/jira/browse/WICKET-6321 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 8.0.0-M3 >Reporter: Mikhail Fursov >Priority: Major > Fix For: 8.0.0 > > Attachments: wicket-6321-20180306.diff, wicket-6321.diff > > > Example of secure script reference: > src="https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/4.0.0-alpha.6/js/bootstrap.min.js"; > integrity="sha256-+kIbbrvS+0dNOjhmQJzmwe/RILR/8lb/+4+PUNVW09k=" > crossorigin="anonymous"> -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6321) Support Integrity and Crossorigin attributes for JavaScriptUrlReferenceHeaderItem
[ https://issues.apache.org/jira/browse/WICKET-6321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420686#comment-16420686 ] ASF GitHub Bot commented on WICKET-6321: GitHub user tremel opened a pull request: https://github.com/apache/wicket/pull/273 WICKET-6321 Support Integrity and Crossorigin attributes WICKET-6321 Support Integrity and Crossorigin attributes for JavaScriptUrlReferenceHeaderItem You can merge this pull request into a Git repository by running: $ git pull https://github.com/tremel/wicket master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/wicket/pull/273.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #273 commit bea5c61463391099c4f06dd05607f8b9326312b8 Author: Dieter Tremel Date: 2018-03-30T16:40:19Z WICKET-6321 Support Integrity and Crossorigin attributes for JavaScriptUrlReferenceHeaderItem > Support Integrity and Crossorigin attributes for > JavaScriptUrlReferenceHeaderItem > -- > > Key: WICKET-6321 > URL: https://issues.apache.org/jira/browse/WICKET-6321 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 8.0.0-M3 >Reporter: Mikhail Fursov >Priority: Major > Fix For: 8.0.0 > > Attachments: wicket-6321-20180306.diff, wicket-6321.diff > > > Example of secure script reference: > src="https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/4.0.0-alpha.6/js/bootstrap.min.js"; > integrity="sha256-+kIbbrvS+0dNOjhmQJzmwe/RILR/8lb/+4+PUNVW09k=" > crossorigin="anonymous"> -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6321) Support Integrity and Crossorigin attributes for JavaScriptUrlReferenceHeaderItem
[ https://issues.apache.org/jira/browse/WICKET-6321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420687#comment-16420687 ] Dieter Tremel commented on WICKET-6321: --- PR: https://github.com/apache/wicket/pull/273 > Support Integrity and Crossorigin attributes for > JavaScriptUrlReferenceHeaderItem > -- > > Key: WICKET-6321 > URL: https://issues.apache.org/jira/browse/WICKET-6321 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 8.0.0-M3 >Reporter: Mikhail Fursov >Priority: Major > Fix For: 8.0.0 > > Attachments: wicket-6321-20180306.diff, wicket-6321.diff > > > Example of secure script reference: > src="https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/4.0.0-alpha.6/js/bootstrap.min.js"; > integrity="sha256-+kIbbrvS+0dNOjhmQJzmwe/RILR/8lb/+4+PUNVW09k=" > crossorigin="anonymous"> -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (WICKET-6547) NPE upon session timeout
Rakesh A created WICKET-6547: Summary: NPE upon session timeout Key: WICKET-6547 URL: https://issues.apache.org/jira/browse/WICKET-6547 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.29.0 Reporter: Rakesh A Wicket 6.29.0 has a fix for https://issues.apache.org/jira/browse/WICKET-6484 change-set of which can be see at - [https://git-wip-us.apache.org/repos/asf?p=wicket.git;a=blobdiff;f=wicket-core/src/main/java/org/apache/wicket/Session.java;h=21a9432a2c5d5005b215dd5d7c3b15bf87fda0ba;hp=5bab1c6bf5fd60243c7adc8a9a6f248f41f78166;hb=35b9381;hpb=d0967b2312ed999b289566fbdd81eb282ad20c8e] Problem I see with this fix is, when session times out there wont be a request cycle, RequestCycle.get() will return NULL and 'isSessionInvalidated()' method call in 'org.apache.wicket.protocol.http.WebSession.invalidate()' will result a NPE -- This message was sent by Atlassian JIRA (v7.6.3#76005)
