[jira] [Commented] (WICKET-6546) CssContentHeaderItem comments CSS code with HTML comments
[
https://issues.apache.org/jira/browse/WICKET-6546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426201#comment-16426201
]
Sven Meier commented on WICKET-6546:
I'd prefer if we applied the change to Wicket 7 and 8 only.
There are really old Wicket 6 projects out there that might not work with this
change. This issue isn't so important that we should take any risk.
> CssContentHeaderItem comments CSS code with HTML comments
> -
>
> Key: WICKET-6546
> URL: https://issues.apache.org/jira/browse/WICKET-6546
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 6.24.0, 6.29.0
>Reporter: Robert Niestroj
>Assignee: Maxim Solodovnik
>Priority: Minor
> Attachments: wicket6546 (2).zip
>
>
> CssContentHeaderItem wraps the passed CSS in HTML comments thus rendering
> invalid markup.
> Example code:
>
> {code:java}
> @Override
> public void renderHead(Component component, IHeaderResponse response) {
> super.renderHead(component, response);
> response.render(CssContentHeaderItem.forCSS(".select2-container--open
> {z-index: 10;}", "select2-mod", ""));
> }
> {code}
> Renders:
>
> {code:java}
>
>
> {code}
> The HTML comments in the CSS make the response invalid and in the browser you
> get a XML Parsing Error - Not Well Formed.
>
> It should not render this invalid html comments in CSS.
> Looking at the source code i think the error is in the CssUtils class:
> https://github.com/apache/wicket/blob/wicket-6.x/wicket-core/src/main/java/org/apache/wicket/core/util/string/CssUtils.java
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WICKET-6544) Chrome and Firefox on iOS detected as Safari version -1
[
https://issues.apache.org/jira/browse/WICKET-6544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426055#comment-16426055
]
ASF GitHub Bot commented on WICKET-6544:
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/269
I also looked a bit around and stumbled over Apache DeviceMap which has
been moved into the Attic and from the Attic
(http://attic.apache.org/projects/devicemap.html) I followed the link to
https://github.com/nielsbasjes/yauaa which seems to be maintained.
@kbachl - I understand your suggestion to remove it because of reliability,
but I would keep the functionality with the hint that there might be some not
supported browsers which is better than no detection.
> Chrome and Firefox on iOS detected as Safari version -1
> ---
>
> Key: WICKET-6544
> URL: https://issues.apache.org/jira/browse/WICKET-6544
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 7.9.0
>Reporter: Sven Ackermann
>Assignee: Maxim Solodovnik
>Priority: Major
>
> The UserAgent detection on iOS for browsers other than Safari does not work
> correctly.
> E.g. Chrome 64 has UserAgent
> ??Mozilla/5.0 (iPhone; CPU iPhone OS 11_2_6 like Mac OS X)
> AppleWebKit/604.1.34 (KHTML, like Gecko) CriOS/64.0.3282.112 Mobile/15D100
> Safari/604.1??
> which is recognized by classes {{UserAgent}} and {{WebClientInfo}} as Safari
> with no version (-1). The problem is that the UserAgent does not contain
> "Chrome" as required by {{UserAgent.CHROME}}, but instead "CriOS". So it is
> recognized as Safari, but since it does not contain "version/", no version is
> set.
> A similar problem exists for Firefox on iOS where the UserAgent contains
> "FxiOS" instead of "Firefox":
> ??Mozilla/5.0 (iPhone; CPU iPhone OS 11_2_6 like Mac OS X)
> AppleWebKit/604.5.6 (KHTML, like Gecko) FxiOS/10.6b8836 Mobile/15D100
> Safari/604.5.6??
> In our application this causes some unwanted redirects to legacy pages
> because we think it is an old Safari browser with no support for some
> features our pages need. But of course the Chrome und Firefox versions above
> support all that.
> see also
> [https://developer.chrome.com/multidevice/user-agent#chrome_for_ios_user_agent|https://developer.chrome.com/multidevice/user-agent#chrome_for_ios_user_agent,]
> and
> [https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent/Firefox#Firefox_for_iOS]
>
> Thanks for looking into it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WICKET-6321) Support Integrity and Crossorigin attributes for JavaScriptUrlReferenceHeaderItem
[ https://issues.apache.org/jira/browse/WICKET-6321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425087#comment-16425087 ] ASF GitHub Bot commented on WICKET-6321: Github user tremel commented on the issue: https://github.com/apache/wicket/pull/273 For a usage example and test I made [CORS.zip](https://github.com/apache/wicket/files/1874596/CORS.zip), a mofified quickstart showing a bootstrap 4 page with bootstrap css and jquery, popper and bootstrap js with CORS. > Support Integrity and Crossorigin attributes for > JavaScriptUrlReferenceHeaderItem > -- > > Key: WICKET-6321 > URL: https://issues.apache.org/jira/browse/WICKET-6321 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 8.0.0-M3 >Reporter: Mikhail Fursov >Priority: Major > Fix For: 8.0.0 > > Attachments: CORS.zip, wicket-6321-20180306.diff, wicket-6321.diff > > > Example of secure script reference: > src="https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/4.0.0-alpha.6/js/bootstrap.min.js"; > integrity="sha256-+kIbbrvS+0dNOjhmQJzmwe/RILR/8lb/+4+PUNVW09k=" > crossorigin="anonymous"> -- This message was sent by Atlassian JIRA (v7.6.3#76005)
