[jira] [Commented] (WICKET-6586) Broken JavaScript due to fix charsetName in JavaScriptPackageResource
[
https://issues.apache.org/jira/browse/WICKET-6586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649952#comment-16649952
]
ASF GitHub Bot commented on WICKET-6586:
Github user svenmeier commented on the issue:
https://github.com/apache/wicket/pull/295
+1
> Broken JavaScript due to fix charsetName in JavaScriptPackageResource
> -
>
> Key: WICKET-6586
> URL: https://issues.apache.org/jira/browse/WICKET-6586
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 7.10.0
>Reporter: Andreas Müller
>Assignee: Martin Grigorov
>Priority: Major
>
> When running Wicket in DEPLOYMENT Mode, {{DefaultJavaScriptCompressor}} will
> be set as JavaScript Compressor by default to strip Comments and Whitespaces
> from JavaScript files.
> In {{JavaScriptPackageResource}} the {{processResponse}} method sets the
> charsetName fix to "UTF-8", when compressing JS files:
> {code:java}
> @Override
> protected byte[] processResponse(final Attributes attributes, byte[] bytes)
> {
> final byte[] processedResponse = super.processResponse(attributes, bytes);
> IJavaScriptCompressor compressor = getCompressor();
> if (compressor != null && getCompress())
> {
> try
> {
>String charsetName = "UTF-8";
> ...{code}
> If those JavaScript files are not in UTF-8, the Compressor can break those
> files.
> E.g. when using ISO-8859-15 and having umlauts in the file, the umlauts will
> be replaced by the REPLACEMENT CHARACTER "\uefbfbd".
> There should be a way to specify the charsetName in
> {{JavaScriptPackageResource}}.
> E.g. by calling something like
> {{getResourceSettings().setJavaScriptCharset()}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WICKET-4423) Modal Window dragging failes with iframe
[ https://issues.apache.org/jira/browse/WICKET-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650826#comment-16650826 ] ASF subversion and git services commented on WICKET-4423: - Commit c7be83b16f5ef016c8d981d4b5f74bf480097868 in wicket's branch refs/heads/wicket-8.x from [~svenmeier] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=c7be83b ] WICKET-4423 allow dragging over iframe with pointer-events=none > Modal Window dragging failes with iframe > > > Key: WICKET-4423 > URL: https://issues.apache.org/jira/browse/WICKET-4423 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 6.0.0-beta1 >Reporter: Sven Meier >Assignee: Sven Meier >Priority: Major > > Forwarding of mouse event from nested iframes seems to have stopped working. > (see javascript Wicket.Iframe) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[1/2] wicket git commit: WICKET-5552 allow prevention of drags
Repository: wicket
Updated Branches:
refs/heads/wicket-8.x efc8ceb42 -> c7be83b16
WICKET-5552 allow prevention of drags
used by ModalWindow to prevent dragging on window content
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/03412f18
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/03412f18
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/03412f18
Branch: refs/heads/wicket-8.x
Commit: 03412f18eeab8954cc60f5532585993ae1f012d0
Parents: efc8ceb
Author: Sven Meier
Authored: Mon Oct 15 23:15:06 2018 +0200
Committer: Sven Meier
Committed: Mon Oct 15 23:15:06 2018 +0200
--
.../wicket/ajax/res/js/wicket-ajax-jquery.js| 25 +---
.../ajax/markup/html/modal/res/modal.js | 11 +++--
2 files changed, 25 insertions(+), 11 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/03412f18/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
b/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
index 0969bb8..c58e502 100644
---
a/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
+++
b/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
@@ -2257,13 +2257,18 @@
Drag: {
/**
-* Initializes the dragging on the specified element.
-* Element's onmousedown will be replaced by generated
handler.
-*
-* @param {Element} element - element clicking on which
the drag should begin
-* @param {Function} onDragBegin - handler called at
the begin on dragging - passed element as first parameter
-* @param {Function} onDragEnd - handler called at the
end of dragging - passed element as first parameter
-* @param {Function} onDrag - handler called during
dragging - passed element and mouse deltas
+* Initializes dragging on the specified element.
+*
+* @param element {Element}
+*element clicking on which
+*the drag should begin
+* @param onDragBegin {Function}
+*called at the begin of dragging - passed
element and event as parameters,
+*may return false to prevent the start
+* @param onDragEnd {Function}
+*handler called at the end of dragging -
passed element as parameter
+* @param onDrag {Function}
+*handler called during dragging - passed
element and mouse deltas as parameters
*/
init: function(element, onDragBegin, onDragEnd, onDrag)
{
@@ -2293,14 +2298,16 @@
var element = this;
+ if (element.wicketOnDragBegin(element, e) ===
false) {
+ return;
+ }
+
Wicket.Event.stop(e);
if (e.preventDefault) {
e.preventDefault();
}
- element.wicketOnDragBegin(element);
-
element.lastMouseX = e.clientX;
element.lastMouseY = e.clientY;
http://git-wip-us.apache.org/repos/asf/wicket/blob/03412f18/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
--
diff --git
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
index b00ceec..6bcebf2 100644
---
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
+++
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
@@ -901,11 +901,18 @@
/**
* Called when dragging has started.
*/
- onBegin: function(object) {
+ onBegin: function(element, event) {
+ // ignore anything inside the content
+ if (jQuery(event.target).closest('.w_content
[jira] [Commented] (WICKET-5552) Events to close pop-up on Modal Window are not propagated
[ https://issues.apache.org/jira/browse/WICKET-5552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650825#comment-16650825 ] ASF subversion and git services commented on WICKET-5552: - Commit 03412f18eeab8954cc60f5532585993ae1f012d0 in wicket's branch refs/heads/wicket-8.x from [~svenmeier] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=03412f1 ] WICKET-5552 allow prevention of drags used by ModalWindow to prevent dragging on window content > Events to close pop-up on Modal Window are not propagated > - > > Key: WICKET-5552 > URL: https://issues.apache.org/jira/browse/WICKET-5552 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 7.10.0 > Environment: Windows/Eclipse/JRE7 >Reporter: Neil Bennett >Priority: Minor > Labels: javascript, modalwindow > Attachments: quickstart.zip > > > When using a field on a modal window that shows a pop-up window, like a time > picker, when clicking outside of the pop-up window but over the modal window, > mousedown/click events are not propagated. Clicks outside of the modal window > are propagated. > This is due to Wicket.Event.stop(event) being called on mousedown on the > w_content_1 component. Removal of this leads to the Drag javascript being > executed which itself calls Wicket.Event.stop(event), disabling this then > propagates the event which leads to the pop-up window being closed but causes > any field on the modalwindow to get focus. > I have a quickstart that demonstrates the modalwindow behavior vs that on a > page. You will see that launching the modal window and clicking on the time > component opens the pop-up window. However, you can only get this to close > when clicking outside of the modal window. The same component has been put on > the main page as a comparison which does close when clicking outside of the > pop-up window. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[2/2] wicket git commit: WICKET-4423 allow dragging over iframe
WICKET-4423 allow dragging over iframe
with pointer-events=none
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/c7be83b1
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/c7be83b1
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/c7be83b1
Branch: refs/heads/wicket-8.x
Commit: c7be83b16f5ef016c8d981d4b5f74bf480097868
Parents: 03412f1
Author: Sven Meier
Authored: Mon Oct 15 23:29:14 2018 +0200
Committer: Sven Meier
Committed: Mon Oct 15 23:29:14 2018 +0200
--
.../ajax/markup/html/modal/res/modal.js | 154 +--
1 file changed, 6 insertions(+), 148 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/c7be83b1/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
--
diff --git
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
index 6bcebf2..8b66687 100644
---
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
+++
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
@@ -56,142 +56,6 @@
}
/**
-* Supporting code for getting mouse move and mouse up events from
iframes.
-* The problem when dragging a div with an iframe is that when the
mouse cursor
-* gets over an iframe, all mouse events are received by the iframe's
document. (IE and FF)
-*
-* This code can recursively traverse all iframes in document and
temporarily forward
-* events from their documents to parent document.
-*/
- Wicket.Iframe = {
-
- /**
-* Returns the horizontal position of given element (in pixels).
-*/
- findPosX: function(e) {
- if (e.offsetParent) {
- var c = 0;
- while (e) {
- c += e.offsetLeft;
- e = e.offsetParent;
- }
- return c;
- } else if (e.x) {
- return e.x;
- } else {
- return 0;
- }
- },
-
- /**
-* Returns the vertical position of given element (in pixels).
-*/
- findPosY: function(e) {
- if (e.offsetParent) {
- var c = 0;
- while (e) {
- c += e.offsetTop;
- e = e.offsetParent;
- }
- return c;
- } else if (e.y) {
- return e.y;
- } else {
- return 0;
- }
- },
-
- /**
-* Forwards the events from iframe to the parent document
(works recursively).
-* @param {Document} doc - document to which the events will be
forwarded
-* @param {HTMLElement} iframe - source iframe
-* @param {Array} revertList - list to which altered iframes
will be added
-*/
- forwardEvents: function(doc, iframe, revertList) {
- try {
- var idoc = iframe.contentWindow.document;
- idoc.old_onmousemove = idoc.onmousemove;
- idoc.onmousemove = function(evt) {
- if (!evt) {
- evt =
iframe.contentWindow.event;
- }
- var e = {};
-
- var dx = 0;
- var dy = 0;
- if (Wicket.Browser.isIELessThan11() ||
Wicket.Browser.isGecko()) {
- dx = Wicket.Window.getScrollX();
- dy = Wicket.Window.getScrollY();
- }
-
- e.clientX = evt.clientX +
Wicket.Iframe.findPosX(iframe) - dx;
- e.clientY = evt.clientY +
Wicket.Iframe.findPosY(iframe) - dy;
-
[jira] [Resolved] (WICKET-5552) Events to close pop-up on Modal Window are not propagated
[ https://issues.apache.org/jira/browse/WICKET-5552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sven Meier resolved WICKET-5552. Resolution: Fixed Assignee: Sven Meier Fix Version/s: 8.2.0 events are allowed to bubble now > Events to close pop-up on Modal Window are not propagated > - > > Key: WICKET-5552 > URL: https://issues.apache.org/jira/browse/WICKET-5552 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 7.10.0 > Environment: Windows/Eclipse/JRE7 >Reporter: Neil Bennett >Assignee: Sven Meier >Priority: Minor > Labels: javascript, modalwindow > Fix For: 8.2.0 > > Attachments: quickstart.zip > > > When using a field on a modal window that shows a pop-up window, like a time > picker, when clicking outside of the pop-up window but over the modal window, > mousedown/click events are not propagated. Clicks outside of the modal window > are propagated. > This is due to Wicket.Event.stop(event) being called on mousedown on the > w_content_1 component. Removal of this leads to the Drag javascript being > executed which itself calls Wicket.Event.stop(event), disabling this then > propagates the event which leads to the pop-up window being closed but causes > any field on the modalwindow to get focus. > I have a quickstart that demonstrates the modalwindow behavior vs that on a > page. You will see that launching the modal window and clicking on the time > component opens the pop-up window. However, you can only get this to close > when clicking outside of the modal window. The same component has been put on > the main page as a comparison which does close when clicking outside of the > pop-up window. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[2/2] wicket git commit: WICKET-4423 allow dragging over iframe
WICKET-4423 allow dragging over iframe
with pointer-events=none
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/c51cf875
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/c51cf875
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/c51cf875
Branch: refs/heads/master
Commit: c51cf875f59ce0438a5f339aae71eb92fa915a1c
Parents: ace845c
Author: Sven Meier
Authored: Mon Oct 15 23:29:14 2018 +0200
Committer: Sven Meier
Committed: Mon Oct 15 23:31:17 2018 +0200
--
.../ajax/markup/html/modal/res/modal.js | 154 +--
1 file changed, 6 insertions(+), 148 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/c51cf875/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
--
diff --git
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
index 6bcebf2..8b66687 100644
---
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
+++
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
@@ -56,142 +56,6 @@
}
/**
-* Supporting code for getting mouse move and mouse up events from
iframes.
-* The problem when dragging a div with an iframe is that when the
mouse cursor
-* gets over an iframe, all mouse events are received by the iframe's
document. (IE and FF)
-*
-* This code can recursively traverse all iframes in document and
temporarily forward
-* events from their documents to parent document.
-*/
- Wicket.Iframe = {
-
- /**
-* Returns the horizontal position of given element (in pixels).
-*/
- findPosX: function(e) {
- if (e.offsetParent) {
- var c = 0;
- while (e) {
- c += e.offsetLeft;
- e = e.offsetParent;
- }
- return c;
- } else if (e.x) {
- return e.x;
- } else {
- return 0;
- }
- },
-
- /**
-* Returns the vertical position of given element (in pixels).
-*/
- findPosY: function(e) {
- if (e.offsetParent) {
- var c = 0;
- while (e) {
- c += e.offsetTop;
- e = e.offsetParent;
- }
- return c;
- } else if (e.y) {
- return e.y;
- } else {
- return 0;
- }
- },
-
- /**
-* Forwards the events from iframe to the parent document
(works recursively).
-* @param {Document} doc - document to which the events will be
forwarded
-* @param {HTMLElement} iframe - source iframe
-* @param {Array} revertList - list to which altered iframes
will be added
-*/
- forwardEvents: function(doc, iframe, revertList) {
- try {
- var idoc = iframe.contentWindow.document;
- idoc.old_onmousemove = idoc.onmousemove;
- idoc.onmousemove = function(evt) {
- if (!evt) {
- evt =
iframe.contentWindow.event;
- }
- var e = {};
-
- var dx = 0;
- var dy = 0;
- if (Wicket.Browser.isIELessThan11() ||
Wicket.Browser.isGecko()) {
- dx = Wicket.Window.getScrollX();
- dy = Wicket.Window.getScrollY();
- }
-
- e.clientX = evt.clientX +
Wicket.Iframe.findPosX(iframe) - dx;
- e.clientY = evt.clientY +
Wicket.Iframe.findPosY(iframe) - dy;
-
[1/2] wicket git commit: WICKET-5552 allow prevention of drags
Repository: wicket
Updated Branches:
refs/heads/master 6ee5313d4 -> c51cf875f
WICKET-5552 allow prevention of drags
used by ModalWindow to prevent dragging on window content
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/ace845c4
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/ace845c4
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/ace845c4
Branch: refs/heads/master
Commit: ace845c412d6ea3117c6f366d9bd91b06c6270da
Parents: 6ee5313
Author: Sven Meier
Authored: Mon Oct 15 23:15:06 2018 +0200
Committer: Sven Meier
Committed: Mon Oct 15 23:31:07 2018 +0200
--
.../wicket/ajax/res/js/wicket-ajax-jquery.js| 25 +---
.../ajax/markup/html/modal/res/modal.js | 11 +++--
2 files changed, 25 insertions(+), 11 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/ace845c4/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
b/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
index 5f64c0b..2f0561f 100644
---
a/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
+++
b/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
@@ -2279,13 +2279,18 @@
Drag: {
/**
-* Initializes the dragging on the specified element.
-* Element's onmousedown will be replaced by generated
handler.
-*
-* @param {Element} element - element clicking on which
the drag should begin
-* @param {Function} onDragBegin - handler called at
the begin on dragging - passed element as first parameter
-* @param {Function} onDragEnd - handler called at the
end of dragging - passed element as first parameter
-* @param {Function} onDrag - handler called during
dragging - passed element and mouse deltas
+* Initializes dragging on the specified element.
+*
+* @param element {Element}
+*element clicking on which
+*the drag should begin
+* @param onDragBegin {Function}
+*called at the begin of dragging - passed
element and event as parameters,
+*may return false to prevent the start
+* @param onDragEnd {Function}
+*handler called at the end of dragging -
passed element as parameter
+* @param onDrag {Function}
+*handler called during dragging - passed
element and mouse deltas as parameters
*/
init: function(element, onDragBegin, onDragEnd, onDrag)
{
@@ -2315,14 +2320,16 @@
var element = this;
+ if (element.wicketOnDragBegin(element, e) ===
false) {
+ return;
+ }
+
Wicket.Event.stop(e);
if (e.preventDefault) {
e.preventDefault();
}
- element.wicketOnDragBegin(element);
-
element.lastMouseX = e.clientX;
element.lastMouseY = e.clientY;
http://git-wip-us.apache.org/repos/asf/wicket/blob/ace845c4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
--
diff --git
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
index b00ceec..6bcebf2 100644
---
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
+++
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
@@ -901,11 +901,18 @@
/**
* Called when dragging has started.
*/
- onBegin: function(object) {
+ onBegin: function(element, event) {
+ // ignore anything inside the content
+ if (jQuery(event.target).closest('.w_content').size(
[jira] [Commented] (WICKET-5552) Events to close pop-up on Modal Window are not propagated
[ https://issues.apache.org/jira/browse/WICKET-5552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650837#comment-16650837 ] ASF subversion and git services commented on WICKET-5552: - Commit ace845c412d6ea3117c6f366d9bd91b06c6270da in wicket's branch refs/heads/master from [~svenmeier] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=ace845c ] WICKET-5552 allow prevention of drags used by ModalWindow to prevent dragging on window content > Events to close pop-up on Modal Window are not propagated > - > > Key: WICKET-5552 > URL: https://issues.apache.org/jira/browse/WICKET-5552 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 7.10.0 > Environment: Windows/Eclipse/JRE7 >Reporter: Neil Bennett >Assignee: Sven Meier >Priority: Minor > Labels: javascript, modalwindow > Fix For: 8.2.0 > > Attachments: quickstart.zip > > > When using a field on a modal window that shows a pop-up window, like a time > picker, when clicking outside of the pop-up window but over the modal window, > mousedown/click events are not propagated. Clicks outside of the modal window > are propagated. > This is due to Wicket.Event.stop(event) being called on mousedown on the > w_content_1 component. Removal of this leads to the Drag javascript being > executed which itself calls Wicket.Event.stop(event), disabling this then > propagates the event which leads to the pop-up window being closed but causes > any field on the modalwindow to get focus. > I have a quickstart that demonstrates the modalwindow behavior vs that on a > page. You will see that launching the modal window and clicking on the time > component opens the pop-up window. However, you can only get this to close > when clicking outside of the modal window. The same component has been put on > the main page as a comparison which does close when clicking outside of the > pop-up window. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-4423) Modal Window dragging failes with iframe
[ https://issues.apache.org/jira/browse/WICKET-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650838#comment-16650838 ] ASF subversion and git services commented on WICKET-4423: - Commit c51cf875f59ce0438a5f339aae71eb92fa915a1c in wicket's branch refs/heads/master from [~svenmeier] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=c51cf87 ] WICKET-4423 allow dragging over iframe with pointer-events=none > Modal Window dragging failes with iframe > > > Key: WICKET-4423 > URL: https://issues.apache.org/jira/browse/WICKET-4423 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 6.0.0-beta1 >Reporter: Sven Meier >Assignee: Sven Meier >Priority: Major > > Forwarding of mouse event from nested iframes seems to have stopped working. > (see javascript Wicket.Iframe) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (WICKET-4423) Modal Window dragging failes with iframe
[ https://issues.apache.org/jira/browse/WICKET-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sven Meier resolved WICKET-4423. Resolution: Fixed Fix Version/s: 8.2.0 New solution with pointer-events=none allows dragging over iframe. > Modal Window dragging failes with iframe > > > Key: WICKET-4423 > URL: https://issues.apache.org/jira/browse/WICKET-4423 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 6.0.0-beta1 >Reporter: Sven Meier >Assignee: Sven Meier >Priority: Major > Fix For: 8.2.0 > > > Forwarding of mouse event from nested iframes seems to have stopped working. > (see javascript Wicket.Iframe) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-5552) Events to close pop-up on Modal Window are not propagated
[ https://issues.apache.org/jira/browse/WICKET-5552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650852#comment-16650852 ] ASF GitHub Bot commented on WICKET-5552: Github user svenmeier commented on the issue: https://github.com/apache/wicket/pull/294 I've fixed WICKET-5552, please open a new pull request if you think ModalWindow is in need of further extensibility. > Events to close pop-up on Modal Window are not propagated > - > > Key: WICKET-5552 > URL: https://issues.apache.org/jira/browse/WICKET-5552 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 7.10.0 > Environment: Windows/Eclipse/JRE7 >Reporter: Neil Bennett >Assignee: Sven Meier >Priority: Minor > Labels: javascript, modalwindow > Fix For: 8.2.0 > > Attachments: quickstart.zip > > > When using a field on a modal window that shows a pop-up window, like a time > picker, when clicking outside of the pop-up window but over the modal window, > mousedown/click events are not propagated. Clicks outside of the modal window > are propagated. > This is due to Wicket.Event.stop(event) being called on mousedown on the > w_content_1 component. Removal of this leads to the Drag javascript being > executed which itself calls Wicket.Event.stop(event), disabling this then > propagates the event which leads to the pop-up window being closed but causes > any field on the modalwindow to get focus. > I have a quickstart that demonstrates the modalwindow behavior vs that on a > page. You will see that launching the modal window and clicking on the time > component opens the pop-up window. However, you can only get this to close > when clicking outside of the modal window. The same component has been put on > the main page as a comparison which does close when clicking outside of the > pop-up window. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6427) Fire an event once all ajax timers are registered
[ https://issues.apache.org/jira/browse/WICKET-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650853#comment-16650853 ] ASF GitHub Bot commented on WICKET-6427: Github user Jezza closed the pull request at: https://github.com/apache/wicket/pull/223 > Fire an event once all ajax timers are registered > - > > Key: WICKET-6427 > URL: https://issues.apache.org/jira/browse/WICKET-6427 > Project: Wicket > Issue Type: Improvement >Reporter: Jezza >Priority: Minor > > This is in the same vein as WICKET-5746. > I just need some way to execute code after the timers have been registered, > and it seemed weird to only have the event fired for one set of ajax related > calls. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6427) Fire an event once all ajax timers are registered
[ https://issues.apache.org/jira/browse/WICKET-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650856#comment-16650856 ] ASF GitHub Bot commented on WICKET-6427: Github user Jezza commented on the issue: https://github.com/apache/wicket/pull/223 I'm moving my branches around, so I guess github spotted that it's no longer on my master branch. I, personally, don't have any need of this ticket anymore, and honestly, there's a lot of work to do. I think I got, maybe, 25% of the way through the tests. I did have to change all of them, so I think unless someone wants it, I'll just let it lie. > Fire an event once all ajax timers are registered > - > > Key: WICKET-6427 > URL: https://issues.apache.org/jira/browse/WICKET-6427 > Project: Wicket > Issue Type: Improvement >Reporter: Jezza >Priority: Minor > > This is in the same vein as WICKET-5746. > I just need some way to execute code after the timers have been registered, > and it seemed weird to only have the event fired for one set of ajax related > calls. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6427) Fire an event once all ajax timers are registered
[ https://issues.apache.org/jira/browse/WICKET-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650864#comment-16650864 ] Jezza commented on WICKET-6427: --- I don't have the right to close this ticket. Can someone else? > Fire an event once all ajax timers are registered > - > > Key: WICKET-6427 > URL: https://issues.apache.org/jira/browse/WICKET-6427 > Project: Wicket > Issue Type: Improvement >Reporter: Jezza >Priority: Minor > > This is in the same vein as WICKET-5746. > I just need some way to execute code after the timers have been registered, > and it seemed weird to only have the event fired for one set of ajax related > calls. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
buildbot success in on wicket-branch-8.x
The Buildbot has detected a restored build on builder wicket-branch-8.x while building wicket. Full details are available at: https://ci.apache.org/builders/wicket-branch-8.x/builds/40 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: bb_slave1_ubuntu Build Reason: The SingleBranchScheduler scheduler named 'on-wicket-branch-8.x-commit' triggered this build Build Source Stamp: [branch wicket-8.x] c7be83b16f5ef016c8d981d4b5f74bf480097868 Blamelist: Sven Meier Build succeeded! Sincerely, -The Buildbot
[jira] [Commented] (WICKET-5552) Events to close pop-up on Modal Window are not propagated
[ https://issues.apache.org/jira/browse/WICKET-5552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650955#comment-16650955 ] ASF GitHub Bot commented on WICKET-5552: Github user andruhon commented on the issue: https://github.com/apache/wicket/pull/294 Thanks for ace845c412d6ea3117c6f366d9bd91b06c6270da. I'll create another one with extensibility improvements soon. > Events to close pop-up on Modal Window are not propagated > - > > Key: WICKET-5552 > URL: https://issues.apache.org/jira/browse/WICKET-5552 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 7.10.0 > Environment: Windows/Eclipse/JRE7 >Reporter: Neil Bennett >Assignee: Sven Meier >Priority: Minor > Labels: javascript, modalwindow > Fix For: 8.2.0 > > Attachments: quickstart.zip > > > When using a field on a modal window that shows a pop-up window, like a time > picker, when clicking outside of the pop-up window but over the modal window, > mousedown/click events are not propagated. Clicks outside of the modal window > are propagated. > This is due to Wicket.Event.stop(event) being called on mousedown on the > w_content_1 component. Removal of this leads to the Drag javascript being > executed which itself calls Wicket.Event.stop(event), disabling this then > propagates the event which leads to the pop-up window being closed but causes > any field on the modalwindow to get focus. > I have a quickstart that demonstrates the modalwindow behavior vs that on a > page. You will see that launching the modal window and clicking on the time > component opens the pop-up window. However, you can only get this to close > when clicking outside of the modal window. The same component has been put on > the main page as a comparison which does close when clicking outside of the > pop-up window. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-5552) Events to close pop-up on Modal Window are not propagated
[ https://issues.apache.org/jira/browse/WICKET-5552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650956#comment-16650956 ] ASF GitHub Bot commented on WICKET-5552: Github user andruhon closed the pull request at: https://github.com/apache/wicket/pull/294 > Events to close pop-up on Modal Window are not propagated > - > > Key: WICKET-5552 > URL: https://issues.apache.org/jira/browse/WICKET-5552 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 7.10.0 > Environment: Windows/Eclipse/JRE7 >Reporter: Neil Bennett >Assignee: Sven Meier >Priority: Minor > Labels: javascript, modalwindow > Fix For: 8.2.0 > > Attachments: quickstart.zip > > > When using a field on a modal window that shows a pop-up window, like a time > picker, when clicking outside of the pop-up window but over the modal window, > mousedown/click events are not propagated. Clicks outside of the modal window > are propagated. > This is due to Wicket.Event.stop(event) being called on mousedown on the > w_content_1 component. Removal of this leads to the Drag javascript being > executed which itself calls Wicket.Event.stop(event), disabling this then > propagates the event which leads to the pop-up window being closed but causes > any field on the modalwindow to get focus. > I have a quickstart that demonstrates the modalwindow behavior vs that on a > page. You will see that launching the modal window and clicking on the time > component opens the pop-up window. However, you can only get this to close > when clicking outside of the modal window. The same component has been put on > the main page as a comparison which does close when clicking outside of the > pop-up window. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (WICKET-6427) Fire an event once all ajax timers are registered
[ https://issues.apache.org/jira/browse/WICKET-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sven Meier resolved WICKET-6427. Resolution: Not A Problem No longer needed. > Fire an event once all ajax timers are registered > - > > Key: WICKET-6427 > URL: https://issues.apache.org/jira/browse/WICKET-6427 > Project: Wicket > Issue Type: Improvement >Reporter: Jezza >Priority: Minor > > This is in the same vein as WICKET-5746. > I just need some way to execute code after the timers have been registered, > and it seemed weird to only have the event fired for one set of ajax related > calls. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
