[jira] [Commented] (WICKET-6617) Header contribution ignore
[
https://issues.apache.org/jira/browse/WICKET-6617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713571#comment-16713571
]
ASF GitHub Bot commented on WICKET-6617:
Github user svenmeier commented on the issue:
https://github.com/apache/wicket/pull/343
We should leave 7.x for people with support for older browsers. Let them
migrate to 8.x if they need newer features.
> Header contribution ignore
> -
>
> Key: WICKET-6617
> URL: https://issues.apache.org/jira/browse/WICKET-6617
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
>Affects Versions: 8.2.0
>Reporter: Maxim Solodovnik
>Assignee: Maxim Solodovnik
>Priority: Major
> Fix For: 8.3.0, 9.0.0
>
>
> Components added via AJAX and contributing to {{}} using {{@Override
> renderHead}} ignores {{}} if any
> Here is the example:
> Imaging you have following markup:
> {code}
>
>
>
> Hello
>
>
>
>
>
> {code}
> In your java code you replacing component A with component B on the page via
> AJAX
> Component B contributing to {{}} as follows:
> {code}
> @Override
> public void renderHead(IHeaderResponse response) {
> super.renderHead(response);
> response.render(JavaScriptHeaderItem.forReference(new
> JavaScriptResourceReference(B.class, "some.js")));
> }
> {code}
> As developer I would expect additional JS/CSS files (or any other header
> resources) will be appended before {{}} tag since I have placed
> {{}} tag
> Currently only initial header resources will take {{}}
> into account
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (WICKET-6620) @Deprecated classes/methods need to be removed
[ https://issues.apache.org/jira/browse/WICKET-6620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik resolved WICKET-6620. -- Resolution: Fixed > @Deprecated classes/methods need to be removed > -- > > Key: WICKET-6620 > URL: https://issues.apache.org/jira/browse/WICKET-6620 > Project: Wicket > Issue Type: Task > Components: wicket >Affects Versions: 9.0.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 9.0.0 > > > @Deprecated classes/methods need to be removed > 1) Drop all `@Deprecated(since = "8.0", forRemoval = true)` from master > 2) Drop all marked as @Deprecated in wicket7 from master -- This message was sent by Atlassian JIRA (v7.6.3#76005)
buildbot success in on wicket-branch-8.x
The Buildbot has detected a restored build on builder wicket-branch-8.x while building wicket. Full details are available at: https://ci.apache.org/builders/wicket-branch-8.x/builds/74 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: bb_slave1_ubuntu Build Reason: The SingleBranchScheduler scheduler named 'on-wicket-branch-8.x-commit' triggered this build Build Source Stamp: [branch wicket-8.x] 23c46412d175c914ec6c09910cfc4af83bd75cde Blamelist: Maxim Solodovnik Build succeeded! Sincerely, -The Buildbot
[jira] [Resolved] (WICKET-6617) Header contribution ignore
[
https://issues.apache.org/jira/browse/WICKET-6617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Solodovnik resolved WICKET-6617.
--
Resolution: Fixed
Fix Version/s: 9.0.0
8.3.0
> Header contribution ignore
> -
>
> Key: WICKET-6617
> URL: https://issues.apache.org/jira/browse/WICKET-6617
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
>Affects Versions: 8.2.0
>Reporter: Maxim Solodovnik
>Assignee: Maxim Solodovnik
>Priority: Major
> Fix For: 8.3.0, 9.0.0
>
>
> Components added via AJAX and contributing to {{}} using {{@Override
> renderHead}} ignores {{}} if any
> Here is the example:
> Imaging you have following markup:
> {code}
>
>
>
> Hello
>
>
>
>
>
> {code}
> In your java code you replacing component A with component B on the page via
> AJAX
> Component B contributing to {{}} as follows:
> {code}
> @Override
> public void renderHead(IHeaderResponse response) {
> super.renderHead(response);
> response.render(JavaScriptHeaderItem.forReference(new
> JavaScriptResourceReference(B.class, "some.js")));
> }
> {code}
> As developer I would expect additional JS/CSS files (or any other header
> resources) will be appended before {{}} tag since I have placed
> {{}} tag
> Currently only initial header resources will take {{}}
> into account
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WICKET-6620) @Deprecated classes/methods need to be removed
[ https://issues.apache.org/jira/browse/WICKET-6620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713546#comment-16713546 ] ASF GitHub Bot commented on WICKET-6620: Github user asfgit closed the pull request at: https://github.com/apache/wicket/pull/344 > @Deprecated classes/methods need to be removed > -- > > Key: WICKET-6620 > URL: https://issues.apache.org/jira/browse/WICKET-6620 > Project: Wicket > Issue Type: Task > Components: wicket >Affects Versions: 9.0.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 9.0.0 > > > @Deprecated classes/methods need to be removed > 1) Drop all `@Deprecated(since = "8.0", forRemoval = true)` from master > 2) Drop all marked as @Deprecated in wicket7 from master -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[wicket] Git Push Summary
Repository: wicket Updated Branches: refs/heads/WICKET-6620-remove-deprecated [deleted] 4b09e371b
[jira] [Commented] (WICKET-6620) @Deprecated classes/methods need to be removed
[ https://issues.apache.org/jira/browse/WICKET-6620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713543#comment-16713543 ] ASF subversion and git services commented on WICKET-6620: - Commit 4b09e371b0a59ff2d093d1236afbf66ee7874402 in wicket's branch refs/heads/master from [~solomax] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=4b09e37 ] [WICKET-6620] deprecated classes/methods are removed > @Deprecated classes/methods need to be removed > -- > > Key: WICKET-6620 > URL: https://issues.apache.org/jira/browse/WICKET-6620 > Project: Wicket > Issue Type: Task > Components: wicket >Affects Versions: 9.0.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 9.0.0 > > > @Deprecated classes/methods need to be removed > 1) Drop all `@Deprecated(since = "8.0", forRemoval = true)` from master > 2) Drop all marked as @Deprecated in wicket7 from master -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[3/3] wicket git commit: Merge remote-tracking branch 'origin/WICKET-6620-remove-deprecated'
Merge remote-tracking branch 'origin/WICKET-6620-remove-deprecated' Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/4ebdafb6 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/4ebdafb6 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/4ebdafb6 Branch: refs/heads/master Commit: 4ebdafb600740442fcdc96ee41041169b77ed57f Parents: 7befe9b 4b09e37 Author: Maxim Solodovnik Authored: Sat Dec 8 12:16:38 2018 +0700 Committer: Maxim Solodovnik Committed: Sat Dec 8 12:16:38 2018 +0700 -- .../core/request/handler/IPageProvider.java |7 - .../core/request/handler/PageProvider.java | 11 - .../mapper/AbstractBookmarkableMapper.java |2 +- .../wicket/core/util/lang/WicketObjects.java| 149 +-- .../org/apache/wicket/markup/WicketTag.java | 13 - .../apache/wicket/markup/html/form/Form.java|8 - .../wicket/markup/html/form/FormComponent.java | 17 - .../markup/resolver/HtmlHeaderResolver.java | 17 +- .../migrate/StringResourceModelMigration.java | 175 --- .../http/mock/MockHttpServletRequest.java | 44 - .../http/mock/MockHttpServletResponse.java | 44 - .../request/handler/render/WebPageRenderer.java |2 +- .../resource/JQueryResourceReference.java |9 - .../wicket/util/tester/BaseWicketTester.java| 35 +- .../apache/wicket/util/tester/TagTester.java| 40 +- .../apache/wicket/util/tester/WicketTester.java | 19 - .../core/request/mapper/MountedMapperTest.java | 20 +- .../markup/html/image/ResponsiveImageTest.java |8 +- .../wicket/markup/html/media/MediaTagsTest.java | 13 +- .../request/handler/PageProviderTest.java |3 +- .../handler/render/WebPageRendererTest.java |6 +- .../wicket/util/lang/WicketObjectsTest.java | 17 +- .../examples/guestbook/GuestbookTest.java |4 +- .../ajax/markup/html/AjaxLazyLoadPanel.java | 34 - .../data/sort/AjaxFallbackOrderByLink.java | 52 - .../wizard/IDefaultButtonProvider.java | 47 - .../wicket/extensions/wizard/WizardButton.java | 17 - .../wicket/request/RequestHandlerExecutor.java | 29 - .../apache/wicket/util/IContextProvider.java| 47 - .../java/org/apache/wicket/util/IProvider.java | 36 - .../wicket/util/collections/ArrayListStack.java | 141 --- .../org/apache/wicket/util/crypt/Base64.java| 1108 -- .../apache/wicket/util/crypt/Base64Test.java| 275 - 33 files changed, 36 insertions(+), 2413 deletions(-) --
[jira] [Commented] (WICKET-6620) @Deprecated classes/methods need to be removed
[ https://issues.apache.org/jira/browse/WICKET-6620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713544#comment-16713544 ] ASF subversion and git services commented on WICKET-6620: - Commit 4ebdafb600740442fcdc96ee41041169b77ed57f in wicket's branch refs/heads/master from [~solomax] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=4ebdafb ] Merge remote-tracking branch 'origin/WICKET-6620-remove-deprecated' > @Deprecated classes/methods need to be removed > -- > > Key: WICKET-6620 > URL: https://issues.apache.org/jira/browse/WICKET-6620 > Project: Wicket > Issue Type: Task > Components: wicket >Affects Versions: 9.0.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 9.0.0 > > > @Deprecated classes/methods need to be removed > 1) Drop all `@Deprecated(since = "8.0", forRemoval = true)` from master > 2) Drop all marked as @Deprecated in wicket7 from master -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[1/3] wicket git commit: [WICKET-6620] deprecated classes/methods are removed
Repository: wicket
Updated Branches:
refs/heads/master 7befe9b3b -> 4ebdafb60
http://git-wip-us.apache.org/repos/asf/wicket/blob/4b09e371/wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java
--
diff --git a/wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java
b/wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java
deleted file mode 100644
index 358db37..000
--- a/wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java
+++ /dev/null
@@ -1,1108 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.wicket.util.crypt;
-
-import java.math.BigInteger;
-
-/**
- * Provides Base64 encoding and decoding with URL and filename safe alphabet
as defined by RFC 3548,
- * section 4.
- *
- * This Base64 encoder is modified to meet URL requirements. The changes are:
'+' = '*', '/' =
- * '-', and no padding.
- *
- *
- * This class is taken from the Apache commons-codec, and adjusted to fit the
Wicket framework's
- * needs, especially external dependencies have been removed.
- *
- *
- * This class implements section 4. Base 64 Encoding with URL and
Filename Safe
- * Alphabet from RFC 3548 The Base16, Base32, and Base64 Data
Encodings by Simon
- * Josefsson.
- *
- *
- * @author Apache Software Foundation
- * @author Juergen Donnerstag
- *
- * @since 1.2
- * @deprecated Use {@link java.util.Base64} instead.
- */
-@Deprecated
-public class Base64
-{
- private static final int DEFAULT_BUFFER_RESIZE_FACTOR = 2;
-
- private static final int DEFAULT_BUFFER_SIZE = 8192;
-
- /**
-* Chunk size per RFC 2045 section 6.8.
-*
-*
-* The {@value} character limit does not count the trailing CRLF, but
counts all other
-* characters, including any equal signs.
-*
-*
-* @see http://www.ietf.org/rfc/rfc2045.txt;>RFC 2045 section
6.8
-*/
- static final int CHUNK_SIZE = 76;
-
- /**
-* Chunk separator per RFC 2045 section 2.1.
-*
-*
-* N.B. The next major release may break compatibility and make this
field private.
-*
-*
-* @see http://www.ietf.org/rfc/rfc2045.txt;>RFC 2045 section
2.1
-*/
- static final byte[] CHUNK_SEPARATOR = { '\r', '\n' };
-
- /**
-* This array is a lookup table that translates 6-bit positive integer
index values into their
-* "Base64 Alphabet" equivalents as specified in Table 1 of RFC 2045.
-*
-* Thanks to "commons" project in ws.apache.org for this code.
-*
http://svn.apache.org/repos/asf/webservices/commons/trunk/modules/util/
-*/
- private static final byte[] STANDARD_ENCODE_TABLE = { 'A', 'B', 'C',
'D', 'E', 'F', 'G', 'H',
- 'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S',
'T', 'U', 'V', 'W', 'X', 'Y',
- 'Z', 'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j',
'k', 'l', 'm', 'n', 'o', 'p',
- 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z', '0',
'1', '2', '3', '4', '5', '6',
- '7', '8', '9', '+', '/' };
-
- /**
-* This is a copy of the STANDARD_ENCODE_TABLE above, but with + and /
changed to - and _ to
-* make the encoded Base64 results more URL-SAFE. This table is only
used when the Base64's mode
-* is set to URL-SAFE.
-*/
- private static final byte[] URL_SAFE_ENCODE_TABLE = { 'A', 'B', 'C',
'D', 'E', 'F', 'G', 'H',
- 'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S',
'T', 'U', 'V', 'W', 'X', 'Y',
- 'Z', 'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j',
'k', 'l', 'm', 'n', 'o', 'p',
- 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z', '0',
'1', '2', '3', '4', '5', '6',
- '7', '8', '9', '-', '_' };
-
- /**
-* Byte used to pad output.
-*/
- private static final byte PAD = '=';
-
- /**
-* This array is a lookup table that translates Unicode characters
drawn from the
-* "Base64
[2/3] wicket git commit: [WICKET-6620] deprecated classes/methods are removed
[WICKET-6620] deprecated classes/methods are removed
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/4b09e371
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/4b09e371
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/4b09e371
Branch: refs/heads/master
Commit: 4b09e371b0a59ff2d093d1236afbf66ee7874402
Parents: 52a101f
Author: Maxim Solodovnik
Authored: Fri Dec 7 16:52:19 2018 +0700
Committer: Maxim Solodovnik
Committed: Fri Dec 7 16:52:19 2018 +0700
--
.../core/request/handler/IPageProvider.java |7 -
.../core/request/handler/PageProvider.java | 11 -
.../mapper/AbstractBookmarkableMapper.java |2 +-
.../wicket/core/util/lang/WicketObjects.java| 149 +--
.../org/apache/wicket/markup/WicketTag.java | 13 -
.../apache/wicket/markup/html/form/Form.java|8 -
.../wicket/markup/html/form/FormComponent.java | 17 -
.../markup/resolver/HtmlHeaderResolver.java | 17 +-
.../migrate/StringResourceModelMigration.java | 175 ---
.../http/mock/MockHttpServletRequest.java | 44 -
.../http/mock/MockHttpServletResponse.java | 44 -
.../request/handler/render/WebPageRenderer.java |2 +-
.../resource/JQueryResourceReference.java |9 -
.../wicket/util/tester/BaseWicketTester.java| 35 +-
.../apache/wicket/util/tester/TagTester.java| 40 +-
.../apache/wicket/util/tester/WicketTester.java | 19 -
.../core/request/mapper/MountedMapperTest.java | 20 +-
.../markup/html/image/ResponsiveImageTest.java |8 +-
.../wicket/markup/html/media/MediaTagsTest.java | 13 +-
.../request/handler/PageProviderTest.java |3 +-
.../handler/render/WebPageRendererTest.java |6 +-
.../wicket/util/lang/WicketObjectsTest.java | 17 +-
.../examples/guestbook/GuestbookTest.java |4 +-
.../ajax/markup/html/AjaxLazyLoadPanel.java | 34 -
.../data/sort/AjaxFallbackOrderByLink.java | 52 -
.../wizard/IDefaultButtonProvider.java | 47 -
.../wicket/extensions/wizard/WizardButton.java | 17 -
.../wicket/request/RequestHandlerExecutor.java | 29 -
.../apache/wicket/util/IContextProvider.java| 47 -
.../java/org/apache/wicket/util/IProvider.java | 36 -
.../wicket/util/collections/ArrayListStack.java | 141 ---
.../org/apache/wicket/util/crypt/Base64.java| 1108 --
.../apache/wicket/util/crypt/Base64Test.java| 275 -
33 files changed, 36 insertions(+), 2413 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/4b09e371/wicket-core/src/main/java/org/apache/wicket/core/request/handler/IPageProvider.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/core/request/handler/IPageProvider.java
b/wicket-core/src/main/java/org/apache/wicket/core/request/handler/IPageProvider.java
index 28ccb3a..47d7239 100644
---
a/wicket-core/src/main/java/org/apache/wicket/core/request/handler/IPageProvider.java
+++
b/wicket-core/src/main/java/org/apache/wicket/core/request/handler/IPageProvider.java
@@ -52,13 +52,6 @@ public interface IPageProvider
PageParameters getPageParameters() throws PageExpiredException;
/**
-* @return negates {@link PageProvider#hasPageInstance()}
-* @deprecated use {@link PageProvider#hasPageInstance()} negation
instead
-*/
- @Deprecated(since = "8.0", forRemoval = true)
- boolean isNewPageInstance();
-
- /**
* Returns whether the provided page was expired prior to this access.
*
* @return true> if the page was created after its
original instance expired.
http://git-wip-us.apache.org/repos/asf/wicket/blob/4b09e371/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageProvider.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageProvider.java
b/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageProvider.java
index bb94682..c08f0ad 100644
---
a/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageProvider.java
+++
b/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageProvider.java
@@ -196,17 +196,6 @@ public class PageProvider implements IPageProvider,
IClusterable
}
/**
-* @return negates {@link PageProvider#hasPageInstance()}
-* @deprecated use {@link PageProvider#hasPageInstance()} negation
instead
-*/
- @Deprecated(since = "8.0", forRemoval = true)
- @Override
- public boolean isNewPageInstance()
- {
- return !hasPageInstance();
- }
-
- /**
* If this provider
[wicket] Git Push Summary
Repository: wicket Updated Branches: refs/heads/WICKET-6617-header-placeholder [deleted] b83281403
[jira] [Commented] (WICKET-6617) Header contribution ignore
[
https://issues.apache.org/jira/browse/WICKET-6617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713542#comment-16713542
]
ASF GitHub Bot commented on WICKET-6617:
Github user solomax closed the pull request at:
https://github.com/apache/wicket/pull/343
> Header contribution ignore
> -
>
> Key: WICKET-6617
> URL: https://issues.apache.org/jira/browse/WICKET-6617
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
>Affects Versions: 8.2.0
>Reporter: Maxim Solodovnik
>Assignee: Maxim Solodovnik
>Priority: Major
>
> Components added via AJAX and contributing to {{}} using {{@Override
> renderHead}} ignores {{}} if any
> Here is the example:
> Imaging you have following markup:
> {code}
>
>
>
> Hello
>
>
>
>
>
> {code}
> In your java code you replacing component A with component B on the page via
> AJAX
> Component B contributing to {{}} as follows:
> {code}
> @Override
> public void renderHead(IHeaderResponse response) {
> super.renderHead(response);
> response.render(JavaScriptHeaderItem.forReference(new
> JavaScriptResourceReference(B.class, "some.js")));
> }
> {code}
> As developer I would expect additional JS/CSS files (or any other header
> resources) will be appended before {{}} tag since I have placed
> {{}} tag
> Currently only initial header resources will take {{}}
> into account
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WICKET-6617) Header contribution ignore
[
https://issues.apache.org/jira/browse/WICKET-6617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713541#comment-16713541
]
ASF subversion and git services commented on WICKET-6617:
-
Commit 7befe9b3b4df36913e332cb7e045c1252e8b0baf in wicket's branch
refs/heads/master from [~solomax]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=7befe9b ]
[WICKET-6617] headers are added to header-items if specified
> Header contribution ignore
> -
>
> Key: WICKET-6617
> URL: https://issues.apache.org/jira/browse/WICKET-6617
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
>Affects Versions: 8.2.0
>Reporter: Maxim Solodovnik
>Assignee: Maxim Solodovnik
>Priority: Major
>
> Components added via AJAX and contributing to {{}} using {{@Override
> renderHead}} ignores {{}} if any
> Here is the example:
> Imaging you have following markup:
> {code}
>
>
>
> Hello
>
>
>
>
>
> {code}
> In your java code you replacing component A with component B on the page via
> AJAX
> Component B contributing to {{}} as follows:
> {code}
> @Override
> public void renderHead(IHeaderResponse response) {
> super.renderHead(response);
> response.render(JavaScriptHeaderItem.forReference(new
> JavaScriptResourceReference(B.class, "some.js")));
> }
> {code}
> As developer I would expect additional JS/CSS files (or any other header
> resources) will be appended before {{}} tag since I have placed
> {{}} tag
> Currently only initial header resources will take {{}}
> into account
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
wicket git commit: [WICKET-6617] headers are added to header-items if specified
Repository: wicket
Updated Branches:
refs/heads/master babcb99ef -> 7befe9b3b
[WICKET-6617] headers are added to header-items if specified
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/7befe9b3
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/7befe9b3
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/7befe9b3
Branch: refs/heads/master
Commit: 7befe9b3b4df36913e332cb7e045c1252e8b0baf
Parents: babcb99
Author: Maxim Solodovnik
Authored: Sat Dec 8 11:48:12 2018 +0700
Committer: Maxim Solodovnik
Committed: Sat Dec 8 11:49:17 2018 +0700
--
.../wicket/ajax/res/js/wicket-ajax-jquery.js| 11 +++--
.../html/internal/HtmlHeaderContainer.java | 46 ++--
.../html/internal/HtmlHeaderItemsContainer.java | 9
3 files changed, 40 insertions(+), 26 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/7befe9b3/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
b/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
index 267d897..9ad893b 100644
---
a/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
+++
b/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
@@ -2138,10 +2138,15 @@
// Adds the element to page head
addElement: function (element) {
- var head =
document.getElementsByTagName("head");
+ var headItems = document.querySelector('head
meta[name="wicket.header.items"]');
+ if (headItems) {
+
headItems.parentNode.insertBefore(element, headItems);
+ } else {
+ var head =
document.querySelector("head");
- if (head[0]) {
- head[0].appendChild(element);
+ if (head) {
+ head.appendChild(element);
+ }
}
},
http://git-wip-us.apache.org/repos/asf/wicket/blob/7befe9b3/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/HtmlHeaderContainer.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/HtmlHeaderContainer.java
b/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/HtmlHeaderContainer.java
index e906560..ebe0de3 100644
---
a/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/HtmlHeaderContainer.java
+++
b/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/HtmlHeaderContainer.java
@@ -66,7 +66,7 @@ import org.apache.wicket.response.StringResponse;
* wicket:head and it's content is copied to the output.
Components contained in
* wicket:head are rendered as usual
*
- *
+ *
* @author Juergen Donnerstag
*/
public class HtmlHeaderContainer extends TransparentWebMarkupContainer
@@ -89,7 +89,7 @@ public class HtmlHeaderContainer extends
TransparentWebMarkupContainer
/**
* Combines the {@link MarkupStream} with the open tag, together
representing the header section
* in the markup.
-*
+*
* @author papegaaij
*/
public static class HeaderStreamState
@@ -122,7 +122,7 @@ public class HtmlHeaderContainer extends
TransparentWebMarkupContainer
/**
* Construct
-*
+*
* @see Component#Component(String)
*/
public HtmlHeaderContainer(final String id)
@@ -161,19 +161,19 @@ public class HtmlHeaderContainer extends
TransparentWebMarkupContainer
final StringResponse response = new StringResponse();
getRequestCycle().setResponse(response);
- IHeaderResponse headerResponse = getHeaderResponse();
- if (!response.equals(headerResponse.getResponse()))
- {
-
getRequestCycle().setResponse(headerResponse.getResponse());
- }
+ try (IHeaderResponse headerResponse =
getHeaderResponse()) {
+ if
(!response.equals(headerResponse.getResponse()))
+ {
+
getRequestCycle().setResponse(headerResponse.getResponse());
+
[jira] [Commented] (WICKET-6617) Header contribution ignore
[
https://issues.apache.org/jira/browse/WICKET-6617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713524#comment-16713524
]
ASF GitHub Bot commented on WICKET-6617:
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/343
@svenmeier Should this be merged into 7.x?
> Header contribution ignore
> -
>
> Key: WICKET-6617
> URL: https://issues.apache.org/jira/browse/WICKET-6617
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
>Affects Versions: 8.2.0
>Reporter: Maxim Solodovnik
>Assignee: Maxim Solodovnik
>Priority: Major
>
> Components added via AJAX and contributing to {{}} using {{@Override
> renderHead}} ignores {{}} if any
> Here is the example:
> Imaging you have following markup:
> {code}
>
>
>
> Hello
>
>
>
>
>
> {code}
> In your java code you replacing component A with component B on the page via
> AJAX
> Component B contributing to {{}} as follows:
> {code}
> @Override
> public void renderHead(IHeaderResponse response) {
> super.renderHead(response);
> response.render(JavaScriptHeaderItem.forReference(new
> JavaScriptResourceReference(B.class, "some.js")));
> }
> {code}
> As developer I would expect additional JS/CSS files (or any other header
> resources) will be appended before {{}} tag since I have placed
> {{}} tag
> Currently only initial header resources will take {{}}
> into account
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
wicket git commit: [WICKET-6617] headers are added to header-items if specified
Repository: wicket
Updated Branches:
refs/heads/wicket-8.x 4f9b029fa -> 23c46412d
[WICKET-6617] headers are added to header-items if specified
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/23c46412
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/23c46412
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/23c46412
Branch: refs/heads/wicket-8.x
Commit: 23c46412d175c914ec6c09910cfc4af83bd75cde
Parents: 4f9b029
Author: Maxim Solodovnik
Authored: Sat Dec 8 11:48:12 2018 +0700
Committer: Maxim Solodovnik
Committed: Sat Dec 8 11:48:12 2018 +0700
--
.../wicket/ajax/res/js/wicket-ajax-jquery.js| 11 +++--
.../html/internal/HtmlHeaderContainer.java | 46 ++--
.../html/internal/HtmlHeaderItemsContainer.java | 9
3 files changed, 40 insertions(+), 26 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/23c46412/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
b/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
index 8370208..b93a98b 100644
---
a/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
+++
b/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
@@ -2116,10 +2116,15 @@
// Adds the element to page head
addElement: function (element) {
- var head =
document.getElementsByTagName("head");
+ var headItems = document.querySelector('head
meta[name="wicket.header.items"]');
+ if (headItems) {
+
headItems.parentNode.insertBefore(element, headItems);
+ } else {
+ var head =
document.querySelector("head");
- if (head[0]) {
- head[0].appendChild(element);
+ if (head) {
+ head.appendChild(element);
+ }
}
},
http://git-wip-us.apache.org/repos/asf/wicket/blob/23c46412/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/HtmlHeaderContainer.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/HtmlHeaderContainer.java
b/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/HtmlHeaderContainer.java
index e906560..ebe0de3 100644
---
a/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/HtmlHeaderContainer.java
+++
b/wicket-core/src/main/java/org/apache/wicket/markup/html/internal/HtmlHeaderContainer.java
@@ -66,7 +66,7 @@ import org.apache.wicket.response.StringResponse;
* wicket:head and it's content is copied to the output.
Components contained in
* wicket:head are rendered as usual
*
- *
+ *
* @author Juergen Donnerstag
*/
public class HtmlHeaderContainer extends TransparentWebMarkupContainer
@@ -89,7 +89,7 @@ public class HtmlHeaderContainer extends
TransparentWebMarkupContainer
/**
* Combines the {@link MarkupStream} with the open tag, together
representing the header section
* in the markup.
-*
+*
* @author papegaaij
*/
public static class HeaderStreamState
@@ -122,7 +122,7 @@ public class HtmlHeaderContainer extends
TransparentWebMarkupContainer
/**
* Construct
-*
+*
* @see Component#Component(String)
*/
public HtmlHeaderContainer(final String id)
@@ -161,19 +161,19 @@ public class HtmlHeaderContainer extends
TransparentWebMarkupContainer
final StringResponse response = new StringResponse();
getRequestCycle().setResponse(response);
- IHeaderResponse headerResponse = getHeaderResponse();
- if (!response.equals(headerResponse.getResponse()))
- {
-
getRequestCycle().setResponse(headerResponse.getResponse());
- }
+ try (IHeaderResponse headerResponse =
getHeaderResponse()) {
+ if
(!response.equals(headerResponse.getResponse()))
+ {
+
getRequestCycle().setResponse(headerResponse.getResponse());
+
[jira] [Commented] (WICKET-6617) Header contribution ignore
[
https://issues.apache.org/jira/browse/WICKET-6617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713526#comment-16713526
]
ASF subversion and git services commented on WICKET-6617:
-
Commit 23c46412d175c914ec6c09910cfc4af83bd75cde in wicket's branch
refs/heads/wicket-8.x from [~solomax]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=23c4641 ]
[WICKET-6617] headers are added to header-items if specified
> Header contribution ignore
> -
>
> Key: WICKET-6617
> URL: https://issues.apache.org/jira/browse/WICKET-6617
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
>Affects Versions: 8.2.0
>Reporter: Maxim Solodovnik
>Assignee: Maxim Solodovnik
>Priority: Major
>
> Components added via AJAX and contributing to {{}} using {{@Override
> renderHead}} ignores {{}} if any
> Here is the example:
> Imaging you have following markup:
> {code}
>
>
>
> Hello
>
>
>
>
>
> {code}
> In your java code you replacing component A with component B on the page via
> AJAX
> Component B contributing to {{}} as follows:
> {code}
> @Override
> public void renderHead(IHeaderResponse response) {
> super.renderHead(response);
> response.render(JavaScriptHeaderItem.forReference(new
> JavaScriptResourceReference(B.class, "some.js")));
> }
> {code}
> As developer I would expect additional JS/CSS files (or any other header
> resources) will be appended before {{}} tag since I have placed
> {{}} tag
> Currently only initial header resources will take {{}}
> into account
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
buildbot success in on wicket-master
The Buildbot has detected a restored build on builder wicket-master while building wicket. Full details are available at: https://ci.apache.org/builders/wicket-master/builds/1040 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: bb_slave1_ubuntu Build Reason: The SingleBranchScheduler scheduler named 'on-wicket-master-commit' triggered this build Build Source Stamp: [branch master] babcb99ef040c0d1160d8d0cbb22b323c868e0ed Blamelist: Sven Meier Build succeeded! Sincerely, -The Buildbot
buildbot failure in on wicket-branch-8.x
The Buildbot has detected a new failure on builder wicket-branch-8.x while building wicket. Full details are available at: https://ci.apache.org/builders/wicket-branch-8.x/builds/73 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: bb_slave1_ubuntu Build Reason: The SingleBranchScheduler scheduler named 'on-wicket-branch-8.x-commit' triggered this build Build Source Stamp: [branch wicket-8.x] 4f9b029fa32a9da0fa9aebc710443a202a435299 Blamelist: Sven Meier BUILD FAILED: failed compile Sincerely, -The Buildbot
[jira] [Updated] (WICKET-6563) Rework page and data storage
[ https://issues.apache.org/jira/browse/WICKET-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sven Meier updated WICKET-6563: --- Fix Version/s: 9.0.0 > Rework page and data storage > > > Key: WICKET-6563 > URL: https://issues.apache.org/jira/browse/WICKET-6563 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 9.0.0 >Reporter: Sven Meier >Assignee: Sven Meier >Priority: Minor > Fix For: 9.0.0 > > > IPageManager, IPageStore and IDataStore are riddled with complicated and > error-prone code aiming to do one simple thing: keeping pages around. > There are multiple problems with the current implementation: > * PageStoreManger does too much > ** it handles request and session storage > ** it contains workarounds for DiskDataStore, when the sessionId changes > * IPageStore/AbstractPageStore > ** has no access to IPageManagerContext > ** juggles with byte[], serialization and conversion > * IDataStore introduces an unncecessary third layer into the API > Additional or specialized stores are difficult to implement. > We should rework that. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6569) LambdaModel.of overload is ambiguous
[
https://issues.apache.org/jira/browse/WICKET-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713046#comment-16713046
]
ASF subversion and git services commented on WICKET-6569:
-
Commit babcb99ef040c0d1160d8d0cbb22b323c868e0ed in wicket's branch
refs/heads/master from [~svenmeier]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=babcb99 ]
WICKET-6569 remove ambiguous method
deprecated in 8.x
> LambdaModel.of overload is ambiguous
>
>
> Key: WICKET-6569
> URL: https://issues.apache.org/jira/browse/WICKET-6569
> Project: Wicket
> Issue Type: Wish
> Components: wicket
>Affects Versions: 8.0.0
>Reporter: Michael Gerhards
>Priority: Minor
> Attachments: myproject.zip
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> a method call of
> LambdaModel.of(this::getModelObject, this::setModelObject)
> refers to
> public static IModel of(IModel target, SerializableFunction R> getter)
> but should be
> public static IModel of(SerializableSupplier getter,
> SerializableConsumer setter)
> The problem is that IModel and SerializableSupplier have functionally the
> same interface:
> T getObject(); vs. T get();
>
> Background:
> The child component should share its default model object with its parent
> component's default model object. So if setDefaultModelObject is called on
> the parent component than the child component should also refer to the new
> value (and with versa).
>
> Workaround:
> public Parent(String wicektId, IModel roleModel) {
> IModel childRoleModel = new IModel() {
> @Override
> public Role getObject()
> { return Parent.this.getModelObject(); }
> @Override
> public void setObject(Role object)
> { Parent.this.setModelObject(object); }
> };
> add(new Child("child", childRoleModel));
> }
>
> Solution:
> The problem only exists because .of Method is overloaded. If both methods
> would have different names (or be in different classes) than the compiler
> would be fine.
>
> Please see attached files
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WICKET-6569) LambdaModel.of overload is ambiguous
[
https://issues.apache.org/jira/browse/WICKET-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713051#comment-16713051
]
ASF subversion and git services commented on WICKET-6569:
-
Commit 4f9b029fa32a9da0fa9aebc710443a202a435299 in wicket's branch
refs/heads/wicket-8.x from [~svenmeier]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=4f9b029 ]
WICKET-6569 deprecated ambiguous method
> LambdaModel.of overload is ambiguous
>
>
> Key: WICKET-6569
> URL: https://issues.apache.org/jira/browse/WICKET-6569
> Project: Wicket
> Issue Type: Wish
> Components: wicket
>Affects Versions: 8.0.0
>Reporter: Michael Gerhards
>Priority: Minor
> Fix For: 8.3.0, 9.0.0
>
> Attachments: myproject.zip
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> a method call of
> LambdaModel.of(this::getModelObject, this::setModelObject)
> refers to
> public static IModel of(IModel target, SerializableFunction R> getter)
> but should be
> public static IModel of(SerializableSupplier getter,
> SerializableConsumer setter)
> The problem is that IModel and SerializableSupplier have functionally the
> same interface:
> T getObject(); vs. T get();
>
> Background:
> The child component should share its default model object with its parent
> component's default model object. So if setDefaultModelObject is called on
> the parent component than the child component should also refer to the new
> value (and with versa).
>
> Workaround:
> public Parent(String wicektId, IModel roleModel) {
> IModel childRoleModel = new IModel() {
> @Override
> public Role getObject()
> { return Parent.this.getModelObject(); }
> @Override
> public void setObject(Role object)
> { Parent.this.setModelObject(object); }
> };
> add(new Child("child", childRoleModel));
> }
>
> Solution:
> The problem only exists because .of Method is overloaded. If both methods
> would have different names (or be in different classes) than the compiler
> would be fine.
>
> Please see attached files
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
wicket git commit: WICKET-6569 deprecated ambiguous method
Repository: wicket
Updated Branches:
refs/heads/wicket-8.x 826f1c9a4 -> 4f9b029fa
WICKET-6569 deprecated ambiguous method
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/4f9b029f
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/4f9b029f
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/4f9b029f
Branch: refs/heads/wicket-8.x
Commit: 4f9b029fa32a9da0fa9aebc710443a202a435299
Parents: 826f1c9
Author: Sven Meier
Authored: Fri Dec 7 17:21:55 2018 +0100
Committer: Sven Meier
Committed: Fri Dec 7 17:21:55 2018 +0100
--
.../src/main/java/org/apache/wicket/model/LambdaModel.java| 3 +++
1 file changed, 3 insertions(+)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/4f9b029f/wicket-core/src/main/java/org/apache/wicket/model/LambdaModel.java
--
diff --git a/wicket-core/src/main/java/org/apache/wicket/model/LambdaModel.java
b/wicket-core/src/main/java/org/apache/wicket/model/LambdaModel.java
index 96d4f20..dc2d49c 100644
--- a/wicket-core/src/main/java/org/apache/wicket/model/LambdaModel.java
+++ b/wicket-core/src/main/java/org/apache/wicket/model/LambdaModel.java
@@ -134,7 +134,10 @@ public abstract class LambdaModel implements IModel
*model object type
*
* @return model
+*
+* @deprecated this method will be remove in Wicket 9.x, use {@link
IModel#map(SerializableFunction)} instead.
*/
+ @Deprecated
public static IModel of(IModel target,
SerializableFunction getter)
{
Args.notNull(target, "target");
[jira] [Resolved] (WICKET-6569) LambdaModel.of overload is ambiguous
[
https://issues.apache.org/jira/browse/WICKET-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sven Meier resolved WICKET-6569.
Resolution: Fixed
Assignee: Sven Meier
Fix Version/s: 9.0.0
8.3.0
The problematic method was deprecate in Wicket 8.x and removed in 9.x
> LambdaModel.of overload is ambiguous
>
>
> Key: WICKET-6569
> URL: https://issues.apache.org/jira/browse/WICKET-6569
> Project: Wicket
> Issue Type: Wish
> Components: wicket
>Affects Versions: 8.0.0
>Reporter: Michael Gerhards
>Assignee: Sven Meier
>Priority: Minor
> Fix For: 8.3.0, 9.0.0
>
> Attachments: myproject.zip
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> a method call of
> LambdaModel.of(this::getModelObject, this::setModelObject)
> refers to
> public static IModel of(IModel target, SerializableFunction R> getter)
> but should be
> public static IModel of(SerializableSupplier getter,
> SerializableConsumer setter)
> The problem is that IModel and SerializableSupplier have functionally the
> same interface:
> T getObject(); vs. T get();
>
> Background:
> The child component should share its default model object with its parent
> component's default model object. So if setDefaultModelObject is called on
> the parent component than the child component should also refer to the new
> value (and with versa).
>
> Workaround:
> public Parent(String wicektId, IModel roleModel) {
> IModel childRoleModel = new IModel() {
> @Override
> public Role getObject()
> { return Parent.this.getModelObject(); }
> @Override
> public void setObject(Role object)
> { Parent.this.setModelObject(object); }
> };
> add(new Child("child", childRoleModel));
> }
>
> Solution:
> The problem only exists because .of Method is overloaded. If both methods
> would have different names (or be in different classes) than the compiler
> would be fine.
>
> Please see attached files
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WICKET-6578) StatelessResourceLink
[
https://issues.apache.org/jira/browse/WICKET-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713045#comment-16713045
]
ASF subversion and git services commented on WICKET-6578:
-
Commit b7ac58db8183f7c0632388fdf43e4a00d82ba355 in wicket's branch
refs/heads/master from [~svenmeier]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=b7ac58d ]
WICKET-6578 ResourceLink is stateless
when used with resourceReference
> StatelessResourceLink
> -
>
> Key: WICKET-6578
> URL: https://issues.apache.org/jira/browse/WICKET-6578
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
>Affects Versions: 8.0.0
>Reporter: Michael Gerhards
>Priority: Trivial
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Wicket provides many Stateless Versions of classes such as StatelessLink. It
> would be nice to also have a StatelessResourceLink:
> Complete code for StatelessResourceLink analogous to StatelessLink:
> public class StatelessResourceLink extends ResourceLink {
> public StatelessResourceLink(String wicketId, ResourceReference
> resourceReference) {
> super(wicketId, resourceReference);
> }
> public StatelessResourceLink(String wicketId, ResourceReference
> resourceReference, PageParameters resourceParameters) {
> super(wicketId, resourceReference, resourceParameters);
> }
> public StatelessResourceLink(String wicketId, IResource resource) {
> super(wicketId, resource);
> }
> @Override
> protected boolean getStatelessHint() {
> return true;
> }
>
> }
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[2/2] wicket git commit: WICKET-6569 remove ambiguous method
WICKET-6569 remove ambiguous method
deprecated in 8.x
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/babcb99e
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/babcb99e
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/babcb99e
Branch: refs/heads/master
Commit: babcb99ef040c0d1160d8d0cbb22b323c868e0ed
Parents: b7ac58d
Author: Sven Meier
Authored: Fri Dec 7 17:20:55 2018 +0100
Committer: Sven Meier
Committed: Fri Dec 7 17:20:55 2018 +0100
--
.../org/apache/wicket/model/LambdaModel.java| 56
.../apache/wicket/model/LambdaModelTest.java| 13 -
2 files changed, 69 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/babcb99e/wicket-core/src/main/java/org/apache/wicket/model/LambdaModel.java
--
diff --git a/wicket-core/src/main/java/org/apache/wicket/model/LambdaModel.java
b/wicket-core/src/main/java/org/apache/wicket/model/LambdaModel.java
index 96d4f20..af857dc 100644
--- a/wicket-core/src/main/java/org/apache/wicket/model/LambdaModel.java
+++ b/wicket-core/src/main/java/org/apache/wicket/model/LambdaModel.java
@@ -112,62 +112,6 @@ public abstract class LambdaModel implements IModel
};
}
-
- /**
-* Create a {@link LambdaModel} for a given target. Usage:
-*
-*
-* {@code
-* LambdaModel.of(personModel, Person::getName)
-* }
-*
-*
-* The target model will be detached automatically.
-*
-* @param target
-*target for getter and setter
-* @param getter
-*used to get a value
-* @param
-*target model object type
-* @param
-*model object type
-*
-* @return model
-*/
- public static IModel of(IModel target,
SerializableFunction getter)
- {
- Args.notNull(target, "target");
- Args.notNull(getter, "getter");
-
- return new LambdaModel()
- {
- private static final long serialVersionUID = 1L;
-
- @Override
- public R getObject()
- {
- X x = target.getObject();
- if (x == null)
- {
- return null;
- }
- return getter.apply(x);
- }
-
- @Override
- public void setObject(R r) {
- throw new
UnsupportedOperationException("setObject(Object) on " + target + " is not
supported");
- }
-
- @Override
- public void detach()
- {
- target.detach();
- }
- };
- }
-
/**
* Create a {@link LambdaModel} for a given target. Usage:
*
http://git-wip-us.apache.org/repos/asf/wicket/blob/babcb99e/wicket-core/src/test/java/org/apache/wicket/model/LambdaModelTest.java
--
diff --git
a/wicket-core/src/test/java/org/apache/wicket/model/LambdaModelTest.java
b/wicket-core/src/test/java/org/apache/wicket/model/LambdaModelTest.java
index 905ed62..1868031 100644
--- a/wicket-core/src/test/java/org/apache/wicket/model/LambdaModelTest.java
+++ b/wicket-core/src/test/java/org/apache/wicket/model/LambdaModelTest.java
@@ -19,7 +19,6 @@ package org.apache.wicket.model;
import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNull;
-import static org.junit.jupiter.api.Assertions.assertThrows;
import org.apache.wicket.core.util.lang.WicketObjects;
import org.apache.wicket.model.lambda.Person;
@@ -69,18 +68,6 @@ class LambdaModelTest
assertNull(personNameModel.getObject());
}
- @Test
- void targetReadOnly()
- {
- IModel target = Model.of(new Person());
-
- IModel personNameModel = LambdaModel.of(target,
Person::getName);
-
- assertThrows(UnsupportedOperationException.class, () -> {
- check(personNameModel);
- });
- }
-
private void check(IModel personNameModel)
{
assertNull(personNameModel.getObject());
[1/2] wicket git commit: WICKET-6578 ResourceLink is stateless
Repository: wicket Updated Branches: refs/heads/master 2bfdc8b23 -> babcb99ef WICKET-6578 ResourceLink is stateless when used with resourceReference Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/b7ac58db Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/b7ac58db Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/b7ac58db Branch: refs/heads/master Commit: b7ac58db8183f7c0632388fdf43e4a00d82ba355 Parents: 2bfdc8b Author: Sven Meier Authored: Fri Dec 7 17:17:28 2018 +0100 Committer: Sven Meier Committed: Fri Dec 7 17:17:28 2018 +0100 -- .../org/apache/wicket/markup/html/link/ResourceLinkTest.java| 5 - 1 file changed, 4 insertions(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/wicket/blob/b7ac58db/wicket-core/src/test/java/org/apache/wicket/markup/html/link/ResourceLinkTest.java -- diff --git a/wicket-core/src/test/java/org/apache/wicket/markup/html/link/ResourceLinkTest.java b/wicket-core/src/test/java/org/apache/wicket/markup/html/link/ResourceLinkTest.java index 78a2a10..c790674 100644 --- a/wicket-core/src/test/java/org/apache/wicket/markup/html/link/ResourceLinkTest.java +++ b/wicket-core/src/test/java/org/apache/wicket/markup/html/link/ResourceLinkTest.java @@ -16,11 +16,14 @@ */ package org.apache.wicket.markup.html.link; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; + import org.apache.wicket.request.resource.CharSequenceResource; import org.apache.wicket.request.resource.IResource; import org.apache.wicket.request.resource.ResourceReference; import org.apache.wicket.util.tester.WicketTestCase; -import org.junit.Test; +import org.junit.jupiter.api.Test; /**
[jira] [Commented] (WICKET-6578) StatelessResourceLink
[
https://issues.apache.org/jira/browse/WICKET-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713031#comment-16713031
]
ASF subversion and git services commented on WICKET-6578:
-
Commit 826f1c9a4e03b8458121511ef8a08d97eeb28e5f in wicket's branch
refs/heads/wicket-8.x from [~svenmeier]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=826f1c9 ]
WICKET-6578 ResourceLink is stateless
when used with resourceReference
> StatelessResourceLink
> -
>
> Key: WICKET-6578
> URL: https://issues.apache.org/jira/browse/WICKET-6578
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
>Affects Versions: 8.0.0
>Reporter: Michael Gerhards
>Priority: Trivial
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Wicket provides many Stateless Versions of classes such as StatelessLink. It
> would be nice to also have a StatelessResourceLink:
> Complete code for StatelessResourceLink analogous to StatelessLink:
> public class StatelessResourceLink extends ResourceLink {
> public StatelessResourceLink(String wicketId, ResourceReference
> resourceReference) {
> super(wicketId, resourceReference);
> }
> public StatelessResourceLink(String wicketId, ResourceReference
> resourceReference, PageParameters resourceParameters) {
> super(wicketId, resourceReference, resourceParameters);
> }
> public StatelessResourceLink(String wicketId, IResource resource) {
> super(wicketId, resource);
> }
> @Override
> protected boolean getStatelessHint() {
> return true;
> }
>
> }
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
buildbot failure in on wicket-master
The Buildbot has detected a new failure on builder wicket-master while building wicket. Full details are available at: https://ci.apache.org/builders/wicket-master/builds/1039 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: bb_slave1_ubuntu Build Reason: The SingleBranchScheduler scheduler named 'on-wicket-master-commit' triggered this build Build Source Stamp: [branch master] 2bfdc8b2399dc9c20067ba6a80175215176702e5 Blamelist: Sven Meier BUILD FAILED: failed compile Sincerely, -The Buildbot
[jira] [Commented] (WICKET-6578) StatelessResourceLink
[
https://issues.apache.org/jira/browse/WICKET-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713039#comment-16713039
]
ASF subversion and git services commented on WICKET-6578:
-
Commit 2bfdc8b2399dc9c20067ba6a80175215176702e5 in wicket's branch
refs/heads/master from [~svenmeier]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=2bfdc8b ]
WICKET-6578 ResourceLink is stateless
when used with resourceReference
> StatelessResourceLink
> -
>
> Key: WICKET-6578
> URL: https://issues.apache.org/jira/browse/WICKET-6578
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
>Affects Versions: 8.0.0
>Reporter: Michael Gerhards
>Priority: Trivial
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Wicket provides many Stateless Versions of classes such as StatelessLink. It
> would be nice to also have a StatelessResourceLink:
> Complete code for StatelessResourceLink analogous to StatelessLink:
> public class StatelessResourceLink extends ResourceLink {
> public StatelessResourceLink(String wicketId, ResourceReference
> resourceReference) {
> super(wicketId, resourceReference);
> }
> public StatelessResourceLink(String wicketId, ResourceReference
> resourceReference, PageParameters resourceParameters) {
> super(wicketId, resourceReference, resourceParameters);
> }
> public StatelessResourceLink(String wicketId, IResource resource) {
> super(wicketId, resource);
> }
> @Override
> protected boolean getStatelessHint() {
> return true;
> }
>
> }
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
wicket git commit: WICKET-6578 ResourceLink is stateless
Repository: wicket
Updated Branches:
refs/heads/master 52a101f01 -> 2bfdc8b23
WICKET-6578 ResourceLink is stateless
when used with resourceReference
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/2bfdc8b2
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/2bfdc8b2
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/2bfdc8b2
Branch: refs/heads/master
Commit: 2bfdc8b2399dc9c20067ba6a80175215176702e5
Parents: 52a101f
Author: Sven Meier
Authored: Fri Dec 7 16:55:41 2018 +0100
Committer: Sven Meier
Committed: Fri Dec 7 17:06:23 2018 +0100
--
.../wicket/markup/html/link/ResourceLink.java | 29 ++---
.../markup/html/link/PageWithResourceLink.html | 8 +++
.../markup/html/link/PageWithResourceLink.java | 47 ++
.../markup/html/link/ResourceLinkTest.java | 65
4 files changed, 142 insertions(+), 7 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/2bfdc8b2/wicket-core/src/main/java/org/apache/wicket/markup/html/link/ResourceLink.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/markup/html/link/ResourceLink.java
b/wicket-core/src/main/java/org/apache/wicket/markup/html/link/ResourceLink.java
index dcfe7a5..303c067 100644
---
a/wicket-core/src/main/java/org/apache/wicket/markup/html/link/ResourceLink.java
+++
b/wicket-core/src/main/java/org/apache/wicket/markup/html/link/ResourceLink.java
@@ -106,15 +106,20 @@ public class ResourceLink extends Link implements
IRequestListener
return false;
}
+ /**
+* For {@link ResourceReference}s this link is stateless.
+*
+* @return true if a resourceReference was provided to the
+* constructor
+*
+* @see ResourceLink#ResourceLink(String, ResourceReference)
+* @see ResourceLink#ResourceLink(String, ResourceReference,
PageParameters)
+*/
@Override
- public final void onRequest()
+ protected boolean getStatelessHint()
{
- Attributes a = new Attributes(RequestCycle.get().getRequest(),
RequestCycle.get()
- .getResponse(), null);
- resource.respond(a);
-
- super.onRequest();
- }
+ return resourceReference != null;
+ }
@Override
protected final CharSequence getURL()
@@ -140,4 +145,14 @@ public class ResourceLink extends Link implements
IRequestListener
}
return urlForListener(resourceParameters);
}
+
+ @Override
+ public final void onRequest()
+ {
+ Attributes a = new Attributes(RequestCycle.get().getRequest(),
RequestCycle.get()
+ .getResponse(), null);
+ resource.respond(a);
+
+ super.onRequest();
+ }
}
http://git-wip-us.apache.org/repos/asf/wicket/blob/2bfdc8b2/wicket-core/src/test/java/org/apache/wicket/markup/html/link/PageWithResourceLink.html
--
diff --git
a/wicket-core/src/test/java/org/apache/wicket/markup/html/link/PageWithResourceLink.html
b/wicket-core/src/test/java/org/apache/wicket/markup/html/link/PageWithResourceLink.html
new file mode 100644
index 000..cb27a2c
--- /dev/null
+++
b/wicket-core/src/test/java/org/apache/wicket/markup/html/link/PageWithResourceLink.html
@@ -0,0 +1,8 @@
+
+
+Mock Page
+
+
+Link
+
+
http://git-wip-us.apache.org/repos/asf/wicket/blob/2bfdc8b2/wicket-core/src/test/java/org/apache/wicket/markup/html/link/PageWithResourceLink.java
--
diff --git
a/wicket-core/src/test/java/org/apache/wicket/markup/html/link/PageWithResourceLink.java
b/wicket-core/src/test/java/org/apache/wicket/markup/html/link/PageWithResourceLink.java
new file mode 100644
index 000..ccec067
--- /dev/null
+++
b/wicket-core/src/test/java/org/apache/wicket/markup/html/link/PageWithResourceLink.java
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS"
wicket git commit: WICKET-6578 ResourceLink is stateless
Repository: wicket
Updated Branches:
refs/heads/wicket-8.x a44613885 -> 826f1c9a4
WICKET-6578 ResourceLink is stateless
when used with resourceReference
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/826f1c9a
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/826f1c9a
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/826f1c9a
Branch: refs/heads/wicket-8.x
Commit: 826f1c9a4e03b8458121511ef8a08d97eeb28e5f
Parents: a446138
Author: Sven Meier
Authored: Fri Dec 7 16:55:41 2018 +0100
Committer: Sven Meier
Committed: Fri Dec 7 16:55:41 2018 +0100
--
.../wicket/markup/html/link/ResourceLink.java | 29 ++---
.../markup/html/link/PageWithResourceLink.html | 8 +++
.../markup/html/link/PageWithResourceLink.java | 47 ++
.../markup/html/link/ResourceLinkTest.java | 65
4 files changed, 142 insertions(+), 7 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/826f1c9a/wicket-core/src/main/java/org/apache/wicket/markup/html/link/ResourceLink.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/markup/html/link/ResourceLink.java
b/wicket-core/src/main/java/org/apache/wicket/markup/html/link/ResourceLink.java
index dcfe7a5..303c067 100644
---
a/wicket-core/src/main/java/org/apache/wicket/markup/html/link/ResourceLink.java
+++
b/wicket-core/src/main/java/org/apache/wicket/markup/html/link/ResourceLink.java
@@ -106,15 +106,20 @@ public class ResourceLink extends Link implements
IRequestListener
return false;
}
+ /**
+* For {@link ResourceReference}s this link is stateless.
+*
+* @return true if a resourceReference was provided to the
+* constructor
+*
+* @see ResourceLink#ResourceLink(String, ResourceReference)
+* @see ResourceLink#ResourceLink(String, ResourceReference,
PageParameters)
+*/
@Override
- public final void onRequest()
+ protected boolean getStatelessHint()
{
- Attributes a = new Attributes(RequestCycle.get().getRequest(),
RequestCycle.get()
- .getResponse(), null);
- resource.respond(a);
-
- super.onRequest();
- }
+ return resourceReference != null;
+ }
@Override
protected final CharSequence getURL()
@@ -140,4 +145,14 @@ public class ResourceLink extends Link implements
IRequestListener
}
return urlForListener(resourceParameters);
}
+
+ @Override
+ public final void onRequest()
+ {
+ Attributes a = new Attributes(RequestCycle.get().getRequest(),
RequestCycle.get()
+ .getResponse(), null);
+ resource.respond(a);
+
+ super.onRequest();
+ }
}
http://git-wip-us.apache.org/repos/asf/wicket/blob/826f1c9a/wicket-core/src/test/java/org/apache/wicket/markup/html/link/PageWithResourceLink.html
--
diff --git
a/wicket-core/src/test/java/org/apache/wicket/markup/html/link/PageWithResourceLink.html
b/wicket-core/src/test/java/org/apache/wicket/markup/html/link/PageWithResourceLink.html
new file mode 100644
index 000..cb27a2c
--- /dev/null
+++
b/wicket-core/src/test/java/org/apache/wicket/markup/html/link/PageWithResourceLink.html
@@ -0,0 +1,8 @@
+
+
+Mock Page
+
+
+Link
+
+
http://git-wip-us.apache.org/repos/asf/wicket/blob/826f1c9a/wicket-core/src/test/java/org/apache/wicket/markup/html/link/PageWithResourceLink.java
--
diff --git
a/wicket-core/src/test/java/org/apache/wicket/markup/html/link/PageWithResourceLink.java
b/wicket-core/src/test/java/org/apache/wicket/markup/html/link/PageWithResourceLink.java
new file mode 100644
index 000..ccec067
--- /dev/null
+++
b/wicket-core/src/test/java/org/apache/wicket/markup/html/link/PageWithResourceLink.java
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS
[jira] [Commented] (WICKET-6620) @Deprecated classes/methods need to be removed
[ https://issues.apache.org/jira/browse/WICKET-6620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712566#comment-16712566 ] ASF GitHub Bot commented on WICKET-6620: GitHub user solomax opened a pull request: https://github.com/apache/wicket/pull/344 [WICKET-6620] deprecated classes/methods are removed You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/wicket WICKET-6620-remove-deprecated Alternatively you can review and apply these changes as the patch at: https://github.com/apache/wicket/pull/344.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #344 commit 4b09e371b0a59ff2d093d1236afbf66ee7874402 Author: Maxim Solodovnik Date: 2018-12-07T09:52:19Z [WICKET-6620] deprecated classes/methods are removed > @Deprecated classes/methods need to be removed > -- > > Key: WICKET-6620 > URL: https://issues.apache.org/jira/browse/WICKET-6620 > Project: Wicket > Issue Type: Task > Components: wicket >Affects Versions: 9.0.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 9.0.0 > > > @Deprecated classes/methods need to be removed > 1) Drop all `@Deprecated(since = "8.0", forRemoval = true)` from master > 2) Drop all marked as @Deprecated in wicket7 from master -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6620) @Deprecated classes/methods need to be removed
[ https://issues.apache.org/jira/browse/WICKET-6620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712564#comment-16712564 ] ASF subversion and git services commented on WICKET-6620: - Commit 4b09e371b0a59ff2d093d1236afbf66ee7874402 in wicket's branch refs/heads/WICKET-6620-remove-deprecated from [~solomax] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=4b09e37 ] [WICKET-6620] deprecated classes/methods are removed > @Deprecated classes/methods need to be removed > -- > > Key: WICKET-6620 > URL: https://issues.apache.org/jira/browse/WICKET-6620 > Project: Wicket > Issue Type: Task > Components: wicket >Affects Versions: 9.0.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 9.0.0 > > > @Deprecated classes/methods need to be removed > 1) Drop all `@Deprecated(since = "8.0", forRemoval = true)` from master > 2) Drop all marked as @Deprecated in wicket7 from master -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[2/2] wicket git commit: [WICKET-6620] deprecated classes/methods are removed
[WICKET-6620] deprecated classes/methods are removed
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/4b09e371
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/4b09e371
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/4b09e371
Branch: refs/heads/WICKET-6620-remove-deprecated
Commit: 4b09e371b0a59ff2d093d1236afbf66ee7874402
Parents: 52a101f
Author: Maxim Solodovnik
Authored: Fri Dec 7 16:52:19 2018 +0700
Committer: Maxim Solodovnik
Committed: Fri Dec 7 16:52:19 2018 +0700
--
.../core/request/handler/IPageProvider.java |7 -
.../core/request/handler/PageProvider.java | 11 -
.../mapper/AbstractBookmarkableMapper.java |2 +-
.../wicket/core/util/lang/WicketObjects.java| 149 +--
.../org/apache/wicket/markup/WicketTag.java | 13 -
.../apache/wicket/markup/html/form/Form.java|8 -
.../wicket/markup/html/form/FormComponent.java | 17 -
.../markup/resolver/HtmlHeaderResolver.java | 17 +-
.../migrate/StringResourceModelMigration.java | 175 ---
.../http/mock/MockHttpServletRequest.java | 44 -
.../http/mock/MockHttpServletResponse.java | 44 -
.../request/handler/render/WebPageRenderer.java |2 +-
.../resource/JQueryResourceReference.java |9 -
.../wicket/util/tester/BaseWicketTester.java| 35 +-
.../apache/wicket/util/tester/TagTester.java| 40 +-
.../apache/wicket/util/tester/WicketTester.java | 19 -
.../core/request/mapper/MountedMapperTest.java | 20 +-
.../markup/html/image/ResponsiveImageTest.java |8 +-
.../wicket/markup/html/media/MediaTagsTest.java | 13 +-
.../request/handler/PageProviderTest.java |3 +-
.../handler/render/WebPageRendererTest.java |6 +-
.../wicket/util/lang/WicketObjectsTest.java | 17 +-
.../examples/guestbook/GuestbookTest.java |4 +-
.../ajax/markup/html/AjaxLazyLoadPanel.java | 34 -
.../data/sort/AjaxFallbackOrderByLink.java | 52 -
.../wizard/IDefaultButtonProvider.java | 47 -
.../wicket/extensions/wizard/WizardButton.java | 17 -
.../wicket/request/RequestHandlerExecutor.java | 29 -
.../apache/wicket/util/IContextProvider.java| 47 -
.../java/org/apache/wicket/util/IProvider.java | 36 -
.../wicket/util/collections/ArrayListStack.java | 141 ---
.../org/apache/wicket/util/crypt/Base64.java| 1108 --
.../apache/wicket/util/crypt/Base64Test.java| 275 -
33 files changed, 36 insertions(+), 2413 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/4b09e371/wicket-core/src/main/java/org/apache/wicket/core/request/handler/IPageProvider.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/core/request/handler/IPageProvider.java
b/wicket-core/src/main/java/org/apache/wicket/core/request/handler/IPageProvider.java
index 28ccb3a..47d7239 100644
---
a/wicket-core/src/main/java/org/apache/wicket/core/request/handler/IPageProvider.java
+++
b/wicket-core/src/main/java/org/apache/wicket/core/request/handler/IPageProvider.java
@@ -52,13 +52,6 @@ public interface IPageProvider
PageParameters getPageParameters() throws PageExpiredException;
/**
-* @return negates {@link PageProvider#hasPageInstance()}
-* @deprecated use {@link PageProvider#hasPageInstance()} negation
instead
-*/
- @Deprecated(since = "8.0", forRemoval = true)
- boolean isNewPageInstance();
-
- /**
* Returns whether the provided page was expired prior to this access.
*
* @return true> if the page was created after its
original instance expired.
http://git-wip-us.apache.org/repos/asf/wicket/blob/4b09e371/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageProvider.java
--
diff --git
a/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageProvider.java
b/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageProvider.java
index bb94682..c08f0ad 100644
---
a/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageProvider.java
+++
b/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageProvider.java
@@ -196,17 +196,6 @@ public class PageProvider implements IPageProvider,
IClusterable
}
/**
-* @return negates {@link PageProvider#hasPageInstance()}
-* @deprecated use {@link PageProvider#hasPageInstance()} negation
instead
-*/
- @Deprecated(since = "8.0", forRemoval = true)
- @Override
- public boolean isNewPageInstance()
- {
- return !hasPageInstance();
- }
-
- /**
[1/2] wicket git commit: [WICKET-6620] deprecated classes/methods are removed
Repository: wicket
Updated Branches:
refs/heads/WICKET-6620-remove-deprecated [created] 4b09e371b
http://git-wip-us.apache.org/repos/asf/wicket/blob/4b09e371/wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java
--
diff --git a/wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java
b/wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java
deleted file mode 100644
index 358db37..000
--- a/wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java
+++ /dev/null
@@ -1,1108 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.wicket.util.crypt;
-
-import java.math.BigInteger;
-
-/**
- * Provides Base64 encoding and decoding with URL and filename safe alphabet
as defined by RFC 3548,
- * section 4.
- *
- * This Base64 encoder is modified to meet URL requirements. The changes are:
'+' = '*', '/' =
- * '-', and no padding.
- *
- *
- * This class is taken from the Apache commons-codec, and adjusted to fit the
Wicket framework's
- * needs, especially external dependencies have been removed.
- *
- *
- * This class implements section 4. Base 64 Encoding with URL and
Filename Safe
- * Alphabet from RFC 3548 The Base16, Base32, and Base64 Data
Encodings by Simon
- * Josefsson.
- *
- *
- * @author Apache Software Foundation
- * @author Juergen Donnerstag
- *
- * @since 1.2
- * @deprecated Use {@link java.util.Base64} instead.
- */
-@Deprecated
-public class Base64
-{
- private static final int DEFAULT_BUFFER_RESIZE_FACTOR = 2;
-
- private static final int DEFAULT_BUFFER_SIZE = 8192;
-
- /**
-* Chunk size per RFC 2045 section 6.8.
-*
-*
-* The {@value} character limit does not count the trailing CRLF, but
counts all other
-* characters, including any equal signs.
-*
-*
-* @see http://www.ietf.org/rfc/rfc2045.txt;>RFC 2045 section
6.8
-*/
- static final int CHUNK_SIZE = 76;
-
- /**
-* Chunk separator per RFC 2045 section 2.1.
-*
-*
-* N.B. The next major release may break compatibility and make this
field private.
-*
-*
-* @see http://www.ietf.org/rfc/rfc2045.txt;>RFC 2045 section
2.1
-*/
- static final byte[] CHUNK_SEPARATOR = { '\r', '\n' };
-
- /**
-* This array is a lookup table that translates 6-bit positive integer
index values into their
-* "Base64 Alphabet" equivalents as specified in Table 1 of RFC 2045.
-*
-* Thanks to "commons" project in ws.apache.org for this code.
-*
http://svn.apache.org/repos/asf/webservices/commons/trunk/modules/util/
-*/
- private static final byte[] STANDARD_ENCODE_TABLE = { 'A', 'B', 'C',
'D', 'E', 'F', 'G', 'H',
- 'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S',
'T', 'U', 'V', 'W', 'X', 'Y',
- 'Z', 'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j',
'k', 'l', 'm', 'n', 'o', 'p',
- 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z', '0',
'1', '2', '3', '4', '5', '6',
- '7', '8', '9', '+', '/' };
-
- /**
-* This is a copy of the STANDARD_ENCODE_TABLE above, but with + and /
changed to - and _ to
-* make the encoded Base64 results more URL-SAFE. This table is only
used when the Base64's mode
-* is set to URL-SAFE.
-*/
- private static final byte[] URL_SAFE_ENCODE_TABLE = { 'A', 'B', 'C',
'D', 'E', 'F', 'G', 'H',
- 'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S',
'T', 'U', 'V', 'W', 'X', 'Y',
- 'Z', 'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j',
'k', 'l', 'm', 'n', 'o', 'p',
- 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z', '0',
'1', '2', '3', '4', '5', '6',
- '7', '8', '9', '-', '_' };
-
- /**
-* Byte used to pad output.
-*/
- private static final byte PAD = '=';
-
- /**
-* This array is a lookup table that translates Unicode characters
drawn from the
-
[jira] [Created] (WICKET-6620) @Deprecated classes/methods need to be removed
Maxim Solodovnik created WICKET-6620: Summary: @Deprecated classes/methods need to be removed Key: WICKET-6620 URL: https://issues.apache.org/jira/browse/WICKET-6620 Project: Wicket Issue Type: Task Components: wicket Affects Versions: 9.0.0 Reporter: Maxim Solodovnik Assignee: Maxim Solodovnik Fix For: 9.0.0 @Deprecated classes/methods need to be removed 1) Drop all `@Deprecated(since = "8.0", forRemoval = true)` from master 2) Drop all marked as @Deprecated in wicket7 from master -- This message was sent by Atlassian JIRA (v7.6.3#76005)
