[jira] [Comment Edited] (WICKET-7106) Changes in JS File between milestone and final release are cached by browsers

2024-04-22 Thread Martin Tzvetanov Grigorov (Jira)


[ 
https://issues.apache.org/jira/browse/WICKET-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839820#comment-17839820
 ] 

Martin Tzvetanov Grigorov edited comment on WICKET-7106 at 4/22/24 7:03 PM:


Please take a look at https://issues.apache.org/jira/browse/WICKET-7090.
Wicket uses IResourceCachingStrategy to generate the -ver-1001 part of the 
ResourceReferences' names.
You may use even a custom impl to generate a unique value without waiting for a 
new Wicket release.

The discussion at dev@ is 
https://lists.apache.org/thread/drdsskl7nhj2xdrtk2z87p8f4v8c9w7r


was (Author: mgrigorov):
Please take a look at https://issues.apache.org/jira/browse/WICKET-7090.
Wicket uses IResourceCachingStrategy to generate the -ver-1001 part of the 
ResourceReferences' names.
You may use even a custom impl to generate a unique value without waiting for a 
new Wicket release.

> Changes in JS File between milestone and final release are cached by browsers
> -
>
> Key: WICKET-7106
> URL: https://issues.apache.org/jira/browse/WICKET-7106
> Project: Wicket
>  Issue Type: Wish
>Affects Versions: 10.0.0
>Reporter: Alexander Ermer
>Priority: Trivial
>
> My issue is the latest change of wicket-ajax-jquery.js between 10.0.0-M2 and 
> 10.0.0 (final) from 
> https://github.com/apache/wicket/commit/653d31b1154450626fc8c4047a6b25007924bf90
>  
> We had to go in production with the milestone version which serves the file 
> wicket-ajax-jquery-ver-1000.js. The exakt same filename is served by the 
> final releaes BUT there are changes. Default browser settings do cache these 
> files which leads to undefined function calls of `Wicket.Event.requestSubmit`.
>  
> This issue is very easy to solve: please just release a version like 10.0.1 
> without any changes. That way the file wicket-ajax-jquery-ver-1001.js would 
> be served and my problems are gone.
>  
> Thanks!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WICKET-7106) Changes in JS File between milestone and final release are cached by browsers

2024-04-22 Thread Martin Tzvetanov Grigorov (Jira)


[ 
https://issues.apache.org/jira/browse/WICKET-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839820#comment-17839820
 ] 

Martin Tzvetanov Grigorov commented on WICKET-7106:
---

Please take a look at https://issues.apache.org/jira/browse/WICKET-7090.
Wicket uses IResourceCachingStrategy to generate the -ver-1001 part of the 
ResourceReferences' names.
You may use even a custom impl to generate a unique value without waiting for a 
new Wicket release.

> Changes in JS File between milestone and final release are cached by browsers
> -
>
> Key: WICKET-7106
> URL: https://issues.apache.org/jira/browse/WICKET-7106
> Project: Wicket
>  Issue Type: Wish
>Affects Versions: 10.0.0
>Reporter: Alexander Ermer
>Priority: Trivial
>
> My issue is the latest change of wicket-ajax-jquery.js between 10.0.0-M2 and 
> 10.0.0 (final) from 
> https://github.com/apache/wicket/commit/653d31b1154450626fc8c4047a6b25007924bf90
>  
> We had to go in production with the milestone version which serves the file 
> wicket-ajax-jquery-ver-1000.js. The exakt same filename is served by the 
> final releaes BUT there are changes. Default browser settings do cache these 
> files which leads to undefined function calls of `Wicket.Event.requestSubmit`.
>  
> This issue is very easy to solve: please just release a version like 10.0.1 
> without any changes. That way the file wicket-ajax-jquery-ver-1001.js would 
> be served and my problems are gone.
>  
> Thanks!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (WICKET-7106) Changes in JS File between milestone and final release are cached by browsers

2024-04-22 Thread Alexander Ermer (Jira)


 [ 
https://issues.apache.org/jira/browse/WICKET-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Ermer updated WICKET-7106:

Summary: Changes in JS File between milestone and final release are cached 
by browsers  (was: Please release 10.0.1)

> Changes in JS File between milestone and final release are cached by browsers
> -
>
> Key: WICKET-7106
> URL: https://issues.apache.org/jira/browse/WICKET-7106
> Project: Wicket
>  Issue Type: Wish
>Affects Versions: 10.0.0
>Reporter: Alexander Ermer
>Priority: Trivial
>
> My issue is the latest change of wicket-ajax-jquery.js between 10.0.0-M2 and 
> 10.0.0 (final) from 
> https://github.com/apache/wicket/commit/653d31b1154450626fc8c4047a6b25007924bf90
>  
> We had to go in production with the milestone version which serves the file 
> wicket-ajax-jquery-ver-1000.js. The exakt same filename is served by the 
> final releaes BUT there are changes. Default browser settings do cache these 
> files which leads to undefined function calls of `Wicket.Event.requestSubmit`.
>  
> This issue is very easy to solve: please just release a version like 10.0.1 
> without any changes. That way the file wicket-ajax-jquery-ver-1001.js would 
> be served and my problems are gone.
>  
> Thanks!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (WICKET-7106) Please release 10.0.1

2024-04-22 Thread Alexander Ermer (Jira)
Alexander Ermer created WICKET-7106:
---

 Summary: Please release 10.0.1
 Key: WICKET-7106
 URL: https://issues.apache.org/jira/browse/WICKET-7106
 Project: Wicket
  Issue Type: Wish
Affects Versions: 10.0.0
Reporter: Alexander Ermer


My issue is the latest change of wicket-ajax-jquery.js between 10.0.0-M2 and 
10.0.0 (final) from 
https://github.com/apache/wicket/commit/653d31b1154450626fc8c4047a6b25007924bf90

 

We had to go in production with the milestone version which serves the file 
wicket-ajax-jquery-ver-1000.js. The exakt same filename is served by the final 
releaes BUT there are changes. Default browser settings do cache these files 
which leads to undefined function calls of `Wicket.Event.requestSubmit`.

 

This issue is very easy to solve: please just release a version like 10.0.1 
without any changes. That way the file wicket-ajax-jquery-ver-1001.js would be 
served and my problems are gone.

 

Thanks!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (WICKET-7105) Remove 'final' from AbstractPartialPageRequestHandler#add(Component...)

2024-04-22 Thread Sven T (Jira)


[ 
https://issues.apache.org/jira/browse/WICKET-7105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839531#comment-17839531
 ] 

Sven T commented on WICKET-7105:


Thanks for your quick help! 10.1.0 is fine.

> Remove 'final' from AbstractPartialPageRequestHandler#add(Component...)
> ---
>
> Key: WICKET-7105
> URL: https://issues.apache.org/jira/browse/WICKET-7105
> Project: Wicket
>  Issue Type: Wish
>Reporter: Sven T
>Assignee: Martin Tzvetanov Grigorov
>Priority: Major
> Fix For: 10.1.0
>
>
> We are currently in the progress of migrating a Wicket based framework from 
> Wicket 8 to Wicket 10. Wicket 9 introduced a breaking change in 
> AjaxRequestHandler, which made the method 
> AjaxRequestHandler#add(Component...) *final* (within this change the method 
> was moved to new parent class AbstractPartialPageRequestHandler.  See [Commit 
> in 
> GitHub|https://github.com/apache/wicket/commit/2dc9bd121c62aab1b742e55ce9c2675a8439f6df#diff-6c297de222deaef2b5afc7a03fa8b058c45cc92127b0fae647f27bd35cb17a29L219]
>  
> Is there any chance that the modifier can be removed again to match its 
> previous state? We are currently overriding the add(Component...) method in 
> Wicket 8 to add some custom logic to the refresh mechanism, which leads to 
> compile errors while migrating to Wicket 9/10.
>  
> If it helps, we could provide a pull request. Thanks in advance :) 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)