[jira] [Commented] (WICKET-6471) FileSystemResource file descriptor leak
[
https://issues.apache.org/jira/browse/WICKET-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176300#comment-16176300
]
Boris Goldowsky commented on WICKET-6471:
-
Thanks for the immediate fix!
> FileSystemResource file descriptor leak
> ---
>
> Key: WICKET-6471
> URL: https://issues.apache.org/jira/browse/WICKET-6471
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 7.9.0
>Reporter: Boris Goldowsky
>Assignee: Sven Meier
> Fix For: 8.0.0-M8, 7.10.0
>
> Attachments: frquickstart.zip
>
>
> FileSystemResource does not appear to close the InputStream that it creates.
> I believe it should call setClose(true) on the PartWriterCallback.
> To verify the problem, see the attached quick start. Change the filename in
> HomePage.java to point to some valid image file on your system. After viewing
> the home page in a browser, check for files that the jetty process has open,
> eg:
> {noformat}
> lsof -p PID | grep logo
> {noformat}
> If you load the home page a few more times, using Shift-reload to avoid
> simply loading from cache, you can see many file descriptors pointing to the
> image file are kept open:
> {noformat}
> java87278 borisgoldowsky txt REG1,4 12244
> 103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
> java87278 borisgoldowsky 175r REG1,4 12244
> 103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
> java87278 borisgoldowsky 180r REG1,4 12244
> 103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
> java87278 borisgoldowsky 181r REG1,4 12244
> 103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (WICKET-6471) FileSystemResource file descriptor leak
Boris Goldowsky created WICKET-6471:
---
Summary: FileSystemResource file descriptor leak
Key: WICKET-6471
URL: https://issues.apache.org/jira/browse/WICKET-6471
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 7.9.0
Reporter: Boris Goldowsky
Attachments: frquickstart.zip
FileSystemResource does not appear to close the InputStream that it creates.
I believe it should call setClose(true) on the PartWriterCallback.
To verify the problem, see the attached quick start. Change the filename in
HomePage.java to point to some valid image file on your system. After viewing
the home page in a browser, check for files that the jetty process has open, eg:
{noformat}
lsof -p PID | grep logo
{noformat}
If you load the home page a few more times, using Shift-reload to avoid simply
loading from cache, you can see many file descriptors pointing to the image
file are kept open:
{noformat}
java87278 borisgoldowsky txt REG1,4 12244
103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
java87278 borisgoldowsky 175r REG1,4 12244
103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
java87278 borisgoldowsky 180r REG1,4 12244
103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
java87278 borisgoldowsky 181r REG1,4 12244
103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
{noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (WICKET-6362) HeaderItems with different PageParameters are treated as identical
Boris Goldowsky created WICKET-6362:
---
Summary: HeaderItems with different PageParameters are treated as
identical
Key: WICKET-6362
URL: https://issues.apache.org/jira/browse/WICKET-6362
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 7.5.0
Reporter: Boris Goldowsky
Priority: Minor
Given code like the following, where same ResourceReference is used for both
resources but they have different PageParameters and different IDs, only one of
them actually gets rendered in the page head:
{code}
public void renderHead(IHeaderResponse response) {
…
response.render(JavaScriptHeaderItem.forReference(resRef, pageParameters1,
“id1”));
response.render(JavaScriptHeaderItem.forReference(resRef, pageParameters2,
“id2”));
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (WICKET-6172) Inconsistent results from getTag[s]ByWicketId
[ https://issues.apache.org/jira/browse/WICKET-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boris Goldowsky updated WICKET-6172: Attachment: tag-tester-quickstart.zip Quickstart showing the issue. Both "logo" tests should pass, but only one does. > Inconsistent results from getTag[s]ByWicketId > - > > Key: WICKET-6172 > URL: https://issues.apache.org/jira/browse/WICKET-6172 > Project: Wicket > Issue Type: Bug > Components: wicket >Reporter: Boris Goldowsky >Priority: Minor > Attachments: tag-tester-quickstart.zip > > > The change in WICKET-5874 alters the behavior for getTagByWicketId but not > getTagsByWicketId . Thus for markup like this: > > getTagByWicketId will return the img tag, but getTagsByWicketId will return > an empty list, which feels very inconsistent. > Since HTML5 made the /> syntax optional for void elements like input and img, > the XmlPullParser probably needs to be replaced with something that can parse > HTML5. The fix in WICKET-5874 does not seem sufficient. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (WICKET-6172) Inconsistent results from getTag[s]ByWicketId
Boris Goldowsky created WICKET-6172: --- Summary: Inconsistent results from getTag[s]ByWicketId Key: WICKET-6172 URL: https://issues.apache.org/jira/browse/WICKET-6172 Project: Wicket Issue Type: Bug Components: wicket Reporter: Boris Goldowsky Priority: Minor The change in WICKET-5874 alters the behavior for getTagByWicketId but not getTagsByWicketId . Thus for markup like this: getTagByWicketId will return the img tag, but getTagsByWicketId will return an empty list, which feels very inconsistent. Since HTML5 made the /> syntax optional for void elements like input and img, the XmlPullParser probably needs to be replaced with something that can parse HTML5. The fix in WICKET-5874 does not seem sufficient. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
