[jira] Created: (WICKET-2664) CheckBoxMultipleChoice should use isEnabledInHierarchy()
CheckBoxMultipleChoice should use isEnabledInHierarchy() Key: WICKET-2664 URL: https://issues.apache.org/jira/browse/WICKET-2664 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.4.1 Reporter: Craig McIlwee Fix For: 1.5-M1 ... instead of isEnabled() when rendering. This will make it consistent with all other form components, otherwise a call to setEnabled(false) on a form will disable all components except the CheckBoxMultipleChoice which requires special handling at the moment. FYI, I posted this to the mailing list and there were no objections or reasoning for the current behavior http://www.mail-archive.com/us...@wicket.apache.org/msg46303.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1579) Enclosure is checking determineVisibility instead of isVisible on child component
[
https://issues.apache.org/jira/browse/WICKET-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673081#action_12673081
]
Craig McIlwee commented on WICKET-1579:
---
Igor, can you add that restriction to the javadoc please?
> Enclosure is checking determineVisibility instead of isVisible on child
> component
> -
>
> Key: WICKET-1579
> URL: https://issues.apache.org/jira/browse/WICKET-1579
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.3.3
>Reporter: Rahul Pilani
>Assignee: Igor Vaynberg
>
> This problem is happening when Ajax requests are being used to update the
> visibility of child component of the Enclosure.
> Say originally we have an enclosure whose child component is not visible.
> the following code will run and set visibilityAllowed on all the components
> under the enclosure to false.
> onComponentTagBody - Line 188-198 from Enclosure.java
>
> DirectChildTagIterator it = new DirectChildTagIterator(markupStream, openTag);
> MarkupContainer controllerParent = getEnclosureParent();
> while (it.hasNext())
> {
> ComponentTag t = (ComponentTag)it.next();
> Component child = controllerParent.get(t.getId());
> if (child != null)
> {
> child.setVisibilityAllowed(isVisible());
> }
> }
>
> Then when an Ajax request sets the child component to visible,
> this is the code that checks the Enclosure's visibility:
> onComponentTagBody - Line 185 in Enclosure.java
>
> setVisible(controller.determineVisibility());
>
> which calls the component's determineVisibility() method to determine if the
> component is visibile. But, determineVisiblity not only checks isVisible(),
> but other states as well, including isVisibilityAllowed()
> determineVisibility , Line 4194 in Component.java
>
> public final boolean determineVisibility()
> {
> return isVisible() && isRenderAllowed() &&
> isVisibilityAllowed();
> }
>
> Since the setVisibilityAllowed was set by the enclosure earlier, the
> determineVisibility method is going to return false no matter what the state
> of isVisible is, hence the Enclosure will never render.
> Instead of calling determineVisibility, the enclosure should just call
> isVisible to determine whether it should render itself or not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-1891) AjaxLazyLoadPanel shouldn't call getLoadingComponent(String) in constructor
AjaxLazyLoadPanel shouldn't call getLoadingComponent(String) in constructor
---
Key: WICKET-1891
URL: https://issues.apache.org/jira/browse/WICKET-1891
Project: Wicket
Issue Type: Improvement
Components: wicket-extensions
Affects Versions: 1.4-M2
Reporter: Craig McIlwee
Priority: Minor
Fix For: 1.4-M4
Use case:
class MyPanel extends AjaxLazyLoadPanel {
private boolean bool;
public MyPanel(String id, boolean bool) {
super(id); <-- bool is used in this call
this.bool = bool; <-- but not assigned until this call
}
public getLoadingComponent(String id) {
if (bool) {
return componentA;
} else {
return componentB;
}
}
}
-
Since getLoadingComponent(String) is called as part of the super constructor
then the actual value of 'bool' can never be used. Furthur, if bool were an
object instead of a primitive could potentially cause an NPE. Instead the
loading component can be created in onBeforeRender():
protected void onBeforeRender() {
if (!renderedOnce) {
loadingComponent = getLoadingComponent("content");
add(loadingComponent.setRenderBodyOnly(true));
renderedOnce = true;
}
super.onBeforeRender();
}
... this also requires a change to the ajax behavior:
public boolean isEnabled(Component component) {
return get("content") == loadingComponent || loadingComponent == null;
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-715) rename classes and methods from *JavaScript* to *Javascript*
[ https://issues.apache.org/jira/browse/WICKET-715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604697#action_12604697 ] Craig McIlwee commented on WICKET-715: -- If you have to pick between the 2, JavaScript (capital S) is actually the correct spelling. > rename classes and methods from *JavaScript* to *Javascript* > > > Key: WICKET-715 > URL: https://issues.apache.org/jira/browse/WICKET-715 > Project: Wicket > Issue Type: Task >Affects Versions: 1.4-M1 >Reporter: Gerolf Seitz >Priority: Minor > Fix For: 1.4-M3 > > > some classes are spelled *JavaScript* and some *Javascript*. same with > methods too. > for the sake of consistency the term "Javascript" should be used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-1699) NPE in RequestLogger
NPE in RequestLogger Key: WICKET-1699 URL: https://issues.apache.org/jira/browse/WICKET-1699 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4-M2 Reporter: Craig McIlwee Fix For: 1.4-M3 RequestLogger throws an NPE at line 200 because the field 'active' is never assigned a value when the class is instantiated. In older versions (I am migrating from 1.3.3) this field was just a native int so the value would default to 0, but sometime between 1.3.3 and 1.4m2 it has changed to an AtomicInteger and never assigned a value via new AtomicInteger() or new AtomicInteger(someInt). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-1306) CLONE - Correct javadoc for Fragment
CLONE - Correct javadoc for Fragment Key: WICKET-1306 URL: https://issues.apache.org/jira/browse/WICKET-1306 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.3.0-beta4 Environment: any Reporter: Craig McIlwee Priority: Minor Fix For: 1.3.0-rc1 The Fragment constructors without markupProvider argument have been deprecated but the example in the class javadoc's is still using it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1306) CLONE - Correct javadoc for Fragment
[ https://issues.apache.org/jira/browse/WICKET-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Craig McIlwee updated WICKET-1306: -- Fix Version/s: (was: 1.3.0-rc1) 1.3.1 Description: The Fragment constructors without markupProvider argument have been deprecated but the example in the class javadoc's is still using it. CLONE: This still not reflected in the javadocs that are linked from the main project page (http://people.apache.org/~tobrien/wicket/apidocs/index.html) In addition to the example using the deprecated constructors, the constructors themselves are not marked as deprecated in the documentation. was:The Fragment constructors without markupProvider argument have been deprecated but the example in the class javadoc's is still using it. Environment: (was: any) Affects Version/s: (was: 1.3.0-beta4) 1.3.0-final Remaining Estimate: 0.25h Original Estimate: 0.25h > CLONE - Correct javadoc for Fragment > > > Key: WICKET-1306 > URL: https://issues.apache.org/jira/browse/WICKET-1306 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.3.0-final >Reporter: Craig McIlwee >Priority: Minor > Fix For: 1.3.1 > > Original Estimate: 0.25h > Remaining Estimate: 0.25h > > The Fragment constructors without markupProvider argument have been > deprecated but the example in the class javadoc's is still using it. > CLONE: > This still not reflected in the javadocs that are linked from the main > project page (http://people.apache.org/~tobrien/wicket/apidocs/index.html) > In addition to the example using the deprecated constructors, the > constructors themselves are not marked as deprecated in the documentation. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1206) Change BaseWicketTester.getTagByXXX return value from TagTester to TagTester[]
[ https://issues.apache.org/jira/browse/WICKET-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Craig McIlwee updated WICKET-1206: -- Attachment: MultipleTagTester.java This may help... Shortly after posting this issue I created a class to do what I needed. It's basically just a copy of the createTagsByAttribute method with a few changes to get all tags. I imagine you can probably just copy/paste this into the TagTester class. > Change BaseWicketTester.getTagByXXX return value from TagTester to TagTester[] > -- > > Key: WICKET-1206 > URL: https://issues.apache.org/jira/browse/WICKET-1206 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.3.0-rc1 >Reporter: Craig McIlwee >Assignee: Frank Bille Jensen >Priority: Minor > Fix For: 1.4.0-M1 > > Attachments: MultipleTagTester.java > > > When using the org.apache.wicket.markup.repeater.data.DataView, each row in > the table has the same wicket:id. I am trying to use the TagTester to ensure > that each tag has the correct attributes, in this case class="odd" and > class="even". Since getTagByWicketId and getTagById only return a single > TagTester, a tester for the same markup tag is returned each time, making it > impossible to test any row other than the first. > Example HTML output: > > <- TagTester returned is > always for this tag > > > > > > > > > > > Proposed solution: change the return value to TagTester[] so that one call > will return all of the tags with that wicket:id -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-1206) Change BaseWicketTester.getTagByXXX return value from TagTester to TagTester[]
Change BaseWicketTester.getTagByXXX return value from TagTester to TagTester[] -- Key: WICKET-1206 URL: https://issues.apache.org/jira/browse/WICKET-1206 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.3.0-rc1 Reporter: Craig McIlwee Priority: Minor Fix For: 1.4.0-alpha When using the org.apache.wicket.markup.repeater.data.DataView, each row in the table has the same wicket:id. I am trying to use the TagTester to ensure that each tag has the correct attributes, in this case class="odd" and class="even". Since getTagByWicketId and getTagById only return a single TagTester, a tester for the same markup tag is returned each time, making it impossible to test any row other than the first. Example HTML output: <- TagTester returned is always for this tag Proposed solution: change the return value to TagTester[] so that one call will return all of the tags with that wicket:id -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
