[jira] Created: (WICKET-3139) Fix comments for Form.process() to be consistent with method declaration
Fix comments for Form.process() to be consistent with method declaration
Key: WICKET-3139
URL: https://issues.apache.org/jira/browse/WICKET-3139
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.5-M2.1
Environment: All
Reporter: Daniel Toffetti
Priority: Trivial
/**
* Process the form. Though you can override this method to provide
your whole own algorithm, it
* is not recommended to do so.
*
* See the class documentation for further details on the form
processing
*
*
* @return False if the form had an error
*/
private boolean process()
{
The comment for Form.process() states "you can override" when in fact the
method is declared private. This is most likely caused by the method being
public previously. Either make it protected, or change the comment. Also
compare to this other method in Form which is public and overridable:
public void process(IFormSubmittingComponent submittingComponent)
{
And lastly, please provide some help in the Migration Guide for those who
used to override it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2816) Refactor / rework pageability
Refactor / rework pageability - Key: WICKET-2816 URL: https://issues.apache.org/jira/browse/WICKET-2816 Project: Wicket Issue Type: Improvement Components: wicket, wicket-extensions Affects Versions: 1.4.7, 1.5-M1 Environment: All Reporter: Daniel Toffetti I need to add a NavigatorLabel to a GridView, now NavigatorLabel has constructors accepting DataTable, DataView and PageableListView but not a GridView. Instead of creating a new constructor accepting a GridView, I think it would be far better to merge IPageable and the private NavigatorLabel.PageableComponent into a single public interface and making all pageable components implement this interface. I understand this approach breaks APIs and will need one major version, maybe two allowing for deprecations in between. A less breaking alternative (but not as good in my opinion) is to change the constructor accepting a DataView to make it accept an AbstractPageableView, which is a common ancestor of both DataView and GridView and defines the methods needed to satisfy NavigatorLabel.PageableComponent. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2152) AbstractAjaxTimerBehavior is stoppable, would be nice to have it restartable
[
https://issues.apache.org/jira/browse/WICKET-2152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680041#action_12680041
]
Daniel Toffetti commented on WICKET-2152:
-
Oops, this seems to be a dupe of:
https://issues.apache.org/jira/browse/WICKET-1525
Sorry.
> AbstractAjaxTimerBehavior is stoppable, would be nice to have it restartable
>
>
> Key: WICKET-2152
> URL: https://issues.apache.org/jira/browse/WICKET-2152
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
>Affects Versions: 1.3.5, 1.4-M3, 1.5-M1
> Environment: All
>Reporter: Daniel Toffetti
>Priority: Trivial
> Fix For: 1.5-M1
>
>
> My use case is: I have a page with an AjaxSelfUpdatingTimerBehavior and a
> button that opens a modal window. If the modal window is opened and the timer
> fires the refresh, the browser ask for a confirmation to leave the page, and
> then closes the modal window.
> It would be very nice to be able to stop the self updating behavior just
> before opening the modal window, and restarting it just before closing it.
> This feature has already been requested long ago in SourceForge tracker, see:
> http://www.nabble.com/forum/ViewPost.jtp?post=5773807&framed=y, but couldn't
> find it in JIRA.
> To overcome this problem, I created a custom (AbstractAjax +
> AjaxSelfUpdating)TimerBehavior, and added this method:
> /**
>* Starts the timer
>*/
> public final void start(final AjaxRequestTarget target)
> {
> stopped = false;
> target.getHeaderResponse().renderOnLoadJavascript(
>
> getJsTimeoutCall(updateInterval));
> }
> And changed (this might not be important, I'm not sure but this works for me):
> /**
>*
>* @see
> org.apache.wicket.ajax.AbstractDefaultAjaxBehavior#respond(org.apache.wicket.ajax.AjaxRequestTarget)
>*/
> protected final void respond(final AjaxRequestTarget target)
> {
> onTimer(target);
> if (!stopped) {
> target.getHeaderResponse().renderOnLoadJavascript(
>
> getJsTimeoutCall(updateInterval));
> }
> }
> to:
> /**
>*
>* @see
> org.apache.wicket.ajax.AbstractDefaultAjaxBehavior#respond(org.apache.wicket.ajax.AjaxRequestTarget)
>*/
> protected final void respond(final AjaxRequestTarget target)
> {
> if (!stopped) {
> onTimer(target);
> target.getHeaderResponse().renderOnLoadJavascript(
>
> getJsTimeoutCall(updateInterval));
> }
> }
> Then in the onClick of the button that opens the modal window, I call;
> @Override
> public void onClick(AjaxRequestTarget target) {
> autoRefreshBehavior.stop();
> //---
> and in the onClose of the modal window:
> @Override
> public void onClose(AjaxRequestTarget target) {
> //---
> autoRefreshBehavior.start(target);
> }
> It's working fine so far, but it would be nice to have this little feature or
> something similar provided in core.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2033) & instead of & in javascript
[
https://issues.apache.org/jira/browse/WICKET-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680036#action_12680036
]
Daniel Toffetti commented on WICKET-2033:
-
Perhaps it has something to do with this:
https://issues.apache.org/jira/browse/WICKET-2131 ???
> & instead of & in javascript
>
>
> Key: WICKET-2033
> URL: https://issues.apache.org/jira/browse/WICKET-2033
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 1.4-RC1
> Environment: all
>Reporter: Tuomas Karkkainen
>Assignee: Johan Compagner
>Priority: Minor
> Fix For: 1.4-RC3
>
> Attachments: wicket-2033-quickstart.zip
>
>
> the non httpsessionstore part of:
> https://issues.apache.org/jira/browse/WICKET-1971
> is that
> in the
> wicket:ignoreIfNotActive actually becomes
> amp;wicket:ignoreIfNotActive=true
> in:
> protected CharSequence encode(RequestCycle requestCycle,
> IListenerInterfaceRequestTarget requestTarget)
> of WebRequestCodingStrategy on the line:
> url.append(url.indexOf("?") > -1 ? "&" :
> "?").append(
>
> IGNORE_IF_NOT_ACTIVE_PARAMETER_NAME).append("=true");
> so when this happens in
> public final RequestParameters decode(final Request request) {
> ---
> if (request.getParameter(IGNORE_IF_NOT_ACTIVE_PARAMETER_NAME)
> != null)
> {
> parameters.setOnlyProcessIfPathActive(true);
> }
> ---
> this never actually happens.
> then if you have a throttle, ajaxlazyloadpanel etc with
> onlyprocessifpathactive set to true, and you logout, but go to another wicket
> page, then the original session is destroyed and a new one is created
> if this is worked around in the way the guys on WICKET-1971 suggest,
> WebRequestCycleProcessor
> method
> public IRequestTarget resolve(final RequestCycle requestCycle,
> final RequestParameters requestParameters)
> if
> (requestParameters.isOnlyProcessIfPathActive())
> last branch falls through:
> else
> {
> // TODO also this should work..
> }
> and it throws PageExpiredException because the request
> component/page/behavior does not exist in this new session. even though
> onlyprocessifpathactive was set to true, and it's purpose is precisely to
> avoid pageexpiredexception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2152) AbstractAjaxTimerBehavior is stoppable, would be nice to have it restartable
AbstractAjaxTimerBehavior is stoppable, would be nice to have it restartable
Key: WICKET-2152
URL: https://issues.apache.org/jira/browse/WICKET-2152
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.4-M3, 1.3.5, 1.5-M1
Environment: All
Reporter: Daniel Toffetti
Priority: Trivial
Fix For: 1.5-M1
My use case is: I have a page with an AjaxSelfUpdatingTimerBehavior and a
button that opens a modal window. If the modal window is opened and the timer
fires the refresh, the browser ask for a confirmation to leave the page, and
then closes the modal window.
It would be very nice to be able to stop the self updating behavior just before
opening the modal window, and restarting it just before closing it. This
feature has already been requested long ago in SourceForge tracker, see:
http://www.nabble.com/forum/ViewPost.jtp?post=5773807&framed=y, but couldn't
find it in JIRA.
To overcome this problem, I created a custom (AbstractAjax +
AjaxSelfUpdating)TimerBehavior, and added this method:
/**
* Starts the timer
*/
public final void start(final AjaxRequestTarget target)
{
stopped = false;
target.getHeaderResponse().renderOnLoadJavascript(
getJsTimeoutCall(updateInterval));
}
And changed (this might not be important, I'm not sure but this works for me):
/**
*
* @see
org.apache.wicket.ajax.AbstractDefaultAjaxBehavior#respond(org.apache.wicket.ajax.AjaxRequestTarget)
*/
protected final void respond(final AjaxRequestTarget target)
{
onTimer(target);
if (!stopped) {
target.getHeaderResponse().renderOnLoadJavascript(
getJsTimeoutCall(updateInterval));
}
}
to:
/**
*
* @see
org.apache.wicket.ajax.AbstractDefaultAjaxBehavior#respond(org.apache.wicket.ajax.AjaxRequestTarget)
*/
protected final void respond(final AjaxRequestTarget target)
{
if (!stopped) {
onTimer(target);
target.getHeaderResponse().renderOnLoadJavascript(
getJsTimeoutCall(updateInterval));
}
}
Then in the onClick of the button that opens the modal window, I call;
@Override
public void onClick(AjaxRequestTarget target) {
autoRefreshBehavior.stop();
//---
and in the onClose of the modal window:
@Override
public void onClose(AjaxRequestTarget target) {
//---
autoRefreshBehavior.start(target);
}
It's working fine so far, but it would be nice to have this little feature or
something similar provided in core.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-1668) Application_es.properties (added translations)
Application_es.properties (added translations)
--
Key: WICKET-1668
URL: https://issues.apache.org/jira/browse/WICKET-1668
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.4-M1, 1.3.3
Environment: All
Reporter: Daniel Toffetti
Priority: Trivial
Fix For: 1.3.4, 1.4-M2, 1.4-M3
Add this to Application_es.properties (in line 21, after
NumberValidator.maximum=):
NumberValidator.positive='${input}' debe ser positivo.
NumberValidator.negative='${input}' debe ser negativo.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-1318) NavigatorLabel should be localizable
NavigatorLabel should be localizable
Key: WICKET-1318
URL: https://issues.apache.org/jira/browse/WICKET-1318
Project: Wicket
Issue Type: Improvement
Components: wicket, wicket-extensions
Affects Versions: 1.3.0-final, 1.3.1, 1.3.2
Environment: All
Reporter: Daniel Toffetti
Priority: Trivial
Fix For: 1.3.1, 1.3.2, 1.3.0-final
In
org\apache\wicket\extensions\markup\html\repeater\data\table\NavigatorLabel.java:
private NavigatorLabel(final String id, final PageableComponent table)
{
super(id);
setModel(new StringResourceModel("NavigatorLabel", this, new
Model(new LabelModelObject(
table)), "Showing ${from} to ${to} of ${of}"));
}
The message "Showing x to y of z" is hardcoded, it should be extracted to a
.properties file in order to allow for localization of the message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1309) Properties files translation (_es)
[
https://issues.apache.org/jira/browse/WICKET-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Toffetti updated WICKET-1309:
Attachment: Wizard_es.properties
> Properties files translation (_es)
> --
>
> Key: WICKET-1309
> URL: https://issues.apache.org/jira/browse/WICKET-1309
> Project: Wicket
> Issue Type: Improvement
> Components: wicket, wicket-extensions
>Affects Versions: 1.3.1, 1.4-M3
> Environment: All
>Reporter: Daniel Toffetti
>Priority: Trivial
> Fix For: 1.3.1, 1.4-M3
>
> Attachments: RatingPanel_es.properties, Wizard_es.properties
>
>
> Attached two files, RatingPanel_es.properties and Wizard_es.properties.
> Also this minor fix in org.apache.wicket.Application_es.properties, line 25
> reads:
> StringValidator.exact=StringValidator.exact='${input}' debe tener
> exactamente ${exact} caracteres.
> and should read:
> StringValidator.exact='${input}' debe tener exactamente ${exact}
> caracteres.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-1309) Properties files translation (_es)
Properties files translation (_es)
--
Key: WICKET-1309
URL: https://issues.apache.org/jira/browse/WICKET-1309
Project: Wicket
Issue Type: Improvement
Components: wicket, wicket-extensions
Affects Versions: 1.3.1, 1.4-M3
Environment: All
Reporter: Daniel Toffetti
Priority: Trivial
Fix For: 1.3.1, 1.4-M3
Attachments: RatingPanel_es.properties
Attached two files, RatingPanel_es.properties and Wizard_es.properties.
Also this minor fix in org.apache.wicket.Application_es.properties, line 25
reads:
StringValidator.exact=StringValidator.exact='${input}' debe tener
exactamente ${exact} caracteres.
and should read:
StringValidator.exact='${input}' debe tener exactamente ${exact} caracteres.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1309) Properties files translation (_es)
[
https://issues.apache.org/jira/browse/WICKET-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Toffetti updated WICKET-1309:
Attachment: RatingPanel_es.properties
> Properties files translation (_es)
> --
>
> Key: WICKET-1309
> URL: https://issues.apache.org/jira/browse/WICKET-1309
> Project: Wicket
> Issue Type: Improvement
> Components: wicket, wicket-extensions
>Affects Versions: 1.3.1, 1.4-M3
> Environment: All
>Reporter: Daniel Toffetti
>Priority: Trivial
> Fix For: 1.3.1, 1.4-M3
>
> Attachments: RatingPanel_es.properties
>
>
> Attached two files, RatingPanel_es.properties and Wizard_es.properties.
> Also this minor fix in org.apache.wicket.Application_es.properties, line 25
> reads:
> StringValidator.exact=StringValidator.exact='${input}' debe tener
> exactamente ${exact} caracteres.
> and should read:
> StringValidator.exact='${input}' debe tener exactamente ${exact}
> caracteres.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1147) Application_es.properties patch
[ https://issues.apache.org/jira/browse/WICKET-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Toffetti updated WICKET-1147: Attachment: App_es_props.patch > Application_es.properties patch > --- > > Key: WICKET-1147 > URL: https://issues.apache.org/jira/browse/WICKET-1147 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 1.3.0-rc1 > Environment: All >Reporter: Daniel Toffetti >Priority: Trivial > Attachments: App_es_props.patch > > > Patch for Application_es.properties > - Fixes minor spelling error, capitalisation and accented vowels. > - Adds credit card number validator translated string -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-1147) Application_es.properties patch
Application_es.properties patch --- Key: WICKET-1147 URL: https://issues.apache.org/jira/browse/WICKET-1147 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.3.0-rc1 Environment: All Reporter: Daniel Toffetti Priority: Trivial Patch for Application_es.properties - Fixes minor spelling error, capitalisation and accented vowels. - Adds credit card number validator translated string -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
