[jira] Commented: (WICKET-2684) Provide a way to disable Child component has a non-safe child id
[ https://issues.apache.org/jira/browse/WICKET-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12804035#action_12804035 ] Marat Radchenko commented on WICKET-2684: - the index is translated into the model which is in turn translated into the PK Translate 1-3 numbers into ann, john, peter, please. Also, don't forget that after you initially loaded a stateless page with user list (but before you clicked on a link inside repeater), bob registered. or do all wicket apps out there suffer from concurrency issues where pressing a delete button deletes the wrong thing? All that do not use persistent object primary key as repeater child id. Provide a way to disable Child component has a non-safe child id --- Key: WICKET-2684 URL: https://issues.apache.org/jira/browse/WICKET-2684 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.4.5 Reporter: Marat Radchenko Assignee: Igor Vaynberg AbstractRepeater.onBeforeRender checks child component ids to be digit-only. While i (kinda) understand reasoning behind this behavior, it is sometimes not what i want. One of examples is user list with login acting as primary key on a stateless page. Relying on index is fragile because users can be added/deleted by other requests, so i want to use user login as repeater child ids, however it triggers warning. That check should be either disableable globally or on per-component basis (latter is more desired), so I can tell AbstractRepeater that i know what i'm doing and deliberately want non-numeric ids. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2684) Provide a way to disable Child component has a non-safe child id
[ https://issues.apache.org/jira/browse/WICKET-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12804039#action_12804039 ] Marat Radchenko commented on WICKET-2684: - 404 is acceptable behavior on the web because you always see outdated page (as it was when it was rendered). However, deleting wrong entries isn't acceptable. After all, it's not wicket business what ids i assign to my components (and actually nothing in wicket depends on them being numeric). Provide a way to disable Child component has a non-safe child id --- Key: WICKET-2684 URL: https://issues.apache.org/jira/browse/WICKET-2684 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.4.5 Reporter: Marat Radchenko Assignee: Igor Vaynberg AbstractRepeater.onBeforeRender checks child component ids to be digit-only. While i (kinda) understand reasoning behind this behavior, it is sometimes not what i want. One of examples is user list with login acting as primary key on a stateless page. Relying on index is fragile because users can be added/deleted by other requests, so i want to use user login as repeater child ids, however it triggers warning. That check should be either disableable globally or on per-component basis (latter is more desired), so I can tell AbstractRepeater that i know what i'm doing and deliberately want non-numeric ids. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2684) Provide a way to disable Child component has a non-safe child id
[ https://issues.apache.org/jira/browse/WICKET-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12804058#action_12804058 ] Marat Radchenko commented on WICKET-2684: - or use a low-level repeater where you have total control - RepeatingView Great! We finally got to the point :) RepeatingView is _subclass of AbstractRepeater_ whose onBeforeRender is producing warning! Provide a way to disable Child component has a non-safe child id --- Key: WICKET-2684 URL: https://issues.apache.org/jira/browse/WICKET-2684 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.4.5 Reporter: Marat Radchenko Assignee: Igor Vaynberg AbstractRepeater.onBeforeRender checks child component ids to be digit-only. While i (kinda) understand reasoning behind this behavior, it is sometimes not what i want. One of examples is user list with login acting as primary key on a stateless page. Relying on index is fragile because users can be added/deleted by other requests, so i want to use user login as repeater child ids, however it triggers warning. That check should be either disableable globally or on per-component basis (latter is more desired), so I can tell AbstractRepeater that i know what i'm doing and deliberately want non-numeric ids. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2684) Provide a way to disable Child component has a non-safe child id
[
https://issues.apache.org/jira/browse/WICKET-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12804130#action_12804130
]
Marat Radchenko commented on WICKET-2684:
-
I don't ask to remove that check. I ask to provide a way to suppress it for
particular component.
Like, protected boolean warnIfNonNumericChild() { return true; }
Provide a way to disable Child component has a non-safe child id
---
Key: WICKET-2684
URL: https://issues.apache.org/jira/browse/WICKET-2684
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.4.5
Reporter: Marat Radchenko
Assignee: Igor Vaynberg
AbstractRepeater.onBeforeRender checks child component ids to be digit-only.
While i (kinda) understand reasoning behind this behavior, it is sometimes
not what i want.
One of examples is user list with login acting as primary key on a stateless
page. Relying on index is fragile because users can be added/deleted by other
requests, so i want to use user login as repeater child ids, however it
triggers warning.
That check should be either disableable globally or on per-component basis
(latter is more desired), so I can tell AbstractRepeater that i know what i'm
doing and deliberately want non-numeric ids.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2684) Provide a way to disable Child component has a non-safe child id
[ https://issues.apache.org/jira/browse/WICKET-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12803660#action_12803660 ] Marat Radchenko commented on WICKET-2684: - how is that fragile? From issue description: Relying on index is fragile because users can be added/deleted by other requests. I can't guarantee that link with particular index will refer to same user when page is initially rendered and when it is submitted. Provide a way to disable Child component has a non-safe child id --- Key: WICKET-2684 URL: https://issues.apache.org/jira/browse/WICKET-2684 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.4.5 Reporter: Marat Radchenko Assignee: Igor Vaynberg AbstractRepeater.onBeforeRender checks child component ids to be digit-only. While i (kinda) understand reasoning behind this behavior, it is sometimes not what i want. One of examples is user list with login acting as primary key on a stateless page. Relying on index is fragile because users can be added/deleted by other requests, so i want to use user login as repeater child ids, however it triggers warning. That check should be either disableable globally or on per-component basis (latter is more desired), so I can tell AbstractRepeater that i know what i'm doing and deliberately want non-numeric ids. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2684) Provide a way to disable Child component has a non-safe child id
Provide a way to disable Child component has a non-safe child id --- Key: WICKET-2684 URL: https://issues.apache.org/jira/browse/WICKET-2684 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.4.5 Reporter: Marat Radchenko AbstractRepeater.onBeforeRender checks child component ids to be digit-only. While i (kinda) understand reasoning behind this behavior, it is sometimes not what i want. One of examples is user list with login acting as primary key on a stateless page. Relying on index is fragile because users can be added/deleted by other requests, so i want to use user login as repeater child ids, however it triggers warning. That check should be either disableable globally or on per-component basis (latter is more desired), so I can tell AbstractRepeater that i know what i'm doing and deliberately want non-numeric ids. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2672) FormComponent doesn't properly handle array model types
FormComponent doesn't properly handle array model types --- Key: WICKET-2672 URL: https://issues.apache.org/jira/browse/WICKET-2672 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.5 Reporter: Marat Radchenko Attachments: FormComponentTest.java FormComponent doesn't properly handle array model types. Testcase attached. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2672) FormComponent doesn't properly handle array model types
[ https://issues.apache.org/jira/browse/WICKET-2672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marat Radchenko updated WICKET-2672: Attachment: FormComponentTest.java FormComponent doesn't properly handle array model types --- Key: WICKET-2672 URL: https://issues.apache.org/jira/browse/WICKET-2672 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.5 Reporter: Marat Radchenko Attachments: FormComponentTest.java FormComponent doesn't properly handle array model types. Testcase attached. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2648) DatePicker javascript uses 4 symbols for year although pattern contains just yy
DatePicker javascript uses 4 symbols for year although pattern contains just yy --- Key: WICKET-2648 URL: https://issues.apache.org/jira/browse/WICKET-2648 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.5 Reporter: Marat Radchenko Steps to reproduce: 1. Create TextField 2. Add DatePicker with yy for year (en_US locale, SHORT format, for example). 3. Set some date to textfield 4. Open page (year is correctly shown with two digits) 5. Click datepicker icon Expected: year is still 2-digit Actual: year becomes 4-digit -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2648) DatePicker javascript uses 4 symbols for year although pattern contains just yy
[ https://issues.apache.org/jira/browse/WICKET-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marat Radchenko updated WICKET-2648: Component/s: (was: wicket) wicket-extensions DatePicker javascript uses 4 symbols for year although pattern contains just yy --- Key: WICKET-2648 URL: https://issues.apache.org/jira/browse/WICKET-2648 Project: Wicket Issue Type: Bug Components: wicket-extensions Affects Versions: 1.4.5 Reporter: Marat Radchenko Steps to reproduce: 1. Create TextField 2. Add DatePicker with yy for year (en_US locale, SHORT format, for example). 3. Set some date to textfield 4. Open page (year is correctly shown with two digits) 5. Click datepicker icon Expected: year is still 2-digit Actual: year becomes 4-digit -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2651) NPE on InspectorPage (devutils)
NPE on InspectorPage (devutils) --- Key: WICKET-2651 URL: https://issues.apache.org/jira/browse/WICKET-2651 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.5 Reporter: Marat Radchenko Steps to reproduce: 1. Open InspectorPage 2. Press and hold F5. Expected: page happily reloads Actual: page reloads, but sometimes NPE happens. Stacktrace: SEVERE: Error attaching this container for rendering: [MarkupContainer [Component id = pagemap]] org.apache.wicket.WicketRuntimeException: Error attaching this container for rendering: [MarkupContainer [Component id = pagemap]] at org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1739) at org.apache.wicket.Component.onBeforeRender(Component.java:3855) at org.apache.wicket.devutils.DevUtilsPanel.onBeforeRender(DevUtilsPanel.java:43) at org.apache.wicket.Component.internalBeforeRender(Component.java:1061) at org.apache.wicket.Component.beforeRender(Component.java:1095) at org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1727) at org.apache.wicket.Component.onBeforeRender(Component.java:3855) at org.apache.wicket.Component.internalBeforeRender(Component.java:1061) at org.apache.wicket.Component.beforeRender(Component.java:1095) at org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1727) at org.apache.wicket.Component.onBeforeRender(Component.java:3855) at org.apache.wicket.markup.repeater.AbstractRepeater.onBeforeRender(AbstractRepeater.java:151) at org.apache.wicket.Component.internalBeforeRender(Component.java:1061) at org.apache.wicket.Component.beforeRender(Component.java:1095) at org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1727) at org.apache.wicket.Component.onBeforeRender(Component.java:3855) at org.apache.wicket.devutils.DevUtilsPanel.onBeforeRender(DevUtilsPanel.java:43) at org.apache.wicket.Component.internalBeforeRender(Component.java:1061) at org.apache.wicket.Component.beforeRender(Component.java:1095) at org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1727) at org.apache.wicket.Component.onBeforeRender(Component.java:3855) at org.apache.wicket.Page.onBeforeRender(Page.java:1501) at org.apache.wicket.devutils.DevUtilsPage.onBeforeRender(DevUtilsPage.java:71) at org.apache.wicket.Component.internalBeforeRender(Component.java:1061) at org.apache.wicket.Component.beforeRender(Component.java:1095) at org.apache.wicket.Component.prepareForRender(Component.java:2225) at org.apache.wicket.Component.prepareForRender(Component.java:2262) at org.apache.wicket.Page.renderPage(Page.java:893) at org.apache.wicket.request.target.component.BookmarkablePageRequestTarget.respond(BookmarkablePageRequestTarget.java:261) at org.apache.wicket.request.AbstractRequestCycleProcessor.respond(AbstractRequestCycleProcessor.java:105) at ru.kctsoft.taro.web.TransactionalRequestCycleProcessor.respond(TransactionalRequestCycleProcessor.java:22) at sun.reflect.GeneratedMethodAccessor17.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:307) at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:182) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:149) at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:106) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171) at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204) at $Proxy42.respond(Unknown Source) at org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1258) at org.apache.wicket.RequestCycle.step(RequestCycle.java:1329) at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1428) at org.apache.wicket.RequestCycle.request(RequestCycle.java:545) at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:479) at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:312) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157) at
[jira] Created: (WICKET-2652) LiveSessionsPage (devutils) leaks memory
LiveSessionsPage (devutils) leaks memory Key: WICKET-2652 URL: https://issues.apache.org/jira/browse/WICKET-2652 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.5 Reporter: Marat Radchenko Steps to reproduce: 1. Open LiveSessionsPage 2. Click Enable request recording 3. Click Disable request recording 4. Refresh page several times and observe session growth. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2653) Make GoAndClearFilter.defaultClearModel and GoFilter.defaultGoModel internationalizable
Make GoAndClearFilter.defaultClearModel and GoFilter.defaultGoModel internationalizable --- Key: WICKET-2653 URL: https://issues.apache.org/jira/browse/WICKET-2653 Project: Wicket Issue Type: Improvement Components: wicket-extensions Affects Versions: 1.4.5 Reporter: Marat Radchenko Priority: Trivial Please, change GoAndClearFilter.defaultClearModel and GoFilter.defaultGoModel to ResourceModel with default string (same way as it is done in NoRecordsToolbar.DEFAULT_MESSAGE_MODEL). That'll allow translating button labels without the need to pass custom models. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2654) Make GoAndClearFilter optionally accept ISortStateLocator and reset it when Clear button is clicked
Make GoAndClearFilter optionally accept ISortStateLocator and reset it when Clear button is clicked --- Key: WICKET-2654 URL: https://issues.apache.org/jira/browse/WICKET-2654 Project: Wicket Issue Type: Improvement Components: wicket-extensions Affects Versions: 1.4.5 Reporter: Marat Radchenko Priority: Minor Please, make GoAndClearFilter optionally accept ISortStateLocator and reset it when Clear button is clicked (the same way it currently handles sort state, via cloning original model) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2646) Better error reporting from StatelessChecker
Better error reporting from StatelessChecker Key: WICKET-2646 URL: https://issues.apache.org/jira/browse/WICKET-2646 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.4.5 Reporter: Marat Radchenko Improvement for error messages from StatelessChecker: replace throw new IllegalArgumentException(msg + Offending component: + o); with throw new IllegalArgumentException(msg + Offending component: + ((Component)o)toString(true); Reasoning: Current message contains Component.toString(false) output that doesn't contain component path, thus making it harder to identify which component is to blame. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2646) Better error reporting from StatelessChecker
[ https://issues.apache.org/jira/browse/WICKET-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marat Radchenko updated WICKET-2646: Description: Improvement for error messages from StatelessChecker: replace throw new IllegalArgumentException(msg + Offending component: + o); with throw new IllegalArgumentException(msg + Offending component: + ((Component)o)toString(true)); Reasoning: Current message contains Component.toString(false) output that doesn't contain component path, thus making it harder to identify which component is to blame. was: Improvement for error messages from StatelessChecker: replace throw new IllegalArgumentException(msg + Offending component: + o); with throw new IllegalArgumentException(msg + Offending component: + ((Component)o)toString(true); Reasoning: Current message contains Component.toString(false) output that doesn't contain component path, thus making it harder to identify which component is to blame. Better error reporting from StatelessChecker Key: WICKET-2646 URL: https://issues.apache.org/jira/browse/WICKET-2646 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.4.5 Reporter: Marat Radchenko Improvement for error messages from StatelessChecker: replace throw new IllegalArgumentException(msg + Offending component: + o); with throw new IllegalArgumentException(msg + Offending component: + ((Component)o)toString(true)); Reasoning: Current message contains Component.toString(false) output that doesn't contain component path, thus making it harder to identify which component is to blame. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2647) InspectorPage (from devutils) is stateful for no valid reason
InspectorPage (from devutils) is stateful for no valid reason - Key: WICKET-2647 URL: https://issues.apache.org/jira/browse/WICKET-2647 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.5 Reporter: Marat Radchenko The only reason InspectorPage is stateful is new Image(bug). If it is replaced new Image(bug, new ResourceReference(InspectorPage.class, bug.png)), then InspectorPage becomes stateless. I already raised an issue (WICKET-1340) on empty image that finds resource from markup being stateful, but was told that it is desired behavior. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2641) EnumLabel misbehaves with anonymous enum
EnumLabel misbehaves with anonymous enum
Key: WICKET-2641
URL: https://issues.apache.org/jira/browse/WICKET-2641
Project: Wicket
Issue Type: Bug
Affects Versions: 1.4.5
Reporter: Marat Radchenko
Same problem as was with EnumChoiceRenderer (see WICKET-2609)
protected String resourceKey(T value)
{
return value.getClass().getSimpleName() + . + value.name();
}
should be changed to:
protected String resourceKey(T value)
{
return value.getDeclaringClass().getSimpleName() + . + value.name();
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2641) EnumLabel misbehaves with anonymous enum
[
https://issues.apache.org/jira/browse/WICKET-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marat Radchenko updated WICKET-2641:
Component/s: wicket
EnumLabel misbehaves with anonymous enum
Key: WICKET-2641
URL: https://issues.apache.org/jira/browse/WICKET-2641
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4.5
Reporter: Marat Radchenko
Same problem as was with EnumChoiceRenderer (see WICKET-2609)
protected String resourceKey(T value)
{
return value.getClass().getSimpleName() + . + value.name();
}
should be changed to:
protected String resourceKey(T value)
{
return value.getDeclaringClass().getSimpleName() + . + value.name();
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2642) Russian translation of SignInPage/SignInPanel
Russian translation of SignInPage/SignInPanel - Key: WICKET-2642 URL: https://issues.apache.org/jira/browse/WICKET-2642 Project: Wicket Issue Type: Improvement Components: wicket-auth-roles Affects Versions: 1.4.5 Reporter: Marat Radchenko See attachements. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2638) Form.isMultipart() doesn't check FormComponent.isMultipart() on nested components
Form.isMultipart() doesn't check FormComponent.isMultipart() on nested components - Key: WICKET-2638 URL: https://issues.apache.org/jira/browse/WICKET-2638 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.5 Reporter: Marat Radchenko Form.isMultipart() doesn't check FormComponent.isMultipart() on nested components. This breaks submitting of stateless forms with multipart FormComponent but no explicit Form.setMultipart(true) call. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-2634) WicketTester doesn't handle multiple RestartResponseExceptions.
[ https://issues.apache.org/jira/browse/WICKET-2634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marat Radchenko closed WICKET-2634. --- Resolution: Duplicate Oh, didn't see that dupe. WicketTester doesn't handle multiple RestartResponseExceptions. --- Key: WICKET-2634 URL: https://issues.apache.org/jira/browse/WICKET-2634 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.5 Reporter: Marat Radchenko Priority: Minor Attachments: RestartResponseTest.java WicketTester doesn't handle multiple RestartResponseExceptions because it doesn't use the same loop pattern as RequestCycle.steps(). Testcase attached. Low priority, i workarounded it in my app. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2502) WicketTester cannot handle consecutive RestartResponseException's
[ https://issues.apache.org/jira/browse/WICKET-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12794379#action_12794379 ] Marat Radchenko commented on WICKET-2502: - One more testcase in WICKET-2634. WicketTester cannot handle consecutive RestartResponseException's - Key: WICKET-2502 URL: https://issues.apache.org/jira/browse/WICKET-2502 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4-RC7 Reporter: Martin Makundi Priority: Minor Attachments: Wicket-Quickstart.zip Original Estimate: 5h Remaining Estimate: 5h See attached quickstart junit test. WicketTester crashes (seizes from running the tests) if there eare consecutive RestartResponseException's. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2639) More pages missing xml prolog
More pages missing xml prolog - Key: WICKET-2639 URL: https://issues.apache.org/jira/browse/WICKET-2639 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.5 Reporter: Marat Radchenko InternalErrorPage.html ExceptionErrorPage.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2591) Allow subclasses of AuthenticatedWebSession to set signedIn field
[ https://issues.apache.org/jira/browse/WICKET-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12793982#action_12793982 ] Marat Radchenko commented on WICKET-2591: - Err... public?! I thought protected access would be enough (and if it isn't for someone, he can always add public method to his WebSession and call signIn from it). Allow subclasses of AuthenticatedWebSession to set signedIn field --- Key: WICKET-2591 URL: https://issues.apache.org/jira/browse/WICKET-2591 Project: Wicket Issue Type: Improvement Components: wicket-auth-roles Affects Versions: 1.4.3 Reporter: Marat Radchenko Assignee: Juergen Donnerstag Fix For: 1.4.6, 1.5-M1 My app implements remember me service by setting cookie in authenticate method of custom session that subclasses AuthenticatedWebSession. In order to automatically login user if cookie present, i need to set signedIn field to true when session is created, however it isn't possible since signedIn is private and no way to set it is available. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2634) WicketTester doesn't handle multiple RestartResponseExceptions.
[ https://issues.apache.org/jira/browse/WICKET-2634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marat Radchenko updated WICKET-2634: Attachment: RestartResponseTest.java WicketTester doesn't handle multiple RestartResponseExceptions. --- Key: WICKET-2634 URL: https://issues.apache.org/jira/browse/WICKET-2634 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.5 Reporter: Marat Radchenko Priority: Minor Attachments: RestartResponseTest.java WicketTester doesn't handle multiple RestartResponseExceptions because it doesn't use the same loop pattern as RequestCycle.steps(). Testcase attached. Low priority, i workarounded it in my app. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2635) Sucessfull login on SignInPanel causes HomePage to become stateful
Sucessfull login on SignInPanel causes HomePage to become stateful
--
Key: WICKET-2635
URL: https://issues.apache.org/jira/browse/WICKET-2635
Project: Wicket
Issue Type: Bug
Components: wicket-auth-roles
Affects Versions: 1.4.5
Reporter: Marat Radchenko
Attachments: 2635.tar.gz
Quickstart attached.
Steps to reproduce
1. Unpack attached quickstart
2. mvn jetty:run
3. Open http://localhost:8080/login
4. Enter any credentials
Expected: StatelessHomePage opens
Actual: exception happends, StatelessHomePage isn't stateless
Problem analysis:
1. SignInForm manually creates page.
2. AbstractListenerInterfaceRequestTarget.onProcessEvents calls
requestCycle.setRedirect(true)
3. RequestCycle.urlFor(final Component component, final
RequestListenerInterface listener, ValueMap params) calls
page.setPageStateless(Boolean.FALSE)
4. StatelessChecker isn't happy.
Fix is simple - SignInForm.onSignInSucceeded should be:
if (!continueToOriginalDestination())
{
setResponsePage(getApplication().getHomePage());
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2635) Sucessfull login on SignInPanel causes HomePage to become stateful
[
https://issues.apache.org/jira/browse/WICKET-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marat Radchenko updated WICKET-2635:
Attachment: 2635.tar.gz
Sucessfull login on SignInPanel causes HomePage to become stateful
--
Key: WICKET-2635
URL: https://issues.apache.org/jira/browse/WICKET-2635
Project: Wicket
Issue Type: Bug
Components: wicket-auth-roles
Affects Versions: 1.4.5
Reporter: Marat Radchenko
Attachments: 2635.tar.gz
Quickstart attached.
Steps to reproduce
1. Unpack attached quickstart
2. mvn jetty:run
3. Open http://localhost:8080/login
4. Enter any credentials
Expected: StatelessHomePage opens
Actual: exception happends, StatelessHomePage isn't stateless
Problem analysis:
1. SignInForm manually creates page.
2. AbstractListenerInterfaceRequestTarget.onProcessEvents calls
requestCycle.setRedirect(true)
3. RequestCycle.urlFor(final Component component, final
RequestListenerInterface listener, ValueMap params) calls
page.setPageStateless(Boolean.FALSE)
4. StatelessChecker isn't happy.
Fix is simple - SignInForm.onSignInSucceeded should be:
if (!continueToOriginalDestination())
{
setResponsePage(getApplication().getHomePage());
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2591) Allow subclasses of AuthenticatedWebSession to set signedIn field
[ https://issues.apache.org/jira/browse/WICKET-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12793961#action_12793961 ] Marat Radchenko commented on WICKET-2591: - Cookie stores pair of user login + randomly generated number. Upon successfull authentication, I generate random number, store it in db (associated with user) and set it into cookie. Cookie maxAge is much bigger that http session age. After that, on subsequent session creations, I check for cookie, and if it is present (and matches data that i stored in db), i automatically mark session as logged in without asking login/password. Hey, even this jira has remember me feature. Allow subclasses of AuthenticatedWebSession to set signedIn field --- Key: WICKET-2591 URL: https://issues.apache.org/jira/browse/WICKET-2591 Project: Wicket Issue Type: Improvement Components: wicket-auth-roles Affects Versions: 1.4.3 Reporter: Marat Radchenko My app implements remember me service by setting cookie in authenticate method of custom session that subclasses AuthenticatedWebSession. In order to automatically login user if cookie present, i need to set signedIn field to true when session is created, however it isn't possible since signedIn is private and no way to set it is available. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2630) MockHttpServletResponse doesn't delete cookies
[ https://issues.apache.org/jira/browse/WICKET-2630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12793152#action_12793152 ] Marat Radchenko commented on WICKET-2630: - Attention, cookies are stored in two places, MockHttpServletResponse.cookies and MockWebApplication.cookiesOfThisSession MockHttpServletResponse doesn't delete cookies -- Key: WICKET-2630 URL: https://issues.apache.org/jira/browse/WICKET-2630 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.5 Reporter: Marat Radchenko From Cookie.setMaxAge javadoc: * @param expiry an integer specifying the maximum age of the *cookie in seconds; if negative, means *the cookie is not stored; if zero, deletes *the cookie So, if maxAge is zero, MockHttpServletResponse should remove cookie. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2624) MethodGetAndSet.setValue uses wrong source to determine which type to convert to when there's no setter
MethodGetAndSet.setValue uses wrong source to determine which type to convert
to when there's no setter
---
Key: WICKET-2624
URL: https://issues.apache.org/jira/browse/WICKET-2624
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4.4
Reporter: Marat Radchenko
Attachments: PropertyResolverTest.java
MethodGetAndSet.setValue uses wrong source to determine which type to convert
to when there's no setter, resulting in exceptions like this:
org.apache.wicket.WicketRuntimeException: Error setting field: private int
PropertyResolverTest$DirectFieldSetWithDifferentTypeThanGetter.value on object:
propertyresolvertest$directfieldsetwithdifferenttypethanget...@396477d9
at
org.apache.wicket.util.lang.PropertyResolver$MethodGetAndSet.setValue(PropertyResolver.java:1150)
at
org.apache.wicket.util.lang.PropertyResolver$ObjectAndGetSetter.setValue(PropertyResolver.java:588)
at
org.apache.wicket.util.lang.PropertyResolver.setValue(PropertyResolver.java:136)
at
PropertyResolverTest.testDirectFieldSetWithDifferentTypeThanGetter(PropertyResolverTest.java:12)
Bug is located in:
converted = converter.convert(value, getMethod.getReturnType());
Instead, it should read:
converted = converter.convert(value, type);
Testcase attached.
Additional thoughts:
if (setMethod != null)
{
type = getMethod.getReturnType();
}
This is really confusing (we check setMethod presence but get type from
getMethod). Luckily, this works as expected because in
MethodGetAndSet.findSetter only methods with same (or superclass) type as
getter are returned.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2624) MethodGetAndSet.setValue uses wrong source to determine which type to convert to when there's no setter
[
https://issues.apache.org/jira/browse/WICKET-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marat Radchenko updated WICKET-2624:
Attachment: PropertyResolverTest.java
MethodGetAndSet.setValue uses wrong source to determine which type to convert
to when there's no setter
---
Key: WICKET-2624
URL: https://issues.apache.org/jira/browse/WICKET-2624
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4.4
Reporter: Marat Radchenko
Attachments: PropertyResolverTest.java
MethodGetAndSet.setValue uses wrong source to determine which type to convert
to when there's no setter, resulting in exceptions like this:
org.apache.wicket.WicketRuntimeException: Error setting field: private int
PropertyResolverTest$DirectFieldSetWithDifferentTypeThanGetter.value on
object:
propertyresolvertest$directfieldsetwithdifferenttypethanget...@396477d9
at
org.apache.wicket.util.lang.PropertyResolver$MethodGetAndSet.setValue(PropertyResolver.java:1150)
at
org.apache.wicket.util.lang.PropertyResolver$ObjectAndGetSetter.setValue(PropertyResolver.java:588)
at
org.apache.wicket.util.lang.PropertyResolver.setValue(PropertyResolver.java:136)
at
PropertyResolverTest.testDirectFieldSetWithDifferentTypeThanGetter(PropertyResolverTest.java:12)
Bug is located in:
converted = converter.convert(value, getMethod.getReturnType());
Instead, it should read:
converted = converter.convert(value, type);
Testcase attached.
Additional thoughts:
if (setMethod != null)
{
type = getMethod.getReturnType();
}
This is really confusing (we check setMethod presence but get type from
getMethod). Luckily, this works as expected because in
MethodGetAndSet.findSetter only methods with same (or superclass) type as
getter are returned.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2591) Allow subclasses of AuthenticatedWebSession to set signedIn field
[ https://issues.apache.org/jira/browse/WICKET-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12791994#action_12791994 ] Marat Radchenko commented on WICKET-2591: - So you expect me to use some magic values for login/password string in order to identify that other one is actually _not_ a login/password, but cookie value? That's a hack. I don't see what's the problem with giving protected access to signedIn. After all, AuthenticatedWebSession subclass already can set it (by calling signIn on itself and returning proper value from authenticate). Allow subclasses of AuthenticatedWebSession to set signedIn field --- Key: WICKET-2591 URL: https://issues.apache.org/jira/browse/WICKET-2591 Project: Wicket Issue Type: Improvement Components: wicket-auth-roles Affects Versions: 1.4.3 Reporter: Marat Radchenko My app implements remember me service by setting cookie in authenticate method of custom session that subclasses AuthenticatedWebSession. In order to automatically login user if cookie present, i need to set signedIn field to true when session is created, however it isn't possible since signedIn is private and no way to set it is available. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2591) Allow subclasses of AuthenticatedWebSession to set signedIn field
[ https://issues.apache.org/jira/browse/WICKET-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12790037#action_12790037 ] Marat Radchenko commented on WICKET-2591: - Yeah, but with remember me cookie, there isn't any login/password. There's just auth cookie token, so using authenticate(login, password) is inappropriate. Allow subclasses of AuthenticatedWebSession to set signedIn field --- Key: WICKET-2591 URL: https://issues.apache.org/jira/browse/WICKET-2591 Project: Wicket Issue Type: Improvement Components: wicket-auth-roles Affects Versions: 1.4.3 Reporter: Marat Radchenko My app implements remember me service by setting cookie in authenticate method of custom session that subclasses AuthenticatedWebSession. In order to automatically login user if cookie present, i need to set signedIn field to true when session is created, however it isn't possible since signedIn is private and no way to set it is available. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2609) EnumChoiceRenderer misbehaves with anonymous enum classes
EnumChoiceRenderer misbehaves with anonymous enum classes - Key: WICKET-2609 URL: https://issues.apache.org/jira/browse/WICKET-2609 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.4 Reporter: Marat Radchenko Please find attached testcase reproducing the problem. Proper fix is to do return object.getDeclaringClass().getSimpleName() + . + object.name() instead of return object.getClass().getSimpleName() + . + object.name() in EnumChoiceRenderer.resourceKey -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2609) EnumChoiceRenderer misbehaves with anonymous enum classes
[ https://issues.apache.org/jira/browse/WICKET-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marat Radchenko updated WICKET-2609: Attachment: EnumChoiceRendererTest.java EnumChoiceRenderer misbehaves with anonymous enum classes - Key: WICKET-2609 URL: https://issues.apache.org/jira/browse/WICKET-2609 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.4 Reporter: Marat Radchenko Attachments: EnumChoiceRendererTest.java Please find attached testcase reproducing the problem. Proper fix is to do return object.getDeclaringClass().getSimpleName() + . + object.name() instead of return object.getClass().getSimpleName() + . + object.name() in EnumChoiceRenderer.resourceKey -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2609) EnumChoiceRenderer misbehaves with anonymous enum classes
[ https://issues.apache.org/jira/browse/WICKET-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789393#action_12789393 ] Marat Radchenko commented on WICKET-2609: - I doubt current behavior makes sense since it produces resource keys without classname at all - enum constants from different classes get same resource keys. Additionally, every bugfix alters behavior :) But, your word is last here. Let it be 1.5, it just means i won't use it in 1.4 EnumChoiceRenderer misbehaves with anonymous enum classes - Key: WICKET-2609 URL: https://issues.apache.org/jira/browse/WICKET-2609 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.4 Reporter: Marat Radchenko Fix For: 1.5-M1 Attachments: EnumChoiceRendererTest.java Please find attached testcase reproducing the problem. Proper fix is to do return object.getDeclaringClass().getSimpleName() + . + object.name() instead of return object.getClass().getSimpleName() + . + object.name() in EnumChoiceRenderer.resourceKey -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2598) Some components still escape non-ASCII symbols by default
Some components still escape non-ASCII symbols by default - Key: WICKET-2598 URL: https://issues.apache.org/jira/browse/WICKET-2598 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.3 Reporter: Marat Radchenko With fix for WICKET-1054 Wicket (almost) stopped escaping non-ASCII symbols by default, it calls Strings.escapeMarkup(String) or Strings.escapeMarkup(String, false, false). However, there are still some places that also call Strings.escapeMarkup with different args. I used Strings.escapeMarkup\(.*, false, true\) regex to find them: AbstractChoice.escapeOptionHtml, CheckBoxMultipleChoice.onComponentTagBody (the reason i started to dig into this issue) RadioChoice.onComponentTagBody They should either call String.escapeMarkup(String) or even use Component.getDefaultModelObjectAsString -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2599) Missing XML prolog in wicket-extensions panel htmls
Missing XML prolog in wicket-extensions panel htmls --- Key: WICKET-2599 URL: https://issues.apache.org/jira/browse/WICKET-2599 Project: Wicket Issue Type: Bug Components: wicket-extensions Affects Versions: 1.4.3 Reporter: Marat Radchenko Almost all wicket-extensions panel HTML files are missing XML prologs. That makes it impossible to use wicket-extensions with throwExceptionOnMissingXmlDeclaration=true -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2506) Regression: Could not find child with id: ID in the wicket:enclosure for non-component tag
[ https://issues.apache.org/jira/browse/WICKET-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12785793#action_12785793 ] Marat Radchenko commented on WICKET-2506: - Douglas, you can't experience this issue since it has testcase that was added to wicket testsuite and passes correctly. What you might see is WICKET-2519, that is fixed in 1.4.4 Regression: Could not find child with id: ID in the wicket:enclosure for non-component tag -- Key: WICKET-2506 URL: https://issues.apache.org/jira/browse/WICKET-2506 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.2 Reporter: Marat Radchenko Assignee: Juergen Donnerstag Fix For: 1.4.3, 1.5-M1 Attachments: enclosure-bug.tar.gz Attached testcase passes with wicket-1.4.1 but fails with 1.4.2 saying: org.apache.wicket.WicketRuntimeException: Could not find child with id: radio in the wicket:enclosure at org.apache.wicket.markup.html.internal.Enclosure.checkChildComponent(Enclosure.java:210) at org.apache.wicket.markup.html.internal.Enclosure.ensureAllChildrenPresent(Enclosure.java:249) at org.apache.wicket.markup.html.internal.Enclosure.onComponentTagBody(Enclosure.java:169) at org.apache.wicket.Component.renderComponent(Component.java:2626) at org.apache.wicket.MarkupContainer.onRender(MarkupContainer.java:1512) at org.apache.wicket.Component.render(Component.java:2457) at org.apache.wicket.MarkupContainer.autoAdd(MarkupContainer.java:229) at org.apache.wicket.markup.resolver.EnclosureResolver.resolve(EnclosureResolver.java:61) at org.apache.wicket.markup.resolver.ComponentResolvers.resolve(ComponentResolvers.java:81) at org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1418) at org.apache.wicket.MarkupContainer.renderComponentTagBody(MarkupContainer.java:1577) at org.apache.wicket.MarkupContainer.onComponentTagBody(MarkupContainer.java:1501) at org.apache.wicket.Component.renderComponent(Component.java:2626) at org.apache.wicket.MarkupContainer.onRender(MarkupContainer.java:1512) at org.apache.wicket.Component.render(Component.java:2457) at org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1414) at org.apache.wicket.MarkupContainer.renderAll(MarkupContainer.java:1528) at org.apache.wicket.Page.onRender(Page.java:1545) at org.apache.wicket.Component.render(Component.java:2457) at org.apache.wicket.Page.renderPage(Page.java:914) at org.apache.wicket.request.target.component.BookmarkablePageRequestTarget.respond(BookmarkablePageRequestTarget.java:262) at org.apache.wicket.request.AbstractRequestCycleProcessor.respond(AbstractRequestCycleProcessor.java:105) at org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1258) at org.apache.wicket.RequestCycle.step(RequestCycle.java:1329) at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1428) at org.apache.wicket.RequestCycle.request(RequestCycle.java:594) at org.apache.wicket.protocol.http.MockWebApplication.processRequestCycle(MockWebApplication.java:478) at org.apache.wicket.protocol.http.MockWebApplication.processRequestCycle(MockWebApplication.java:390) at org.apache.wicket.util.tester.BaseWicketTester.startPage(BaseWicketTester.java:300) at org.apache.wicket.EnclosurePageTest.testRender(EnclosurePageTest.java:23) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at junit.framework.TestCase.runTest(TestCase.java:154) at junit.framework.TestCase.runBare(TestCase.java:127) at junit.framework.TestResult$1.protect(TestResult.java:106) at junit.framework.TestResult.runProtected(TestResult.java:124) at junit.framework.TestResult.run(TestResult.java:109) at junit.framework.TestCase.run(TestCase.java:118) at junit.framework.TestSuite.runTest(TestSuite.java:208) at junit.framework.TestSuite.run(TestSuite.java:203) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at
[jira] Created: (WICKET-2591) Allow subclasses of AuthenticatedWebSession to set signedIn field
Allow subclasses of AuthenticatedWebSession to set signedIn field --- Key: WICKET-2591 URL: https://issues.apache.org/jira/browse/WICKET-2591 Project: Wicket Issue Type: Improvement Components: wicket-auth-roles Affects Versions: 1.4.3 Reporter: Marat Radchenko My app implements remember me service by setting cookie in authenticate method of custom session that subclasses AuthenticatedWebSession. However, in order to automatically login user if cookie present, i need to set signedIn field to true when session is created, however it isn't possible since signedIn is private and no way to set it is available. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2591) Allow subclasses of AuthenticatedWebSession to set signedIn field
[ https://issues.apache.org/jira/browse/WICKET-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marat Radchenko updated WICKET-2591: Description: My app implements remember me service by setting cookie in authenticate method of custom session that subclasses AuthenticatedWebSession. In order to automatically login user if cookie present, i need to set signedIn field to true when session is created, however it isn't possible since signedIn is private and no way to set it is available. was: My app implements remember me service by setting cookie in authenticate method of custom session that subclasses AuthenticatedWebSession. However, in order to automatically login user if cookie present, i need to set signedIn field to true when session is created, however it isn't possible since signedIn is private and no way to set it is available. Allow subclasses of AuthenticatedWebSession to set signedIn field --- Key: WICKET-2591 URL: https://issues.apache.org/jira/browse/WICKET-2591 Project: Wicket Issue Type: Improvement Components: wicket-auth-roles Affects Versions: 1.4.3 Reporter: Marat Radchenko My app implements remember me service by setting cookie in authenticate method of custom session that subclasses AuthenticatedWebSession. In order to automatically login user if cookie present, i need to set signedIn field to true when session is created, however it isn't possible since signedIn is private and no way to set it is available. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2592) Add support for arbitrary PageParameters values in QueryStringUrlCodingStrategy
[ https://issues.apache.org/jira/browse/WICKET-2592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marat Radchenko updated WICKET-2592: Attachment: QuertStringUrlCodingStrategyTest.java Add support for arbitrary PageParameters values in QueryStringUrlCodingStrategy --- Key: WICKET-2592 URL: https://issues.apache.org/jira/browse/WICKET-2592 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.4.3 Reporter: Marat Radchenko Attachments: QuertStringUrlCodingStrategyTest.java QueryStringUrlCodingStrategy, in contrast to BookmarkablePageRequestTargetUrlCodingStrategy that it inherits from, supports only String and String[] values. This makes it hard to switch strategies. Please, make it support arbitrary value type by calling toString() on them. Testcase attached. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2592) Add support for arbitrary PageParameters values in QueryStringUrlCodingStrategy
Add support for arbitrary PageParameters values in QueryStringUrlCodingStrategy --- Key: WICKET-2592 URL: https://issues.apache.org/jira/browse/WICKET-2592 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.4.3 Reporter: Marat Radchenko Attachments: QuertStringUrlCodingStrategyTest.java QueryStringUrlCodingStrategy, in contrast to BookmarkablePageRequestTargetUrlCodingStrategy that it inherits from, supports only String and String[] values. This makes it hard to switch strategies. Please, make it support arbitrary value type by calling toString() on them. Testcase attached. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2583) Warnings flood if incorrect credentials endered on SignInPage
[ https://issues.apache.org/jira/browse/WICKET-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12783400#action_12783400 ] Marat Radchenko commented on WICKET-2583: - Thanks Warnings flood if incorrect credentials endered on SignInPage - Key: WICKET-2583 URL: https://issues.apache.org/jira/browse/WICKET-2583 Project: Wicket Issue Type: Bug Components: wicket-auth-roles Affects Versions: 1.4.3 Reporter: Marat Radchenko Assignee: Juergen Donnerstag Fix For: 1.4.4 WARNING: Couldn't resolve model type of Model:classname=[org.apache.wicket.model.PropertyModel]:nestedModel=[username = admin]:expression=[username] for [MarkupContainer [Component id = username]], please set the type yourself. 20.11.2009 0:04:11 org.apache.wicket.markup.html.form.AbstractTextComponent getModelType WARNING: Couldn't resolve model type of Model:classname=[org.apache.wicket.model.PropertyModel]:nestedModel=[username = admin]:expression=[password] for [MarkupContainer [Component id = password]], please set the type yourself. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Reopened: (WICKET-2583) Warnings flood if incorrect credentials endered on SignInPage
[ https://issues.apache.org/jira/browse/WICKET-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marat Radchenko reopened WICKET-2583: - Hmm... Let's try once again. This problem isn't on any random page i wrote myself, but on SignInPage from wicket-auth-roles. Warnings flood if incorrect credentials endered on SignInPage - Key: WICKET-2583 URL: https://issues.apache.org/jira/browse/WICKET-2583 Project: Wicket Issue Type: Bug Components: wicket-auth-roles Affects Versions: 1.4.3 Reporter: Marat Radchenko Assignee: Juergen Donnerstag WARNING: Couldn't resolve model type of Model:classname=[org.apache.wicket.model.PropertyModel]:nestedModel=[username = admin]:expression=[username] for [MarkupContainer [Component id = username]], please set the type yourself. 20.11.2009 0:04:11 org.apache.wicket.markup.html.form.AbstractTextComponent getModelType WARNING: Couldn't resolve model type of Model:classname=[org.apache.wicket.model.PropertyModel]:nestedModel=[username = admin]:expression=[password] for [MarkupContainer [Component id = password]], please set the type yourself. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2583) Warnings flood if incorrect credentials endered on SignInPage
Warnings flood if incorrect credentials endered on SignInPage - Key: WICKET-2583 URL: https://issues.apache.org/jira/browse/WICKET-2583 Project: Wicket Issue Type: Bug Components: wicket-auth-roles Affects Versions: 1.4.3 Reporter: Marat Radchenko WARNING: Couldn't resolve model type of Model:classname=[org.apache.wicket.model.PropertyModel]:nestedModel=[username = admin]:expression=[username] for [MarkupContainer [Component id = username]], please set the type yourself. 20.11.2009 0:04:11 org.apache.wicket.markup.html.form.AbstractTextComponent getModelType WARNING: Couldn't resolve model type of Model:classname=[org.apache.wicket.model.PropertyModel]:nestedModel=[username = admin]:expression=[password] for [MarkupContainer [Component id = password]], please set the type yourself. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2506) Regression: Could not find child with id: ID in the wicket:enclosure for non-component tag
Regression: Could not find child with id: ID in the wicket:enclosure for non-component tag -- Key: WICKET-2506 URL: https://issues.apache.org/jira/browse/WICKET-2506 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.2 Reporter: Marat Radchenko Attachments: enclosure-bug.tar.gz Attached testcase passes with wicket-1.4.1 but fails with 1.4.2 saying: org.apache.wicket.WicketRuntimeException: Could not find child with id: radio in the wicket:enclosure at org.apache.wicket.markup.html.internal.Enclosure.checkChildComponent(Enclosure.java:210) at org.apache.wicket.markup.html.internal.Enclosure.ensureAllChildrenPresent(Enclosure.java:249) at org.apache.wicket.markup.html.internal.Enclosure.onComponentTagBody(Enclosure.java:169) at org.apache.wicket.Component.renderComponent(Component.java:2626) at org.apache.wicket.MarkupContainer.onRender(MarkupContainer.java:1512) at org.apache.wicket.Component.render(Component.java:2457) at org.apache.wicket.MarkupContainer.autoAdd(MarkupContainer.java:229) at org.apache.wicket.markup.resolver.EnclosureResolver.resolve(EnclosureResolver.java:61) at org.apache.wicket.markup.resolver.ComponentResolvers.resolve(ComponentResolvers.java:81) at org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1418) at org.apache.wicket.MarkupContainer.renderComponentTagBody(MarkupContainer.java:1577) at org.apache.wicket.MarkupContainer.onComponentTagBody(MarkupContainer.java:1501) at org.apache.wicket.Component.renderComponent(Component.java:2626) at org.apache.wicket.MarkupContainer.onRender(MarkupContainer.java:1512) at org.apache.wicket.Component.render(Component.java:2457) at org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1414) at org.apache.wicket.MarkupContainer.renderAll(MarkupContainer.java:1528) at org.apache.wicket.Page.onRender(Page.java:1545) at org.apache.wicket.Component.render(Component.java:2457) at org.apache.wicket.Page.renderPage(Page.java:914) at org.apache.wicket.request.target.component.BookmarkablePageRequestTarget.respond(BookmarkablePageRequestTarget.java:262) at org.apache.wicket.request.AbstractRequestCycleProcessor.respond(AbstractRequestCycleProcessor.java:105) at org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1258) at org.apache.wicket.RequestCycle.step(RequestCycle.java:1329) at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1428) at org.apache.wicket.RequestCycle.request(RequestCycle.java:594) at org.apache.wicket.protocol.http.MockWebApplication.processRequestCycle(MockWebApplication.java:478) at org.apache.wicket.protocol.http.MockWebApplication.processRequestCycle(MockWebApplication.java:390) at org.apache.wicket.util.tester.BaseWicketTester.startPage(BaseWicketTester.java:300) at org.apache.wicket.EnclosurePageTest.testRender(EnclosurePageTest.java:23) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at junit.framework.TestCase.runTest(TestCase.java:154) at junit.framework.TestCase.runBare(TestCase.java:127) at junit.framework.TestResult$1.protect(TestResult.java:106) at junit.framework.TestResult.runProtected(TestResult.java:124) at junit.framework.TestResult.run(TestResult.java:109) at junit.framework.TestCase.run(TestCase.java:118) at junit.framework.TestSuite.runTest(TestSuite.java:208) at junit.framework.TestSuite.run(TestSuite.java:203) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.maven.surefire.junit.JUnitTestSet.execute(JUnitTestSet.java:213) at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140) at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127) at org.apache.maven.surefire.Surefire.run(Surefire.java:177) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
[jira] Updated: (WICKET-2506) Regression: Could not find child with id: ID in the wicket:enclosure for non-component tag
[ https://issues.apache.org/jira/browse/WICKET-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marat Radchenko updated WICKET-2506: Attachment: enclosure-bug.tar.gz Regression: Could not find child with id: ID in the wicket:enclosure for non-component tag -- Key: WICKET-2506 URL: https://issues.apache.org/jira/browse/WICKET-2506 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.2 Reporter: Marat Radchenko Attachments: enclosure-bug.tar.gz Attached testcase passes with wicket-1.4.1 but fails with 1.4.2 saying: org.apache.wicket.WicketRuntimeException: Could not find child with id: radio in the wicket:enclosure at org.apache.wicket.markup.html.internal.Enclosure.checkChildComponent(Enclosure.java:210) at org.apache.wicket.markup.html.internal.Enclosure.ensureAllChildrenPresent(Enclosure.java:249) at org.apache.wicket.markup.html.internal.Enclosure.onComponentTagBody(Enclosure.java:169) at org.apache.wicket.Component.renderComponent(Component.java:2626) at org.apache.wicket.MarkupContainer.onRender(MarkupContainer.java:1512) at org.apache.wicket.Component.render(Component.java:2457) at org.apache.wicket.MarkupContainer.autoAdd(MarkupContainer.java:229) at org.apache.wicket.markup.resolver.EnclosureResolver.resolve(EnclosureResolver.java:61) at org.apache.wicket.markup.resolver.ComponentResolvers.resolve(ComponentResolvers.java:81) at org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1418) at org.apache.wicket.MarkupContainer.renderComponentTagBody(MarkupContainer.java:1577) at org.apache.wicket.MarkupContainer.onComponentTagBody(MarkupContainer.java:1501) at org.apache.wicket.Component.renderComponent(Component.java:2626) at org.apache.wicket.MarkupContainer.onRender(MarkupContainer.java:1512) at org.apache.wicket.Component.render(Component.java:2457) at org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1414) at org.apache.wicket.MarkupContainer.renderAll(MarkupContainer.java:1528) at org.apache.wicket.Page.onRender(Page.java:1545) at org.apache.wicket.Component.render(Component.java:2457) at org.apache.wicket.Page.renderPage(Page.java:914) at org.apache.wicket.request.target.component.BookmarkablePageRequestTarget.respond(BookmarkablePageRequestTarget.java:262) at org.apache.wicket.request.AbstractRequestCycleProcessor.respond(AbstractRequestCycleProcessor.java:105) at org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1258) at org.apache.wicket.RequestCycle.step(RequestCycle.java:1329) at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1428) at org.apache.wicket.RequestCycle.request(RequestCycle.java:594) at org.apache.wicket.protocol.http.MockWebApplication.processRequestCycle(MockWebApplication.java:478) at org.apache.wicket.protocol.http.MockWebApplication.processRequestCycle(MockWebApplication.java:390) at org.apache.wicket.util.tester.BaseWicketTester.startPage(BaseWicketTester.java:300) at org.apache.wicket.EnclosurePageTest.testRender(EnclosurePageTest.java:23) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at junit.framework.TestCase.runTest(TestCase.java:154) at junit.framework.TestCase.runBare(TestCase.java:127) at junit.framework.TestResult$1.protect(TestResult.java:106) at junit.framework.TestResult.runProtected(TestResult.java:124) at junit.framework.TestResult.run(TestResult.java:109) at junit.framework.TestCase.run(TestCase.java:118) at junit.framework.TestSuite.runTest(TestSuite.java:208) at junit.framework.TestSuite.run(TestSuite.java:203) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.maven.surefire.junit.JUnitTestSet.execute(JUnitTestSet.java:213) at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140) at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127) at
[jira] Commented: (WICKET-2277) Radio#onComponentTag uses Objects.equal instead of model comparator
[ https://issues.apache.org/jira/browse/WICKET-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12730257#action_12730257 ] Marat Radchenko commented on WICKET-2277: - Confirming that fix works in 1.4-rc6. Radio#onComponentTag uses Objects.equal instead of model comparator --- Key: WICKET-2277 URL: https://issues.apache.org/jira/browse/WICKET-2277 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4-RC2, 1.4-RC3, 1.4-RC4 Reporter: Marat Radchenko Assignee: Juergen Donnerstag Fix For: 1.4-RC5 Radio#onComponentTag uses Objects.equal instead of modelcomparator from RadioGroup. Because of that, it is impossible to use custom model comparator in RadioGroup as RadioGroup must contain values that pass equality check with values in Radios (otherwise, Radios aren't marked as checked in html). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2277) Radio#onComponentTag uses Objects.equal instead of model comparator
Radio#onComponentTag uses Objects.equal instead of model comparator --- Key: WICKET-2277 URL: https://issues.apache.org/jira/browse/WICKET-2277 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4-RC2 Reporter: Marat Radchenko Radio#onComponentTag uses Objects.equal instead of modelcomparator from RadioGroup. Because of that, it is impossible to use custom model comparator in RadioGroup as RadioGroup must contain values that pass equality check with values in Radios (otherwise, Radios aren't marked as checked in html). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2277) Radio#onComponentTag uses Objects.equal instead of model comparator
[ https://issues.apache.org/jira/browse/WICKET-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marat Radchenko updated WICKET-2277: Affects Version/s: 1.4-RC3 1.4-RC4 Also affects 1.4-rc3, 1.4-rc4: http://fisheye6.atlassian.com/browse/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Radio.java?r=762860#l191 Radio#onComponentTag uses Objects.equal instead of model comparator --- Key: WICKET-2277 URL: https://issues.apache.org/jira/browse/WICKET-2277 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4-RC2, 1.4-RC3, 1.4-RC4 Reporter: Marat Radchenko Radio#onComponentTag uses Objects.equal instead of modelcomparator from RadioGroup. Because of that, it is impossible to use custom model comparator in RadioGroup as RadioGroup must contain values that pass equality check with values in Radios (otherwise, Radios aren't marked as checked in html). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2170) @StatelessComponent contribution by Marat Radchenko
[ https://issues.apache.org/jira/browse/WICKET-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12682257#action_12682257 ] Marat Radchenko commented on WICKET-2170: - Gwyn, all files in source archive include Apache License headers. @StatelessComponent contribution by Marat Radchenko --- Key: WICKET-2170 URL: https://issues.apache.org/jira/browse/WICKET-2170 Project: Wicket Issue Type: New Feature Components: wicket Reporter: Gwyn Evans Priority: Minor Attachments: wicketextras-1.5-SNAPSHOT.jar, wicketextras.tar.gz From mailing list - http://www.nabble.com/Have-a-feature,-want-to-contribute-td21079751.html Wicket pages/components can be either stateful or stateless. Wicket manages hem transparently and it is very easy to write any complex page you want. Stateful pages are much more powerful than stateless. However that comes at a cost of using page store for their state. On highload sites it is usually desired to minimize session-scope data, and move it to request-scope. That's when Wicket users approach a task of making stateful pages stateless. However stateless state (sic!) is very fragile, if you add a single stateful component to a page, it instantly becomes stateful (and you even might not notice that if your other page content can work in both modes. And here comes my lovely feature - @StatelessComponent. It is an annotation that you should put on components which you want to be stateless. It doesn't do any magic, it simply uses postComponentOnBeforeRender to assert that annotated component (and all its children) are stateless. If it doesn't, an exception is thrown, indicating what component tries to be stateful. This feature isn't large enough to be put in a separate project (just one annotation and one listener) but wee find it extremely useful on our project. I'd be happy to give it to Wicket project (or wicketstuff?) at absolutely no cost (tests included) under same license as wicket itself, if Wicket developers are interested in it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1451) BaseWicketTester's simulated AJAX form submissions don't include Radio values
[
https://issues.apache.org/jira/browse/WICKET-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12659196#action_12659196
]
Marat Radchenko commented on WICKET-1451:
-
We also hit this bug with wicket-1.4-rc1.
BaseWicketTester's simulated AJAX form submissions don't include Radio values
-
Key: WICKET-1451
URL: https://issues.apache.org/jira/browse/WICKET-1451
Project: Wicket
Issue Type: Bug
Reporter: David Shepherdson
Assignee: Frank Bille Jensen
Priority: Minor
When submitting a form by AJAX, the BaseWicketTester goes through all the
form components to make sure their values are stored in the request. However,
because Radios are not instances of FormComponent, and because the code skips
RadioGroups, the values for radio buttons are not stored in the request. This
is particularly a problem if the form contains radio buttons marked as
required, because in that case validation will fail and the onSubmit() method
will not be called.
The problem lies in BaseWicketTester.submitAjaxFormSubmitBehavior(). If the
visitor in this method were changed so that, instead of skipping RadioGroups,
it instead did something like the constructor of FormTester does (see
WICKET-1411) to extract the actual value for the group and set that in the
request, the problem would be prevented.
For anyone else affected by this issue, we're working around it by overriding
the clickLink(String, boolean) method (since submitAjaxFormSubmitBehavior()
is private) in a subclass of WicketTester like this:
@Override
public void clickLink(String path, boolean isAjax) {
// Workaround for bug in BaseWicketTester: doexn't cope with
RadioGroups properly.
Component linkComponent =
getComponentFromLastRenderedPage(path);
if (linkComponent instanceof AjaxSubmitLink) {
// Code borrowed from BaseWicketTester.
AjaxSubmitLink link = (AjaxSubmitLink)linkComponent;
// We cycle through the attached behaviors and select
the
// LAST matching behavior as the one we handle.
List behaviors = link.getBehaviors();
AjaxFormSubmitBehavior behaviour = null;
for (Iterator iter = behaviors.iterator();
iter.hasNext();)
{
Object behavior = iter.next();
if (behavior instanceof AjaxFormSubmitBehavior)
{
AjaxFormSubmitBehavior submitBehavior =
(AjaxFormSubmitBehavior)behavior;
behaviour = submitBehavior;
}
}
if (behaviour != null) {
// More code borrowed from BaseWicketTester.
Form form = null;
try {
Field formField =
AjaxFormSubmitBehavior.class.getDeclaredField(form);
formField.setAccessible(true);
form = (Form)formField.get(behaviour);
} catch (Exception e) {
s_log.error(Caught exception in
workaround for BaseWicketTester bug., e);
}
if (form != null) {
form.visitFormComponents(new
FormComponent.AbstractVisitor()
{
public void
onFormComponent(FormComponent formComponent)
{
if (formComponent
instanceof RadioGroup) {
final String
name = formComponent.getInputName();
final String value =
formComponent.getValue();
Object choiceValue =
formComponent.visitChildren(Radio.class, new IVisitor()
{
public Object
component(Component component)
{
// O-P Preserve
old escaping value, then turn escaping off
// so that
values aren't escaped unnecessarily.
[jira] Issue Comment Edited: (WICKET-1653) Invalid argument in wicket-ajax.js (line 606) causes not loading ajax lazy load panel in IE
[ https://issues.apache.org/jira/browse/WICKET-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12651272#action_12651272 ] slonopotamus edited comment on WICKET-1653 at 11/27/08 12:13 AM: Closed too early. Nobody confirmed bug is fixed on 1.4 branch. was (Author: slonopotamus): Closed to early. Nobody confirmed bug is fixed on 1.4 branch. Invalid argument in wicket-ajax.js (line 606) causes not loading ajax lazy load panel in IE --- Key: WICKET-1653 URL: https://issues.apache.org/jira/browse/WICKET-1653 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.3 Environment: IE6.0.2900.2180 on xp Reporter: Per Newgro Assignee: Matej Knopp Priority: Critical see description at http://www.nabble.com/javascript-error-in-internet-explorer-td16732896.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1653) Invalid argument in wicket-ajax.js (line 606) causes not loading ajax lazy load panel in IE
[ https://issues.apache.org/jira/browse/WICKET-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12651272#action_12651272 ] Marat Radchenko commented on WICKET-1653: - Closed to early. Nobody confirmed bug is fixed on 1.4 branch? Invalid argument in wicket-ajax.js (line 606) causes not loading ajax lazy load panel in IE --- Key: WICKET-1653 URL: https://issues.apache.org/jira/browse/WICKET-1653 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.3 Environment: IE6.0.2900.2180 on xp Reporter: Per Newgro Assignee: Matej Knopp Priority: Critical see description at http://www.nabble.com/javascript-error-in-internet-explorer-td16732896.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-1653) Invalid argument in wicket-ajax.js (line 606) causes not loading ajax lazy load panel in IE
[ https://issues.apache.org/jira/browse/WICKET-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12651272#action_12651272 ] slonopotamus edited comment on WICKET-1653 at 11/26/08 11:32 PM: Closed to early. Nobody confirmed bug is fixed on 1.4 branch. was (Author: slonopotamus): Closed to early. Nobody confirmed bug is fixed on 1.4 branch? Invalid argument in wicket-ajax.js (line 606) causes not loading ajax lazy load panel in IE --- Key: WICKET-1653 URL: https://issues.apache.org/jira/browse/WICKET-1653 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.3 Environment: IE6.0.2900.2180 on xp Reporter: Per Newgro Assignee: Matej Knopp Priority: Critical see description at http://www.nabble.com/javascript-error-in-internet-explorer-td16732896.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1653) Invalid argument in wicket-ajax.js (line 606) causes not loading ajax lazy load panel in IE
[ https://issues.apache.org/jira/browse/WICKET-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12643775#action_12643775 ] Marat Radchenko commented on WICKET-1653: - Hmm... So you have bugreport, you have complaining users, you have steps to reproduce, you have a patch. Why not fix this bug and forget about it? Invalid argument in wicket-ajax.js (line 606) causes not loading ajax lazy load panel in IE --- Key: WICKET-1653 URL: https://issues.apache.org/jira/browse/WICKET-1653 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.3 Environment: IE6.0.2900.2180 on xp Reporter: Per Newgro Assignee: Matej Knopp see description at http://www.nabble.com/javascript-error-in-internet-explorer-td16732896.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1520) JavaScriptStripper breaks prototype.js
[ https://issues.apache.org/jira/browse/WICKET-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12626918#action_12626918 ] Marat Radchenko commented on WICKET-1520: - Bug doesn't appear in wicket-1.4-m3 JavaScriptStripper breaks prototype.js --- Key: WICKET-1520 URL: https://issues.apache.org/jira/browse/WICKET-1520 Project: Wicket Issue Type: Bug Affects Versions: 1.3.2, 1.3.3 Reporter: Juliano Viana Assignee: Matej Knopp Fix For: 1.3.5 JavaScriptStripper is used to strip whitespace and comments from JavaScript files if the resource settings for the application enable that behavior. The problem is it breaks prototype.js version 1.6.0 (a heavily used JavaScript library, used by many components like wicketstuff-scriptaculous ). It changes the library so that the line that reads: document.write(script id=__onDOMContentLoaded defer src=//:\/script); becomes: document.write(script id=__onDOMContentLoaded defer src= This is enough to render useless any application that relies on scriptaculous . The funny part is that it only happen if the application mode is DEPLOYMENT, as in DEVELOPMENT this code is not active. I suggest dropping this functionality altogether - the logic for doing the stripping is extremely complicated and what is the point of stripping whitespace and comments from something that is going to be gzip compressed anyway? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1648) AbstractRequestTargetUrlCodingStrategy(line 174) throws confusing exception. It would be better redirect to 404-page in this case.
[ https://issues.apache.org/jira/browse/WICKET-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12623596#action_12623596 ] Marat Radchenko commented on WICKET-1648: - Still present in 1.4-M3 AbstractRequestTargetUrlCodingStrategy(line 174) throws confusing exception. It would be better redirect to 404-page in this case. --- Key: WICKET-1648 URL: https://issues.apache.org/jira/browse/WICKET-1648 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4-M1 Reporter: Andrey Tuzhikov Assignee: Gerolf Seitz Fix For: 1.3.5 Original Estimate: 48h Remaining Estimate: 48h Steps to reproduce: When user manually types incorrect URL, this confusing exception will be thrown. SEVERE: Internal error for /eshop/profile/p java.lang.IllegalStateException: URL fragment has unmatched key/value pair: p at org.apache.wicket.request.target.coding.AbstractRequestTargetUrlCodingStrategy.decodeParameters(AbstractRequestTargetUrlCodingStrategy.java:174) at org.apache.wicket.request.target.coding.BookmarkablePageRequestTargetUrlCodingStrategy.decode(BookmarkablePageRequestTargetUrlCodingStrategy.java:76) at org.apache.wicket.protocol.http.request.WebRequestCodingStrategy.targetForRequest(WebRequestCodingStrategy.java:476) at org.apache.wicket.protocol.http.WebRequestCycleProcessor.resolve(WebRequestCycleProcessor.java:175) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-1750) Inconsisting Handling of id mismatch on wicket:container
Inconsisting Handling of id mismatch on wicket:container
Key: WICKET-1750
URL: https://issues.apache.org/jira/browse/WICKET-1750
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4-M2
Reporter: Marat Radchenko
Given this simple case:
public class Home extends WebPage {
public Home() {
add(new EmptyPanel(test));
}
}
and the following HTML page:
span wicket:id='test2'/
Please notice that the ids do not match.
Executing this app will give the following Exception:
WicketMessage: Unable to find component with id 'test2' in [Page class =
com.myapp.wicket.Home, id = 0, version = 0]. This means that you declared
wicket:id=test2 in your markup, but that you either did not add the
component to your page at all, or that the hierarchy does not match.
Whereas when using a wicket:container instead of a HTML tag, like this:
wicket:container wicket:id='test2'/
And when the ids doesn't match, Wicket throws the following exception:
WicketMessage: Failed to handle: wicket:container wicket:id='test2'/
Which is quite cryptic at the first glance.
Original:
http://mail-archives.apache.org/mod_mbox/wicket-dev/200803.mbox/[EMAIL
PROTECTED]
We ran across same problem too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1520) JavaScriptStripper breaks prototype.js
[ https://issues.apache.org/jira/browse/WICKET-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12601366#action_12601366 ] Marat Radchenko commented on WICKET-1520: - Also affects wicket-1.4-m1 JavaScriptStripper breaks prototype.js --- Key: WICKET-1520 URL: https://issues.apache.org/jira/browse/WICKET-1520 Project: Wicket Issue Type: Bug Affects Versions: 1.3.2, 1.3.3 Reporter: Juliano Viana Assignee: Matej Knopp Fix For: 1.3.4 JavaScriptStripper is used to strip whitespace and comments from JavaScript files if the resource settings for the application enable that behavior. The problem is it breaks prototype.js version 1.6.0 (a heavily used JavaScript library, used by many components like wicketstuff-scriptaculous ). It changes the library so that the line that reads: document.write(script id=__onDOMContentLoaded defer src=//:\/script); becomes: document.write(script id=__onDOMContentLoaded defer src= This is enough to render useless any application that relies on scriptaculous . The funny part is that it only happen if the application mode is DEPLOYMENT, as in DEVELOPMENT this code is not active. I suggest dropping this functionality altogether - the logic for doing the stripping is extremely complicated and what is the point of stripping whitespace and comments from something that is going to be gzip compressed anyway? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1658) WicketTester#clickLink doesn't update lastRenderedPage
[ https://issues.apache.org/jira/browse/WICKET-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marat Radchenko updated WICKET-1658: Attachment: wicket-1658.tar.gz Please find attached testcase. WicketTester#clickLink doesn't update lastRenderedPage -- Key: WICKET-1658 URL: https://issues.apache.org/jira/browse/WICKET-1658 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4-M1 Reporter: Marat Radchenko Assignee: Frank Bille Jensen Attachments: wicket-1658.tar.gz If clickLink is used on a link that calls setResponsePage then that page doesn't appear in WicketTester's lastRenderedPage. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-1658) WicketTester#clickLink doesn't update lastRenderedPage
WicketTester#clickLink doesn't update lastRenderedPage -- Key: WICKET-1658 URL: https://issues.apache.org/jira/browse/WICKET-1658 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4-M1 Reporter: Marat Radchenko If clickLink is used on a link that calls setResponsePage then that page doesn't appear in WicketTester's lastRenderedPage. To fix the problem simply call postProcessRequestCycle(requestCycle) between target.respond(requestCycle) and requestCycle.detach() -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1658) WicketTester#clickLink doesn't update lastRenderedPage
[ https://issues.apache.org/jira/browse/WICKET-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marat Radchenko updated WICKET-1658: Description: If clickLink is used on a link that calls setResponsePage then that page doesn't appear in WicketTester's lastRenderedPage. (was: If clickLink is used on a link that calls setResponsePage then that page doesn't appear in WicketTester's lastRenderedPage. To fix the problem simply call postProcessRequestCycle(requestCycle) between target.respond(requestCycle) and requestCycle.detach()) WicketTester#clickLink doesn't update lastRenderedPage -- Key: WICKET-1658 URL: https://issues.apache.org/jira/browse/WICKET-1658 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4-M1 Reporter: Marat Radchenko If clickLink is used on a link that calls setResponsePage then that page doesn't appear in WicketTester's lastRenderedPage. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1520) JavaScriptStripper breaks prototype.js
[ https://issues.apache.org/jira/browse/WICKET-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12597949#action_12597949 ] Marat Radchenko commented on WICKET-1520: - Get the same error here. JavaScriptStripper breaks prototype.js --- Key: WICKET-1520 URL: https://issues.apache.org/jira/browse/WICKET-1520 Project: Wicket Issue Type: Bug Affects Versions: 1.3.2, 1.3.3 Reporter: Juliano Viana Fix For: 1.3.4 JavaScriptStripper is used to strip whitespace and comments from JavaScript files if the resource settings for the application enable that behavior. The problem is it breaks prototype.js version 1.6.0 (a heavily used JavaScript library, used by many components like wicketstuff-scriptaculous ). It changes the library so that the line that reads: document.write(script id=__onDOMContentLoaded defer src=//:\/script); becomes: document.write(script id=__onDOMContentLoaded defer src= This is enough to render useless any application that relies on scriptaculous . The funny part is that it only happen if the application mode is DEPLOYMENT, as in DEVELOPMENT this code is not active. I suggest dropping this functionality altogether - the logic for doing the stripping is extremely complicated and what is the point of stripping whitespace and comments from something that is going to be gzip compressed anyway? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1340) Bogus LocalizedImageResource#isStateless()
[ https://issues.apache.org/jira/browse/WICKET-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12568502#action_12568502 ] Marat Radchenko commented on WICKET-1340: - And if an Image doesn't have a resourceReference but only a Resource then it generates a callback link so that it will serve the Resource itself. I understand case with Resource. However empty image (that takes url from template) doesn't have any resource. And it doesn't generate callback to itself. If image is empty then LocalizedImageResource searches for src attribute on tag and invokes LocalizedImageResource#loadStaticImage. Which sets ResourceReference! So empty image turns into image with ResourceReference (which is stateless as you say). Bogus LocalizedImageResource#isStateless() -- Key: WICKET-1340 URL: https://issues.apache.org/jira/browse/WICKET-1340 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.0-final, 1.3.1 Reporter: Marat Radchenko Assignee: Johan Compagner Fix For: 1.3.2 Attachments: Image2Test.java, ImageTest.java Image without resource/resource reference should be stateless. Bug is located in LocalizedImageResource#isStateless(), which should read return resourceReference == null; Test case is attached. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1340) Bogus LocalizedImageResource#isStateless()
[ https://issues.apache.org/jira/browse/WICKET-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12568534#action_12568534 ] Marat Radchenko commented on WICKET-1340: - Ok, let's sum up. Image should be stateful if it has Resource [either in LocalizedImageResource or in model]. Otherwise (if it has ResourceReference [either in LocalizedImageResource or in model]) it should be stateless. Right? Bogus LocalizedImageResource#isStateless() -- Key: WICKET-1340 URL: https://issues.apache.org/jira/browse/WICKET-1340 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.0-final, 1.3.1 Reporter: Marat Radchenko Assignee: Johan Compagner Fix For: 1.3.2 Attachments: Image2Test.java, ImageTest.java Image without resource/resource reference should be stateless. Bug is located in LocalizedImageResource#isStateless(), which should read return resourceReference == null; Test case is attached. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-1340) Bogus LocalizedImageResource#isStateless()
[ https://issues.apache.org/jira/browse/WICKET-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12568534#action_12568534 ] slonopotamus edited comment on WICKET-1340 at 2/13/08 4:26 AM: -- Ok, let's sum up. 1) Image should be stateful if it has Resource [either in LocalizedImageResource or in model]. 2) Otherwise (if it has ResourceReference [either in LocalizedImageResource or in model]) it should be stateless. 3) If image is empty (it doesn't have R/RR in model and it doesn't have R/RR in LocalizedImageResource) then it cannot become stateful because in this case src tag attribute will be used and RR will be created so image will be the same as in 2. Right? was (Author: slonopotamus): Ok, let's sum up. Image should be stateful if it has Resource [either in LocalizedImageResource or in model]. Otherwise (if it has ResourceReference [either in LocalizedImageResource or in model]) it should be stateless. Right? Bogus LocalizedImageResource#isStateless() -- Key: WICKET-1340 URL: https://issues.apache.org/jira/browse/WICKET-1340 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.0-final, 1.3.1 Reporter: Marat Radchenko Assignee: Johan Compagner Fix For: 1.3.2 Attachments: Image2Test.java, ImageTest.java Image without resource/resource reference should be stateless. Bug is located in LocalizedImageResource#isStateless(), which should read return resourceReference == null; Test case is attached. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1340) Bogus LocalizedImageResource#isStateless()
[ https://issues.apache.org/jira/browse/WICKET-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marat Radchenko updated WICKET-1340: Attachment: Image2Test.java Sorry, mistyped your name Bogus LocalizedImageResource#isStateless() -- Key: WICKET-1340 URL: https://issues.apache.org/jira/browse/WICKET-1340 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.0-final, 1.3.1 Reporter: Marat Radchenko Assignee: Johan Compagner Attachments: Image2Test.java, ImageTest.java Image without resource/resource reference should be stateless. Bug is located in LocalizedImageResource#isStateless(), which should read return resourceReference == null; Test case is attached. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Reopened: (WICKET-1340) Bogus LocalizedImageResource#isStateless()
[ https://issues.apache.org/jira/browse/WICKET-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marat Radchenko reopened WICKET-1340: - Sadly I have to reopen this issue. Please find attached testcase (Image2Test.java). It tries to prove what you say (and fails...). I cannot find any way to create a stateless Image. Could you show me an example? Bogus LocalizedImageResource#isStateless() -- Key: WICKET-1340 URL: https://issues.apache.org/jira/browse/WICKET-1340 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.0-final, 1.3.1 Reporter: Marat Radchenko Assignee: Johan Compagner Attachments: Image2Test.java, ImageTest.java Image without resource/resource reference should be stateless. Bug is located in LocalizedImageResource#isStateless(), which should read return resourceReference == null; Test case is attached. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-1340) Bogus LocalizedImageResource#isStateless()
Bogus LocalizedImageResource#isStateless() -- Key: WICKET-1340 URL: https://issues.apache.org/jira/browse/WICKET-1340 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.1, 1.3.0-final Reporter: Marat Radchenko Attachments: ImageTest.java Image without resource/resource reference should be stateless. Bug is located in LocalizedImageResource#isStateless(), which should read return resourceReference == null; Test case is attached. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1340) Bogus LocalizedImageResource#isStateless()
[ https://issues.apache.org/jira/browse/WICKET-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marat Radchenko updated WICKET-1340: Attachment: ImageTest.java Bogus LocalizedImageResource#isStateless() -- Key: WICKET-1340 URL: https://issues.apache.org/jira/browse/WICKET-1340 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.0-final, 1.3.1 Reporter: Marat Radchenko Attachments: ImageTest.java Image without resource/resource reference should be stateless. Bug is located in LocalizedImageResource#isStateless(), which should read return resourceReference == null; Test case is attached. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1139) Wicket html files do not have xml prolog
[ https://issues.apache.org/jira/browse/WICKET-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547606 ] Marat Radchenko commented on WICKET-1139: - Wow. Thanks :) Wicket html files do not have xml prolog Key: WICKET-1139 URL: https://issues.apache.org/jira/browse/WICKET-1139 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.0-beta4 Environment: n/a Reporter: Marat Radchenko Assignee: Juergen Donnerstag Fix For: 1.3.0-rc2 We want to enforce all our pages to explicitly specify xml prolog in order to avoid troubles with encodings (unfortunately we are not ASCII-speaking). We want to do that by specifying invalid defaultMarkupEncoding. This way we will get exceptions for all htmls that didn't declare encoding. However it is not possible at the moment because many wicket built-in html files do not have xml prolog. Fix is very simple: just add ?xml version=1.0 encoding=UTF-8 ? to your html files. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1172) FormComponentFeedbackIndicator and FormComponentFeedbackBorder is broken
[
https://issues.apache.org/jira/browse/WICKET-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marat Radchenko updated WICKET-1172:
Attachment: IndicatorTest.java
Please find testcase in attached file.
There are two tests:
* testFixedVisible, which runs fixed FormComponentFeedBackIndicator (and passes)
* testVisible, which runs current FormComponentFeedBackIndicator (and fails)
FormComponentFeedbackIndicator and FormComponentFeedbackBorder is broken
Key: WICKET-1172
URL: https://issues.apache.org/jira/browse/WICKET-1172
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.3.0-rc1
Reporter: Dmitry Rzhevskiy
Assignee: Johan Compagner
Priority: Critical
Attachments: IndicatorTest.java
FormComponentFeedbackIndicator is not work. FormComponentFeedbackIndicator
always invisible because:
first render forms contain no errors,
method FormComponentFeedbackIndicator.onBeforeRender (line 78) sets
component invisible.
onBeforeRender() not call for invisible components.
workaround: override isVisible method :
@Override
public boolean isVisible() {
return
Session.get().getFeedbackMessages().hasMessage(this.getFeedbackMessageFilter());
}
method onBeforeRender don't need override in
org.apache.wicket.markup.html.form.validation.FormComponentFeedbackIndicator
same situation with FormComponentFeedbackBorder .
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1139) Wicket html files do not have xml prolog
[ https://issues.apache.org/jira/browse/WICKET-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542488 ] Marat Radchenko commented on WICKET-1139: - Your files are ASCII-only and so they do not care a lot about exact encoding. You can specify UTF-8 or ISO 8859-1 (or some other because all encodings (as far as I know) have same byte numbers for ASCII symbols). Affected files (list may be incomplete): org/apache/wicket/markup/html/panel/FeedbackPanel.html org/apache/wicket/markup/html/panel/EmptyPanel.html org/apache/wicket/markup/html/pages/RedirectPage.html org/apache/wicket/markup/html/pages/PageExpiredErrorPage.html org/apache/wicket/markup/html/pages/InternalErrorPage.html org/apache/wicket/markup/html/pages/ExceptionErrorPage.html org/apache/wicket/markup/html/pages/AccessDeniedPage.html Wicket html files do not have xml prolog Key: WICKET-1139 URL: https://issues.apache.org/jira/browse/WICKET-1139 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.0-beta4 Environment: n/a Reporter: Marat Radchenko Fix For: 1.3.0-rc2 We want to enforce all our pages to explicitly specify xml prolog in order to avoid troubles with encodings (unfortunately we are not ASCII-speaking). We want to do that by specifying invalid defaultMarkupEncoding. This way we will get exceptions for all htmls that didn't declare encoding. However it is not possible at the moment because many wicket built-in html files do not have xml prolog. Fix is very simple: just add ?xml version=1.0 encoding=UTF-8 ? to your html files. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-1139) Wicket html files do not have xml prolog
Wicket html files do not have xml prolog Key: WICKET-1139 URL: https://issues.apache.org/jira/browse/WICKET-1139 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.0-beta4 Environment: n/a Reporter: Marat Radchenko We want to enforce all our pages to explicitly specify xml prolog in order to avoid troubles with encodings (unfortunately we are not ASCII-speaking). We want to do that by specifying invalid defaultMarkupEncoding. This way we will get exceptions for all htmls that didn't declare encoding. However it is not possible at the moment because many wicket built-in html files do not have xml prolog. Fix is very simple: just add ?xml version=1.0 encoding=UTF-8 ? to your html files. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1139) Wicket html files do not have xml prolog
[ https://issues.apache.org/jira/browse/WICKET-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541300 ] Marat Radchenko commented on WICKET-1139: - Well, I'm not speaking about outputting xml prolog to users. I'm speaking about using it when loading markup files. Wicket html files do not have xml prolog Key: WICKET-1139 URL: https://issues.apache.org/jira/browse/WICKET-1139 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.0-beta4 Environment: n/a Reporter: Marat Radchenko We want to enforce all our pages to explicitly specify xml prolog in order to avoid troubles with encodings (unfortunately we are not ASCII-speaking). We want to do that by specifying invalid defaultMarkupEncoding. This way we will get exceptions for all htmls that didn't declare encoding. However it is not possible at the moment because many wicket built-in html files do not have xml prolog. Fix is very simple: just add ?xml version=1.0 encoding=UTF-8 ? to your html files. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1139) Wicket html files do not have xml prolog
[ https://issues.apache.org/jira/browse/WICKET-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541302 ] Marat Radchenko commented on WICKET-1139: - That was just an example. You should specify real file encoding. The thing is that it will be explicitly specified and wicket won't rely on system default charset when loading them. Wicket html files do not have xml prolog Key: WICKET-1139 URL: https://issues.apache.org/jira/browse/WICKET-1139 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.0-beta4 Environment: n/a Reporter: Marat Radchenko We want to enforce all our pages to explicitly specify xml prolog in order to avoid troubles with encodings (unfortunately we are not ASCII-speaking). We want to do that by specifying invalid defaultMarkupEncoding. This way we will get exceptions for all htmls that didn't declare encoding. However it is not possible at the moment because many wicket built-in html files do not have xml prolog. Fix is very simple: just add ?xml version=1.0 encoding=UTF-8 ? to your html files. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-1139) Wicket html files do not have xml prolog
[ https://issues.apache.org/jira/browse/WICKET-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541300 ] slonopotamus edited comment on WICKET-1139 at 11/9/07 4:24 AM: -- Well, I'm not speaking about outputting xml prolog to users. I'm speaking about using it when loading markup files. Outputting xml prolog to users is handled by stripXmlDeclarationFromOutput in IMarkupSettings. was (Author: slonopotamus): Well, I'm not speaking about outputting xml prolog to users. I'm speaking about using it when loading markup files. Wicket html files do not have xml prolog Key: WICKET-1139 URL: https://issues.apache.org/jira/browse/WICKET-1139 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.0-beta4 Environment: n/a Reporter: Marat Radchenko We want to enforce all our pages to explicitly specify xml prolog in order to avoid troubles with encodings (unfortunately we are not ASCII-speaking). We want to do that by specifying invalid defaultMarkupEncoding. This way we will get exceptions for all htmls that didn't declare encoding. However it is not possible at the moment because many wicket built-in html files do not have xml prolog. Fix is very simple: just add ?xml version=1.0 encoding=UTF-8 ? to your html files. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1054) No way to escape html markup but keep non-7 bit characters in generated output
[
https://issues.apache.org/jira/browse/WICKET-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534615
]
Marat Radchenko commented on WICKET-1054:
-
Hi, Juergen
Could you tell me how we will be able to use described third option?
No way to escape html markup but keep non-7 bit characters in generated output
--
Key: WICKET-1054
URL: https://issues.apache.org/jira/browse/WICKET-1054
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.3.0-beta3
Reporter: Marat Radchenko
Assignee: Juergen Donnerstag
Fix For: 1.3.0-beta5
from Component#String getModelObjectAsString(Object):
==
if (getFlag(FLAG_ESCAPE_MODEL_STRINGS))
{
// Escape it
return Strings.escapeMarkup(modelString, false, true).toString();
}
return modelString;
==
As you can see, we have two options.
1) Output will be html-escaped and all non-7 bit characters will be replaced
with #; codes.
2) Nothing will be escaped.
These might be enough for ASCII-speaking people but not very friendly for
others.
We need third option:
escape html-sensitive characters (, , , etc) and do not modify all other
characters because it is very difficult to view html-escaped page source and
search engines are not happy with it.
This can be done by replacing if {} body with following code:
return Strings.escapeMarkup(modelString, false, false).toString();
Maybe some additional flag could be added in order to support such behavior?
Hope this will be fixed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-1054) No way to escape html markup but keep non-7 bit characters in generated output
No way to escape html markup but keep non-7 bit characters in generated output
--
Key: WICKET-1054
URL: https://issues.apache.org/jira/browse/WICKET-1054
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.3.0-beta3
Reporter: Marat Radchenko
from Component#String getModelObjectAsString(Object):
==
if (getFlag(FLAG_ESCAPE_MODEL_STRINGS))
{
// Escape it
return Strings.escapeMarkup(modelString, false, true).toString();
}
return modelString;
==
As you can see, we have two options.
1) Output will be html-escaped and all non-7 bit characters will be replaced
with #; codes.
2) Nothing will be escaped.
These might be enough for ASCII-speaking people but not very friendly for
others.
We need third option:
escape html-sensitive characters (, , , etc) and do not modify all other
characters because it is very difficult to view html-escaped page source and
search engines are not happy with it.
This can be done by replacing if {} body with following code:
return Strings.escapeMarkup(modelString, false, false).toString();
Maybe some additional flag could be added in order to support such behavior?
Hope this will be fixed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-908) There is no way to specify what exceptions to log in RequestCycle
[ https://issues.apache.org/jira/browse/WICKET-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524293 ] Marat Radchenko commented on WICKET-908: Oh, sorry. I didn't think about overriding logRuntimeException There is no way to specify what exceptions to log in RequestCycle - Key: WICKET-908 URL: https://issues.apache.org/jira/browse/WICKET-908 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.0-beta3 Reporter: Marat Radchenko Assignee: Juergen Donnerstag Priority: Critical Fix For: 1.3.0-beta4 RequestCycle, line 1135 logs all exceptions except for PageExpiredException. This is not a wanted behavior for us (for example, it also logs AuthorizationException which is not a error). So we need some way to specify which exceptions should be treated as errors and which ones are just need to be handled by RequestCycleProcessor#respond(RuntimeException, RequestCycle). Maybe there is some way to globally catch application exceptions other than writing a custom RequestCycleProcessor. If so then tell me please. The possible solution is to move exception logging to RequestCycleProcessor#respond(RuntimeException, RequestCycle) because it can be overriden. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-908) There is no way to specify what exceptions to log in RequestCycle
There is no way to specify what exceptions to log in RequestCycle - Key: WICKET-908 URL: https://issues.apache.org/jira/browse/WICKET-908 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.0-beta3 Reporter: Marat Radchenko Priority: Critical RequestCycle, line 1135 logs all exceptions except for PageExpiredException. This is not a wanted behavior for us (for example, it also logs AuthorizationException which is not a error). So we need some way to specify which exceptions should be treated as errors and which ones are just need to be handled by RequestCycleProcessor#respond(RuntimeException, RequestCycle). Maybe there is some way to globally catch application exceptions other than writing a custom RequestCycleProcessor. If so then tell me please. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-908) There is no way to specify what exceptions to log in RequestCycle
[ https://issues.apache.org/jira/browse/WICKET-908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marat Radchenko updated WICKET-908: --- Description: RequestCycle, line 1135 logs all exceptions except for PageExpiredException. This is not a wanted behavior for us (for example, it also logs AuthorizationException which is not a error). So we need some way to specify which exceptions should be treated as errors and which ones are just need to be handled by RequestCycleProcessor#respond(RuntimeException, RequestCycle). Maybe there is some way to globally catch application exceptions other than writing a custom RequestCycleProcessor. If so then tell me please. The possible solution is to move exception logging to RequestCycleProcessor#respond(RuntimeException, RequestCycle) because it can be overriden. was: RequestCycle, line 1135 logs all exceptions except for PageExpiredException. This is not a wanted behavior for us (for example, it also logs AuthorizationException which is not a error). So we need some way to specify which exceptions should be treated as errors and which ones are just need to be handled by RequestCycleProcessor#respond(RuntimeException, RequestCycle). Maybe there is some way to globally catch application exceptions other than writing a custom RequestCycleProcessor. If so then tell me please. There is no way to specify what exceptions to log in RequestCycle - Key: WICKET-908 URL: https://issues.apache.org/jira/browse/WICKET-908 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.0-beta3 Reporter: Marat Radchenko Priority: Critical RequestCycle, line 1135 logs all exceptions except for PageExpiredException. This is not a wanted behavior for us (for example, it also logs AuthorizationException which is not a error). So we need some way to specify which exceptions should be treated as errors and which ones are just need to be handled by RequestCycleProcessor#respond(RuntimeException, RequestCycle). Maybe there is some way to globally catch application exceptions other than writing a custom RequestCycleProcessor. If so then tell me please. The possible solution is to move exception logging to RequestCycleProcessor#respond(RuntimeException, RequestCycle) because it can be overriden. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-906) It is impossible to inject primitives
It is impossible to inject primitives - Key: WICKET-906 URL: https://issues.apache.org/jira/browse/WICKET-906 Project: Wicket Issue Type: Bug Components: wicket-spring Affects Versions: 1.3.0-beta3 Reporter: Marat Radchenko subj -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-609) Wicket should provide an easy method to generate absolute urls to bookmarkable pages
[
https://issues.apache.org/jira/browse/WICKET-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523860
]
Marat Radchenko commented on WICKET-609:
Solution:
{code:java}
String getAbsoluteUrl(final HttpServletRequest request, final String
servletPath) {
final StringBuffer requestUrl = request.getRequestURL();
final int start = requestUrl.length() - request.getServletPath().length();
final int end = requestUrl.length();
final StringBuffer absoluteContextPath = requestUrl.delete(start, end);
return absoluteContextPath.append(servletPath).toString();
}
final Page page = ...
HttpServletRequest req = ...
final String servletPath = / + RequestCycle.get().urlFor(page);
String absolutePageUrl = getAbsoluteUrl(req, servletPath);
{code}
Wicket should provide an easy method to generate absolute urls to
bookmarkable pages
Key: WICKET-609
URL: https://issues.apache.org/jira/browse/WICKET-609
Project: Wicket
Issue Type: Bug
Affects Versions: 1.3.0-beta1
Reporter: Ryan Crumley
Assignee: Alastair Maw
Priority: Minor
Fix For: 1.3.0-rc1
Currently there is no easy way to generate an absolute url for a bookmarkable
page. Something like getFullyQualifiedUrl(String contextRoot, Class page,
PageParameters parameters) would be ideal.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-609) Wicket should provide an easy method to generate absolute urls to bookmarkable pages
[
https://issues.apache.org/jira/browse/WICKET-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523889
]
Marat Radchenko commented on WICKET-609:
Solution, take two (how handles pages in different directories):
{code:java}
/**
* Calculates absolute path to url relative to another absolute url.
*
* @param requestPath absolute path.
* @param relativePagePath path, relative to requestPath
* @return absolute path for given url
*/
private static String toAbsolutePath(final String requestPath, final String
relativePagePath) {
final StringBuffer result;
if (requestPath.endsWith(/)) {
result = new StringBuffer(requestPath);
} else {
//Remove everything after last slash (but not slash itself)
result = new StringBuffer(requestPath.substring(0,
requestPath.lastIndexOf('/') + 1));
}
if (relativePagePath.startsWith(../)) {
StringBuffer tempRelative = new StringBuffer(relativePagePath);
//Go up through hierarchy until we find most common directory for both
pathes.
while (tempRelative.indexOf(../) == 0) {
//Delete ../ from relative path
tempRelative.delete(0, 3);
//Delete last slash from result
result.setLength(result.length() - 1);
//Delete everyting up to last slash
result.delete(result.lastIndexOf(/) + 1, result.length());
}
result.append(tempRelative);
} else {
//Pages are in the same directory
result.append(relativePagePath);
}
return result.toString();
}
{code}
Testing (should print 'true' three times [and prints]):
{code:java}
public static void main(String[] args) {
System.out.println(toAbsolutePath(http://aif.ru/test/test;,
../blah/zzz).equals(http://aif.ru/blah/zzz;));
System.out.println(toAbsolutePath(http://aif.ru/test;,
blah/zzz).equals(http://aif.ru/blah/zzz;));
System.out.println(toAbsolutePath(http://aif.ru/test/;,
../blah/zzz).equals(http://aif.ru/blah/zzz;));
}
{code}
Usage:
{code:java}
HttpServletRequest req = ...
final String relativePagePath= RequestCycle.get().urlFor(...);
final String absolutePageUrl = toAbsolutePath(req.getRequestURL().toString(),
relativePagePath);
{code}
Wicket should provide an easy method to generate absolute urls to
bookmarkable pages
Key: WICKET-609
URL: https://issues.apache.org/jira/browse/WICKET-609
Project: Wicket
Issue Type: Bug
Affects Versions: 1.3.0-beta1
Reporter: Ryan Crumley
Assignee: Alastair Maw
Priority: Minor
Fix For: 1.3.0-rc1
Currently there is no easy way to generate an absolute url for a bookmarkable
page. Something like getFullyQualifiedUrl(String contextRoot, Class page,
PageParameters parameters) would be ideal.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-609) Wicket should provide an easy method to generate absolute urls to bookmarkable pages
[
https://issues.apache.org/jira/browse/WICKET-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523892
]
Marat Radchenko commented on WICKET-609:
One more test (works):
{code:java}
System.out.println(toAbsolutePath(http://aif.ru/blah/test;,
zzz).equals(http://aif.ru/blah/zzz;));
{code}
Btw, why my code isn't highlighted?
Wicket should provide an easy method to generate absolute urls to
bookmarkable pages
Key: WICKET-609
URL: https://issues.apache.org/jira/browse/WICKET-609
Project: Wicket
Issue Type: Bug
Affects Versions: 1.3.0-beta1
Reporter: Ryan Crumley
Assignee: Alastair Maw
Priority: Minor
Fix For: 1.3.0-rc1
Currently there is no easy way to generate an absolute url for a bookmarkable
page. Something like getFullyQualifiedUrl(String contextRoot, Class page,
PageParameters parameters) would be ideal.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
