[jira] Reopened: (WICKET-3119) Localizer cache does not include style in cache key when no component is given

2010-10-20 Thread Nick Wiedenbrueck (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Wiedenbrueck reopened WICKET-3119:
---


That's the code when a component is given. I meant the code when no component 
is given (a couple of lines below that):

{code}
else
{
// locale is guaranteed to be != null
cacheKey += "-" + locale.toString();
}
{code}

> Localizer cache does not include style in cache key when no component is given
> --
>
> Key: WICKET-3119
> URL: https://issues.apache.org/jira/browse/WICKET-3119
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Reporter: Nick Wiedenbrueck
>Assignee: Igor Vaynberg
> Attachments: localizer.patch
>
>
> Localizer uses a cache internally to cache the results of getString() 
> methods. The getCacheKey() method creates the key for the cache entries:
> getCacheKey(final String key, final Component component, final Locale locale, 
> final String style, final String variation)
> When a null component is given, this method creates a cache key from the key 
> param and the locale param, but does not include the style param. When 
> switching between styles, this leads to unexpected behavior.
> I'll attach a patch with test cases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-3119) Localizer cache does not include style in cache key when no component is given

2010-10-19 Thread Nick Wiedenbrueck (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Wiedenbrueck updated WICKET-3119:
--

Attachment: localizer.patch

Patch with unit tests

> Localizer cache does not include style in cache key when no component is given
> --
>
> Key: WICKET-3119
> URL: https://issues.apache.org/jira/browse/WICKET-3119
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Reporter: Nick Wiedenbrueck
> Attachments: localizer.patch
>
>
> Localizer uses a cache internally to cache the results of getString() 
> methods. The getCacheKey() method creates the key for the cache entries:
> getCacheKey(final String key, final Component component, final Locale locale, 
> final String style, final String variation)
> When a null component is given, this method creates a cache key from the key 
> param and the locale param, but does not include the style param. When 
> switching between styles, this leads to unexpected behavior.
> I'll attach a patch with test cases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (WICKET-3119) Localizer cache does not include style in cache key when no component is given

2010-10-19 Thread Nick Wiedenbrueck (JIRA)
Localizer cache does not include style in cache key when no component is given
--

 Key: WICKET-3119
 URL: https://issues.apache.org/jira/browse/WICKET-3119
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Reporter: Nick Wiedenbrueck


Localizer uses a cache internally to cache the results of getString() methods. 
The getCacheKey() method creates the key for the cache entries:

getCacheKey(final String key, final Component component, final Locale locale, 
final String style, final String variation)

When a null component is given, this method creates a cache key from the key 
param and the locale param, but does not include the style param. When 
switching between styles this leads to unexpected behavior.

I'll attach a patch with test cases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-3119) Localizer cache does not include style in cache key when no component is given

2010-10-19 Thread Nick Wiedenbrueck (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Wiedenbrueck updated WICKET-3119:
--

Description: 
Localizer uses a cache internally to cache the results of getString() methods. 
The getCacheKey() method creates the key for the cache entries:

getCacheKey(final String key, final Component component, final Locale locale, 
final String style, final String variation)

When a null component is given, this method creates a cache key from the key 
param and the locale param, but does not include the style param. When 
switching between styles, this leads to unexpected behavior.

I'll attach a patch with test cases.

  was:
Localizer uses a cache internally to cache the results of getString() methods. 
The getCacheKey() method creates the key for the cache entries:

getCacheKey(final String key, final Component component, final Locale locale, 
final String style, final String variation)

When a null component is given, this method creates a cache key from the key 
param and the locale param, but does not include the style param. When 
switching between styles this leads to unexpected behavior.

I'll attach a patch with test cases.


> Localizer cache does not include style in cache key when no component is given
> --
>
> Key: WICKET-3119
> URL: https://issues.apache.org/jira/browse/WICKET-3119
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Reporter: Nick Wiedenbrueck
>
> Localizer uses a cache internally to cache the results of getString() 
> methods. The getCacheKey() method creates the key for the cache entries:
> getCacheKey(final String key, final Component component, final Locale locale, 
> final String style, final String variation)
> When a null component is given, this method creates a cache key from the key 
> param and the locale param, but does not include the style param. When 
> switching between styles, this leads to unexpected behavior.
> I'll attach a patch with test cases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (WICKET-2340) Make ModificationWatcher replacable

2009-06-23 Thread Nick Wiedenbrueck (JIRA)
Make ModificationWatcher replacable
---

 Key: WICKET-2340
 URL: https://issues.apache.org/jira/browse/WICKET-2340
 Project: Wicket
  Issue Type: Improvement
  Components: wicket
 Environment: Mainly on Google App Engine
Reporter: Nick Wiedenbrueck


Google App Engine does not allow applications to spawn threads. But Wicket's 
ModificationWatcher does so. So, deploying Wicket applications on GAE will not 
work in debug mode, even when deploying on the local app engine development 
environment.

It would be nice, if  it would be possible to use a different 
ModificationWatcher that does not spawn Threads. The Problem is, that 

A) ModificationWatcher is not an Interface but a concrete class
B) ModificationWatcher is final

As a bonus it would be nice to have an optional  ModificationWatcher 
implementation in the wicket core that does not rely on threads, but instead 
checks Resources before every request, for example.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (WICKET-1186) Ajax Memory Leak in IE

2007-11-26 Thread Nick Wiedenbrueck (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-1186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Wiedenbrueck updated WICKET-1186:
--

Attachment: WicketIEMemLeak.zip

Quickstart project. Try paging through the user list.

> Ajax Memory Leak in IE
> --
>
> Key: WICKET-1186
> URL: https://issues.apache.org/jira/browse/WICKET-1186
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.3.0-rc1
> Environment: Win XP
> IE 6
>Reporter: Nick Wiedenbrueck
> Attachments: WicketIEMemLeak.zip
>
>
> Memory Leak in IE6 (IE7?) when using a DataView with AjaxPagingNavigator and 
> each entry of the DataView table contains an AjaxLink. Memory increases by 
> more than 500KB when displaying 100 items per page. AjaxDebugMode is 
> disabled. Configuration is set to deployment. Version 1.2.6 is working fine. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (WICKET-1186) Ajax Memory Leak in IE

2007-11-26 Thread Nick Wiedenbrueck (JIRA)
Ajax Memory Leak in IE
--

 Key: WICKET-1186
 URL: https://issues.apache.org/jira/browse/WICKET-1186
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 1.3.0-rc1
 Environment: Win XP
IE 6
Reporter: Nick Wiedenbrueck


Memory Leak in IE6 (IE7?) when using a DataView with AjaxPagingNavigator and 
each entry of the DataView table contains an AjaxLink. Memory increases by more 
than 500KB when displaying 100 items per page. AjaxDebugMode is disabled. 
Configuration is set to deployment. Version 1.2.6 is working fine. 


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.