[jira] [Commented] (WICKET-6546) CssContentHeaderItem comments CSS code with HTML comments
[ https://issues.apache.org/jira/browse/WICKET-6546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424629#comment-16424629 ] Robert Niestroj commented on WICKET-6546: - Can you merge this also to Wicket 7 and 8 if the issue is there as well? > CssContentHeaderItem comments CSS code with HTML comments > - > > Key: WICKET-6546 > URL: https://issues.apache.org/jira/browse/WICKET-6546 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 6.24.0, 6.29.0 >Reporter: Robert Niestroj >Assignee: Maxim Solodovnik >Priority: Minor > Attachments: wicket6546 (2).zip > > > CssContentHeaderItem wraps the passed CSS in HTML comments thus rendering > invalid markup. > Example code: > > {code:java} > @Override > public void renderHead(Component component, IHeaderResponse response) { > super.renderHead(component, response); > response.render(CssContentHeaderItem.forCSS(".select2-container--open > {z-index: 10;}", "select2-mod", "")); > } > {code} > Renders: > > {code:java} > > > {code} > The HTML comments in the CSS make the response invalid and in the browser you > get a XML Parsing Error - Not Well Formed. > > It should not render this invalid html comments in CSS. > Looking at the source code i think the error is in the CssUtils class: > https://github.com/apache/wicket/blob/wicket-6.x/wicket-core/src/main/java/org/apache/wicket/core/util/string/CssUtils.java > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (WICKET-6546) CssContentHeaderItem comments CSS code with HTML comments
[ https://issues.apache.org/jira/browse/WICKET-6546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16418515#comment-16418515 ] Robert Niestroj edited comment on WICKET-6546 at 3/29/18 7:09 AM: -- CSS comments should be /* */ and not as per [https://developer.mozilla.org/en-US/docs/Web/CSS/Comments#Notes] Also the added CSS should not be commented at all. I just want it to be. Attached another QS with the error visible in browser console. Click the AjaxLink. Tested on recent Firefox Developer and Chrome Stable. In chrome the logged error is: {code:java} wicket-ajax-jquery-debug-ver-1518883664000.js:131 Wicket.Ajax: Error in parsing: This page contains the following errors:error on line 2 at column 19: Double hyphen within comment: as per [https://developer.mozilla.org/en-US/docs/Web/CSS/Comments#Notes] Also the added CSS should not be commented at all. I just want it to be. Attached another QS with the error visible in browser console. Click the AjaxLink. Tested on recent Firefox Developer and Chrome Stable. In chrome the logged error is: {code:java} wicket-ajax-jquery-debug-ver-1518883664000.js:131 Wicket.Ajax: Error in parsing: This page contains the following errors:error on line 2 at column 19: Double hyphen within comment: > Key: WICKET-6546 > URL: https://issues.apache.org/jira/browse/WICKET-6546 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 6.24.0, 6.29.0 >Reporter: Robert Niestroj >Priority: Minor > Attachments: wicket6546 (2).zip > > > CssContentHeaderItem wraps the passed CSS in HTML comments thus rendering > invalid markup. > Example code: > > {code:java} > @Override > public void renderHead(Component component, IHeaderResponse response) { > super.renderHead(component, response); > response.render(CssContentHeaderItem.forCSS(".select2-container--open > {z-index: 10;}", "select2-mod", "")); > } > {code} > Renders: > > {code:java} > > > {code} > The HTML comments in the CSS make the response invalid and in the browser you > get a XML Parsing Error - Not Well Formed. > > It should not render this invalid html comments in CSS. > Looking at the source code i think the error is in the CssUtils class: > https://github.com/apache/wicket/blob/wicket-6.x/wicket-core/src/main/java/org/apache/wicket/core/util/string/CssUtils.java > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (WICKET-6546) CssContentHeaderItem comments CSS code with HTML comments
[ https://issues.apache.org/jira/browse/WICKET-6546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16418515#comment-16418515 ] Robert Niestroj edited comment on WICKET-6546 at 3/29/18 7:03 AM: -- CSS comments should be /* */ and not as per [https://developer.mozilla.org/en-US/docs/Web/CSS/Comments#Notes] Also the added CSS should not be commented at all. I just want it to be. Attached another QS with the error visible in browser console. Click the AjaxLink. Tested on recent Firefox Developer and Chrome Stable. In chrome the logged error is: {code:java} wicket-ajax-jquery-debug-ver-1518883664000.js:131 Wicket.Ajax: Error in parsing: This page contains the following errors:error on line 2 at column 19: Double hyphen within comment: as per [https://developer.mozilla.org/en-US/docs/Web/CSS/Comments#Notes] Also the added CSS should not be commented at all. I just want it to be. Attached another QS with the error visible in browser console. Click the AjaxLink. Tested on recent Firefox Developer and Chrome Stable. In chrome the logged error is: wicket-ajax-jquery-debug-ver-1518883664000.js:131 Wicket.Ajax: Error in parsing: This page contains the following errors:error on line 2 at column 19: Double hyphen within comment: > Key: WICKET-6546 > URL: https://issues.apache.org/jira/browse/WICKET-6546 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 6.24.0, 6.29.0 >Reporter: Robert Niestroj >Priority: Minor > Attachments: wicket6546 (2).zip > > > CssContentHeaderItem wraps the passed CSS in HTML comments thus rendering > invalid markup. > Example code: > > {code:java} > @Override > public void renderHead(Component component, IHeaderResponse response) { > super.renderHead(component, response); > response.render(CssContentHeaderItem.forCSS(".select2-container--open > {z-index: 10;}", "select2-mod", "")); > } > {code} > Renders: > > {code:java} > > > {code} > The HTML comments in the CSS make the response invalid and in the browser you > get a XML Parsing Error - Not Well Formed. > > It should not render this invalid html comments in CSS. > Looking at the source code i think the error is in the CssUtils class: > https://github.com/apache/wicket/blob/wicket-6.x/wicket-core/src/main/java/org/apache/wicket/core/util/string/CssUtils.java > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (WICKET-6546) CssContentHeaderItem comments CSS code with HTML comments
[ https://issues.apache.org/jira/browse/WICKET-6546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Niestroj updated WICKET-6546: Attachment: (was: wicket6546.zip) > CssContentHeaderItem comments CSS code with HTML comments > - > > Key: WICKET-6546 > URL: https://issues.apache.org/jira/browse/WICKET-6546 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 6.24.0, 6.29.0 >Reporter: Robert Niestroj >Priority: Minor > Attachments: wicket6546 (2).zip > > > CssContentHeaderItem wraps the passed CSS in HTML comments thus rendering > invalid markup. > Example code: > > {code:java} > @Override > public void renderHead(Component component, IHeaderResponse response) { > super.renderHead(component, response); > response.render(CssContentHeaderItem.forCSS(".select2-container--open > {z-index: 10;}", "select2-mod", "")); > } > {code} > Renders: > > {code:java} > > > {code} > The HTML comments in the CSS make the response invalid and in the browser you > get a XML Parsing Error - Not Well Formed. > > It should not render this invalid html comments in CSS. > Looking at the source code i think the error is in the CssUtils class: > https://github.com/apache/wicket/blob/wicket-6.x/wicket-core/src/main/java/org/apache/wicket/core/util/string/CssUtils.java > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6546) CssContentHeaderItem comments CSS code with HTML comments
[ https://issues.apache.org/jira/browse/WICKET-6546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16418515#comment-16418515 ] Robert Niestroj commented on WICKET-6546: - CSS comments should be /* */ and not as per [https://developer.mozilla.org/en-US/docs/Web/CSS/Comments#Notes] Also the added CSS should not be commented at all. I just want it to be. Attached another QS with the error visible in browser console. Click the AjaxLink. Tested on recent Firefox Developer and Chrome Stable. In chrome the logged error is: wicket-ajax-jquery-debug-ver-1518883664000.js:131 Wicket.Ajax: Error in parsing: This page contains the following errors:error on line 2 at column 19: Double hyphen within comment: > Key: WICKET-6546 > URL: https://issues.apache.org/jira/browse/WICKET-6546 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 6.24.0, 6.29.0 >Reporter: Robert Niestroj >Priority: Minor > Attachments: wicket6546 (2).zip, wicket6546.zip > > > CssContentHeaderItem wraps the passed CSS in HTML comments thus rendering > invalid markup. > Example code: > > {code:java} > @Override > public void renderHead(Component component, IHeaderResponse response) { > super.renderHead(component, response); > response.render(CssContentHeaderItem.forCSS(".select2-container--open > {z-index: 10;}", "select2-mod", "")); > } > {code} > Renders: > > {code:java} > > > {code} > The HTML comments in the CSS make the response invalid and in the browser you > get a XML Parsing Error - Not Well Formed. > > It should not render this invalid html comments in CSS. > Looking at the source code i think the error is in the CssUtils class: > https://github.com/apache/wicket/blob/wicket-6.x/wicket-core/src/main/java/org/apache/wicket/core/util/string/CssUtils.java > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (WICKET-6546) CssContentHeaderItem comments CSS code with HTML comments
[ https://issues.apache.org/jira/browse/WICKET-6546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Niestroj updated WICKET-6546: Attachment: wicket6546 (2).zip > CssContentHeaderItem comments CSS code with HTML comments > - > > Key: WICKET-6546 > URL: https://issues.apache.org/jira/browse/WICKET-6546 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 6.24.0, 6.29.0 >Reporter: Robert Niestroj >Priority: Minor > Attachments: wicket6546 (2).zip, wicket6546.zip > > > CssContentHeaderItem wraps the passed CSS in HTML comments thus rendering > invalid markup. > Example code: > > {code:java} > @Override > public void renderHead(Component component, IHeaderResponse response) { > super.renderHead(component, response); > response.render(CssContentHeaderItem.forCSS(".select2-container--open > {z-index: 10;}", "select2-mod", "")); > } > {code} > Renders: > > {code:java} > > > {code} > The HTML comments in the CSS make the response invalid and in the browser you > get a XML Parsing Error - Not Well Formed. > > It should not render this invalid html comments in CSS. > Looking at the source code i think the error is in the CssUtils class: > https://github.com/apache/wicket/blob/wicket-6.x/wicket-core/src/main/java/org/apache/wicket/core/util/string/CssUtils.java > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6546) CssContentHeaderItem comments CSS code with HTML comments
[ https://issues.apache.org/jira/browse/WICKET-6546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417991#comment-16417991 ] Robert Niestroj commented on WICKET-6546: - Quickstart attached. The page works here, but the comments in the CSS is also there. > CssContentHeaderItem comments CSS code with HTML comments > - > > Key: WICKET-6546 > URL: https://issues.apache.org/jira/browse/WICKET-6546 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 6.24.0, 6.29.0 >Reporter: Robert Niestroj >Priority: Minor > Attachments: wicket6546.zip > > > CssContentHeaderItem wraps the passed CSS in HTML comments thus rendering > invalid markup. > Example code: > > {code:java} > @Override > public void renderHead(Component component, IHeaderResponse response) { > super.renderHead(component, response); > response.render(CssContentHeaderItem.forCSS(".select2-container--open > {z-index: 10;}", "select2-mod", "")); > } > {code} > Renders: > > {code:java} > > > {code} > The HTML comments in the CSS make the response invalid and in the browser you > get a XML Parsing Error - Not Well Formed. > > It should not render this invalid html comments in CSS. > Looking at the source code i think the error is in the CssUtils class: > https://github.com/apache/wicket/blob/wicket-6.x/wicket-core/src/main/java/org/apache/wicket/core/util/string/CssUtils.java > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (WICKET-6546) CssContentHeaderItem comments CSS code with HTML comments
[ https://issues.apache.org/jira/browse/WICKET-6546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Niestroj updated WICKET-6546: Attachment: wicket6546.zip > CssContentHeaderItem comments CSS code with HTML comments > - > > Key: WICKET-6546 > URL: https://issues.apache.org/jira/browse/WICKET-6546 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 6.24.0, 6.29.0 >Reporter: Robert Niestroj >Priority: Minor > Attachments: wicket6546.zip > > > CssContentHeaderItem wraps the passed CSS in HTML comments thus rendering > invalid markup. > Example code: > > {code:java} > @Override > public void renderHead(Component component, IHeaderResponse response) { > super.renderHead(component, response); > response.render(CssContentHeaderItem.forCSS(".select2-container--open > {z-index: 10;}", "select2-mod", "")); > } > {code} > Renders: > > {code:java} > > > {code} > The HTML comments in the CSS make the response invalid and in the browser you > get a XML Parsing Error - Not Well Formed. > > It should not render this invalid html comments in CSS. > Looking at the source code i think the error is in the CssUtils class: > https://github.com/apache/wicket/blob/wicket-6.x/wicket-core/src/main/java/org/apache/wicket/core/util/string/CssUtils.java > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (WICKET-6546) CssContentHeaderItem comments CSS code with HTML comments
[ https://issues.apache.org/jira/browse/WICKET-6546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Niestroj updated WICKET-6546: Affects Version/s: 6.29.0 > CssContentHeaderItem comments CSS code with HTML comments > - > > Key: WICKET-6546 > URL: https://issues.apache.org/jira/browse/WICKET-6546 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 6.24.0, 6.29.0 >Reporter: Robert Niestroj >Priority: Minor > > CssContentHeaderItem wraps the passed CSS in HTML comments thus rendering > invalid markup. > Example code: > > {code:java} > @Override > public void renderHead(Component component, IHeaderResponse response) { > super.renderHead(component, response); > response.render(CssContentHeaderItem.forCSS(".select2-container--open > {z-index: 10;}", "select2-mod", "")); > } > {code} > Renders: > > {code:java} > > > {code} > The HTML comments in the CSS make the response invalid and in the browser you > get a XML Parsing Error - Not Well Formed. > > It should not render this invalid html comments in CSS. > Looking at the source code i think the error is in the CssUtils class: > https://github.com/apache/wicket/blob/wicket-6.x/wicket-core/src/main/java/org/apache/wicket/core/util/string/CssUtils.java > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (WICKET-6546) CssContentHeaderItem comments CSS code with HTML comments
[ https://issues.apache.org/jira/browse/WICKET-6546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Niestroj updated WICKET-6546: Description: CssContentHeaderItem wraps the passed CSS in HTML comments thus rendering invalid markup. Example code: {code:java} @Override public void renderHead(Component component, IHeaderResponse response) { super.renderHead(component, response); response.render(CssContentHeaderItem.forCSS(".select2-container--open {z-index: 10;}", "select2-mod", "")); } {code} Renders: {code:java} {code} The HTML comments in the CSS make the response invalid and in the browser you get a XML Parsing Error - Not Well Formed. It should not render this invalid html comments in CSS. Looking at the source code i think the error is in the CssUtils class: https://github.com/apache/wicket/blob/wicket-6.x/wicket-core/src/main/java/org/apache/wicket/core/util/string/CssUtils.java was: CssContentHeaderItem wraps the passed CSS in HTML comments thus rendering invalid markup. Example code: {code:java} @Override public void renderHead(Component component, IHeaderResponse response) { super.renderHead(component, response); response.render(CssContentHeaderItem.forCSS(".select2-container--open {z-index: 10;}", "select2-mod", "")); } {code} Renders: {code:java} {code} The HTML comments in the CSS make the response invalid and in the browser you get a XML Parsing Error - Not Well Formed. It should not render this invalid html comments in CSS. > CssContentHeaderItem comments CSS code with HTML comments > - > > Key: WICKET-6546 > URL: https://issues.apache.org/jira/browse/WICKET-6546 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 6.24.0 >Reporter: Robert Niestroj >Priority: Minor > > CssContentHeaderItem wraps the passed CSS in HTML comments thus rendering > invalid markup. > Example code: > > {code:java} > @Override > public void renderHead(Component component, IHeaderResponse response) { > super.renderHead(component, response); > response.render(CssContentHeaderItem.forCSS(".select2-container--open > {z-index: 10;}", "select2-mod", "")); > } > {code} > Renders: > > {code:java} > > > {code} > The HTML comments in the CSS make the response invalid and in the browser you > get a XML Parsing Error - Not Well Formed. > > It should not render this invalid html comments in CSS. > Looking at the source code i think the error is in the CssUtils class: > https://github.com/apache/wicket/blob/wicket-6.x/wicket-core/src/main/java/org/apache/wicket/core/util/string/CssUtils.java > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (WICKET-6546) CssContentHeaderItem comments CSS code with HTML comments
Robert Niestroj created WICKET-6546: --- Summary: CssContentHeaderItem comments CSS code with HTML comments Key: WICKET-6546 URL: https://issues.apache.org/jira/browse/WICKET-6546 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.24.0 Reporter: Robert Niestroj CssContentHeaderItem wraps the passed CSS in HTML comments thus rendering invalid markup. Example code: {code:java} @Override public void renderHead(Component component, IHeaderResponse response) { super.renderHead(component, response); response.render(CssContentHeaderItem.forCSS(".select2-container--open {z-index: 10;}", "select2-mod", "")); } {code} Renders: {code:java} {code} The HTML comments in the CSS make the response invalid and in the browser you get a XML Parsing Error - Not Well Formed. It should not render this invalid html comments in CSS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6197) Some JavaScript not executed on Firefox and multipart Forms
[ https://issues.apache.org/jira/browse/WICKET-6197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363963#comment-15363963 ] Robert Niestroj commented on WICKET-6197: - Yep, that works. Is this a bug in Wicket? > Some JavaScript not executed on Firefox and multipart Forms > --- > > Key: WICKET-6197 > URL: https://issues.apache.org/jira/browse/WICKET-6197 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.3.0 > Environment: Windows 7 x64, Firefox Developer Edition 49.0.a2 but > also on firefox Stable 47, verified on 3 different PCs (my Win7, two Win 10) >Reporter: Robert Niestroj > Attachments: IMG_05072016_162356.png, qs.zip > > > When i have a multipart Form and an AjaxSubmitLink where i want to open the > the browsers print dialog it is not working. > protected void onSubmit(AjaxRequestTarget target, Form form) { > super.onSubmit(target, form); > target.appendJavaScript("window.print();"); > } > However alert(1); is working. > When i remove setMultiPart(true) from the form it is working so i has > something to do with it. It might be the dot. > it is not working under Firefox, it works under Chrome. > When i click my print button a few times in quick succession firefox shows a > dialog "Prevent this page from creating additional dialogs" - see screenshot. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6197) Some JavaScript not executed on Firefox and multipart Forms
[ https://issues.apache.org/jira/browse/WICKET-6197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Niestroj updated WICKET-6197: Description: When i have a multipart Form and an AjaxSubmitLink where i want to open the the browsers print dialog it is not working. protected void onSubmit(AjaxRequestTarget target, Form form) { super.onSubmit(target, form); target.appendJavaScript("window.print();"); } However alert(1); is working. When i remove setMultiPart(true) from the form it is working so i has something to do with it. It might be the dot. it is not working under Firefox, it works under Chrome. When i click my print button a few times in quick succession firefox shows a dialog "Prevent this page from creating additional dialogs" - see screenshot. was: When i have a multipart Form and an AjaxSubmitLink where i want to open the the browsers print dialog it is not working. protected void onSubmit(AjaxRequestTarget target, Form form) { super.onSubmit(target, form); target.appendJavaScript("window.print();"); } However alert(1); is working. When i remove setMultiPart(true) from the form it is working so i has something to do with it. It might be the dot. > Some JavaScript not executed on Firefox and multipart Forms > --- > > Key: WICKET-6197 > URL: https://issues.apache.org/jira/browse/WICKET-6197 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.3.0 > Environment: Windows 7 x64, Firefox Developer Edition 49.0.a2 but > also on firefox Stable 47, verified on 3 different PCs (my Win7, two Win 10) >Reporter: Robert Niestroj > Attachments: IMG_05072016_162356.png, qs.zip > > > When i have a multipart Form and an AjaxSubmitLink where i want to open the > the browsers print dialog it is not working. > protected void onSubmit(AjaxRequestTarget target, Form form) { > super.onSubmit(target, form); > target.appendJavaScript("window.print();"); > } > However alert(1); is working. > When i remove setMultiPart(true) from the form it is working so i has > something to do with it. It might be the dot. > it is not working under Firefox, it works under Chrome. > When i click my print button a few times in quick succession firefox shows a > dialog "Prevent this page from creating additional dialogs" - see screenshot. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6197) Some JavaScript not executed on Firefox and multipart Forms
[ https://issues.apache.org/jira/browse/WICKET-6197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Niestroj updated WICKET-6197: Attachment: IMG_05072016_162356.png > Some JavaScript not executed on Firefox and multipart Forms > --- > > Key: WICKET-6197 > URL: https://issues.apache.org/jira/browse/WICKET-6197 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.3.0 > Environment: Windows 7 x64, Firefox Developer Edition 49.0.a2 but > also on firefox Stable 47, verified on 3 different PCs (my Win7, two Win 10) >Reporter: Robert Niestroj > Attachments: IMG_05072016_162356.png, qs.zip > > > When i have a multipart Form and an AjaxSubmitLink where i want to open the > the browsers print dialog it is not working. > protected void onSubmit(AjaxRequestTarget target, Form form) { > super.onSubmit(target, form); > target.appendJavaScript("window.print();"); > } > However alert(1); is working. > When i remove setMultiPart(true) from the form it is working so i has > something to do with it. It might be the dot. > it is not working under Firefox, it works under Chrome. > When i click my print button a few times in quick succession firefox shows a > dialog "Prevent this page from creating additional dialogs" - see screenshot. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6197) Some JavaScript not executed on Firefox and multipart Forms
[ https://issues.apache.org/jira/browse/WICKET-6197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Niestroj updated WICKET-6197: Attachment: qs.zip Quickstart > Some JavaScript not executed on Firefox and multipart Forms > --- > > Key: WICKET-6197 > URL: https://issues.apache.org/jira/browse/WICKET-6197 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.3.0 > Environment: Windows 7 x64, Firefox Developer Edition 49.0.a2 but > also on firefox Stable 47, verified on 3 different PCs (my Win7, two Win 10) >Reporter: Robert Niestroj > Attachments: qs.zip > > > When i have a multipart Form and an AjaxSubmitLink where i want to open the > the browsers print dialog it is not working. > protected void onSubmit(AjaxRequestTarget target, Form form) { > super.onSubmit(target, form); > target.appendJavaScript("window.print();"); > } > However alert(1); is working. > When i remove setMultiPart(true) from the form it is working so i has > something to do with it. It might be the dot. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6197) Some JavaScript not executed on Firefox and multipart Forms
[ https://issues.apache.org/jira/browse/WICKET-6197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Niestroj updated WICKET-6197: Description: When i have a multipart Form and an AjaxSubmitLink where i want to open the the browsers print dialog it is not working. {{a protected void onSubmit(AjaxRequestTarget target, Form form) { super.onSubmit(target, form); target.appendJavaScript("window.print();"); } a}} However alert(1); is working. When i remove setMultiPart(true) from the form it is working so i has something to do with it. It might be the dot. was: When i have a multipart Form and an AjaxSubmitLink where i want to open the the browsers print dialog it is not working. {{aaa}} protected void onSubmit(AjaxRequestTarget target, Form form) { super.onSubmit(target, form); target.appendJavaScript("window.print();"); } However alert(1); is working. When i remove setMultiPart(true) from the form it is working so i has something to do with it. It might be the dot. > Some JavaScript not executed on Firefox and multipart Forms > --- > > Key: WICKET-6197 > URL: https://issues.apache.org/jira/browse/WICKET-6197 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.3.0 > Environment: Windows 7 x64, Firefox Developer Edition 49.0.a2 but > also on firefox Stable 47, verified on 3 different PCs (my Win7, two Win 10) >Reporter: Robert Niestroj > > When i have a multipart Form and an AjaxSubmitLink where i want to open the > the browsers print dialog it is not working. > {{a > protected void onSubmit(AjaxRequestTarget target, Form form) { > super.onSubmit(target, form); > target.appendJavaScript("window.print();"); > } > a}} > However alert(1); is working. > When i remove setMultiPart(true) from the form it is working so i has > something to do with it. It might be the dot. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6197) Some JavaScript not executed on Firefox and multipart Forms
[ https://issues.apache.org/jira/browse/WICKET-6197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Niestroj updated WICKET-6197: Description: When i have a multipart Form and an AjaxSubmitLink where i want to open the the browsers print dialog it is not working. protected void onSubmit(AjaxRequestTarget target, Form form) { super.onSubmit(target, form); target.appendJavaScript("window.print();"); } However alert(1); is working. When i remove setMultiPart(true) from the form it is working so i has something to do with it. It might be the dot. was: When i have a multipart Form and an AjaxSubmitLink where i want to open the the browsers print dialog it is not working. {{a protected void onSubmit(AjaxRequestTarget target, Form form) { super.onSubmit(target, form); target.appendJavaScript("window.print();"); } a}} However alert(1); is working. When i remove setMultiPart(true) from the form it is working so i has something to do with it. It might be the dot. > Some JavaScript not executed on Firefox and multipart Forms > --- > > Key: WICKET-6197 > URL: https://issues.apache.org/jira/browse/WICKET-6197 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.3.0 > Environment: Windows 7 x64, Firefox Developer Edition 49.0.a2 but > also on firefox Stable 47, verified on 3 different PCs (my Win7, two Win 10) >Reporter: Robert Niestroj > > When i have a multipart Form and an AjaxSubmitLink where i want to open the > the browsers print dialog it is not working. > protected void onSubmit(AjaxRequestTarget target, Form form) { > super.onSubmit(target, form); > target.appendJavaScript("window.print();"); > } > However alert(1); is working. > When i remove setMultiPart(true) from the form it is working so i has > something to do with it. It might be the dot. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (WICKET-6197) Some JavaScript not executed on Firefox and multipart Forms
Robert Niestroj created WICKET-6197: --- Summary: Some JavaScript not executed on Firefox and multipart Forms Key: WICKET-6197 URL: https://issues.apache.org/jira/browse/WICKET-6197 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 7.3.0 Environment: Windows 7 x64, Firefox Developer Edition 49.0.a2 but also on firefox Stable 47, verified on 3 different PCs (my Win7, two Win 10) Reporter: Robert Niestroj When i have a multipart Form and an AjaxSubmitLink where i want to open the the browsers print dialog it is not working. protected void onSubmit(AjaxRequestTarget target, Form form) { super.onSubmit(target, form); target.appendJavaScript("window.print();"); } However alert(1); is working. When i remove setMultiPart(true) from the form it is working so i has something to do with it. It might be the dot. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6197) Some JavaScript not executed on Firefox and multipart Forms
[ https://issues.apache.org/jira/browse/WICKET-6197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Niestroj updated WICKET-6197: Description: When i have a multipart Form and an AjaxSubmitLink where i want to open the the browsers print dialog it is not working. {{aaa}} protected void onSubmit(AjaxRequestTarget target, Form form) { super.onSubmit(target, form); target.appendJavaScript("window.print();"); } However alert(1); is working. When i remove setMultiPart(true) from the form it is working so i has something to do with it. It might be the dot. was: When i have a multipart Form and an AjaxSubmitLink where i want to open the the browsers print dialog it is not working. protected void onSubmit(AjaxRequestTarget target, Form form) { super.onSubmit(target, form); target.appendJavaScript("window.print();"); } However alert(1); is working. When i remove setMultiPart(true) from the form it is working so i has something to do with it. It might be the dot. > Some JavaScript not executed on Firefox and multipart Forms > --- > > Key: WICKET-6197 > URL: https://issues.apache.org/jira/browse/WICKET-6197 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.3.0 > Environment: Windows 7 x64, Firefox Developer Edition 49.0.a2 but > also on firefox Stable 47, verified on 3 different PCs (my Win7, two Win 10) >Reporter: Robert Niestroj > > When i have a multipart Form and an AjaxSubmitLink where i want to open the > the browsers print dialog it is not working. > {{aaa}} > protected void onSubmit(AjaxRequestTarget target, Form form) { > super.onSubmit(target, form); > target.appendJavaScript("window.print();"); > } > However alert(1); is working. > When i remove setMultiPart(true) from the form it is working so i has > something to do with it. It might be the dot. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (WICKET-6095) Multiline headers in DataTable
Robert Niestroj created WICKET-6095: --- Summary: Multiline headers in DataTable Key: WICKET-6095 URL: https://issues.apache.org/jira/browse/WICKET-6095 Project: Wicket Issue Type: Wish Components: wicket-extensions Affects Versions: 7.3.0 Reporter: Robert Niestroj Priority: Minor Please add the posibility to create multiline headers for DataTables with the current sorting functionality. Right now you have to you can circumvent this by hardcoding the headers in HTML and using a ListView as but that's incovenient. http://stackoverflow.com/questions/35039896/multiline-table-header-in-wicket https://github.com/wicketstuff/core/blob/ebc873384dea5ee0cf9ab6f621a3419862a6c8f1/datatables-parent/datatables/src/main/java/org/wicketstuff/datatables/columns/SpanHeadersToolbar.java#L97-L99 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-5956) OnChangeAjaxBeavior conflicting with autoNumeric.js plugin
[ https://issues.apache.org/jira/browse/WICKET-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Niestroj updated WICKET-5956: Description: I have a problem with the OnChangeAjaxBehavior in conjunction with the autoNumeric.js (http://www.decorplanit.com/plugin/, https://github.com/BobKnothe/autoNumeric) plugin. The OnChangeAjaxBehavior is not reconigzing changes (onUpdate is not being called) in an TextField while typing when an autonumeric.js plugin is attached to it. It sees changes when i leave the TextField. I will try to attach a quickstart. was: I have a problem with the OnChangeAjaxBehavior in conjunction with the autoNumeric.js (http://www.decorplanit.com/plugin/, https://github.com/BobKnothe/autoNumeric) plugin. The OnChangeAjaxBehavior is not reconigzing changes in an TextField while typing when an autonumeric.js plugin is attached to it. It sees changes when i leave the TextField. I will try to attach a quickstart. > OnChangeAjaxBeavior conflicting with autoNumeric.js plugin > -- > > Key: WICKET-5956 > URL: https://issues.apache.org/jira/browse/WICKET-5956 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 6.20.0 > Environment: Windows 7, Firefox 40, Wicket 6.20, autonumeric 1.39.9 >Reporter: Robert Niestroj > Labels: behavior, changes, input, textfield > Attachments: mavenproject2.zip > > > I have a problem with the OnChangeAjaxBehavior in conjunction with the > autoNumeric.js (http://www.decorplanit.com/plugin/, > https://github.com/BobKnothe/autoNumeric) plugin. The OnChangeAjaxBehavior is > not reconigzing changes (onUpdate is not being called) in an TextField while > typing when an autonumeric.js plugin is attached to it. It sees changes when > i leave the TextField. > I will try to attach a quickstart. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-5956) OnChangeAjaxBeavior conflicting with autoNumeric.js plugin
[ https://issues.apache.org/jira/browse/WICKET-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Niestroj updated WICKET-5956: Labels: behavior changes input textfield (was: ) > OnChangeAjaxBeavior conflicting with autoNumeric.js plugin > -- > > Key: WICKET-5956 > URL: https://issues.apache.org/jira/browse/WICKET-5956 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 6.20.0 > Environment: Windows 7, Firefox 40, Wicket 6.20, autonumeric 1.39.9 >Reporter: Robert Niestroj > Labels: behavior, changes, input, textfield > Attachments: mavenproject2.zip > > > I have a problem with the OnChangeAjaxBehavior in conjunction with the > autoNumeric.js (http://www.decorplanit.com/plugin/, > https://github.com/BobKnothe/autoNumeric) plugin. The OnChangeAjaxBehavior is > not reconigzing changes in an TextField while typing when an autonumeric.js > plugin is attached to it. It sees changes when i leave the TextField. > I will try to attach a quickstart. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-5956) OnChangeAjaxBeavior conflicting with autoNumeric.js plugin
[ https://issues.apache.org/jira/browse/WICKET-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Niestroj updated WICKET-5956: Attachment: mavenproject2.zip > OnChangeAjaxBeavior conflicting with autoNumeric.js plugin > -- > > Key: WICKET-5956 > URL: https://issues.apache.org/jira/browse/WICKET-5956 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 6.20.0 > Environment: Windows 7, Firefox 40, Wicket 6.20, autonumeric 1.39.9 >Reporter: Robert Niestroj > Attachments: mavenproject2.zip > > > I have a problem with the OnChangeAjaxBehavior in conjunction with the > autoNumeric.js (http://www.decorplanit.com/plugin/, > https://github.com/BobKnothe/autoNumeric) plugin. The OnChangeAjaxBehavior is > not reconigzing changes in an TextField while typing when an autonumeric.js > plugin is attached to it. It sees changes when i leave the TextField. > I will try to attach a quickstart. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-5956) OnChangeAjaxBeavior conflicting with autoNumeric.js plugin
[ https://issues.apache.org/jira/browse/WICKET-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Niestroj updated WICKET-5956: Description: I have a problem with the OnChangeAjaxBehavior in conjunction with the autoNumeric.js (http://www.decorplanit.com/plugin/, https://github.com/BobKnothe/autoNumeric) plugin. The OnChangeAjaxBehavior is not reconigzing changes in an TextField while typing when an autonumeric.js plugin is attached to it. It sees changes when i leave the TextField. I will try to attach a quickstart. was: I have a problem with the OnChangeAjaxBehavior in conjunction with the autoNumeric.js plugin. The OnChangeAjaxBehavior is not reconigzing changes in an TextField while typing when an autonumeric.js plugin is attached to it. It sees changes when i leave the TextField. I will try to attach a quickstart. > OnChangeAjaxBeavior conflicting with autoNumeric.js plugin > -- > > Key: WICKET-5956 > URL: https://issues.apache.org/jira/browse/WICKET-5956 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 6.20.0 > Environment: Windows 7, Firefox 40, Wicket 6.20, autonumeric 1.39.9 >Reporter: Robert Niestroj > > I have a problem with the OnChangeAjaxBehavior in conjunction with the > autoNumeric.js (http://www.decorplanit.com/plugin/, > https://github.com/BobKnothe/autoNumeric) plugin. The OnChangeAjaxBehavior is > not reconigzing changes in an TextField while typing when an autonumeric.js > plugin is attached to it. It sees changes when i leave the TextField. > I will try to attach a quickstart. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (WICKET-5956) OnChangeAjaxBeavior conflicting with autoNumeric.js plugin
Robert Niestroj created WICKET-5956: --- Summary: OnChangeAjaxBeavior conflicting with autoNumeric.js plugin Key: WICKET-5956 URL: https://issues.apache.org/jira/browse/WICKET-5956 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.20.0 Environment: Windows 7, Firefox 40, Wicket 6.20, autonumeric 1.39.9 Reporter: Robert Niestroj I have a problem with the OnChangeAjaxBehavior in conjunction with the autoNumeric.js plugin. The OnChangeAjaxBehavior is not reconigzing changes in an TextField while typing when an autonumeric.js plugin is attached to it. It sees changes when i leave the TextField. I will try to attach a quickstart. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-4163) BufferedResponseMapper doesn't recognize the the stored response because the session id is not available
[ https://issues.apache.org/jira/browse/WICKET-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13578425#comment-13578425 ] Robert Niestroj commented on WICKET-4163: - What are the possible causes of this warning? The Buffered response should be handled by BufferedResponseRequestHandler ? I have this when i enter a certain panel and try through an ajaxlink to go to another panel. The ajax can be on this panel or on another panel. I have to click three times until the debugger stops in the onClick method of the link. > BufferedResponseMapper doesn't recognize the the stored response because the > session id is not available > > > Key: WICKET-4163 > URL: https://issues.apache.org/jira/browse/WICKET-4163 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.5.2 >Reporter: Martin Grigorov >Assignee: Martin Grigorov > Fix For: 1.5.3 > > > WebPageRenderer logs a warning that there is a stored response but it wasn't > picked by BufferedResponseRequestHandler: > WARN - WebPageRenderer- The Buffered response should be handled > by BufferedResponseRequestHandler > The problem is in > org.apache.wicket.request.mapper.BufferedResponseMapper.getSessionId() which > was wrongly optimized to not create a new Session with > http://svn.apache.org/viewvc?view=revision&revision=1186125 > Workaround until 1.5.3 is released: > MyApplication#init() { > mount(new BufferedResponseMapper() { > protected String getSessionId() > { > return Session.get().getId(); > } > }); > } -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4163) BufferedResponseMapper doesn't recognize the the stored response because the session id is not available
[ https://issues.apache.org/jira/browse/WICKET-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13572307#comment-13572307 ] Robert Niestroj commented on WICKET-4163: - Got the same error on Wicket 6.5.0. Dont know where it come from. Maybe i will have to revert on SVN revision by revision to find out what wrong. Clearing browser cache doesnt change anything. Closing browser changes. When i click an ajax link or sth like that the first time the request goes to the server but nothing happens. Second time it then works ok. > BufferedResponseMapper doesn't recognize the the stored response because the > session id is not available > > > Key: WICKET-4163 > URL: https://issues.apache.org/jira/browse/WICKET-4163 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.5.2 >Reporter: Martin Grigorov >Assignee: Martin Grigorov > Fix For: 1.5.3 > > > WebPageRenderer logs a warning that there is a stored response but it wasn't > picked by BufferedResponseRequestHandler: > WARN - WebPageRenderer- The Buffered response should be handled > by BufferedResponseRequestHandler > The problem is in > org.apache.wicket.request.mapper.BufferedResponseMapper.getSessionId() which > was wrongly optimized to not create a new Session with > http://svn.apache.org/viewvc?view=revision&revision=1186125 > Workaround until 1.5.3 is released: > MyApplication#init() { > mount(new BufferedResponseMapper() { > protected String getSessionId() > { > return Session.get().getId(); > } > }); > } -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3433) Wicket parses HTML inside IE conditional comments
[ https://issues.apache.org/jira/browse/WICKET-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13564321#comment-13564321 ] Robert Niestroj commented on WICKET-3433: - Made a workaround today. This is attached to the body tag: WebMarkupContainer body = new WebMarkupContainer("bodyContainer"){ @Override protected void onConfigure() { super.onConfigure(); if (WebSession.get().getClientInfo().getProperties().isBrowserInternetExplorer()){ add(AttributeModifier.replace("class", "ie ie" + WebSession.get().getClientInfo().getProperties().getBrowserVersionMajor() )); } } }; > Wicket parses HTML inside IE conditional comments > - > > Key: WICKET-3433 > URL: https://issues.apache.org/jira/browse/WICKET-3433 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.5-M3 >Reporter: Alan Shaw >Assignee: Juergen Donnerstag > Labels: HTML5, boilerplate, doctype, html, parser > Attachments: html5boilerplate.ui.wicket.parsefail-working.zip, > html5boilerplate.ui.wicket.parsefail.zip, programmatic-way.tgz, > quickstart.zip, SimplePageExpectedResult_12a.html, WICKET-3433.patch, > wicket-conditional-comments.patch > > > I cannot use the HTML5 Boilerplate HTML with wicket. Wicket appears to parse > HTML inside IE conditional comments when they appear between the doctype > declaration and the tag. > The first lines of the boilerplate html look like this: > > > > > > > > > ...which causes a problem for wicket, as it thinks there are five opening > tags on the page. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4363) Duplicate html ID for generated divs in modal.js
[ https://issues.apache.org/jira/browse/WICKET-4363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559577#comment-13559577 ] Robert Niestroj commented on WICKET-4363: - How do i create a quickstart? > Duplicate html ID for generated divs in modal.js > > > Key: WICKET-4363 > URL: https://issues.apache.org/jira/browse/WICKET-4363 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 1.5.4 >Reporter: Rodolfo Hansen >Assignee: Igor Vaynberg > Fix For: 1.5.5, 6.0.0-beta1 > > Attachments: 0001-Fix-duplicate-IDs-in-modal-window.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > using wicket's ModalWindow creates invalid markup since it creates two divs > with id="_wicket_window_11" -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (WICKET-4999) CLONE - Duplicate html ID for generated divs in modal.js
Robert Niestroj created WICKET-4999: --- Summary: CLONE - Duplicate html ID for generated divs in modal.js Key: WICKET-4999 URL: https://issues.apache.org/jira/browse/WICKET-4999 Project: Wicket Issue Type: Bug Components: wicket-extensions Affects Versions: 1.5.4 Reporter: Robert Niestroj Assignee: Igor Vaynberg Fix For: 1.5.5, 6.0.0-beta1 using wicket's ModalWindow creates invalid markup since it creates two divs with id="_wicket_window_11" -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4999) CLONE - Duplicate html ID for generated divs in modal.js
[ https://issues.apache.org/jira/browse/WICKET-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Niestroj updated WICKET-4999: Affects Version/s: (was: 1.5.4) 6.4.0 > CLONE - Duplicate html ID for generated divs in modal.js > > > Key: WICKET-4999 > URL: https://issues.apache.org/jira/browse/WICKET-4999 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 6.4.0 >Reporter: Robert Niestroj >Assignee: Igor Vaynberg > Fix For: 1.5.5, 6.0.0-beta1 > > Original Estimate: 0h > Remaining Estimate: 0h > > using wicket's ModalWindow creates invalid markup since it creates two divs > with id="_wicket_window_11" -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4999) CLONE - Duplicate html ID for generated divs in modal.js
[ https://issues.apache.org/jira/browse/WICKET-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559558#comment-13559558 ] Robert Niestroj commented on WICKET-4999: - I think the bug is still there in Wicket 6.4.0 This is the Panel i have in my modalWindow: When i add the wicket:id="formContainer" to the target it gets duplicated with the same generated id. I have a link in the wicket:id="dataTable" for editing items from the datatable. This link uses replaceWith to replace the wicket:id="formContainer" with a new instance and then i add wicket:id="formContainer" to the AjaxRequestTarget. Then it doubles the formContainer div. > CLONE - Duplicate html ID for generated divs in modal.js > > > Key: WICKET-4999 > URL: https://issues.apache.org/jira/browse/WICKET-4999 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 1.5.4 >Reporter: Robert Niestroj >Assignee: Igor Vaynberg > Fix For: 1.5.5, 6.0.0-beta1 > > Original Estimate: 0h > Remaining Estimate: 0h > > using wicket's ModalWindow creates invalid markup since it creates two divs > with id="_wicket_window_11" -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4363) Duplicate html ID for generated divs in modal.js
[ https://issues.apache.org/jira/browse/WICKET-4363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559555#comment-13559555 ] Robert Niestroj commented on WICKET-4363: - I think the bug is still there in Wicket 6.4.0 This is the Panel i have in my modalWindow: When i add the wicket:id="formContainer" to the target it gets duplicated with the same generated id. I have a link in the wicket:id="dataTable" for editing items from the datatable. This link uses replaceWith to replace the wicket:id="formContainer" with a new instance and then i add wicket:id="formContainer" to the AjaxRequestTarget. Then it doubles the formContainer div. Can you reopen this isse? > Duplicate html ID for generated divs in modal.js > > > Key: WICKET-4363 > URL: https://issues.apache.org/jira/browse/WICKET-4363 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 1.5.4 >Reporter: Rodolfo Hansen >Assignee: Igor Vaynberg > Fix For: 1.5.5, 6.0.0-beta1 > > Attachments: 0001-Fix-duplicate-IDs-in-modal-window.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > using wicket's ModalWindow creates invalid markup since it creates two divs > with id="_wicket_window_11" -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (WICKET-4981) Label with wicket:for visibility bound to "for" component
Robert Niestroj created WICKET-4981: --- Summary: Label with wicket:for visibility bound to "for" component Key: WICKET-4981 URL: https://issues.apache.org/jira/browse/WICKET-4981 Project: Wicket Issue Type: Improvement Reporter: Robert Niestroj I use wicket:for for label "binding" to inputs. When i now i the input change the visibility to hidden the label remains visible. It would be nice if i could set an option to bind the label visibility with the formcomponent visibility. Landfill Now i have to create a seperat Label and set its visibility accordingly do the component. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (WICKET-4977) Wicket jQueryUI integration
Robert Niestroj created WICKET-4977: --- Summary: Wicket jQueryUI integration Key: WICKET-4977 URL: https://issues.apache.org/jira/browse/WICKET-4977 Project: Wicket Issue Type: Wish Reporter: Robert Niestroj DateField uses yui, ModalWindow - something else. It would be nice to integrate jQuery UI into wicket to use in wicket components jQuery UI and not mixing in other libraries since jQuery is already integrated. This could be done through some interfaces, to which wicket would provide implementations using Jquery UI, yui (already existing) with the possibility to make these components later with other libraries. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira