[jira] [Commented] (WICKET-5417) this.replaceWith is broken when called from onInitialize
[
https://issues.apache.org/jira/browse/WICKET-5417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13825485#comment-13825485
]
Ryan Dearing commented on WICKET-5417:
--
Calling super.onInitialize() after the replaceWith() call does prevent the
error. This usecase only arose because I'm extending a panel that has
overridden onInitialize() which in turn calls an abstract method implemented by
subclasses. In that method there is some business logic that determines the
current panel is not appropriate and calls replaceWith().
I was able to fix this by moving the logic into the constructor and calling
replaceWith() there. It wasn't immediately clear what was causing the issue or
that calling replaceWith() is not permitted within onInitialize(), so it would
be nice to update the exception or the javadoc so it is more clear.
this.replaceWith is broken when called from onInitialize
Key: WICKET-5417
URL: https://issues.apache.org/jira/browse/WICKET-5417
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.12.0
Reporter: Ryan Dearing
Assignee: Martin Grigorov
Attachments: WICKET-5417.patch, replacewithbug.tgz
When calling this.replaceWith within the onInitialize method, wicket throws
an exception:
Last cause: org.apache.wicket.Component has not been properly initialized.
Something in the hierarchy of com.mycompany.PanelA has not called
super.onInitialize() in the override of onInitialize() method
This happens because detach is called on the panel being replaced which
clears Component.request flags (sets to 0) which causes the exception on line
864 of Component.java:
if (!getRequestFlag(RFLAG_INITIALIZE_SUPER_CALL_VERIFIED)) {
// throws here
}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Created] (WICKET-5417) this.replaceWith is broken when called from onInitialize
Ryan Dearing created WICKET-5417:
Summary: this.replaceWith is broken when called from onInitialize
Key: WICKET-5417
URL: https://issues.apache.org/jira/browse/WICKET-5417
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.12.0
Reporter: Ryan Dearing
When calling this.replaceWith within the onInitialize method, wicket throws an
exception:
Last cause: org.apache.wicket.Component has not been properly initialized.
Something in the hierarchy of com.mycompany.PanelA has not called
super.onInitialize() in the override of onInitialize() method
This happens because detach is called on the panel which clears
Component.request flags (sets to 0) which causes the exception on line 864 of
Component.java:
if (!getRequestFlag(RFLAG_INITIALIZE_SUPER_CALL_VERIFIED)) {
// throws here
}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (WICKET-5417) this.replaceWith is broken when called from onInitialize
[
https://issues.apache.org/jira/browse/WICKET-5417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Dearing updated WICKET-5417:
-
Attachment: replacewithbug.tgz
Quickstart to repro bug
this.replaceWith is broken when called from onInitialize
Key: WICKET-5417
URL: https://issues.apache.org/jira/browse/WICKET-5417
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.12.0
Reporter: Ryan Dearing
Attachments: replacewithbug.tgz
When calling this.replaceWith within the onInitialize method, wicket throws
an exception:
Last cause: org.apache.wicket.Component has not been properly initialized.
Something in the hierarchy of com.mycompany.PanelA has not called
super.onInitialize() in the override of onInitialize() method
This happens because detach is called on the panel which clears
Component.request flags (sets to 0) which causes the exception on line 864 of
Component.java:
if (!getRequestFlag(RFLAG_INITIALIZE_SUPER_CALL_VERIFIED)) {
// throws here
}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (WICKET-5417) this.replaceWith is broken when called from onInitialize
[
https://issues.apache.org/jira/browse/WICKET-5417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Dearing updated WICKET-5417:
-
Description:
When calling this.replaceWith within the onInitialize method, wicket throws an
exception:
Last cause: org.apache.wicket.Component has not been properly initialized.
Something in the hierarchy of com.mycompany.PanelA has not called
super.onInitialize() in the override of onInitialize() method
This happens because detach is called on the panel being replaced which clears
Component.request flags (sets to 0) which causes the exception on line 864 of
Component.java:
if (!getRequestFlag(RFLAG_INITIALIZE_SUPER_CALL_VERIFIED)) {
// throws here
}
was:
When calling this.replaceWith within the onInitialize method, wicket throws an
exception:
Last cause: org.apache.wicket.Component has not been properly initialized.
Something in the hierarchy of com.mycompany.PanelA has not called
super.onInitialize() in the override of onInitialize() method
This happens because detach is called on the panel which clears
Component.request flags (sets to 0) which causes the exception on line 864 of
Component.java:
if (!getRequestFlag(RFLAG_INITIALIZE_SUPER_CALL_VERIFIED)) {
// throws here
}
this.replaceWith is broken when called from onInitialize
Key: WICKET-5417
URL: https://issues.apache.org/jira/browse/WICKET-5417
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.12.0
Reporter: Ryan Dearing
Attachments: replacewithbug.tgz
When calling this.replaceWith within the onInitialize method, wicket throws
an exception:
Last cause: org.apache.wicket.Component has not been properly initialized.
Something in the hierarchy of com.mycompany.PanelA has not called
super.onInitialize() in the override of onInitialize() method
This happens because detach is called on the panel being replaced which
clears Component.request flags (sets to 0) which causes the exception on line
864 of Component.java:
if (!getRequestFlag(RFLAG_INITIALIZE_SUPER_CALL_VERIFIED)) {
// throws here
}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (WICKET-5417) this.replaceWith is broken when called from onInitialize
[
https://issues.apache.org/jira/browse/WICKET-5417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Dearing updated WICKET-5417:
-
Description:
When calling this.replaceWith within the onInitialize method, wicket throws an
exception:
Last cause: org.apache.wicket.Component has not been properly initialized.
Something in the hierarchy of com.mycompany.PanelA has not called
super.onInitialize() in the override of onInitialize() method
This happens because detach is called on the panel being replaced which clears
Component.request flags (sets to 0) which causes the exception on line 864 of
Component.java:
if (!getRequestFlag(RFLAG_INITIALIZE_SUPER_CALL_VERIFIED)) {
// throws here
}
was:
When calling this.replaceWith within the onInitialize method, wicket throws an
exception:
Last cause: org.apache.wicket.Component has not been properly initialized.
Something in the hierarchy of com.mycompany.PanelA has not called
super.onInitialize() in the override of onInitialize() method
This happens because detach is called on the panel being replaced which clears
Component.request flags (sets to 0) which causes the exception on line 864 of
Component.java:
if (!getRequestFlag(RFLAG_INITIALIZE_SUPER_CALL_VERIFIED)) {
// throws here
}
this.replaceWith is broken when called from onInitialize
Key: WICKET-5417
URL: https://issues.apache.org/jira/browse/WICKET-5417
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.12.0
Reporter: Ryan Dearing
Attachments: replacewithbug.tgz
When calling this.replaceWith within the onInitialize method, wicket throws
an exception:
Last cause: org.apache.wicket.Component has not been properly initialized.
Something in the hierarchy of com.mycompany.PanelA has not called
super.onInitialize() in the override of onInitialize() method
This happens because detach is called on the panel being replaced which
clears Component.request flags (sets to 0) which causes the exception on line
864 of Component.java:
if (!getRequestFlag(RFLAG_INITIALIZE_SUPER_CALL_VERIFIED)) {
// throws here
}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] Created: (WICKET-2743) BookmarkablePageLink creates an invalid url when components are updated via ajax (using AjaxPagingNavigator)
BookmarkablePageLink creates an invalid url when components are updated via ajax (using AjaxPagingNavigator) Key: WICKET-2743 URL: https://issues.apache.org/jira/browse/WICKET-2743 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.6 Reporter: Ryan Dearing Priority: Critical I have a 2 mounted pages, one mounted at home and one mounted at page2. When clicking a BookmarkablePageLink for home the browser is sent to the correct page. The home page then uses a DataView to create many panels with BookmarkablePageLinks to page2. If you paginate using AjaxPagingNavigator the links incorrectly point to /home/page2. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2743) BookmarkablePageLink creates an invalid url when components are updated via ajax (using AjaxPagingNavigator)
[ https://issues.apache.org/jira/browse/WICKET-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dearing updated WICKET-2743: - Attachment: ajaxissue.tgz Attached quickstart demonstrating issue. Reproduction steps with this quickstart: Browse to homepage, this click the link at the top. Now click one of the paging links. Now click a link labeled Funky Link BookmarkablePageLink creates an invalid url when components are updated via ajax (using AjaxPagingNavigator) Key: WICKET-2743 URL: https://issues.apache.org/jira/browse/WICKET-2743 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.6 Reporter: Ryan Dearing Priority: Critical Attachments: ajaxissue.tgz I have a 2 mounted pages, one mounted at home and one mounted at page2. When clicking a BookmarkablePageLink for home the browser is sent to the correct page. The home page then uses a DataView to create many panels with BookmarkablePageLinks to page2. If you paginate using AjaxPagingNavigator the links incorrectly point to /home/page2. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2743) BookmarkablePageLink creates an invalid url when components are updated via ajax (using AjaxPagingNavigator)
[ https://issues.apache.org/jira/browse/WICKET-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dearing updated WICKET-2743: - Description: I have a 2 mounted pages, one mounted at home and one mounted at page2. When clicking a BookmarkablePageLink for home the browser is sent to the correct page. The home page then uses a DataView to create many panels with BookmarkablePageLinks to page2. If you paginate using AjaxPagingNavigator the links incorrectly point to /home/test/foo/page2. Where test/foo was a pageparameter sent to the page. was: I have a 2 mounted pages, one mounted at home and one mounted at page2. When clicking a BookmarkablePageLink for home the browser is sent to the correct page. The home page then uses a DataView to create many panels with BookmarkablePageLinks to page2. If you paginate using AjaxPagingNavigator the links incorrectly point to /home/page2. BookmarkablePageLink creates an invalid url when components are updated via ajax (using AjaxPagingNavigator) Key: WICKET-2743 URL: https://issues.apache.org/jira/browse/WICKET-2743 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.6 Reporter: Ryan Dearing Priority: Critical Attachments: ajaxissue.tgz I have a 2 mounted pages, one mounted at home and one mounted at page2. When clicking a BookmarkablePageLink for home the browser is sent to the correct page. The home page then uses a DataView to create many panels with BookmarkablePageLinks to page2. If you paginate using AjaxPagingNavigator the links incorrectly point to /home/test/foo/page2. Where test/foo was a pageparameter sent to the page. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2743) BookmarkablePageLink creates an invalid url when components are updated via ajax (using AjaxPagingNavigator)
[ https://issues.apache.org/jira/browse/WICKET-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dearing updated WICKET-2743: - Description: I have a 2 mounted pages, one mounted at home and one mounted at page2. When clicking a BookmarkablePageLink for home the browser is sent to the correct page. The home page then uses a DataView to create many panels with BookmarkablePageLinks to page2. If you paginate using AjaxPagingNavigator the links in the panels incorrectly point to /home/test/foo/page2. Where test/foo was a pageparameter sent to the page. was: I have a 2 mounted pages, one mounted at home and one mounted at page2. When clicking a BookmarkablePageLink for home the browser is sent to the correct page. The home page then uses a DataView to create many panels with BookmarkablePageLinks to page2. If you paginate using AjaxPagingNavigator the links incorrectly point to /home/test/foo/page2. Where test/foo was a pageparameter sent to the page. BookmarkablePageLink creates an invalid url when components are updated via ajax (using AjaxPagingNavigator) Key: WICKET-2743 URL: https://issues.apache.org/jira/browse/WICKET-2743 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.6 Reporter: Ryan Dearing Priority: Critical Attachments: ajaxissue.tgz I have a 2 mounted pages, one mounted at home and one mounted at page2. When clicking a BookmarkablePageLink for home the browser is sent to the correct page. The home page then uses a DataView to create many panels with BookmarkablePageLinks to page2. If you paginate using AjaxPagingNavigator the links in the panels incorrectly point to /home/test/foo/page2. Where test/foo was a pageparameter sent to the page. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2743) BookmarkablePageLink creates an invalid url when components are updated via ajax (using AjaxPagingNavigator)
[ https://issues.apache.org/jira/browse/WICKET-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dearing updated WICKET-2743: - Description: I have a 2 mounted pages, one mounted at home and one mounted at page2. When clicking a BookmarkablePageLink for home the browser is sent to the correct page. The home page then uses a DataView to create many panels with BookmarkablePageLinks to page2. If you paginate using AjaxPagingNavigator the links in the panels incorrectly point to /home/test/foo/page2. Where test/foo was a pageparameter sent to the page. This works correctly in 1.4.5. was: I have a 2 mounted pages, one mounted at home and one mounted at page2. When clicking a BookmarkablePageLink for home the browser is sent to the correct page. The home page then uses a DataView to create many panels with BookmarkablePageLinks to page2. If you paginate using AjaxPagingNavigator the links in the panels incorrectly point to /home/test/foo/page2. Where test/foo was a pageparameter sent to the page. BookmarkablePageLink creates an invalid url when components are updated via ajax (using AjaxPagingNavigator) Key: WICKET-2743 URL: https://issues.apache.org/jira/browse/WICKET-2743 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.6 Reporter: Ryan Dearing Priority: Critical Attachments: ajaxissue.tgz I have a 2 mounted pages, one mounted at home and one mounted at page2. When clicking a BookmarkablePageLink for home the browser is sent to the correct page. The home page then uses a DataView to create many panels with BookmarkablePageLinks to page2. If you paginate using AjaxPagingNavigator the links in the panels incorrectly point to /home/test/foo/page2. Where test/foo was a pageparameter sent to the page. This works correctly in 1.4.5. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-2516) Javadoc for Component.getMarkupId is incorrect
Javadoc for Component.getMarkupId is incorrect -- Key: WICKET-2516 URL: https://issues.apache.org/jira/browse/WICKET-2516 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.2 Reporter: Ryan Dearing Priority: Trivial The javadoc for Component.getMarkupId states: Retrieves id by which this component is represented within the markup. This is either the id attribute set explicitly via a call to setMarkupId(String), id attribute defined in the markup, or an automatically generated id - in that order. However, a colleague has pointed out that retrieving the markup id from the html markup is not working. The below post confirms that it is not possible to retrieve the markup id from the markup: http://www.nabble.com/Re%3A-id-attribute-of-Component-Tag-in-renderHead--p22953222.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1929) PagingNavigator.newPagingNavigationIncrementLink and PagingNavigator.newPagingNavigationLink should return AbstractLink
[ https://issues.apache.org/jira/browse/WICKET-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dearing updated WICKET-1929: - Description: Currently newPagingNavigationLink and newPagingNavigationIncrementLink in PagingNavigator return Link objects. It would be nice if they returned AbstractLink objects to allow more flexibility. This would make using SubmitLink and custom Link components with PagingNavigator much easier. This was discussed back in Jan 08 ( http://markmail.org/message/dfgnis2rc7ysjlhj ), but I could not find a JIRA issue for it. For now using Behaviors may work and avoids duplicating a lot of the code. was: Currently newPagingNavigationLink and newPagingNavigationIncrementLink in PagingNavigator return Link objects. It would be nice if they returned AbstractLink objects to allow more flexibility. This would make using SubmitLink and custom Link components with PagingNavigator much easier. This was discussed back in Jan 08 (http://markmail.org/message/dfgnis2rc7ysjlhj), but I could not find a JIRA issue for it. For now using Behaviors may work and avoids duplicating a lot of the code. PagingNavigator.newPagingNavigationIncrementLink and PagingNavigator.newPagingNavigationLink should return AbstractLink - Key: WICKET-1929 URL: https://issues.apache.org/jira/browse/WICKET-1929 Project: Wicket Issue Type: Improvement Affects Versions: 1.3.0-final, 1.3.1, 1.3.2, 1.3.3, 1.3.4, 1.3.5, 1.4-M1, 1.4-M2, 1.4-M3 Reporter: Ryan Dearing Currently newPagingNavigationLink and newPagingNavigationIncrementLink in PagingNavigator return Link objects. It would be nice if they returned AbstractLink objects to allow more flexibility. This would make using SubmitLink and custom Link components with PagingNavigator much easier. This was discussed back in Jan 08 ( http://markmail.org/message/dfgnis2rc7ysjlhj ), but I could not find a JIRA issue for it. For now using Behaviors may work and avoids duplicating a lot of the code. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-1929) PagingNavigator.newPagingNavigationIncrementLink and PagingNavigator.newPagingNavigationLink should return AbstractLink
PagingNavigator.newPagingNavigationIncrementLink and PagingNavigator.newPagingNavigationLink should return AbstractLink - Key: WICKET-1929 URL: https://issues.apache.org/jira/browse/WICKET-1929 Project: Wicket Issue Type: Improvement Affects Versions: 1.3.5 Reporter: Ryan Dearing Currently newPagingNavigationLink and newPagingNavigationIncrementLink in PagingNavigator return Link objects. It would be nice if they returned AbstractLink objects to allow more flexibility. This would make using SubmitLink and custom Link components with PagingNavigator much easier. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1929) PagingNavigator.newPagingNavigationIncrementLink and PagingNavigator.newPagingNavigationLink should return AbstractLink
[ https://issues.apache.org/jira/browse/WICKET-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dearing updated WICKET-1929: - Description: Currently newPagingNavigationLink and newPagingNavigationIncrementLink in PagingNavigator return Link objects. It would be nice if they returned AbstractLink objects to allow more flexibility. This would make using SubmitLink and custom Link components with PagingNavigator much easier. This was discussed back in Jan 08 (http://markmail.org/message/dfgnis2rc7ysjlhj), but I could not find a JIRA issue for it. For now using Behaviors may work and avoids duplicating a lot of the code. was:Currently newPagingNavigationLink and newPagingNavigationIncrementLink in PagingNavigator return Link objects. It would be nice if they returned AbstractLink objects to allow more flexibility. This would make using SubmitLink and custom Link components with PagingNavigator much easier. Affects Version/s: 1.3.0-final 1.3.1 1.3.2 1.3.3 1.3.4 1.4-M1 1.4-M2 1.4-M3 PagingNavigator.newPagingNavigationIncrementLink and PagingNavigator.newPagingNavigationLink should return AbstractLink - Key: WICKET-1929 URL: https://issues.apache.org/jira/browse/WICKET-1929 Project: Wicket Issue Type: Improvement Affects Versions: 1.3.0-final, 1.3.1, 1.3.2, 1.3.3, 1.3.4, 1.3.5, 1.4-M1, 1.4-M2, 1.4-M3 Reporter: Ryan Dearing Currently newPagingNavigationLink and newPagingNavigationIncrementLink in PagingNavigator return Link objects. It would be nice if they returned AbstractLink objects to allow more flexibility. This would make using SubmitLink and custom Link components with PagingNavigator much easier. This was discussed back in Jan 08 (http://markmail.org/message/dfgnis2rc7ysjlhj), but I could not find a JIRA issue for it. For now using Behaviors may work and avoids duplicating a lot of the code. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-1925) SubmitLink javadoc is wrong. It states the javascript will be used in the href attribute of the tab, but it is actually in the onclick attribute.
SubmitLink javadoc is wrong. It states the javascript will be used in the href attribute of the tab, but it is actually in the onclick attribute. - Key: WICKET-1925 URL: https://issues.apache.org/jira/browse/WICKET-1925 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.3.5 Reporter: Ryan Dearing Priority: Trivial I was reading the SubmitLink javadoc which states the javascript it generates will be put into the href attribute of the link. Instead the javascript is put in the onclick attribute. The javadoc should be fixed to state that the javascript is put into the onclick attribute. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (WICKET-1419) GridView has a bug in findNext that prevents ReuseIfModelsEqualStrategy from working correctly
GridView has a bug in findNext that prevents ReuseIfModelsEqualStrategy from
working correctly
--
Key: WICKET-1419
URL: https://issues.apache.org/jira/browse/WICKET-1419
Project: Wicket
Issue Type: Bug
Affects Versions: 1.3.1
Reporter: Ryan Dearing
Priority: Critical
Attachments: gridview-bug.tgz
the method findNext() in GridView.java has this code:
if (cells != null cells.hasNext())
{
next = (Item)cells.next();
}
but it should be:
if (cells != null cells.hasNext())
{
next = (Item)cells.next();
return;
}
I have attached a quickstart project that will recreate the bug. When you hit
the toggle buggy link, the panel should maintain its state and you should see
the text toggle from false to true. As you can see, it works correctly in
the 1st column of panels, but the second column does not work.
There is also a class called MyGridView in the attachment that fixes the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1419) GridView has a bug in findNext that prevents ReuseIfModelsEqualStrategy from working correctly
[
https://issues.apache.org/jira/browse/WICKET-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Dearing updated WICKET-1419:
-
Attachment: gridview-bug.tgz
quickstart project attached
GridView has a bug in findNext that prevents ReuseIfModelsEqualStrategy from
working correctly
--
Key: WICKET-1419
URL: https://issues.apache.org/jira/browse/WICKET-1419
Project: Wicket
Issue Type: Bug
Affects Versions: 1.3.1
Reporter: Ryan Dearing
Priority: Critical
Attachments: gridview-bug.tgz
the method findNext() in GridView.java has this code:
if (cells != null cells.hasNext())
{
next = (Item)cells.next();
}
but it should be:
if (cells != null cells.hasNext())
{
next = (Item)cells.next();
return;
}
I have attached a quickstart project that will recreate the bug. When you hit
the toggle buggy link, the panel should maintain its state and you should
see the text toggle from false to true. As you can see, it works
correctly in the 1st column of panels, but the second column does not work.
There is also a class called MyGridView in the attachment that fixes the
issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1419) GridView has a bug in findNext that prevents ReuseIfModelsEqualStrategy from working correctly
[
https://issues.apache.org/jira/browse/WICKET-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Dearing updated WICKET-1419:
-
Attachment: MyGridView.java
fixed version of GridView... a one liner, the best kind.
GridView has a bug in findNext that prevents ReuseIfModelsEqualStrategy from
working correctly
--
Key: WICKET-1419
URL: https://issues.apache.org/jira/browse/WICKET-1419
Project: Wicket
Issue Type: Bug
Affects Versions: 1.3.1
Reporter: Ryan Dearing
Priority: Critical
Attachments: gridview-bug.tgz, MyGridView.java
the method findNext() in GridView.java has this code:
if (cells != null cells.hasNext())
{
next = (Item)cells.next();
}
but it should be:
if (cells != null cells.hasNext())
{
next = (Item)cells.next();
return;
}
I have attached a quickstart project that will recreate the bug. When you hit
the toggle buggy link, the panel should maintain its state and you should
see the text toggle from false to true. As you can see, it works
correctly in the 1st column of panels, but the second column does not work.
There is also a class called MyGridView in the attachment that fixes the
issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
