[jira] [Created] (WICKET-6574) JQueryResourceReference#get() (still) return V1
Sebastien Briquet created WICKET-6574: - Summary: JQueryResourceReference#get() (still) return V1 Key: WICKET-6574 URL: https://issues.apache.org/jira/browse/WICKET-6574 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 8.0.0 Reporter: Sebastien Briquet JQueryResourceReference#get() returns V1 (jquery-1.12.4) and is marked as deprecated It is still called by JQueryPluginResourceReference, in the case the application does not exists. On another side, we have WicketAjaxJQueryResourceReference, which does explicitly returns V2 in the case the application does not exists. IIRC V1 was returned by #get() to keep the compatibility. Maybe it's time to remove #get() and make JQueryPluginResourceReference use V2? WDYT ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6448) IndicatingAjaxButton should prevent double submit
[ https://issues.apache.org/jira/browse/WICKET-6448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127048#comment-16127048 ] Sebastien Briquet commented on WICKET-6448: --- [~bitstorm], if you do not agree to have this behavior out of the box in the IndicatingAjaxButton itself, maybe we can agree that the DisableOnClickBehavior could be part of the API? I think disabling/prevent-to-submit-twice an indicating button is a very valid usecase that should be supported out of the box in the API... Is there something I missed about this implementation that cannot be generic? > IndicatingAjaxButton should prevent double submit > - > > Key: WICKET-6448 > URL: https://issues.apache.org/jira/browse/WICKET-6448 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 8.0.0-M6 >Reporter: Kamil > Attachments: showcase-preventClick.zip > > > 1)Run the app > 2)Click "submit" quickly several times > 3)Watch the console -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (WICKET-6448) IndicatingAjaxButton should prevent double submit
[ https://issues.apache.org/jira/browse/WICKET-6448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125874#comment-16125874 ] Sebastien Briquet edited comment on WICKET-6448 at 8/14/17 4:03 PM: I would say that if the button is not part of the submit (which I guess it will be the case), then I do not agree : the user should be aware of this, and he voluntary accept it by overriding #isDisabledOnClick (or equivalent). Moreover, thinking back on the implementation... I'm figuring out that we need to use both #click and #ajaxStart. #click for displaying the indicator #ajaxStart for disabling the button Otherwise the indicator will be always be shown on every ajax request in the current page... was (Author: sebfz1): I would say that if the button is not part of the submit (which I guess it will be the case), then I do not agree : the user should be aware of this, and he voluntary accept it by overriding #isDisabledOnClick (or equivalent). Moreover, thinking back on the implementation... I'm figuring out that we need to user both #click and #ajaxStart. #click for displaying the indicator #ajaxStart for disabling the button Otherwise the indicator will be always be shown on every ajax request in the current page... > IndicatingAjaxButton should prevent double submit > - > > Key: WICKET-6448 > URL: https://issues.apache.org/jira/browse/WICKET-6448 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 8.0.0-M6 >Reporter: Kamil > Attachments: showcase-preventClick.zip > > > 1)Run the app > 2)Click "submit" quickly several times > 3)Watch the console -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6448) IndicatingAjaxButton should prevent double submit
[ https://issues.apache.org/jira/browse/WICKET-6448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125874#comment-16125874 ] Sebastien Briquet commented on WICKET-6448: --- I would say that if the button is not part of the submit (which I guess it will be the case), then I do not agree : the user should be aware of this, and he voluntary accept it by overriding #isDisabledOnClick (or equivalent). Moreover, thinking back on the implementation... I'm figuring out that we need to user both #click and #ajaxStart. #click for displaying the indicator #ajaxStart for disabling the button Otherwise the indicator will be always be shown on every ajax request in the current page... > IndicatingAjaxButton should prevent double submit > - > > Key: WICKET-6448 > URL: https://issues.apache.org/jira/browse/WICKET-6448 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 8.0.0-M6 >Reporter: Kamil > Attachments: showcase-preventClick.zip > > > 1)Run the app > 2)Click "submit" quickly several times > 3)Watch the console -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6448) IndicatingAjaxButton should prevent double submit
[ https://issues.apache.org/jira/browse/WICKET-6448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125849#comment-16125849 ] Sebastien Briquet commented on WICKET-6448: --- I've rechecked my code, actually I've changed from ajaxStart to button.click to prevent the button being disabled on every ajax call (ajaxStart should always be bound to 'document') But ajaxStart seems actually to be the best compromise for now as I guess it occurs after the submit (I will double check...) > IndicatingAjaxButton should prevent double submit > - > > Key: WICKET-6448 > URL: https://issues.apache.org/jira/browse/WICKET-6448 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 8.0.0-M6 >Reporter: Kamil > Attachments: showcase-preventClick.zip > > > 1)Run the app > 2)Click "submit" quickly several times > 3)Watch the console -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6448) IndicatingAjaxButton should prevent double submit
[ https://issues.apache.org/jira/browse/WICKET-6448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125809#comment-16125809 ] Sebastien Briquet commented on WICKET-6448: --- Agree that it is not a bug, should rather be an enhancement... > IndicatingAjaxButton should prevent double submit > - > > Key: WICKET-6448 > URL: https://issues.apache.org/jira/browse/WICKET-6448 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 8.0.0-M6 >Reporter: Kamil > Attachments: showcase-preventClick.zip > > > 1)Run the app > 2)Click "submit" quickly several times > 3)Watch the console -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6448) IndicatingAjaxButton should prevent double submit
[ https://issues.apache.org/jira/browse/WICKET-6448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125807#comment-16125807 ] Sebastien Briquet commented on WICKET-6448: --- [~mgrigorov]: It can be an option. I should say that it is convenient. I've added isDisabledOnClick property (default false) on wicket-jquery-ui's IndicatingAjaxButton, but I recently realized the issue I described earlier... :( > IndicatingAjaxButton should prevent double submit > - > > Key: WICKET-6448 > URL: https://issues.apache.org/jira/browse/WICKET-6448 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 8.0.0-M6 >Reporter: Kamil > Attachments: showcase-preventClick.zip > > > 1)Run the app > 2)Click "submit" quickly several times > 3)Watch the console -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6448) IndicatingAjaxButton should prevent double submit
[ https://issues.apache.org/jira/browse/WICKET-6448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125803#comment-16125803 ] Sebastien Briquet commented on WICKET-6448: --- To prevent double submit, the button should likely be disabled on ajax-start and re-enabled on ajax-stop. The problems are: 1/ if the button is disabled just before the submit, it will not be part of the form data, therefore button#onSubmit will never be reached (but form#onSubmit will) 2/ on Chrome and IE, disabling the button will just prevent the form to be submitted. It work on FF however So, a smart alternative should be found... > IndicatingAjaxButton should prevent double submit > - > > Key: WICKET-6448 > URL: https://issues.apache.org/jira/browse/WICKET-6448 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 8.0.0-M6 >Reporter: Kamil > Attachments: showcase-preventClick.zip > > > 1)Run the app > 2)Click "submit" quickly several times > 3)Watch the console -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (WICKET-6070) Provide factory methods for WizardButtonBar buttons
[
https://issues.apache.org/jira/browse/WICKET-6070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebastien Briquet updated WICKET-6070:
--
Fix Version/s: 7.3.0
> Provide factory methods for WizardButtonBar buttons
> ---
>
> Key: WICKET-6070
> URL: https://issues.apache.org/jira/browse/WICKET-6070
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
>Reporter: Sebastien Briquet
>Assignee: Sebastien Briquet
> Fix For: 7.3.0
>
>
> This ticket aims to provide factory methods for {{WizardButtonBar}} buttons
> so these can be easier customized/styled
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (WICKET-6070) Provide factory methods for WizardButtonBar buttons
[
https://issues.apache.org/jira/browse/WICKET-6070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebastien Briquet resolved WICKET-6070.
---
Resolution: Fixed
> Provide factory methods for WizardButtonBar buttons
> ---
>
> Key: WICKET-6070
> URL: https://issues.apache.org/jira/browse/WICKET-6070
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
>Reporter: Sebastien Briquet
>Assignee: Sebastien Briquet
> Fix For: 7.3.0
>
>
> This ticket aims to provide factory methods for {{WizardButtonBar}} buttons
> so these can be easier customized/styled
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (WICKET-6070) Provide factory methods for WizardButtonBar buttons
Sebastien Briquet created WICKET-6070:
-
Summary: Provide factory methods for WizardButtonBar buttons
Key: WICKET-6070
URL: https://issues.apache.org/jira/browse/WICKET-6070
Project: Wicket
Issue Type: Improvement
Components: wicket-extensions
Reporter: Sebastien Briquet
Assignee: Sebastien Briquet
This ticket aims to provide factory methods for {{WizardButtonBar}} buttons so
these can be easier customized/styled
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-6052) CSS header contribution overlap
[
https://issues.apache.org/jira/browse/WICKET-6052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15071004#comment-15071004
]
Sebastien Briquet commented on WICKET-6052:
---
Hi Martin,
Sure, I will do it next week!
Merry Christmas to you too! :)
> CSS header contribution overlap
> ---
>
> Key: WICKET-6052
> URL: https://issues.apache.org/jira/browse/WICKET-6052
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 7.1.0
>Reporter: Sebastien Briquet
>Assignee: Sebastien Briquet
> Fix For: 7.2.0, 8.0.0-M1, 6.22.0
>
> Attachments: WICKET-6052.zip
>
>
> There is an overlap of css header contribution in the following case:
> A parent panel have a CSS HC (wicket:header + ), a
> child panel also have a CSS HC.
> If a child panel is completely newly added to the page via an ajax request,
> then the child CSS HC is not taken into account. I guess it is because both
> CSS HC share the same id...
> {code:html}
>