[jira] [Comment Edited] (WICKET-6611) Missing check for IScopeAwareTextResourceProcessor when concatenating resources
[
https://issues.apache.org/jira/browse/WICKET-6611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678123#comment-16678123
]
Tobias Soloschenko edited comment on WICKET-6611 at 11/7/18 12:07 PM:
--
Hi [~mgrigorov],
just saw your answer. :)
{quote}
I think it is an oversight.
Please send a Pull Request. Preferably with tests. Thank you!
{quote}
I am just wondering on how to fix the circumstances I just mentioned or maybe I
am just making it to difficult. ;)
kind regards
Tobias
was (Author: klopfdreh):
Hi [~mgrigorov],
just saw your answer. :)
I am just wondering on how to fix the circumstances I just mentioned or maybe I
am just making it to difficult. ;)
kind regards
Tobias
> Missing check for IScopeAwareTextResourceProcessor when concatenating
> resources
> ---
>
> Key: WICKET-6611
> URL: https://issues.apache.org/jira/browse/WICKET-6611
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
>Affects Versions: 8.1.0
>Reporter: Thomas Heigl
>Priority: Major
>
> Resource concatenation cannot be used with text compressors relying on scope
> information.
> I tried to use {{CssUrlReplacer}} in my application and it failed on startup
> with an {{UnsupportedOperationException}} in the {{compress}} method.
> In {{CssPackageResource}} we have the following code:
> {code:java}
> ICssCompressor compressor = getCompressor();
> if (compressor != null && getCompress())
> {
>try
>{
> String charsetName = "UTF-8";
> String nonCompressed = new String(processedResponse, charsetName);
> String output;
> if (compressor instanceof IScopeAwareTextResourceProcessor)
> {
> IScopeAwareTextResourceProcessor scopeAwareProcessor =
> (IScopeAwareTextResourceProcessor) compressor;
> output = scopeAwareProcessor.process(nonCompressed, getScope(),
> name);
> }
> else
> {
> output = compressor.compress(nonCompressed);
> }
> return output.getBytes(charsetName);
>}
>catch (Exception e)
>{
> log.error("Error while filtering content", e);
> return processedResponse;
>}
> }{code}
> In {{ConcatBundleResource}} this {{instanceof}} is missing and {{compress}}
> is called directly.
> {code:java}
> if (getCompressor() != null)
> {
>String nonCompressed = new String(bytes, "UTF-8");
>bytes = getCompressor().compress(nonCompressed).getBytes("UTF-8");
> }{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WICKET-6611) Missing check for IScopeAwareTextResourceProcessor when concatenating resources
[
https://issues.apache.org/jira/browse/WICKET-6611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678123#comment-16678123
]
Tobias Soloschenko commented on WICKET-6611:
Hi [~mgrigorov],
just saw your answer. :)
I am just wondering on how to fix the circumstances I just mentioned or maybe I
am just making it to difficult. ;)
kind regards
Tobias
> Missing check for IScopeAwareTextResourceProcessor when concatenating
> resources
> ---
>
> Key: WICKET-6611
> URL: https://issues.apache.org/jira/browse/WICKET-6611
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
>Affects Versions: 8.1.0
>Reporter: Thomas Heigl
>Priority: Major
>
> Resource concatenation cannot be used with text compressors relying on scope
> information.
> I tried to use {{CssUrlReplacer}} in my application and it failed on startup
> with an {{UnsupportedOperationException}} in the {{compress}} method.
> In {{CssPackageResource}} we have the following code:
> {code:java}
> ICssCompressor compressor = getCompressor();
> if (compressor != null && getCompress())
> {
>try
>{
> String charsetName = "UTF-8";
> String nonCompressed = new String(processedResponse, charsetName);
> String output;
> if (compressor instanceof IScopeAwareTextResourceProcessor)
> {
> IScopeAwareTextResourceProcessor scopeAwareProcessor =
> (IScopeAwareTextResourceProcessor) compressor;
> output = scopeAwareProcessor.process(nonCompressed, getScope(),
> name);
> }
> else
> {
> output = compressor.compress(nonCompressed);
> }
> return output.getBytes(charsetName);
>}
>catch (Exception e)
>{
> log.error("Error while filtering content", e);
> return processedResponse;
>}
> }{code}
> In {{ConcatBundleResource}} this {{instanceof}} is missing and {{compress}}
> is called directly.
> {code:java}
> if (getCompressor() != null)
> {
>String nonCompressed = new String(bytes, "UTF-8");
>bytes = getCompressor().compress(nonCompressed).getBytes("UTF-8");
> }{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WICKET-6611) Missing check for IScopeAwareTextResourceProcessor when concatenating resources
[
https://issues.apache.org/jira/browse/WICKET-6611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678119#comment-16678119
]
Tobias Soloschenko commented on WICKET-6611:
Hello [~thomas.heigl],
[~mgrigorov] and me did some refactoring to process scoped resources, so that
you have the scope and the name of the original resource available in addition
to the original content. With this variables it is possible to provide a
PackageResourceReference the app can access by url. (With the replaced URLs)
Without knowing of the stack trace you are facing I assume that a resource is
present which invokes the old compress method and your application fails with a
message that ends with: ".process() should be used instead!"
Because ConcatBundleResource is using ITextResourceCompressor which only
provides the compress method the CssUrlReplacer can't create
PackageResourceReference in a meaningful way.
Without digging deep into it my suggestion would be to create your own
ConcatBundleResource which uses the IScopeAwareTextResourceProcessor and
provide a name / scope that fits to map the URLs of the CSS to a concrete
location so that the PackageResourceReferences are resolving the resources
correctly.
The reason why ConcatBundleResource is exclude is that the resources provided
by URLs are mapped based on each Resource.
If there is any good suggestion how to handle the resource mapping for bundled
resources in general, PRs are always welcome.
kind regards
Tobias
> Missing check for IScopeAwareTextResourceProcessor when concatenating
> resources
> ---
>
> Key: WICKET-6611
> URL: https://issues.apache.org/jira/browse/WICKET-6611
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
>Affects Versions: 8.1.0
>Reporter: Thomas Heigl
>Priority: Major
>
> Resource concatenation cannot be used with text compressors relying on scope
> information.
> I tried to use {{CssUrlReplacer}} in my application and it failed on startup
> with an {{UnsupportedOperationException}} in the {{compress}} method.
> In {{CssPackageResource}} we have the following code:
> {code:java}
> ICssCompressor compressor = getCompressor();
> if (compressor != null && getCompress())
> {
>try
>{
> String charsetName = "UTF-8";
> String nonCompressed = new String(processedResponse, charsetName);
> String output;
> if (compressor instanceof IScopeAwareTextResourceProcessor)
> {
> IScopeAwareTextResourceProcessor scopeAwareProcessor =
> (IScopeAwareTextResourceProcessor) compressor;
> output = scopeAwareProcessor.process(nonCompressed, getScope(),
> name);
> }
> else
> {
> output = compressor.compress(nonCompressed);
> }
> return output.getBytes(charsetName);
>}
>catch (Exception e)
>{
> log.error("Error while filtering content", e);
> return processedResponse;
>}
> }{code}
> In {{ConcatBundleResource}} this {{instanceof}} is missing and {{compress}}
> is called directly.
> {code:java}
> if (getCompressor() != null)
> {
>String nonCompressed = new String(bytes, "UTF-8");
>bytes = getCompressor().compress(nonCompressed).getBytes("UTF-8");
> }{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WICKET-6504) Use a serializable model for FileSystemResource's path
[ https://issues.apache.org/jira/browse/WICKET-6504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308471#comment-16308471 ] Tobias Soloschenko commented on WICKET-6504: Thank you [~solomax]! (y) > Use a serializable model for FileSystemResource's path > -- > > Key: WICKET-6504 > URL: https://issues.apache.org/jira/browse/WICKET-6504 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 7.8.0 >Reporter: Claudia Hirt >Assignee: Martin Grigorov >Priority: Minor > Fix For: 8.0.0, 7.10.0 > > > FileSystemResource takes a java.nio.file.Path to load the resource. > This leads to java.io.NotSerializableException: sun.nio.fs.WindowsPath in my > case. I know this is a problem of JavaSerializer and I already found the > solution to use something like Kryo Serializer instead. > But wouldn't it be better to have the possibility to use a Model for the path > anyway? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (WICKET-6504) Use a serializable model for FileSystemResource's path
[ https://issues.apache.org/jira/browse/WICKET-6504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307901#comment-16307901 ] Tobias Soloschenko edited comment on WICKET-6504 at 1/2/18 11:24 AM: - Hi, I just asked to also apply it within Wicket 7 - it was only done within the master branch, yet - WDYT? I asked because it is an API break. https://github.com/apache/wicket/commit/7e25f47fd1259c34824d40d5ec52e0b595ded774#commitcomment-26590409 was (Author: klopfdreh): Hi, I just asked to also apply it within Wicket 7 - it was only done within the master branch, yet - WDYT? I asked because it is an API break. https://github.com/apache/wicket/commit/7e25f47fd1259c34824d40d5ec52e0b595ded774 > Use a serializable model for FileSystemResource's path > -- > > Key: WICKET-6504 > URL: https://issues.apache.org/jira/browse/WICKET-6504 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 7.8.0 >Reporter: Claudia Hirt >Assignee: Martin Grigorov >Priority: Minor > Fix For: 8.0.0 > > > FileSystemResource takes a java.nio.file.Path to load the resource. > This leads to java.io.NotSerializableException: sun.nio.fs.WindowsPath in my > case. I know this is a problem of JavaSerializer and I already found the > solution to use something like Kryo Serializer instead. > But wouldn't it be better to have the possibility to use a Model for the path > anyway? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6504) Use a serializable model for FileSystemResource's path
[ https://issues.apache.org/jira/browse/WICKET-6504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307901#comment-16307901 ] Tobias Soloschenko commented on WICKET-6504: Hi, I just asked to also apply it within Wicket 7 - it was only done within the master branch, yet - WDYT? I asked because it is an API break. https://github.com/apache/wicket/commit/7e25f47fd1259c34824d40d5ec52e0b595ded774 > Use a serializable model for FileSystemResource's path > -- > > Key: WICKET-6504 > URL: https://issues.apache.org/jira/browse/WICKET-6504 > Project: Wicket > Issue Type: Improvement > Components: wicket >Affects Versions: 7.8.0 >Reporter: Claudia Hirt >Assignee: Martin Grigorov >Priority: Minor > Fix For: 8.0.0 > > > FileSystemResource takes a java.nio.file.Path to load the resource. > This leads to java.io.NotSerializableException: sun.nio.fs.WindowsPath in my > case. I know this is a problem of JavaSerializer and I already found the > solution to use something like Kryo Serializer instead. > But wouldn't it be better to have the possibility to use a Model for the path > anyway? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6471) FileSystemResource file descriptor leak
[
https://issues.apache.org/jira/browse/WICKET-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176354#comment-16176354
]
Tobias Soloschenko commented on WICKET-6471:
Until 7.10.0 or 8.0.0 is released you can override the method to fix it.
> FileSystemResource file descriptor leak
> ---
>
> Key: WICKET-6471
> URL: https://issues.apache.org/jira/browse/WICKET-6471
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 7.9.0
>Reporter: Boris Goldowsky
>Assignee: Sven Meier
> Fix For: 8.0.0-M8, 7.10.0
>
> Attachments: frquickstart.zip
>
>
> FileSystemResource does not appear to close the InputStream that it creates.
> I believe it should call setClose(true) on the PartWriterCallback.
> To verify the problem, see the attached quick start. Change the filename in
> HomePage.java to point to some valid image file on your system. After viewing
> the home page in a browser, check for files that the jetty process has open,
> eg:
> {noformat}
> lsof -p PID | grep logo
> {noformat}
> If you load the home page a few more times, using Shift-reload to avoid
> simply loading from cache, you can see many file descriptors pointing to the
> image file are kept open:
> {noformat}
> java87278 borisgoldowsky txt REG1,4 12244
> 103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
> java87278 borisgoldowsky 175r REG1,4 12244
> 103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
> java87278 borisgoldowsky 180r REG1,4 12244
> 103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
> java87278 borisgoldowsky 181r REG1,4 12244
> 103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (WICKET-6471) FileSystemResource file descriptor leak
[
https://issues.apache.org/jira/browse/WICKET-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176226#comment-16176226
]
Tobias Soloschenko edited comment on WICKET-6471 at 9/22/17 10:17 AM:
--
Thanks from me, too.
[~svenmeier] - is the fix version 7.9.0 or 7.10.0?
Edit: I changed it to 7.10.0
was (Author: klopfdreh):
Thanks from me, too.
[~svenmeier] - is the fix version 7.9.0 or 7.10.0?
> FileSystemResource file descriptor leak
> ---
>
> Key: WICKET-6471
> URL: https://issues.apache.org/jira/browse/WICKET-6471
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 7.9.0
>Reporter: Boris Goldowsky
>Assignee: Sven Meier
> Fix For: 8.0.0-M8, 7.10.0
>
> Attachments: frquickstart.zip
>
>
> FileSystemResource does not appear to close the InputStream that it creates.
> I believe it should call setClose(true) on the PartWriterCallback.
> To verify the problem, see the attached quick start. Change the filename in
> HomePage.java to point to some valid image file on your system. After viewing
> the home page in a browser, check for files that the jetty process has open,
> eg:
> {noformat}
> lsof -p PID | grep logo
> {noformat}
> If you load the home page a few more times, using Shift-reload to avoid
> simply loading from cache, you can see many file descriptors pointing to the
> image file are kept open:
> {noformat}
> java87278 borisgoldowsky txt REG1,4 12244
> 103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
> java87278 borisgoldowsky 175r REG1,4 12244
> 103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
> java87278 borisgoldowsky 180r REG1,4 12244
> 103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
> java87278 borisgoldowsky 181r REG1,4 12244
> 103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (WICKET-6471) FileSystemResource file descriptor leak
[
https://issues.apache.org/jira/browse/WICKET-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tobias Soloschenko updated WICKET-6471:
---
Fix Version/s: (was: 7.9.0)
7.10.0
> FileSystemResource file descriptor leak
> ---
>
> Key: WICKET-6471
> URL: https://issues.apache.org/jira/browse/WICKET-6471
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 7.9.0
>Reporter: Boris Goldowsky
>Assignee: Sven Meier
> Fix For: 8.0.0-M8, 7.10.0
>
> Attachments: frquickstart.zip
>
>
> FileSystemResource does not appear to close the InputStream that it creates.
> I believe it should call setClose(true) on the PartWriterCallback.
> To verify the problem, see the attached quick start. Change the filename in
> HomePage.java to point to some valid image file on your system. After viewing
> the home page in a browser, check for files that the jetty process has open,
> eg:
> {noformat}
> lsof -p PID | grep logo
> {noformat}
> If you load the home page a few more times, using Shift-reload to avoid
> simply loading from cache, you can see many file descriptors pointing to the
> image file are kept open:
> {noformat}
> java87278 borisgoldowsky txt REG1,4 12244
> 103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
> java87278 borisgoldowsky 175r REG1,4 12244
> 103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
> java87278 borisgoldowsky 180r REG1,4 12244
> 103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
> java87278 borisgoldowsky 181r REG1,4 12244
> 103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (WICKET-6471) FileSystemResource file descriptor leak
[
https://issues.apache.org/jira/browse/WICKET-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176226#comment-16176226
]
Tobias Soloschenko edited comment on WICKET-6471 at 9/22/17 10:16 AM:
--
Thanks from me, too.
[~svenmeier] - is the fix version 7.9.0 or 7.10.0?
was (Author: klopfdreh):
Thanks from me, too.
> FileSystemResource file descriptor leak
> ---
>
> Key: WICKET-6471
> URL: https://issues.apache.org/jira/browse/WICKET-6471
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 7.9.0
>Reporter: Boris Goldowsky
>Assignee: Sven Meier
> Fix For: 7.9.0, 8.0.0-M8
>
> Attachments: frquickstart.zip
>
>
> FileSystemResource does not appear to close the InputStream that it creates.
> I believe it should call setClose(true) on the PartWriterCallback.
> To verify the problem, see the attached quick start. Change the filename in
> HomePage.java to point to some valid image file on your system. After viewing
> the home page in a browser, check for files that the jetty process has open,
> eg:
> {noformat}
> lsof -p PID | grep logo
> {noformat}
> If you load the home page a few more times, using Shift-reload to avoid
> simply loading from cache, you can see many file descriptors pointing to the
> image file are kept open:
> {noformat}
> java87278 borisgoldowsky txt REG1,4 12244
> 103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
> java87278 borisgoldowsky 175r REG1,4 12244
> 103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
> java87278 borisgoldowsky 180r REG1,4 12244
> 103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
> java87278 borisgoldowsky 181r REG1,4 12244
> 103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (WICKET-6471) FileSystemResource file descriptor leak
[
https://issues.apache.org/jira/browse/WICKET-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176226#comment-16176226
]
Tobias Soloschenko commented on WICKET-6471:
Thanks from me, too.
> FileSystemResource file descriptor leak
> ---
>
> Key: WICKET-6471
> URL: https://issues.apache.org/jira/browse/WICKET-6471
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 7.9.0
>Reporter: Boris Goldowsky
>Assignee: Sven Meier
> Fix For: 7.9.0, 8.0.0-M8
>
> Attachments: frquickstart.zip
>
>
> FileSystemResource does not appear to close the InputStream that it creates.
> I believe it should call setClose(true) on the PartWriterCallback.
> To verify the problem, see the attached quick start. Change the filename in
> HomePage.java to point to some valid image file on your system. After viewing
> the home page in a browser, check for files that the jetty process has open,
> eg:
> {noformat}
> lsof -p PID | grep logo
> {noformat}
> If you load the home page a few more times, using Shift-reload to avoid
> simply loading from cache, you can see many file descriptors pointing to the
> image file are kept open:
> {noformat}
> java87278 borisgoldowsky txt REG1,4 12244
> 103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
> java87278 borisgoldowsky 175r REG1,4 12244
> 103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
> java87278 borisgoldowsky 180r REG1,4 12244
> 103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
> java87278 borisgoldowsky 181r REG1,4 12244
> 103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (WICKET-6434) Fixed WicketTester to detect components in enclosure when doing isComponentOnAjaxResponse.
Tobias Soloschenko created WICKET-6434: -- Summary: Fixed WicketTester to detect components in enclosure when doing isComponentOnAjaxResponse. Key: WICKET-6434 URL: https://issues.apache.org/jira/browse/WICKET-6434 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 8.0.0-M6 Reporter: Tobias Soloschenko Assignee: Martin Grigorov Priority: Minor Fix For: 8.0.0-M7 When a component is in a wicket:enclosure and is then correctly re-rendered using ajax, WicketTester seemed to not be able to detect that the component was in the ajax response in the isComponentOnAjaxResponse method. A functionality has been additionalwhere isComponentOnAjaxResponse tries to find an enclosure whose child is the given component, and if one is found, it recurses into isComponentOnAjaxResponse passing the enclosure as an argument. In order not to duplicate logic detecting when an enclosure's child is a given component, AjaxEnclosureListener's isControllerOfEnclosure has been switched to public and static. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (WICKET-6433) Allow to set the rel attribute with CssHeaderItem
Tobias Soloschenko created WICKET-6433: -- Summary: Allow to set the rel attribute with CssHeaderItem Key: WICKET-6433 URL: https://issues.apache.org/jira/browse/WICKET-6433 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 8.0.0-M6 Reporter: Tobias Soloschenko Assignee: Tobias Soloschenko Priority: Trivial Fix For: 8.0.0-M7 Allow to set the rel attribute with CssHeaderItem: https://github.com/apache/wicket/pull/226 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (WICKET-6406) Each path has to be pushed directly
[ https://issues.apache.org/jira/browse/WICKET-6406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Soloschenko resolved WICKET-6406. Resolution: Fixed > Each path has to be pushed directly > --- > > Key: WICKET-6406 > URL: https://issues.apache.org/jira/browse/WICKET-6406 > Project: Wicket > Issue Type: Bug > Components: wicket-http2 >Affects Versions: 8.0.0-M6 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko > Fix For: 8.0.0-M7 > > > Because the path is set as a class attribute to the push builder it has to be > pushed directly, otherwise only the last path is pushed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (WICKET-6406) Each path has to be pushed directly
Tobias Soloschenko created WICKET-6406: -- Summary: Each path has to be pushed directly Key: WICKET-6406 URL: https://issues.apache.org/jira/browse/WICKET-6406 Project: Wicket Issue Type: Bug Components: wicket-http2 Affects Versions: 8.0.0-M6 Reporter: Tobias Soloschenko Assignee: Tobias Soloschenko Fix For: 8.0.0-M7 Because the path is set as a class attribute to the push builder it has to be pushed directly, otherwise only the last path is pushed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WICKET-6323) Allow ResourceBundles to use the defer attribute
[
https://issues.apache.org/jira/browse/WICKET-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876359#comment-15876359
]
Tobias Soloschenko commented on WICKET-6323:
Can be configured by adding a boolean to the bundle configuration:
{code}
tester.getApplication().getResourceBundles().addJavaScriptBundle(ResouceBundleTest.class,
"ab.js", true,
new JavaScriptResourceReference(ResouceBundleTest.class, "a.js"),
new JavaScriptResourceReference(ResouceBundleTest.class, "b.js"));
{code}
> Allow ResourceBundles to use the defer attribute
>
>
> Key: WICKET-6323
> URL: https://issues.apache.org/jira/browse/WICKET-6323
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
>Affects Versions: 7.6.0, 8.0.0-M3, 6.26.0
>Reporter: Tobias Soloschenko
>Assignee: Tobias Soloschenko
>Priority: Minor
> Fix For: 6.27.0, 7.7.0, 8.0.0-M4
>
>
> ResourceBundles should be also configurable with the attribute defer
> {code}
>
[jira] [Resolved] (WICKET-6323) Allow ResourceBundles to use the defer attribute
[
https://issues.apache.org/jira/browse/WICKET-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tobias Soloschenko resolved WICKET-6323.
Resolution: Fixed
> Allow ResourceBundles to use the defer attribute
>
>
> Key: WICKET-6323
> URL: https://issues.apache.org/jira/browse/WICKET-6323
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
>Affects Versions: 7.6.0, 8.0.0-M3, 6.26.0
>Reporter: Tobias Soloschenko
>Assignee: Tobias Soloschenko
>Priority: Minor
> Fix For: 6.27.0, 7.7.0, 8.0.0-M4
>
>
> ResourceBundles should be also configurable with the attribute defer
> {code}
>
[jira] [Created] (WICKET-6323) Allow ResourceBundles to use the defer attribute
Tobias Soloschenko created WICKET-6323:
--
Summary: Allow ResourceBundles to use the defer attribute
Key: WICKET-6323
URL: https://issues.apache.org/jira/browse/WICKET-6323
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 6.26.0, 8.0.0-M3, 7.6.0
Reporter: Tobias Soloschenko
Assignee: Tobias Soloschenko
Priority: Minor
Fix For: 6.27.0, 7.7.0, 8.0.0-M4
ResourceBundles should be also configurable with the attribute defer
{code}
[jira] [Resolved] (WICKET-6287) Switch from json.org to open-json
[ https://issues.apache.org/jira/browse/WICKET-6287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Soloschenko resolved WICKET-6287. Resolution: Fixed > Switch from json.org to open-json > - > > Key: WICKET-6287 > URL: https://issues.apache.org/jira/browse/WICKET-6287 > Project: Wicket > Issue Type: Task > Components: wicket, wicket-atmosphere, wicket-extensions >Affects Versions: 7.6.0, 8.0.0-M3, 6.26.0 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko >Priority: Minor > Labels: license > Fix For: 6.27.0, 7.7.0, 8.0.0-M4 > > > Because of license issues it is required to switch from json.org: > https://github.com/stleary/JSON-java > to open-json: > https://github.com/tdunning/open-json > For more information see: > http://apache-wicket.1842946.n4.nabble.com/Fwd-JSON-License-and-Apache-Projects-td4676261.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6287) Switch from json.org to open-json
[ https://issues.apache.org/jira/browse/WICKET-6287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Soloschenko updated WICKET-6287: --- Affects Version/s: (was: 7.5.0) (was: 6.25.0) (was: 8.0.0-M2) 8.0.0-M3 7.6.0 6.26.0 > Switch from json.org to open-json > - > > Key: WICKET-6287 > URL: https://issues.apache.org/jira/browse/WICKET-6287 > Project: Wicket > Issue Type: Task > Components: wicket, wicket-atmosphere, wicket-extensions >Affects Versions: 7.6.0, 8.0.0-M3, 6.26.0 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko >Priority: Minor > Labels: license > Fix For: 6.27.0, 7.7.0, 8.0.0-M4 > > > Because of license issues it is required to switch from json.org: > https://github.com/stleary/JSON-java > to open-json: > https://github.com/tdunning/open-json > For more information see: > http://apache-wicket.1842946.n4.nabble.com/Fwd-JSON-License-and-Apache-Projects-td4676261.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6287) Switch from json.org to open-json
[ https://issues.apache.org/jira/browse/WICKET-6287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Soloschenko updated WICKET-6287: --- Fix Version/s: (was: 8.0.0-M3) (was: 7.6.0) (was: 6.26) 8.0.0-M4 7.7.0 6.27.0 > Switch from json.org to open-json > - > > Key: WICKET-6287 > URL: https://issues.apache.org/jira/browse/WICKET-6287 > Project: Wicket > Issue Type: Task > Components: wicket, wicket-atmosphere, wicket-extensions >Affects Versions: 8.0.0-M2, 6.25.0, 7.5.0 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko >Priority: Minor > Labels: license > Fix For: 6.27.0, 7.7.0, 8.0.0-M4 > > > Because of license issues it is required to switch from json.org: > https://github.com/stleary/JSON-java > to open-json: > https://github.com/tdunning/open-json > For more information see: > http://apache-wicket.1842946.n4.nabble.com/Fwd-JSON-License-and-Apache-Projects-td4676261.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6299) Autofill support based on whatwg standard
[ https://issues.apache.org/jira/browse/WICKET-6299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15767500#comment-15767500 ] Tobias Soloschenko commented on WICKET-6299: Implementation was reverted due to conversation: http://apache-wicket.1842946.n4.nabble.com/Re-wicket-git-commit-WICKET-6299-td4676488.html > Autofill support based on whatwg standard > - > > Key: WICKET-6299 > URL: https://issues.apache.org/jira/browse/WICKET-6299 > Project: Wicket > Issue Type: New Feature > Components: wicket >Affects Versions: 8.0.0-M2 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko > Labels: features > Fix For: 8.0.0-M2 > > > Provide whatwg autofill functionality to the form components: > https://html.spec.whatwg.org/multipage/forms.html#autofilling-form-controls:-the-autocomplete-attribute -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Reopened] (WICKET-6299) Autofill support based on whatwg standard
[ https://issues.apache.org/jira/browse/WICKET-6299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Soloschenko reopened WICKET-6299: > Autofill support based on whatwg standard > - > > Key: WICKET-6299 > URL: https://issues.apache.org/jira/browse/WICKET-6299 > Project: Wicket > Issue Type: New Feature > Components: wicket >Affects Versions: 8.0.0-M2 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko > Labels: features > Fix For: 8.0.0-M2 > > > Provide whatwg autofill functionality to the form components: > https://html.spec.whatwg.org/multipage/forms.html#autofilling-form-controls:-the-autocomplete-attribute -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6299) Autofill support based on whatwg standard
[ https://issues.apache.org/jira/browse/WICKET-6299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Soloschenko updated WICKET-6299: --- Fix Version/s: (was: 8.0.0-M3) 8.0.0-M2 > Autofill support based on whatwg standard > - > > Key: WICKET-6299 > URL: https://issues.apache.org/jira/browse/WICKET-6299 > Project: Wicket > Issue Type: New Feature > Components: wicket >Affects Versions: 8.0.0-M2 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko > Labels: features > Fix For: 8.0.0-M2 > > > Provide whatwg autofill functionality to the form components: > https://html.spec.whatwg.org/multipage/forms.html#autofilling-form-controls:-the-autocomplete-attribute -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (WICKET-6299) Autofill support based on whatwg standard
[ https://issues.apache.org/jira/browse/WICKET-6299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Soloschenko resolved WICKET-6299. Resolution: Won't Fix > Autofill support based on whatwg standard > - > > Key: WICKET-6299 > URL: https://issues.apache.org/jira/browse/WICKET-6299 > Project: Wicket > Issue Type: New Feature > Components: wicket >Affects Versions: 8.0.0-M2 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko > Labels: features > Fix For: 8.0.0-M2 > > > Provide whatwg autofill functionality to the form components: > https://html.spec.whatwg.org/multipage/forms.html#autofilling-form-controls:-the-autocomplete-attribute -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (WICKET-6299) Autofill support based on whatwg standard
[ https://issues.apache.org/jira/browse/WICKET-6299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Soloschenko resolved WICKET-6299. Resolution: Fixed > Autofill support based on whatwg standard > - > > Key: WICKET-6299 > URL: https://issues.apache.org/jira/browse/WICKET-6299 > Project: Wicket > Issue Type: New Feature > Components: wicket >Affects Versions: 8.0.0-M2 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko > Labels: features > Fix For: 8.0.0-M3 > > > Provide whatwg autofill functionality to the form components: > https://html.spec.whatwg.org/multipage/forms.html#autofilling-form-controls:-the-autocomplete-attribute -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6299) Autofill support based on whatwg standard
[ https://issues.apache.org/jira/browse/WICKET-6299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Soloschenko updated WICKET-6299: --- Summary: Autofill support based on whatwg standard (was: Autofill support with based on whatwg standard) > Autofill support based on whatwg standard > - > > Key: WICKET-6299 > URL: https://issues.apache.org/jira/browse/WICKET-6299 > Project: Wicket > Issue Type: New Feature > Components: wicket >Affects Versions: 8.0.0-M2 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko > Labels: features > Fix For: 8.0.0-M3 > > > Provide whatwg autofill functionality to the form components: > https://html.spec.whatwg.org/multipage/forms.html#autofilling-form-controls:-the-autocomplete-attribute -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (WICKET-6299) Autofill support with based on whatwg standard
Tobias Soloschenko created WICKET-6299: -- Summary: Autofill support with based on whatwg standard Key: WICKET-6299 URL: https://issues.apache.org/jira/browse/WICKET-6299 Project: Wicket Issue Type: New Feature Components: wicket Affects Versions: 8.0.0-M2 Reporter: Tobias Soloschenko Assignee: Tobias Soloschenko Fix For: 8.0.0-M3 Provide whatwg autofill functionality to the form components: https://html.spec.whatwg.org/multipage/forms.html#autofilling-form-controls:-the-autocomplete-attribute -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6287) Switch from json.org to open-json
[ https://issues.apache.org/jira/browse/WICKET-6287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693898#comment-15693898 ] Tobias Soloschenko commented on WICKET-6287: There are some changes required in open-json, so that it can be used within Apache Wicket: * JSONFunction class for value as a hack to not surround it with quotes * Only escape "/" slash after a "<" bracket, because it is allowed * JDK 1.5 A PR is provided already: https://github.com/tdunning/open-json/pull/1 > Switch from json.org to open-json > - > > Key: WICKET-6287 > URL: https://issues.apache.org/jira/browse/WICKET-6287 > Project: Wicket > Issue Type: Task > Components: wicket, wicket-atmosphere, wicket-extensions >Affects Versions: 8.0.0-M2, 7.5.0, 1.5.17 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko >Priority: Critical > Labels: license > Fix For: 6.26, 7.6.0, 8.0.0-M3, 1.5.18 > > > Because of license issues it is required to switch from json.org: > https://github.com/stleary/JSON-java > to open-json: > https://github.com/tdunning/open-json > For more information see: > http://apache-wicket.1842946.n4.nabble.com/Fwd-JSON-License-and-Apache-Projects-td4676261.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (WICKET-6287) Switch from json.org to open-json
Tobias Soloschenko created WICKET-6287: -- Summary: Switch from json.org to open-json Key: WICKET-6287 URL: https://issues.apache.org/jira/browse/WICKET-6287 Project: Wicket Issue Type: Task Components: wicket, wicket-atmosphere, wicket-extensions Affects Versions: 1.5.17, 7.5.0, 8.0.0-M2 Reporter: Tobias Soloschenko Assignee: Tobias Soloschenko Priority: Critical Fix For: 1.5.18, 6.26, 7.6.0, 8.0.0-M3 Because of license issues it is required to switch from json.org: https://github.com/stleary/JSON-java to open-json: https://github.com/tdunning/open-json For more information see: http://apache-wicket.1842946.n4.nabble.com/Fwd-JSON-License-and-Apache-Projects-td4676261.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (WICKET-6194) PushBuilder API integration
[ https://issues.apache.org/jira/browse/WICKET-6194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Soloschenko resolved WICKET-6194. Resolution: Fixed > PushBuilder API integration > --- > > Key: WICKET-6194 > URL: https://issues.apache.org/jira/browse/WICKET-6194 > Project: Wicket > Issue Type: New Feature >Affects Versions: 8.0.0-M1 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko > Labels: features > Fix For: 8.0.0-M2 > > > Allows to push resources via HeaderItem to the client and make use of the > http/2 functionality. In the first step this should be an experimental module > and make use of the server specific APIs until the servlet 4.0 standard is > finished. > A reference implementation can be found here: > https://github.com/klopfdreh/wicket-components-playground/wiki/23.-PushHeaderItem_Servlet4Support > Working-Branch: > https://github.com/apache/wicket/tree/WICKET-6194 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5836) Update the version of clirr-maven-plugin (current 2.6.1)
[ https://issues.apache.org/jira/browse/WICKET-5836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15507580#comment-15507580 ] Tobias Soloschenko commented on WICKET-5836: Yay! Great! Thanks a lot Martin. > Update the version of clirr-maven-plugin (current 2.6.1) > > > Key: WICKET-5836 > URL: https://issues.apache.org/jira/browse/WICKET-5836 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 6.20.0, 7.0.0-M6, 8.0.0-M1 >Reporter: Tobias Soloschenko >Assignee: Martin Grigorov >Priority: Minor > Fix For: 8.0.0-M2 > > > This ticket is targeting Wicket 6.x, 7.x, 8.x compiled with JDK 8, because > the current version of the clirr plugin 2.6.1 isn't compatible with Java 8. > At the moment there is no version higher then 2.6.1 so we have to wait until > release. > More information can be found here: > http://mail-archives.apache.org/mod_mbox/commons-dev/201407.mbox/%3ccaczkxpzs2nxtvk5sejfyikvhp2817ey2b+7rak0w_nuyzha...@mail.gmail.com%3E > http://mail-archives.apache.org/mod_mbox/commons-dev/201407.mbox/%3c11f48c22-60d5-4a94-8ed2-42cccfefa...@email.android.com%3E > Here the correlating tickets: > https://issues.apache.org/jira/browse/BCEL-173 > https://issues.apache.org/jira/browse/BCEL-174 > https://issues.apache.org/jira/browse/BCEL-175 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (WICKET-6194) PushBuilder API integration
[ https://issues.apache.org/jira/browse/WICKET-6194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427058#comment-15427058 ] Tobias Soloschenko edited comment on WICKET-6194 at 8/18/16 8:02 PM: - Hi, with the last commits I changed the following things: 1. I made some methods protected. The most important method which is protected now is getPageModificationTime(). The user can override this method to apply other checks for the page modification date. For example a properties file which contains the build date - this can be used to check against the if-modified-since header together with the html file. (see javadoc) 2. applyPageCacheHeader. So that the user can customize the PushHeaderItem headers I used a little trick now and I hope this also works for chrome. I set the expiration date to the "last-modified" date of the file (or what the user configures) - "Expires" is set to -1 so that the cache entry becomes invalid immediately. Also I set the max-age to 0 and must-revalidate, proxy-revalidate. With this options the browser uses the cache but actually don't cache anything. But what the browser do is to send the "if-modified-since" date so that the Push API can make use of the browser cache. Also I changed the SimpleDateFormat to DateTimeFormatter so that there will be no concurrency issue. The last thing I added was a bit javadoc. kind regards Tobias was (Author: klopfdreh): Hi, with the last commits I changed the following things: 1. I made some methods protected. The most important method which is protected now is getPageModificationTime(). The user can override this method to apply other checks for the page modification date. For example a properties file which contains the build date - this can be used to check against the if-modified-since header together with the html file. (see javadoc) 2. applyPageCacheHeader. So that the user can customize the PushHeaderItem headers I used a little trick now and I hope this also works for chrome. I set the expiration date to the "last-modified" date of the file (or what the user configured) - "Expires" is set to -1 so that the cache entry becomes invalid immediately. Also I set the max-age to 0 and must-revalidate, proxy-revalidate. With this options the browser uses the cache but actually don't cache anything. But what the browser do is to send the "if-modified-since" date so that the Push API can make use of the browser cache. Also I changed the SimpleDateFormat to DateTimeFormatter so that there will be no concurrency issue. The last thing I added was a bit javadoc. kind regards Tobias > PushBuilder API integration > --- > > Key: WICKET-6194 > URL: https://issues.apache.org/jira/browse/WICKET-6194 > Project: Wicket > Issue Type: New Feature >Affects Versions: 8.0.0-M1 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko > Labels: features > Fix For: 8.0.0-M2 > > > Allows to push resources via HeaderItem to the client and make use of the > http/2 functionality. In the first step this should be an experimental module > and make use of the server specific APIs until the servlet 4.0 standard is > finished. > A reference implementation can be found here: > https://github.com/klopfdreh/wicket-components-playground/wiki/23.-PushHeaderItem_Servlet4Support > Working-Branch: > https://github.com/apache/wicket/tree/WICKET-6194 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (WICKET-6194) PushBuilder API integration
[ https://issues.apache.org/jira/browse/WICKET-6194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427058#comment-15427058 ] Tobias Soloschenko edited comment on WICKET-6194 at 8/18/16 8:02 PM: - Hi, with the last commits I changed the following things: 1. I made some methods protected. The most important method which is protected now is getPageModificationTime(). The user can override this method to apply other checks for the page modification date. For example a properties file which contains the build date - this can be used to check against the if-modified-since header together with the html file. (see javadoc) 2. applyPageCacheHeader. So that the user can customize the PushHeaderItem headers I used a little trick now and I hope this also works for chrome. I set the expiration date to the "last-modified" date of the file (or what the user configures) - "Expires" is set to -1 so that the cache entry becomes invalid / stale immediately. Also I set the max-age to 0 and must-revalidate, proxy-revalidate. With this options the browser uses the cache but actually don't cache anything. But what the browser do is to send the "if-modified-since" date so that the Push API can make use of the browser cache. Also I changed the SimpleDateFormat to DateTimeFormatter so that there will be no concurrency issue. The last thing I added was a bit javadoc. kind regards Tobias was (Author: klopfdreh): Hi, with the last commits I changed the following things: 1. I made some methods protected. The most important method which is protected now is getPageModificationTime(). The user can override this method to apply other checks for the page modification date. For example a properties file which contains the build date - this can be used to check against the if-modified-since header together with the html file. (see javadoc) 2. applyPageCacheHeader. So that the user can customize the PushHeaderItem headers I used a little trick now and I hope this also works for chrome. I set the expiration date to the "last-modified" date of the file (or what the user configures) - "Expires" is set to -1 so that the cache entry becomes invalid immediately. Also I set the max-age to 0 and must-revalidate, proxy-revalidate. With this options the browser uses the cache but actually don't cache anything. But what the browser do is to send the "if-modified-since" date so that the Push API can make use of the browser cache. Also I changed the SimpleDateFormat to DateTimeFormatter so that there will be no concurrency issue. The last thing I added was a bit javadoc. kind regards Tobias > PushBuilder API integration > --- > > Key: WICKET-6194 > URL: https://issues.apache.org/jira/browse/WICKET-6194 > Project: Wicket > Issue Type: New Feature >Affects Versions: 8.0.0-M1 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko > Labels: features > Fix For: 8.0.0-M2 > > > Allows to push resources via HeaderItem to the client and make use of the > http/2 functionality. In the first step this should be an experimental module > and make use of the server specific APIs until the servlet 4.0 standard is > finished. > A reference implementation can be found here: > https://github.com/klopfdreh/wicket-components-playground/wiki/23.-PushHeaderItem_Servlet4Support > Working-Branch: > https://github.com/apache/wicket/tree/WICKET-6194 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (WICKET-6194) PushBuilder API integration
[ https://issues.apache.org/jira/browse/WICKET-6194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427058#comment-15427058 ] Tobias Soloschenko edited comment on WICKET-6194 at 8/18/16 8:01 PM: - Hi, with the last commits I changed the following things: 1. I made some methods protected. The most important method which is protected now is getPageModificationTime(). The user can override this method to apply other checks for the page modification date. For example a properties file which contains the build date - this can be used to check against the if-modified-since header together with the html file. (see javadoc) 2. applyPageCacheHeader. So that the user can customize the PushHeaderItem headers I used a little trick now and I hope this also works for chrome. I set the expiration date to the "last-modified" date of the file (or what the user configured) - "Expires" is set to -1 so that the cache entry becomes invalid immediately. Also I set the max-age to 0 and must-revalidate, proxy-revalidate. With this options the browser uses the cache but actually don't cache anything. But what the browser do is to send the "if-modified-since" date so that the Push API can make use of the browser cache. Also I changed the SimpleDateFormat to DateTimeFormatter so that there will be no concurrency issue. The last thing I added was a bit javadoc. kind regards Tobias was (Author: klopfdreh): Hi, with the last commits I changed the following things: 1. I made some methods protected. The most important method which is protected now is getPageModificationTime(). The user can override this method to apply other checks for the page modification date. For example a properties file which contains the build date - this can be used to check against the if-modified-since header. 2. applyPageCacheHeader. So that the user can customize the PushHeaderItem headers I used a little trick now and I hope this also works for chrome. I set the expiration date to the "last-modified" date of the file (or what the user configured) - "Expires" is set to -1 so that the cache entry becomes invalid immediately. Also I set the max-age to 0 and must-revalidate, proxy-revalidate. With this options the browser uses the cache but actually don't cache anything. But what the browser do is to send the "if-modified-since" date so that the Push API can make use of the browser cache. Also I changed the SimpleDateFormat to DateTimeFormatter so that there will be no concurrency issue. The last thing I added was a bit javadoc. kind regards Tobias > PushBuilder API integration > --- > > Key: WICKET-6194 > URL: https://issues.apache.org/jira/browse/WICKET-6194 > Project: Wicket > Issue Type: New Feature >Affects Versions: 8.0.0-M1 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko > Labels: features > Fix For: 8.0.0-M2 > > > Allows to push resources via HeaderItem to the client and make use of the > http/2 functionality. In the first step this should be an experimental module > and make use of the server specific APIs until the servlet 4.0 standard is > finished. > A reference implementation can be found here: > https://github.com/klopfdreh/wicket-components-playground/wiki/23.-PushHeaderItem_Servlet4Support > Working-Branch: > https://github.com/apache/wicket/tree/WICKET-6194 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (WICKET-6194) PushBuilder API integration
[ https://issues.apache.org/jira/browse/WICKET-6194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427058#comment-15427058 ] Tobias Soloschenko edited comment on WICKET-6194 at 8/18/16 8:01 PM: - Hi, with the last commits I changed the following things: 1. I made some methods protected. The most important method which is protected now is getPageModificationTime(). The user can override this method to apply other checks for the page modification date. For example a properties file which contains the build date - this can be used to check against the if-modified-since header. 2. applyPageCacheHeader. So that the user can customize the PushHeaderItem headers I used a little trick now and I hope this also works for chrome. I set the expiration date to the "last-modified" date of the file (or what the user configured) - "Expires" is set to -1 so that the cache entry becomes invalid immediately. Also I set the max-age to 0 and must-revalidate, proxy-revalidate. With this options the browser uses the cache but actually don't cache anything. But what the browser do is to send the "if-modified-since" date so that the Push API can make use of the browser cache. Also I changed the SimpleDateFormat to DateTimeFormatter so that there will be no concurrency issue. The last thing I added was a bit javadoc. kind regards Tobias was (Author: klopfdreh): Hi, with the last commits I changed the following things: 1. I made some methods protected. The most important method which is protected now is getPageModificationTime(). The use can override this method to apply other checks for the page modification date. For example a properties file which contains the build date - this can be used to check against the if-modified-since header. 2. applyPageCacheHeader. So that the user can customize the PushHeaderItem headers I used a little trick now and I hope this also works for chrome. I set the expiration date to the "last-modified" date of the file (or what the user configured) - "Expires" is set to -1 so that the cache entry becomes invalid immediately. Also I set the max-age to 0 and must-revalidate, proxy-revalidate. With this options the browser uses the cache but actually don't cache anything. But what the browser do is to send the "if-modified-since" date so that the Push API can make use of the browser cache. Also I changed the SimpleDateFormat to DateTimeFormatter so that there will be no concurrency issue. The last thing I added was a bit javadoc. kind regards Tobias > PushBuilder API integration > --- > > Key: WICKET-6194 > URL: https://issues.apache.org/jira/browse/WICKET-6194 > Project: Wicket > Issue Type: New Feature >Affects Versions: 8.0.0-M1 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko > Labels: features > Fix For: 8.0.0-M2 > > > Allows to push resources via HeaderItem to the client and make use of the > http/2 functionality. In the first step this should be an experimental module > and make use of the server specific APIs until the servlet 4.0 standard is > finished. > A reference implementation can be found here: > https://github.com/klopfdreh/wicket-components-playground/wiki/23.-PushHeaderItem_Servlet4Support > Working-Branch: > https://github.com/apache/wicket/tree/WICKET-6194 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6194) PushBuilder API integration
[ https://issues.apache.org/jira/browse/WICKET-6194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427058#comment-15427058 ] Tobias Soloschenko commented on WICKET-6194: Hi, with the last commits I changed the following things: 1. I made some methods protected. The most important method which is protected now is getPageModificationTime(). The use can override this method to apply other checks for the page modification date. For example a properties file which contains the build date - this can be used to check against the if-modified-since header. 2. applyPageCacheHeader. So that the user can customize the PushHeaderItem headers I used a little trick now and I hope this also works for chrome. I set the expiration date to the "last-modified" date of the file (or what the user configured) - "Expires" is set to -1 so that the cache entry becomes invalid immediately. Also I set the max-age to 0 and must-revalidate, proxy-revalidate. With this options the browser uses the cache but actually don't cache anything. But what the browser do is to send the "if-modified-since" date so that the Push API can make use of the browser cache. Also I changed the SimpleDateFormat to DateTimeFormatter so that there will be no concurrency issue. The last thing I added was a bit javadoc. kind regards Tobias > PushBuilder API integration > --- > > Key: WICKET-6194 > URL: https://issues.apache.org/jira/browse/WICKET-6194 > Project: Wicket > Issue Type: New Feature >Affects Versions: 8.0.0-M1 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko > Labels: features > Fix For: 8.0.0-M2 > > > Allows to push resources via HeaderItem to the client and make use of the > http/2 functionality. In the first step this should be an experimental module > and make use of the server specific APIs until the servlet 4.0 standard is > finished. > A reference implementation can be found here: > https://github.com/klopfdreh/wicket-components-playground/wiki/23.-PushHeaderItem_Servlet4Support > Working-Branch: > https://github.com/apache/wicket/tree/WICKET-6194 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6194) PushBuilder API integration
[ https://issues.apache.org/jira/browse/WICKET-6194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Soloschenko updated WICKET-6194: --- Fix Version/s: (was: 8.0.0-M1) 8.0.0-M2 > PushBuilder API integration > --- > > Key: WICKET-6194 > URL: https://issues.apache.org/jira/browse/WICKET-6194 > Project: Wicket > Issue Type: New Feature >Affects Versions: 8.0.0-M1 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko > Labels: features > Fix For: 8.0.0-M2 > > > Allows to push resources via HeaderItem to the client and make use of the > http/2 functionality. In the first step this should be an experimental module > and make use of the server specific APIs until the servlet 4.0 standard is > finished. > A reference implementation can be found here: > https://github.com/klopfdreh/wicket-components-playground/wiki/23.-PushHeaderItem_Servlet4Support > Working-Branch: > https://github.com/apache/wicket/tree/WICKET-6194 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6194) PushBuilder API integration
[ https://issues.apache.org/jira/browse/WICKET-6194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368935#comment-15368935 ] Tobias Soloschenko commented on WICKET-6194: Hi Martin, I commited the following things and pushed the branch to master: * Javadoc for all classes * Undertow push builder API * pom.xml changes to also build the new experimental projects kind regards Tobias > PushBuilder API integration > --- > > Key: WICKET-6194 > URL: https://issues.apache.org/jira/browse/WICKET-6194 > Project: Wicket > Issue Type: New Feature >Affects Versions: 8.0.0-M1 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko > Labels: features > Fix For: 8.0.0-M1 > > > Allows to push resources via HeaderItem to the client and make use of the > http/2 functionality. In the first step this should be an experimental module > and make use of the server specific APIs until the servlet 4.0 standard is > finished. > A reference implementation can be found here: > https://github.com/klopfdreh/wicket-components-playground/wiki/23.-PushHeaderItem_Servlet4Support > Working-Branch: > https://github.com/apache/wicket/tree/WICKET-6194 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6194) PushBuilder API integration
[ https://issues.apache.org/jira/browse/WICKET-6194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Soloschenko updated WICKET-6194: --- Description: Allows to push resources via HeaderItem to the client and make use of the http/2 functionality. In the first step this should be an experimental module and make use of the server specific APIs until the servlet 4.0 standard is finished. A reference implementation can be found here: https://github.com/klopfdreh/wicket-components-playground/wiki/23.-PushHeaderItem_Servlet4Support Working-Branch: https://github.com/apache/wicket/tree/WICKET-6194 was: Allows to push resources via HeaderItem to the client and make use of the http/2 functionality. In the first step this should be an experimental module and make use of the server specific APIs until the servlet 4.0 standard is finished. A reference implementation can be found here: https://github.com/klopfdreh/wicket-components-playground/wiki/23.-PushHeaderItem_Servlet4Support > PushBuilder API integration > --- > > Key: WICKET-6194 > URL: https://issues.apache.org/jira/browse/WICKET-6194 > Project: Wicket > Issue Type: New Feature >Affects Versions: 8.0.0-M1 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko > Labels: features > Fix For: 8.0.0-M1 > > > Allows to push resources via HeaderItem to the client and make use of the > http/2 functionality. In the first step this should be an experimental module > and make use of the server specific APIs until the servlet 4.0 standard is > finished. > A reference implementation can be found here: > https://github.com/klopfdreh/wicket-components-playground/wiki/23.-PushHeaderItem_Servlet4Support > Working-Branch: > https://github.com/apache/wicket/tree/WICKET-6194 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (WICKET-6194) PushBuilder API integration
Tobias Soloschenko created WICKET-6194: -- Summary: PushBuilder API integration Key: WICKET-6194 URL: https://issues.apache.org/jira/browse/WICKET-6194 Project: Wicket Issue Type: New Feature Affects Versions: 8.0.0-M1 Reporter: Tobias Soloschenko Assignee: Tobias Soloschenko Fix For: 8.0.0-M1 Allows to push resources via HeaderItem to the client and make use of the http/2 functionality. In the first step this should be an experimental module and make use of the server specific APIs until the servlet 4.0 standard is finished. A reference implementation can be found here: https://github.com/klopfdreh/wicket-components-playground/wiki/23.-PushHeaderItem_Servlet4Support -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (WICKET-6193) NestedStringResourceLoader - replaces nested keys within property files
[ https://issues.apache.org/jira/browse/WICKET-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Soloschenko resolved WICKET-6193. Resolution: Fixed > NestedStringResourceLoader - replaces nested keys within property files > --- > > Key: WICKET-6193 > URL: https://issues.apache.org/jira/browse/WICKET-6193 > Project: Wicket > Issue Type: New Feature > Components: wicket >Affects Versions: 8.0.0-M1, 7.4.0 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko > Labels: features > Fix For: 8.0.0-M1, 7.4.0 > > > As described here it would be great to replace nested keys in property files: > http://apache-wicket.1842946.n4.nabble.com/Dynamic-localisation-td4674990.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (WICKET-6193) NestedStringResourceLoader - replaces nested keys within property files
Tobias Soloschenko created WICKET-6193: -- Summary: NestedStringResourceLoader - replaces nested keys within property files Key: WICKET-6193 URL: https://issues.apache.org/jira/browse/WICKET-6193 Project: Wicket Issue Type: New Feature Components: wicket Affects Versions: 8.0.0-M1, 7.4.0 Reporter: Tobias Soloschenko Assignee: Tobias Soloschenko Fix For: 8.0.0-M1, 7.4.0 As described here it would be great to replace nested keys in property files: http://apache-wicket.1842946.n4.nabble.com/Dynamic-localisation-td4674990.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (WICKET-6160) Missing type for MediaComponent causing iOS devices not to be able to play videos
[
https://issues.apache.org/jira/browse/WICKET-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269540#comment-15269540
]
Tobias Soloschenko edited comment on WICKET-6160 at 5/3/16 8:39 PM:
That easy? Impossible! :-) - Thank you
was (Author: klopfdreh):
That easy? Impossible! :-D - Thank you
> Missing type for MediaComponent causing iOS devices not to be able to play
> videos
> -
>
> Key: WICKET-6160
> URL: https://issues.apache.org/jira/browse/WICKET-6160
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-examples
>Affects Versions: 7.2.0, 8.0.0
>Reporter: Tobias Soloschenko
>Assignee: Tobias Soloschenko
>Priority: Minor
> Fix For: 8.0.0-M1, 7.4.0
>
>
> Because of a missing option to set the type for MediaComponents - Video /
> Audio can't be played on iOS devices.
> If you want to enable it with the Wicket 7.2.0 you have to override the
> onComponentTag method:
> {code}
> @Override
> protected void onComponentTag(ComponentTag tag)
> {
> super.onComponentTag(tag);
> tag.put("type", "video/mp4");
> }
> {code}
> See Table 10-1 File name extensions for MIME types:
> https://developer.apple.com/library/safari/documentation/AppleApplications/Reference/SafariWebContent/CreatingVideoforSafarioniPhone/CreatingVideoforSafarioniPhone.html#//apple_ref/doc/uid/TP40006514-SW6
> I used remote debugging of iOS Safari / Mac OS X to check if all videos are
> playing, now.
> http://moduscreate.com/enable-remote-web-inspector-in-ios-6/ (for iOS 9 very
> similar)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-6160) Missing type for MediaComponent causing iOS devices not to be able to play videos
[
https://issues.apache.org/jira/browse/WICKET-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269540#comment-15269540
]
Tobias Soloschenko commented on WICKET-6160:
That easy? Impossible! :-D - Thank you
> Missing type for MediaComponent causing iOS devices not to be able to play
> videos
> -
>
> Key: WICKET-6160
> URL: https://issues.apache.org/jira/browse/WICKET-6160
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-examples
>Affects Versions: 7.2.0, 8.0.0
>Reporter: Tobias Soloschenko
>Assignee: Tobias Soloschenko
>Priority: Minor
> Fix For: 8.0.0-M1, 7.4.0
>
>
> Because of a missing option to set the type for MediaComponents - Video /
> Audio can't be played on iOS devices.
> If you want to enable it with the Wicket 7.2.0 you have to override the
> onComponentTag method:
> {code}
> @Override
> protected void onComponentTag(ComponentTag tag)
> {
> super.onComponentTag(tag);
> tag.put("type", "video/mp4");
> }
> {code}
> See Table 10-1 File name extensions for MIME types:
> https://developer.apple.com/library/safari/documentation/AppleApplications/Reference/SafariWebContent/CreatingVideoforSafarioniPhone/CreatingVideoforSafarioniPhone.html#//apple_ref/doc/uid/TP40006514-SW6
> I used remote debugging of iOS Safari / Mac OS X to check if all videos are
> playing, now.
> http://moduscreate.com/enable-remote-web-inspector-in-ios-6/ (for iOS 9 very
> similar)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (WICKET-6160) Missing type for MediaComponent causing iOS devices not to be able to play videos
[
https://issues.apache.org/jira/browse/WICKET-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269469#comment-15269469
]
Tobias Soloschenko edited comment on WICKET-6160 at 5/3/16 7:59 PM:
[~mgrigorov] - I can't set the Fix Version/s to 7.4.0 - because 7.3.0 is going
to be released, soon I think this change is not going to make it in 7.3.0
anymore. Would you be so kind and help me out with this?
Thanks a lot! :-)
was (Author: klopfdreh):
[~mgrigorov] - I can't set the Fix Version/s to 7.4.0 - because 7.3.0 is going
to be released, soon I think this change is not going to make it in 7.3.0
anymore. Would you be so kind and help me out with this?
> Missing type for MediaComponent causing iOS devices not to be able to play
> videos
> -
>
> Key: WICKET-6160
> URL: https://issues.apache.org/jira/browse/WICKET-6160
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-examples
>Affects Versions: 7.2.0, 8.0.0
>Reporter: Tobias Soloschenko
>Assignee: Tobias Soloschenko
>Priority: Minor
> Fix For: 7.3.0, 8.0.0-M1
>
>
> Because of a missing option to set the type for MediaComponents - Video /
> Audio can't be played on iOS devices.
> If you want to enable it with the Wicket 7.2.0 you have to override the
> onComponentTag method:
> {code}
> @Override
> protected void onComponentTag(ComponentTag tag)
> {
> super.onComponentTag(tag);
> tag.put("type", "video/mp4");
> }
> {code}
> See Table 10-1 File name extensions for MIME types:
> https://developer.apple.com/library/safari/documentation/AppleApplications/Reference/SafariWebContent/CreatingVideoforSafarioniPhone/CreatingVideoforSafarioniPhone.html#//apple_ref/doc/uid/TP40006514-SW6
> I used remote debugging of iOS Safari / Mac OS X to check if all videos are
> playing, now.
> http://moduscreate.com/enable-remote-web-inspector-in-ios-6/ (for iOS 9 very
> similar)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-6160) Missing type for MediaComponent causing iOS devices not to be able to play videos
[
https://issues.apache.org/jira/browse/WICKET-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269469#comment-15269469
]
Tobias Soloschenko commented on WICKET-6160:
[~mgrigorov] - I can't set the Fix Version/s to 7.4.0 - because 7.3.0 is going
to be released, soon I think this change is not going to make it in 7.3.0
anymore. Would you be so kind and help me out with this?
> Missing type for MediaComponent causing iOS devices not to be able to play
> videos
> -
>
> Key: WICKET-6160
> URL: https://issues.apache.org/jira/browse/WICKET-6160
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-examples
>Affects Versions: 7.2.0, 8.0.0
>Reporter: Tobias Soloschenko
>Assignee: Tobias Soloschenko
>Priority: Minor
> Fix For: 7.3.0, 8.0.0-M1
>
>
> Because of a missing option to set the type for MediaComponents - Video /
> Audio can't be played on iOS devices.
> If you want to enable it with the Wicket 7.2.0 you have to override the
> onComponentTag method:
> {code}
> @Override
> protected void onComponentTag(ComponentTag tag)
> {
> super.onComponentTag(tag);
> tag.put("type", "video/mp4");
> }
> {code}
> See Table 10-1 File name extensions for MIME types:
> https://developer.apple.com/library/safari/documentation/AppleApplications/Reference/SafariWebContent/CreatingVideoforSafarioniPhone/CreatingVideoforSafarioniPhone.html#//apple_ref/doc/uid/TP40006514-SW6
> I used remote debugging of iOS Safari / Mac OS X to check if all videos are
> playing, now.
> http://moduscreate.com/enable-remote-web-inspector-in-ios-6/ (for iOS 9 very
> similar)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (WICKET-6160) Missing type for MediaComponent causing iOS devices not to be able to play videos
[
https://issues.apache.org/jira/browse/WICKET-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tobias Soloschenko resolved WICKET-6160.
Resolution: Fixed
> Missing type for MediaComponent causing iOS devices not to be able to play
> videos
> -
>
> Key: WICKET-6160
> URL: https://issues.apache.org/jira/browse/WICKET-6160
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-examples
>Affects Versions: 7.2.0, 8.0.0
>Reporter: Tobias Soloschenko
>Assignee: Tobias Soloschenko
>Priority: Minor
> Fix For: 7.3.0, 8.0.0-M1
>
>
> Because of a missing option to set the type for MediaComponents - Video /
> Audio can't be played on iOS devices.
> If you want to enable it with the Wicket 7.2.0 you have to override the
> onComponentTag method:
> {code}
> @Override
> protected void onComponentTag(ComponentTag tag)
> {
> super.onComponentTag(tag);
> tag.put("type", "video/mp4");
> }
> {code}
> See Table 10-1 File name extensions for MIME types:
> https://developer.apple.com/library/safari/documentation/AppleApplications/Reference/SafariWebContent/CreatingVideoforSafarioniPhone/CreatingVideoforSafarioniPhone.html#//apple_ref/doc/uid/TP40006514-SW6
> I used remote debugging of iOS Safari / Mac OS X to check if all videos are
> playing, now.
> http://moduscreate.com/enable-remote-web-inspector-in-ios-6/ (for iOS 9 very
> similar)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (WICKET-6160) Missing type for MediaComponent causing iOS devices not to be able to play videos
[
https://issues.apache.org/jira/browse/WICKET-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tobias Soloschenko updated WICKET-6160:
---
Description:
Because of a missing option to set the type for MediaComponents - Video / Audio
can't be played on iOS devices.
If you want to enable it with the Wicket 7.2.0 you have to override the
onComponentTag method:
{code}
@Override
protected void onComponentTag(ComponentTag tag)
{
super.onComponentTag(tag);
tag.put("type", "video/mp4");
}
{code}
See Table 10-1 File name extensions for MIME types:
https://developer.apple.com/library/safari/documentation/AppleApplications/Reference/SafariWebContent/CreatingVideoforSafarioniPhone/CreatingVideoforSafarioniPhone.html#//apple_ref/doc/uid/TP40006514-SW6
I used remote debugging of iOS Safari / Mac OS X to check if all videos are
playing, now.
http://moduscreate.com/enable-remote-web-inspector-in-ios-6/ (for iOS 9 very
similar)
was:
Because of a missing option to set the type for MediaComponents - Video / Audio
can't be played on iOS devices.
If you want to enable it with the Wicket 7.2.0 you have to override the
onComponentTag method:
{code}
@Override
protected void onComponentTag(ComponentTag tag)
{
super.onComponentTag(tag);
tag.put("type", "video/mp4");
}
{code}
See Table 10-1 File name extensions for MIME types:
https://developer.apple.com/library/safari/documentation/AppleApplications/Reference/SafariWebContent/CreatingVideoforSafarioniPhone/CreatingVideoforSafarioniPhone.html#//apple_ref/doc/uid/TP40006514-SW6
I used remote debugging of iOS Safari / Mac OS X to check if all videos are
playing, now.
> Missing type for MediaComponent causing iOS devices not to be able to play
> videos
> -
>
> Key: WICKET-6160
> URL: https://issues.apache.org/jira/browse/WICKET-6160
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-examples
>Affects Versions: 7.2.0, 8.0.0
>Reporter: Tobias Soloschenko
>Assignee: Tobias Soloschenko
>Priority: Minor
> Fix For: 7.3.0, 8.0.0-M1
>
>
> Because of a missing option to set the type for MediaComponents - Video /
> Audio can't be played on iOS devices.
> If you want to enable it with the Wicket 7.2.0 you have to override the
> onComponentTag method:
> {code}
> @Override
> protected void onComponentTag(ComponentTag tag)
> {
> super.onComponentTag(tag);
> tag.put("type", "video/mp4");
> }
> {code}
> See Table 10-1 File name extensions for MIME types:
> https://developer.apple.com/library/safari/documentation/AppleApplications/Reference/SafariWebContent/CreatingVideoforSafarioniPhone/CreatingVideoforSafarioniPhone.html#//apple_ref/doc/uid/TP40006514-SW6
> I used remote debugging of iOS Safari / Mac OS X to check if all videos are
> playing, now.
> http://moduscreate.com/enable-remote-web-inspector-in-ios-6/ (for iOS 9 very
> similar)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (WICKET-6160) Missing type for MediaComponent causing iOS devices not to be able to play videos
[
https://issues.apache.org/jira/browse/WICKET-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tobias Soloschenko updated WICKET-6160:
---
Description:
Because of a missing option to set the type for MediaComponents - Video / Audio
can't be played on iOS devices.
If you want to enable it with the Wicket 7.2.0 you have to override the
onComponentTag method:
{code}
@Override
protected void onComponentTag(ComponentTag tag)
{
super.onComponentTag(tag);
tag.put("type", "video/mp4");
}
{code}
See Table 10-1 File name extensions for MIME types:
https://developer.apple.com/library/safari/documentation/AppleApplications/Reference/SafariWebContent/CreatingVideoforSafarioniPhone/CreatingVideoforSafarioniPhone.html#//apple_ref/doc/uid/TP40006514-SW6
I used remote debugging of iOS Safari / Mac OS X to check if all videos are
playing, now.
was:
Because of a missing option to set the type for MediaComponents - Video / Audio
can't be played on iOS devices.
If you want to enable it with the Wicket 7.2.0 you have to override the
onComponentTag method:
{code}
@Override
protected void onComponentTag(ComponentTag tag)
{
super.onComponentTag(tag);
tag.put("type", "video/mp4");
}
{code}
> Missing type for MediaComponent causing iOS devices not to be able to play
> videos
> -
>
> Key: WICKET-6160
> URL: https://issues.apache.org/jira/browse/WICKET-6160
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-examples
>Affects Versions: 7.2.0, 8.0.0
>Reporter: Tobias Soloschenko
>Assignee: Tobias Soloschenko
>Priority: Minor
> Fix For: 7.3.0, 8.0.0-M1
>
>
> Because of a missing option to set the type for MediaComponents - Video /
> Audio can't be played on iOS devices.
> If you want to enable it with the Wicket 7.2.0 you have to override the
> onComponentTag method:
> {code}
> @Override
> protected void onComponentTag(ComponentTag tag)
> {
> super.onComponentTag(tag);
> tag.put("type", "video/mp4");
> }
> {code}
> See Table 10-1 File name extensions for MIME types:
> https://developer.apple.com/library/safari/documentation/AppleApplications/Reference/SafariWebContent/CreatingVideoforSafarioniPhone/CreatingVideoforSafarioniPhone.html#//apple_ref/doc/uid/TP40006514-SW6
> I used remote debugging of iOS Safari / Mac OS X to check if all videos are
> playing, now.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (WICKET-6160) Missing type for MediaComponent causing iOS devices not to be able to play videos
[
https://issues.apache.org/jira/browse/WICKET-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tobias Soloschenko updated WICKET-6160:
---
Description:
Because of a missing option to set the type for MediaComponents - Video / Audio
can't be played on iOS devices.
If you want to enable it with the Wicket 7.2.0 you have to override the
onComponentTag method:
{code}
@Override
protected void onComponentTag(ComponentTag tag)
{
super.onComponentTag(tag);
tag.put("type", "video/mp4");
}
{code}
was:
Because of a missing option to set the type for MediaComponents and because of
that for Video / Audio, it is not possible to play videos on iOS devices.
If you want to enable it with the Wicket 7.2.0 you have to override the
onComponentTag method:
{code}
@Override
protected void onComponentTag(ComponentTag tag)
{
super.onComponentTag(tag);
tag.put("type", "video/mp4");
}
{code}
> Missing type for MediaComponent causing iOS devices not to be able to play
> videos
> -
>
> Key: WICKET-6160
> URL: https://issues.apache.org/jira/browse/WICKET-6160
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-examples
>Affects Versions: 7.2.0, 8.0.0
>Reporter: Tobias Soloschenko
>Assignee: Tobias Soloschenko
>Priority: Minor
> Fix For: 7.3.0, 8.0.0-M1
>
>
> Because of a missing option to set the type for MediaComponents - Video /
> Audio can't be played on iOS devices.
> If you want to enable it with the Wicket 7.2.0 you have to override the
> onComponentTag method:
> {code}
> @Override
> protected void onComponentTag(ComponentTag tag)
> {
> super.onComponentTag(tag);
> tag.put("type", "video/mp4");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (WICKET-6160) Missing type for MediaComponent causing iOS devices not to be able to play videos
[
https://issues.apache.org/jira/browse/WICKET-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tobias Soloschenko updated WICKET-6160:
---
Priority: Minor (was: Major)
> Missing type for MediaComponent causing iOS devices not to be able to play
> videos
> -
>
> Key: WICKET-6160
> URL: https://issues.apache.org/jira/browse/WICKET-6160
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-examples
>Affects Versions: 7.2.0, 8.0.0
>Reporter: Tobias Soloschenko
>Assignee: Tobias Soloschenko
>Priority: Minor
> Fix For: 7.3.0, 8.0.0-M1
>
>
> Because of a missing option to set the type for MediaComponents and because
> of that for Video / Audio, it is not possible to play videos on iOS devices.
> If you want to enable it with the Wicket 7.2.0 you have to override the
> onComponentTag method:
> {code}
> @Override
> protected void onComponentTag(ComponentTag tag)
> {
> super.onComponentTag(tag);
> tag.put("type", "video/mp4");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (WICKET-6160) Missing type for MediaComponent causing iOS devices not to be able to play videos
[
https://issues.apache.org/jira/browse/WICKET-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tobias Soloschenko updated WICKET-6160:
---
Description:
Because of a missing option to set the type for MediaComponents and because of
that for Video / Audio, it is not possible to play videos on iOS devices.
If you want to enable it with the Wicket 7.2.0 you have to override the
onComponentTag method:
{code}
@Override
protected void onComponentTag(ComponentTag tag)
{
super.onComponentTag(tag);
tag.put("type", "video/mp4");
}
{code}
was:
Because of a missing option to set the type for MediaComponents and because of
that for Video / Audio, it is not possible to play videos on iOS devices.
If you want to enable it with the Wicket 7.2.0 you have to override the
onComponentTag method:
{code}
@Override
protected void onComponentTag(ComponentTag tag)
{
super.onComponentTag(tag);
}
{code}
> Missing type for MediaComponent causing iOS devices not to be able to play
> videos
> -
>
> Key: WICKET-6160
> URL: https://issues.apache.org/jira/browse/WICKET-6160
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-examples
>Affects Versions: 7.2.0, 8.0.0
>Reporter: Tobias Soloschenko
>Assignee: Tobias Soloschenko
> Fix For: 7.3.0, 8.0.0-M1
>
>
> Because of a missing option to set the type for MediaComponents and because
> of that for Video / Audio, it is not possible to play videos on iOS devices.
> If you want to enable it with the Wicket 7.2.0 you have to override the
> onComponentTag method:
> {code}
> @Override
> protected void onComponentTag(ComponentTag tag)
> {
> super.onComponentTag(tag);
> tag.put("type", "video/mp4");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (WICKET-6160) Missing type for MediaComponent causing iOS devices not to be able to play videos
[
https://issues.apache.org/jira/browse/WICKET-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tobias Soloschenko updated WICKET-6160:
---
Description:
Because of a missing option to set the type for MediaComponents and because of
that for Video / Audio, it is not possible to play videos on iOS devices.
If you want to enable it with the Wicket 7.2.0 you have to override the
onComponentTag method:
{code}
@Override
protected void onComponentTag(ComponentTag tag)
{
super.onComponentTag(tag);
}
{code}
was:Because of a missing option to set the type for MediaComponents and
because of that for Video / Audio, it is not possible to play videos on iOS
devices.
> Missing type for MediaComponent causing iOS devices not to be able to play
> videos
> -
>
> Key: WICKET-6160
> URL: https://issues.apache.org/jira/browse/WICKET-6160
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-examples
>Affects Versions: 7.2.0, 8.0.0
>Reporter: Tobias Soloschenko
>Assignee: Tobias Soloschenko
> Fix For: 7.3.0, 8.0.0-M1
>
>
> Because of a missing option to set the type for MediaComponents and because
> of that for Video / Audio, it is not possible to play videos on iOS devices.
> If you want to enable it with the Wicket 7.2.0 you have to override the
> onComponentTag method:
> {code}
> @Override
> protected void onComponentTag(ComponentTag tag)
> {
> super.onComponentTag(tag);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (WICKET-6160) Missing type for MediaComponent causing iOS devices not to be able to play videos
Tobias Soloschenko created WICKET-6160: -- Summary: Missing type for MediaComponent causing iOS devices not to be able to play videos Key: WICKET-6160 URL: https://issues.apache.org/jira/browse/WICKET-6160 Project: Wicket Issue Type: Bug Components: wicket, wicket-examples Affects Versions: 7.2.0, 8.0.0 Reporter: Tobias Soloschenko Assignee: Tobias Soloschenko Fix For: 7.3.0, 8.0.0-M1 Because of a missing option to set the type for MediaComponents and because of that for Video / Audio, it is not possible to play videos on iOS devices. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5836) Update the version of clirr-maven-plugin (current 2.6.1)
[ https://issues.apache.org/jira/browse/WICKET-5836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268183#comment-15268183 ] Tobias Soloschenko commented on WICKET-5836: Hi Martin, short update: https://github.com/mojohaus/clirr-maven-plugin/issues/3 kind regards Tobias > Update the version of clirr-maven-plugin (current 2.6.1) > > > Key: WICKET-5836 > URL: https://issues.apache.org/jira/browse/WICKET-5836 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 6.20.0, 7.0.0-M6, 8.0.0-M1 >Reporter: Tobias Soloschenko >Priority: Minor > Fix For: 8.0.0-M1 > > > This ticket is targeting Wicket 6.x, 7.x, 8.x compiled with JDK 8, because > the current version of the clirr plugin 2.6.1 isn't compatible with Java 8. > At the moment there is no version higher then 2.6.1 so we have to wait until > release. > More information can be found here: > http://mail-archives.apache.org/mod_mbox/commons-dev/201407.mbox/%3ccaczkxpzs2nxtvk5sejfyikvhp2817ey2b+7rak0w_nuyzha...@mail.gmail.com%3E > http://mail-archives.apache.org/mod_mbox/commons-dev/201407.mbox/%3c11f48c22-60d5-4a94-8ed2-42cccfefa...@email.android.com%3E > Here the correlating tickets: > https://issues.apache.org/jira/browse/BCEL-173 > https://issues.apache.org/jira/browse/BCEL-174 > https://issues.apache.org/jira/browse/BCEL-175 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6075) Error page redirection for Autocomplete field response
[
https://issues.apache.org/jira/browse/WICKET-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268175#comment-15268175
]
Tobias Soloschenko commented on WICKET-6075:
Mh - is this function supposed to be public API? If not I would suggest to
comment it that way and implement the changes you suggested. Otherwise we
should look to solve it somehow else.
> Error page redirection for Autocomplete field response
> --
>
> Key: WICKET-6075
> URL: https://issues.apache.org/jira/browse/WICKET-6075
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 6.21.0, 7.1.0
>Reporter: Rakesh A
>Assignee: Andrea Del Bene
> Attachments: WICKET-WICKET-6075.patch, autocomplete.7z
>
>
> If ExceptionSettings#errorHandlingStrategyDuringAjaxRequests,
> is set to ExceptionSettings.AjaxErrorStrategy.REDIRECT_TO_ERROR_PAGE, and
> AutoCompleteTextField.getChoices(String) results an exception,
> 'Ajax-Location' header is ignored.
> In wicket-ajax-jquery.js, 'Ajax-Location' header is processed in
> 'Wicket.Ajax.Call.processAjaxResponse()' method. But for autocomplete field,
> 'wr' ajax attribute is set to false and below given block (success callback
> in doAjax() method) in 'wicket-ajax-jquery.js', doesn't go into
> processAjaxResponse() method.
> success: function(data, textStatus, jqXHR) {
> if (attrs.wr) {
> self.processAjaxResponse(data, textStatus, jqXHR,
> context);
> } else {
> self._executeHandlers(attrs.sh, attrs, jqXHR, data,
> textStatus);
> we.publish(topic.AJAX_CALL_SUCCESS, attrs,
> jqXHR, data, textStatus);
> }
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (WICKET-6127) Add metrics for request duration
[ https://issues.apache.org/jira/browse/WICKET-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Soloschenko resolved WICKET-6127. Resolution: Fixed > Add metrics for request duration > > > Key: WICKET-6127 > URL: https://issues.apache.org/jira/browse/WICKET-6127 > Project: Wicket > Issue Type: Improvement > Components: wicket-metrics >Affects Versions: 7.2.0, 8.0.0-M1 >Reporter: Martin Grigorov >Assignee: Tobias Soloschenko >Priority: Minor > Fix For: 7.3.0, 8.0.0-M1 > > > Add a metric aspect that collects the duration of a request. > Use the request url, without the query string, as a metric name. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (WICKET-6128) Add metrics for currently active sessions
[ https://issues.apache.org/jira/browse/WICKET-6128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Soloschenko resolved WICKET-6128. Resolution: Fixed > Add metrics for currently active sessions > - > > Key: WICKET-6128 > URL: https://issues.apache.org/jira/browse/WICKET-6128 > Project: Wicket > Issue Type: Improvement > Components: wicket-metrics >Affects Versions: 7.2.0, 8.0.0-M1 >Reporter: Martin Grigorov >Assignee: Tobias Soloschenko >Priority: Minor > Fix For: 7.3.0, 8.0.0-M1 > > > Add metric for the number of currently active Wicket sessions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6127) Add metrics for request duration
[ https://issues.apache.org/jira/browse/WICKET-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15210914#comment-15210914 ] Tobias Soloschenko commented on WICKET-6127: fixed: https://github.com/apache/wicket/pull/166 > Add metrics for request duration > > > Key: WICKET-6127 > URL: https://issues.apache.org/jira/browse/WICKET-6127 > Project: Wicket > Issue Type: Improvement > Components: wicket-metrics >Affects Versions: 7.2.0, 8.0.0-M1 >Reporter: Martin Grigorov >Assignee: Tobias Soloschenko >Priority: Minor > Fix For: 7.3.0, 8.0.0-M1 > > > Add a metric aspect that collects the duration of a request. > Use the request url, without the query string, as a metric name. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6128) Add metrics for currently active sessions
[ https://issues.apache.org/jira/browse/WICKET-6128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15210913#comment-15210913 ] Tobias Soloschenko commented on WICKET-6128: fixed: https://github.com/apache/wicket/pull/166 > Add metrics for currently active sessions > - > > Key: WICKET-6128 > URL: https://issues.apache.org/jira/browse/WICKET-6128 > Project: Wicket > Issue Type: Improvement > Components: wicket-metrics >Affects Versions: 7.2.0, 8.0.0-M1 >Reporter: Martin Grigorov >Assignee: Tobias Soloschenko >Priority: Minor > Fix For: 7.3.0, 8.0.0-M1 > > > Add metric for the number of currently active Wicket sessions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6127) Add metrics for request duration
[ https://issues.apache.org/jira/browse/WICKET-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15208927#comment-15208927 ] Tobias Soloschenko commented on WICKET-6127: See PR: https://github.com/apache/wicket/pull/166 This should work - any suggestions? P.S.: I had to change the url and replace / and . with _ and : with space because otherwise Graphite displays it as category and because it is also causing issues in JMX. > Add metrics for request duration > > > Key: WICKET-6127 > URL: https://issues.apache.org/jira/browse/WICKET-6127 > Project: Wicket > Issue Type: Improvement > Components: wicket-metrics >Affects Versions: 7.2.0, 8.0.0-M1 >Reporter: Martin Grigorov >Assignee: Tobias Soloschenko >Priority: Minor > Fix For: 7.3.0, 8.0.0-M1 > > > Add a metric aspect that collects the duration of a request. > Use the request url, without the query string, as a metric name. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6128) Add metrics for currently active sessions
[ https://issues.apache.org/jira/browse/WICKET-6128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15208923#comment-15208923 ] Tobias Soloschenko commented on WICKET-6128: See PR: https://github.com/apache/wicket/pull/166 This should work - any suggestions? > Add metrics for currently active sessions > - > > Key: WICKET-6128 > URL: https://issues.apache.org/jira/browse/WICKET-6128 > Project: Wicket > Issue Type: Improvement > Components: wicket-metrics >Affects Versions: 7.2.0, 8.0.0-M1 >Reporter: Martin Grigorov >Assignee: Tobias Soloschenko >Priority: Minor > Fix For: 7.3.0, 8.0.0-M1 > > > Add metric for the number of currently active Wicket sessions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6127) Add metrics for request duration
[ https://issues.apache.org/jira/browse/WICKET-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Soloschenko updated WICKET-6127: --- Affects Version/s: (was: 7.3.0) 8.0.0-M1 7.2.0 > Add metrics for request duration > > > Key: WICKET-6127 > URL: https://issues.apache.org/jira/browse/WICKET-6127 > Project: Wicket > Issue Type: Improvement > Components: wicket-metrics >Affects Versions: 7.2.0, 8.0.0-M1 >Reporter: Martin Grigorov >Assignee: Tobias Soloschenko >Priority: Minor > Fix For: 7.3.0, 8.0.0-M1 > > > Add a metric aspect that collects the duration of a request. > Use the request url, without the query string, as a metric name. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6128) Add metrics for currently active sessions
[ https://issues.apache.org/jira/browse/WICKET-6128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Soloschenko updated WICKET-6128: --- Affects Version/s: (was: 7.3.0) 8.0.0-M1 7.2.0 > Add metrics for currently active sessions > - > > Key: WICKET-6128 > URL: https://issues.apache.org/jira/browse/WICKET-6128 > Project: Wicket > Issue Type: Improvement > Components: wicket-metrics >Affects Versions: 7.2.0, 8.0.0-M1 >Reporter: Martin Grigorov >Assignee: Tobias Soloschenko >Priority: Minor > Fix For: 7.3.0, 8.0.0-M1 > > > Add metric for the number of currently active Wicket sessions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6128) Add metrics for currently active sessions
[ https://issues.apache.org/jira/browse/WICKET-6128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Soloschenko updated WICKET-6128: --- Fix Version/s: 8.0.0-M1 7.3.0 > Add metrics for currently active sessions > - > > Key: WICKET-6128 > URL: https://issues.apache.org/jira/browse/WICKET-6128 > Project: Wicket > Issue Type: Improvement > Components: wicket-metrics >Affects Versions: 7.2.0, 8.0.0-M1 >Reporter: Martin Grigorov >Assignee: Tobias Soloschenko >Priority: Minor > Fix For: 7.3.0, 8.0.0-M1 > > > Add metric for the number of currently active Wicket sessions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6127) Add metrics for request duration
[ https://issues.apache.org/jira/browse/WICKET-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Soloschenko updated WICKET-6127: --- Fix Version/s: 8.0.0-M1 7.3.0 > Add metrics for request duration > > > Key: WICKET-6127 > URL: https://issues.apache.org/jira/browse/WICKET-6127 > Project: Wicket > Issue Type: Improvement > Components: wicket-metrics >Affects Versions: 7.2.0, 8.0.0-M1 >Reporter: Martin Grigorov >Assignee: Tobias Soloschenko >Priority: Minor > Fix For: 7.3.0, 8.0.0-M1 > > > Add a metric aspect that collects the duration of a request. > Use the request url, without the query string, as a metric name. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6128) Add metrics for currently active sessions
[
https://issues.apache.org/jira/browse/WICKET-6128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15208017#comment-15208017
]
Tobias Soloschenko commented on WICKET-6128:
Hi,
yesterday I tried out the following setup:
Session counter:
{code}
private static final AtomicLong count = new AtomicLong(0);
{code}
Session is created and measured with:
{code}
@Around("execution(* org.apache.wicket.session.ISessionStore.bind(..))")
public Object aroundBind(ProceedingJoinPoint joinPoint) throws Throwable
{
return histogram("core/session/count", joinPoint,
count.getAndIncrement());
}
{code}
Session expired and measured with:
{code}
@Around("execution(* org.apache.wicket.Session.onInvalidate())")
public Object aroundInvalidate(ProceedingJoinPoint joinPoint) throws
Throwable
{
return histogram("core/session/count", joinPoint,
count.getAndDecrement());
}
{code}
The issue where was that the increment is working, but the decrement always
results in an exception, because the Application cant be resolved with
Application.get().
{code}
org.apache.wicket.WicketRuntimeException: There is no application attached to
current thread ContainerBackgroundProcessor[StandardEngine[Catalina]]
at org.apache.wicket.Application.get(Application.java:236)
at
org.apache.wicket.metrics.WicketMetrics.getSettings(WicketMetrics.java:189)
at
org.apache.wicket.metrics.WicketMetrics.histogram(WicketMetrics.java:96)
at
org.apache.wicket.metrics.aspects.session.ISessionStoreAspect.aroundInvalidate(ISessionStoreAspect.java:49)
at org.apache.wicket.Session.onInvalidate(Session.java:918)
at
org.apache.wicket.session.HttpSessionStore$SessionBindingListener.valueUnbound(HttpSessionStore.java:458)
at
org.apache.catalina.session.StandardSession.removeAttributeInternal(StandardSession.java:1838)
at
org.apache.catalina.session.StandardSession.expire(StandardSession.java:891)
at
org.apache.catalina.session.StandardSession.isValid(StandardSession.java:694)
at
org.apache.catalina.session.ManagerBase.processExpires(ManagerBase.java:666)
at
org.apache.catalina.session.ManagerBase.backgroundProcess(ManagerBase.java:651)
at
org.apache.catalina.core.StandardContext.backgroundProcess(StandardContext.java:5625)
at
org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.processChildren(ContainerBase.java:1377)
at
org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.processChildren(ContainerBase.java:1381)
at
org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.processChildren(ContainerBase.java:1381)
at
org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.run(ContainerBase.java:1349)
at java.lang.Thread.run(Thread.java:745)
{code}
I think there is a limit by using meta data and application, but if I use
static variables you said that OSGi would make trouble - I don't know where to
store the registry / settings then. Any ideas?
> Add metrics for currently active sessions
> -
>
> Key: WICKET-6128
> URL: https://issues.apache.org/jira/browse/WICKET-6128
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-metrics
>Affects Versions: 7.3.0
>Reporter: Martin Grigorov
>Assignee: Tobias Soloschenko
>Priority: Minor
>
> Add metric for the number of currently active Wicket sessions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (WICKET-6128) Add metrics for currently active sessions
[
https://issues.apache.org/jira/browse/WICKET-6128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15208017#comment-15208017
]
Tobias Soloschenko edited comment on WICKET-6128 at 3/23/16 7:40 AM:
-
Hi,
yesterday I tried out the following setup:
Session counter:
{code}
private static final AtomicLong count = new AtomicLong(0);
{code}
Session is created and measured with:
{code}
@Around("execution(* org.apache.wicket.session.ISessionStore.bind(..))")
public Object aroundBind(ProceedingJoinPoint joinPoint) throws Throwable
{
return histogram("core/session/count", joinPoint,
count.getAndIncrement());
}
{code}
Session expired and measured with:
{code}
@Around("execution(* org.apache.wicket.Session.onInvalidate())")
public Object aroundInvalidate(ProceedingJoinPoint joinPoint) throws
Throwable
{
return histogram("core/session/count", joinPoint,
count.getAndDecrement());
}
{code}
The issue here was that the increment is working, but the decrement always
results in an exception, because the Application cant be resolved with
Application.get().
{code}
org.apache.wicket.WicketRuntimeException: There is no application attached to
current thread ContainerBackgroundProcessor[StandardEngine[Catalina]]
at org.apache.wicket.Application.get(Application.java:236)
at
org.apache.wicket.metrics.WicketMetrics.getSettings(WicketMetrics.java:189)
at
org.apache.wicket.metrics.WicketMetrics.histogram(WicketMetrics.java:96)
at
org.apache.wicket.metrics.aspects.session.ISessionStoreAspect.aroundInvalidate(ISessionStoreAspect.java:49)
at org.apache.wicket.Session.onInvalidate(Session.java:918)
at
org.apache.wicket.session.HttpSessionStore$SessionBindingListener.valueUnbound(HttpSessionStore.java:458)
at
org.apache.catalina.session.StandardSession.removeAttributeInternal(StandardSession.java:1838)
at
org.apache.catalina.session.StandardSession.expire(StandardSession.java:891)
at
org.apache.catalina.session.StandardSession.isValid(StandardSession.java:694)
at
org.apache.catalina.session.ManagerBase.processExpires(ManagerBase.java:666)
at
org.apache.catalina.session.ManagerBase.backgroundProcess(ManagerBase.java:651)
at
org.apache.catalina.core.StandardContext.backgroundProcess(StandardContext.java:5625)
at
org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.processChildren(ContainerBase.java:1377)
at
org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.processChildren(ContainerBase.java:1381)
at
org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.processChildren(ContainerBase.java:1381)
at
org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.run(ContainerBase.java:1349)
at java.lang.Thread.run(Thread.java:745)
{code}
I think there is a limit by using meta data and application, but if I use
static variables you said that OSGi would make trouble - I don't know where to
store the registry / settings then. Any ideas?
was (Author: klopfdreh):
Hi,
yesterday I tried out the following setup:
Session counter:
{code}
private static final AtomicLong count = new AtomicLong(0);
{code}
Session is created and measured with:
{code}
@Around("execution(* org.apache.wicket.session.ISessionStore.bind(..))")
public Object aroundBind(ProceedingJoinPoint joinPoint) throws Throwable
{
return histogram("core/session/count", joinPoint,
count.getAndIncrement());
}
{code}
Session expired and measured with:
{code}
@Around("execution(* org.apache.wicket.Session.onInvalidate())")
public Object aroundInvalidate(ProceedingJoinPoint joinPoint) throws
Throwable
{
return histogram("core/session/count", joinPoint,
count.getAndDecrement());
}
{code}
The issue where was that the increment is working, but the decrement always
results in an exception, because the Application cant be resolved with
Application.get().
{code}
org.apache.wicket.WicketRuntimeException: There is no application attached to
current thread ContainerBackgroundProcessor[StandardEngine[Catalina]]
at org.apache.wicket.Application.get(Application.java:236)
at
org.apache.wicket.metrics.WicketMetrics.getSettings(WicketMetrics.java:189)
at
org.apache.wicket.metrics.WicketMetrics.histogram(WicketMetrics.java:96)
at
org.apache.wicket.metrics.aspects.session.ISessionStoreAspect.aroundInvalidate(ISessionStoreAspect.java:49)
at org.apache.wicket.Session.onInvalidate(Session.java:918)
at
org.apache.wicket.session.HttpSessionStore$SessionBindingListener.valueUnbound(HttpSessionStore.java:458)
at
org.apache.catalina.ses
[jira] [Commented] (WICKET-6128) Add metrics for currently active sessions
[ https://issues.apache.org/jira/browse/WICKET-6128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15206787#comment-15206787 ] Tobias Soloschenko commented on WICKET-6128: I am going to have a look, soon. > Add metrics for currently active sessions > - > > Key: WICKET-6128 > URL: https://issues.apache.org/jira/browse/WICKET-6128 > Project: Wicket > Issue Type: Improvement > Components: wicket-metrics >Affects Versions: 7.3.0 >Reporter: Martin Grigorov >Assignee: Tobias Soloschenko >Priority: Minor > > Add metric for the number of currently active Wicket sessions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6128) Add metrics for currently active sessions
[ https://issues.apache.org/jira/browse/WICKET-6128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15206305#comment-15206305 ] Tobias Soloschenko commented on WICKET-6128: Hey Martin, I have a question to that: It is a bit hard to create an interval and check the sessions which are alive - I would suggest to wrap an aspect around Application.get().getRequestLogger() and invoke getLiveSessions() in the aspect and count the array each time a request is performed. So the measurement how many sessions are alive would be updated on each request. Would this be ok? Or do you see another way? > Add metrics for currently active sessions > - > > Key: WICKET-6128 > URL: https://issues.apache.org/jira/browse/WICKET-6128 > Project: Wicket > Issue Type: Improvement > Components: wicket-metrics >Affects Versions: 7.3.0 >Reporter: Martin Grigorov >Assignee: Tobias Soloschenko >Priority: Minor > > Add metric for the number of currently active Wicket sessions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6120) Wicket Metrics
[ https://issues.apache.org/jira/browse/WICKET-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15205932#comment-15205932 ] Tobias Soloschenko commented on WICKET-6120: Done. > Wicket Metrics > -- > > Key: WICKET-6120 > URL: https://issues.apache.org/jira/browse/WICKET-6120 > Project: Wicket > Issue Type: New Feature > Components: wicket >Affects Versions: 7.2.0, 8.0.0-M1 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko > Labels: features > Fix For: 7.3.0, 8.0.0-M1 > > > As mentioned in confluence, it would be nice Wicket to collect data about the > lifecycle of components and other useful metric data: > https://cwiki.apache.org/confluence/display/WICKET/Ideas+for+Wicket+8.0 > Mailing list: > http://apache-wicket.1842946.n4.nabble.com/wicket-metrics-statistics-for-wicket-td4673887.html > Pull request: > https://github.com/apache/wicket/pull/164?_pjax=%23js-repo-pjax-container -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (WICKET-6120) Wicket Metrics
[ https://issues.apache.org/jira/browse/WICKET-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Soloschenko resolved WICKET-6120. Resolution: Fixed > Wicket Metrics > -- > > Key: WICKET-6120 > URL: https://issues.apache.org/jira/browse/WICKET-6120 > Project: Wicket > Issue Type: New Feature > Components: wicket >Affects Versions: 7.2.0, 8.0.0-M1 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko > Labels: features > Fix For: 7.3.0, 8.0.0-M1 > > > As mentioned in confluence, it would be nice Wicket to collect data about the > lifecycle of components and other useful metric data: > https://cwiki.apache.org/confluence/display/WICKET/Ideas+for+Wicket+8.0 > Mailing list: > http://apache-wicket.1842946.n4.nabble.com/wicket-metrics-statistics-for-wicket-td4673887.html > Pull request: > https://github.com/apache/wicket/pull/164?_pjax=%23js-repo-pjax-container -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6120) Wicket Metrics
[ https://issues.apache.org/jira/browse/WICKET-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Soloschenko updated WICKET-6120: --- Affects Version/s: 7.3.0 > Wicket Metrics > -- > > Key: WICKET-6120 > URL: https://issues.apache.org/jira/browse/WICKET-6120 > Project: Wicket > Issue Type: New Feature > Components: wicket >Affects Versions: 7.2.0, 8.0.0-M1 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko > Labels: features > Fix For: 7.3.0, 8.0.0-M1 > > > As mentioned in confluence, it would be nice Wicket to collect data about the > lifecycle of components and other useful metric data: > https://cwiki.apache.org/confluence/display/WICKET/Ideas+for+Wicket+8.0 > Mailing list: > http://apache-wicket.1842946.n4.nabble.com/wicket-metrics-statistics-for-wicket-td4673887.html > Pull request: > https://github.com/apache/wicket/pull/164?_pjax=%23js-repo-pjax-container -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6120) Wicket Metrics
[ https://issues.apache.org/jira/browse/WICKET-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Soloschenko updated WICKET-6120: --- Fix Version/s: 7.3.0 > Wicket Metrics > -- > > Key: WICKET-6120 > URL: https://issues.apache.org/jira/browse/WICKET-6120 > Project: Wicket > Issue Type: New Feature > Components: wicket >Affects Versions: 7.2.0, 8.0.0-M1 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko > Labels: features > Fix For: 7.3.0, 8.0.0-M1 > > > As mentioned in confluence, it would be nice Wicket to collect data about the > lifecycle of components and other useful metric data: > https://cwiki.apache.org/confluence/display/WICKET/Ideas+for+Wicket+8.0 > Mailing list: > http://apache-wicket.1842946.n4.nabble.com/wicket-metrics-statistics-for-wicket-td4673887.html > Pull request: > https://github.com/apache/wicket/pull/164?_pjax=%23js-repo-pjax-container -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6120) Wicket Metrics
[ https://issues.apache.org/jira/browse/WICKET-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Soloschenko updated WICKET-6120: --- Affects Version/s: (was: 7.3.0) 7.2.0 > Wicket Metrics > -- > > Key: WICKET-6120 > URL: https://issues.apache.org/jira/browse/WICKET-6120 > Project: Wicket > Issue Type: New Feature > Components: wicket >Affects Versions: 7.2.0, 8.0.0-M1 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko > Labels: features > Fix For: 7.3.0, 8.0.0-M1 > > > As mentioned in confluence, it would be nice Wicket to collect data about the > lifecycle of components and other useful metric data: > https://cwiki.apache.org/confluence/display/WICKET/Ideas+for+Wicket+8.0 > Mailing list: > http://apache-wicket.1842946.n4.nabble.com/wicket-metrics-statistics-for-wicket-td4673887.html > Pull request: > https://github.com/apache/wicket/pull/164?_pjax=%23js-repo-pjax-container -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6120) Wicket Metrics
[ https://issues.apache.org/jira/browse/WICKET-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15203803#comment-15203803 ] Tobias Soloschenko commented on WICKET-6120: There are only a few changes left if the NOTICE / EPL license files should be included. As of legal-discuss@ it is not required to be. The project itself is already integrated into the master branch. It is also considered to backport it to wicket 7 > Wicket Metrics > -- > > Key: WICKET-6120 > URL: https://issues.apache.org/jira/browse/WICKET-6120 > Project: Wicket > Issue Type: New Feature > Components: wicket >Affects Versions: 8.0.0-M1 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko > Labels: features > Fix For: 8.0.0-M1 > > > As mentioned in confluence, it would be nice Wicket to collect data about the > lifecycle of components and other useful metric data: > https://cwiki.apache.org/confluence/display/WICKET/Ideas+for+Wicket+8.0 > Mailing list: > http://apache-wicket.1842946.n4.nabble.com/wicket-metrics-statistics-for-wicket-td4673887.html > Pull request: > https://github.com/apache/wicket/pull/164?_pjax=%23js-repo-pjax-container -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (WICKET-6120) Wicket Metrics
Tobias Soloschenko created WICKET-6120: -- Summary: Wicket Metrics Key: WICKET-6120 URL: https://issues.apache.org/jira/browse/WICKET-6120 Project: Wicket Issue Type: New Feature Components: wicket Affects Versions: 8.0.0-M1 Reporter: Tobias Soloschenko Assignee: Tobias Soloschenko Fix For: 8.0.0-M1 As mentioned in confluence, it would be nice Wicket to collect data about the lifecycle of components and other useful metric data: https://cwiki.apache.org/confluence/display/WICKET/Ideas+for+Wicket+8.0 Mailing list: http://apache-wicket.1842946.n4.nabble.com/wicket-metrics-statistics-for-wicket-td4673887.html Pull request: https://github.com/apache/wicket/pull/164?_pjax=%23js-repo-pjax-container -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6112) Microservices support (decoupled component usage)
[
https://issues.apache.org/jira/browse/WICKET-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185057#comment-15185057
]
Tobias Soloschenko commented on WICKET-6112:
Reference to dev mailing list:
http://apache-wicket.1842946.n4.nabble.com/servlet-3-1-web-fragments-and-microservices-td4673844.html
> Microservices support (decoupled component usage)
> -
>
> Key: WICKET-6112
> URL: https://issues.apache.org/jira/browse/WICKET-6112
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
>Affects Versions: 8.0.0-M1
>Reporter: Tobias Soloschenko
>Assignee: Tobias Soloschenko
> Labels: features
> Fix For: 8.0.0-M1
>
> Attachments: 0001-Microservices.patch, wicket.microservices.parent.zip
>
>
> It would be very nice to be able to instantiate components in a decoupled
> way, so that jars might be dropped into the web apps lib folder and if they
> are present, the web app show new functionality.
> Examples would look like this:
> {code}
> String microservicePage =
> "wicket.microservices.service1.MicroservicePage1";
> add(new Link("link")
> {
> private static final long serialVersionUID = 1L;
> @Override
> public void onClick()
> {
> setResponsePage(microservicePage);
> }
>
> @Override
> protected void onConfigure()
> {
>
> setVisible(Component.isAvailable(microservicePage));
> }
> });
> {code}
> or like this
> {code}
> String microservicePanel =
> "wicket.microservices.service2.MicroservicePanel2";
> if(Component.isAvailable(microservicePanel)){
> add(Component.newInstance(microservicePanel,"Yay this
> is a label"));
> }else{
> add(new EmptyPanel("panel"));
> }
> {code}
> The main benefit of this feature is that you are able to have jars that
> provide additional functionality but not required to be shipped with an
> initial deployment.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (WICKET-6112) Microservices support (decoupled component usage)
[
https://issues.apache.org/jira/browse/WICKET-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tobias Soloschenko closed WICKET-6112.
--
Resolution: Won't Fix
Due to committer votes not going to be implemented. Use CDI or registration to
achieve this functionality (spring, cdi)
> Microservices support (decoupled component usage)
> -
>
> Key: WICKET-6112
> URL: https://issues.apache.org/jira/browse/WICKET-6112
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
>Affects Versions: 8.0.0-M1
>Reporter: Tobias Soloschenko
>Assignee: Tobias Soloschenko
> Labels: features
> Fix For: 8.0.0-M1
>
> Attachments: 0001-Microservices.patch, wicket.microservices.parent.zip
>
>
> It would be very nice to be able to instantiate components in a decoupled
> way, so that jars might be dropped into the web apps lib folder and if they
> are present, the web app show new functionality.
> Examples would look like this:
> {code}
> String microservicePage =
> "wicket.microservices.service1.MicroservicePage1";
> add(new Link("link")
> {
> private static final long serialVersionUID = 1L;
> @Override
> public void onClick()
> {
> setResponsePage(microservicePage);
> }
>
> @Override
> protected void onConfigure()
> {
>
> setVisible(Component.isAvailable(microservicePage));
> }
> });
> {code}
> or like this
> {code}
> String microservicePanel =
> "wicket.microservices.service2.MicroservicePanel2";
> if(Component.isAvailable(microservicePanel)){
> add(Component.newInstance(microservicePanel,"Yay this
> is a label"));
> }else{
> add(new EmptyPanel("panel"));
> }
> {code}
> The main benefit of this feature is that you are able to have jars that
> provide additional functionality but not required to be shipped with an
> initial deployment.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (WICKET-6112) Microservices support (decoupled component usage)
[
https://issues.apache.org/jira/browse/WICKET-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tobias Soloschenko updated WICKET-6112:
---
Component/s: wicket
> Microservices support (decoupled component usage)
> -
>
> Key: WICKET-6112
> URL: https://issues.apache.org/jira/browse/WICKET-6112
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
>Affects Versions: 8.0.0-M1
>Reporter: Tobias Soloschenko
>Assignee: Tobias Soloschenko
> Labels: features
> Fix For: 8.0.0-M1
>
> Attachments: 0001-Microservices.patch, wicket.microservices.parent.zip
>
>
> It would be very nice to be able to instantiate components in a decoupled
> way, so that jars might be dropped into the web apps lib folder and if they
> are present, the web app show new functionality.
> Examples would look like this:
> {code}
> String microservicePage =
> "wicket.microservices.service1.MicroservicePage1";
> add(new Link("link")
> {
> private static final long serialVersionUID = 1L;
> @Override
> public void onClick()
> {
> setResponsePage(microservicePage);
> }
>
> @Override
> protected void onConfigure()
> {
>
> setVisible(Component.isAvailable(microservicePage));
> }
> });
> {code}
> or like this
> {code}
> String microservicePanel =
> "wicket.microservices.service2.MicroservicePanel2";
> if(Component.isAvailable(microservicePanel)){
> add(Component.newInstance(microservicePanel,"Yay this
> is a label"));
> }else{
> add(new EmptyPanel("panel"));
> }
> {code}
> The main benefit of this feature is that you are able to have jars that
> provide additional functionality but not required to be shipped with an
> initial deployment.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (WICKET-6112) Microservices support (decoupled component usage)
[
https://issues.apache.org/jira/browse/WICKET-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tobias Soloschenko updated WICKET-6112:
---
Labels: features (was: )
> Microservices support (decoupled component usage)
> -
>
> Key: WICKET-6112
> URL: https://issues.apache.org/jira/browse/WICKET-6112
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
>Affects Versions: 8.0.0-M1
>Reporter: Tobias Soloschenko
>Assignee: Tobias Soloschenko
> Labels: features
> Fix For: 8.0.0-M1
>
> Attachments: 0001-Microservices.patch, wicket.microservices.parent.zip
>
>
> It would be very nice to be able to instantiate components in a decoupled
> way, so that jars might be dropped into the web apps lib folder and if they
> are present, the web app show new functionality.
> Examples would look like this:
> {code}
> String microservicePage =
> "wicket.microservices.service1.MicroservicePage1";
> add(new Link("link")
> {
> private static final long serialVersionUID = 1L;
> @Override
> public void onClick()
> {
> setResponsePage(microservicePage);
> }
>
> @Override
> protected void onConfigure()
> {
>
> setVisible(Component.isAvailable(microservicePage));
> }
> });
> {code}
> or like this
> {code}
> String microservicePanel =
> "wicket.microservices.service2.MicroservicePanel2";
> if(Component.isAvailable(microservicePanel)){
> add(Component.newInstance(microservicePanel,"Yay this
> is a label"));
> }else{
> add(new EmptyPanel("panel"));
> }
> {code}
> The main benefit of this feature is that you are able to have jars that
> provide additional functionality but not required to be shipped with an
> initial deployment.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (WICKET-6112) Microservices support (decoupled component usage)
[
https://issues.apache.org/jira/browse/WICKET-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tobias Soloschenko updated WICKET-6112:
---
Description:
It would be very nice to be able to instantiate components in a decoupled way,
so that jars might be dropped into the web apps lib folder and if they are
present, the web app show new functionality.
Examples would look like this:
{code}
String microservicePage =
"wicket.microservices.service1.MicroservicePage1";
add(new Link("link")
{
private static final long serialVersionUID = 1L;
@Override
public void onClick()
{
setResponsePage(microservicePage);
}
@Override
protected void onConfigure()
{
setVisible(Component.isAvailable(microservicePage));
}
});
{code}
or like this
{code}
String microservicePanel =
"wicket.microservices.service2.MicroservicePanel2";
if(Component.isAvailable(microservicePanel)){
add(Component.newInstance(microservicePanel,"Yay this
is a label"));
}else{
add(new EmptyPanel("panel"));
}
{code}
The main benefit of this feature is that you are able to have jars that provide
additional functionality but not required to be shipped with an initial
deployment.
was:
It would be very nice to be able to instantiate components in a decoupled way,
so that jars might be dropped into the web apps lib folder and if they are
present, the web app show new functionality.
Examples would look like this:
{code}
String microservicePage =
"wicket.microservices.service1.MicroservicePage1";
add(new Link("link")
{
private static final long serialVersionUID = 1L;
@Override
public void onClick()
{
setResponsePage(microservicePage);
}
@Override
protected void onConfigure()
{
setVisible(Component.isAvailable(microservicePage));
}
});
{code}
or like this
{code}
String microservicePanel =
"wicket.microservices.service2.MicroservicePanel2";
if(Component.isAvailable(microservicePanel)){
add(Component.newInstance(microservicePanel,"Yay this
is a label"));
}else{
add(new EmptyPanel("panel"));
}
{code}
> Microservices support (decoupled component usage)
> -
>
> Key: WICKET-6112
> URL: https://issues.apache.org/jira/browse/WICKET-6112
> Project: Wicket
> Issue Type: New Feature
>Affects Versions: 8.0.0-M1
>Reporter: Tobias Soloschenko
>Assignee: Tobias Soloschenko
> Fix For: 8.0.0-M1
>
> Attachments: 0001-Microservices.patch, wicket.microservices.parent.zip
>
>
> It would be very nice to be able to instantiate components in a decoupled
> way, so that jars might be dropped into the web apps lib folder and if they
> are present, the web app show new functionality.
> Examples would look like this:
> {code}
> String microservicePage =
> "wicket.microservices.service1.MicroservicePage1";
> add(new Link("link")
> {
> private static final long serialVersionUID = 1L;
> @Override
> public void onClick()
> {
> setResponsePage(microservicePage);
> }
>
> @Override
> protected void onConfigure()
> {
>
> setVisible(Component.isAvailable(microservicePage));
> }
> });
> {code}
> or like this
> {code}
> String microservicePanel =
> "wicket.microservices.service2.MicroservicePanel2";
> if(Component.isAvailable(microservicePanel)){
> add(Component.newInstance(microservicePanel,"Yay this
> is a label"));
> }else{
> add(new EmptyPanel("panel"));
> }
> {code}
> The main benefit of this feature is that you are able to have jars that
> provide additional functionality
[jira] [Updated] (WICKET-6112) Microservices support (decoupled component usage)
[
https://issues.apache.org/jira/browse/WICKET-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tobias Soloschenko updated WICKET-6112:
---
Attachment: wicket.microservices.parent.zip
> Microservices support (decoupled component usage)
> -
>
> Key: WICKET-6112
> URL: https://issues.apache.org/jira/browse/WICKET-6112
> Project: Wicket
> Issue Type: New Feature
>Affects Versions: 8.0.0-M1
>Reporter: Tobias Soloschenko
>Assignee: Tobias Soloschenko
> Fix For: 8.0.0-M1
>
> Attachments: 0001-Microservices.patch, wicket.microservices.parent.zip
>
>
> It would be very nice to be able to instantiate components in a decoupled
> way, so that jars might be dropped into the web apps lib folder and if they
> are present, the web app show new functionality.
> Examples would look like this:
> {code}
> String microservicePage =
> "wicket.microservices.service1.MicroservicePage1";
> add(new Link("link")
> {
> private static final long serialVersionUID = 1L;
> @Override
> public void onClick()
> {
> setResponsePage(microservicePage);
> }
>
> @Override
> protected void onConfigure()
> {
>
> setVisible(Component.isAvailable(microservicePage));
> }
> });
> {code}
> or like this
> {code}
> String microservicePanel =
> "wicket.microservices.service2.MicroservicePanel2";
> if(Component.isAvailable(microservicePanel)){
> add(Component.newInstance(microservicePanel,"Yay this
> is a label"));
> }else{
> add(new EmptyPanel("panel"));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (WICKET-6112) Microservices support (decoupled component usage)
[
https://issues.apache.org/jira/browse/WICKET-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tobias Soloschenko updated WICKET-6112:
---
Description:
It would be very nice to be able to instantiate components in a decoupled way,
so that jars might be dropped into the web apps lib folder and if they are
present, the web app show new functionality.
Examples would look like this:
{code}
String microservicePage =
"wicket.microservices.service1.MicroservicePage1";
add(new Link("link")
{
private static final long serialVersionUID = 1L;
@Override
public void onClick()
{
setResponsePage(microservicePage);
}
@Override
protected void onConfigure()
{
setVisible(Component.isAvailable(microservicePage));
}
});
{code}
or like this
{code}
String microservicePanel =
"wicket.microservices.service2.MicroservicePanel2";
if(Component.isAvailable(microservicePanel)){
add(Component.newInstance(microservicePanel,"Yay this
is a label"));
}else{
add(new EmptyPanel("panel"));
}
{code}
was:It would be very nice to be able to instantiate components in a decoupled
way, so that jars might be dropped into the web apps lib folder and if they are
present, the web app show new functionality.
> Microservices support (decoupled component usage)
> -
>
> Key: WICKET-6112
> URL: https://issues.apache.org/jira/browse/WICKET-6112
> Project: Wicket
> Issue Type: New Feature
>Affects Versions: 8.0.0-M1
>Reporter: Tobias Soloschenko
>Assignee: Tobias Soloschenko
> Fix For: 8.0.0-M1
>
> Attachments: 0001-Microservices.patch
>
>
> It would be very nice to be able to instantiate components in a decoupled
> way, so that jars might be dropped into the web apps lib folder and if they
> are present, the web app show new functionality.
> Examples would look like this:
> {code}
> String microservicePage =
> "wicket.microservices.service1.MicroservicePage1";
> add(new Link("link")
> {
> private static final long serialVersionUID = 1L;
> @Override
> public void onClick()
> {
> setResponsePage(microservicePage);
> }
>
> @Override
> protected void onConfigure()
> {
>
> setVisible(Component.isAvailable(microservicePage));
> }
> });
> {code}
> or like this
> {code}
> String microservicePanel =
> "wicket.microservices.service2.MicroservicePanel2";
> if(Component.isAvailable(microservicePanel)){
> add(Component.newInstance(microservicePanel,"Yay this
> is a label"));
> }else{
> add(new EmptyPanel("panel"));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (WICKET-6112) Microservices support (decoupled component usage)
[ https://issues.apache.org/jira/browse/WICKET-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Soloschenko updated WICKET-6112: --- Attachment: 0001-Microservices.patch > Microservices support (decoupled component usage) > - > > Key: WICKET-6112 > URL: https://issues.apache.org/jira/browse/WICKET-6112 > Project: Wicket > Issue Type: New Feature >Affects Versions: 8.0.0-M1 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko > Fix For: 8.0.0-M1 > > Attachments: 0001-Microservices.patch > > > It would be very nice to be able to instantiate components in a decoupled > way, so that jars might be dropped into the web apps lib folder and if they > are present, the web app show new functionality. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (WICKET-6112) Microservices support (decoupled component usage)
Tobias Soloschenko created WICKET-6112: -- Summary: Microservices support (decoupled component usage) Key: WICKET-6112 URL: https://issues.apache.org/jira/browse/WICKET-6112 Project: Wicket Issue Type: New Feature Affects Versions: 8.0.0-M1 Reporter: Tobias Soloschenko Assignee: Tobias Soloschenko Fix For: 8.0.0-M1 It would be very nice to be able to instantiate components in a decoupled way, so that jars might be dropped into the web apps lib folder and if they are present, the web app show new functionality. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5847) Support for nested properties keys in translations
[
https://issues.apache.org/jira/browse/WICKET-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138793#comment-15138793
]
Tobias Soloschenko commented on WICKET-5847:
{quote}
For built-in support we would have to agree on a placeholder syntax (e.g. {{}},
${} or #{}), while watching for many pitfalls (overlap with property values
and/or MessageFormat placeholders, increased API complexity etc.).
{quote}
Sadly this is something the users of Wicket have to do in future if no out of
the box solution is provided. Don't get me wrong, but I think a framework
should provide this if it is that simple (one class).
> Support for nested properties keys in translations
> --
>
> Key: WICKET-5847
> URL: https://issues.apache.org/jira/browse/WICKET-5847
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
>Affects Versions: 7.0.0-M5
>Reporter: Rob Sonke
>Assignee: Sven Meier
>Priority: Minor
> Attachments: i18nresolver.zip, keyreplacelocalizer.patch,
> screenshot-1.png
>
>
> I wrote an extended version of the Localizer class to support properties like:
> {code}
> lbl.test=This is a string including this ${lbl.other} test
> lbl.other=nested property
> {code}
> Based on this discussion:
> http://apache-wicket.1842946.n4.nabble.com/Resolving-nested-properties-td4669681.html
> It would be nice if this can be added to Wicket core to support this. Then
> developers can easily choose to use this one or not. By default the existing
> Localizer is used.
> I've attached a patch file based on today's master branch which includes the
> new class and some junit tests. Apart from that I attached a zipped
> quickstart that shows the use. Please be aware that I added the new class as
> a copy in that project on the same package as in the real Wicket jar.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-5847) Support for nested properties keys in translations
[
https://issues.apache.org/jira/browse/WICKET-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138681#comment-15138681
]
Tobias Soloschenko commented on WICKET-5847:
To make it short: It works.
I just wanted to help out with this ticket to get it closed - I don't want that
anyone is going to "waste" time for anything. I also resume to other work, now.
> Support for nested properties keys in translations
> --
>
> Key: WICKET-5847
> URL: https://issues.apache.org/jira/browse/WICKET-5847
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
>Affects Versions: 7.0.0-M5
>Reporter: Rob Sonke
>Priority: Minor
> Attachments: i18nresolver.zip, keyreplacelocalizer.patch,
> screenshot-1.png
>
>
> I wrote an extended version of the Localizer class to support properties like:
> {code}
> lbl.test=This is a string including this ${lbl.other} test
> lbl.other=nested property
> {code}
> Based on this discussion:
> http://apache-wicket.1842946.n4.nabble.com/Resolving-nested-properties-td4669681.html
> It would be nice if this can be added to Wicket core to support this. Then
> developers can easily choose to use this one or not. By default the existing
> Localizer is used.
> I've attached a patch file based on today's master branch which includes the
> new class and some junit tests. Apart from that I attached a zipped
> quickstart that shows the use. Please be aware that I added the new class as
> a copy in that project on the same package as in the real Wicket jar.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (WICKET-5847) Support for nested properties keys in translations
[
https://issues.apache.org/jira/browse/WICKET-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138564#comment-15138564
]
Tobias Soloschenko edited comment on WICKET-5847 at 2/9/16 9:02 AM:
Just for my understanding - what would you just do to provide it to the actual
normal property key resolvement? So lets say you have a StringResourceModel or
getString() of a component. How do you hook in the IStringResourceLoader to
also replace nested keys in there? Maybe I missed something during the process
chain in which the IStringResourceLoader is involved and in which the new class
would replace nested keys if you add it to:
{code}
getResourceSettings().getStringResourceLoaders().add(...);
{code}
Btw.: The class has a lot of duplicated code. ;-)
was (Author: klopfdreh):
Just for my understanding - what would you just do to provide it to the actual
normal property key resolvement? So lets say you have a StringResourceModel or
getString() of a component. How do you hook in the IStringResourceLoader to
also replace nested keys in there? Maybe I missed something during the process
chain in which the IStringResourceLoader is involved and in which the new class
would replace nested keys if you add it to:
{code}
getResourceSettings().getStringResourceLoaders().add(...);
{code}
> Support for nested properties keys in translations
> --
>
> Key: WICKET-5847
> URL: https://issues.apache.org/jira/browse/WICKET-5847
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
>Affects Versions: 7.0.0-M5
>Reporter: Rob Sonke
>Priority: Minor
> Attachments: i18nresolver.zip, keyreplacelocalizer.patch,
> screenshot-1.png
>
>
> I wrote an extended version of the Localizer class to support properties like:
> {code}
> lbl.test=This is a string including this ${lbl.other} test
> lbl.other=nested property
> {code}
> Based on this discussion:
> http://apache-wicket.1842946.n4.nabble.com/Resolving-nested-properties-td4669681.html
> It would be nice if this can be added to Wicket core to support this. Then
> developers can easily choose to use this one or not. By default the existing
> Localizer is used.
> I've attached a patch file based on today's master branch which includes the
> new class and some junit tests. Apart from that I attached a zipped
> quickstart that shows the use. Please be aware that I added the new class as
> a copy in that project on the same package as in the real Wicket jar.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-5847) Support for nested properties keys in translations
[
https://issues.apache.org/jira/browse/WICKET-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138564#comment-15138564
]
Tobias Soloschenko commented on WICKET-5847:
Just for my understanding - what would you just do to provide it to the actual
normal property key resolvement? So lets say you have a StringResourceModel or
getString() of a component. How do you hook in the IStringResourceLoader to
also replace nested keys in there? Maybe I missed something during the process
chain in which the IStringResourceLoader is involved and in which the new class
would replace nested keys if you add it to:
{code}
getResourceSettings().getStringResourceLoaders().add(...);
{code}
> Support for nested properties keys in translations
> --
>
> Key: WICKET-5847
> URL: https://issues.apache.org/jira/browse/WICKET-5847
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
>Affects Versions: 7.0.0-M5
>Reporter: Rob Sonke
>Priority: Minor
> Attachments: i18nresolver.zip, keyreplacelocalizer.patch,
> screenshot-1.png
>
>
> I wrote an extended version of the Localizer class to support properties like:
> {code}
> lbl.test=This is a string including this ${lbl.other} test
> lbl.other=nested property
> {code}
> Based on this discussion:
> http://apache-wicket.1842946.n4.nabble.com/Resolving-nested-properties-td4669681.html
> It would be nice if this can be added to Wicket core to support this. Then
> developers can easily choose to use this one or not. By default the existing
> Localizer is used.
> I've attached a patch file based on today's master branch which includes the
> new class and some junit tests. Apart from that I attached a zipped
> quickstart that shows the use. Please be aware that I added the new class as
> a copy in that project on the same package as in the real Wicket jar.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-5847) Support for nested properties keys in translations
[
https://issues.apache.org/jira/browse/WICKET-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138332#comment-15138332
]
Tobias Soloschenko commented on WICKET-5847:
Another question would be: Should we change the whole method signatures of
every class, because the LocalizationSupport requires the Localizer to be
passed into the method signatures to grant access. Also the previous translated
String is required.
> Support for nested properties keys in translations
> --
>
> Key: WICKET-5847
> URL: https://issues.apache.org/jira/browse/WICKET-5847
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
>Affects Versions: 7.0.0-M5
>Reporter: Rob Sonke
>Priority: Minor
> Attachments: i18nresolver.zip, keyreplacelocalizer.patch,
> screenshot-1.png
>
>
> I wrote an extended version of the Localizer class to support properties like:
> {code}
> lbl.test=This is a string including this ${lbl.other} test
> lbl.other=nested property
> {code}
> Based on this discussion:
> http://apache-wicket.1842946.n4.nabble.com/Resolving-nested-properties-td4669681.html
> It would be nice if this can be added to Wicket core to support this. Then
> developers can easily choose to use this one or not. By default the existing
> Localizer is used.
> I've attached a patch file based on today's master branch which includes the
> new class and some junit tests. Apart from that I attached a zipped
> quickstart that shows the use. Please be aware that I added the new class as
> a copy in that project on the same package as in the real Wicket jar.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-5847) Support for nested properties keys in translations
[
https://issues.apache.org/jira/browse/WICKET-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137604#comment-15137604
]
Tobias Soloschenko commented on WICKET-5847:
Then I don't see how it is connected to the localizer, because all classes are
calling methods of the localizer itself instead of an interface / a chained
interface.
Again what is meant by "loading of resource strings" - is this related to the
localization?
> Support for nested properties keys in translations
> --
>
> Key: WICKET-5847
> URL: https://issues.apache.org/jira/browse/WICKET-5847
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
>Affects Versions: 7.0.0-M5
>Reporter: Rob Sonke
>Priority: Minor
> Attachments: i18nresolver.zip, keyreplacelocalizer.patch,
> screenshot-1.png
>
>
> I wrote an extended version of the Localizer class to support properties like:
> {code}
> lbl.test=This is a string including this ${lbl.other} test
> lbl.other=nested property
> {code}
> Based on this discussion:
> http://apache-wicket.1842946.n4.nabble.com/Resolving-nested-properties-td4669681.html
> It would be nice if this can be added to Wicket core to support this. Then
> developers can easily choose to use this one or not. By default the existing
> Localizer is used.
> I've attached a patch file based on today's master branch which includes the
> new class and some junit tests. Apart from that I attached a zipped
> quickstart that shows the use. Please be aware that I added the new class as
> a copy in that project on the same package as in the real Wicket jar.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-5847) Support for nested properties keys in translations
[
https://issues.apache.org/jira/browse/WICKET-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137434#comment-15137434
]
Tobias Soloschenko commented on WICKET-5847:
The class is used to load Resources via String, but not for localization, isn't
it?!
If so I would not mix the scopes the classes achieve.
> Support for nested properties keys in translations
> --
>
> Key: WICKET-5847
> URL: https://issues.apache.org/jira/browse/WICKET-5847
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
>Affects Versions: 7.0.0-M5
>Reporter: Rob Sonke
>Priority: Minor
> Attachments: i18nresolver.zip, keyreplacelocalizer.patch,
> screenshot-1.png
>
>
> I wrote an extended version of the Localizer class to support properties like:
> {code}
> lbl.test=This is a string including this ${lbl.other} test
> lbl.other=nested property
> {code}
> Based on this discussion:
> http://apache-wicket.1842946.n4.nabble.com/Resolving-nested-properties-td4669681.html
> It would be nice if this can be added to Wicket core to support this. Then
> developers can easily choose to use this one or not. By default the existing
> Localizer is used.
> I've attached a patch file based on today's master branch which includes the
> new class and some junit tests. Apart from that I attached a zipped
> quickstart that shows the use. Please be aware that I added the new class as
> a copy in that project on the same package as in the real Wicket jar.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-5847) Support for nested properties keys in translations
[
https://issues.apache.org/jira/browse/WICKET-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15136725#comment-15136725
]
Tobias Soloschenko commented on WICKET-5847:
[~svenmeier]: You said that you dislike subclassing here. What do you think
about that solution:
1. Add a list of LocalizingSupport to the Localizer (Maybe initialized with a
"DefaultLocalizingSupport")
2. The Localizer iterates over the list of LocalizingSupport within the
innermost getString(...) method
3. A getString(...) method of each DefaultLocalizingSupport is called and the
previous resolved String is passed into the next LocalizingSupport
This way you would be able to plug in new localizing functionality your own
without overriding the Localizer itself.
E.G.
Application.get().getResourceSettings().getLocalizer().addLocalizingSupport(new
MyLocalizingSupport());
> Support for nested properties keys in translations
> --
>
> Key: WICKET-5847
> URL: https://issues.apache.org/jira/browse/WICKET-5847
> Project: Wicket
> Issue Type: New Feature
> Components: wicket
>Affects Versions: 7.0.0-M5
>Reporter: Rob Sonke
>Priority: Minor
> Attachments: i18nresolver.zip, keyreplacelocalizer.patch,
> screenshot-1.png
>
>
> I wrote an extended version of the Localizer class to support properties like:
> {code}
> lbl.test=This is a string including this ${lbl.other} test
> lbl.other=nested property
> {code}
> Based on this discussion:
> http://apache-wicket.1842946.n4.nabble.com/Resolving-nested-properties-td4669681.html
> It would be nice if this can be added to Wicket core to support this. Then
> developers can easily choose to use this one or not. By default the existing
> Localizer is used.
> I've attached a patch file based on today's master branch which includes the
> new class and some junit tests. Apart from that I attached a zipped
> quickstart that shows the use. Please be aware that I added the new class as
> a copy in that project on the same package as in the real Wicket jar.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (WICKET-6042) Implementation of ExternalImage component
[ https://issues.apache.org/jira/browse/WICKET-6042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Soloschenko updated WICKET-6042: --- Issue Type: New Feature (was: Improvement) > Implementation of ExternalImage component > - > > Key: WICKET-6042 > URL: https://issues.apache.org/jira/browse/WICKET-6042 > Project: Wicket > Issue Type: New Feature > Components: wicket >Affects Versions: 7.1.0, 8.0.0-M1 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko > Labels: features > Fix For: 7.2.0, 8.0.0-M1 > > > Like in the MediaComponent - Video for example > (https://ci.apache.org/projects/wicket/apidocs/7.x/org/apache/wicket/markup/html/media/video/Video.html) > the Image should be able to be configured with a String placed into the src > attribute. > Possible constructor to be used for that: > Image(String id, IModel model, String... srcs) > As of comments the requirement changed a bit and a new implementation > "ExternalImage" is the target of this ticket: > http://apache-wicket.1842946.n4.nabble.com/Image-based-on-external-url-model-object-tt4672692.html#none > *Integrated* > Wicket 8.x: > https://github.com/apache/wicket/commit/ee572d0ee597a357f10735cb2141b01ec19d19a4 > https://github.com/apache/wicket/commit/b174c21c42220d9ccb4a01579ee9b0723a121513 > https://github.com/apache/wicket/commit/4eacb2aba5f580fbbb851293834253ec7a8b3ce9 > https://github.com/apache/wicket/commit/a1b19493da671dce33f258de8021713fdc45234a > https://github.com/apache/wicket/commit/93fe70d08cf255d6673243ae02e36c01c360eaf7 > https://github.com/apache/wicket/commit/1ac89ee1c8c305097e34c3733c41bb217d627e57 > https://github.com/apache/wicket/commit/78802c9c8a13a71000d5b6225daab80c9e6f8d46 > Wicket 7.x: > https://github.com/apache/wicket/commit/2e82b8913f3cbf8d2631f8afbaba46dda8b122b0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (WICKET-6058) Error in calculation of byte ranges
[ https://issues.apache.org/jira/browse/WICKET-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Soloschenko resolved WICKET-6058. Resolution: Fixed > Error in calculation of byte ranges > --- > > Key: WICKET-6058 > URL: https://issues.apache.org/jira/browse/WICKET-6058 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0, 8.0.0-M1 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko > Fix For: 7.3.0, 8.0.0-M1 > > > curl --range 0-99 > http://examples7x.wicket.apache.org/videos/wicket/resource/org.apache.wicket.examples.media.Home/video1-ver-538557E5F248D450160FC81033930591.mp4 > -o /dev/null > returns 99 bytes and not 100 as expected in this document: > https://developer.apple.com/library/safari/documentation/AppleApplications/Reference/SafariWebContent/CreatingVideoforSafarioniPhone/CreatingVideoforSafarioniPhone.html#//apple_ref/doc/uid/TP40006514-SW6 > But this: > curl --range 0-99 http://media.w3.org/2010/05/video/movie_300.mp4 -o /dev/null > returns 100 bytes. > So there is an issue in the byte range calculation. > Fix PRs: > Wicket 7.x: https://github.com/apache/wicket/pull/150 > Wicket 8.x: https://github.com/apache/wicket/pull/149 > Fixes: > Wicket 7.x: > https://github.com/apache/wicket/commit/b5ee0cbf5a1234524a57983c6bfacb2fdf8aeb97 > Wicket 8.x: > https://github.com/apache/wicket/commit/a169eb1125d93867c64377a8dc4066491ef510c7 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6058) Error in calculation of byte ranges
[ https://issues.apache.org/jira/browse/WICKET-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Soloschenko updated WICKET-6058: --- Description: curl --range 0-99 http://examples7x.wicket.apache.org/videos/wicket/resource/org.apache.wicket.examples.media.Home/video1-ver-538557E5F248D450160FC81033930591.mp4 -o /dev/null returns 99 bytes and not 100 as expected in this document: https://developer.apple.com/library/safari/documentation/AppleApplications/Reference/SafariWebContent/CreatingVideoforSafarioniPhone/CreatingVideoforSafarioniPhone.html#//apple_ref/doc/uid/TP40006514-SW6 But this: curl --range 0-99 http://media.w3.org/2010/05/video/movie_300.mp4 -o /dev/null returns 100 bytes. So there is an issue in the byte range calculation. Fix PRs: Wicket 7.x: https://github.com/apache/wicket/pull/150 Wicket 8.x: https://github.com/apache/wicket/pull/149 Fixes: Wicket 7.x: https://github.com/apache/wicket/commit/b5ee0cbf5a1234524a57983c6bfacb2fdf8aeb97 Wicket 8.x: https://github.com/apache/wicket/commit/a169eb1125d93867c64377a8dc4066491ef510c7 was: curl --range 0-99 http://examples7x.wicket.apache.org/videos/wicket/resource/org.apache.wicket.examples.media.Home/video1-ver-538557E5F248D450160FC81033930591.mp4 -o /dev/null returns 99 bytes and not 100 as expected in this document: https://developer.apple.com/library/safari/documentation/AppleApplications/Reference/SafariWebContent/CreatingVideoforSafarioniPhone/CreatingVideoforSafarioniPhone.html#//apple_ref/doc/uid/TP40006514-SW6 But this: curl --range 0-99 http://media.w3.org/2010/05/video/movie_300.mp4 -o /dev/null returns 100 bytes. So there is an issue in the byte range calculation. Fix PRs: Wicket 7.x: https://github.com/apache/wicket/pull/150 Wicket 8.x: https://github.com/apache/wicket/pull/149 > Error in calculation of byte ranges > --- > > Key: WICKET-6058 > URL: https://issues.apache.org/jira/browse/WICKET-6058 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0, 8.0.0-M1 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko > Fix For: 7.3.0, 8.0.0-M1 > > > curl --range 0-99 > http://examples7x.wicket.apache.org/videos/wicket/resource/org.apache.wicket.examples.media.Home/video1-ver-538557E5F248D450160FC81033930591.mp4 > -o /dev/null > returns 99 bytes and not 100 as expected in this document: > https://developer.apple.com/library/safari/documentation/AppleApplications/Reference/SafariWebContent/CreatingVideoforSafarioniPhone/CreatingVideoforSafarioniPhone.html#//apple_ref/doc/uid/TP40006514-SW6 > But this: > curl --range 0-99 http://media.w3.org/2010/05/video/movie_300.mp4 -o /dev/null > returns 100 bytes. > So there is an issue in the byte range calculation. > Fix PRs: > Wicket 7.x: https://github.com/apache/wicket/pull/150 > Wicket 8.x: https://github.com/apache/wicket/pull/149 > Fixes: > Wicket 7.x: > https://github.com/apache/wicket/commit/b5ee0cbf5a1234524a57983c6bfacb2fdf8aeb97 > Wicket 8.x: > https://github.com/apache/wicket/commit/a169eb1125d93867c64377a8dc4066491ef510c7 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (WICKET-6058) Error in calculation of byte ranges
[ https://issues.apache.org/jira/browse/WICKET-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Soloschenko updated WICKET-6058: --- Description: curl --range 0-99 http://examples7x.wicket.apache.org/videos/wicket/resource/org.apache.wicket.examples.media.Home/video1-ver-538557E5F248D450160FC81033930591.mp4 -o /dev/null returns 99 bytes and not 100 as expected in this document: https://developer.apple.com/library/safari/documentation/AppleApplications/Reference/SafariWebContent/CreatingVideoforSafarioniPhone/CreatingVideoforSafarioniPhone.html#//apple_ref/doc/uid/TP40006514-SW6 But this: curl --range 0-99 http://media.w3.org/2010/05/video/movie_300.mp4 -o /dev/null returns 100 bytes. So there is an issue in the byte range calculation. Fix PRs: Wicket 7.x: https://github.com/apache/wicket/pull/150 Wicket 8.x: https://github.com/apache/wicket/pull/149 was: Issue: curl --range 0-99 http://examples7x.wicket.apache.org/videos/wicket/resource/org.apache.wicket.examples.media.Home/video1-ver-538557E5F248D450160FC81033930591.mp4 -o /dev/null returns 99 bytes and not 100 as expected in this document: https://developer.apple.com/library/safari/documentation/AppleApplications/Reference/SafariWebContent/CreatingVideoforSafarioniPhone/CreatingVideoforSafarioniPhone.html#//apple_ref/doc/uid/TP40006514-SW6 But this: curl --range 0-99 http://media.w3.org/2010/05/video/movie_300.mp4 -o /dev/null returns 100 bytes. So there is an issue in the byte range calculation. Fix PRs: Wicket 7.x: https://github.com/apache/wicket/pull/150 Wicket 8.x: https://github.com/apache/wicket/pull/149 > Error in calculation of byte ranges > --- > > Key: WICKET-6058 > URL: https://issues.apache.org/jira/browse/WICKET-6058 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0, 8.0.0-M1 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko > Fix For: 7.3.0, 8.0.0-M1 > > > curl --range 0-99 > http://examples7x.wicket.apache.org/videos/wicket/resource/org.apache.wicket.examples.media.Home/video1-ver-538557E5F248D450160FC81033930591.mp4 > -o /dev/null > returns 99 bytes and not 100 as expected in this document: > https://developer.apple.com/library/safari/documentation/AppleApplications/Reference/SafariWebContent/CreatingVideoforSafarioniPhone/CreatingVideoforSafarioniPhone.html#//apple_ref/doc/uid/TP40006514-SW6 > But this: > curl --range 0-99 http://media.w3.org/2010/05/video/movie_300.mp4 -o /dev/null > returns 100 bytes. > So there is an issue in the byte range calculation. > Fix PRs: > Wicket 7.x: https://github.com/apache/wicket/pull/150 > Wicket 8.x: https://github.com/apache/wicket/pull/149 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6058) Error in calculation of byte ranges
[ https://issues.apache.org/jira/browse/WICKET-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15071878#comment-15071878 ] Tobias Soloschenko commented on WICKET-6058: Changes will be committed tomorrow in the morning. > Error in calculation of byte ranges > --- > > Key: WICKET-6058 > URL: https://issues.apache.org/jira/browse/WICKET-6058 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.1.0, 8.0.0-M1 >Reporter: Tobias Soloschenko >Assignee: Tobias Soloschenko > Fix For: 7.3.0, 8.0.0-M1 > > > curl --range 0-99 > http://examples7x.wicket.apache.org/videos/wicket/resource/org.apache.wicket.examples.media.Home/video1-ver-538557E5F248D450160FC81033930591.mp4 > -o /dev/null > returns 99 bytes and not 100 as expected in this document: > https://developer.apple.com/library/safari/documentation/AppleApplications/Reference/SafariWebContent/CreatingVideoforSafarioniPhone/CreatingVideoforSafarioniPhone.html#//apple_ref/doc/uid/TP40006514-SW6 > But this: > curl --range 0-99 http://media.w3.org/2010/05/video/movie_300.mp4 -o /dev/null > returns 100 bytes. > So there is an issue in the byte range calculation. > Fix PRs: > Wicket 7.x: https://github.com/apache/wicket/pull/150 > Wicket 8.x: https://github.com/apache/wicket/pull/149 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
