generics commented on by Jeremy Thomerson (May 22, 2008).

Comment:

I agree with Doug, and with suggestion 1 above on setResponsePage changing from setResponsePage(final Class<? extends Page<?>> cls to setResponsePage(final Class<?> cls

Another example would be:
Change public RestartResponseAtInterceptPageException(final Class< ? extends Page< ? >> interceptPageClass)
to: public RestartResponseAtInterceptPageException(final Class<?> interceptPageClass)

This, for the same reason as above - it's not very likely that someone is going to pass a non-page-child class into these methods or constructors, so the benefit is minimal, but the strictly generified versions penalize you if your page class is not also generified, which would be confusing to new users.

Reply via email to