[jira] [Comment Edited] (WICKET-5819) Support for HTML 5 media tags (audio / video)
[ https://issues.apache.org/jira/browse/WICKET-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555936#comment-14555936 ] Tobias Soloschenko edited comment on WICKET-5819 at 5/22/15 10:15 AM: -- So improve the code that not the whole file is read in case of big data? Maybe we can use a fluent API and tell the PackageResourceReference (or other References in future cases) not to read the whole content. new PackageResourceReference(...).readPartial(true) What do you think? was (Author: klopfdreh): So improve the code that not the whole file is read in case of big data? Maybe we can use a fluent API and tell the PackageResourceReference not to read the whole content. new PackageResourceReference(...).readPartial(true) What do you think? > Support for HTML 5 media tags (audio / video) > - > > Key: WICKET-5819 > URL: https://issues.apache.org/jira/browse/WICKET-5819 > Project: Wicket > Issue Type: New Feature > Components: wicket >Affects Versions: 7.0.0-M6 >Reporter: Tobias Soloschenko >Assignee: Martin Grigorov > Labels: features > Fix For: 7.0.0-M6 > > Attachments: wicket-examples-media-tags.png > > > It would be great to embed video and audio files with the html5 tags: > http://www.w3schools.com/html/html5_video.asp > http://www.w3schools.com/html/html5_audio.asp > http://dev.w3.org/html5/spec-author-view/video.html > A documentation / implementation is provided here: > https://github.com/klopfdreh/wicket-components-playground -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (WICKET-5819) Support for HTML 5 media tags (audio / video)
[ https://issues.apache.org/jira/browse/WICKET-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322590#comment-14322590 ] Tobias Soloschenko edited comment on WICKET-5819 at 2/16/15 10:00 AM: -- Ok - there are some examples, now. I added additional checks if the resource can not be found and reimplemented the PageParameters constructors. I used the following code to convert the PageParameters into a query string - hope this is ok: Url encoded = new PageParametersEncoder().encodePageParameters(pageParameters); String queryString = encoded.getQueryString(); "The line is returning 'null' for a valid video located in the package with the correct scope - any idea what it could be?" - This issue was only a fault of my IDE which does not copied the video.mp4 into the target/classes folder. One little hint I also mentioned in the Examples Page: Videos are from: http://media.w3.org/2010/05/video/ Images are from: http://search.creativecommons.org/ with check on commercial use and modify... Edit: Ah and I updated the header of the web.xml - it is the one of servlet 3.0, now. :-) was (Author: klopfdreh): Ok - there are some examples, now. I added additional checks if the resource can not be found and reimplemented the PageParameters constructors. I used the following code to convert the PageParameters into a query string - hope this is ok: Url encoded = new PageParametersEncoder().encodePageParameters(pageParameters); String queryString = encoded.getQueryString(); "The line is returning 'null' for a valid video located in the package with the correct scope - any idea what it could be?" - This issue was only a fault of my IDE which does not copied the video.mp4 into the target/classes folder. One little hint I also mentioned in the Examples Page: Videos are from: http://media.w3.org/2010/05/video/ Images are from: http://search.creativecommons.org/ with check on commercial use and modify... > Support for HTML 5 media tags (audio / video) > - > > Key: WICKET-5819 > URL: https://issues.apache.org/jira/browse/WICKET-5819 > Project: Wicket > Issue Type: New Feature > Components: wicket >Affects Versions: 7.0.0-M5 >Reporter: Tobias Soloschenko >Assignee: Martin Grigorov > Labels: features > > It would be great to embed video and audio files with the html5 tags: > http://www.w3schools.com/html/html5_video.asp > http://www.w3schools.com/html/html5_audio.asp > http://dev.w3.org/html5/spec-author-view/video.html > A documentation / implementation is provided here: > https://github.com/klopfdreh/wicket-components-playground -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (WICKET-5819) Support for HTML 5 media tags (audio / video)
[ https://issues.apache.org/jira/browse/WICKET-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322523#comment-14322523 ] Tobias Soloschenko edited comment on WICKET-5819 at 2/16/15 8:37 AM: - https://github.com/apache/wicket/blob/pr-86-media_tags/wicket-core/src/main/java/org/apache/wicket/markup/html/media/MediaStreamingResourceReference.java#L75 The line is returning 'null' for a valid video located in the package with the correct scope - any idea what it could be? was (Author: klopfdreh): https://github.com/apache/wicket/blob/pr-86-media_tags/wicket-core/src/main/java/org/apache/wicket/markup/html/media/MediaStreamingResourceReference.java#L75 The line is returning 'null' for a valide video located in the package with the correct scope - any idea what it could be? > Support for HTML 5 media tags (audio / video) > - > > Key: WICKET-5819 > URL: https://issues.apache.org/jira/browse/WICKET-5819 > Project: Wicket > Issue Type: New Feature > Components: wicket >Affects Versions: 7.0.0-M5 >Reporter: Tobias Soloschenko >Assignee: Martin Grigorov > Labels: features > > It would be great to embed video and audio files with the html5 tags: > http://www.w3schools.com/html/html5_video.asp > http://www.w3schools.com/html/html5_audio.asp > http://dev.w3.org/html5/spec-author-view/video.html > A documentation / implementation is provided here: > https://github.com/klopfdreh/wicket-components-playground -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (WICKET-5819) Support for HTML 5 media tags (audio / video)
[ https://issues.apache.org/jira/browse/WICKET-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322452#comment-14322452 ] Tobias Soloschenko edited comment on WICKET-5819 at 2/16/15 7:19 AM: - https://github.com/klopfdreh/wicket/blob/3384441307eba0477e9692d1c6080b673dce9748/wicket-core/src/main/java/org/apache/wicket/markup/html/media/MediaComponent.java#L147 You can apply separate PageParameters - if you remove the constructor the MediaComponent constructor with PageParameters is not visible anymore (for Video / Audio) and you can't apply separate PageParameter. I missed to apply those PageParameters if you provide an URL: https://github.com/klopfdreh/wicket/blob/3384441307eba0477e9692d1c6080b673dce9748/wicket-core/src/main/java/org/apache/wicket/markup/html/media/MediaComponent.java#L153 Example: http://test.de/myvideo?mySeparatePageParameter=value";> was (Author: klopfdreh): https://github.com/klopfdreh/wicket/blob/3384441307eba0477e9692d1c6080b673dce9748/wicket-core/src/main/java/org/apache/wicket/markup/html/media/MediaComponent.java#L147 You can apply separate PageParameter - if you remove the constructor the MediaComponent constructor with PageParameters is not visible anymore (for Video / Audio) and you can't apply separate PageParameter. I missed to apply those PageParamter if you provide an URL: https://github.com/klopfdreh/wicket/blob/3384441307eba0477e9692d1c6080b673dce9748/wicket-core/src/main/java/org/apache/wicket/markup/html/media/MediaComponent.java#L153 Example: http://test.de/myvideo?mySeparatePageParameter=value";> > Support for HTML 5 media tags (audio / video) > - > > Key: WICKET-5819 > URL: https://issues.apache.org/jira/browse/WICKET-5819 > Project: Wicket > Issue Type: New Feature > Components: wicket >Affects Versions: 7.0.0-M5 >Reporter: Tobias Soloschenko >Assignee: Martin Grigorov > Labels: features > > It would be great to embed video and audio files with the html5 tags: > http://www.w3schools.com/html/html5_video.asp > http://www.w3schools.com/html/html5_audio.asp > http://dev.w3.org/html5/spec-author-view/video.html > A documentation / implementation is provided here: > https://github.com/klopfdreh/wicket-components-playground -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (WICKET-5819) Support for HTML 5 media tags (audio / video)
[ https://issues.apache.org/jira/browse/WICKET-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322346#comment-14322346 ] Tobias Soloschenko edited comment on WICKET-5819 at 2/16/15 5:06 AM: - Hi, it is quite more then only the ResourceReference itself. See here: https://github.com/klopfdreh/wicket/blob/4434d94f95c5c8b8b6e70e65ab630ccac42f9b6d/wicket-core/src/main/java/org/apache/wicket/markup/html/media/MediaStreamingResourceReference.java#L159 There is a PartWriterCallback which also belongs to the MediaStreamingResourceReference and is used to write data chunk wise - only in combination the implementation makes sense and thats the reason why to implement a specialized class for Accept-Range. I think if you would put all stuff into the PackageResourceReference it would get to big and the functionality is way to specialized to implement it for all Resource. (Only for Videos / Audios) But good to see that it has been requested. :-) was (Author: klopfdreh): Hi, it is quite more then only the ResourceReference itself. See here: https://github.com/klopfdreh/wicket/blob/4434d94f95c5c8b8b6e70e65ab630ccac42f9b6d/wicket-core/src/main/java/org/apache/wicket/markup/html/media/MediaStreamingResourceReference.java#L159 There is a PartWriterCallback which also belongs to the MediaStreamingResourceReference and is used to write data chunk wise - only in combination the implementation makes sense and thats the reason why to implement a specialized class for Accept-Range. I think if you would put all stuff into the PackageResourceReference it would get to big and the functionality is way to specialized to implement it for all Resource. But good to see that it has been requested. :-) > Support for HTML 5 media tags (audio / video) > - > > Key: WICKET-5819 > URL: https://issues.apache.org/jira/browse/WICKET-5819 > Project: Wicket > Issue Type: New Feature > Components: wicket >Affects Versions: 7.0.0-M5 >Reporter: Tobias Soloschenko >Assignee: Martin Grigorov > Labels: features > > It would be great to embed video and audio files with the html5 tags: > http://www.w3schools.com/html/html5_video.asp > http://www.w3schools.com/html/html5_audio.asp > http://dev.w3.org/html5/spec-author-view/video.html > A documentation / implementation is provided here: > https://github.com/klopfdreh/wicket-components-playground -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (WICKET-5819) Support for HTML 5 media tags (audio / video)
[ https://issues.apache.org/jira/browse/WICKET-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322346#comment-14322346 ] Tobias Soloschenko edited comment on WICKET-5819 at 2/16/15 4:59 AM: - Hi, it is quite more then only the ResourceReference itself. See here: https://github.com/klopfdreh/wicket/blob/4434d94f95c5c8b8b6e70e65ab630ccac42f9b6d/wicket-core/src/main/java/org/apache/wicket/markup/html/media/MediaStreamingResourceReference.java#L159 There is a PartWriterCallback which also belongs to the MediaStreamingResourceReference and is used to write data chunk wise - only in combination the implementation makes sense and thats the reason why to implement a specialized class for Accept-Range. I think if you would put all stuff into the PackageResourceReference it would get to big and the functionality is way to specialized to implement it for all Resource. But good to see that it has been requested. :-) was (Author: klopfdreh): Hi, it is quite more then only the ResourceReference itself. See here: https://github.com/klopfdreh/wicket/blob/4434d94f95c5c8b8b6e70e65ab630ccac42f9b6d/wicket-core/src/main/java/org/apache/wicket/markup/html/media/MediaStreamingResourceReference.java#L159 There is a PartWriterCallback which also belongs to the MediaStreamingResourceReference and is used to write data chunk wise - only in combination the implementation makes sense and thats the reason why to implement a specialized class for Accept-Range. I think if you would put all stuff into the PackageResourceReference it would get to big and the functionality is way to specialized to implement it for all Resource. > Support for HTML 5 media tags (audio / video) > - > > Key: WICKET-5819 > URL: https://issues.apache.org/jira/browse/WICKET-5819 > Project: Wicket > Issue Type: New Feature > Components: wicket >Affects Versions: 7.0.0-M5 >Reporter: Tobias Soloschenko >Assignee: Martin Grigorov > Labels: features > > It would be great to embed video and audio files with the html5 tags: > http://www.w3schools.com/html/html5_video.asp > http://www.w3schools.com/html/html5_audio.asp > http://dev.w3.org/html5/spec-author-view/video.html > A documentation / implementation is provided here: > https://github.com/klopfdreh/wicket-components-playground -- This message was sent by Atlassian JIRA (v6.3.4#6332)
