[jira] [Commented] (WICKET-4623) UploadProgressBar does not show up if the form submitted by AjaxButton or AjaxLink
[ https://issues.apache.org/jira/browse/WICKET-4623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050064#comment-14050064 ] János Cserép commented on WICKET-4623: -- I've spent a few days reproducing the same issue when the progress bar was not working for me with 6.16.0. Turns out UploadProgressBar is not compatible with Servlet 3.0, which I was using with Jetty8. If you change web.xml in the uploaded test.zip from servlet 2.5 to 3.0 the issue can be easily reproduced. MultipartServletWebRequestImpl only gets the stream of the uploaded file after the upload has finished in the browser, so the javascript always misses the UploadInfo and hides the progress bar. > UploadProgressBar does not show up if the form submitted by AjaxButton or > AjaxLink > -- > > Key: WICKET-4623 > URL: https://issues.apache.org/jira/browse/WICKET-4623 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 1.5.7 > Environment: Win 7 64bit, jetty, netbeans 7.1, jdk1.6.0_30 >Reporter: Sandor Feher >Assignee: Sven Meier > Labels: Ajax, UploadProgressBar, > Fix For: 1.5.9, 6.3.0 > > Attachments: WICKET-4623-with-ajax-update.patch, WICKET-4623.patch, > test.zip > > > If I submit the form normal submit button then the progressbar shows up. If I > do it with any ajax component (AjaxLink, AjaxButton ...) then it does not > show. > I set up setOutputMarkupPlaceholderTag(true) for progressbar itself and it's > parent component (the form) but it has not helped. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (WICKET-4623) UploadProgressBar does not show up if the form submitted by AjaxButton or AjaxLink
[ https://issues.apache.org/jira/browse/WICKET-4623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485082#comment-13485082 ] Sandor Feher commented on WICKET-4623: -- I thought so :(. But I tried it again. Both cases worked fine :). So I'm happy. I would more happy if you could backport this nice feature into 1.5.x branch :). > UploadProgressBar does not show up if the form submitted by AjaxButton or > AjaxLink > -- > > Key: WICKET-4623 > URL: https://issues.apache.org/jira/browse/WICKET-4623 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 1.5.7 > Environment: Win 7 64bit, jetty, netbeans 7.1, jdk1.6.0_30 >Reporter: Sandor Feher > Labels: Ajax, UploadProgressBar, > Attachments: test.zip, WICKET-4623.patch, > WICKET-4623-with-ajax-update.patch > > > If I submit the form normal submit button then the progressbar shows up. If I > do it with any ajax component (AjaxLink, AjaxButton ...) then it does not > show. > I set up setOutputMarkupPlaceholderTag(true) for progressbar itself and it's > parent component (the form) but it has not helped. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4623) UploadProgressBar does not show up if the form submitted by AjaxButton or AjaxLink
[ https://issues.apache.org/jira/browse/WICKET-4623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484762#comment-13484762 ] Sven Meier commented on WICKET-4623: You've forgot getApplicationSettings().setUploadProgressUpdatesEnabled(true); > UploadProgressBar does not show up if the form submitted by AjaxButton or > AjaxLink > -- > > Key: WICKET-4623 > URL: https://issues.apache.org/jira/browse/WICKET-4623 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 1.5.7 > Environment: Win 7 64bit, jetty, netbeans 7.1, jdk1.6.0_30 >Reporter: Sandor Feher > Labels: Ajax, UploadProgressBar, > Attachments: test.zip, WICKET-4623.patch, > WICKET-4623-with-ajax-update.patch > > > If I submit the form normal submit button then the progressbar shows up. If I > do it with any ajax component (AjaxLink, AjaxButton ...) then it does not > show. > I set up setOutputMarkupPlaceholderTag(true) for progressbar itself and it's > parent component (the form) but it has not helped. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4623) UploadProgressBar does not show up if the form submitted by AjaxButton or AjaxLink
[ https://issues.apache.org/jira/browse/WICKET-4623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484460#comment-13484460 ] Sandor Feher commented on WICKET-4623: -- Okay. I made a quickstart cut off my upload form's relevant part and tested it. (I use 1.5.x branch so I could not try it in my project). Now I'm a little bit confused. Progressbar shows up in both cases (even with AjaxLink or Button) but does not show the progress. Moreover if I try to upload a bigger file to see the progress the bar disappears after few seconds. It might be something wrong with my quickstart I don't know. Attached it. Please check. > UploadProgressBar does not show up if the form submitted by AjaxButton or > AjaxLink > -- > > Key: WICKET-4623 > URL: https://issues.apache.org/jira/browse/WICKET-4623 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 1.5.7 > Environment: Win 7 64bit, jetty, netbeans 7.1, jdk1.6.0_30 >Reporter: Sandor Feher > Labels: Ajax, UploadProgressBar, > Attachments: WICKET-4623.patch, WICKET-4623-with-ajax-update.patch > > > If I submit the form normal submit button then the progressbar shows up. If I > do it with any ajax component (AjaxLink, AjaxButton ...) then it does not > show. > I set up setOutputMarkupPlaceholderTag(true) for progressbar itself and it's > parent component (the form) but it has not helped. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4623) UploadProgressBar does not show up if the form submitted by AjaxButton or AjaxLink
[ https://issues.apache.org/jira/browse/WICKET-4623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483048#comment-13483048 ] Sandor Feher commented on WICKET-4623: -- [~svenmeier] Sure. Give me some time pls. > UploadProgressBar does not show up if the form submitted by AjaxButton or > AjaxLink > -- > > Key: WICKET-4623 > URL: https://issues.apache.org/jira/browse/WICKET-4623 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 1.5.7 > Environment: Win 7 64bit, jetty, netbeans 7.1, jdk1.6.0_30 >Reporter: Sandor Feher > Labels: Ajax, UploadProgressBar, > Attachments: WICKET-4623.patch, WICKET-4623-with-ajax-update.patch > > > If I submit the form normal submit button then the progressbar shows up. If I > do it with any ajax component (AjaxLink, AjaxButton ...) then it does not > show. > I set up setOutputMarkupPlaceholderTag(true) for progressbar itself and it's > parent component (the form) but it has not helped. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4623) UploadProgressBar does not show up if the form submitted by AjaxButton or AjaxLink
[ https://issues.apache.org/jira/browse/WICKET-4623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482306#comment-13482306 ] Sven Meier commented on WICKET-4623: I've checked in a small fix needed on master for the progressBar to hide again on Ajax upload. @Sandor Could you please check whether the problem still persists? After much tinkering with Ajax upload I don't understand how the actual upload can be delayed to arrive after the first status update, which is fired at least 1 seconds later. In my tests I was able to reproduces this only if I put a breakpoint in the upload processing, thus preventing storing of UploadInfo in the session before the status update request tried to look it up again. > UploadProgressBar does not show up if the form submitted by AjaxButton or > AjaxLink > -- > > Key: WICKET-4623 > URL: https://issues.apache.org/jira/browse/WICKET-4623 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 1.5.7 > Environment: Win 7 64bit, jetty, netbeans 7.1, jdk1.6.0_30 >Reporter: Sandor Feher > Labels: Ajax, UploadProgressBar, > Attachments: WICKET-4623.patch, WICKET-4623-with-ajax-update.patch > > > If I submit the form normal submit button then the progressbar shows up. If I > do it with any ajax component (AjaxLink, AjaxButton ...) then it does not > show. > I set up setOutputMarkupPlaceholderTag(true) for progressbar itself and it's > parent component (the form) but it has not helped. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4623) UploadProgressBar does not show up if the form submitted by AjaxButton or AjaxLink
[ https://issues.apache.org/jira/browse/WICKET-4623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477286#comment-13477286 ] Sven Meier commented on WICKET-4623: Note that MultipartServletWebRequestImpl uses #getUploadInfo() itself. So in rare cases it could mark the uploadInfo as readOnce and remove it from session already before the UploadStatusResource has accessed it. Wouldn't that make the progressbar running forever? What about making ProgressBar smarter (i.e. let it extend FormComponentPanel) so that it updates itself on ajax form submit? No need then for the UploadStatusResource to signal the end of upload. It could just return "0|" when no info avaiable, as you've changed it. > UploadProgressBar does not show up if the form submitted by AjaxButton or > AjaxLink > -- > > Key: WICKET-4623 > URL: https://issues.apache.org/jira/browse/WICKET-4623 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 1.5.7 > Environment: Win 7 64bit, jetty, netbeans 7.1, jdk1.6.0_30 >Reporter: Sandor Feher > Labels: Ajax, UploadProgressBar, > Attachments: WICKET-4623.patch > > > If I submit the form normal submit button then the progressbar shows up. If I > do it with any ajax component (AjaxLink, AjaxButton ...) then it does not > show. > I set up setOutputMarkupPlaceholderTag(true) for progressbar itself and it's > parent component (the form) but it has not helped. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4623) UploadProgressBar does not show up if the form submitted by AjaxButton or AjaxLink
[ https://issues.apache.org/jira/browse/WICKET-4623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399443#comment-13399443 ] Sven Meier commented on WICKET-4623: I've added a progressBar to example's FileUploadPage (don't forget getApplicationSettings().setUploadProgressUpdatesEnabled(true)) and can confirm the issue. Problem is that the request for the upload status (UploadStatusResource) is coming in earlier than the actual upload via ajax. Thus no UploadInfo is found in the session and the progressBar assumes the upload to have finished. A the moment I don't have an idea how to fix this. > UploadProgressBar does not show up if the form submitted by AjaxButton or > AjaxLink > -- > > Key: WICKET-4623 > URL: https://issues.apache.org/jira/browse/WICKET-4623 > Project: Wicket > Issue Type: Bug > Components: wicket-extensions >Affects Versions: 1.5.7 > Environment: Win 7 64bit, jetty, netbeans 7.1, jdk1.6.0_30 >Reporter: Sandor Feher > Labels: Ajax, UploadProgressBar, > > If I submit the form normal submit button then the progressbar shows up. If I > do it with any ajax component (AjaxLink, AjaxButton ...) then it does not > show. > I set up setOutputMarkupPlaceholderTag(true) for progressbar itself and it's > parent component (the form) but it has not helped. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira