[jira] [Commented] (WICKET-4861) Making MultiFileUploadField use HTML5 multiple attr remove confusing fakepath
[ https://issues.apache.org/jira/browse/WICKET-4861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13899015#comment-13899015 ] ASF GitHub Bot commented on WICKET-4861: Github user costescuandrei closed the pull request at: https://github.com/apache/wicket/pull/20 Making MultiFileUploadField use HTML5 multiple attr remove confusing fakepath --- Key: WICKET-4861 URL: https://issues.apache.org/jira/browse/WICKET-4861 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 6.2.0 Reporter: Andrei Costescu Assignee: Martin Grigorov Priority: Minor Fix For: 6.6.0 Attachments: fix-WICKET-4861.patch, test1.zip WICKET-3370 prepared the terrain (all major browsers except IE already support it). I will make a Git pull request for getting this into the master branch. Here is what the changes do (commit comment): Added the possibility to select multiple files in the OS dialog for browsers that support HTML5 'multiple' attribute. For browsers that do not support it, or if you do not set the boolean to true, it will behave the same as before. New: - easier select multiple files from multiple folders - shows the multiple files after choosing them - one per line Fixes: - the delete buttons are aligned instead of positioning after the variable length file names - useless and confusing C:\fakepath in filenames reported by some browsers (in multiple with single select mode) are now hidden. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (WICKET-4861) Making MultiFileUploadField use HTML5 multiple attr remove confusing fakepath
[ https://issues.apache.org/jira/browse/WICKET-4861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13497872#comment-13497872 ] Martin Grigorov commented on WICKET-4861: - Please attach the changes here as a patch. This way you officially give permissions to Apache to use your code. Thanks! Making MultiFileUploadField use HTML5 multiple attr remove confusing fakepath --- Key: WICKET-4861 URL: https://issues.apache.org/jira/browse/WICKET-4861 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 6.2.0 Reporter: Andrei Costescu Priority: Minor Attachments: test1.zip WICKET-3370 prepared the terrain (all major browsers except IE already support it). I will make a Git pull request for getting this into the master branch. Here is what the changes do (commit comment): Added the possibility to select multiple files in the OS dialog for browsers that support HTML5 'multiple' attribute. For browsers that do not support it, or if you do not set the boolean to true, it will behave the same as before. New: - easier select multiple files from multiple folders - shows the multiple files after choosing them - one per line Fixes: - the delete buttons are aligned instead of positioning after the variable length file names - useless and confusing C:\fakepath in filenames reported by some browsers (in multiple with single select mode) are now hidden. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4861) Making MultiFileUploadField use HTML5 multiple attr remove confusing fakepath
[ https://issues.apache.org/jira/browse/WICKET-4861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13497911#comment-13497911 ] Andrei Costescu commented on WICKET-4861: - Is a pull request enough or does it have to be patch? https://github.com/apache/wicket/pull/20 Making MultiFileUploadField use HTML5 multiple attr remove confusing fakepath --- Key: WICKET-4861 URL: https://issues.apache.org/jira/browse/WICKET-4861 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 6.2.0 Reporter: Andrei Costescu Priority: Minor Attachments: test1.zip WICKET-3370 prepared the terrain (all major browsers except IE already support it). I will make a Git pull request for getting this into the master branch. Here is what the changes do (commit comment): Added the possibility to select multiple files in the OS dialog for browsers that support HTML5 'multiple' attribute. For browsers that do not support it, or if you do not set the boolean to true, it will behave the same as before. New: - easier select multiple files from multiple folders - shows the multiple files after choosing them - one per line Fixes: - the delete buttons are aligned instead of positioning after the variable length file names - useless and confusing C:\fakepath in filenames reported by some browsers (in multiple with single select mode) are now hidden. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4861) Making MultiFileUploadField use HTML5 multiple attr remove confusing fakepath
[ https://issues.apache.org/jira/browse/WICKET-4861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13497913#comment-13497913 ] Andrei Costescu commented on WICKET-4861: - I guess it has to be a patch, cause github is not apache... Making MultiFileUploadField use HTML5 multiple attr remove confusing fakepath --- Key: WICKET-4861 URL: https://issues.apache.org/jira/browse/WICKET-4861 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 6.2.0 Reporter: Andrei Costescu Priority: Minor Attachments: test1.zip WICKET-3370 prepared the terrain (all major browsers except IE already support it). I will make a Git pull request for getting this into the master branch. Here is what the changes do (commit comment): Added the possibility to select multiple files in the OS dialog for browsers that support HTML5 'multiple' attribute. For browsers that do not support it, or if you do not set the boolean to true, it will behave the same as before. New: - easier select multiple files from multiple folders - shows the multiple files after choosing them - one per line Fixes: - the delete buttons are aligned instead of positioning after the variable length file names - useless and confusing C:\fakepath in filenames reported by some browsers (in multiple with single select mode) are now hidden. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4861) Making MultiFileUploadField use HTML5 multiple attr remove confusing fakepath
[ https://issues.apache.org/jira/browse/WICKET-4861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13497915#comment-13497915 ] Martin Grigorov commented on WICKET-4861: - Right. GitHub is just a mirror of Apache's Git/SVN servers. Making MultiFileUploadField use HTML5 multiple attr remove confusing fakepath --- Key: WICKET-4861 URL: https://issues.apache.org/jira/browse/WICKET-4861 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 6.2.0 Reporter: Andrei Costescu Priority: Minor Attachments: test1.zip WICKET-3370 prepared the terrain (all major browsers except IE already support it). I will make a Git pull request for getting this into the master branch. Here is what the changes do (commit comment): Added the possibility to select multiple files in the OS dialog for browsers that support HTML5 'multiple' attribute. For browsers that do not support it, or if you do not set the boolean to true, it will behave the same as before. New: - easier select multiple files from multiple folders - shows the multiple files after choosing them - one per line Fixes: - the delete buttons are aligned instead of positioning after the variable length file names - useless and confusing C:\fakepath in filenames reported by some browsers (in multiple with single select mode) are now hidden. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
