[jira] [Commented] (WICKET-5517) IE11 returns false for Wicket.Browser.isIE()
[ https://issues.apache.org/jira/browse/WICKET-5517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13932954#comment-13932954 ] ASF GitHub Bot commented on WICKET-5517: Github user asfgit closed the pull request at: https://github.com/apache/wicket/pull/70 IE11 returns false for Wicket.Browser.isIE() Key: WICKET-5517 URL: https://issues.apache.org/jira/browse/WICKET-5517 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.14.0 Environment: Internet Explorer 11, tested on Windows 7 and 8. Reporter: Luke Niesink Assignee: Emond Papegaaij Priority: Minor Fix For: 7.0.0, 6.15.0 As of Internet Explorer 11 this statement returns false instead of true (like it did prior to version 11): typeof(document.all) !== undefined This statement is used on line 56 of wicket-event-jquery.js which means Wicket.Browser.isIE() will return false in IE11. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (WICKET-5517) IE11 returns false for Wicket.Browser.isIE()
[ https://issues.apache.org/jira/browse/WICKET-5517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911494#comment-13911494 ] Martin Grigorov commented on WICKET-5517: - Thank you! We are aware of this but we prefer to not fix it until there is a real issue with this check somewhere. IE11 is more close to W3C standards and most of the checks in Wicket code for .isIE() don't apply for 11. IE11 returns false for Wicket.Browser.isIE() Key: WICKET-5517 URL: https://issues.apache.org/jira/browse/WICKET-5517 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.14.0 Environment: Internet Explorer 11, tested on Windows 7 and 8. Reporter: Luke Niesink Priority: Minor As of Internet Explorer 11 this statement returns false instead of true (like it did prior to version 11): typeof(document.all) !== undefined This statement is used on line 56 of wicket-event-jquery.js which means Wicket.Browser.isIE() will return false in IE11. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (WICKET-5517) IE11 returns false for Wicket.Browser.isIE()
[ https://issues.apache.org/jira/browse/WICKET-5517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911512#comment-13911512 ] Martin Grigorov commented on WICKET-5517: - [~papegaaij] I hope you will find time to fix any problems caused by this change in the later versions of Wicket ! I see no reason why to fix something when there is no real problem with it. I'd rather deprecate these methods. IE11 returns false for Wicket.Browser.isIE() Key: WICKET-5517 URL: https://issues.apache.org/jira/browse/WICKET-5517 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.14.0 Environment: Internet Explorer 11, tested on Windows 7 and 8. Reporter: Luke Niesink Assignee: Emond Papegaaij Priority: Minor As of Internet Explorer 11 this statement returns false instead of true (like it did prior to version 11): typeof(document.all) !== undefined This statement is used on line 56 of wicket-event-jquery.js which means Wicket.Browser.isIE() will return false in IE11. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (WICKET-5517) IE11 returns false for Wicket.Browser.isIE()
[ https://issues.apache.org/jira/browse/WICKET-5517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911656#comment-13911656 ] ASF GitHub Bot commented on WICKET-5517: GitHub user niesink opened a pull request: https://github.com/apache/wicket/pull/69 WICKET-5517 Added support for detection of IE11 in Wicket.Browser.isIE() and update references to Wicket.Browser.isIE() You can merge this pull request into a Git repository by running: $ git pull https://github.com/niesink/wicket wicket-6.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/wicket/pull/69.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #69 commit bcce5f29cf42afc83ab99d50f26558194b59192c Author: Martin Tzvetanov Grigorov mgrigo...@apache.org Date: 2013-09-16T08:25:11Z Append character instead of String where possible commit 3c4db496af86e972b2cfc2ed20a6fef25539afb6 Author: Martin Tzvetanov Grigorov mgrigo...@apache.org Date: 2013-09-16T08:25:30Z WICKET-5345 Url.canonical() breaks when there are two consecutive parent segments followed by a normal segment commit 6eb5df74a771f8ad15a1302aa5700e463ddc70a6 Author: Martin Tzvetanov Grigorov mgrigo...@apache.org Date: 2013-09-16T11:52:52Z WICKET-5348 JavaDoc for IColumn#getSortProperty() in misleading commit 89c660fbb1be911b540ff0cf270c35e7ff6a8fb0 Author: Martin Tzvetanov Grigorov mgrigo...@apache.org Date: 2013-09-17T08:11:05Z Minor improvement: use Args.notNull commit 1758ba6b5061f00550d9d65c9b077710d0834e9e Author: Martin Tzvetanov Grigorov mgrigo...@apache.org Date: 2013-09-17T08:22:00Z WICKET-5354 Make ResourceBundles and related classes easier for extension commit 46c03d259c62a9b6b4e13b9c0a86b252c9ecde19 Author: Martijn Dashorst martijn.dasho...@gmail.com Date: 2013-09-20T09:59:22Z Added release notes commit abd0bc5dbb95772af53649510f36a9607d5a9018 Author: Martijn Dashorst martijn.dasho...@gmail.com Date: 2013-09-20T10:01:43Z Added revert script to quickly revert a release when e.g. the changelog was not updated... commit 556587dfe5ebaf9499812fe08f273e7f75c56da4 Author: svenmeier s...@meiers.net Date: 2013-09-20T19:11:09Z WICKET-5359 fixed equals for different locales commit 53b335ee6140f9a0eade5bd30e1d131a67483f20 Author: bitstorm an.delb...@gmail.com Date: 2013-09-21T13:40:55Z WICKET-5356 AutoCompleteSettings.setShowListOnEmptyInput(true) is not working anymore commit d1570dbe76926459e7b036ab3e457a54fbeebbe8 Author: Martin Tzvetanov Grigorov mgrigo...@apache.org Date: 2013-09-23T12:01:40Z WICKET-5362 Add support for parsing IE 11 user agent commit c0c83d54f6b7466962b0d66bdfac0a0be231d312 Author: Martin Tzvetanov Grigorov mgrigo...@apache.org Date: 2013-09-24T08:27:41Z WICKET-5366 ResourceAggregator looses information about priority/filtering/... when using a bundle Add a test case showing the problem commit a6a37d445182fdc0ba385602170b474cca674ff5 Author: Emond Papegaaij emond.papega...@topicus.nl Date: 2013-09-24T13:20:35Z WICKET-5366: rewrap bundle-HeaderItems after resolving commit 27cfdf284521cde403f2bfaca4a03f40fc9f2372 Author: Martin Tzvetanov Grigorov mgrigo...@apache.org Date: 2013-09-24T17:44:40Z Remove usage of prototype.js in Ajax/GuestBook example. It is not really needed commit 865a34fdd5b114fe35c3c7fb2c9a013ca689375a Author: Martijn Dashorst martijn.dasho...@gmail.com Date: 2013-09-25T10:18:10Z Start next development version commit dd336fe22c9b0cfea6bad54261cce0c4fb112a77 Author: Martijn Dashorst martijn.dasho...@gmail.com Date: 2013-09-25T10:18:45Z Merge remote-tracking branch 'origin/wicket-6.x' into wicket-6.x commit a13dec062fffbe1b9fe933b0f546e6f50e1d7fed Author: Leonid Bogdanov leonid_bogda...@mail.ru Date: 2013-09-26T09:12:31Z Upgrade Atmosphere to 2.0.0 commit 28cac7193fe84790dc890937404f739c19927eda Author: svenmeier s...@meiers.net Date: 2013-09-26T09:54:16Z WICKET-5374 don't let XhtmlRenderer use a StringBufferInputStream, as it fails on non-ASCII characters commit 4a92041ebfd770f1b2450707d71d39363e3ceb4d Author: svenmeier s...@meiers.net Date: 2013-09-26T11:06:13Z retain existing CSS classes commit eaed6ee5ebc479fa87b67cc0489e2c3350541a55 Author: Emond Papegaaij emond.papega...@topicus.nl Date: 2013-09-26T13:02:05Z Merge branch 'wicket-6.x' of https://github.com/vonZeppelin/wicket into wicket-6.x commit 7db55f5a828560d8733c4db34eeaa06f11982741 Author: Martin Tzvetanov Grigorov mgrigo...@apache.org Date: 2013-09-26T14:49:06Z WICKET-5375 Improve ConcatBundleResource error handling when a resource is missing commit 2ae366b2eb90d53f1a6e06c3c09ba0d509bfe9d7 Author: Martin Tzvetanov Grigorov mgrigo...@apache.org Date:
[jira] [Commented] (WICKET-5517) IE11 returns false for Wicket.Browser.isIE()
[ https://issues.apache.org/jira/browse/WICKET-5517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911657#comment-13911657 ] ASF GitHub Bot commented on WICKET-5517: GitHub user niesink opened a pull request: https://github.com/apache/wicket/pull/70 WICKET-5517 Added support for detection of IE11 in Wicket.Browser.isIE() and update references to Wicket.Browser.isIE() You can merge this pull request into a Git repository by running: $ git pull https://github.com/niesink/wicket wicket-6.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/wicket/pull/70.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #70 commit a8fcba33b2ae33ccadfd6885ac05812143cbd5c9 Author: Luke Niesink luke.nies...@topicus.nl Date: 2014-02-25T15:15:06Z WICKET-5517 Added support for detection of IE11 in Wicket.Browser.isIE() commit a6565b625581ea583006ac98e5d4dba9c7b730fc Author: Luke Niesink luke.nies...@topicus.nl Date: 2014-02-25T15:16:35Z WICKET-5517 Use Wicket.Browser.isIELessThan11() as the behaviour of Wicket.Browser.isIE() has changed IE11 returns false for Wicket.Browser.isIE() Key: WICKET-5517 URL: https://issues.apache.org/jira/browse/WICKET-5517 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.14.0 Environment: Internet Explorer 11, tested on Windows 7 and 8. Reporter: Luke Niesink Assignee: Emond Papegaaij Priority: Minor As of Internet Explorer 11 this statement returns false instead of true (like it did prior to version 11): typeof(document.all) !== undefined This statement is used on line 56 of wicket-event-jquery.js which means Wicket.Browser.isIE() will return false in IE11. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (WICKET-5517) IE11 returns false for Wicket.Browser.isIE()
[ https://issues.apache.org/jira/browse/WICKET-5517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911661#comment-13911661 ] ASF GitHub Bot commented on WICKET-5517: Github user niesink closed the pull request at: https://github.com/apache/wicket/pull/69 IE11 returns false for Wicket.Browser.isIE() Key: WICKET-5517 URL: https://issues.apache.org/jira/browse/WICKET-5517 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.14.0 Environment: Internet Explorer 11, tested on Windows 7 and 8. Reporter: Luke Niesink Assignee: Emond Papegaaij Priority: Minor As of Internet Explorer 11 this statement returns false instead of true (like it did prior to version 11): typeof(document.all) !== undefined This statement is used on line 56 of wicket-event-jquery.js which means Wicket.Browser.isIE() will return false in IE11. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (WICKET-5517) IE11 returns false for Wicket.Browser.isIE()
[ https://issues.apache.org/jira/browse/WICKET-5517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911660#comment-13911660 ] ASF GitHub Bot commented on WICKET-5517: Github user niesink commented on the pull request: https://github.com/apache/wicket/pull/69#issuecomment-36018963 Tried to merge into master instead of the wicket-6.x branch, apologies IE11 returns false for Wicket.Browser.isIE() Key: WICKET-5517 URL: https://issues.apache.org/jira/browse/WICKET-5517 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.14.0 Environment: Internet Explorer 11, tested on Windows 7 and 8. Reporter: Luke Niesink Assignee: Emond Papegaaij Priority: Minor As of Internet Explorer 11 this statement returns false instead of true (like it did prior to version 11): typeof(document.all) !== undefined This statement is used on line 56 of wicket-event-jquery.js which means Wicket.Browser.isIE() will return false in IE11. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
