[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

2015-11-09 Thread Sergiu Hlihor (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14996925#comment-14996925
 ] 

Sergiu Hlihor commented on WICKET-5713:
---

Lost myself in options. Here it is: 
https://issues.apache.org/jira/browse/WICKET-6030 . Thanks

> Move /wicket.properties to /META-INF/wicket/xyz.properties
> --
>
> Key: WICKET-5713
> URL: https://issues.apache.org/jira/browse/WICKET-5713
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.17.0
>Reporter: Martin Grigorov
>Assignee: Martin Grigorov
>Priority: Minor
> Fix For: 7.0.0-M4
>
>
> As found at http://markmail.org/message/gzychpjelr4eshly the current location 
> of wicket.properties (at the root of the classpath entry) is problematic when 
> an uberjar is used because usually the developer doesn't know how 
> org.apache.wicket.IInitializer works and doesn't add code to merge the 
> contents of all wicket.propeties files in the classpath into one.
> But even if the developer tried to merge them then it will fail again because 
> org.apache.wicket.Application#load(Properties) doesn't expect more than one 
> value per key, e.g. separated by comma.
> Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
> and use more qualified names, e.g. org.apache.wicket.core.properties.
> The first problem is that there are no JRE and Servlet APIs to find such 
> files easily. We need to scan the classpath to be able to find them and load 
> them.
> Is this costly ?
> https://github.com/ronmamo/reflections is wildly used library that provides 
> this functionality (and much more) and it is using the same logic and seems 
> to be quite fast!
> So let's give it a try!
> We should still support /wicket.properties for backward compatibility. We can 
> log a WARN message when such is found and suggest to be moved in 
> /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

2015-11-09 Thread Martin Grigorov (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14996908#comment-14996908
 ] 

Martin Grigorov commented on WICKET-5713:
-

You have to login and then press the "Create" link at the top-center. Not the 
down arrow!

> Move /wicket.properties to /META-INF/wicket/xyz.properties
> --
>
> Key: WICKET-5713
> URL: https://issues.apache.org/jira/browse/WICKET-5713
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.17.0
>Reporter: Martin Grigorov
>Assignee: Martin Grigorov
>Priority: Minor
> Fix For: 7.0.0-M4
>
>
> As found at http://markmail.org/message/gzychpjelr4eshly the current location 
> of wicket.properties (at the root of the classpath entry) is problematic when 
> an uberjar is used because usually the developer doesn't know how 
> org.apache.wicket.IInitializer works and doesn't add code to merge the 
> contents of all wicket.propeties files in the classpath into one.
> But even if the developer tried to merge them then it will fail again because 
> org.apache.wicket.Application#load(Properties) doesn't expect more than one 
> value per key, e.g. separated by comma.
> Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
> and use more qualified names, e.g. org.apache.wicket.core.properties.
> The first problem is that there are no JRE and Servlet APIs to find such 
> files easily. We need to scan the classpath to be able to find them and load 
> them.
> Is this costly ?
> https://github.com/ronmamo/reflections is wildly used library that provides 
> this functionality (and much more) and it is using the same logic and seems 
> to be quite fast!
> So let's give it a try!
> We should still support /wicket.properties for backward compatibility. We can 
> log a WARN message when such is found and suggest to be moved in 
> /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

2015-11-09 Thread Sergiu Hlihor (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14996564#comment-14996564
 ] 

Sergiu Hlihor commented on WICKET-5713:
---

I would happily create a ticket but I do not believe I have the rights (I'm 
missing the "Create Issue").

> Move /wicket.properties to /META-INF/wicket/xyz.properties
> --
>
> Key: WICKET-5713
> URL: https://issues.apache.org/jira/browse/WICKET-5713
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.17.0
>Reporter: Martin Grigorov
>Assignee: Martin Grigorov
>Priority: Minor
> Fix For: 7.0.0-M4
>
>
> As found at http://markmail.org/message/gzychpjelr4eshly the current location 
> of wicket.properties (at the root of the classpath entry) is problematic when 
> an uberjar is used because usually the developer doesn't know how 
> org.apache.wicket.IInitializer works and doesn't add code to merge the 
> contents of all wicket.propeties files in the classpath into one.
> But even if the developer tried to merge them then it will fail again because 
> org.apache.wicket.Application#load(Properties) doesn't expect more than one 
> value per key, e.g. separated by comma.
> Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
> and use more qualified names, e.g. org.apache.wicket.core.properties.
> The first problem is that there are no JRE and Servlet APIs to find such 
> files easily. We need to scan the classpath to be able to find them and load 
> them.
> Is this costly ?
> https://github.com/ronmamo/reflections is wildly used library that provides 
> this functionality (and much more) and it is using the same logic and seems 
> to be quite fast!
> So let's give it a try!
> We should still support /wicket.properties for backward compatibility. We can 
> log a WARN message when such is found and suggest to be moved in 
> /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

2015-11-09 Thread Martin Grigorov (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14996534#comment-14996534
 ] 

Martin Grigorov commented on WICKET-5713:
-

It shouldn't be hard!
Please create a new ticket.
And provide a patch/pull request if you want to make sure it is part of 6.22.0. 
Otherwise someone of us will do it whenever we have time.

> Move /wicket.properties to /META-INF/wicket/xyz.properties
> --
>
> Key: WICKET-5713
> URL: https://issues.apache.org/jira/browse/WICKET-5713
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.17.0
>Reporter: Martin Grigorov
>Assignee: Martin Grigorov
>Priority: Minor
> Fix For: 7.0.0-M4
>
>
> As found at http://markmail.org/message/gzychpjelr4eshly the current location 
> of wicket.properties (at the root of the classpath entry) is problematic when 
> an uberjar is used because usually the developer doesn't know how 
> org.apache.wicket.IInitializer works and doesn't add code to merge the 
> contents of all wicket.propeties files in the classpath into one.
> But even if the developer tried to merge them then it will fail again because 
> org.apache.wicket.Application#load(Properties) doesn't expect more than one 
> value per key, e.g. separated by comma.
> Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
> and use more qualified names, e.g. org.apache.wicket.core.properties.
> The first problem is that there are no JRE and Servlet APIs to find such 
> files easily. We need to scan the classpath to be able to find them and load 
> them.
> Is this costly ?
> https://github.com/ronmamo/reflections is wildly used library that provides 
> this functionality (and much more) and it is using the same logic and seems 
> to be quite fast!
> So let's give it a try!
> We should still support /wicket.properties for backward compatibility. We can 
> log a WARN message when such is found and suggest to be moved in 
> /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

2015-11-09 Thread Sergiu Hlihor (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14996486#comment-14996486
 ] 

Sergiu Hlihor commented on WICKET-5713:
---

Hello,
Is there any chance to get this backported also on Wicket 6.x ? We need it 
and we cannot migrate to 7.x yet.


> Move /wicket.properties to /META-INF/wicket/xyz.properties
> --
>
> Key: WICKET-5713
> URL: https://issues.apache.org/jira/browse/WICKET-5713
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.17.0
>Reporter: Martin Grigorov
>Assignee: Martin Grigorov
>Priority: Minor
> Fix For: 7.0.0-M4
>
>
> As found at http://markmail.org/message/gzychpjelr4eshly the current location 
> of wicket.properties (at the root of the classpath entry) is problematic when 
> an uberjar is used because usually the developer doesn't know how 
> org.apache.wicket.IInitializer works and doesn't add code to merge the 
> contents of all wicket.propeties files in the classpath into one.
> But even if the developer tried to merge them then it will fail again because 
> org.apache.wicket.Application#load(Properties) doesn't expect more than one 
> value per key, e.g. separated by comma.
> Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
> and use more qualified names, e.g. org.apache.wicket.core.properties.
> The first problem is that there are no JRE and Servlet APIs to find such 
> files easily. We need to scan the classpath to be able to find them and load 
> them.
> Is this costly ?
> https://github.com/ronmamo/reflections is wildly used library that provides 
> this functionality (and much more) and it is using the same logic and seems 
> to be quite fast!
> So let's give it a try!
> We should still support /wicket.properties for backward compatibility. We can 
> log a WARN message when such is found and suggest to be moved in 
> /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

2015-04-22 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507390#comment-14507390
 ] 

ASF subversion and git services commented on WICKET-5713:
-

Commit 071e5a06a99a56914482a5fd1418a256bb1d5906 in wicket's branch 
refs/heads/master from [~bitstorm]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=071e5a0 ]

changes for WICKET-5713 and WICKET-5124


> Move /wicket.properties to /META-INF/wicket/xyz.properties
> --
>
> Key: WICKET-5713
> URL: https://issues.apache.org/jira/browse/WICKET-5713
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.17.0
>Reporter: Martin Grigorov
>Assignee: Martin Grigorov
>Priority: Minor
> Fix For: 7.0.0-M4
>
>
> As found at http://markmail.org/message/gzychpjelr4eshly the current location 
> of wicket.properties (at the root of the classpath entry) is problematic when 
> an uberjar is used because usually the developer doesn't know how 
> org.apache.wicket.IInitializer works and doesn't add code to merge the 
> contents of all wicket.propeties files in the classpath into one.
> But even if the developer tried to merge them then it will fail again because 
> org.apache.wicket.Application#load(Properties) doesn't expect more than one 
> value per key, e.g. separated by comma.
> Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
> and use more qualified names, e.g. org.apache.wicket.core.properties.
> The first problem is that there are no JRE and Servlet APIs to find such 
> files easily. We need to scan the classpath to be able to find them and load 
> them.
> Is this costly ?
> https://github.com/ronmamo/reflections is wildly used library that provides 
> this functionality (and much more) and it is using the same logic and seems 
> to be quite fast!
> So let's give it a try!
> We should still support /wicket.properties for backward compatibility. We can 
> log a WARN message when such is found and suggest to be moved in 
> /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

2015-04-09 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487577#comment-14487577
 ] 

ASF subversion and git services commented on WICKET-5713:
-

Commit 071e5a06a99a56914482a5fd1418a256bb1d5906 in wicket's branch 
refs/heads/grails-maven-integration from [~bitstorm]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=071e5a0 ]

changes for WICKET-5713 and WICKET-5124


> Move /wicket.properties to /META-INF/wicket/xyz.properties
> --
>
> Key: WICKET-5713
> URL: https://issues.apache.org/jira/browse/WICKET-5713
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.17.0
>Reporter: Martin Grigorov
>Assignee: Martin Grigorov
>Priority: Minor
> Fix For: 7.0.0-M4
>
>
> As found at http://markmail.org/message/gzychpjelr4eshly the current location 
> of wicket.properties (at the root of the classpath entry) is problematic when 
> an uberjar is used because usually the developer doesn't know how 
> org.apache.wicket.IInitializer works and doesn't add code to merge the 
> contents of all wicket.propeties files in the classpath into one.
> But even if the developer tried to merge them then it will fail again because 
> org.apache.wicket.Application#load(Properties) doesn't expect more than one 
> value per key, e.g. separated by comma.
> Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
> and use more qualified names, e.g. org.apache.wicket.core.properties.
> The first problem is that there are no JRE and Servlet APIs to find such 
> files easily. We need to scan the classpath to be able to find them and load 
> them.
> Is this costly ?
> https://github.com/ronmamo/reflections is wildly used library that provides 
> this functionality (and much more) and it is using the same logic and seems 
> to be quite fast!
> So let's give it a try!
> We should still support /wicket.properties for backward compatibility. We can 
> log a WARN message when such is found and suggest to be moved in 
> /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

2014-11-11 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14206400#comment-14206400
 ] 

ASF subversion and git services commented on WICKET-5713:
-

Commit 6b2a65b0f62ab8cb11aeabdb2bd4c551f7433268 in wicket's branch 
refs/heads/master from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=6b2a65b ]

WICKET-5713 Move /wicket.properties to /META-INF/wicket/xyz.properties

Add a check for scheme "wsjar" used by WebSphere.
borrowed-from: https://github.com/ronmamo/reflections/pull/46/files


> Move /wicket.properties to /META-INF/wicket/xyz.properties
> --
>
> Key: WICKET-5713
> URL: https://issues.apache.org/jira/browse/WICKET-5713
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.17.0
>Reporter: Martin Grigorov
>Assignee: Martin Grigorov
>Priority: Minor
> Fix For: 7.0.0-M4
>
>
> As found at http://markmail.org/message/gzychpjelr4eshly the current location 
> of wicket.properties (at the root of the classpath entry) is problematic when 
> an uberjar is used because usually the developer doesn't know how 
> org.apache.wicket.IInitializer works and doesn't add code to merge the 
> contents of all wicket.propeties files in the classpath into one.
> But even if the developer tried to merge them then it will fail again because 
> org.apache.wicket.Application#load(Properties) doesn't expect more than one 
> value per key, e.g. separated by comma.
> Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
> and use more qualified names, e.g. org.apache.wicket.core.properties.
> The first problem is that there are no JRE and Servlet APIs to find such 
> files easily. We need to scan the classpath to be able to find them and load 
> them.
> Is this costly ?
> https://github.com/ronmamo/reflections is wildly used library that provides 
> this functionality (and much more) and it is using the same logic and seems 
> to be quite fast!
> So let's give it a try!
> We should still support /wicket.properties for backward compatibility. We can 
> log a WARN message when such is found and suggest to be moved in 
> /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

2014-10-15 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14172150#comment-14172150
 ] 

ASF subversion and git services commented on WICKET-5713:
-

Commit 46684ffdf5fa925976e1c10b89b8b754af152b6f in wicket's branch 
refs/heads/master from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=46684ff ]

WICKET-5713 Move /wicket.properties to /META-INF/wicket/xyz.properties

Add support for traversing JBoss' VFS


> Move /wicket.properties to /META-INF/wicket/xyz.properties
> --
>
> Key: WICKET-5713
> URL: https://issues.apache.org/jira/browse/WICKET-5713
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.17.0
>Reporter: Martin Grigorov
>Assignee: Martin Grigorov
>Priority: Minor
> Fix For: 7.0.0-M4
>
>
> As found at http://markmail.org/message/gzychpjelr4eshly the current location 
> of wicket.properties (at the root of the classpath entry) is problematic when 
> an uberjar is used because usually the developer doesn't know how 
> org.apache.wicket.IInitializer works and doesn't add code to merge the 
> contents of all wicket.propeties files in the classpath into one.
> But even if the developer tried to merge them then it will fail again because 
> org.apache.wicket.Application#load(Properties) doesn't expect more than one 
> value per key, e.g. separated by comma.
> Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
> and use more qualified names, e.g. org.apache.wicket.core.properties.
> The first problem is that there are no JRE and Servlet APIs to find such 
> files easily. We need to scan the classpath to be able to find them and load 
> them.
> Is this costly ?
> https://github.com/ronmamo/reflections is wildly used library that provides 
> this functionality (and much more) and it is using the same logic and seems 
> to be quite fast!
> So let's give it a try!
> We should still support /wicket.properties for backward compatibility. We can 
> log a WARN message when such is found and suggest to be moved in 
> /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

2014-10-13 Thread Garret Wilson (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170233#comment-14170233
 ] 

Garret Wilson commented on WICKET-5713:
---

Sorry I haven't had time to contribute to this thread yet --- we have some huge 
deadlines right now on our project.

{quote}Java's service registry is broken with uberjar too (e.g. 
META-INF/services/java.sql.Driver).{quote}

Yeah, that's probably true. The whole idea of an uberjar isn't the best, I 
admit --- I've had our team switch to using individually bundled jars.

Anyway, I appreciate you guys looking into my brainstorming ideas. I hope 
something useful came of it.

> Move /wicket.properties to /META-INF/wicket/xyz.properties
> --
>
> Key: WICKET-5713
> URL: https://issues.apache.org/jira/browse/WICKET-5713
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.17.0
>Reporter: Martin Grigorov
>Assignee: Martin Grigorov
>Priority: Minor
> Fix For: 7.0.0-M4
>
>
> As found at http://markmail.org/message/gzychpjelr4eshly the current location 
> of wicket.properties (at the root of the classpath entry) is problematic when 
> an uberjar is used because usually the developer doesn't know how 
> org.apache.wicket.IInitializer works and doesn't add code to merge the 
> contents of all wicket.propeties files in the classpath into one.
> But even if the developer tried to merge them then it will fail again because 
> org.apache.wicket.Application#load(Properties) doesn't expect more than one 
> value per key, e.g. separated by comma.
> Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
> and use more qualified names, e.g. org.apache.wicket.core.properties.
> The first problem is that there are no JRE and Servlet APIs to find such 
> files easily. We need to scan the classpath to be able to find them and load 
> them.
> Is this costly ?
> https://github.com/ronmamo/reflections is wildly used library that provides 
> this functionality (and much more) and it is using the same logic and seems 
> to be quite fast!
> So let's give it a try!
> We should still support /wicket.properties for backward compatibility. We can 
> log a WARN message when such is found and suggest to be moved in 
> /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

2014-10-13 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169250#comment-14169250
 ] 

ASF subversion and git services commented on WICKET-5713:
-

Commit d106598d4e244122eb330ae84de9cdc6f0ac1413 in wicket's branch 
refs/heads/master from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=d106598 ]

WICKET-5713 Move /wicket.properties to /META-INF/wicket/xyz.properties


> Move /wicket.properties to /META-INF/wicket/xyz.properties
> --
>
> Key: WICKET-5713
> URL: https://issues.apache.org/jira/browse/WICKET-5713
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.17.0
>Reporter: Martin Grigorov
>Assignee: Martin Grigorov
>Priority: Minor
>
> As found at http://markmail.org/message/gzychpjelr4eshly the current location 
> of wicket.properties (at the root of the classpath entry) is problematic when 
> an uberjar is used because usually the developer doesn't know how 
> org.apache.wicket.IInitializer works and doesn't add code to merge the 
> contents of all wicket.propeties files in the classpath into one.
> But even if the developer tried to merge them then it will fail again because 
> org.apache.wicket.Application#load(Properties) doesn't expect more than one 
> value per key, e.g. separated by comma.
> Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
> and use more qualified names, e.g. org.apache.wicket.core.properties.
> The first problem is that there are no JRE and Servlet APIs to find such 
> files easily. We need to scan the classpath to be able to find them and load 
> them.
> Is this costly ?
> https://github.com/ronmamo/reflections is wildly used library that provides 
> this functionality (and much more) and it is using the same logic and seems 
> to be quite fast!
> So let's give it a try!
> We should still support /wicket.properties for backward compatibility. We can 
> log a WARN message when such is found and suggest to be moved in 
> /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

2014-10-13 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169252#comment-14169252
 ] 

ASF subversion and git services commented on WICKET-5713:
-

Commit 3f1e1dfe3a33ccaa7b3514655db287bb765fb1c8 in wicket's branch 
refs/heads/master from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=3f1e1df ]

Merge branch 'WICKET-5713-meta-inf-wicket'


> Move /wicket.properties to /META-INF/wicket/xyz.properties
> --
>
> Key: WICKET-5713
> URL: https://issues.apache.org/jira/browse/WICKET-5713
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.17.0
>Reporter: Martin Grigorov
>Assignee: Martin Grigorov
>Priority: Minor
>
> As found at http://markmail.org/message/gzychpjelr4eshly the current location 
> of wicket.properties (at the root of the classpath entry) is problematic when 
> an uberjar is used because usually the developer doesn't know how 
> org.apache.wicket.IInitializer works and doesn't add code to merge the 
> contents of all wicket.propeties files in the classpath into one.
> But even if the developer tried to merge them then it will fail again because 
> org.apache.wicket.Application#load(Properties) doesn't expect more than one 
> value per key, e.g. separated by comma.
> Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
> and use more qualified names, e.g. org.apache.wicket.core.properties.
> The first problem is that there are no JRE and Servlet APIs to find such 
> files easily. We need to scan the classpath to be able to find them and load 
> them.
> Is this costly ?
> https://github.com/ronmamo/reflections is wildly used library that provides 
> this functionality (and much more) and it is using the same logic and seems 
> to be quite fast!
> So let's give it a try!
> We should still support /wicket.properties for backward compatibility. We can 
> log a WARN message when such is found and suggest to be moved in 
> /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

2014-10-13 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169251#comment-14169251
 ] 

ASF subversion and git services commented on WICKET-5713:
-

Commit fa10aef39e23c0258738079e1d1ff90885175dc1 in wicket's branch 
refs/heads/master from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=fa10aef ]

WICKET-5713 Move /wicket.properties to /META-INF/wicket/xyz.properties

Minor improvements


> Move /wicket.properties to /META-INF/wicket/xyz.properties
> --
>
> Key: WICKET-5713
> URL: https://issues.apache.org/jira/browse/WICKET-5713
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.17.0
>Reporter: Martin Grigorov
>Assignee: Martin Grigorov
>Priority: Minor
>
> As found at http://markmail.org/message/gzychpjelr4eshly the current location 
> of wicket.properties (at the root of the classpath entry) is problematic when 
> an uberjar is used because usually the developer doesn't know how 
> org.apache.wicket.IInitializer works and doesn't add code to merge the 
> contents of all wicket.propeties files in the classpath into one.
> But even if the developer tried to merge them then it will fail again because 
> org.apache.wicket.Application#load(Properties) doesn't expect more than one 
> value per key, e.g. separated by comma.
> Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
> and use more qualified names, e.g. org.apache.wicket.core.properties.
> The first problem is that there are no JRE and Servlet APIs to find such 
> files easily. We need to scan the classpath to be able to find them and load 
> them.
> Is this costly ?
> https://github.com/ronmamo/reflections is wildly used library that provides 
> this functionality (and much more) and it is using the same logic and seems 
> to be quite fast!
> So let's give it a try!
> We should still support /wicket.properties for backward compatibility. We can 
> log a WARN message when such is found and suggest to be moved in 
> /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

2014-10-13 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169249#comment-14169249
 ] 

ASF subversion and git services commented on WICKET-5713:
-

Commit e4262674d6dd347fb51a1454c63e5f03ed5f135e in wicket's branch 
refs/heads/master from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=e426267 ]

WICKET-5713 Move /wicket.properties to /META-INF/wicket/xyz.properties


> Move /wicket.properties to /META-INF/wicket/xyz.properties
> --
>
> Key: WICKET-5713
> URL: https://issues.apache.org/jira/browse/WICKET-5713
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.17.0
>Reporter: Martin Grigorov
>Assignee: Martin Grigorov
>Priority: Minor
>
> As found at http://markmail.org/message/gzychpjelr4eshly the current location 
> of wicket.properties (at the root of the classpath entry) is problematic when 
> an uberjar is used because usually the developer doesn't know how 
> org.apache.wicket.IInitializer works and doesn't add code to merge the 
> contents of all wicket.propeties files in the classpath into one.
> But even if the developer tried to merge them then it will fail again because 
> org.apache.wicket.Application#load(Properties) doesn't expect more than one 
> value per key, e.g. separated by comma.
> Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
> and use more qualified names, e.g. org.apache.wicket.core.properties.
> The first problem is that there are no JRE and Servlet APIs to find such 
> files easily. We need to scan the classpath to be able to find them and load 
> them.
> Is this costly ?
> https://github.com/ronmamo/reflections is wildly used library that provides 
> this functionality (and much more) and it is using the same logic and seems 
> to be quite fast!
> So let's give it a try!
> We should still support /wicket.properties for backward compatibility. We can 
> log a WARN message when such is found and suggest to be moved in 
> /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

2014-10-02 Thread Martin Grigorov (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156590#comment-14156590
 ] 

Martin Grigorov commented on WICKET-5713:
-

No. No new dependencies.
It is manual traversal of the content of .jar that has /META-INF/wicket/ folder 
entry inside.
There is no way to traverse only the files inside /META-INF/wicket/ so all 
entries in the jar are visited. Once the properties file is found we break the 
traversal.
I don't see noticeable delay in Maven build. And it is done only at application 
start time so it should not hurt.

> Move /wicket.properties to /META-INF/wicket/xyz.properties
> --
>
> Key: WICKET-5713
> URL: https://issues.apache.org/jira/browse/WICKET-5713
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.17.0
>Reporter: Martin Grigorov
>Assignee: Martin Grigorov
>Priority: Minor
>
> As found at http://markmail.org/message/gzychpjelr4eshly the current location 
> of wicket.properties (at the root of the classpath entry) is problematic when 
> an uberjar is used because usually the developer doesn't know how 
> org.apache.wicket.IInitializer works and doesn't add code to merge the 
> contents of all wicket.propeties files in the classpath into one.
> But even if the developer tried to merge them then it will fail again because 
> org.apache.wicket.Application#load(Properties) doesn't expect more than one 
> value per key, e.g. separated by comma.
> Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
> and use more qualified names, e.g. org.apache.wicket.core.properties.
> The first problem is that there are no JRE and Servlet APIs to find such 
> files easily. We need to scan the classpath to be able to find them and load 
> them.
> Is this costly ?
> https://github.com/ronmamo/reflections is wildly used library that provides 
> this functionality (and much more) and it is using the same logic and seems 
> to be quite fast!
> So let's give it a try!
> We should still support /wicket.properties for backward compatibility. We can 
> log a WARN message when such is found and suggest to be moved in 
> /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

2014-10-02 Thread Andrea Del Bene (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156587#comment-14156587
 ] 

Andrea Del Bene commented on WICKET-5713:
-

so no additional dependency on reflections, right?

> Move /wicket.properties to /META-INF/wicket/xyz.properties
> --
>
> Key: WICKET-5713
> URL: https://issues.apache.org/jira/browse/WICKET-5713
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.17.0
>Reporter: Martin Grigorov
>Assignee: Martin Grigorov
>Priority: Minor
>
> As found at http://markmail.org/message/gzychpjelr4eshly the current location 
> of wicket.properties (at the root of the classpath entry) is problematic when 
> an uberjar is used because usually the developer doesn't know how 
> org.apache.wicket.IInitializer works and doesn't add code to merge the 
> contents of all wicket.propeties files in the classpath into one.
> But even if the developer tried to merge them then it will fail again because 
> org.apache.wicket.Application#load(Properties) doesn't expect more than one 
> value per key, e.g. separated by comma.
> Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
> and use more qualified names, e.g. org.apache.wicket.core.properties.
> The first problem is that there are no JRE and Servlet APIs to find such 
> files easily. We need to scan the classpath to be able to find them and load 
> them.
> Is this costly ?
> https://github.com/ronmamo/reflections is wildly used library that provides 
> this functionality (and much more) and it is using the same logic and seems 
> to be quite fast!
> So let's give it a try!
> We should still support /wicket.properties for backward compatibility. We can 
> log a WARN message when such is found and suggest to be moved in 
> /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

2014-10-02 Thread Martin Grigorov (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156572#comment-14156572
 ] 

Martin Grigorov commented on WICKET-5713:
-

Are there not registered ones ?
org.apache.wicket.extensions.ajax.markup.html.form.upload.UploadProgressBar.ComponentInitializer
 is registered transitively, for example. Your way won't show it as registered 
one unless you open and read the content of 
org.apache.wicket.extensions.Initializer.
Anyway, you have your ways, and I have mine ...

By changing the file extension to '.initializer' we will make this Properties 
file's purpose solely for IInitializers (by looking at the file name).
At the moment there is no need to use it for something else but in the future 
there may appear one ...

> Move /wicket.properties to /META-INF/wicket/xyz.properties
> --
>
> Key: WICKET-5713
> URL: https://issues.apache.org/jira/browse/WICKET-5713
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.17.0
>Reporter: Martin Grigorov
>Assignee: Martin Grigorov
>Priority: Minor
>
> As found at http://markmail.org/message/gzychpjelr4eshly the current location 
> of wicket.properties (at the root of the classpath entry) is problematic when 
> an uberjar is used because usually the developer doesn't know how 
> org.apache.wicket.IInitializer works and doesn't add code to merge the 
> contents of all wicket.propeties files in the classpath into one.
> But even if the developer tried to merge them then it will fail again because 
> org.apache.wicket.Application#load(Properties) doesn't expect more than one 
> value per key, e.g. separated by comma.
> Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
> and use more qualified names, e.g. org.apache.wicket.core.properties.
> The first problem is that there are no JRE and Servlet APIs to find such 
> files easily. We need to scan the classpath to be able to find them and load 
> them.
> Is this costly ?
> https://github.com/ronmamo/reflections is wildly used library that provides 
> this functionality (and much more) and it is using the same logic and seems 
> to be quite fast!
> So let's give it a try!
> We should still support /wicket.properties for backward compatibility. We can 
> log a WARN message when such is found and suggest to be moved in 
> /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

2014-10-02 Thread Sven Meier (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156557#comment-14156557
 ] 

Sven Meier commented on WICKET-5713:


That IDE power will show you all IInitializers, but not the registered ones.

> Move /wicket.properties to /META-INF/wicket/xyz.properties
> --
>
> Key: WICKET-5713
> URL: https://issues.apache.org/jira/browse/WICKET-5713
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.17.0
>Reporter: Martin Grigorov
>Assignee: Martin Grigorov
>Priority: Minor
>
> As found at http://markmail.org/message/gzychpjelr4eshly the current location 
> of wicket.properties (at the root of the classpath entry) is problematic when 
> an uberjar is used because usually the developer doesn't know how 
> org.apache.wicket.IInitializer works and doesn't add code to merge the 
> contents of all wicket.propeties files in the classpath into one.
> But even if the developer tried to merge them then it will fail again because 
> org.apache.wicket.Application#load(Properties) doesn't expect more than one 
> value per key, e.g. separated by comma.
> Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
> and use more qualified names, e.g. org.apache.wicket.core.properties.
> The first problem is that there are no JRE and Servlet APIs to find such 
> files easily. We need to scan the classpath to be able to find them and load 
> them.
> Is this costly ?
> https://github.com/ronmamo/reflections is wildly used library that provides 
> this functionality (and much more) and it is using the same logic and seems 
> to be quite fast!
> So let's give it a try!
> We should still support /wicket.properties for backward compatibility. We can 
> log a WARN message when such is found and suggest to be moved in 
> /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

2014-10-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156479#comment-14156479
 ] 

ASF subversion and git services commented on WICKET-5713:
-

Commit fa10aef39e23c0258738079e1d1ff90885175dc1 in wicket's branch 
refs/heads/WICKET-5713-meta-inf-wicket from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=fa10aef ]

WICKET-5713 Move /wicket.properties to /META-INF/wicket/xyz.properties

Minor improvements


> Move /wicket.properties to /META-INF/wicket/xyz.properties
> --
>
> Key: WICKET-5713
> URL: https://issues.apache.org/jira/browse/WICKET-5713
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.17.0
>Reporter: Martin Grigorov
>Assignee: Martin Grigorov
>Priority: Minor
>
> As found at http://markmail.org/message/gzychpjelr4eshly the current location 
> of wicket.properties (at the root of the classpath entry) is problematic when 
> an uberjar is used because usually the developer doesn't know how 
> org.apache.wicket.IInitializer works and doesn't add code to merge the 
> contents of all wicket.propeties files in the classpath into one.
> But even if the developer tried to merge them then it will fail again because 
> org.apache.wicket.Application#load(Properties) doesn't expect more than one 
> value per key, e.g. separated by comma.
> Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
> and use more qualified names, e.g. org.apache.wicket.core.properties.
> The first problem is that there are no JRE and Servlet APIs to find such 
> files easily. We need to scan the classpath to be able to find them and load 
> them.
> Is this costly ?
> https://github.com/ronmamo/reflections is wildly used library that provides 
> this functionality (and much more) and it is using the same logic and seems 
> to be quite fast!
> So let's give it a try!
> We should still support /wicket.properties for backward compatibility. We can 
> log a WARN message when such is found and suggest to be moved in 
> /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

2014-10-02 Thread Martin Grigorov (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156465#comment-14156465
 ] 

Martin Grigorov commented on WICKET-5713:
-

Changing the extension is totally OK!

I use the IDE main power to find Java artefacts - "Open IInitializer class" 
(Ctrl+N) and then "Show Implementations" (Ctrl+Alt+B in IDEA) :-)

> Move /wicket.properties to /META-INF/wicket/xyz.properties
> --
>
> Key: WICKET-5713
> URL: https://issues.apache.org/jira/browse/WICKET-5713
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.17.0
>Reporter: Martin Grigorov
>Assignee: Martin Grigorov
>Priority: Minor
>
> As found at http://markmail.org/message/gzychpjelr4eshly the current location 
> of wicket.properties (at the root of the classpath entry) is problematic when 
> an uberjar is used because usually the developer doesn't know how 
> org.apache.wicket.IInitializer works and doesn't add code to merge the 
> contents of all wicket.propeties files in the classpath into one.
> But even if the developer tried to merge them then it will fail again because 
> org.apache.wicket.Application#load(Properties) doesn't expect more than one 
> value per key, e.g. separated by comma.
> Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
> and use more qualified names, e.g. org.apache.wicket.core.properties.
> The first problem is that there are no JRE and Servlet APIs to find such 
> files easily. We need to scan the classpath to be able to find them and load 
> them.
> Is this costly ?
> https://github.com/ronmamo/reflections is wildly used library that provides 
> this functionality (and much more) and it is using the same logic and seems 
> to be quite fast!
> So let's give it a try!
> We should still support /wicket.properties for backward compatibility. We can 
> log a WARN message when such is found and suggest to be moved in 
> /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

2014-10-02 Thread Sven Meier (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156458#comment-14156458
 ] 

Sven Meier commented on WICKET-5713:


Moving the files to META-INF/wicket is a good idea.

Apart from that I don't think this change is too useful:
I'd expect usage of uberjar to lead to many other name collisions anyway. 
Java's service registry is broken with uberjar too (e.g. 
META-INF/services/java.sql.Driver).

Furthermore up til now I was able to search for "wicket.properties" in my IDE 
and quickly find all registered Initializers. Now I can't find them so easily 
:(.
Can we at least rename *.properties to *.initializer(s)?

> Move /wicket.properties to /META-INF/wicket/xyz.properties
> --
>
> Key: WICKET-5713
> URL: https://issues.apache.org/jira/browse/WICKET-5713
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.17.0
>Reporter: Martin Grigorov
>Assignee: Martin Grigorov
>Priority: Minor
>
> As found at http://markmail.org/message/gzychpjelr4eshly the current location 
> of wicket.properties (at the root of the classpath entry) is problematic when 
> an uberjar is used because usually the developer doesn't know how 
> org.apache.wicket.IInitializer works and doesn't add code to merge the 
> contents of all wicket.propeties files in the classpath into one.
> But even if the developer tried to merge them then it will fail again because 
> org.apache.wicket.Application#load(Properties) doesn't expect more than one 
> value per key, e.g. separated by comma.
> Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
> and use more qualified names, e.g. org.apache.wicket.core.properties.
> The first problem is that there are no JRE and Servlet APIs to find such 
> files easily. We need to scan the classpath to be able to find them and load 
> them.
> Is this costly ?
> https://github.com/ronmamo/reflections is wildly used library that provides 
> this functionality (and much more) and it is using the same logic and seems 
> to be quite fast!
> So let's give it a try!
> We should still support /wicket.properties for backward compatibility. We can 
> log a WARN message when such is found and suggest to be moved in 
> /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

2014-10-02 Thread Martin Grigorov (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156368#comment-14156368
 ] 

Martin Grigorov commented on WICKET-5713:
-

Please review !

> Move /wicket.properties to /META-INF/wicket/xyz.properties
> --
>
> Key: WICKET-5713
> URL: https://issues.apache.org/jira/browse/WICKET-5713
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.17.0
>Reporter: Martin Grigorov
>Assignee: Martin Grigorov
>Priority: Minor
>
> As found at http://markmail.org/message/gzychpjelr4eshly the current location 
> of wicket.properties (at the root of the classpath entry) is problematic when 
> an uberjar is used because usually the developer doesn't know how 
> org.apache.wicket.IInitializer works and doesn't add code to merge the 
> contents of all wicket.propeties files in the classpath into one.
> But even if the developer tried to merge them then it will fail again because 
> org.apache.wicket.Application#load(Properties) doesn't expect more than one 
> value per key, e.g. separated by comma.
> Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
> and use more qualified names, e.g. org.apache.wicket.core.properties.
> The first problem is that there are no JRE and Servlet APIs to find such 
> files easily. We need to scan the classpath to be able to find them and load 
> them.
> Is this costly ?
> https://github.com/ronmamo/reflections is wildly used library that provides 
> this functionality (and much more) and it is using the same logic and seems 
> to be quite fast!
> So let's give it a try!
> We should still support /wicket.properties for backward compatibility. We can 
> log a WARN message when such is found and suggest to be moved in 
> /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

2014-10-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156367#comment-14156367
 ] 

ASF subversion and git services commented on WICKET-5713:
-

Commit d106598d4e244122eb330ae84de9cdc6f0ac1413 in wicket's branch 
refs/heads/WICKET-5713-meta-inf-wicket from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=d106598 ]

WICKET-5713 Move /wicket.properties to /META-INF/wicket/xyz.properties


> Move /wicket.properties to /META-INF/wicket/xyz.properties
> --
>
> Key: WICKET-5713
> URL: https://issues.apache.org/jira/browse/WICKET-5713
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.17.0
>Reporter: Martin Grigorov
>Assignee: Martin Grigorov
>Priority: Minor
>
> As found at http://markmail.org/message/gzychpjelr4eshly the current location 
> of wicket.properties (at the root of the classpath entry) is problematic when 
> an uberjar is used because usually the developer doesn't know how 
> org.apache.wicket.IInitializer works and doesn't add code to merge the 
> contents of all wicket.propeties files in the classpath into one.
> But even if the developer tried to merge them then it will fail again because 
> org.apache.wicket.Application#load(Properties) doesn't expect more than one 
> value per key, e.g. separated by comma.
> Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
> and use more qualified names, e.g. org.apache.wicket.core.properties.
> The first problem is that there are no JRE and Servlet APIs to find such 
> files easily. We need to scan the classpath to be able to find them and load 
> them.
> Is this costly ?
> https://github.com/ronmamo/reflections is wildly used library that provides 
> this functionality (and much more) and it is using the same logic and seems 
> to be quite fast!
> So let's give it a try!
> We should still support /wicket.properties for backward compatibility. We can 
> log a WARN message when such is found and suggest to be moved in 
> /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

2014-10-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156306#comment-14156306
 ] 

ASF subversion and git services commented on WICKET-5713:
-

Commit e4262674d6dd347fb51a1454c63e5f03ed5f135e in wicket's branch 
refs/heads/WICKET-5713-meta-inf-wicket from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=e426267 ]

WICKET-5713 Move /wicket.properties to /META-INF/wicket/xyz.properties


> Move /wicket.properties to /META-INF/wicket/xyz.properties
> --
>
> Key: WICKET-5713
> URL: https://issues.apache.org/jira/browse/WICKET-5713
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.17.0
>Reporter: Martin Grigorov
>Assignee: Martin Grigorov
>Priority: Minor
>
> As found at http://markmail.org/message/gzychpjelr4eshly the current location 
> of wicket.properties (at the root of the classpath entry) is problematic when 
> an uberjar is used because usually the developer doesn't know how 
> org.apache.wicket.IInitializer works and doesn't add code to merge the 
> contents of all wicket.propeties files in the classpath into one.
> But even if the developer tried to merge them then it will fail again because 
> org.apache.wicket.Application#load(Properties) doesn't expect more than one 
> value per key, e.g. separated by comma.
> Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
> and use more qualified names, e.g. org.apache.wicket.core.properties.
> The first problem is that there are no JRE and Servlet APIs to find such 
> files easily. We need to scan the classpath to be able to find them and load 
> them.
> Is this costly ?
> https://github.com/ronmamo/reflections is wildly used library that provides 
> this functionality (and much more) and it is using the same logic and seems 
> to be quite fast!
> So let's give it a try!
> We should still support /wicket.properties for backward compatibility. We can 
> log a WARN message when such is found and suggest to be moved in 
> /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)