[jira] [Commented] (WICKET-5717) Url.parse/toString should support fragment
[ https://issues.apache.org/jira/browse/WICKET-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14166504#comment-14166504 ] ASF GitHub Bot commented on WICKET-5717: Github user gsmet commented on the pull request: https://github.com/apache/wicket/pull/78#issuecomment-58620519 Thanks! Url.parse/toString should support fragment -- Key: WICKET-5717 URL: https://issues.apache.org/jira/browse/WICKET-5717 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.17.0 Reporter: Guillaume Smet Assignee: Martin Grigorov Fix For: 6.18.0, 7.0.0-M4 Attachments: redirect-url-anchor.tar.gz Hi, Starting with Wicket 6.16, we have issues redirecting to an absolute URL containing a fragment: the # is escaped by Wicket. Changes in the commit https://fisheye6.atlassian.com/changelog/wicket-git?cs=e1f29e90ff3a35e117bb3ddc5ee2aefd900c13c8 are causing the regression but as far as we can see, the commit is not the problem: the issue is that Url.parse then toString encodes the anchor. Before this commit, as we were using an absolute Url, we were in the case where the Url wasn't escaped. We think the right fix would be to make org.apache.wicket.request.Url anchor aware. Pull request to come. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5717) Url.parse/toString should support fragment
[ https://issues.apache.org/jira/browse/WICKET-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14166505#comment-14166505 ] ASF GitHub Bot commented on WICKET-5717: Github user gsmet closed the pull request at: https://github.com/apache/wicket/pull/78 Url.parse/toString should support fragment -- Key: WICKET-5717 URL: https://issues.apache.org/jira/browse/WICKET-5717 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.17.0 Reporter: Guillaume Smet Assignee: Martin Grigorov Fix For: 6.18.0, 7.0.0-M4 Attachments: redirect-url-anchor.tar.gz Hi, Starting with Wicket 6.16, we have issues redirecting to an absolute URL containing a fragment: the # is escaped by Wicket. Changes in the commit https://fisheye6.atlassian.com/changelog/wicket-git?cs=e1f29e90ff3a35e117bb3ddc5ee2aefd900c13c8 are causing the regression but as far as we can see, the commit is not the problem: the issue is that Url.parse then toString encodes the anchor. Before this commit, as we were using an absolute Url, we were in the case where the Url wasn't escaped. We think the right fix would be to make org.apache.wicket.request.Url anchor aware. Pull request to come. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5717) Url.parse/toString should support fragment
[ https://issues.apache.org/jira/browse/WICKET-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14163265#comment-14163265 ] ASF GitHub Bot commented on WICKET-5717: Github user martin-g commented on the pull request: https://github.com/apache/wicket/pull/78#issuecomment-58332442 After merging this PR to wicket-6.x the following tests fail: ``` Failed tests: optionPlaceholderDecode1(org.apache.wicket.core.request.mapper.MountedMapperTest) optionPlaceholderDecodeEagerMatchParameters(org.apache.wicket.core.request.mapper.MountedMapperTest) optionPlaceholderDecode2(org.apache.wicket.core.request.mapper.MountedMapperTest) optionPlaceholderDecode3(org.apache.wicket.core.request.mapper.MountedMapperTest) optionPlaceholderDecodeWithIndexParams(org.apache.wicket.core.request.mapper.MountedMapperTest) optionPlaceholderEncode1(org.apache.wicket.core.request.mapper.MountedMapperTest): expected:some/[p1/path/p2/i1/i2?a=bb=c] but was:some/[/i1/i2?a=bb=cparam1=p1param2=p2] optionPlaceholderEncode2(org.apache.wicket.core.request.mapper.MountedMapperTest): expected:some/[path/p2/p3/i1/i2?a=bb=c] but was:some/[/i1/i2?a=bb=cparam2=p2param3=p3] ``` I'll investigate. Url.parse/toString should support fragment -- Key: WICKET-5717 URL: https://issues.apache.org/jira/browse/WICKET-5717 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.17.0 Reporter: Guillaume Smet Assignee: Martin Grigorov Attachments: redirect-url-anchor.tar.gz Hi, Starting with Wicket 6.16, we have issues redirecting to an absolute URL containing a fragment: the # is escaped by Wicket. Changes in the commit https://fisheye6.atlassian.com/changelog/wicket-git?cs=e1f29e90ff3a35e117bb3ddc5ee2aefd900c13c8 are causing the regression but as far as we can see, the commit is not the problem: the issue is that Url.parse then toString encodes the anchor. Before this commit, as we were using an absolute Url, we were in the case where the Url wasn't escaped. We think the right fix would be to make org.apache.wicket.request.Url anchor aware. Pull request to come. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5717) Url.parse/toString should support fragment
[ https://issues.apache.org/jira/browse/WICKET-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14163299#comment-14163299 ] ASF subversion and git services commented on WICKET-5717: - Commit 58fa34bc8ff9b531b61e9258ac33480296cc66f6 in wicket's branch refs/heads/wicket-6.x from [~gsmet] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=58fa34b ] WICKET-5717 Support fragment in Url parse and toString (cherry picked from commit ca70ec70a0b7ea20f51db849ea866aa7c3d6cd11) Url.parse/toString should support fragment -- Key: WICKET-5717 URL: https://issues.apache.org/jira/browse/WICKET-5717 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.17.0 Reporter: Guillaume Smet Assignee: Martin Grigorov Attachments: redirect-url-anchor.tar.gz Hi, Starting with Wicket 6.16, we have issues redirecting to an absolute URL containing a fragment: the # is escaped by Wicket. Changes in the commit https://fisheye6.atlassian.com/changelog/wicket-git?cs=e1f29e90ff3a35e117bb3ddc5ee2aefd900c13c8 are causing the regression but as far as we can see, the commit is not the problem: the issue is that Url.parse then toString encodes the anchor. Before this commit, as we were using an absolute Url, we were in the case where the Url wasn't escaped. We think the right fix would be to make org.apache.wicket.request.Url anchor aware. Pull request to come. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5717) Url.parse/toString should support fragment
[ https://issues.apache.org/jira/browse/WICKET-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14163304#comment-14163304 ] ASF subversion and git services commented on WICKET-5717: - Commit 8489bcbebfef5a5096b24c0543d2b767c98f325e in wicket's branch refs/heads/master from [~gsmet] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=8489bcb ] WICKET-5717 Support fragment in Url parse and toString (cherry picked from commit ca70ec70a0b7ea20f51db849ea866aa7c3d6cd11) Url.parse/toString should support fragment -- Key: WICKET-5717 URL: https://issues.apache.org/jira/browse/WICKET-5717 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.17.0 Reporter: Guillaume Smet Assignee: Martin Grigorov Fix For: 6.18.0, 7.0.0-M4 Attachments: redirect-url-anchor.tar.gz Hi, Starting with Wicket 6.16, we have issues redirecting to an absolute URL containing a fragment: the # is escaped by Wicket. Changes in the commit https://fisheye6.atlassian.com/changelog/wicket-git?cs=e1f29e90ff3a35e117bb3ddc5ee2aefd900c13c8 are causing the regression but as far as we can see, the commit is not the problem: the issue is that Url.parse then toString encodes the anchor. Before this commit, as we were using an absolute Url, we were in the case where the Url wasn't escaped. We think the right fix would be to make org.apache.wicket.request.Url anchor aware. Pull request to come. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5717) Url.parse/toString should support fragment
[ https://issues.apache.org/jira/browse/WICKET-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14157270#comment-14157270 ] ASF GitHub Bot commented on WICKET-5717: GitHub user gsmet opened a pull request: https://github.com/apache/wicket/pull/78 WICKET-5717 Support fragment in Url parse and toString Note: this PR is for the wicket-6.x branch. You can merge this pull request into a Git repository by running: $ git pull https://github.com/openwide-java/wicket support-fragment-in-url Alternatively you can review and apply these changes as the patch at: https://github.com/apache/wicket/pull/78.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #78 commit f35ae430ee741ca7dd517ed09647d1a28a1f Author: Guillaume Smet guillaume.s...@gmail.com Date: 2014-09-30T23:42:27Z WICKET-5717 Support fragment in Url parse and toString Url.parse/toString should support fragment -- Key: WICKET-5717 URL: https://issues.apache.org/jira/browse/WICKET-5717 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.17.0 Reporter: Guillaume Smet Attachments: redirect-url-anchor.tar.gz Hi, Starting with Wicket 6.16, we have issues redirecting to an absolute URL containing a fragment: the # is escaped by Wicket. Changes in the commit https://fisheye6.atlassian.com/changelog/wicket-git?cs=e1f29e90ff3a35e117bb3ddc5ee2aefd900c13c8 are causing the regression but as far as we can see, the commit is not the problem: the issue is that Url.parse then toString encodes the anchor. Before this commit, as we were using an absolute Url, we were in the case where the Url wasn't escaped. We think the right fix would be to make org.apache.wicket.request.Url anchor aware. Pull request to come. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
