[jira] [Commented] (WICKET-5801) Responsive Images
[ https://issues.apache.org/jira/browse/WICKET-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14312061#comment-14312061 ] Martin Grigorov commented on WICKET-5801: - Check master branch (latest version). I've fixed this before merging ;-) Responsive Images - Key: WICKET-5801 URL: https://issues.apache.org/jira/browse/WICKET-5801 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 7.0.0-M5 Reporter: Tobias Soloschenko Assignee: Martin Grigorov Labels: features Fix For: 7.0.0-M6 It would be nice to provide the functionality of responsive images to wicket: http://responsiveimages.org/ http://www.w3.org/html/wg/drafts/html/master/embedded-content.html#introduction-0 This would require to refactor the Image class and provide some new classes for picture and source tags. A documentation / implementation is provided here: https://github.com/klopfdreh/wicket-components-playground The changes are source backward compatible to the current implementation of Wicket 6 / 7 and there are also some junit tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5801) Responsive Images
[ https://issues.apache.org/jira/browse/WICKET-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14312065#comment-14312065 ] Tobias Soloschenko commented on WICKET-5801: My fault - I looked into the initial commit. :-) Responsive Images - Key: WICKET-5801 URL: https://issues.apache.org/jira/browse/WICKET-5801 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 7.0.0-M5 Reporter: Tobias Soloschenko Assignee: Martin Grigorov Labels: features Fix For: 7.0.0-M6 It would be nice to provide the functionality of responsive images to wicket: http://responsiveimages.org/ http://www.w3.org/html/wg/drafts/html/master/embedded-content.html#introduction-0 This would require to refactor the Image class and provide some new classes for picture and source tags. A documentation / implementation is provided here: https://github.com/klopfdreh/wicket-components-playground The changes are source backward compatible to the current implementation of Wicket 6 / 7 and there are also some junit tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5801) Responsive Images
[ https://issues.apache.org/jira/browse/WICKET-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14312054#comment-14312054 ] Tobias Soloschenko commented on WICKET-5801: Hi, I saw that there are two issues left regarding the example: https://github.com/apache/wicket/blob/0880713fa15ee8ce67c8005759312964609f5e7c/wicket-examples/src/main/java/org/apache/wicket/examples/images/Home.java#L122-126 The images are written in lower cases. Responsive Images - Key: WICKET-5801 URL: https://issues.apache.org/jira/browse/WICKET-5801 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 7.0.0-M5 Reporter: Tobias Soloschenko Assignee: Martin Grigorov Labels: features Fix For: 7.0.0-M6 It would be nice to provide the functionality of responsive images to wicket: http://responsiveimages.org/ http://www.w3.org/html/wg/drafts/html/master/embedded-content.html#introduction-0 This would require to refactor the Image class and provide some new classes for picture and source tags. A documentation / implementation is provided here: https://github.com/klopfdreh/wicket-components-playground The changes are source backward compatible to the current implementation of Wicket 6 / 7 and there are also some junit tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5801) Responsive Images
[ https://issues.apache.org/jira/browse/WICKET-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14300189#comment-14300189 ] ASF subversion and git services commented on WICKET-5801: - Commit 73c6f52b90f570c6401ee479f8463b13e541aa6a in wicket's branch refs/heads/master from [~mgrigorov] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=73c6f52 ] WICKET-5801 Revert the existence of Image#setImageResourceReference(ResourceReference) Swap the order of the parameters in #setImageResourceReference(PageParameters, ResourceReference) to #setImageResourceReference(ResourceReference, PageParameters). There is no need of API break here. The new #setImageResourceReferences(PageParameters, ResourceReference...) needs to have this signature because varargs have to be the last argument Responsive Images - Key: WICKET-5801 URL: https://issues.apache.org/jira/browse/WICKET-5801 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 7.0.0-M5 Reporter: Tobias Soloschenko Assignee: Martin Grigorov Labels: features Fix For: 7.0.0 It would be nice to provide the functionality of responsive images to wicket: http://responsiveimages.org/ http://www.w3.org/html/wg/drafts/html/master/embedded-content.html#introduction-0 This would require to refactor the Image class and provide some new classes for picture and source tags. A documentation / implementation is provided here: https://github.com/klopfdreh/wicket-components-playground The changes are source backward compatible to the current implementation of Wicket 6 / 7 and there are also some junit tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5801) Responsive Images
[ https://issues.apache.org/jira/browse/WICKET-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295386#comment-14295386 ] ASF subversion and git services commented on WICKET-5801: - Commit 6d0eae5f4f8fcfd9e56dc2bf6115feb970d32a82 in wicket's branch refs/heads/master from [~mgrigorov] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=6d0eae5 ] WICKET-5801 Responsive Images Follow Wicket code style. Java 7 diamonds Fix the demo. Responsive Images - Key: WICKET-5801 URL: https://issues.apache.org/jira/browse/WICKET-5801 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 7.0.0-M5 Reporter: Tobias Soloschenko Labels: features It would be nice to provide the functionality of responsive images to wicket: http://responsiveimages.org/ http://www.w3.org/html/wg/drafts/html/master/embedded-content.html#introduction-0 This would require to refactor the Image class and provide some new classes for picture and source tags. A documentation / implementation is provided here: https://github.com/klopfdreh/wicket-components-playground The changes are source backward compatible to the current implementation of Wicket 6 / 7 and there are also some junit tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5801) Responsive Images
[ https://issues.apache.org/jira/browse/WICKET-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295842#comment-14295842 ] ASF GitHub Bot commented on WICKET-5801: Github user klopfdreh closed the pull request at: https://github.com/apache/wicket/pull/85 Responsive Images - Key: WICKET-5801 URL: https://issues.apache.org/jira/browse/WICKET-5801 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 7.0.0-M5 Reporter: Tobias Soloschenko Assignee: Martin Grigorov Labels: features Fix For: 7.0.0 It would be nice to provide the functionality of responsive images to wicket: http://responsiveimages.org/ http://www.w3.org/html/wg/drafts/html/master/embedded-content.html#introduction-0 This would require to refactor the Image class and provide some new classes for picture and source tags. A documentation / implementation is provided here: https://github.com/klopfdreh/wicket-components-playground The changes are source backward compatible to the current implementation of Wicket 6 / 7 and there are also some junit tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5801) Responsive Images
[ https://issues.apache.org/jira/browse/WICKET-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295841#comment-14295841 ] ASF GitHub Bot commented on WICKET-5801: Github user klopfdreh commented on the pull request: https://github.com/apache/wicket/pull/85#issuecomment-71913385 Integrated. Thanks a lot! Responsive Images - Key: WICKET-5801 URL: https://issues.apache.org/jira/browse/WICKET-5801 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 7.0.0-M5 Reporter: Tobias Soloschenko Assignee: Martin Grigorov Labels: features Fix For: 7.0.0 It would be nice to provide the functionality of responsive images to wicket: http://responsiveimages.org/ http://www.w3.org/html/wg/drafts/html/master/embedded-content.html#introduction-0 This would require to refactor the Image class and provide some new classes for picture and source tags. A documentation / implementation is provided here: https://github.com/klopfdreh/wicket-components-playground The changes are source backward compatible to the current implementation of Wicket 6 / 7 and there are also some junit tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5801) Responsive Images
[ https://issues.apache.org/jira/browse/WICKET-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14283170#comment-14283170 ] Tobias Soloschenko commented on WICKET-5801: Here it is: https://github.com/apache/wicket/pull/85 Responsive Images - Key: WICKET-5801 URL: https://issues.apache.org/jira/browse/WICKET-5801 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 7.0.0-M5, 6.19.0 Reporter: Tobias Soloschenko Labels: features It would be nice to provide the functionality of responsive images to wicket: http://responsiveimages.org/ http://www.w3.org/html/wg/drafts/html/master/embedded-content.html#introduction-0 This would require to refactor the Image class and provide some new classes for picture and source tags. The changes are backward compatible to the current implementation of Wicket 6 / 7 and there are also some junit tests. A documentation / implementation is provided here: https://github.com/klopfdreh/wicket-components-playground -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5801) Responsive Images
[ https://issues.apache.org/jira/browse/WICKET-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282409#comment-14282409 ] Tobias Soloschenko commented on WICKET-5801: Updated Affectes Version/s and added 6.19.0, because there is no breaking of the API. Responsive Images - Key: WICKET-5801 URL: https://issues.apache.org/jira/browse/WICKET-5801 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 7.0.0-M5, 6.19.0 Reporter: Tobias Soloschenko Labels: features It would be nice to provide the functionality of responsive images to wicket: http://responsiveimages.org/ http://www.w3.org/html/wg/drafts/html/master/embedded-content.html#introduction-0 This would require to refactor the Image class and provide some new classes for picture and source tags. I already did the work in a fork of wicket in the following commit: https://github.com/klopfdreh/wicket/commit/15283cb93238995c3fc3ed6bf4095fd0901318b0 The changes are backward compatible to the current implementation of Wicket 6 / 7 and there are also some junit tests. A documentation is provided here: https://github.com/klopfdreh/wicket-components-playground -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5801) Responsive Images
[ https://issues.apache.org/jira/browse/WICKET-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282758#comment-14282758 ] Martin Grigorov commented on WICKET-5801: - Please create a Pull Request against master branch. It will be easier to comment on it and apply it once it is ready. Also it would be nice if you move your demo to wicket-examples' org.apache.wicket.examples.images. Thanks! Responsive Images - Key: WICKET-5801 URL: https://issues.apache.org/jira/browse/WICKET-5801 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 7.0.0-M5, 6.19.0 Reporter: Tobias Soloschenko Labels: features It would be nice to provide the functionality of responsive images to wicket: http://responsiveimages.org/ http://www.w3.org/html/wg/drafts/html/master/embedded-content.html#introduction-0 This would require to refactor the Image class and provide some new classes for picture and source tags. I already did the work in a fork of wicket in the following commit: https://github.com/klopfdreh/wicket/commit/15283cb93238995c3fc3ed6bf4095fd0901318b0 The changes are backward compatible to the current implementation of Wicket 6 / 7 and there are also some junit tests. A documentation is provided here: https://github.com/klopfdreh/wicket-components-playground -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5801) Responsive Images
[ https://issues.apache.org/jira/browse/WICKET-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282777#comment-14282777 ] Tobias Soloschenko commented on WICKET-5801: Ok, I will create a pull request tomorrow afternoon and apply the examples to the pull request. Responsive Images - Key: WICKET-5801 URL: https://issues.apache.org/jira/browse/WICKET-5801 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 7.0.0-M5, 6.19.0 Reporter: Tobias Soloschenko Labels: features It would be nice to provide the functionality of responsive images to wicket: http://responsiveimages.org/ http://www.w3.org/html/wg/drafts/html/master/embedded-content.html#introduction-0 This would require to refactor the Image class and provide some new classes for picture and source tags. I already did the work in a fork of wicket in the following commit: https://github.com/klopfdreh/wicket/commit/15283cb93238995c3fc3ed6bf4095fd0901318b0 The changes are backward compatible to the current implementation of Wicket 6 / 7 and there are also some junit tests. A documentation is provided here: https://github.com/klopfdreh/wicket-components-playground -- This message was sent by Atlassian JIRA (v6.3.4#6332)
