[jira] [Commented] (WICKET-5828) PageProvider not serializable
[
https://issues.apache.org/jira/browse/WICKET-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309809#comment-14309809
]
ASF subversion and git services commented on WICKET-5828:
-
Commit 5c42e992b0cffbdd1e65cb7dbdf5633b156bb5b9 in wicket's branch
refs/heads/master from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=5c42e99 ]
Merge branch 'WICKET-5828' of https://github.com/klopfdreh/wicket into
pr-89-WICKET-5828
> PageProvider not serializable
> -
>
> Key: WICKET-5828
> URL: https://issues.apache.org/jira/browse/WICKET-5828
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 7.0.0-M4
>Reporter: Tore Åsen-Grøssereid
>
> Creating an InlineFrame for a Page gives ObjectCheckException: The object
> type is not Serializable!
> The PageProvider is not serializable.
> InlineFrame iframe = new InlineFrame( "iframe", new Page(){});
> add( iframe );
> should be enough to reproduce it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-5828) PageProvider not serializable
[
https://issues.apache.org/jira/browse/WICKET-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309807#comment-14309807
]
ASF subversion and git services commented on WICKET-5828:
-
Commit b7630fd160e6e710f1ed7cae72c65758b926d9ce in wicket's branch
refs/heads/master from klopfdreh
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=b7630fd ]
WICKET-5828 PageProvider not serializable
> PageProvider not serializable
> -
>
> Key: WICKET-5828
> URL: https://issues.apache.org/jira/browse/WICKET-5828
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 7.0.0-M4
>Reporter: Tore Åsen-Grøssereid
>
> Creating an InlineFrame for a Page gives ObjectCheckException: The object
> type is not Serializable!
> The PageProvider is not serializable.
> InlineFrame iframe = new InlineFrame( "iframe", new Page(){});
> add( iframe );
> should be enough to reproduce it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-5828) PageProvider not serializable
[
https://issues.apache.org/jira/browse/WICKET-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309810#comment-14309810
]
ASF subversion and git services commented on WICKET-5828:
-
Commit 5c42e992b0cffbdd1e65cb7dbdf5633b156bb5b9 in wicket's branch
refs/heads/master from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=5c42e99 ]
Merge branch 'WICKET-5828' of https://github.com/klopfdreh/wicket into
pr-89-WICKET-5828
> PageProvider not serializable
> -
>
> Key: WICKET-5828
> URL: https://issues.apache.org/jira/browse/WICKET-5828
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 7.0.0-M4
>Reporter: Tore Åsen-Grøssereid
>
> Creating an InlineFrame for a Page gives ObjectCheckException: The object
> type is not Serializable!
> The PageProvider is not serializable.
> InlineFrame iframe = new InlineFrame( "iframe", new Page(){});
> add( iframe );
> should be enough to reproduce it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-5828) PageProvider not serializable
[
https://issues.apache.org/jira/browse/WICKET-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309813#comment-14309813
]
ASF GitHub Bot commented on WICKET-5828:
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/89#issuecomment-73305327
Thank you, Tobias!
> PageProvider not serializable
> -
>
> Key: WICKET-5828
> URL: https://issues.apache.org/jira/browse/WICKET-5828
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 7.0.0-M4
>Reporter: Tore Åsen-Grøssereid
>
> Creating an InlineFrame for a Page gives ObjectCheckException: The object
> type is not Serializable!
> The PageProvider is not serializable.
> InlineFrame iframe = new InlineFrame( "iframe", new Page(){});
> add( iframe );
> should be enough to reproduce it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-5828) PageProvider not serializable
[
https://issues.apache.org/jira/browse/WICKET-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309811#comment-14309811
]
ASF GitHub Bot commented on WICKET-5828:
Github user asfgit closed the pull request at:
https://github.com/apache/wicket/pull/89
> PageProvider not serializable
> -
>
> Key: WICKET-5828
> URL: https://issues.apache.org/jira/browse/WICKET-5828
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 7.0.0-M4
>Reporter: Tore Åsen-Grøssereid
>
> Creating an InlineFrame for a Page gives ObjectCheckException: The object
> type is not Serializable!
> The PageProvider is not serializable.
> InlineFrame iframe = new InlineFrame( "iframe", new Page(){});
> add( iframe );
> should be enough to reproduce it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-5828) PageProvider not serializable
[
https://issues.apache.org/jira/browse/WICKET-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309750#comment-14309750
]
Tobias Soloschenko commented on WICKET-5828:
*click* ;-)
> PageProvider not serializable
> -
>
> Key: WICKET-5828
> URL: https://issues.apache.org/jira/browse/WICKET-5828
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 7.0.0-M4
>Reporter: Tore Åsen-Grøssereid
>
> Creating an InlineFrame for a Page gives ObjectCheckException: The object
> type is not Serializable!
> The PageProvider is not serializable.
> InlineFrame iframe = new InlineFrame( "iframe", new Page(){});
> add( iframe );
> should be enough to reproduce it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-5828) PageProvider not serializable
[
https://issues.apache.org/jira/browse/WICKET-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309743#comment-14309743
]
ASF GitHub Bot commented on WICKET-5828:
GitHub user klopfdreh opened a pull request:
https://github.com/apache/wicket/pull/89
WICKET-5828 PageProvider not serializable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/klopfdreh/wicket WICKET-5828
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/89.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #89
commit b7630fd160e6e710f1ed7cae72c65758b926d9ce
Author: klopfdreh
Date: 2015-02-06T19:40:13Z
WICKET-5828 PageProvider not serializable
> PageProvider not serializable
> -
>
> Key: WICKET-5828
> URL: https://issues.apache.org/jira/browse/WICKET-5828
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 7.0.0-M4
>Reporter: Tore Åsen-Grøssereid
>
> Creating an InlineFrame for a Page gives ObjectCheckException: The object
> type is not Serializable!
> The PageProvider is not serializable.
> InlineFrame iframe = new InlineFrame( "iframe", new Page(){});
> add( iframe );
> should be enough to reproduce it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-5828) PageProvider not serializable
[
https://issues.apache.org/jira/browse/WICKET-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307283#comment-14307283
]
Tobias Soloschenko commented on WICKET-5828:
Mh, I feel tricked, now ;-) - so PR or a commit from you?
> PageProvider not serializable
> -
>
> Key: WICKET-5828
> URL: https://issues.apache.org/jira/browse/WICKET-5828
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 7.0.0-M4
>Reporter: Tore Åsen-Grøssereid
>
> Creating an InlineFrame for a Page gives ObjectCheckException: The object
> type is not Serializable!
> The PageProvider is not serializable.
> InlineFrame iframe = new InlineFrame( "iframe", new Page(){});
> add( iframe );
> should be enough to reproduce it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-5828) PageProvider not serializable
[
https://issues.apache.org/jira/browse/WICKET-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307224#comment-14307224
]
Martin Grigorov commented on WICKET-5828:
-
I've expected this suggestion!
Just waited Tobias to make it :-)
I see no problems with it.
> PageProvider not serializable
> -
>
> Key: WICKET-5828
> URL: https://issues.apache.org/jira/browse/WICKET-5828
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 7.0.0-M4
>Reporter: Tore Åsen-Grøssereid
>
> Creating an InlineFrame for a Page gives ObjectCheckException: The object
> type is not Serializable!
> The PageProvider is not serializable.
> InlineFrame iframe = new InlineFrame( "iframe", new Page(){});
> add( iframe );
> should be enough to reproduce it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-5828) PageProvider not serializable
[
https://issues.apache.org/jira/browse/WICKET-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307216#comment-14307216
]
Tobias Soloschenko commented on WICKET-5828:
[~martin-g] Jep thats true, because of circular dependencies. You are right.
> PageProvider not serializable
> -
>
> Key: WICKET-5828
> URL: https://issues.apache.org/jira/browse/WICKET-5828
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 7.0.0-M4
>Reporter: Tore Åsen-Grøssereid
>
> Creating an InlineFrame for a Page gives ObjectCheckException: The object
> type is not Serializable!
> The PageProvider is not serializable.
> InlineFrame iframe = new InlineFrame( "iframe", new Page(){});
> add( iframe );
> should be enough to reproduce it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-5828) PageProvider not serializable
[
https://issues.apache.org/jira/browse/WICKET-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307215#comment-14307215
]
Sven Meier commented on WICKET-5828:
Why not declare pageInstance as transient? The pageId should be sufficient to
restore the page instance after deserialization.
> PageProvider not serializable
> -
>
> Key: WICKET-5828
> URL: https://issues.apache.org/jira/browse/WICKET-5828
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 7.0.0-M4
>Reporter: Tore Åsen-Grøssereid
>
> Creating an InlineFrame for a Page gives ObjectCheckException: The object
> type is not Serializable!
> The PageProvider is not serializable.
> InlineFrame iframe = new InlineFrame( "iframe", new Page(){});
> add( iframe );
> should be enough to reproduce it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-5828) PageProvider not serializable
[
https://issues.apache.org/jira/browse/WICKET-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307209#comment-14307209
]
Martin Grigorov commented on WICKET-5828:
-
It is a bad practice one page to keep a reference to another page.
It will be PageA->PageProvider->PageForInlineFrame, if PageProvider is used
with
https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/core/request/handler/PageProvider.java#L149.
> PageProvider not serializable
> -
>
> Key: WICKET-5828
> URL: https://issues.apache.org/jira/browse/WICKET-5828
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 7.0.0-M4
>Reporter: Tore Åsen-Grøssereid
>
> Creating an InlineFrame for a Page gives ObjectCheckException: The object
> type is not Serializable!
> The PageProvider is not serializable.
> InlineFrame iframe = new InlineFrame( "iframe", new Page(){});
> add( iframe );
> should be enough to reproduce it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-5828) PageProvider not serializable
[
https://issues.apache.org/jira/browse/WICKET-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307199#comment-14307199
]
Tore Åsen-Grøssereid commented on WICKET-5828:
--
Just tried to implement my own PageProvider like explained above, and that
worked as expected =)
> PageProvider not serializable
> -
>
> Key: WICKET-5828
> URL: https://issues.apache.org/jira/browse/WICKET-5828
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 7.0.0-M4
>Reporter: Tore Åsen-Grøssereid
>
> Creating an InlineFrame for a Page gives ObjectCheckException: The object
> type is not Serializable!
> The PageProvider is not serializable.
> InlineFrame iframe = new InlineFrame( "iframe", new Page(){});
> add( iframe );
> should be enough to reproduce it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-5828) PageProvider not serializable
[
https://issues.apache.org/jira/browse/WICKET-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307182#comment-14307182
]
Tobias Soloschenko commented on WICKET-5828:
Thanks for the explanation, then set
org.apache.wicket.core.request.handler.PageProvider to:
public class PageProvider implements IPageProvider, IClusterable with a default
serializable id.
I checked the class attributes. They are all serializable / clusterable.
> PageProvider not serializable
> -
>
> Key: WICKET-5828
> URL: https://issues.apache.org/jira/browse/WICKET-5828
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 7.0.0-M4
>Reporter: Tore Åsen-Grøssereid
>
> Creating an InlineFrame for a Page gives ObjectCheckException: The object
> type is not Serializable!
> The PageProvider is not serializable.
> InlineFrame iframe = new InlineFrame( "iframe", new Page(){});
> add( iframe );
> should be enough to reproduce it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-5828) PageProvider not serializable
[
https://issues.apache.org/jira/browse/WICKET-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307174#comment-14307174
]
Martin Grigorov commented on WICKET-5828:
-
Flow:
- PageA has InlineFrame
- the user navigates from PageA, to PageB, ..., to PageX
- then the user navigates back to PageA
- PageA is loaded from the disk
- #onComponentTag() is executed on every render, so #onLinkClicked() is
executed and => NPE
> PageProvider not serializable
> -
>
> Key: WICKET-5828
> URL: https://issues.apache.org/jira/browse/WICKET-5828
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 7.0.0-M4
>Reporter: Tore Åsen-Grøssereid
>
> Creating an InlineFrame for a Page gives ObjectCheckException: The object
> type is not Serializable!
> The PageProvider is not serializable.
> InlineFrame iframe = new InlineFrame( "iframe", new Page(){});
> add( iframe );
> should be enough to reproduce it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-5828) PageProvider not serializable
[
https://issues.apache.org/jira/browse/WICKET-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307163#comment-14307163
]
Tobias Soloschenko commented on WICKET-5828:
Mh, I think the PageProvider itself should not be serialized, but the code of
the PageProvider is executed and loads the page from disk - or am I wrong?
Code in which the pageProvider is used:
@Override
public final void onLinkClicked()
{
setResponsePage(pageProvider.getPageInstance());
}
> PageProvider not serializable
> -
>
> Key: WICKET-5828
> URL: https://issues.apache.org/jira/browse/WICKET-5828
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 7.0.0-M4
>Reporter: Tore Åsen-Grøssereid
>
> Creating an InlineFrame for a Page gives ObjectCheckException: The object
> type is not Serializable!
> The PageProvider is not serializable.
> InlineFrame iframe = new InlineFrame( "iframe", new Page(){});
> add( iframe );
> should be enough to reproduce it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-5828) PageProvider not serializable
[
https://issues.apache.org/jira/browse/WICKET-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307157#comment-14307157
]
Martin Grigorov commented on WICKET-5828:
-
What if the page is loaded from the page storage (disk) ?
This will break with NullPointerException.
> PageProvider not serializable
> -
>
> Key: WICKET-5828
> URL: https://issues.apache.org/jira/browse/WICKET-5828
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 7.0.0-M4
>Reporter: Tore Åsen-Grøssereid
>
> Creating an InlineFrame for a Page gives ObjectCheckException: The object
> type is not Serializable!
> The PageProvider is not serializable.
> InlineFrame iframe = new InlineFrame( "iframe", new Page(){});
> add( iframe );
> should be enough to reproduce it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-5828) PageProvider not serializable
[
https://issues.apache.org/jira/browse/WICKET-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307149#comment-14307149
]
Tobias Soloschenko commented on WICKET-5828:
I checked this ticket - the PageProvider can be set to transient to solve this
issue:
private transient final IPageProvider pageProvider;
> PageProvider not serializable
> -
>
> Key: WICKET-5828
> URL: https://issues.apache.org/jira/browse/WICKET-5828
> Project: Wicket
> Issue Type: Bug
>Affects Versions: 7.0.0-M4
>Reporter: Tore Åsen-Grøssereid
>
> Creating an InlineFrame for a Page gives ObjectCheckException: The object
> type is not Serializable!
> The PageProvider is not serializable.
> InlineFrame iframe = new InlineFrame( "iframe", new Page(){});
> add( iframe );
> should be enough to reproduce it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
