[jira] [Commented] (WICKET-5835) InlineEnclosure doesn't call child.configure() before updating its visilbity
[
https://issues.apache.org/jira/browse/WICKET-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14322968#comment-14322968
]
Andrea Del Bene commented on WICKET-5835:
-
Thank you for the quickstart. To me this is not a problem with Wicket but with
the way you use to decide the visibility for the inline internal component.
Variable 'visible1' is used to determinate component's visibility but it is set
only when onConfigure is called, hence the component is always invisible to the
inline container.
Just replace the onconfigure method with this version of isVisible:
```java
public boolean isVisible() {
return visible1;
};
//@Override
//protected void onConfigure() {
//super.onConfigure();
//
//setVisible(visible1);
//}
```
in this way the internal component's visibility reflects the visible1 flag.
InlineEnclosure doesn't call child.configure() before updating its visilbity
Key: WICKET-5835
URL: https://issues.apache.org/jira/browse/WICKET-5835
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.19.0
Environment: Any
Reporter: Raoul Zander
Assignee: Andrea Del Bene
Priority: Minor
Labels: enclosure
Attachments: enclosure-quickstart.zip
org.apache.wicket.markup.html.internal.InlineEnclosure.updateVisibility()
should propably call child.configure() before the visibility of the
InlineEnclosure is set to the visibility of the child.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-5835) InlineEnclosure doesn't call child.configure() before updating its visilbity
[ https://issues.apache.org/jira/browse/WICKET-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14323139#comment-14323139 ] Andrea Del Bene commented on WICKET-5835: - Thank you for your clarification, I think now I get the picture... InlineEnclosure doesn't call child.configure() before updating its visilbity Key: WICKET-5835 URL: https://issues.apache.org/jira/browse/WICKET-5835 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.19.0 Environment: Any Reporter: Raoul Zander Assignee: Andrea Del Bene Priority: Minor Labels: enclosure Attachments: enclosure-quickstart.zip org.apache.wicket.markup.html.internal.InlineEnclosure.updateVisibility() should propably call child.configure() before the visibility of the InlineEnclosure is set to the visibility of the child. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5835) InlineEnclosure doesn't call child.configure() before updating its visilbity
[ https://issues.apache.org/jira/browse/WICKET-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14323268#comment-14323268 ] Andrea Del Bene commented on WICKET-5835: - An the answer is in the next javadoc line :-) NOTE: If component's visibility or another property depends on another component you may call other.configure() followed by other.isVisible() as mentioned in configure() javadoc. InlineEnclosure doesn't call child.configure() before updating its visilbity Key: WICKET-5835 URL: https://issues.apache.org/jira/browse/WICKET-5835 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.19.0 Environment: Any Reporter: Raoul Zander Assignee: Andrea Del Bene Priority: Minor Labels: enclosure Attachments: enclosure-quickstart.zip org.apache.wicket.markup.html.internal.InlineEnclosure.updateVisibility() should propably call child.configure() before the visibility of the InlineEnclosure is set to the visibility of the child. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5835) InlineEnclosure doesn't call child.configure() before updating its visilbity
[ https://issues.apache.org/jira/browse/WICKET-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14323276#comment-14323276 ] ASF subversion and git services commented on WICKET-5835: - Commit c97e3f4b0e7c7300c41d4608547d8bd16f37498f in wicket's branch refs/heads/master from [~bitstorm] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=c97e3f4 ] WICKET-5835 InlineEnclosure doesn't call child.configure() before updating its visilbity InlineEnclosure doesn't call child.configure() before updating its visilbity Key: WICKET-5835 URL: https://issues.apache.org/jira/browse/WICKET-5835 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 7.0.0-M5, 6.19.0 Environment: Any Reporter: Raoul Zander Assignee: Andrea Del Bene Priority: Minor Labels: enclosure Fix For: 6.20.0, 7.0.0-M6 Attachments: enclosure-quickstart.zip org.apache.wicket.markup.html.internal.InlineEnclosure.updateVisibility() should propably call child.configure() before the visibility of the InlineEnclosure is set to the visibility of the child. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5835) InlineEnclosure doesn't call child.configure() before updating its visilbity
[ https://issues.apache.org/jira/browse/WICKET-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14323287#comment-14323287 ] ASF subversion and git services commented on WICKET-5835: - Commit 3d5b261577d79afd74a274d7cffb20c031b4dac1 in wicket's branch refs/heads/wicket-6.x from [~bitstorm] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=3d5b261 ] WICKET-5835 InlineEnclosure doesn't call child.configure() before updating its visilbity InlineEnclosure doesn't call child.configure() before updating its visilbity Key: WICKET-5835 URL: https://issues.apache.org/jira/browse/WICKET-5835 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 7.0.0-M5, 6.19.0 Environment: Any Reporter: Raoul Zander Assignee: Andrea Del Bene Priority: Minor Labels: enclosure Fix For: 6.20.0, 7.0.0-M6 Attachments: enclosure-quickstart.zip org.apache.wicket.markup.html.internal.InlineEnclosure.updateVisibility() should propably call child.configure() before the visibility of the InlineEnclosure is set to the visibility of the child. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-5835) InlineEnclosure doesn't call child.configure() before updating its visilbity
[ https://issues.apache.org/jira/browse/WICKET-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14320322#comment-14320322 ] Andrea Del Bene commented on WICKET-5835: - Hi, could you provide a quickstart or some code that shows how this can create a problem or a wrong behavior? InlineEnclosure doesn't call child.configure() before updating its visilbity Key: WICKET-5835 URL: https://issues.apache.org/jira/browse/WICKET-5835 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 6.19.0 Environment: Any Reporter: Raoul Zander Priority: Minor Labels: enclosure org.apache.wicket.markup.html.internal.InlineEnclosure.updateVisibility() should propably call child.configure() before the visibility of the InlineEnclosure is set to the visibility of the child. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
