[jira] [Commented] (WICKET-6001) Exception raised while refreshing a page with queued components missing in the markup
[ https://issues.apache.org/jira/browse/WICKET-6001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15012254#comment-15012254 ] ASF subversion and git services commented on WICKET-6001: - Commit 525995ec9dbdbea226c370e410aaf1ad81aaf498 in wicket's branch refs/heads/wicket-7.x from [~mgrigorov] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=525995e ] WICKET-6001 Exception raised while refreshing a page with queued components missing in the markup Check that there is an Application thread local first. We've been bitten by such assumptions several times > Exception raised while refreshing a page with queued components missing in > the markup > - > > Key: WICKET-6001 > URL: https://issues.apache.org/jira/browse/WICKET-6001 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.0.0 >Reporter: Palancher aurélien >Assignee: Andrea Del Bene > Fix For: 7.2.0, 8.0.0-M1 > > Attachments: myproject.war > > > An exception is raised when refreshing a page or panel containing queued > components which are missing in the markup. > We can omit queued components in the markup when the page is created the > first time but we cannot refresh it -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6001) Exception raised while refreshing a page with queued components missing in the markup
[ https://issues.apache.org/jira/browse/WICKET-6001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15012252#comment-15012252 ] ASF subversion and git services commented on WICKET-6001: - Commit c6fe37d38f9d961a4227480bbee1ac2ed1d24599 in wicket's branch refs/heads/master from [~mgrigorov] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=c6fe37d ] WICKET-6001 Exception raised while refreshing a page with queued components missing in the markup Check that there is an Application thread local first. We've been bitten by such assumptions several times > Exception raised while refreshing a page with queued components missing in > the markup > - > > Key: WICKET-6001 > URL: https://issues.apache.org/jira/browse/WICKET-6001 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.0.0 >Reporter: Palancher aurélien >Assignee: Andrea Del Bene > Fix For: 7.2.0, 8.0.0-M1 > > Attachments: myproject.war > > > An exception is raised when refreshing a page or panel containing queued > components which are missing in the markup. > We can omit queued components in the markup when the page is created the > first time but we cannot refresh it -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6001) Exception raised while refreshing a page with queued components missing in the markup
[ https://issues.apache.org/jira/browse/WICKET-6001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006815#comment-15006815 ] ASF subversion and git services commented on WICKET-6001: - Commit 8f42d7613c107581556534656f62e985f9e8a72a in wicket's branch refs/heads/wicket-7.x from [~bitstorm] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=8f42d76 ] WICKET-6001 Exception raised while refreshing a page with queued components missing in the markup > Exception raised while refreshing a page with queued components missing in > the markup > - > > Key: WICKET-6001 > URL: https://issues.apache.org/jira/browse/WICKET-6001 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.0.0 >Reporter: Palancher aurélien >Assignee: Andrea Del Bene > Fix For: 7.2.0, 8.0.0-M1 > > Attachments: myproject.war > > > An exception is raised when refreshing a page or panel containing queued > components which are missing in the markup. > We can omit queued components in the markup when the page is created the > first time but we cannot refresh it -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6001) Exception raised while refreshing a page with queued components missing in the markup
[ https://issues.apache.org/jira/browse/WICKET-6001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006576#comment-15006576 ] ASF subversion and git services commented on WICKET-6001: - Commit 67b53cf0de66fb8f41a10831e96168b29ab240f2 in wicket's branch refs/heads/master from [~bitstorm] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=67b53cf ] WICKET-6001 Exception raised while refreshing a page with queued components missing in the markup > Exception raised while refreshing a page with queued components missing in > the markup > - > > Key: WICKET-6001 > URL: https://issues.apache.org/jira/browse/WICKET-6001 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.0.0 >Reporter: Palancher aurélien >Assignee: Andrea Del Bene > Attachments: myproject.war > > > An exception is raised when refreshing a page or panel containing queued > components which are missing in the markup. > We can omit queued components in the markup when the page is created the > first time but we cannot refresh it -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6001) Exception raised while refreshing a page with queued components missing in the markup
[ https://issues.apache.org/jira/browse/WICKET-6001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14996233#comment-14996233 ] Martin Grigorov commented on WICKET-6001: - #onDetach() is called **after** writing the response headers to the browser in case of disabled response buffering. I guess we can check whether org.apache.wicket.settings.RequestCycleSettings#getBufferResponse() returns true and re-throw the exception in this case. Should be tested! > Exception raised while refreshing a page with queued components missing in > the markup > - > > Key: WICKET-6001 > URL: https://issues.apache.org/jira/browse/WICKET-6001 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.0.0 >Reporter: Palancher aurélien >Assignee: Andrea Del Bene > Attachments: myproject.war > > > An exception is raised when refreshing a page or panel containing queued > components which are missing in the markup. > We can omit queued components in the markup when the page is created the > first time but we cannot refresh it -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6001) Exception raised while refreshing a page with queued components missing in the markup
[ https://issues.apache.org/jira/browse/WICKET-6001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14995360#comment-14995360 ] Andrea Del Bene commented on WICKET-6001: - Well, I think the title of this issue is a little bit misleading. The problem is not about component queueing working bad. The really problem is that the exception is not re-throw and, as a result, it goes unnoticed by user. If the same exception (thrown by MarkupContainer#onDetach) occurs during rendering phase, it's correctly displayed to user. I just asked you if my proposed change could break something you did in your commit. > Exception raised while refreshing a page with queued components missing in > the markup > - > > Key: WICKET-6001 > URL: https://issues.apache.org/jira/browse/WICKET-6001 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.0.0 >Reporter: Palancher aurélien >Assignee: Andrea Del Bene > Attachments: myproject.war > > > An exception is raised when refreshing a page or panel containing queued > components which are missing in the markup. > We can omit queued components in the markup when the page is created the > first time but we cannot refresh it -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6001) Exception raised while refreshing a page with queued components missing in the markup
[ https://issues.apache.org/jira/browse/WICKET-6001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14995279#comment-14995279 ] Martin Grigorov commented on WICKET-6001: - I've changed it because it is bad practice to catch Throwable. It will catch Error too, e.g. OutOfMemoryError, ThreadDeath, VirtualMachineError, and those are not recoverable. How this breaks the component queueing? What happens after the re-throw of the runtime exception? > Exception raised while refreshing a page with queued components missing in > the markup > - > > Key: WICKET-6001 > URL: https://issues.apache.org/jira/browse/WICKET-6001 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.0.0 >Reporter: Palancher aurélien >Assignee: Andrea Del Bene > Attachments: myproject.war > > > An exception is raised when refreshing a page or panel containing queued > components which are missing in the markup. > We can omit queued components in the markup when the page is created the > first time but we cannot refresh it -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6001) Exception raised while refreshing a page with queued components missing in the markup
[
https://issues.apache.org/jira/browse/WICKET-6001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14995277#comment-14995277
]
Andrea Del Bene commented on WICKET-6001:
-
I see your war contains also source files so I could build a quickstart with
them. A quickstart is much more helpful to spot an issue as we can see the code.
[~mgrigorov]
the problem is inside RequestHandlerStack#detach(). Every exception is caught
and silently logged. I see you have changed the try/catch statement with this:
https://git-wip-us.apache.org/repos/asf/wicket/repo?p=wicket.git;a=commitdiff;h=a5954823353f20a6157156704ae91d6067a1f5c8
A possible solution for this current issue could be adding another catch block
for RuntimeException:
{code}
try
{
detach(handler);
}
catch (RuntimeException exception)
{
throw exception;
}
catch (Exception exception)
{
log.error("Error detaching RequestHandler",
exception);
}
{code}
Could be this a problem in your opinion?
> Exception raised while refreshing a page with queued components missing in
> the markup
> -
>
> Key: WICKET-6001
> URL: https://issues.apache.org/jira/browse/WICKET-6001
> Project: Wicket
> Issue Type: Bug
> Components: wicket
>Affects Versions: 7.0.0
>Reporter: Palancher aurélien
>Assignee: Andrea Del Bene
> Attachments: myproject.war
>
>
> An exception is raised when refreshing a page or panel containing queued
> components which are missing in the markup.
> We can omit queued components in the markup when the page is created the
> first time but we cannot refresh it
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (WICKET-6001) Exception raised while refreshing a page with queued components missing in the markup
[ https://issues.apache.org/jira/browse/WICKET-6001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14995153#comment-14995153 ] Palancher aurélien commented on WICKET-6001: what about the attachment war file ? doesn't it reproduce the problem ? > Exception raised while refreshing a page with queued components missing in > the markup > - > > Key: WICKET-6001 > URL: https://issues.apache.org/jira/browse/WICKET-6001 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.0.0 >Reporter: Palancher aurélien >Assignee: Andrea Del Bene > Attachments: myproject.war > > > An exception is raised when refreshing a page or panel containing queued > components which are missing in the markup. > We can omit queued components in the markup when the page is created the > first time but we cannot refresh it -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6001) Exception raised while refreshing a page with queued components missing in the markup
[ https://issues.apache.org/jira/browse/WICKET-6001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14988103#comment-14988103 ] Andrea Del Bene commented on WICKET-6001: - Hi, could you provide a quickstart (with source code) that reproduces the problem? > Exception raised while refreshing a page with queued components missing in > the markup > - > > Key: WICKET-6001 > URL: https://issues.apache.org/jira/browse/WICKET-6001 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.0.0 >Reporter: Palancher aurélien >Assignee: Andrea Del Bene > Attachments: myproject.war > > > An exception is raised when refreshing a page or panel containing queued > components which are missing in the markup. > We can omit queued components in the markup when the page is created the > first time but we cannot refresh it -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (WICKET-6001) Exception raised while refreshing a page with queued components missing in the markup
[ https://issues.apache.org/jira/browse/WICKET-6001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14959933#comment-14959933 ] Palancher aurélien commented on WICKET-6001: in myproject.war : 2 links refresh 2 containers. The first one contains a listview with 2 labels (one is missing) and the second one contains a missing label. Hitting F5 or clicking on the links generate the exception > Exception raised while refreshing a page with queued components missing in > the markup > - > > Key: WICKET-6001 > URL: https://issues.apache.org/jira/browse/WICKET-6001 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 7.0.0 >Reporter: Palancher aurélien > Attachments: myproject.war > > > An exception is raised when refreshing a page or panel containing queued > components which are missing in the markup. > We can omit queued components in the markup when the page is created the > first time but we cannot refresh it -- This message was sent by Atlassian JIRA (v6.3.4#6332)
