[jira] [Commented] (WICKET-6435) WicketTester should provide assertExists and assertNotExists methods
[
https://issues.apache.org/jira/browse/WICKET-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681542#comment-16681542
]
ASF subversion and git services commented on WICKET-6435:
-
Commit f7bb3a05059a3b7d7af022e4772f3b332ed9ab11 in wicket's branch
refs/heads/WICKET-6563 from Martin Tzvetanov Grigorov
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=f7bb3a0 ]
WICKET-6435 WicketTester should provide assertExists and assertNotExists methods
Rename assertAbsent to assertNotExists.
Make assertExists and assertNotExists 'public'
> WicketTester should provide assertExists and assertNotExists methods
>
>
> Key: WICKET-6435
> URL: https://issues.apache.org/jira/browse/WICKET-6435
> Project: Wicket
> Issue Type: Improvement
>Reporter: Kamil
>Assignee: Martin Grigorov
>Priority: Major
> Fix For: 8.2.0, 9.0.0
>
>
> BaseWicketTester has:
> {code}
> private Component assertExists(final String path)
> {code}
> which is unfortunately private and doesn't provide contrary method.
> These methods are very important if you want to properly test code which is
> using Fragments: one Fragment is being added at time (exist) while another is
> not added (notExist)
> Could you please make assertExists public and add assertNotExists method?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WICKET-6435) WicketTester should provide assertExists and assertNotExists methods
[
https://issues.apache.org/jira/browse/WICKET-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681541#comment-16681541
]
ASF subversion and git services commented on WICKET-6435:
-
Commit 88897690a0f30f306792c1c4478e3e9f010b0738 in wicket's branch
refs/heads/WICKET-6563 from [~Jezza]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=8889769 ]
WICKET-6435: Add assertAbsent to BaseWicketTester.
> WicketTester should provide assertExists and assertNotExists methods
>
>
> Key: WICKET-6435
> URL: https://issues.apache.org/jira/browse/WICKET-6435
> Project: Wicket
> Issue Type: Improvement
>Reporter: Kamil
>Assignee: Martin Grigorov
>Priority: Major
> Fix For: 8.2.0, 9.0.0
>
>
> BaseWicketTester has:
> {code}
> private Component assertExists(final String path)
> {code}
> which is unfortunately private and doesn't provide contrary method.
> These methods are very important if you want to properly test code which is
> using Fragments: one Fragment is being added at time (exist) while another is
> not added (notExist)
> Could you please make assertExists public and add assertNotExists method?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WICKET-6435) WicketTester should provide assertExists and assertNotExists methods
[
https://issues.apache.org/jira/browse/WICKET-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679414#comment-16679414
]
ASF subversion and git services commented on WICKET-6435:
-
Commit f7bb3a05059a3b7d7af022e4772f3b332ed9ab11 in wicket's branch
refs/heads/master from Martin Tzvetanov Grigorov
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=f7bb3a0 ]
WICKET-6435 WicketTester should provide assertExists and assertNotExists methods
Rename assertAbsent to assertNotExists.
Make assertExists and assertNotExists 'public'
> WicketTester should provide assertExists and assertNotExists methods
>
>
> Key: WICKET-6435
> URL: https://issues.apache.org/jira/browse/WICKET-6435
> Project: Wicket
> Issue Type: Improvement
>Reporter: Kamil
>Assignee: Martin Grigorov
>Priority: Major
> Fix For: 8.2.0, 9.0.0
>
>
> BaseWicketTester has:
> {code}
> private Component assertExists(final String path)
> {code}
> which is unfortunately private and doesn't provide contrary method.
> These methods are very important if you want to properly test code which is
> using Fragments: one Fragment is being added at time (exist) while another is
> not added (notExist)
> Could you please make assertExists public and add assertNotExists method?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WICKET-6435) WicketTester should provide assertExists and assertNotExists methods
[
https://issues.apache.org/jira/browse/WICKET-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679418#comment-16679418
]
ASF subversion and git services commented on WICKET-6435:
-
Commit 5f52a24e5e344d237858370565c082e04cb80c41 in wicket's branch
refs/heads/wicket-8.x from Martin Tzvetanov Grigorov
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=5f52a24 ]
WICKET-6435 WicketTester should provide assertExists and assertNotExists methods
Rename assertAbsent to assertNotExists.
Make assertExists and assertNotExists 'public'
(cherry picked from commit f7bb3a05059a3b7d7af022e4772f3b332ed9ab11)
> WicketTester should provide assertExists and assertNotExists methods
>
>
> Key: WICKET-6435
> URL: https://issues.apache.org/jira/browse/WICKET-6435
> Project: Wicket
> Issue Type: Improvement
>Reporter: Kamil
>Assignee: Martin Grigorov
>Priority: Major
> Fix For: 8.2.0, 9.0.0
>
>
> BaseWicketTester has:
> {code}
> private Component assertExists(final String path)
> {code}
> which is unfortunately private and doesn't provide contrary method.
> These methods are very important if you want to properly test code which is
> using Fragments: one Fragment is being added at time (exist) while another is
> not added (notExist)
> Could you please make assertExists public and add assertNotExists method?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WICKET-6435) WicketTester should provide assertExists and assertNotExists methods
[
https://issues.apache.org/jira/browse/WICKET-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678137#comment-16678137
]
ASF GitHub Bot commented on WICKET-6435:
Github user Jezza commented on the issue:
https://github.com/apache/wicket/pull/298
Glad I could help.
> WicketTester should provide assertExists and assertNotExists methods
>
>
> Key: WICKET-6435
> URL: https://issues.apache.org/jira/browse/WICKET-6435
> Project: Wicket
> Issue Type: Improvement
>Reporter: Kamil
>Assignee: Martin Grigorov
>Priority: Major
> Fix For: 8.2.0, 9.0.0
>
>
> BaseWicketTester has:
> {code}
> private Component assertExists(final String path)
> {code}
> which is unfortunately private and doesn't provide contrary method.
> These methods are very important if you want to properly test code which is
> using Fragments: one Fragment is being added at time (exist) while another is
> not added (notExist)
> Could you please make assertExists public and add assertNotExists method?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WICKET-6435) WicketTester should provide assertExists and assertNotExists methods
[
https://issues.apache.org/jira/browse/WICKET-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678136#comment-16678136
]
ASF GitHub Bot commented on WICKET-6435:
Github user Jezza closed the pull request at:
https://github.com/apache/wicket/pull/298
> WicketTester should provide assertExists and assertNotExists methods
>
>
> Key: WICKET-6435
> URL: https://issues.apache.org/jira/browse/WICKET-6435
> Project: Wicket
> Issue Type: Improvement
>Reporter: Kamil
>Assignee: Martin Grigorov
>Priority: Major
> Fix For: 8.2.0, 9.0.0
>
>
> BaseWicketTester has:
> {code}
> private Component assertExists(final String path)
> {code}
> which is unfortunately private and doesn't provide contrary method.
> These methods are very important if you want to properly test code which is
> using Fragments: one Fragment is being added at time (exist) while another is
> not added (notExist)
> Could you please make assertExists public and add assertNotExists method?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WICKET-6435) WicketTester should provide assertExists and assertNotExists methods
[
https://issues.apache.org/jira/browse/WICKET-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677933#comment-16677933
]
Kamil commented on WICKET-6435:
---
[~mgrigorov], [~Jezza]
I see that you added "assertExist" and "assertAbsent"
Wouldn't it be better to have one of these pairs:
"assertPresent / assertAbsent" or "assertExist / assertNotExist"
?
> WicketTester should provide assertExists and assertNotExists methods
>
>
> Key: WICKET-6435
> URL: https://issues.apache.org/jira/browse/WICKET-6435
> Project: Wicket
> Issue Type: Improvement
>Reporter: Kamil
>Assignee: Martin Grigorov
>Priority: Major
> Fix For: 8.2.0, 9.0.0
>
>
> BaseWicketTester has:
> {code}
> private Component assertExists(final String path)
> {code}
> which is unfortunately private and doesn't provide contrary method.
> These methods are very important if you want to properly test code which is
> using Fragments: one Fragment is being added at time (exist) while another is
> not added (notExist)
> Could you please make assertExists public and add assertNotExists method?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WICKET-6435) WicketTester should provide assertExists and assertNotExists methods
[
https://issues.apache.org/jira/browse/WICKET-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677833#comment-16677833
]
ASF GitHub Bot commented on WICKET-6435:
Github user martin-g commented on the issue:
https://github.com/apache/wicket/pull/298
I've merged the PR but due to merge conflict GitHub doesn't recognize the
commit automatically to close the PR.
@Jezza Please close the PR because we cannot do it ourselves.
Thank you for your help!
> WicketTester should provide assertExists and assertNotExists methods
>
>
> Key: WICKET-6435
> URL: https://issues.apache.org/jira/browse/WICKET-6435
> Project: Wicket
> Issue Type: Improvement
>Reporter: Kamil
>Priority: Major
>
> BaseWicketTester has:
> {code}
> private Component assertExists(final String path)
> {code}
> which is unfortunately private and doesn't provide contrary method.
> These methods are very important if you want to properly test code which is
> using Fragments: one Fragment is being added at time (exist) while another is
> not added (notExist)
> Could you please make assertExists public and add assertNotExists method?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WICKET-6435) WicketTester should provide assertExists and assertNotExists methods
[
https://issues.apache.org/jira/browse/WICKET-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677832#comment-16677832
]
ASF subversion and git services commented on WICKET-6435:
-
Commit a58d4f24fd284b712264bea053885e3979c06760 in wicket's branch
refs/heads/wicket-8.x from [~Jezza]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=a58d4f2 ]
WICKET-6435: Add assertAbsent to BaseWicketTester.
(cherry picked from commit 88897690a0f30f306792c1c4478e3e9f010b0738)
> WicketTester should provide assertExists and assertNotExists methods
>
>
> Key: WICKET-6435
> URL: https://issues.apache.org/jira/browse/WICKET-6435
> Project: Wicket
> Issue Type: Improvement
>Reporter: Kamil
>Priority: Major
>
> BaseWicketTester has:
> {code}
> private Component assertExists(final String path)
> {code}
> which is unfortunately private and doesn't provide contrary method.
> These methods are very important if you want to properly test code which is
> using Fragments: one Fragment is being added at time (exist) while another is
> not added (notExist)
> Could you please make assertExists public and add assertNotExists method?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WICKET-6435) WicketTester should provide assertExists and assertNotExists methods
[
https://issues.apache.org/jira/browse/WICKET-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677830#comment-16677830
]
ASF subversion and git services commented on WICKET-6435:
-
Commit 88897690a0f30f306792c1c4478e3e9f010b0738 in wicket's branch
refs/heads/master from [~Jezza]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=8889769 ]
WICKET-6435: Add assertAbsent to BaseWicketTester.
> WicketTester should provide assertExists and assertNotExists methods
>
>
> Key: WICKET-6435
> URL: https://issues.apache.org/jira/browse/WICKET-6435
> Project: Wicket
> Issue Type: Improvement
>Reporter: Kamil
>Priority: Major
>
> BaseWicketTester has:
> {code}
> private Component assertExists(final String path)
> {code}
> which is unfortunately private and doesn't provide contrary method.
> These methods are very important if you want to properly test code which is
> using Fragments: one Fragment is being added at time (exist) while another is
> not added (notExist)
> Could you please make assertExists public and add assertNotExists method?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WICKET-6435) WicketTester should provide assertExists and assertNotExists methods
[
https://issues.apache.org/jira/browse/WICKET-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652511#comment-16652511
]
ASF GitHub Bot commented on WICKET-6435:
GitHub user Jezza opened a pull request:
https://github.com/apache/wicket/pull/298
WICKET-6435: Add assertAbsent to BaseWicketTester.
Closes WICKET-6435
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jezza/wicket WICKET-6435
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/298.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #298
commit 57e01144e07d2c6135f375fc54c46319c45d0431
Author: Jezza
Date: 2018-10-16T21:56:22Z
WICKET-6435: Add assertAbsent to BaseWicketTester.
> WicketTester should provide assertExists and assertNotExists methods
>
>
> Key: WICKET-6435
> URL: https://issues.apache.org/jira/browse/WICKET-6435
> Project: Wicket
> Issue Type: Improvement
>Reporter: Kamil
>Priority: Major
>
> BaseWicketTester has:
> {code}
> private Component assertExists(final String path)
> {code}
> which is unfortunately private and doesn't provide contrary method.
> These methods are very important if you want to properly test code which is
> using Fragments: one Fragment is being added at time (exist) while another is
> not added (notExist)
> Could you please make assertExists public and add assertNotExists method?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WICKET-6435) WicketTester should provide assertExists and assertNotExists methods
[
https://issues.apache.org/jira/browse/WICKET-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153623#comment-16153623
]
Kamil commented on WICKET-6435:
---
Another use case of notExist is when I have a ListView which, depending on
conditions, will have on or two buttons.
Having notExist I could do:
{code}
wicketTester.assertComponent("test:linkContainer:0:button",
AjaxLink.class);
wicketTester.assertVisible("test:linkContainer:0:button");
wicketTester.assertNotExist("test:linkContainer:1:button");
{code}
> WicketTester should provide assertExists and assertNotExists methods
>
>
> Key: WICKET-6435
> URL: https://issues.apache.org/jira/browse/WICKET-6435
> Project: Wicket
> Issue Type: Improvement
>Reporter: Kamil
>
> BaseWicketTester has:
> {code}
> private Component assertExists(final String path)
> {code}
> which is unfortunately private and doesn't provide contrary method.
> These methods are very important if you want to properly test code which is
> using Fragments: one Fragment is being added at time (exist) while another is
> not added (notExist)
> Could you please make assertExists public and add assertNotExists method?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
