[jira] [Commented] (WICKET-6463) Please add additional constructor to Roles

2017-09-04 Thread Kamil (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-6463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152892#comment-16152892
 ] 

Kamil commented on WICKET-6463:
---

Thank you, Martin

> Please add additional constructor to Roles
> --
>
> Key: WICKET-6463
> URL: https://issues.apache.org/jira/browse/WICKET-6463
> Project: Wicket
>  Issue Type: Improvement
>Reporter: Kamil
>Assignee: Martin Grigorov
>Priority: Trivial
> Fix For: 7.9.0, 8.0.0-M8
>
>
> org.apache.wicket.authroles.authorization.strategies.role.Roles can be 
> initialized using String[], but it should be also possible to initialize it 
> using any Collection (since it's already a HashSet, it should be 
> pretty strightforward)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (WICKET-6463) Please add additional constructor to Roles

2017-09-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-6463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152873#comment-16152873
 ] 

ASF subversion and git services commented on WICKET-6463:
-

Commit 13b600c30d681281f40f8300649f78e970b816a9 in wicket's branch 
refs/heads/wicket-7.x from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=13b600c ]

WICKET-6463 Please add additional constructor to Roles

(cherry picked from commit 1f805dd5af6d06e9209907f33f3c7ab4a4678e76)


> Please add additional constructor to Roles
> --
>
> Key: WICKET-6463
> URL: https://issues.apache.org/jira/browse/WICKET-6463
> Project: Wicket
>  Issue Type: Improvement
>Reporter: Kamil
>Assignee: Martin Grigorov
>Priority: Trivial
> Fix For: 7.9.0, 8.0.0-M8
>
>
> org.apache.wicket.authroles.authorization.strategies.role.Roles can be 
> initialized using String[], but it should be also possible to initialize it 
> using any Collection (since it's already a HashSet, it should be 
> pretty strightforward)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (WICKET-6463) Please add additional constructor to Roles

2017-09-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-6463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152872#comment-16152872
 ] 

ASF subversion and git services commented on WICKET-6463:
-

Commit 1f805dd5af6d06e9209907f33f3c7ab4a4678e76 in wicket's branch 
refs/heads/master from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=1f805dd ]

WICKET-6463 Please add additional constructor to Roles


> Please add additional constructor to Roles
> --
>
> Key: WICKET-6463
> URL: https://issues.apache.org/jira/browse/WICKET-6463
> Project: Wicket
>  Issue Type: Improvement
>Reporter: Kamil
>Assignee: Martin Grigorov
>Priority: Trivial
> Fix For: 7.9.0, 8.0.0-M8
>
>
> org.apache.wicket.authroles.authorization.strategies.role.Roles can be 
> initialized using String[], but it should be also possible to initialize it 
> using any Collection (since it's already a HashSet, it should be 
> pretty strightforward)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (WICKET-6463) Please add additional constructor to Roles

2017-09-04 Thread Kamil (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-6463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152781#comment-16152781
 ] 

Kamil commented on WICKET-6463:
---

By the way, AnnotationsRoleAuthorizationStrategy#L174 checks 
"isEmpty(acceptedRoles) || hasAny(acceptedRoles)" while hasAny(Roles) does 
exactly the same check

> Please add additional constructor to Roles
> --
>
> Key: WICKET-6463
> URL: https://issues.apache.org/jira/browse/WICKET-6463
> Project: Wicket
>  Issue Type: Improvement
>Reporter: Kamil
>Priority: Trivial
>
> org.apache.wicket.authroles.authorization.strategies.role.Roles can be 
> initialized using String[], but it should be also possible to initialize it 
> using any Collection (since it's already a HashSet, it should be 
> pretty strightforward)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)