[jira] [Commented] (WICKET-6608) Stateless page, mix of queue and add can cause unforseen consequences
[ https://issues.apache.org/jira/browse/WICKET-6608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711999#comment-16711999 ] ASF subversion and git services commented on WICKET-6608: - Commit 52a101f01bdc646d0f62ab7a5bfb4b468211d54f in wicket's branch refs/heads/WICKET-6563 from [~svenmeier] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=52a101f ] Revert "WICKET-6608 added test case" This reverts commit 3b34d36ad98a5895f7bb9581c22e3b8620c684bc. > Stateless page, mix of queue and add can cause unforseen consequences > - > > Key: WICKET-6608 > URL: https://issues.apache.org/jira/browse/WICKET-6608 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.1.0 >Reporter: Oddgeir Bell >Assignee: Sven Meier >Priority: Minor > Attachments: statelessQueueAdd.zip > > > We are in the process of upgrading a Wicket 6.x application to Wicket 8.1, > mostly because we needed stateless ajax. > In the process we discovered something quite unexpected (took a few days to > figure out the cause). > This is the issue: > Stateless page. > Hierarchy like so: > Page > ->Container > ->Label > ->AjaxButton > > The label should only be visible when it's model has data, so we override > onConfigure and set visible = (getDefaultModelObject != null). > This works if all components are added with add(Component). > It also works if all components are added with queue(Component). > BUT, if the container is added with add(Component) and the AjaxButton is > added with queue(Component), it doesn't work. > Actually, if just one component is added to the page with queue(Component), > things seem to work (as long as it is queue-ed AFTER the container is add-ed) > I could not find any information on dangers of mixing add/queue with my > google-fu, so it may look like it's a bug? > > Attached quickstart that shows the issue. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6608) Stateless page, mix of queue and add can cause unforseen consequences
[ https://issues.apache.org/jira/browse/WICKET-6608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711998#comment-16711998 ] ASF subversion and git services commented on WICKET-6608: - Commit 6a0fdedba3383ebf5ebbc15e51ac56567955ecc1 in wicket's branch refs/heads/WICKET-6563 from [~svenmeier] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=6a0fded ] Revert "WICKET-6608 Stateless page, mix of queue and add can cause unforseen" This reverts commit 147f6d33f839edd9a6eb53ce9c20b4cde07fc938. > Stateless page, mix of queue and add can cause unforseen consequences > - > > Key: WICKET-6608 > URL: https://issues.apache.org/jira/browse/WICKET-6608 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.1.0 >Reporter: Oddgeir Bell >Assignee: Sven Meier >Priority: Minor > Attachments: statelessQueueAdd.zip > > > We are in the process of upgrading a Wicket 6.x application to Wicket 8.1, > mostly because we needed stateless ajax. > In the process we discovered something quite unexpected (took a few days to > figure out the cause). > This is the issue: > Stateless page. > Hierarchy like so: > Page > ->Container > ->Label > ->AjaxButton > > The label should only be visible when it's model has data, so we override > onConfigure and set visible = (getDefaultModelObject != null). > This works if all components are added with add(Component). > It also works if all components are added with queue(Component). > BUT, if the container is added with add(Component) and the AjaxButton is > added with queue(Component), it doesn't work. > Actually, if just one component is added to the page with queue(Component), > things seem to work (as long as it is queue-ed AFTER the container is add-ed) > I could not find any information on dangers of mixing add/queue with my > google-fu, so it may look like it's a bug? > > Attached quickstart that shows the issue. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6608) Stateless page, mix of queue and add can cause unforseen consequences
[ https://issues.apache.org/jira/browse/WICKET-6608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707543#comment-16707543 ] ASF GitHub Bot commented on WICKET-6608: Github user svenmeier closed the pull request at: https://github.com/apache/wicket/pull/342 > Stateless page, mix of queue and add can cause unforseen consequences > - > > Key: WICKET-6608 > URL: https://issues.apache.org/jira/browse/WICKET-6608 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.1.0 >Reporter: Oddgeir Bell >Assignee: Sven Meier >Priority: Minor > Fix For: 9.0.0 > > Attachments: statelessQueueAdd.zip > > > We are in the process of upgrading a Wicket 6.x application to Wicket 8.1, > mostly because we needed stateless ajax. > In the process we discovered something quite unexpected (took a few days to > figure out the cause). > This is the issue: > Stateless page. > Hierarchy like so: > Page > ->Container > ->Label > ->AjaxButton > > The label should only be visible when it's model has data, so we override > onConfigure and set visible = (getDefaultModelObject != null). > This works if all components are added with add(Component). > It also works if all components are added with queue(Component). > BUT, if the container is added with add(Component) and the AjaxButton is > added with queue(Component), it doesn't work. > Actually, if just one component is added to the page with queue(Component), > things seem to work (as long as it is queue-ed AFTER the container is add-ed) > I could not find any information on dangers of mixing add/queue with my > google-fu, so it may look like it's a bug? > > Attached quickstart that shows the issue. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6608) Stateless page, mix of queue and add can cause unforseen consequences
[ https://issues.apache.org/jira/browse/WICKET-6608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707530#comment-16707530 ] ASF subversion and git services commented on WICKET-6608: - Commit 52a101f01bdc646d0f62ab7a5bfb4b468211d54f in wicket's branch refs/heads/master from [~svenmeier] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=52a101f ] Revert "WICKET-6608 added test case" This reverts commit 3b34d36ad98a5895f7bb9581c22e3b8620c684bc. > Stateless page, mix of queue and add can cause unforseen consequences > - > > Key: WICKET-6608 > URL: https://issues.apache.org/jira/browse/WICKET-6608 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.1.0 >Reporter: Oddgeir Bell >Assignee: Andrea Del Bene >Priority: Minor > Fix For: 8.2.0, 9.0.0 > > Attachments: statelessQueueAdd.zip > > > We are in the process of upgrading a Wicket 6.x application to Wicket 8.1, > mostly because we needed stateless ajax. > In the process we discovered something quite unexpected (took a few days to > figure out the cause). > This is the issue: > Stateless page. > Hierarchy like so: > Page > ->Container > ->Label > ->AjaxButton > > The label should only be visible when it's model has data, so we override > onConfigure and set visible = (getDefaultModelObject != null). > This works if all components are added with add(Component). > It also works if all components are added with queue(Component). > BUT, if the container is added with add(Component) and the AjaxButton is > added with queue(Component), it doesn't work. > Actually, if just one component is added to the page with queue(Component), > things seem to work (as long as it is queue-ed AFTER the container is add-ed) > I could not find any information on dangers of mixing add/queue with my > google-fu, so it may look like it's a bug? > > Attached quickstart that shows the issue. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6608) Stateless page, mix of queue and add can cause unforseen consequences
[ https://issues.apache.org/jira/browse/WICKET-6608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707529#comment-16707529 ] ASF subversion and git services commented on WICKET-6608: - Commit 6a0fdedba3383ebf5ebbc15e51ac56567955ecc1 in wicket's branch refs/heads/master from [~svenmeier] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=6a0fded ] Revert "WICKET-6608 Stateless page, mix of queue and add can cause unforseen" This reverts commit 147f6d33f839edd9a6eb53ce9c20b4cde07fc938. > Stateless page, mix of queue and add can cause unforseen consequences > - > > Key: WICKET-6608 > URL: https://issues.apache.org/jira/browse/WICKET-6608 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.1.0 >Reporter: Oddgeir Bell >Assignee: Andrea Del Bene >Priority: Minor > Fix For: 8.2.0, 9.0.0 > > Attachments: statelessQueueAdd.zip > > > We are in the process of upgrading a Wicket 6.x application to Wicket 8.1, > mostly because we needed stateless ajax. > In the process we discovered something quite unexpected (took a few days to > figure out the cause). > This is the issue: > Stateless page. > Hierarchy like so: > Page > ->Container > ->Label > ->AjaxButton > > The label should only be visible when it's model has data, so we override > onConfigure and set visible = (getDefaultModelObject != null). > This works if all components are added with add(Component). > It also works if all components are added with queue(Component). > BUT, if the container is added with add(Component) and the AjaxButton is > added with queue(Component), it doesn't work. > Actually, if just one component is added to the page with queue(Component), > things seem to work (as long as it is queue-ed AFTER the container is add-ed) > I could not find any information on dangers of mixing add/queue with my > google-fu, so it may look like it's a bug? > > Attached quickstart that shows the issue. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6608) Stateless page, mix of queue and add can cause unforseen consequences
[ https://issues.apache.org/jira/browse/WICKET-6608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707526#comment-16707526 ] ASF subversion and git services commented on WICKET-6608: - Commit 7b2bb1162dd80e6faab9fb9f0fc30c0d153a4bd2 in wicket's branch refs/heads/wicket-8.x from [~svenmeier] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=7b2bb11 ] Revert "WICKET-6608 Stateless page, mix of queue and add can cause unforseen" This reverts commit 61c8709389cea30975814530f53dd0ae1f1ea592. > Stateless page, mix of queue and add can cause unforseen consequences > - > > Key: WICKET-6608 > URL: https://issues.apache.org/jira/browse/WICKET-6608 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.1.0 >Reporter: Oddgeir Bell >Assignee: Andrea Del Bene >Priority: Minor > Fix For: 8.2.0, 9.0.0 > > Attachments: statelessQueueAdd.zip > > > We are in the process of upgrading a Wicket 6.x application to Wicket 8.1, > mostly because we needed stateless ajax. > In the process we discovered something quite unexpected (took a few days to > figure out the cause). > This is the issue: > Stateless page. > Hierarchy like so: > Page > ->Container > ->Label > ->AjaxButton > > The label should only be visible when it's model has data, so we override > onConfigure and set visible = (getDefaultModelObject != null). > This works if all components are added with add(Component). > It also works if all components are added with queue(Component). > BUT, if the container is added with add(Component) and the AjaxButton is > added with queue(Component), it doesn't work. > Actually, if just one component is added to the page with queue(Component), > things seem to work (as long as it is queue-ed AFTER the container is add-ed) > I could not find any information on dangers of mixing add/queue with my > google-fu, so it may look like it's a bug? > > Attached quickstart that shows the issue. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6608) Stateless page, mix of queue and add can cause unforseen consequences
[ https://issues.apache.org/jira/browse/WICKET-6608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707527#comment-16707527 ] ASF subversion and git services commented on WICKET-6608: - Commit a446138852fe1748ff879d85bced1b19f8af444e in wicket's branch refs/heads/wicket-8.x from [~svenmeier] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=a446138 ] Revert "WICKET-6608 added test case" This reverts commit 86f92fc8cfaf4ec15409908455d049f9466c542e. > Stateless page, mix of queue and add can cause unforseen consequences > - > > Key: WICKET-6608 > URL: https://issues.apache.org/jira/browse/WICKET-6608 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.1.0 >Reporter: Oddgeir Bell >Assignee: Andrea Del Bene >Priority: Minor > Fix For: 8.2.0, 9.0.0 > > Attachments: statelessQueueAdd.zip > > > We are in the process of upgrading a Wicket 6.x application to Wicket 8.1, > mostly because we needed stateless ajax. > In the process we discovered something quite unexpected (took a few days to > figure out the cause). > This is the issue: > Stateless page. > Hierarchy like so: > Page > ->Container > ->Label > ->AjaxButton > > The label should only be visible when it's model has data, so we override > onConfigure and set visible = (getDefaultModelObject != null). > This works if all components are added with add(Component). > It also works if all components are added with queue(Component). > BUT, if the container is added with add(Component) and the AjaxButton is > added with queue(Component), it doesn't work. > Actually, if just one component is added to the page with queue(Component), > things seem to work (as long as it is queue-ed AFTER the container is add-ed) > I could not find any information on dangers of mixing add/queue with my > google-fu, so it may look like it's a bug? > > Attached quickstart that shows the issue. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6608) Stateless page, mix of queue and add can cause unforseen consequences
[ https://issues.apache.org/jira/browse/WICKET-6608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707191#comment-16707191 ] ASF GitHub Bot commented on WICKET-6608: Github user svenmeier commented on the issue: https://github.com/apache/wicket/pull/342 Ok, you're right, that would be an improvement. IMHO this change is to big to introduce in a 8.x release though. I'd say we revert WICKET-6608 (which as is allows even more components to be accessed unprepared now) and try to find a better solution for 9.x. > Stateless page, mix of queue and add can cause unforseen consequences > - > > Key: WICKET-6608 > URL: https://issues.apache.org/jira/browse/WICKET-6608 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.1.0 >Reporter: Oddgeir Bell >Assignee: Andrea Del Bene >Priority: Minor > Fix For: 8.2.0, 9.0.0 > > Attachments: statelessQueueAdd.zip > > > We are in the process of upgrading a Wicket 6.x application to Wicket 8.1, > mostly because we needed stateless ajax. > In the process we discovered something quite unexpected (took a few days to > figure out the cause). > This is the issue: > Stateless page. > Hierarchy like so: > Page > ->Container > ->Label > ->AjaxButton > > The label should only be visible when it's model has data, so we override > onConfigure and set visible = (getDefaultModelObject != null). > This works if all components are added with add(Component). > It also works if all components are added with queue(Component). > BUT, if the container is added with add(Component) and the AjaxButton is > added with queue(Component), it doesn't work. > Actually, if just one component is added to the page with queue(Component), > things seem to work (as long as it is queue-ed AFTER the container is add-ed) > I could not find any information on dangers of mixing add/queue with my > google-fu, so it may look like it's a bug? > > Attached quickstart that shows the issue. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6608) Stateless page, mix of queue and add can cause unforseen consequences
[ https://issues.apache.org/jira/browse/WICKET-6608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705993#comment-16705993 ] ASF GitHub Bot commented on WICKET-6608: GitHub user svenmeier opened a pull request: https://github.com/apache/wicket/pull/342 Wicket 6616 always render new pages Question: Should Wicket always render new pages before any component in it is accessed? * until 8.1.0 * components can be accessed **un-rendered** when already inside the page hierarchy * then the page is prepared for render * any component added in onInitialize() or onBeforeRender() can be accessed **rendered** * since 8.2.0 (WICKET-6608) * components can be accessed **un-rendered** when already inside the page hierarchy * then the page is initialized * any component added in onInitialize() (e.g. through queueing) can be accessed **rendered** * then the page is prepared for render * any component added in onBeforeRender() can be accessed **rendered** IMHO all these cases should allow access to **rendered** component only. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/wicket WICKET-6616-render-new-pages Alternatively you can review and apply these changes as the patch at: https://github.com/apache/wicket/pull/342.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #342 commit 7b2bb1162dd80e6faab9fb9f0fc30c0d153a4bd2 Author: Sven Meier Date: 2018-11-30T15:10:18Z Revert "WICKET-6608 Stateless page, mix of queue and add can cause unforseen" This reverts commit 61c8709389cea30975814530f53dd0ae1f1ea592. commit a446138852fe1748ff879d85bced1b19f8af444e Author: Sven Meier Date: 2018-11-30T15:10:21Z Revert "WICKET-6608 added test case" This reverts commit 86f92fc8cfaf4ec15409908455d049f9466c542e. commit 557115433e3485fc6ab50607ae930ff46c14c80a Author: Sven Meier Date: 2018-12-01T20:14:40Z WICKET-6616 always render new pages > Stateless page, mix of queue and add can cause unforseen consequences > - > > Key: WICKET-6608 > URL: https://issues.apache.org/jira/browse/WICKET-6608 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.1.0 >Reporter: Oddgeir Bell >Assignee: Andrea Del Bene >Priority: Minor > Fix For: 8.2.0, 9.0.0 > > Attachments: statelessQueueAdd.zip > > > We are in the process of upgrading a Wicket 6.x application to Wicket 8.1, > mostly because we needed stateless ajax. > In the process we discovered something quite unexpected (took a few days to > figure out the cause). > This is the issue: > Stateless page. > Hierarchy like so: > Page > ->Container > ->Label > ->AjaxButton > > The label should only be visible when it's model has data, so we override > onConfigure and set visible = (getDefaultModelObject != null). > This works if all components are added with add(Component). > It also works if all components are added with queue(Component). > BUT, if the container is added with add(Component) and the AjaxButton is > added with queue(Component), it doesn't work. > Actually, if just one component is added to the page with queue(Component), > things seem to work (as long as it is queue-ed AFTER the container is add-ed) > I could not find any information on dangers of mixing add/queue with my > google-fu, so it may look like it's a bug? > > Attached quickstart that shows the issue. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6608) Stateless page, mix of queue and add can cause unforseen consequences
[ https://issues.apache.org/jira/browse/WICKET-6608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705984#comment-16705984 ] ASF subversion and git services commented on WICKET-6608: - Commit 7b2bb1162dd80e6faab9fb9f0fc30c0d153a4bd2 in wicket's branch refs/heads/WICKET-6616-render-new-pages from [~svenmeier] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=7b2bb11 ] Revert "WICKET-6608 Stateless page, mix of queue and add can cause unforseen" This reverts commit 61c8709389cea30975814530f53dd0ae1f1ea592. > Stateless page, mix of queue and add can cause unforseen consequences > - > > Key: WICKET-6608 > URL: https://issues.apache.org/jira/browse/WICKET-6608 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.1.0 >Reporter: Oddgeir Bell >Assignee: Andrea Del Bene >Priority: Minor > Fix For: 8.2.0, 9.0.0 > > Attachments: statelessQueueAdd.zip > > > We are in the process of upgrading a Wicket 6.x application to Wicket 8.1, > mostly because we needed stateless ajax. > In the process we discovered something quite unexpected (took a few days to > figure out the cause). > This is the issue: > Stateless page. > Hierarchy like so: > Page > ->Container > ->Label > ->AjaxButton > > The label should only be visible when it's model has data, so we override > onConfigure and set visible = (getDefaultModelObject != null). > This works if all components are added with add(Component). > It also works if all components are added with queue(Component). > BUT, if the container is added with add(Component) and the AjaxButton is > added with queue(Component), it doesn't work. > Actually, if just one component is added to the page with queue(Component), > things seem to work (as long as it is queue-ed AFTER the container is add-ed) > I could not find any information on dangers of mixing add/queue with my > google-fu, so it may look like it's a bug? > > Attached quickstart that shows the issue. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6608) Stateless page, mix of queue and add can cause unforseen consequences
[ https://issues.apache.org/jira/browse/WICKET-6608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705985#comment-16705985 ] ASF subversion and git services commented on WICKET-6608: - Commit a446138852fe1748ff879d85bced1b19f8af444e in wicket's branch refs/heads/WICKET-6616-render-new-pages from [~svenmeier] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=a446138 ] Revert "WICKET-6608 added test case" This reverts commit 86f92fc8cfaf4ec15409908455d049f9466c542e. > Stateless page, mix of queue and add can cause unforseen consequences > - > > Key: WICKET-6608 > URL: https://issues.apache.org/jira/browse/WICKET-6608 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.1.0 >Reporter: Oddgeir Bell >Assignee: Andrea Del Bene >Priority: Minor > Fix For: 8.2.0, 9.0.0 > > Attachments: statelessQueueAdd.zip > > > We are in the process of upgrading a Wicket 6.x application to Wicket 8.1, > mostly because we needed stateless ajax. > In the process we discovered something quite unexpected (took a few days to > figure out the cause). > This is the issue: > Stateless page. > Hierarchy like so: > Page > ->Container > ->Label > ->AjaxButton > > The label should only be visible when it's model has data, so we override > onConfigure and set visible = (getDefaultModelObject != null). > This works if all components are added with add(Component). > It also works if all components are added with queue(Component). > BUT, if the container is added with add(Component) and the AjaxButton is > added with queue(Component), it doesn't work. > Actually, if just one component is added to the page with queue(Component), > things seem to work (as long as it is queue-ed AFTER the container is add-ed) > I could not find any information on dangers of mixing add/queue with my > google-fu, so it may look like it's a bug? > > Attached quickstart that shows the issue. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6608) Stateless page, mix of queue and add can cause unforseen consequences
[ https://issues.apache.org/jira/browse/WICKET-6608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16703130#comment-16703130 ] Sven Meier commented on WICKET-6608: All components directly *queued into a page* are *immediately* dequeued, *including* all queued component in the child hierarchy: * when you queue your form to the page, all components are immediately dequeued into the component hierarchy * but when you add your form to the page, all queued components inside of it *stay queued* until rendering In the latter case PageAndComponentProvider does not find the component in the page, thus rendering it once to find the queued (not yet added) component. So the label is already configured before the button is submitted changes the model object. > Stateless page, mix of queue and add can cause unforseen consequences > - > > Key: WICKET-6608 > URL: https://issues.apache.org/jira/browse/WICKET-6608 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.1.0 >Reporter: Oddgeir Bell >Assignee: Andrea Del Bene >Priority: Minor > Fix For: 8.2.0, 9.0.0 > > Attachments: statelessQueueAdd.zip > > > We are in the process of upgrading a Wicket 6.x application to Wicket 8.1, > mostly because we needed stateless ajax. > In the process we discovered something quite unexpected (took a few days to > figure out the cause). > This is the issue: > Stateless page. > Hierarchy like so: > Page > ->Container > ->Label > ->AjaxButton > > The label should only be visible when it's model has data, so we override > onConfigure and set visible = (getDefaultModelObject != null). > This works if all components are added with add(Component). > It also works if all components are added with queue(Component). > BUT, if the container is added with add(Component) and the AjaxButton is > added with queue(Component), it doesn't work. > Actually, if just one component is added to the page with queue(Component), > things seem to work (as long as it is queue-ed AFTER the container is add-ed) > I could not find any information on dangers of mixing add/queue with my > google-fu, so it may look like it's a bug? > > Attached quickstart that shows the issue. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6608) Stateless page, mix of queue and add can cause unforseen consequences
[ https://issues.apache.org/jira/browse/WICKET-6608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681543#comment-16681543 ] ASF subversion and git services commented on WICKET-6608: - Commit 3b34d36ad98a5895f7bb9581c22e3b8620c684bc in wicket's branch refs/heads/WICKET-6563 from [~bitstorm] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=3b34d36 ] WICKET-6608 added test case > Stateless page, mix of queue and add can cause unforseen consequences > - > > Key: WICKET-6608 > URL: https://issues.apache.org/jira/browse/WICKET-6608 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.1.0 >Reporter: Oddgeir Bell >Assignee: Andrea Del Bene >Priority: Minor > Fix For: 8.2.0, 9.0.0 > > Attachments: statelessQueueAdd.zip > > > We are in the process of upgrading a Wicket 6.x application to Wicket 8.1, > mostly because we needed stateless ajax. > In the process we discovered something quite unexpected (took a few days to > figure out the cause). > This is the issue: > Stateless page. > Hierarchy like so: > Page > ->Container > ->Label > ->AjaxButton > > The label should only be visible when it's model has data, so we override > onConfigure and set visible = (getDefaultModelObject != null). > This works if all components are added with add(Component). > It also works if all components are added with queue(Component). > BUT, if the container is added with add(Component) and the AjaxButton is > added with queue(Component), it doesn't work. > Actually, if just one component is added to the page with queue(Component), > things seem to work (as long as it is queue-ed AFTER the container is add-ed) > I could not find any information on dangers of mixing add/queue with my > google-fu, so it may look like it's a bug? > > Attached quickstart that shows the issue. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6608) Stateless page, mix of queue and add can cause unforseen consequences
[ https://issues.apache.org/jira/browse/WICKET-6608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681540#comment-16681540 ] ASF subversion and git services commented on WICKET-6608: - Commit 147f6d33f839edd9a6eb53ce9c20b4cde07fc938 in wicket's branch refs/heads/WICKET-6563 from [~bitstorm] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=147f6d3 ] WICKET-6608 Stateless page, mix of queue and add can cause unforseen consequences > Stateless page, mix of queue and add can cause unforseen consequences > - > > Key: WICKET-6608 > URL: https://issues.apache.org/jira/browse/WICKET-6608 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.1.0 >Reporter: Oddgeir Bell >Assignee: Andrea Del Bene >Priority: Minor > Fix For: 8.2.0, 9.0.0 > > Attachments: statelessQueueAdd.zip > > > We are in the process of upgrading a Wicket 6.x application to Wicket 8.1, > mostly because we needed stateless ajax. > In the process we discovered something quite unexpected (took a few days to > figure out the cause). > This is the issue: > Stateless page. > Hierarchy like so: > Page > ->Container > ->Label > ->AjaxButton > > The label should only be visible when it's model has data, so we override > onConfigure and set visible = (getDefaultModelObject != null). > This works if all components are added with add(Component). > It also works if all components are added with queue(Component). > BUT, if the container is added with add(Component) and the AjaxButton is > added with queue(Component), it doesn't work. > Actually, if just one component is added to the page with queue(Component), > things seem to work (as long as it is queue-ed AFTER the container is add-ed) > I could not find any information on dangers of mixing add/queue with my > google-fu, so it may look like it's a bug? > > Attached quickstart that shows the issue. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6608) Stateless page, mix of queue and add can cause unforseen consequences
[ https://issues.apache.org/jira/browse/WICKET-6608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679966#comment-16679966 ] ASF subversion and git services commented on WICKET-6608: - Commit 3b34d36ad98a5895f7bb9581c22e3b8620c684bc in wicket's branch refs/heads/master from [~bitstorm] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=3b34d36 ] WICKET-6608 added test case > Stateless page, mix of queue and add can cause unforseen consequences > - > > Key: WICKET-6608 > URL: https://issues.apache.org/jira/browse/WICKET-6608 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.1.0 >Reporter: Oddgeir Bell >Assignee: Andrea Del Bene >Priority: Minor > Fix For: 8.2.0, 9.0.0 > > Attachments: statelessQueueAdd.zip > > > We are in the process of upgrading a Wicket 6.x application to Wicket 8.1, > mostly because we needed stateless ajax. > In the process we discovered something quite unexpected (took a few days to > figure out the cause). > This is the issue: > Stateless page. > Hierarchy like so: > Page > ->Container > ->Label > ->AjaxButton > > The label should only be visible when it's model has data, so we override > onConfigure and set visible = (getDefaultModelObject != null). > This works if all components are added with add(Component). > It also works if all components are added with queue(Component). > BUT, if the container is added with add(Component) and the AjaxButton is > added with queue(Component), it doesn't work. > Actually, if just one component is added to the page with queue(Component), > things seem to work (as long as it is queue-ed AFTER the container is add-ed) > I could not find any information on dangers of mixing add/queue with my > google-fu, so it may look like it's a bug? > > Attached quickstart that shows the issue. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6608) Stateless page, mix of queue and add can cause unforseen consequences
[ https://issues.apache.org/jira/browse/WICKET-6608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679944#comment-16679944 ] ASF subversion and git services commented on WICKET-6608: - Commit 86f92fc8cfaf4ec15409908455d049f9466c542e in wicket's branch refs/heads/wicket-8.x from [~bitstorm] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=86f92fc ] WICKET-6608 added test case > Stateless page, mix of queue and add can cause unforseen consequences > - > > Key: WICKET-6608 > URL: https://issues.apache.org/jira/browse/WICKET-6608 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.1.0 >Reporter: Oddgeir Bell >Assignee: Andrea Del Bene >Priority: Minor > Attachments: statelessQueueAdd.zip > > > We are in the process of upgrading a Wicket 6.x application to Wicket 8.1, > mostly because we needed stateless ajax. > In the process we discovered something quite unexpected (took a few days to > figure out the cause). > This is the issue: > Stateless page. > Hierarchy like so: > Page > ->Container > ->Label > ->AjaxButton > > The label should only be visible when it's model has data, so we override > onConfigure and set visible = (getDefaultModelObject != null). > This works if all components are added with add(Component). > It also works if all components are added with queue(Component). > BUT, if the container is added with add(Component) and the AjaxButton is > added with queue(Component), it doesn't work. > Actually, if just one component is added to the page with queue(Component), > things seem to work (as long as it is queue-ed AFTER the container is add-ed) > I could not find any information on dangers of mixing add/queue with my > google-fu, so it may look like it's a bug? > > Attached quickstart that shows the issue. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6608) Stateless page, mix of queue and add can cause unforseen consequences
[ https://issues.apache.org/jira/browse/WICKET-6608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676844#comment-16676844 ] Andrea Del Bene commented on WICKET-6608: - When a component on a stateless page is not found by PageAndComponentProvider#findComponent, the page is initialized and rendered in order to invoke possible code that could add the component. Now page rendering is performed only if initialization is not enough to create such component. > Stateless page, mix of queue and add can cause unforseen consequences > - > > Key: WICKET-6608 > URL: https://issues.apache.org/jira/browse/WICKET-6608 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.1.0 >Reporter: Oddgeir Bell >Assignee: Andrea Del Bene >Priority: Minor > Attachments: statelessQueueAdd.zip > > > We are in the process of upgrading a Wicket 6.x application to Wicket 8.1, > mostly because we needed stateless ajax. > In the process we discovered something quite unexpected (took a few days to > figure out the cause). > This is the issue: > Stateless page. > Hierarchy like so: > Page > ->Container > ->Label > ->AjaxButton > > The label should only be visible when it's model has data, so we override > onConfigure and set visible = (getDefaultModelObject != null). > This works if all components are added with add(Component). > It also works if all components are added with queue(Component). > BUT, if the container is added with add(Component) and the AjaxButton is > added with queue(Component), it doesn't work. > Actually, if just one component is added to the page with queue(Component), > things seem to work (as long as it is queue-ed AFTER the container is add-ed) > I could not find any information on dangers of mixing add/queue with my > google-fu, so it may look like it's a bug? > > Attached quickstart that shows the issue. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6608) Stateless page, mix of queue and add can cause unforseen consequences
[ https://issues.apache.org/jira/browse/WICKET-6608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676828#comment-16676828 ] ASF subversion and git services commented on WICKET-6608: - Commit 147f6d33f839edd9a6eb53ce9c20b4cde07fc938 in wicket's branch refs/heads/master from [~bitstorm] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=147f6d3 ] WICKET-6608 Stateless page, mix of queue and add can cause unforseen consequences > Stateless page, mix of queue and add can cause unforseen consequences > - > > Key: WICKET-6608 > URL: https://issues.apache.org/jira/browse/WICKET-6608 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.1.0 >Reporter: Oddgeir Bell >Assignee: Andrea Del Bene >Priority: Minor > Attachments: statelessQueueAdd.zip > > > We are in the process of upgrading a Wicket 6.x application to Wicket 8.1, > mostly because we needed stateless ajax. > In the process we discovered something quite unexpected (took a few days to > figure out the cause). > This is the issue: > Stateless page. > Hierarchy like so: > Page > ->Container > ->Label > ->AjaxButton > > The label should only be visible when it's model has data, so we override > onConfigure and set visible = (getDefaultModelObject != null). > This works if all components are added with add(Component). > It also works if all components are added with queue(Component). > BUT, if the container is added with add(Component) and the AjaxButton is > added with queue(Component), it doesn't work. > Actually, if just one component is added to the page with queue(Component), > things seem to work (as long as it is queue-ed AFTER the container is add-ed) > I could not find any information on dangers of mixing add/queue with my > google-fu, so it may look like it's a bug? > > Attached quickstart that shows the issue. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WICKET-6608) Stateless page, mix of queue and add can cause unforseen consequences
[ https://issues.apache.org/jira/browse/WICKET-6608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676825#comment-16676825 ] ASF subversion and git services commented on WICKET-6608: - Commit 61c8709389cea30975814530f53dd0ae1f1ea592 in wicket's branch refs/heads/wicket-8.x from [~bitstorm] [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=61c8709 ] WICKET-6608 Stateless page, mix of queue and add can cause unforseen consequences > Stateless page, mix of queue and add can cause unforseen consequences > - > > Key: WICKET-6608 > URL: https://issues.apache.org/jira/browse/WICKET-6608 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 8.1.0 >Reporter: Oddgeir Bell >Assignee: Andrea Del Bene >Priority: Minor > Attachments: statelessQueueAdd.zip > > > We are in the process of upgrading a Wicket 6.x application to Wicket 8.1, > mostly because we needed stateless ajax. > In the process we discovered something quite unexpected (took a few days to > figure out the cause). > This is the issue: > Stateless page. > Hierarchy like so: > Page > ->Container > ->Label > ->AjaxButton > > The label should only be visible when it's model has data, so we override > onConfigure and set visible = (getDefaultModelObject != null). > This works if all components are added with add(Component). > It also works if all components are added with queue(Component). > BUT, if the container is added with add(Component) and the AjaxButton is > added with queue(Component), it doesn't work. > Actually, if just one component is added to the page with queue(Component), > things seem to work (as long as it is queue-ed AFTER the container is add-ed) > I could not find any information on dangers of mixing add/queue with my > google-fu, so it may look like it's a bug? > > Attached quickstart that shows the issue. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
