[jira] [Updated] (WICKET-3867) URIs should be used instead of URLs as Set or Map keys.

2011-07-04 Thread Bertrand Guay-Paquet (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-3867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Guay-Paquet updated WICKET-3867:
-

Attachment: WICKET-3867-patch-v2.patch

v2

> URIs should be used instead of URLs as Set or Map keys.
> ---
>
> Key: WICKET-3867
> URL: https://issues.apache.org/jira/browse/WICKET-3867
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-core
>Affects Versions: 1.5-RC5.1
>Reporter: Bertrand Guay-Paquet
>  Labels: classloader, url
> Attachments: WICKET-3867-patch-v2.patch, WICKET-3867-patch.patch
>
>
> URLs are not suitable for use as Set or Map keys because their equals() and 
> hashCode() methods are not well defined. URIs should be used to identify the 
> location and URLs to access the actual resources.
> See thread for 
> http://mail-archives.apache.org/mod_mbox/wicket-users/201107.mbox/%3CCAPdiUN6CaH9rn4+tD9_hXP-dmBGn-SvFu=rvcmh8ayx5_1j...@mail.gmail.com%3E
> Specifically:
> [1] "More Joy of Sets" example with URL from Google Tech Talks:
> http://www.youtube.com/watch?v=wDN_EYUvUq0#t=9m58s

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (WICKET-3867) URIs should be used instead of URLs as Set or Map keys.

2011-07-04 Thread Bertrand Guay-Paquet (JIRA)

 [ 
https://issues.apache.org/jira/browse/WICKET-3867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Guay-Paquet updated WICKET-3867:
-

Attachment: WICKET-3867-patch.patch

Proposed patch.

Please review usage of URLs in ReloadingClassLoader as well since it exhibits 
similar issues.

> URIs should be used instead of URLs as Set or Map keys.
> ---
>
> Key: WICKET-3867
> URL: https://issues.apache.org/jira/browse/WICKET-3867
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-core
>Affects Versions: 1.5-RC5.1
>Reporter: Bertrand Guay-Paquet
>  Labels: classloader, url
> Attachments: WICKET-3867-patch.patch
>
>
> URLs are not suitable for use as Set or Map keys because their equals() and 
> hashCode() methods are not well defined. URIs should be used to identify the 
> location and URLs to access the actual resources.
> See thread for 
> http://mail-archives.apache.org/mod_mbox/wicket-users/201107.mbox/%3CCAPdiUN6CaH9rn4+tD9_hXP-dmBGn-SvFu=rvcmh8ayx5_1j...@mail.gmail.com%3E
> Specifically:
> [1] "More Joy of Sets" example with URL from Google Tech Talks:
> http://www.youtube.com/watch?v=wDN_EYUvUq0#t=9m58s

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira