[jira] Commented: (WICKET-2502) WicketTester cannot handle consecutive RestartResponseException's

2010-01-17 Thread Martin Makundi (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801384#action_12801384
 ] 

Martin Makundi commented on WICKET-2502:


Yeah, looks like your fix works for my real test case!

> WicketTester cannot handle consecutive RestartResponseException's
> -
>
> Key: WICKET-2502
> URL: https://issues.apache.org/jira/browse/WICKET-2502
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.4-RC7
>Reporter: Martin Makundi
>Priority: Minor
> Attachments: Wicket-Quickstart.zip
>
>   Original Estimate: 5h
>  Remaining Estimate: 5h
>
> See attached quickstart junit test. WicketTester "crashes" (seizes from 
> running the tests) if there eare consecutive RestartResponseException's.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (WICKET-2502) WicketTester cannot handle consecutive RestartResponseException's

2010-01-17 Thread Martin Makundi (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801369#action_12801369
 ] 

Martin Makundi commented on WICKET-2502:


Ok. It was a bit tricky to make the test case and verify it so maybe there is a 
bug in it. Meanwhile, let me test your patch.

> WicketTester cannot handle consecutive RestartResponseException's
> -
>
> Key: WICKET-2502
> URL: https://issues.apache.org/jira/browse/WICKET-2502
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.4-RC7
>Reporter: Martin Makundi
>Priority: Minor
> Attachments: Wicket-Quickstart.zip
>
>   Original Estimate: 5h
>  Remaining Estimate: 5h
>
> See attached quickstart junit test. WicketTester "crashes" (seizes from 
> running the tests) if there eare consecutive RestartResponseException's.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (WICKET-2502) WicketTester cannot handle consecutive RestartResponseException's

2010-01-17 Thread Martin Grigorov (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801365#action_12801365
 ] 

Martin Grigorov commented on WICKET-2502:
-

My question is what do you expect with the provided test case ?
It goes in a loop: LoginPage -> PendingPage -> MainPage (intercepted by 
AuthStrategy and starts again with LoginPage).

I just added a patch for WICKET-2634.
Test it if you have time.

> WicketTester cannot handle consecutive RestartResponseException's
> -
>
> Key: WICKET-2502
> URL: https://issues.apache.org/jira/browse/WICKET-2502
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.4-RC7
>Reporter: Martin Makundi
>Priority: Minor
> Attachments: Wicket-Quickstart.zip
>
>   Original Estimate: 5h
>  Remaining Estimate: 5h
>
> See attached quickstart junit test. WicketTester "crashes" (seizes from 
> running the tests) if there eare consecutive RestartResponseException's.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (WICKET-2502) WicketTester cannot handle consecutive RestartResponseException's

2010-01-17 Thread Martin Makundi (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801360#action_12801360
 ] 

Martin Makundi commented on WICKET-2502:


What is your question exactly?

The core of the problem is that WicketTester cannot handle consecutive 
RestartResponsePages in the same way that the servlet container does. 


> WicketTester cannot handle consecutive RestartResponseException's
> -
>
> Key: WICKET-2502
> URL: https://issues.apache.org/jira/browse/WICKET-2502
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.4-RC7
>Reporter: Martin Makundi
>Priority: Minor
> Attachments: Wicket-Quickstart.zip
>
>   Original Estimate: 5h
>  Remaining Estimate: 5h
>
> See attached quickstart junit test. WicketTester "crashes" (seizes from 
> running the tests) if there eare consecutive RestartResponseException's.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (WICKET-2502) WicketTester cannot handle consecutive RestartResponseException's

2010-01-17 Thread Martin Grigorov (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801352#action_12801352
 ] 

Martin Grigorov commented on WICKET-2502:
-

Would you please explain more about the page flow in the test case.

As far as I understand it is:
1) Go to LoginPage
2) throw RestartResponsePage(PendingPage.class)
3) throw RestartResponsePage(MainPage.class)
4) WicketAuthorizationStrategy#onUnauthorizedInstantiation(mainPageInstance) 
throws RestartResponseAtInterceptPageException(LoginPage.class) because 
WicketSession#isLoggedIn() returns false
5) Wicket requests a redirect (302) but since this is not executed in a real 
web server this is no-op
6) later Wicket tries to get the "lastRenderedPage" but this again fails at the 
instantiation of LoginPage and the test fails with RestartResponseException in 
LoginPage's constructor 

> WicketTester cannot handle consecutive RestartResponseException's
> -
>
> Key: WICKET-2502
> URL: https://issues.apache.org/jira/browse/WICKET-2502
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.4-RC7
>Reporter: Martin Makundi
>Priority: Minor
> Attachments: Wicket-Quickstart.zip
>
>   Original Estimate: 5h
>  Remaining Estimate: 5h
>
> See attached quickstart junit test. WicketTester "crashes" (seizes from 
> running the tests) if there eare consecutive RestartResponseException's.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (WICKET-2502) WicketTester cannot handle consecutive RestartResponseException's

2009-12-24 Thread Marat Radchenko (JIRA)

[ 
https://issues.apache.org/jira/browse/WICKET-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794379#action_12794379
 ] 

Marat Radchenko commented on WICKET-2502:
-

One more testcase in WICKET-2634.

> WicketTester cannot handle consecutive RestartResponseException's
> -
>
> Key: WICKET-2502
> URL: https://issues.apache.org/jira/browse/WICKET-2502
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.4-RC7
>Reporter: Martin Makundi
>Priority: Minor
> Attachments: Wicket-Quickstart.zip
>
>   Original Estimate: 5h
>  Remaining Estimate: 5h
>
> See attached quickstart junit test. WicketTester "crashes" (seizes from 
> running the tests) if there eare consecutive RestartResponseException's.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.