[jira] Commented: (WICKET-2569) Inheritance layout excludes XML header from output
[ https://issues.apache.org/jira/browse/WICKET-2569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12788108#action_12788108 ] Neil Curzon commented on WICKET-2569: - The current behavior IS that the child magically overrides the parent. This is exactly what my patch fixes. After the patch, the ?xml header comes from the parent. In 1.4.3, the ?xml header comes from the child. You can verify this by using the attached quickstart, and moving the ?xml header from the parent, SuperPage.html, to the child, SuperPageWithMarkup.html. With 1.4.3, the final output has the ?xml header, the one from the child. With 1.4-SNAPSHOT after the patch, the ?xml header is in the final output ONLY if it's in the parent. Inheritance layout excludes XML header from output -- Key: WICKET-2569 URL: https://issues.apache.org/jira/browse/WICKET-2569 Project: Wicket Issue Type: Bug Affects Versions: 1.3.7, 1.4.3 Reporter: Neil Curzon Assignee: Juergen Donnerstag Attachments: wicket-2569.patch, wicket-2569.tgz When using inheritance layout, if the superclass (Layout class) has an ?xml header at the top, it's excluded from the rendering of subclasses, if they have an associated html file. If the subclass has no .html file associated with it, the ?xml header is preserved in the rendering output. To reproduce: Create a SuperPage class extending WebPage. At the top of SuperPage.html, put ?xml version=1.0 encoding=utf-8? . Create two subclasses of SuperPage, one with an HTML file and one without. View the sub pages. Notice when the one with an HTML file is rendered, the xml header is excluded. Expected: The ?xml header should always be preserved in the rendered output as it's vital to the layout. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2569) Inheritance layout excludes XML header from output
[ https://issues.apache.org/jira/browse/WICKET-2569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787858#action_12787858 ] Neil Curzon commented on WICKET-2569: - I've attached a patch against 1.4.x that fixes the quickstart and (I think) the bug. When merging markup of a base class and its superclass, currently it seems that the XML header that wins is the one at the bottom of the inheritance tree. I think it makes more sense for the top of the inheritance tree to win... so the ?xml declaration I have in my base Layout appears at the top of my rendered pages as expected. Inheritance layout excludes XML header from output -- Key: WICKET-2569 URL: https://issues.apache.org/jira/browse/WICKET-2569 Project: Wicket Issue Type: Bug Affects Versions: 1.3.7, 1.4.3 Reporter: Neil Curzon Assignee: Juergen Donnerstag Attachments: wicket-2569.patch, wicket-2569.tgz When using inheritance layout, if the superclass (Layout class) has an ?xml header at the top, it's excluded from the rendering of subclasses, if they have an associated html file. If the subclass has no .html file associated with it, the ?xml header is preserved in the rendering output. To reproduce: Create a SuperPage class extending WebPage. At the top of SuperPage.html, put ?xml version=1.0 encoding=utf-8? . Create two subclasses of SuperPage, one with an HTML file and one without. View the sub pages. Notice when the one with an HTML file is rendered, the xml header is excluded. Expected: The ?xml header should always be preserved in the rendered output as it's vital to the layout. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2569) Inheritance layout excludes XML header from output
[ https://issues.apache.org/jira/browse/WICKET-2569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787949#action_12787949 ] Juergen Donnerstag commented on WICKET-2569: Which file contains the page/panel information and which the extension. The base markup contains the page/panel layout and the inherited markup the specific extension. In my opinion it is more logical that the base markup (the page layout) provides the xml declaration when merging the markups. Inheritance layout excludes XML header from output -- Key: WICKET-2569 URL: https://issues.apache.org/jira/browse/WICKET-2569 Project: Wicket Issue Type: Bug Affects Versions: 1.3.7, 1.4.3 Reporter: Neil Curzon Assignee: Juergen Donnerstag Attachments: wicket-2569.patch, wicket-2569.tgz When using inheritance layout, if the superclass (Layout class) has an ?xml header at the top, it's excluded from the rendering of subclasses, if they have an associated html file. If the subclass has no .html file associated with it, the ?xml header is preserved in the rendering output. To reproduce: Create a SuperPage class extending WebPage. At the top of SuperPage.html, put ?xml version=1.0 encoding=utf-8? . Create two subclasses of SuperPage, one with an HTML file and one without. View the sub pages. Notice when the one with an HTML file is rendered, the xml header is excluded. Expected: The ?xml header should always be preserved in the rendered output as it's vital to the layout. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2569) Inheritance layout excludes XML header from output
[ https://issues.apache.org/jira/browse/WICKET-2569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787957#action_12787957 ] Igor Vaynberg commented on WICKET-2569: --- i agree with juergen, otherwise the child is magically overriding something in the parent which is inconsistent with how everything else works. Inheritance layout excludes XML header from output -- Key: WICKET-2569 URL: https://issues.apache.org/jira/browse/WICKET-2569 Project: Wicket Issue Type: Bug Affects Versions: 1.3.7, 1.4.3 Reporter: Neil Curzon Assignee: Juergen Donnerstag Attachments: wicket-2569.patch, wicket-2569.tgz When using inheritance layout, if the superclass (Layout class) has an ?xml header at the top, it's excluded from the rendering of subclasses, if they have an associated html file. If the subclass has no .html file associated with it, the ?xml header is preserved in the rendering output. To reproduce: Create a SuperPage class extending WebPage. At the top of SuperPage.html, put ?xml version=1.0 encoding=utf-8? . Create two subclasses of SuperPage, one with an HTML file and one without. View the sub pages. Notice when the one with an HTML file is rendered, the xml header is excluded. Expected: The ?xml header should always be preserved in the rendered output as it's vital to the layout. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2569) Inheritance layout excludes XML header from output
[ https://issues.apache.org/jira/browse/WICKET-2569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787104#action_12787104 ] Juergen Donnerstag commented on WICKET-2569: Wicket should throw an exception since a base clase with wicket:child but without a subclass with associated markup containing wicket:extend doesn't make sense. Inheritance layout excludes XML header from output -- Key: WICKET-2569 URL: https://issues.apache.org/jira/browse/WICKET-2569 Project: Wicket Issue Type: Bug Affects Versions: 1.3.7, 1.4.3 Reporter: Neil Curzon Assignee: Juergen Donnerstag Attachments: wicket-2569.tgz When using inheritance layout, if the superclass (Layout class) has an ?xml header at the top, it's excluded from the rendering of subclasses, if they have an associated html file. If the subclass has no .html file associated with it, the ?xml header is preserved in the rendering output. To reproduce: Create a SuperPage class extending WebPage. At the top of SuperPage.html, put ?xml version=1.0 encoding=utf-8? . Create two subclasses of SuperPage, one with an HTML file and one without. View the sub pages. Notice when the one with an HTML file is rendered, the xml header is excluded. Expected: The ?xml header should always be preserved in the rendered output as it's vital to the layout. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2569) Inheritance layout excludes XML header from output
[ https://issues.apache.org/jira/browse/WICKET-2569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12783369#action_12783369 ] Juergen Donnerstag commented on WICKET-2569: your baseclass contains wicket:child, which means your subclass must provide the wicket:extend markup. Wicket should rather throw an exception in case there is no sub-markup, than silently ignore wicket:child. Inheritance layout excludes XML header from output -- Key: WICKET-2569 URL: https://issues.apache.org/jira/browse/WICKET-2569 Project: Wicket Issue Type: Bug Affects Versions: 1.3.7, 1.4.3 Reporter: Neil Curzon Attachments: wicket-2569.tgz When using inheritance layout, if the superclass (Layout class) has an ?xml header at the top, it's excluded from the rendering of subclasses, if they have an associated html file. If the subclass has no .html file associated with it, the ?xml header is preserved in the rendering output. To reproduce: Create a SuperPage class extending WebPage. At the top of SuperPage.html, put ?xml version=1.0 encoding=utf-8? . Create two subclasses of SuperPage, one with an HTML file and one without. View the sub pages. Notice when the one with an HTML file is rendered, the xml header is excluded. Expected: The ?xml header should always be preserved in the rendered output as it's vital to the layout. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2569) Inheritance layout excludes XML header from output
[ https://issues.apache.org/jira/browse/WICKET-2569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12783401#action_12783401 ] Martijn Dashorst commented on WICKET-2569: -- I'd rather not mandate wicket:extend for pages with wicket:child /, because it is used for overriding the markup completely. Inheritance layout excludes XML header from output -- Key: WICKET-2569 URL: https://issues.apache.org/jira/browse/WICKET-2569 Project: Wicket Issue Type: Bug Affects Versions: 1.3.7, 1.4.3 Reporter: Neil Curzon Attachments: wicket-2569.tgz When using inheritance layout, if the superclass (Layout class) has an ?xml header at the top, it's excluded from the rendering of subclasses, if they have an associated html file. If the subclass has no .html file associated with it, the ?xml header is preserved in the rendering output. To reproduce: Create a SuperPage class extending WebPage. At the top of SuperPage.html, put ?xml version=1.0 encoding=utf-8? . Create two subclasses of SuperPage, one with an HTML file and one without. View the sub pages. Notice when the one with an HTML file is rendered, the xml header is excluded. Expected: The ?xml header should always be preserved in the rendered output as it's vital to the layout. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2569) Inheritance layout excludes XML header from output
[ https://issues.apache.org/jira/browse/WICKET-2569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12775452#action_12775452 ] Neil Curzon commented on WICKET-2569: - I've worked around this by putting a body-only non-escaping label with the header at the top of my layout. Inheritance layout excludes XML header from output -- Key: WICKET-2569 URL: https://issues.apache.org/jira/browse/WICKET-2569 Project: Wicket Issue Type: Bug Affects Versions: 1.3.7, 1.4.3 Reporter: Neil Curzon Attachments: wicket-2569.tgz When using inheritance layout, if the superclass (Layout class) has an ?xml header at the top, it's excluded from the rendering of subclasses, if they have an associated html file. If the subclass has no .html file associated with it, the ?xml header is preserved in the rendering output. To reproduce: Create a SuperPage class extending WebPage. At the top of SuperPage.html, put ?xml version=1.0 encoding=utf-8? . Create two subclasses of SuperPage, one with an HTML file and one without. View the sub pages. Notice when the one with an HTML file is rendered, the xml header is excluded. Expected: The ?xml header should always be preserved in the rendered output as it's vital to the layout. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
