[jira] Commented: (WICKET-3109) Using PopupSettings creates page maps early
[ https://issues.apache.org/jira/browse/WICKET-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12987663#action_12987663 ] Igor Vaynberg commented on WICKET-3109: --- pedo, i think popupsettings should be changed to take pagemapname instead of pagemap as well. this way users do not need to create pagemaps for every link they want to popup. Using PopupSettings creates page maps early --- Key: WICKET-3109 URL: https://issues.apache.org/jira/browse/WICKET-3109 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.12 Reporter: Jeremy Thomerson Assignee: Pedro Santos Priority: Minor Fix For: 1.4.16 Attachments: WICKET-3109.patch See WICKET-3108 for a description of the background (and a quickstart to demonstrate) The issue here is that whenever you create a link and add PopupSettings to it, it creates a page map. The page map shouldn't be created until someone actually clicks the link, though. The page map name will need to go in the URL, but the page map can be lazy-created. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3109) Using PopupSettings creates page maps early
[ https://issues.apache.org/jira/browse/WICKET-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12987667#action_12987667 ] Pedro Santos commented on WICKET-3109: -- It is currently taking one when an window name is set. But it is not easy to figure out since the javadoc don't explain it. By change you mean deprecate the API receiving an page mas as parameter and provide a new one to the page map name, or we can just remove the old API in benefit of the new one? Using PopupSettings creates page maps early --- Key: WICKET-3109 URL: https://issues.apache.org/jira/browse/WICKET-3109 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.12 Reporter: Jeremy Thomerson Assignee: Pedro Santos Priority: Minor Fix For: 1.4.16 Attachments: WICKET-3109.patch See WICKET-3108 for a description of the background (and a quickstart to demonstrate) The issue here is that whenever you create a link and add PopupSettings to it, it creates a page map. The page map shouldn't be created until someone actually clicks the link, though. The page map name will need to go in the URL, but the page map can be lazy-created. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3109) Using PopupSettings creates page maps early
[ https://issues.apache.org/jira/browse/WICKET-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12987694#action_12987694 ] Hudson commented on WICKET-3109: Integrated in Apache Wicket 1.4.x #407 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/407/]) avoiding early page maps creation when link has an popup setting Issue: WICKET-3109 Using PopupSettings creates page maps early --- Key: WICKET-3109 URL: https://issues.apache.org/jira/browse/WICKET-3109 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.12 Reporter: Jeremy Thomerson Assignee: Pedro Santos Priority: Minor Fix For: 1.4.16 Attachments: WICKET-3109.patch See WICKET-3108 for a description of the background (and a quickstart to demonstrate) The issue here is that whenever you create a link and add PopupSettings to it, it creates a page map. The page map shouldn't be created until someone actually clicks the link, though. The page map name will need to go in the URL, but the page map can be lazy-created. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3109) Using PopupSettings creates page maps early
[ https://issues.apache.org/jira/browse/WICKET-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12987732#action_12987732 ] Hudson commented on WICKET-3109: Integrated in Apache Wicket 1.4.x #409 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/409/]) restoring the PopupSettings(IPageMap pageMapName, final int displayFlags) constructor as deprecated Issue: WICKET-3109 Using PopupSettings creates page maps early --- Key: WICKET-3109 URL: https://issues.apache.org/jira/browse/WICKET-3109 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.12 Reporter: Jeremy Thomerson Assignee: Pedro Santos Priority: Minor Fix For: 1.4.16 Attachments: WICKET-3109.patch See WICKET-3108 for a description of the background (and a quickstart to demonstrate) The issue here is that whenever you create a link and add PopupSettings to it, it creates a page map. The page map shouldn't be created until someone actually clicks the link, though. The page map name will need to go in the URL, but the page map can be lazy-created. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3109) Using PopupSettings creates page maps early
[ https://issues.apache.org/jira/browse/WICKET-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12921458#action_12921458 ] Igor Vaynberg commented on WICKET-3109: --- its not that popupsettings creates it, its that other components such as link call getpagemap on it. we should add getpagemapname() to popupsettings and refactor those components to use that instead since the only reason they call getpagemap is to get the name. Using PopupSettings creates page maps early --- Key: WICKET-3109 URL: https://issues.apache.org/jira/browse/WICKET-3109 Project: Wicket Issue Type: Bug Components: wicket Affects Versions: 1.4.12 Reporter: Jeremy Thomerson Assignee: Jeremy Thomerson Priority: Minor See WICKET-3108 for a description of the background (and a quickstart to demonstrate) The issue here is that whenever you create a link and add PopupSettings to it, it creates a page map. The page map shouldn't be created until someone actually clicks the link, though. The page map name will need to go in the URL, but the page map can be lazy-created. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
