[jira] Updated: (WICKET-1172) FormComponentFeedbackIndicator and FormComponentFeedbackBorder is broken

2007-11-21 Thread Marat Radchenko (JIRA) 

 [ 
https://issues.apache.org/jira/browse/WICKET-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marat Radchenko updated WICKET-1172:


Attachment: IndicatorTest.java

Please find testcase in attached file.
There are two tests:
* testFixedVisible, which runs fixed FormComponentFeedBackIndicator (and passes)
* testVisible, which runs current FormComponentFeedBackIndicator (and fails)

> FormComponentFeedbackIndicator and FormComponentFeedbackBorder is broken
> 
>
> Key: WICKET-1172
> URL: https://issues.apache.org/jira/browse/WICKET-1172
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.3.0-rc1
>Reporter: Dmitry Rzhevskiy
>Assignee: Johan Compagner
>Priority: Critical
> Attachments: IndicatorTest.java
>
>
> FormComponentFeedbackIndicator is not work. FormComponentFeedbackIndicator  
> always invisible because:
> first render forms contain no errors, 
> method FormComponentFeedbackIndicator.onBeforeRender  (line 78)  sets 
> component invisible.
> onBeforeRender() not call for invisible components.
> workaround: override isVisible method :
>  @Override
>   public boolean isVisible() {
> return 
> Session.get().getFeedbackMessages().hasMessage(this.getFeedbackMessageFilter());
>   }
> method onBeforeRender don't need override in 
> org.apache.wicket.markup.html.form.validation.FormComponentFeedbackIndicator
> same situation with FormComponentFeedbackBorder .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-1172) FormComponentFeedbackIndicator and FormComponentFeedbackBorder is broken

2007-11-20 Thread Dmitry Rzhevskiy (JIRA) 

 [ 
https://issues.apache.org/jira/browse/WICKET-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dmitry Rzhevskiy updated WICKET-1172:
-

Description: 
FormComponentFeedbackIndicator is not work. FormComponentFeedbackIndicator  
always invisible because:
first render forms contain no errors, 
method FormComponentFeedbackIndicator.onBeforeRender  (line 78)  sets component 
invisible.
onBeforeRender() not call for invisible components.

workaround: override isVisible method :

 @Override
  public boolean isVisible() {
return 
Session.get().getFeedbackMessages().hasMessage(this.getFeedbackMessageFilter());
  }


method onBeforeRender don't need override in 
org.apache.wicket.markup.html.form.validation.FormComponentFeedbackIndicator

same situation with FormComponentFeedbackBorder .

  was:
FormComponentFeedbackIndicator is not work. FormComponentFeedbackIndicator  
always invisible because:
first render forms contain no errors, 
method FormComponentFeedbackIndicator.onBeforeRender  (line 78)  sets component 
invisible.
onBeforeRender() not call for invisible components.

workaround: override isVisible method :

 @Override
  public boolean isVisible() {
return 
Session.get().getFeedbackMessages().hasMessage(this.getFeedbackMessageFilter());
  }


method onBeforeRender don't need override in 
org.apache.wicket.markup.html.form.validation.FormComponentFeedbackIndicator


> FormComponentFeedbackIndicator and FormComponentFeedbackBorder is broken
> 
>
> Key: WICKET-1172
> URL: https://issues.apache.org/jira/browse/WICKET-1172
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.3.0-rc1
>Reporter: Dmitry Rzhevskiy
>Priority: Critical
>
> FormComponentFeedbackIndicator is not work. FormComponentFeedbackIndicator  
> always invisible because:
> first render forms contain no errors, 
> method FormComponentFeedbackIndicator.onBeforeRender  (line 78)  sets 
> component invisible.
> onBeforeRender() not call for invisible components.
> workaround: override isVisible method :
>  @Override
>   public boolean isVisible() {
> return 
> Session.get().getFeedbackMessages().hasMessage(this.getFeedbackMessageFilter());
>   }
> method onBeforeRender don't need override in 
> org.apache.wicket.markup.html.form.validation.FormComponentFeedbackIndicator
> same situation with FormComponentFeedbackBorder .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.