[jira] Updated: (WICKET-1419) GridView has a bug in findNext that prevents ReuseIfModelsEqualStrategy from working correctly

2008-03-12 Thread Ryan Dearing (JIRA) 

 [ 
https://issues.apache.org/jira/browse/WICKET-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ryan Dearing updated WICKET-1419:
-

Attachment: gridview-bug.tgz

quickstart project attached

 GridView has a bug in findNext that prevents ReuseIfModelsEqualStrategy from 
 working correctly
 --

 Key: WICKET-1419
 URL: https://issues.apache.org/jira/browse/WICKET-1419
 Project: Wicket
  Issue Type: Bug
Affects Versions: 1.3.1
Reporter: Ryan Dearing
Priority: Critical
 Attachments: gridview-bug.tgz


 the method findNext() in GridView.java has this code:
 if (cells != null  cells.hasNext())
 {
   next = (Item)cells.next();
 }
 but it should be:
 if (cells != null  cells.hasNext())
 {
   next = (Item)cells.next();
 return;
 }
 I have attached a quickstart project that will recreate the bug. When you hit 
 the toggle buggy link, the panel should maintain its state and you should 
 see the text toggle from false to true. As you can see, it works 
 correctly in the 1st column of panels, but the second column does not work.
 There is also a class called MyGridView in the attachment that fixes the 
 issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-1419) GridView has a bug in findNext that prevents ReuseIfModelsEqualStrategy from working correctly

2008-03-12 Thread Ryan Dearing (JIRA) 

 [ 
https://issues.apache.org/jira/browse/WICKET-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ryan Dearing updated WICKET-1419:
-

Attachment: MyGridView.java

fixed version of GridView... a one liner, the best kind.

 GridView has a bug in findNext that prevents ReuseIfModelsEqualStrategy from 
 working correctly
 --

 Key: WICKET-1419
 URL: https://issues.apache.org/jira/browse/WICKET-1419
 Project: Wicket
  Issue Type: Bug
Affects Versions: 1.3.1
Reporter: Ryan Dearing
Priority: Critical
 Attachments: gridview-bug.tgz, MyGridView.java


 the method findNext() in GridView.java has this code:
 if (cells != null  cells.hasNext())
 {
   next = (Item)cells.next();
 }
 but it should be:
 if (cells != null  cells.hasNext())
 {
   next = (Item)cells.next();
 return;
 }
 I have attached a quickstart project that will recreate the bug. When you hit 
 the toggle buggy link, the panel should maintain its state and you should 
 see the text toggle from false to true. As you can see, it works 
 correctly in the 1st column of panels, but the second column does not work.
 There is also a class called MyGridView in the attachment that fixes the 
 issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.